fastlane 2.28.9 → 2.29.0.beta.20170421010107

data/fastlane_core/lib/fastlane_core/ui/fastlane_runner.rb

@@ -103,22 +103,18 @@ module Commander
       FastlaneCore::UI.important("pilot crashed")
       FastlaneCore::UI.important("-------------")
       FastlaneCore::UI.error("Unfortunately the TestFlight update from 11th April 2017 changed")
-      FastlaneCore::UI.error("the way Testers, Groups, and Builds are managed on iTunesConnect.")
-      FastlaneCore::UI.error("We have already fixed a number of features including submitting")
-      FastlaneCore::UI.error("builds for testing, adding and removing testers from groups, and")
-      FastlaneCore::UI.error("waiting for builds to process.")
+      FastlaneCore::UI.error("the way Testers, Groups and Builds are managed on iTunes connect.")
+      FastlaneCore::UI.error("We're busy working on migrating _pilot_ to work with the new system")
+      FastlaneCore::UI.error("however it requires lots of changes and refactors from our side")
+      FastlaneCore::UI.error("to ensure that everything keeps working for you as it did before")
       FastlaneCore::UI.error("")
-      FastlaneCore::UI.error("Please open an issue on https://github.com/fastlane/fastlane/issues")
-      FastlaneCore::UI.error("if you believe this failure is the result of a bug in _pilot_ and we")
-      FastlaneCore::UI.error("will be happy to look into this further.")
-      FastlaneCore::UI.error("")
-      FastlaneCore::UI.error("Please stay tuned for more updates from _fastlane_ as we fix more issues!")
+      FastlaneCore::UI.error("Please follow the WIP pull request on GitHub to stay up to date: https://github.com/fastlane/fastlane/pull/8871")
       FastlaneCore::UI.error("")
+      FastlaneCore::UI.error("Original error message: #{e}")
       if FastlaneCore::Globals.verbose?
         raise e # on verbose mode, we want to show the original stack trace
       else
-        FastlaneCore::UI.error("Original error message:")
-        FastlaneCore::UI.user_error!(e.message)
+        FastlaneCore::UI.user_error!("pilot doesn't work with the latest TestFlight yet, we're busy working on upgrading it!")
       end
     end
 

data/fastlane_core/lib/fastlane_core/ui/github_issue_inspector_reporter.rb

@@ -45,8 +45,8 @@ module Fastlane
       status = (resolved ? issue.state.green : issue.state.red)
 
       puts "➡️  #{issue.title.yellow}"
-      puts "    #{issue.html_url} [#{status}] #{issue.comments} 💬"
-      puts "    #{Time.parse(issue.updated_at).to_pretty}"
+      puts "   #{issue.html_url} [#{status}] #{issue.comments} 💬"
+      puts "   #{Time.parse(issue.updated_at).to_pretty}"
       puts ""
     end
 

data/fastlane_core/lib/fastlane_core/ui/implementations/shell.rb

@@ -20,8 +20,6 @@ module FastlaneCore
         "#{format_string(datetime, severity)}#{msg}\n"
       end
 
-      require 'fastlane_core/ui/disable_colors' if FastlaneCore::Helper.colors_disabled?
-
       @log
     end
 

data/fastlane_core/lib/fastlane_core/ui/ui.rb

@@ -22,3 +22,5 @@ require 'fastlane_core/ui/interface'
 Dir[File.expand_path('implementations/*.rb', File.dirname(__FILE__))].each do |file|
   require file
 end
+
+require 'fastlane_core/ui/disable_colors' if FastlaneCore::Helper.colors_disabled?

data/gym/lib/gym/generators/build_command_generator.rb

@@ -41,7 +41,6 @@ module Gym
         options << "-derivedDataPath '#{config[:derived_data_path]}'" if config[:derived_data_path]
         options << "-resultBundlePath '#{result_bundle_path}'" if config[:result_bundle]
         options << config[:xcargs] if config[:xcargs]
-        options << "OTHER_SWIFT_FLAGS=\"\$(inherited) -Xfrontend -debug-time-function-bodies\"" if config[:analyze_build_time]
 
         options
       end
@@ -65,7 +64,6 @@ module Gym
       def pipe
         pipe = []
         pipe << "| tee #{xcodebuild_log_path.shellescape}"
-        pipe << "| grep .[0-9]ms | grep -v ^0.[0-9]ms | sort -nr > culprits.txt" if Gym.config[:analyze_build_time]
         unless Gym.config[:disable_xcpretty]
           formatter = Gym.config[:xcpretty_formatter]
           pipe << "| xcpretty"

data/gym/lib/gym/options.rb

@@ -100,11 +100,6 @@ module Gym
                                      env_name: "GYM_CODE_SIGNING_IDENTITY",
                                      description: "The name of the code signing identity to use. It has to match the name exactly. e.g. 'iPhone Distribution: SunApps GmbH'",
                                      optional: true),
-        FastlaneCore::ConfigItem.new(key: :skip_package_ipa,
-                                     env_name: "GYM_SKIP_PACKAGE_IPA",
-                                     description: "Should we skip packaging the ipa?",
-                                     is_string: false,
-                                     default_value: false),
         FastlaneCore::ConfigItem.new(key: :include_symbols,
                                      short_option: "-m",
                                      env_name: "GYM_INCLUDE_SYMBOLS",
@@ -277,11 +272,6 @@ module Gym
                                      verify_block: proc do |value|
                                        UI.user_error!("Report output location not found at path '#{File.expand_path(value)}'") unless File.exist?(value)
                                      end),
-        FastlaneCore::ConfigItem.new(key: :analyze_build_time,
-                                     env_name: "GYM_ANALYZE_BUILD_TIME",
-                                     description: "Analyze the project build time and store the output in culprits.txt file",
-                                     optional: true,
-                                     is_string: false),
         FastlaneCore::ConfigItem.new(key: :xcpretty_utf,
                                      env_name: "XCPRETTY_UTF",
                                      description: "Have xcpretty use unicode encoding when reporting builds",

data/gym/lib/gym/runner.rb

@@ -16,8 +16,6 @@ module Gym
 
       if Gym.project.ios? || Gym.project.tvos?
         fix_generic_archive # See https://github.com/fastlane/fastlane/pull/4325
-        return BuildCommandGenerator.archive_path if Gym.config[:skip_package_ipa]
-
         package_app
         fix_package
         compress_and_move_dsym

data/gym/lib/gym/xcode.rb

@@ -18,7 +18,9 @@ module Gym
       end
 
       def legacy_api_deprecated?
-        FastlaneCore::Helper.xcode_at_least?('8.3')
+        UI.user_error!("Unable to locate Xcode. Please make sure to have Xcode installed on your machine") if xcode_version.nil?
+        v = xcode_version
+        Gem::Version.new(v) >= Gem::Version.new('8.3.0')
       end
     end
   end

data/pilot/lib/pilot/build_manager.rb

@@ -37,38 +37,19 @@ module Pilot
       UI.message("If you want to skip waiting for the processing to be finished, use the `skip_waiting_for_build_processing` option")
       latest_build = FastlaneCore::BuildWatcher.wait_for_build_processing_to_be_complete(app_id: app.apple_id, platform: platform)
 
-      distribute(options, build: latest_build)
+      distribute(options, latest_build)
     end
 
-    def distribute(options, build: nil)
+    def distribute(options, build)
       start(options)
       if config[:apple_id].to_s.length == 0 and config[:app_identifier].to_s.length == 0
         config[:app_identifier] = UI.input("App Identifier: ")
       end
 
-      build ||= Spaceship::TestFlight::Build.latest(app_id: app.apple_id, platform: fetch_app_platform)
-      if build.nil?
-        UI.user_error!("No build to distribute!")
-      end
-
-      if should_update_app_test_information?(options)
-        app_test_info = Spaceship::TestFlight::AppTestInfo.find(app_id: build.app_id)
-        app_test_info.test_info.feedback_email = options[:beta_app_feedback_email] if options[:beta_app_feedback_email]
-        app_test_info.test_info.description = options[:beta_app_description] if options[:beta_app_description]
-        begin
-          app_test_info.save_for_app!(app_id: build.app_id)
-          UI.success "Successfully set the beta_app_feedback_email and/or beta_app_description"
-        rescue => ex
-          UI.user_error!("Could not set beta_app_feedback_email and/or beta_app_description: #{ex}")
-        end
-      end
-
-      if should_update_build_information?(options)
-        begin
-          build.update_build_information!(whats_new: options[:changelog])
-          UI.success "Successfully set the changelog for build"
-        rescue => ex
-          UI.user_error!("Could not set changelog: #{ex}")
+      unless config[:update_build_info_on_upload]
+        if should_update_build_information(options)
+          build.update_build_information!(whats_new: options[:changelog], description: options[:beta_app_description], feedback_email: options[:beta_app_feedback_email])
+          UI.success "Successfully set the changelog and/or description for build"
         end
       end
 
@@ -120,12 +101,8 @@ module Pilot
       return row
     end
 
-    def should_update_build_information?(options)
-      options[:changelog].to_s.length > 0
-    end
-
-    def should_update_app_test_information?(options)
-      options[:beta_app_description].to_s.length > 0 || options[:beta_app_feedback_email].to_s.length > 0
+    def should_update_build_information(options)
+      options[:changelog].to_s.length > 0 or options[:beta_app_description].to_s.length > 0 or options[:beta_app_feedback_email].to_s.length > 0
     end
 
     def distribute_build(uploaded_build, options)
@@ -133,10 +110,10 @@ module Pilot
 
       # This is where we could add a check to see if encryption is required and has been updated
       uploaded_build.export_compliance.encryption_updated = false
+      uploaded_build.beta_review_info.demo_account_required = false
+      uploaded_build.submit_for_testflight_review!
 
       if options[:distribute_external]
-        uploaded_build.beta_review_info.demo_account_required = false
-        uploaded_build.submit_for_testflight_review!
         external_group = Spaceship::TestFlight::Group.default_external_group(app_id: uploaded_build.app_id)
         uploaded_build.add_group!(external_group) unless external_group.nil?
 
@@ -144,18 +121,14 @@ module Pilot
           UI.user_error!("You must specify at least one group using the `:groups` option to distribute externally")
         end
 
-        if options[:groups]
-          groups = Spaceship::TestFlight::Group.filter_groups(app_id: uploaded_build.app_id) do |group|
-            options[:groups].include?(group.name)
-          end
-          groups.each do |group|
-            uploaded_build.add_group!(group)
-          end
+      end
+
+      if options[:groups]
+        groups = Group.filter_groups(app_id: uploaded_build.app_id) do |group|
+          options[:groups].include?(group.name)
         end
-      else # distribute internally
-        # in case any changes to export_compliance are required
-        if uploaded_build.export_compliance_missing?
-          uploaded_build.save!
+        groups.each do |group|
+          uploaded_build.add_group!(group)
         end
       end
 

data/pilot/lib/pilot/commands_generator.rb

@@ -29,8 +29,7 @@ module Pilot
         begin
           mgr.public_send(action, config)
         rescue => ex
-          # no need to show the email address in the message if only one specified
-          message = (args.count > 1) ? "[#{address}]: #{ex}" : ex
+          message = "[#{address}]: #{ex}"
           failures << message
           UI.error(message)
         end

data/pilot/lib/pilot/options.rb

@@ -32,7 +32,7 @@ module Pilot
                                      optional: true,
                                      env_name: "PILOT_IPA",
                                      description: "Path to the ipa file to upload",
-                                     default_value: Dir["*.ipa"].sort_by { |x| File.mtime(x) }.last,
+                                     default_value: Dir["*.ipa"].first,
                                      verify_block: proc do |value|
                                        UI.user_error!("Could not find ipa file at path '#{value}'") unless File.exist? value
                                        UI.user_error!("'#{value}' doesn't seem to be an ipa file") unless value.end_with? ".ipa"
@@ -65,10 +65,9 @@ module Pilot
                                      is_string: false,
                                      default_value: false),
         FastlaneCore::ConfigItem.new(key: :update_build_info_on_upload,
-                                     deprecated: true,
                                      short_option: "-x",
                                      env_name: "PILOT_UPDATE_BUILD_INFO_ON_UPLOAD",
-                                     description: "Update build info immediately after validation. This is deprecated and will be removed in a future release. iTunesConnect no longer supports setting build info until after build processing has completed, which is when build info is updated by default",
+                                     description: "Update build info immediately after validation. This will set the changelog even if PILOT_SKIP_SUBMISSION is set, but will have no effect if PILOT_SKIP_WAITING_FOR_BUILD_PROCESSING is set",
                                      is_string: false,
                                      default_value: false),
         FastlaneCore::ConfigItem.new(key: :apple_id,

data/pilot/lib/pilot/tester_manager.rb

@@ -7,21 +7,38 @@ module Pilot
     def add_tester(options)
       start(options)
 
-      app = find_app(app_filter: config[:apple_id] || config[:app_identifier])
-      UI.user_error!("You must provide either a Apple ID for the app (with the `:apple_id` option) or app identifier (with the `:app_identifier` option)") unless app
-
-      tester = find_or_create_tester(email: config[:email], first_name: config[:first_name], last_name: config[:last_name])
+      if config[:groups]
+        UI.important("Currently pilot doesn't support groups yet, we're working on restoring that functionality")
+        config[:groups] = nil
+      end
 
       begin
-        groups = Spaceship::TestFlight::Group.add_tester_to_groups!(tester: tester, app: app, groups: config[:groups])
-        if tester.kind_of?(Spaceship::Tunes::Tester::Internal)
-          UI.success("Successfully added tester to app #{app.name}")
+        tester = Spaceship::Tunes::Tester::Internal.find(config[:email])
+        tester ||= Spaceship::Tunes::Tester::External.find(config[:email])
+
+        if tester
+          UI.success("Existing tester #{tester.email}")
         else
-          group_names = groups.map(&:name).join(", ")
-          UI.success("Successfully added tester to app #{app.name} in group(s) #{group_names}")
+          tester = Spaceship::Tunes::Tester::External.create!(email: config[:email],
+                                                              first_name: config[:first_name],
+                                                              last_name: config[:last_name])
+          UI.success("Successfully invited tester: #{tester.email}")
+        end
+
+        app_filter = (config[:apple_id] || config[:app_identifier])
+        if app_filter
+          begin
+            app = Spaceship::Application.find(app_filter)
+            UI.user_error!("Couldn't find app with '#{app_filter}'") unless app
+            app.default_external_group.add_tester!(tester)
+            UI.success("Successfully added tester to app #{app_filter}")
+          rescue => ex
+            UI.error("Could not add #{tester.email} to app: #{ex}")
+            raise ex
+          end
         end
       rescue => ex
-        UI.error("Could not add #{tester.email} to app: #{app.name}")
+        UI.error("Could not create tester #{config[:email]}")
         raise ex
       end
     end
@@ -43,29 +60,25 @@ module Pilot
 
       tester = Spaceship::Tunes::Tester::External.find(config[:email])
       tester ||= Spaceship::Tunes::Tester::Internal.find(config[:email])
-      UI.user_error!("Tester not found: #{config[:email]}") if tester.nil?
-
-      app = find_app(app_filter: config[:apple_id] || config[:app_identifier])
-      unless app
-        tester.delete!
-        UI.success("Successfully removed tester #{tester.email}")
-      end
 
-      begin
-        # If no groups are passed to options, remove the tester from the app-level,
-        # otherwise remove the tester from the groups specified.
-        if config[:groups].nil? && tester.kind_of?(Spaceship::Tunes::Tester::External)
-          test_flight_tester = Spaceship::TestFlight::Tester.find(app_id: app.apple_id, email: tester.email)
-          test_flight_tester.remove_from_app!(app_id: app.apple_id)
-          UI.success("Successfully removed tester, #{test_flight_tester.email}, from app: #{app.name}")
+      if tester
+        app_filter = (config[:apple_id] || config[:app_identifier])
+        if app_filter
+          begin
+            app = Spaceship::Application.find(app_filter)
+            UI.user_error!("Couldn't find app with '#{app_filter}'") unless app
+            app.default_external_group.remove_tester!(tester)
+            UI.success("Successfully removed tester #{tester.email} from app #{app_filter}")
+          rescue => ex
+            UI.error("Could not remove #{tester.email} from app: #{ex}")
+            raise ex
+          end
         else
-          groups = Spaceship::TestFlight::Group.remove_tester_from_groups!(tester: tester, app: app, groups: config[:groups])
-          group_names = groups.map(&:name).join(", ")
-          UI.success("Successfully removed tester #{tester.email} from app #{app.name} in group(s) #{group_names}")
+          tester.delete!
+          UI.success("Successfully removed tester #{tester.email}")
         end
-      rescue => ex
-        UI.error("Could not remove #{tester.email} from app: #{ex}")
-        raise ex
+      else
+        UI.error("Tester not found: #{config[:email]}")
       end
     end
 
@@ -80,34 +93,7 @@ module Pilot
       end
     end
 
-    private
-
-    def find_app(app_filter: nil)
-      if app_filter
-        app = Spaceship::Application.find(app_filter)
-        UI.user_error!("Could not find an app by #{app_filter}") unless app
-        return app
-      end
-      nil
-    end
-
-    def find_or_create_tester(email: nil, first_name: nil, last_name: nil)
-      tester = Spaceship::Tunes::Tester::Internal.find(config[:email])
-      tester ||= Spaceship::Tunes::Tester::External.find(config[:email])
-
-      if tester
-        UI.success("Existing tester #{tester.email}")
-      else
-        tester = Spaceship::Tunes::Tester::External.create!(email: config[:email],
-                                                            first_name: config[:first_name],
-                                                            last_name: config[:last_name])
-        UI.success("Successfully added tester: #{tester.email} to your account")
-      end
-      return tester
-    rescue => ex
-      UI.error("Could not create tester #{config[:email]}")
-      raise ex
-    end
+    # private
 
     def list_testers_by_app(app_filter)
       app = Spaceship::Application.find(app_filter)

data/snapshot/lib/assets/SnapshotHelper.swift

@@ -145,7 +145,7 @@ open class Snapshot: NSObject {
                 print("Can't prepare environment. Simulator home location is inaccessible. Does \(simulatorHostHome) exist?")
                 return nil
             }
-            homeDir = URL(fileURLWithPath: homeDirUrl.path)
+            homeDir = homeDirUrl
         #endif
         return homeDir.appendingPathComponent("Library/Caches/tools.fastlane")
     }

data/spaceship/lib/spaceship/spaceauth_runner.rb

@@ -22,7 +22,7 @@ module Spaceship
         puts "This could be an issue with iTunes Connect,".yellow
         puts "Please try unsetting the FASTLANE_SESSION environment variable".yellow
         puts "and re-run `fastlane spaceauth`".yellow
-        raise "Problem connecting to iTunes Connect"
+        UI.crash!("Problem connecting to iTunes Connect")
       end
 
       itc_cookie_content = Spaceship::Tunes.client.store_cookie

data/spaceship/lib/spaceship/test_flight.rb

@@ -1,11 +1,9 @@
 
 require 'spaceship/test_flight/client'
 require 'spaceship/test_flight/base'
-require 'spaceship/test_flight/app_test_info'
 require 'spaceship/test_flight/build'
 require 'spaceship/test_flight/build_trains'
 require 'spaceship/test_flight/beta_review_info'
 require 'spaceship/test_flight/export_compliance'
 require 'spaceship/test_flight/test_info'
 require 'spaceship/test_flight/group'
-require 'spaceship/test_flight/tester'

data/spaceship/lib/spaceship/test_flight/base.rb

@@ -4,18 +4,6 @@ module Spaceship::TestFlight
       @client ||= Client.client_with_authorization_from(Spaceship::Tunes.client)
     end
 
-    ##
-    # Have subclasses inherit the client from their superclass
-    #
-    # Essentially, we are making a class-inheritable-accessor as described here:
-    # https://apidock.com/rails/v4.2.7/Class/class_attribute
-    def self.inherited(subclass)
-      this_class = self
-      subclass.define_singleton_method(:client) do
-        this_class.client
-      end
-    end
-
     def to_json
       raw_data.to_json
     end

data/spaceship/lib/spaceship/test_flight/build.rb

@@ -67,17 +67,16 @@ module Spaceship::TestFlight
     BUILD_STATES = {
       processing: 'testflight.build.state.processing',
       active: 'testflight.build.state.testing.active',
-      ready_to_submit: 'testflight.build.state.submit.ready',
-      ready_to_test: 'testflight.build.state.testing.ready',
+      ready: 'testflight.build.state.submit.ready',
       export_compliance_missing: 'testflight.build.state.export.compliance.missing'
     }
 
-    # Find a Build by `build_id`.
+    # Find a Build by `build_id`. Returns `nil` if can't find it.
     #
     # @return (Spaceship::TestFlight::Build)
     def self.find(app_id: nil, build_id: nil)
       attrs = client.get_build(app_id: app_id, build_id: build_id)
-      self.new(attrs)
+      self.new(attrs) if attrs
     end
 
     def self.all(app_id: nil, platform: nil)
@@ -105,17 +104,13 @@ module Spaceship::TestFlight
     #
     # Note: this will overwrite any non-saved changes to the object
     #
-    # @return (Spaceship::Base::DataHash) the raw_data of the build.
+    # @return (Spaceceship::Base::DataHash) the raw_data of the build.
     def reload
       self.raw_data = self.class.find(app_id: app_id, build_id: id).raw_data
     end
 
     def ready_to_submit?
-      external_state == BUILD_STATES[:ready_to_submit]
-    end
-
-    def ready_to_test?
-      external_state == BUILD_STATES[:ready_to_test]
+      external_state == BUILD_STATES[:ready]
     end
 
     def active?
@@ -126,14 +121,6 @@ module Spaceship::TestFlight
       external_state == BUILD_STATES[:processing]
     end
 
-    def export_compliance_missing?
-      external_state == BUILD_STATES[:export_compliance_missing]
-    end
-
-    def processed?
-      active? || ready_to_submit? || export_compliance_missing?
-    end
-
     # Getting builds from BuildTrains only gets a partial Build object
     # We are then requesting the full build from iTC when we need to access
     # any of the variables below, because they are not inlcuded in the partial Build objects
@@ -168,14 +155,13 @@ module Spaceship::TestFlight
     end
 
     def update_build_information!(description: nil, feedback_email: nil, whats_new: nil)
-      test_info.description = description if description
-      test_info.feedback_email = feedback_email if feedback_email
-      test_info.whats_new = whats_new if whats_new
+      test_info.description = description
+      test_info.feedback_email = feedback_email
+      test_info.whats_new = whats_new
       save!
     end
 
     def submit_for_testflight_review!
-      return if ready_to_test?
       client.post_for_testflight_review(app_id: app_id, build_id: id, build: self)
     end