fastlane 2.28.9 → 2.29.0.beta.20170421010107

data/spaceship/lib/spaceship/test_flight/client.rb

@@ -1,126 +1,34 @@
 module Spaceship::TestFlight
   class Client < Spaceship::Client
-    ##
-    # Spaceship HTTP client for the testflight API.
-    #
-    # This client is solely responsible for the making HTTP requests and
-    # parsing their responses. Parameters should be either named parameters, or
-    # for large request data bodies, pass in anything that can resond to
-    # `to_json`.
-    #
-    # Each request method should validate the required parameters. A required parameter is one that would result in 400-range response if it is not supplied.
-    # Each request method should make only one request. For more high-level logic, put code in the data models.
-
     def self.hostname
       'https://itunesconnect.apple.com/testflight/v2/'
     end
 
-    ##
-    # @!group Build trains API
-    ##
-
     # Returns an array of all available build trains (not the builds they include)
-    def get_build_trains(app_id: nil, platform: "ios")
+    def get_build_trains(app_id: nil, platform: nil)
       assert_required_params(__method__, binding)
-
+      platform ||= "ios"
       response = request(:get, "providers/#{team_id}/apps/#{app_id}/platforms/#{platform}/trains")
       handle_response(response)
     end
 
-    def get_builds_for_train(app_id: nil, platform: "ios", train_version: nil)
+    def get_builds_for_train(app_id: nil, platform: nil, train_version: nil)
       assert_required_params(__method__, binding)
+      platform ||= "ios"
 
       response = request(:get, "providers/#{team_id}/apps/#{app_id}/platforms/#{platform}/trains/#{train_version}/builds")
       handle_response(response)
     end
 
-    ##
-    # @!group Builds API
-    ##
-
-    def get_build(app_id: nil, build_id: nil)
-      assert_required_params(__method__, binding)
-
-      response = request(:get, "providers/#{team_id}/apps/#{app_id}/builds/#{build_id}")
-      handle_response(response)
-    end
-
-    def put_build(app_id: nil, build_id: nil, build: nil)
-      assert_required_params(__method__, binding)
-
-      response = request(:put) do |req|
-        req.url "providers/#{team_id}/apps/#{app_id}/builds/#{build_id}"
-        req.body = build.to_json
-        req.headers['Content-Type'] = 'application/json'
-      end
-      handle_response(response)
-    end
-
-    def post_for_testflight_review(app_id: nil, build_id: nil, build: nil)
-      assert_required_params(__method__, binding)
-
-      response = request(:post) do |req|
-        req.url "providers/#{team_id}/apps/#{app_id}/builds/#{build_id}/review"
-        req.body = build.to_json
-        req.headers['Content-Type'] = 'application/json'
-      end
-      handle_response(response)
-    end
-
-    ##
-    # @!group Groups API
-    ##
-
-    def get_groups(app_id: nil)
-      assert_required_params(__method__, binding)
-
-      response = request(:get, "/testflight/v2/providers/#{team_id}/apps/#{app_id}/groups")
-      handle_response(response)
-    end
-
-    def add_group_to_build(app_id: nil, group_id: nil, build_id: nil)
-      assert_required_params(__method__, binding)
-
-      body = {
-        'groupId' => group_id,
-        'buildId' => build_id
-      }
-      response = request(:put) do |req|
-        req.url "providers/#{team_id}/apps/#{app_id}/groups/#{group_id}/builds/#{build_id}"
-        req.body = body.to_json
-        req.headers['Content-Type'] = 'application/json'
-      end
-      handle_response(response)
-    end
-
-    ##
-    # @!group Testers API
-    ##
-
-    def testers_for_app(app_id: nil)
-      assert_required_params(__method__, binding)
-      url = "providers/#{team_id}/apps/#{app_id}/testers?limit=10000"
-      response = request(:get, url)
-      handle_response(response)
-    end
-
-    def delete_tester_from_app(app_id: nil, tester_id: nil)
-      assert_required_params(__method__, binding)
-      url = "providers/#{team_id}/apps/#{app_id}/testers/#{tester_id}"
-      response = request(:delete, url)
-      handle_response(response)
-    end
-
     def post_tester(app_id: nil, tester: nil)
       assert_required_params(__method__, binding)
-
       url = "providers/#{team_id}/apps/#{app_id}/testers"
       response = request(:post) do |req|
         req.url url
         req.body = {
           "email" => tester.email,
-          "firstName" => tester.first_name,
-          "lastName" => tester.last_name
+          "firstName" => tester.last_name,
+          "lastName" => tester.first_name
         }.to_json
         req.headers['Content-Type'] = 'application/json'
       end
@@ -129,7 +37,6 @@ module Spaceship::TestFlight
 
     def put_tester_to_group(app_id: nil, tester_id: nil, group_id: nil)
       assert_required_params(__method__, binding)
-
       # Then we can add the tester to the group that allows the app to test
       # This is easy enough, we already have all this data. We don't need any response from the previous request
       url = "providers/#{team_id}/apps/#{app_id}/groups/#{group_id}/testers/#{tester_id}"
@@ -146,7 +53,6 @@ module Spaceship::TestFlight
 
     def delete_tester_from_group(group_id: nil, tester_id: nil, app_id: nil)
       assert_required_params(__method__, binding)
-
       url = "providers/#{team_id}/apps/#{app_id}/groups/#{group_id}/testers/#{tester_id}"
       response = request(:delete) do |req|
         req.url url
@@ -155,32 +61,53 @@ module Spaceship::TestFlight
       handle_response(response)
     end
 
-    ##
-    # @!group AppTestInfo
-    ##
+    def get_build(app_id: nil, build_id: nil)
+      assert_required_params(__method__, binding)
+      response = request(:get, "providers/#{team_id}/apps/#{app_id}/builds/#{build_id}")
+      handle_response(response)
+    end
 
-    def get_app_test_info(app_id: nil)
+    def put_build(app_id: nil, build_id: nil, build: nil)
       assert_required_params(__method__, binding)
+      response = request(:put) do |req|
+        req.url "providers/#{team_id}/apps/#{app_id}/builds/#{build_id}"
+        req.body = build.to_json
+        req.headers['Content-Type'] = 'application/json'
+      end
+      handle_response(response)
+    end
 
-      response = request(:get, "providers/#{team_id}/apps/#{app_id}/testInfo")
+    def post_for_testflight_review(app_id: nil, build_id: nil, build: nil)
+      assert_required_params(__method__, binding)
+      response = request(:post) do |req|
+        req.url "providers/#{team_id}/apps/#{app_id}/builds/#{build_id}/review"
+        req.body = build.to_json
+        req.headers['Content-Type'] = 'application/json'
+      end
       handle_response(response)
     end
 
-    def put_app_test_info(app_id: nil, app_test_info: nil)
+    def get_groups(app_id: nil)
       assert_required_params(__method__, binding)
+      response = request(:get, "/testflight/v2/providers/#{team_id}/apps/#{app_id}/groups")
+      handle_response(response)
+    end
 
+    def add_group_to_build(app_id: nil, group_id: nil, build_id: nil)
+      body = {
+        'groupId' => group_id,
+        'buildId' => build_id
+      }
       response = request(:put) do |req|
-        req.url "providers/#{team_id}/apps/#{app_id}/testInfo"
-        req.body = app_test_info.to_json
+        req.url "providers/#{team_id}/apps/#{app_id}/groups/#{group_id}/builds/#{build_id}"
+        req.body = body.to_json
         req.headers['Content-Type'] = 'application/json'
       end
       handle_response(response)
     end
 
-    protected
-
     def handle_response(response)
-      if (200...300).cover?(response.status) && (response.body.nil? || response.body.empty?)
+      if (200..300).cover?(response.status) && response.body.empty?
         return
       end
 
@@ -201,20 +128,12 @@ module Spaceship::TestFlight
     #
     # @raises NameError if the values are nil
     def assert_required_params(method_name, binding)
-      parameter_names = method(method_name).parameters.map { |k, v| v }
+      parameter_names = Hash[method(method_name).parameters].values
       parameter_names.each do |name|
-        if local_variable_get(binding, name).nil?
+        if binding.local_variable_get(name).nil?
           raise NameError, "`#{name}' is a required parameter"
         end
       end
     end
-
-    def local_variable_get(binding, name)
-      if binding.respond_to?(:local_variable_get)
-        binding.local_variable_get(name)
-      else
-        binding.eval(name.to_s)
-      end
-    end
   end
 end

data/spaceship/lib/spaceship/test_flight/group.rb

@@ -3,21 +3,22 @@ module Spaceship::TestFlight
     attr_accessor :id
     attr_accessor :name
     attr_accessor :is_default_external_group
-    attr_accessor :is_internal_group
 
     attr_accessor :app_id
 
     attr_mapping({
       'id' => :id,
       'name' => :name,
-      'isInternalGroup' => :is_internal_group,
-      'appAdamId' => :app_id,
       'isDefaultExternalGroup' => :is_default_external_group
     })
 
     def self.all(app_id: nil)
       groups = client.get_groups(app_id: app_id)
-      groups.map { |g| self.new(g) }
+      groups.map do |g|
+        current_element = self.new(g)
+        current_element.app_id = app_id
+        current_element
+      end
     end
 
     def self.find(app_id: nil, group_name: nil)
@@ -35,11 +36,6 @@ module Spaceship::TestFlight
       groups.select(&block)
     end
 
-    def self.internal_group(app_id: nil)
-      groups = self.all(app_id: app_id)
-      groups.find(&:internal_group?)
-    end
-
     # First we need to add the tester to the app
     # It's ok if the tester already exists, we just have to do this... don't ask
     # This will enable testing for the tester for a given app, as just creating the tester on an account-level
@@ -47,55 +43,17 @@ module Spaceship::TestFlight
     # This is a bug we reported to the iTunes Connect team, as it also happens on the iTunes Connect UI on 18. April 2017
     def add_tester!(tester)
       # This post request makes the account-level tester available to the app
-      tester_data = client.post_tester(app_id: self.app_id, tester: tester)
+      client.post_tester(app_id: self.app_id, tester: tester)
       # This put request adds the tester to the group
-      client.put_tester_to_group(group_id: self.id, tester_id: tester_data['id'], app_id: self.app_id)
+      client.put_tester_to_group(group_id: self.id, tester_id: tester.tester_id, app_id: self.app_id)
     end
 
     def remove_tester!(tester)
       client.delete_tester_from_group(group_id: self.id, tester_id: tester.tester_id, app_id: self.app_id)
     end
 
-    def self.add_tester_to_groups!(tester: nil, app: nil, groups: nil)
-      if tester.kind_of?(Spaceship::Tunes::Tester::Internal)
-        self.internal_group(app_id: app.apple_id).add_tester!(tester)
-      else
-        self.perform_for_groups_in_app(app: app, groups: groups) { |group| group.add_tester!(tester) }
-      end
-    end
-
-    def self.remove_tester_from_groups!(tester: nil, app: nil, groups: nil)
-      if tester.kind_of?(Spaceship::Tunes::Tester::Internal)
-        self.internal_group(app_id: app.apple_id).remove_tester!(tester)
-      else
-        self.perform_for_groups_in_app(app: app, groups: groups) { |group| group.remove_tester!(tester) }
-      end
-    end
-
     def default_external_group?
       is_default_external_group
     end
-
-    def internal_group?
-      is_internal_group
-    end
-
-    def self.perform_for_groups_in_app(app: nil, groups: nil, &block)
-      if groups.nil?
-        default_external_group = app.default_external_group
-        if default_external_group.nil?
-          raise "The app #{app.name} does not have a default external group. Please make sure to pass group names to the `:groups` option."
-        end
-        test_flight_groups = [default_external_group]
-      else
-        test_flight_groups = self.filter_groups(app_id: app.apple_id) do |group|
-          groups.include?(group.name)
-        end
-
-        raise "There are no groups available matching the names passed to the `:groups` option." if test_flight_groups.empty?
-      end
-
-      test_flight_groups.each(&block)
-    end
   end
 end

data/spaceship/lib/spaceship/test_flight/test_info.rb

@@ -30,9 +30,5 @@ module Spaceship::TestFlight
     def whats_new=(value)
       raw_data.each { |locale| locale['whatsNew'] = value }
     end
-
-    def deep_copy
-      TestInfo.new(raw_data.map(&:dup))
-    end
   end
 end

data/spaceship/lib/spaceship/tunes/app_ratings.rb

@@ -47,81 +47,9 @@ module Spaceship
         instance_variable_set(:@store_fronts, unfolded_store_fronts)
       end
 
-      # @return (Array) of Review Objects
+      # @return (Array) of raw hashes representing user reviews for the given store front (and optional versionId)
       def reviews(store_front, versionId = '')
-        raw_reviews = client.get_reviews(application.apple_id, application.platform, store_front, versionId)
-        raw_reviews.map do |review|
-          review["value"]["application"] = self.application
-          AppReview.factory(review["value"])
-        end
-      end
-    end
-
-    class DeveloperResponse < TunesBase
-      attr_reader :id
-      attr_reader :response
-      attr_reader :last_modified
-      attr_reader :hidden
-      attr_reader :state
-      attr_accessor :application
-      attr_accessor :review_id
-
-      attr_mapping({
-        'responseId' => :id,
-        'response' => :response,
-        'lastModified' => :last_modified,
-        'isHidden' => :hidden,
-        'pendingState' => :state
-      })
-    end
-
-    class AppReview < TunesBase
-      attr_accessor :application
-      attr_reader :rating
-      attr_reader :id
-      attr_reader :title
-      attr_reader :review
-      attr_reader :nickname
-      attr_reader :store_front
-      attr_reader :app_version
-      attr_reader :last_modified
-      attr_reader :helpful_views
-      attr_reader :total_views
-      attr_reader :edited
-      attr_reader :raw_developer_response
-      attr_accessor :developer_response
-
-      attr_mapping({
-        'id' => :id,
-        'rating' => :rating,
-        'title' => :title,
-        'review' => :review,
-        'nickname' => :nickname,
-        'storeFront' => :store_front,
-        'appVersionString' => :app_version,
-        'lastModified' => :last_modified,
-        'helpfulViews' => :helpful_views,
-        'totalViews' => :total_views,
-        'developerResponse' => :raw_developer_response,
-        'edited' => :edited
-      })
-      class << self
-        # Create a new object based on a hash.
-        # This is used to create a new object based on the server response.
-        def factory(attrs)
-          obj = self.new(attrs)
-          response_attrs = {}
-          response_attrs = obj.raw_developer_response if obj.raw_developer_response
-          response_attrs[:application] = obj.application
-          response_attrs[:review_id] = obj.id
-          obj.developer_response = DeveloperResponse.factory(response_attrs)
-          return obj
-        end
-      end
-
-      def responded?
-        return true if raw_developer_response
-        false
+        client.get_reviews(application.apple_id, application.platform, store_front, versionId)
       end
     end
 

data/spaceship/lib/spaceship/tunes/app_status.rb

@@ -33,7 +33,7 @@ module Spaceship
       PROCESSING_FOR_APP_STORE = "Processing for App Store"
       # WAITING_FOR_EXPORT_COMPLIANCE = "Waiting For Export Compliance"
       METADATA_REJECTED = "Metadata Rejected"
-      REMOVED_FROM_SALE = "Removed From Sale"
+      # REMOVED_FROM_SALE = "Removed From Sale"
       # INVALID_BINARY = "Invalid Binary"
 
       # Get the app status matching based on a string (given by iTunes Connect)
@@ -46,10 +46,8 @@ module Spaceship
           'developerRemovedFromSale' => DEVELOPER_REMOVED_FROM_SALE,
           'waitingForReview' => WAITING_FOR_REVIEW,
           'inReview' => IN_REVIEW,
-          'rejected' => REJECTED,
           'pendingDeveloperRelease' => PENDING_DEVELOPER_RELEASE,
-          'metadataRejected' => METADATA_REJECTED,
-          'removedFromSale' => REMOVED_FROM_SALE
+          'metadataRejected' => METADATA_REJECTED
         }
 
         mapping.each do |k, v|

data/spaceship/lib/spaceship/tunes/application.rb

@@ -78,7 +78,7 @@ module Spaceship
         #  should it be an ios or an osx app
 
         def create!(name: nil, primary_language: nil, version: nil, sku: nil, bundle_id: nil, bundle_id_suffix: nil, company_name: nil, platform: nil)
-          puts "The `version` parameter is deprecated. Use `ensure_version!` method instead" if version
+          UI.deprecated("The `version` parameter is deprecated. Use `ensure_version!` method instead") if version
           client.create_application!(name: name,
                          primary_language: primary_language,
                                       sku: sku,