fastlane 1.20.0 → 1.21.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 913ddd5a293edd301b1fb0bd00a25ce696c269ae
-  data.tar.gz: 59515f32a74f1904fb5924641f9de68bb57e78ac
+  metadata.gz: a3688edd276635af01ff6dbde0e3ec6786ab5536
+  data.tar.gz: ad234477739a849996fff29f8a193095fae7eea3
 SHA512:
-  metadata.gz: 8f53818436dc2576d69b8ee534456000f0e4ac0223f03e29656c519805fc11d928d72e410586fdb26380e08a7417627e44d03513277fe3e443f5c0deefc649a5
-  data.tar.gz: 4dbdc3c618022ac5348f60eb2d322db087db3acae0744ccbf24dce927514ca00caddd0ef367958ac39a1ddca470b32dcf9c256c64060fb540916d435ae01af69
+  metadata.gz: 99d5d48ba2a9107b87dcfcd571b3ec0a4580976685c0a45ecbed9039fde34840aaa90e13590e2fa0f619576088f350995f1f440d40b116fee916bde2bbad31d7
+  data.tar.gz: e0941d32fdbf8236d06098f8672fb073260e85adad502adc52a8a505260cfc38795d3e712700c3e01b5f65cc75c17f8283a54d2e8771d373d2e45138cab25ee7

data/bin/fastlane

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# rubocop:disable Metrics/AbcSize
 
 $LOAD_PATH.push File.expand_path('../../lib', __FILE__)
 
@@ -22,17 +23,15 @@ class FastlaneApplication
     program :help, 'GitHub', 'https://github.com/krausefx/fastlane'
     program :help_formatter, :compact
 
-    always_trace!
-
     command :run do |c|
       c.syntax = 'fastlane run [lane]'
       c.description = 'Drive the fastlane for a specific environment. Pass the lane name and optionally the platform first'
       c.option '--env STRING', String, 'Add environment to use with `dotenv`'
 
-      c.action do |args, _options|
+      c.action do |args, options|
         if Fastlane::FastlaneFolder.path
 
-          Fastlane::CommandLineHandler.handle(args, _options)
+          Fastlane::CommandLineHandler.handle(args, options)
         else
           create = agree('Could not find fastlane in current directory. Would you like to set it up? (y/n)'.yellow, true)
           Fastlane::Setup.new.run if create
@@ -44,7 +43,7 @@ class FastlaneApplication
       c.syntax = 'fastlane init'
       c.description = 'Helps you setting up fastlane based on your existing tools.'
 
-      c.action do |_args, _options|
+      c.action do |args, options|
         Fastlane::Setup.new.run
       end
     end
@@ -53,7 +52,7 @@ class FastlaneApplication
       c.syntax = 'fastlane new_action'
       c.description = 'Create a new custom action for fastlane.'
 
-      c.action do |_args, _options|
+      c.action do |args, options|
         Fastlane::NewAction.run
       end
     end
@@ -62,7 +61,7 @@ class FastlaneApplication
       c.syntax = 'fastlane lanes'
       c.description = 'Lists all available lanes and shows their description'
 
-      c.action do |_args, _options|
+      c.action do |args, options|
         require 'fastlane/lane_list'
         path = File.join(Fastlane::FastlaneFolder.path || '.', 'Fastfile')
         Fastlane::LaneList.output(path)
@@ -72,7 +71,7 @@ class FastlaneApplication
     command :list do |c|
       c.syntax = 'fastlane list'
       c.description = 'Lists all available lanes without description'
-      c.action do |_args, _options|
+      c.action do |args, options|
         ff = Fastlane::FastFile.new(File.join(Fastlane::FastlaneFolder.path || '.', 'Fastfile'))
         puts "\nAvailable lanes:".green
         ff.runner.available_lanes.each do |lane|
@@ -87,10 +86,10 @@ class FastlaneApplication
       c.description = 'Generate a markdown based documentation based on the Fastfile'
       c.option '-f', '--force', 'Overwrite the existing README.md in the ./fastlane folder'
 
-      c.action do |_args, _options|
+      c.action do |args, options|
         path = File.join(Fastlane::FastlaneFolder.path || '.', 'README.md')
-        if File.exists?path and not _options.force
-          return unless agree('Found existing ./fastlane/README.md. Do you want to overwrite it? (y/n)', true)
+        if File.exist? path and !options.force
+          return nil unless agree('Found existing ./fastlane/README.md. Do you want to overwrite it? (y/n)', true)
         end
 
         ff = Fastlane::FastFile.new(File.join(Fastlane::FastlaneFolder.path || '.', 'Fastfile'))
@@ -104,18 +103,18 @@ class FastlaneApplication
       c.syntax = 'fastlane actions'
       c.description = 'Lists all available fastlane actions'
 
-      c.action do |_args, _options|
+      c.action do |args, options|
         require 'fastlane/actions_list'
-        Fastlane::ActionsList.run(_args.first)
+        Fastlane::ActionsList.run(args.first)
       end
     end
 
     command :action do |c|
       c.syntax = 'fastlane action [tool_name]'
       c.description = 'Shows more information for a specific command'
-      c.action do |_args, _options|
+      c.action do |args, options|
         require 'fastlane/actions_list'
-        Fastlane::ActionsList.run(_args.first)
+        Fastlane::ActionsList.run(args.first)
       end
     end
 
@@ -130,4 +129,5 @@ begin
   FastlaneApplication.new.run
 ensure
   FastlaneCore::UpdateChecker.show_update_status('fastlane', Fastlane::VERSION)
-end
+end
+# rubocop:enable Metrics/AbcSize

data/lib/assets/custom_action_template.rb

@@ -44,7 +44,7 @@ module Fastlane
           FastlaneCore::ConfigItem.new(key: :api_token,
                                        env_name: "FL_[[NAME_UP]]_API_TOKEN", # The name of the environment variable
                                        description: "API Token for [[NAME_CLASS]]", # a short description of this parameter
-                                       verify_block: Proc.new do |value|
+                                       verify_block: proc do |value|
                                           raise "No API token for [[NAME_CLASS]] given, pass using `api_token: 'token'`".red unless (value and not value.empty?)
                                        end),
           FastlaneCore::ConfigItem.new(key: :development,
@@ -75,7 +75,7 @@ module Fastlane
         # 
         #  platform == :ios
         # 
-        #  [:ios, :mac].include?platform
+        #  [:ios, :mac].include? platform
         # 
 
         platform == :ios

data/lib/fastlane.rb

@@ -21,6 +21,7 @@ module Fastlane
   Helper = FastlaneCore::Helper # you gotta love Ruby: Helper.* should use the Helper class contained in FastlaneCore
 
   Fastlane::Actions.load_default_actions
+  Fastlane::Actions.load_helpers
 
   if Fastlane::FastlaneFolder.path
     actions_path = File.join(Fastlane::FastlaneFolder.path, 'actions')

data/lib/fastlane/action.rb

@@ -3,7 +3,6 @@ require 'fastlane/actions/actions_helper'
 module Fastlane
   class Action
     def self.run(params)
-      
     end
 
     # Implement in subclasses
@@ -44,11 +43,11 @@ module Fastlane
     def self.is_supported?(platform)
       # you can do things like
       #  true
-      # 
+      #
       #  platform == :ios
-      # 
-      #  [:ios, :android].include?platform
-      # 
+      #
+      #  [:ios, :android].include? platform
+      #
       raise "Implementing `is_supported?` for all actions is mandatory. Please update #{self}".red
     end
 
@@ -68,4 +67,4 @@ module Fastlane
       self.name.split('::').last.gsub('Action', '').fastlane_underscore
     end
   end
-end
+end

data/lib/fastlane/action_collector.rb

@@ -32,9 +32,9 @@ module Fastlane
           require 'excon'
           url = HOST_URL + '/did_launch?'
           url += URI.encode_www_form(
-                  steps: launches.to_json,
-                  error: @error
-                )
+            steps: launches.to_json,
+            error: @error
+          )
 
           unless Helper.is_test? # don't send test data
             fork do
@@ -57,15 +57,15 @@ module Fastlane
 
     def is_official?(name)
       return true if name == :lane_switch
-      Actions.get_all_official_actions.include?name
+      Actions.get_all_official_actions.include? name
     end
 
     def did_show_message?
       path = File.join(File.expand_path('~'), '.did_show_opt_info')
 
-      did_show = File.exists?path
+      did_show = File.exist? path
       File.write(path, '1')
       did_show
     end
   end
-end
+end

data/lib/fastlane/actions/actions_helper.rb

@@ -8,31 +8,6 @@ module Fastlane
       ENVIRONMENT = :ENVIRONMENT
     end
 
-    # Helper Methods
-    def self.git_author
-      s = `git log --name-status HEAD^..HEAD`
-      s = s.match(/Author:.*<(.*)>/)[1]
-      return s if s.to_s.length > 0
-      return nil
-    rescue
-      return nil
-    end
-
-    def self.last_git_commit
-      s = `git log -1 --pretty=%B`.strip
-      return s if s.to_s.length > 0
-      nil
-    end
-
-    # Returns the current git branch - can be replaced using the environment variable `GIT_BRANCH`
-    def self.git_branch
-      return ENV['GIT_BRANCH'] if ENV['GIT_BRANCH'].to_s.length > 0 # set by Jenkins
-      s = `git rev-parse --abbrev-ref HEAD`
-      return s.to_s.strip if s.to_s.length > 0
-      nil
-    end
-
-
     def self.executed_actions
       @executed_actions ||= []
     end
@@ -79,60 +54,24 @@ module Fastlane
       raise exc if exc
     end
 
-    # Execute a shell command
-    # This method will output the string and execute it
-    # Just an alias for sh_no_action
-    # @param log [boolean] should fastlane print out the executed command
-    def self.sh(command, log: true)
-      sh_no_action(command, log: log)
-    end
-
-    def self.sh_no_action(command, log: true)
-      # Set the encoding first, the user might have set it wrong
-      previous_encoding = [Encoding.default_external, Encoding.default_internal]
-      Encoding.default_external = Encoding::UTF_8
-      Encoding.default_internal = Encoding::UTF_8
-
-      command = command.join(' ') if command.is_a?(Array) # since it's an array of one element when running from the Fastfile
-      Helper.log.info ['[SHELL COMMAND]', command.yellow].join(': ') if log
-
-      result = ''
-      unless Helper.test?
-        exit_status = nil
-        status = IO.popen(command, err: [:child, :out]) do |io|
-          io.each do |line|
-            Helper.log.info ['[SHELL]', line.strip].join(': ')
-            result << line
-          end
-          io.close
-          exit_status = $?.exitstatus
-        end
-
-        if exit_status != 0
-          # this will also append the output to the exception
-          raise "Exit status of command '#{command}' was #{exit_status} instead of 0. \n#{result}"
-        end
-      else
-        result << command # only for the tests
-      end
-
-      result
-    rescue => ex
-      raise ex
-    ensure
-      Encoding.default_external = previous_encoding.first
-      Encoding.default_internal = previous_encoding.last
-    end
-
     # returns a list of official integrations
+    # rubocop:disable Style/AccessorMethodName
     def self.get_all_official_actions
-      Dir[File.expand_path '*.rb', File.dirname(__FILE__)].collect do |file|
+      Dir[File.expand_path('*.rb', File.dirname(__FILE__))].collect do |file|
         File.basename(file).gsub('.rb', '').to_sym
       end
     end
+    # rubocop:enable Style/AccessorMethodName
 
     def self.load_default_actions
-      Dir[File.expand_path '*.rb', File.dirname(__FILE__)].each do |file|
+      Dir[File.expand_path('*.rb', File.dirname(__FILE__))].each do |file|
+        require file
+      end
+    end
+
+    # Import all the helpers
+    def self.load_helpers
+      Dir[File.expand_path('../helper/*.rb', File.dirname(__FILE__))].each do |file|
         require file
       end
     end
@@ -146,7 +85,6 @@ module Fastlane
         file_name = File.basename(file).gsub('.rb', '')
 
         class_name = file_name.fastlane_class + 'Action'
-        class_ref = nil
         begin
           class_ref = Fastlane::Actions.const_get(class_name)
 
@@ -157,7 +95,7 @@ module Fastlane
             Helper.log.error 'For more information, check out the docs: https://github.com/KrauseFx/fastlane'
             raise "Plugin '#{file_name}' is damaged!"
           end
-        rescue NameError => ex
+        rescue NameError
           # Action not found
           Helper.log.error "Could not find '#{class_name}' class defined.".red
           Helper.log.error 'For more information, check out the docs: https://github.com/KrauseFx/fastlane'

data/lib/fastlane/actions/add_git_tag.rb

@@ -3,9 +3,9 @@ module Fastlane
     # Adds a git tag to the current commit
     class AddGitTagAction < Action
       def self.run(options)
-        lane_name = Actions.lane_context[Actions::SharedValues::LANE_NAME].gsub(' ', '') # no spaces allowed
+        lane_name = Actions.lane_context[Actions::SharedValues::LANE_NAME].delete(' ') # no spaces allowed
 
-        tag = options[:tag] || "#{options[:grouping]}/#{lane_name}/#{options[:prefix]}#{options[:build_number].to_s}"
+        tag = options[:tag] || "#{options[:grouping]}/#{lane_name}/#{options[:prefix]}#{options[:build_number]}"
 
         Helper.log.info "Adding git tag '#{tag}' 🎯."
         Actions.sh("git tag \"#{tag}\"")

data/lib/fastlane/actions/appstore.rb

@@ -36,8 +36,8 @@ module Fastlane
       end
 
       def self.is_supported?(platform)
-        Actions::DeliverAction.is_supported?platform
+        Actions::DeliverAction.is_supported? platform
       end
     end
   end
-end
+end

data/lib/fastlane/actions/backup_file.rb

@@ -1,7 +1,7 @@
 module Fastlane
   module Actions
     class BackupFileAction < Action
-      def self.run params
+      def self.run(params)
         path = params[:path]
         FileUtils.cp(path, "#{path}.back", {preserve: true})
         Helper.log.info "Successfully created a backup 💾"
@@ -23,7 +23,7 @@ module Fastlane
         [
           FastlaneCore::ConfigItem.new(key: :path,
                                        description: "Path to the file you want to backup",
-                                       optional: false),
+                                       optional: false)
         ]
       end
     end

data/lib/fastlane/actions/backup_xcarchive.rb

@@ -13,7 +13,7 @@ module Fastlane
         base_destination = params[:destination]
         zipped = params[:zip]
         versioned = params[:versioned]
-        
+
         # Prepare destionation folder
         full_destination = base_destination
 
@@ -24,10 +24,10 @@ module Fastlane
           full_destination = File.expand_path(subfolder, base_destination)
         end
 
-        FileUtils.mkdir(full_destination) unless File.exists?(full_destination)
+        FileUtils.mkdir(full_destination) unless File.exist?(full_destination)
 
         # Save archive to destination
-        if zipped 
+        if zipped
           Helper.log.info "Compressing #{xcarchive}"
 
           xcarchive_folder = File.expand_path(File.dirname(xcarchive))
@@ -35,7 +35,7 @@ module Fastlane
           zip_file = File.expand_path(File.join("#{xcarchive_file}.zip"))
 
           # Create zip
-          Actions.sh(%Q[cd "#{xcarchive_folder}" && zip -r -X "#{zip_file}" "#{xcarchive_file}" > /dev/null])
+          Actions.sh(%(cd "#{xcarchive_folder}" && zip -r -X "#{zip_file}" "#{xcarchive_file}" > /dev/null))
 
           # Moved to its final destination
           FileUtils.mv(zip_file, full_destination)
@@ -47,7 +47,6 @@ module Fastlane
 
           Actions.lane_context[SharedValues::BACKUP_XCARCHIVE_FILE] = "#{full_destination}/#{File.basename(xcarchive)}"
         end
-
       end
 
       #####################################################
@@ -65,15 +64,15 @@ module Fastlane
                                        default_value: Actions.lane_context[SharedValues::XCODEBUILD_ARCHIVE],
                                        optional: false,
                                        env_name: 'BACKUP_XCARCHIVE_ARCHIVE',
-                                       verify_block: Proc.new do |value|
-                                        raise "Couldn't find xcarchive file at path '#{value}'".red if !Helper.test? && !File.exists?(value)
+                                       verify_block: proc do |value|
+                                         raise "Couldn't find xcarchive file at path '#{value}'".red if !Helper.test? && !File.exist?(value)
                                        end),
           FastlaneCore::ConfigItem.new(key: :destination,
                                        description: 'Where your archive will be placed',
                                        optional: false,
                                        env_name: 'BACKUP_XCARCHIVE_DESTINATION',
-                                       verify_block: Proc.new do |value|
-                                        raise "Couldn't find the destination folder at '#{value}'".red if !Helper.test? && !File.directory?(value) && !File.exists?(value)
+                                       verify_block: proc do |value|
+                                         raise "Couldn't find the destination folder at '#{value}'".red if !Helper.test? && !File.directory?(value) && !File.exist?(value)
                                        end),
           FastlaneCore::ConfigItem.new(key: :zip,
                                        description: 'Enable compression of the archive. Default value `true`',
@@ -101,9 +100,9 @@ module Fastlane
       end
 
       def self.is_supported?(platform)
-        [:ios, :mac].include?platform
+        [:ios, :mac].include? platform
       end
-      
+
     end
   end
-end
+end

data/lib/fastlane/actions/bundle_install.rb

@@ -1,8 +1,10 @@
 module Fastlane
   module Actions
     class BundleInstallAction < Action
+      # rubocop:disable Metrics/CyclomaticComplexity
+      # rubocop:disable Metrics/PerceivedComplexity
       def self.run(params)
-        if File.exists?('Gemfile')
+        if File.exist?('Gemfile')
           cmd = ['bundle install']
 
           cmd << "--binstubs #{params[:binstubs]}" if params[:binstubs]
@@ -29,6 +31,8 @@ module Fastlane
           Helper.log.info "No Gemfile found"
         end
       end
+      # rubocop:enable Metrics/CyclomaticComplexity
+      # rubocop:enable Metrics/PerceivedComplexity
 
       def self.description
         'This action runs `bundle install` if it founds the Gemfile'