fastlane 1.20.0 → 1.21.0

data/lib/fastlane/actions/install_cocoapods.rb

@@ -4,7 +4,7 @@ module Fastlane
       def self.run(params)
         cmd = []
 
-        cmd << ['bundle exec'] if File.exists?('Gemfile') && params[:use_bundle_exec]
+        cmd << ['bundle exec'] if File.exist?('Gemfile') && params[:use_bundle_exec]
         cmd << ['pod install']
 
         cmd << '--no-clean' unless params[:clean]
@@ -51,12 +51,12 @@ module Fastlane
                                        env_name: "FL_COCOAPODS_USE_BUNDLE_EXEC",
                                        description: "Use bundle exec when there is a Gemfile presented",
                                        is_string: false,
-                                       default_value: true),
+                                       default_value: true)
         ]
       end
 
       def self.is_supported?(platform)
-        [:ios, :mac].include?platform
+        [:ios, :mac].include? platform
       end
 
       def self.authors

data/lib/fastlane/actions/ipa.rb

@@ -1,3 +1,5 @@
+# rubocop:disable Lint/AssignmentInCondition
+# rubocop:disable Style/Next
 module Fastlane
   module Actions
     ARGS_MAP = {
@@ -23,9 +25,6 @@ module Fastlane
       end
 
       def self.run(params)
-        # The args we will build with
-        build_args = nil
-
         # The output directory of the IPA and dSYM
         absolute_dest_directory = nil
 
@@ -34,10 +33,11 @@ module Fastlane
           absolute_dest_directory = File.expand_path(dest)
         end
 
+        # The args we will build with
         # Maps nice developer build parameters to Shenzhen args
         build_args = params_to_build_args(params)
 
-        unless (params[:scheme] rescue nil)
+        unless params[:scheme]
           Helper.log.warn "You haven't specified a scheme. This might cause problems. If you can't see any output, please pass a `scheme`"
         end
 
@@ -101,7 +101,7 @@ module Fastlane
         # Maps nice developer param names to Shenzhen's `ipa build` arguments
         params.collect do |k, v|
           v ||= ''
-          if args = ARGS_MAP[k]
+          if ARGS_MAP[k]
             if k == :clean
               v == true ? '--clean' : '--no-clean'
             elsif k == :archive
@@ -196,7 +196,7 @@ module Fastlane
           FastlaneCore::ConfigItem.new(key: :xcargs,
                                        env_name: "IPA_XCARGS",
                                        description: "Pass additional arguments to xcodebuild when building the app. Be sure to quote multiple args",
-                                       optional: true),
+                                       optional: true)
         ]
       end
 
@@ -213,3 +213,5 @@ module Fastlane
     end
   end
 end
+# rubocop:enable Lint/AssignmentInCondition
+# rubocop:enable Style/Next

data/lib/fastlane/actions/is_ci.rb

@@ -0,0 +1,37 @@
+module Fastlane
+  module Actions
+    class IsCiAction < Action
+      def self.run(params)
+        Helper.is_ci?
+      end
+
+      #####################################################
+      # @!group Documentation
+      #####################################################
+
+      def self.description
+        "Is the current run being executed on a CI system, like Jenkins or Travis"
+      end
+
+      def self.details
+        [
+          "The return value of this method is true if fastlane is currently executed on",
+          "Travis, Jenkins, Circle or a similar CI service"
+        ].join("\n")
+      end
+
+      def self.available_options
+        []
+      end
+
+      def self.authors
+        # So no one will ever forget your contribution to fastlane :) You are awesome btw!
+        ["KrauseFx"]
+      end
+
+      def self.is_supported?(platform)
+        true
+      end
+    end
+  end
+end

data/lib/fastlane/actions/lane_context.rb

@@ -21,7 +21,7 @@ module Fastlane
         []
       end
 
-      def self.authors        
+      def self.authors
         ["KrauseFx"]
       end
 
@@ -35,4 +35,4 @@ module Fastlane
       end
     end
   end
-end
+end

data/lib/fastlane/actions/last_git_tag.rb

@@ -30,4 +30,4 @@ module Fastlane
       end
     end
   end
-end
+end

data/lib/fastlane/actions/lcov.rb

@@ -35,7 +35,6 @@ module Fastlane
                                        is_string: true,
                                        default_value: "coverage_reports")
 
-
         ]
       end
 
@@ -43,45 +42,43 @@ module Fastlane
         "thiagolioy"
       end
 
-      private
-
-        def self.gen_cov(options)
-          tmp_cov_file = "/tmp/coverage.info"
-          output_dir = options[:output_dir]
-          derived_data_path = derived_data_dir(options)
+      def self.gen_cov(options)
+        tmp_cov_file = "/tmp/coverage.info"
+        output_dir = options[:output_dir]
+        derived_data_path = derived_data_dir(options)
 
-          system("lcov --capture --directory \"#{derived_data_path}\" --output-file #{tmp_cov_file}")
-          system(gen_lcov_cmd(tmp_cov_file))
-          system("genhtml #{tmp_cov_file} --output-directory #{output_dir}")
-        end
+        system("lcov --capture --directory \"#{derived_data_path}\" --output-file #{tmp_cov_file}")
+        system(gen_lcov_cmd(tmp_cov_file))
+        system("genhtml #{tmp_cov_file} --output-directory #{output_dir}")
+      end
 
-        def self.gen_lcov_cmd(cov_file)
-          cmd = "lcov "
-          exclude_dirs.each do |e|
-            cmd << "--remove #{cov_file} \"#{e}\" "
-          end
-          cmd << "--output #{cov_file} "
+      def self.gen_lcov_cmd(cov_file)
+        cmd = "lcov "
+        exclude_dirs.each do |e|
+          cmd << "--remove #{cov_file} \"#{e}\" "
         end
+        cmd << "--output #{cov_file} "
+      end
 
-        def self.derived_data_dir(options)
-           pn = options[:project_name]
-           sc = options[:scheme]
+      def self.derived_data_dir(options)
+        pn = options[:project_name]
+        sc = options[:scheme]
 
-           initial_path = "#{Dir.home}/Library/Developer/Xcode/DerivedData/"
-           end_path = "/Build/Intermediates/#{pn}.build/Debug-iphonesimulator/#{sc}.build/Objects-normal/i386/"
+        initial_path = "#{Dir.home}/Library/Developer/Xcode/DerivedData/"
+        end_path = "/Build/Intermediates/#{pn}.build/Debug-iphonesimulator/#{sc}.build/Objects-normal/i386/"
 
-           match = find_project_dir(pn,initial_path)
+        match = find_project_dir(pn, initial_path)
 
-           "#{initial_path}#{match}#{end_path}"
-        end
+        "#{initial_path}#{match}#{end_path}"
+      end
 
-        def self.find_project_dir(project_name,path)
-          `ls -t #{path}| grep #{project_name} | head -1`.to_s.gsub(/\n/, "")
-        end
+      def self.find_project_dir(project_name, path)
+        `ls -t #{path}| grep #{project_name} | head -1`.to_s.gsub(/\n/, "")
+      end
 
-        def self.exclude_dirs
-          ["/Applications/*","/Frameworks/*"]
-        end
+      def self.exclude_dirs
+        ["/Applications/*", "/Frameworks/*"]
+      end
 
     end
   end

data/lib/fastlane/actions/mailgun.rb

@@ -11,7 +11,6 @@ module Fastlane
       def self.run(options)
         require 'rest_client'
         handle_params_transition(options)
-        handle_exceptions(options)
         mailgunit(options)
       end
 
@@ -21,17 +20,17 @@ module Fastlane
 
       def self.available_options
         [
-          #This is here just for while due to the transition, not needed anymore
+          # This is here just for while due to the transition, not needed anymore
           FastlaneCore::ConfigItem.new(key: :mailgun_sandbox_domain,
                                        env_name: "MAILGUN_SANDBOX_POSTMASTER",
                                        optional: true,
                                        description: "Mailgun sandbox domain postmaster for your mail. Please use postmaster instead"),
-          #This is here just for while due to the transition, should use postmaster instead
+          # This is here just for while due to the transition, should use postmaster instead
           FastlaneCore::ConfigItem.new(key: :mailgun_sandbox_postmaster,
                                        env_name: "MAILGUN_SANDBOX_POSTMASTER",
                                        optional: true,
                                        description: "Mailgun sandbox domain postmaster for your mail. Please use postmaster instead"),
-          #This is here just for while due to the transition, should use apikey instead
+          # This is here just for while due to the transition, should use apikey instead
           FastlaneCore::ConfigItem.new(key: :mailgun_apikey,
                                        env_name: "MAILGUN_APIKEY",
                                        optional: true,
@@ -72,7 +71,6 @@ module Fastlane
                                       optional: true,
                                       is_string: true)
 
-
         ]
       end
 
@@ -80,53 +78,24 @@ module Fastlane
         "thiagolioy"
       end
 
-      private
       def self.handle_params_transition(options)
-          options[:postmaster] = options[:mailgun_sandbox_postmaster] if options[:mailgun_sandbox_postmaster]
-          puts "\nUsing :mailgun_sandbox_postmaster is deprecated, please change to :postmaster".yellow
-
-          options[:apikey] = options[:mailgun_apikey] if options[:mailgun_apikey]
-          puts "\nUsing :mailgun_apikey is deprecated, please change to :apikey".yellow
-      end
-
-      def self.handle_exceptions(options)
-          unless (options[:apikey] rescue nil)
-            Helper.log.fatal "Please add 'ENV[\"MAILGUN_APIKEY\"] = \"a_valid_mailgun_apikey\"' to your Fastfile's `before_all` section.".red
-            raise 'No MAILGUN_APIKEY given.'.red
-          end
+        options[:postmaster] = options[:mailgun_sandbox_postmaster] if options[:mailgun_sandbox_postmaster]
+        puts "\nUsing :mailgun_sandbox_postmaster is deprecated, please change to :postmaster".yellow
 
-          unless (options[:postmaster] rescue nil)
-            Helper.log.fatal "Please add 'ENV[\"MAILGUN_SANDBOX_POSTMASTER\"] = \"a_valid_mailgun_sandbox_postmaster\"' to your Fastfile's `before_all` section.".red
-            raise 'No MAILGUN_SANDBOX_POSTMASTER given.'.red
-          end
-
-          unless (options[:to] rescue nil)
-            Helper.log.fatal "Please provide a valid :to  = \"a_valid_mailgun_to\"".red
-            raise 'No MAILGUN_TO given.'.red
-          end
-
-          unless (options[:message] rescue nil)
-            Helper.log.fatal "Please provide a valid :message  = \"a_valid_mailgun_text\"".red
-            raise 'No MAILGUN_MESSAGE given.'.red
-          end
-
-          unless (options[:app_link] rescue nil)
-            Helper.log.fatal "Please provide a valid :app_link  = \"a_valid_mailgun_app_link\"".red
-            raise 'No MAILGUN_APP_LINK given.'.red
-          end
+        options[:apikey] = options[:mailgun_apikey] if options[:mailgun_apikey]
+        puts "\nUsing :mailgun_apikey is deprecated, please change to :apikey".yellow
       end
 
       def self.mailgunit(options)
         sandbox_domain = options[:postmaster].split("@").last
         RestClient.post "https://api:#{options[:apikey]}@api.mailgun.net/v3/#{sandbox_domain}/messages",
-            from: "Mailgun Sandbox<#{options[:postmaster]}>",
-            to: "#{options[:to]}",
-            subject: options[:subject],
-            html: mail_teplate(options)
+                        from: "Mailgun Sandbox<#{options[:postmaster]}>",
+                        to: "#{options[:to]}",
+                        subject: options[:subject],
+                        html: mail_teplate(options)
         mail_teplate(options)
       end
 
-
       def self.mail_teplate(options)
         hash = {
           author: Actions.git_author,

data/lib/fastlane/actions/oclint.rb

@@ -6,17 +6,16 @@ module Fastlane
 
     class OclintAction < Action
       def self.run(params)
-
         select_reqex = params[:select_reqex]
-        
+
         compile_commands = params[:compile_commands]
-        raise "Could not find json compilation database at path '#{compile_commands}'".red unless File.exists?(compile_commands)
-        
+        raise "Could not find json compilation database at path '#{compile_commands}'".red unless File.exist?(compile_commands)
+
         files = JSON.parse(File.read(compile_commands)).map { |compile_command| compile_command['file'] }
         files.uniq!
         files.select! do |file|
           file_ruby = file.gsub('\ ', ' ')
-          File.exists?(file_ruby) and (!select_reqex or file_ruby =~ select_reqex)
+          File.exist?(file_ruby) and (!select_reqex or file_ruby =~ select_reqex)
         end
 
         command_prefix = [
@@ -24,30 +23,28 @@ module Fastlane
           File.expand_path('.').shellescape,
           '&&'
         ].join(' ')
-        
+
         report_type = params[:report_type]
         report_path = params[:report_path] ? params[:report_path] : 'oclint_report.' + report_type
-        
+
         oclint_args = ["-report-type=#{report_type}", "-o=#{report_path}"]
         oclint_args << "-rc=#{params[:rc]}" if params[:rc]
         oclint_args << "-max-priority-1=#{params[:max_priority_1]}" if params[:max_priority_1]
         oclint_args << "-max-priority-2=#{params[:max_priority_2]}" if params[:max_priority_2]
         oclint_args << "-max-priority-3=#{params[:max_priority_3]}" if params[:max_priority_3]
-                
+
         command = [
           command_prefix,
           'oclint',
           oclint_args,
           '"' + files.join('" "') + '"'
         ].join(' ')
-        
+
         Action.sh command
 
         Actions.lane_context[SharedValues::FL_OCLINT_REPORT_PATH] = File.expand_path(report_path)
       end
 
-
-
       #####################################################
       # @!group Documentation
       #####################################################
@@ -108,10 +105,10 @@ module Fastlane
       def self.author
         'HeEAaD'
       end
-      
+
       def self.is_supported?(platform)
         true
       end
     end
   end
-end
+end

data/lib/fastlane/actions/pem.rb

@@ -41,7 +41,7 @@ module Fastlane
           "profile was created. You can use it to upload the new profile to your server.",
           "Use it like this: ",
           "pem(",
-          "  new_profile: Proc.new do ",
+          "  new_profile: proc do ",
           "    # your upload code",
           "  end",
           ")"
@@ -55,7 +55,7 @@ module Fastlane
         unless @options
           @options = PEM::Options.available_options
           @options << FastlaneCore::ConfigItem.new(key: :new_profile,
-                                       description: "Block that is called if there is a new profile", 
+                                       description: "Block that is called if there is a new profile",
                                        optional: true,
                                        is_string: false)
         end

data/lib/fastlane/actions/pilot.rb

@@ -7,7 +7,9 @@ module Fastlane
 
         begin
           FastlaneCore::UpdateChecker.start_looking_for_update('pilot') unless Helper.is_test?
-          
+
+          values[:ipa] ||= Actions.lane_context[SharedValues::IPA_OUTPUT_PATH]
+
           Pilot::BuildManager.new.upload(values) # we already have the finished config
 
           return nil
@@ -46,4 +48,4 @@ module Fastlane
       end
     end
   end
-end
+end

data/lib/fastlane/actions/prompt.rb

@@ -7,14 +7,14 @@ module Fastlane
 
         return params[:ci_input] if Helper.is_ci?
 
-        unless params[:multi_line_end_keyword]
-          # Standard one line input
-          user_input = STDIN.gets.chomp.strip
-        else
+        if params[:multi_line_end_keyword]
           # Multi line
           end_tag = params[:multi_line_end_keyword]
           Helper.log.info "Submit inputs using \"#{params[:multi_line_end_keyword]}\"".yellow
           user_input = STDIN.gets(end_tag).chomp.gsub(end_tag, "").strip
+        else
+          # Standard one line input
+          user_input = STDIN.gets.chomp.strip
         end
 
         user_input = (user_input.downcase == 'y') if params[:boolean]
@@ -52,7 +52,7 @@ module Fastlane
           FastlaneCore::ConfigItem.new(key: :multi_line_end_keyword,
                                        description: "Enable multi-line inputs by providing an end text (e.g. 'END') which will stop the user input",
                                        optional: true,
-                                       is_string: true),
+                                       is_string: true)
         ]
       end
 
@@ -69,4 +69,4 @@ module Fastlane
       end
     end
   end
-end
+end