fastlane 1.20.0 → 1.21.0

data/lib/fastlane/actions/push_git_tags.rb

@@ -0,0 +1,38 @@
+module Fastlane
+  module Actions
+    class PushGitTagsAction < Action
+      def self.run(params)
+        command = [
+          'git',
+          'push',
+          '--tags'
+        ]
+
+        result = Actions.sh(command.join(' '))
+        Helper.log.info 'Tags pushed to remote'.green
+        result
+      end
+
+      #####################################################
+      # @!group Documentation
+      #####################################################
+
+      def self.description
+        "Push local tags to the remote - this will only push tags"
+      end
+
+      def self.available_options
+        [
+        ]
+      end
+
+      def self.author
+        ['vittoriom']
+      end
+
+      def self.is_supported?(platform)
+        true
+      end
+    end
+  end
+end

data/lib/fastlane/actions/push_to_git_remote.rb

@@ -3,7 +3,10 @@ module Fastlane
     # Adds a git tag to the current commit
     class PushToGitRemoteAction < Action
       def self.run(params)
-        local_branch  = params[:local_branch] || (Actions.git_branch.gsub(/#{params[:remote]}\//, '') rescue nil) || 'master'
+        local_branch = params[:local_branch]
+        local_branch ||= Actions.git_branch.gsub(%r{#{params[:remote]}\/}, '') if Actions.git_branch
+        local_branch ||= 'master'
+
         remote_branch = params[:remote_branch] || local_branch
 
         # construct our command as an array of components

data/lib/fastlane/actions/puts.rb

@@ -27,4 +27,4 @@ module Fastlane
       end
     end
   end
-end
+end

data/lib/fastlane/actions/register_devices.rb

@@ -45,6 +45,7 @@ module Fastlane
         end
 
         Helper.log.info "Successfully registered new devices.".green
+        return device_objs
       end
 
       def self.description
@@ -62,8 +63,8 @@ module Fastlane
                                        env_name: "FL_REGISTER_DEVICES_FILE",
                                        description: "Provide a path to the devices to register",
                                        optional: true,
-                                       verify_block: Proc.new do |value|
-                                        raise "Could not find file '#{value}'".red unless File.exists?(value)
+                                       verify_block: proc do |value|
+                                         raise "Could not find file '#{value}'".red unless File.exist?(value)
                                        end),
           FastlaneCore::ConfigItem.new(key: :team_id,
                                        env_name: "FASTLANE_TEAM_ID",
@@ -72,7 +73,7 @@ module Fastlane
           FastlaneCore::ConfigItem.new(key: :username,
                                        env_name: "DELIVER_USER",
                                        description: "Optional: Your Apple ID",
-                                       default_value: CredentialsManager::AppfileConfig.try_fetch_value(:apple_id)),
+                                       default_value: CredentialsManager::AppfileConfig.try_fetch_value(:apple_id))
         ]
       end
 

data/lib/fastlane/actions/reset_git_repo.rb

@@ -4,17 +4,17 @@ module Fastlane
     class ResetGitRepoAction < Action
       def self.run(params)
         if params[:force] || params[:force] || Actions.lane_context[SharedValues::GIT_REPO_WAS_CLEAN_ON_START]
-          paths = (params[:files] rescue nil)
+          paths = params[:files]
 
           return paths if Helper.is_test?
-          
+
           if (paths || []).count == 0
             Actions.sh('git reset --hard HEAD')
             Actions.sh('git clean -qfdx')
             Helper.log.info 'Git repo was reset and cleaned back to a pristine state.'.green
           else
             paths.each do |path|
-              Helper.log.warn("Couldn't find file at path '#{path}'") unless File.exists?(path)
+              Helper.log.warn("Couldn't find file at path '#{path}'") unless File.exist?(path)
               Actions.sh("git checkout -- '#{path}'")
             end
             Helper.log.info "Git cleaned up #{paths.count} files.".green
@@ -43,14 +43,14 @@ module Fastlane
                                        description: "Array of files the changes should be discarded from. If not given, all files will be discarded",
                                        optional: true,
                                        is_string: false,
-                                       verify_block: Proc.new do |value|
-                                        raise "Please pass an array only" unless value.kind_of?Array
+                                       verify_block: proc do |value|
+                                         raise "Please pass an array only" unless value.kind_of? Array
                                        end),
           FastlaneCore::ConfigItem.new(key: :force,
                                        env_name: "FL_RESET_GIT_FORCE",
                                        description: "Skip verifying of previously clean state of repo. Only recommended in combination with `files` option",
                                        is_string: false,
-                                       default_value: false),
+                                       default_value: false)
         ]
       end
 

data/lib/fastlane/actions/resign.rb

@@ -5,7 +5,6 @@ module Fastlane
       def self.run(params)
         require 'sigh'
 
-
         # try to resign the ipa
         if Sigh::Resign.resign(params[:ipa], params[:signing_identity], params[:provisioning_profile])
           Helper.log.info 'Successfully re-signed .ipa 🔏.'.green
@@ -24,8 +23,8 @@ module Fastlane
                                        env_name: "FL_RESIGN_IPA",
                                        description: "Path to the ipa file to resign. Optional if you use the `ipa` or `xcodebuild` action",
                                        default_value: Actions.lane_context[SharedValues::IPA_OUTPUT_PATH],
-                                       verify_block: Proc.new do |value|
-                                        raise "Couldn't find ipa file at path '#{value}'".red unless File.exists?(value)
+                                       verify_block: proc do |value|
+                                         raise "Couldn't find ipa file at path '#{value}'".red unless File.exist?(value)
                                        end),
           FastlaneCore::ConfigItem.new(key: :signing_identity,
                                        env_name: "FL_RESIGN_SIGNING_IDENTITY",
@@ -34,8 +33,8 @@ module Fastlane
                                        env_name: "FL_RESIGN_PROVISIONING_PROFILE",
                                        description: "Path to your provisioning_profile. Optional if you use `sigh`",
                                        default_value: Actions.lane_context[SharedValues::SIGH_PROFILE_PATH],
-                                       verify_block: Proc.new do |value|
-                                        raise "No provisioning_profile file given or found, pass using `provisioning_profile: 'path/app.mobileprovision'`".red unless File.exists?(value)
+                                       verify_block: proc do |value|
+                                         raise "No provisioning_profile file given or found, pass using `provisioning_profile: 'path/app.mobileprovision'`".red unless File.exist?(value)
                                        end)
         ]
       end

data/lib/fastlane/actions/restore_file.rb

@@ -1,7 +1,7 @@
 module Fastlane
   module Actions
     class RestoreFileAction < Action
-      def self.run params
+      def self.run(params)
         path = params[:path]
         backup_path = "#{path}.back"
         raise "Could not find file '#{backup_path}'" unless File.exist? backup_path
@@ -26,7 +26,7 @@ module Fastlane
         [
           FastlaneCore::ConfigItem.new(key: :path,
                                        description: "Original file name you want to restore",
-                                       optional: false),
+                                       optional: false)
         ]
       end
     end

data/lib/fastlane/actions/s3.rb

@@ -1,10 +1,11 @@
+# rubocop:disable Metrics/PerceivedComplexity
+# rubocop:disable Metrics/AbcSize
 require 'fastlane/erb_template_helper'
 require 'ostruct'
 require 'shenzhen'
 
 module Fastlane
   module Actions
-
     module SharedValues
       S3_IPA_OUTPUT_PATH = :S3_IPA_OUTPUT_PATH
       S3_DSYM_OUTPUT_PATH = :S3_DSYM_OUTPUT_PATH
@@ -22,12 +23,11 @@ module Fastlane
       region: '-r',
       acl: '--acl',
       source: '--source-dir',
-      path: '-P',
+      path: '-P'
     }
 
     class S3Action < Action
       def self.run(config)
-
         # Calling fetch on config so that default values will be used
         params = {}
         params[:ipa] = config[:ipa]
@@ -113,21 +113,19 @@ module Fastlane
         plist_url = "https://#{s3_subdomain}.amazonaws.com/#{s3_bucket}/#{plist_file_name}"
 
         html_file_name ||= "index.html"
-        html_url = "https://#{s3_subdomain}.amazonaws.com/#{s3_bucket}/#{html_file_name}"
 
         version_file_name ||= "version.json"
-        version_url = "https://#{s3_subdomain}.amazonaws.com/#{s3_bucket}/#{version_file_name}"
 
-        #grabs module
+        # grabs module
         eth = Fastlane::ErbTemplateHelper
 
         # Creates plist from template
-        if plist_template_path && File.exists?(plist_template_path)
+        if plist_template_path && File.exist?(plist_template_path)
           plist_template = eth.load_from_path(plist_template_path)
         else
           plist_template = eth.load("s3_plist_template")
         end
-        plist_render = eth.render(plist_template,{
+        plist_render = eth.render(plist_template, {
           url: ipa_url,
           bundle_id: bundle_id,
           bundle_version: bundle_version,
@@ -135,12 +133,12 @@ module Fastlane
         })
 
         # Creates html from template
-        if html_template_path && File.exists?(html_template_path)
+        if html_template_path && File.exist?(html_template_path)
           html_template = eth.load_from_path(html_template_path)
         else
           html_template = eth.load("s3_html_template")
         end
-        html_render = eth.render(html_template,{
+        html_render = eth.render(html_template, {
           url: plist_url,
           bundle_id: bundle_id,
           bundle_version: bundle_version,
@@ -148,12 +146,12 @@ module Fastlane
         })
 
         # Creates version from template
-        if version_template_path && File.exists?(version_template_path)
+        if version_template_path && File.exist?(version_template_path)
           version_template = eth.load_from_path(version_template_path)
         else
           version_template = eth.load("s3_version_template")
         end
-        version_render = eth.render(version_template,{
+        version_render = eth.render(version_template, {
           url: plist_url,
           full_version: full_version
         })
@@ -174,10 +172,9 @@ module Fastlane
           html_render,
           version_file_name,
           version_render
-          )
+        )
 
         return true
-
       end
 
       def self.params_to_build_args(params)
@@ -185,9 +182,9 @@ module Fastlane
         params = params.delete_if { |k, v| (k != :clean && k != :archive ) && v.nil? }
 
         # Maps nice developer param names to Shenzhen's `ipa build` arguments
-        params.collect do |k,v|
+        params.collect do |k, v|
           v ||= ''
-          if args = S3_ARGS_MAP[k]
+          if S3_ARGS_MAP[k]
             value = (v.to_s.length > 0 ? "\"#{v}\"" : "")
             "#{S3_ARGS_MAP[k]} #{value}".strip
           end
@@ -197,8 +194,8 @@ module Fastlane
       def self.upload_plist_and_html_to_s3(s3_access_key, s3_secret_access_key, s3_bucket, plist_file_name, plist_render, html_file_name, html_render, version_file_name, version_render)
         require 'aws-sdk'
         s3_client = AWS::S3.new(
-            access_key_id: s3_access_key,
-            secret_access_key: s3_secret_access_key
+          access_key_id: s3_access_key,
+          secret_access_key: s3_secret_access_key
         )
         bucket = s3_client.buckets[s3_bucket]
 
@@ -216,7 +213,7 @@ module Fastlane
         Actions.lane_context[SharedValues::S3_VERSION_OUTPUT_PATH] = version_obj.public_url.to_s
         ENV[SharedValues::S3_VERSION_OUTPUT_PATH.to_s] = version_obj.public_url.to_s
 
-        Helper.log.info "Successfully uploaded ipa file to '#{html_obj.public_url.to_s}'".green
+        Helper.log.info "Successfully uploaded ipa file to '#{html_obj.public_url}'".green
       end
 
       #
@@ -251,7 +248,6 @@ module Fastlane
       def self.get_ipa_info(ipa_file)
         bundle_id, bundle_version, title, full_version = nil
         Dir.mktmpdir do |dir|
-
           system "unzip -q #{ipa_file} -d #{dir} 2> /dev/null"
           plist = Dir["#{dir}/**/*.app/Info.plist"].last
 
@@ -261,7 +257,6 @@ module Fastlane
 
           # This is the string: {CFBundleShortVersionString}.{CFBundleVersion}
           full_version = bundle_version + '.' + Shenzhen::PlistBuddy.print(plist, 'CFBundleVersion')
-
         end
         return bundle_id, bundle_version, title, full_version
       end
@@ -339,7 +334,7 @@ module Fastlane
           FastlaneCore::ConfigItem.new(key: :acl,
                                        env_name: "S3_ACL",
                                        description: "Uploaded object permissions e.g public_read (default), private, public_read_write, authenticated_read ",
-                                       optional: true,),
+                                       optional: true)
         ]
       end
 
@@ -363,3 +358,5 @@ module Fastlane
     end
   end
 end
+# rubocop:enable Metrics/PerceivedComplexity
+# rubocop:enable Metrics/AbcSize

data/lib/fastlane/actions/set_build_number_repository.rb

@@ -9,53 +9,43 @@ module Fastlane
       end
 
       def self.is_svn?
-        begin
-          Actions.sh 'svn info'
-          return true
-        rescue
-          return false
-        end
+        Actions.sh 'svn info'
+        return true
+      rescue
+        return false
       end
 
       def self.is_git?
-        begin
-          Actions.sh 'git rev-parse HEAD'
-          return true
-        rescue
-          return false
-        end
+        Actions.sh 'git rev-parse HEAD'
+        return true
+      rescue
+        return false
       end
 
       def self.is_git_svn?
-        begin
-          Actions.sh 'git svn info'
-          return true
-        rescue
-          return false
-        end
+        Actions.sh 'git svn info'
+        return true
+      rescue
+        return false
       end
 
       def self.run(params)
-         begin
-
-          if is_svn?
-            Helper.log.info "Detected repo: svn"
-            command = 'svn info | grep Revision | egrep -o "[0-9]+"'
-          elsif is_git_svn?
-            Helper.log.info "Detected repo: git-svn"
-            command = 'git svn info | grep Revision | egrep -o "[0-9]+"'
-          elsif is_git?
-            Helper.log.info "Detected repo: git"
-            command = 'git rev-parse --short HEAD'
-          else
-            raise "No repository detected"
-          end
-
-          build_number = Actions.sh command
+        if is_svn?
+          Helper.log.info "Detected repo: svn"
+          command = 'svn info | grep Revision | egrep -o "[0-9]+"'
+        elsif is_git_svn?
+          Helper.log.info "Detected repo: git-svn"
+          command = 'git svn info | grep Revision | egrep -o "[0-9]+"'
+        elsif is_git?
+          Helper.log.info "Detected repo: git"
+          command = 'git rev-parse --short HEAD'
+        else
+          raise "No repository detected"
+        end
 
-          Fastlane::Actions::IncrementBuildNumberAction.run(build_number:build_number)
+        build_number = Actions.sh command
 
-        end
+        Fastlane::Actions::IncrementBuildNumberAction.run(build_number: build_number)
       end
 
       #####################################################

data/lib/fastlane/actions/set_changelog.rb

@@ -25,7 +25,7 @@ module Fastlane
         unless changelog
           path = "./fastlane/changelog.txt"
           Helper.log.info "Looking for changelog in '#{path}'..."
-          if File.exists?path
+          if File.exist? path
             changelog = File.read(path)
           else
             Helper.log.error "Couldn't find changelog.txt"
@@ -85,7 +85,7 @@ module Fastlane
                                      env_name: "FASTLANE_USERNAME",
                                      description: "Your Apple ID Username",
                                      default_value: ENV["DELIVER_USER"] || CredentialsManager::AppfileConfig.try_fetch_value(:apple_id),
-                                     verify_block: Proc.new do |value|
+                                     verify_block: proc do |value|
                                        CredentialsManager::PasswordManager.shared_manager(value)
                                      end),
           FastlaneCore::ConfigItem.new(key: :version,
@@ -104,8 +104,8 @@ module Fastlane
       end
 
       def self.is_supported?(platform)
-        [:ios, :mac].include?platform
+        [:ios, :mac].include? platform
       end
     end
   end
-end
+end

data/lib/fastlane/actions/set_github_release.rb

@@ -8,7 +8,6 @@ module Fastlane
 
     class SetGithubReleaseAction < Action
       def self.run(params)
-
         Helper.log.info "Creating release of #{params[:repository_name]} on tag \"#{params[:tag_name]}\" with name \"#{params[:name]}\".".yellow
 
         require 'json'
@@ -25,10 +24,10 @@ module Fastlane
         require 'base64'
         headers = { 'User-Agent' => 'fastlane-set_github_release' }
         headers['Authorization'] = "Basic #{Base64.strict_encode64(params[:api_token])}" if params[:api_token]
-        response = Excon.post("https://api.github.com/repos/#{params[:repository_name]}/releases", 
-          :headers => headers,
-          :body => body
-          )
+        response = Excon.post("https://api.github.com/repos/#{params[:repository_name]}/releases",
+                              headers: headers,
+                              body: body
+                             )
 
         case response[:status]
         when 201
@@ -64,10 +63,10 @@ module Fastlane
       end
 
       def self.details
-        "Creates a new release on GitHub. You must provide your GitHub Personal token 
+        "Creates a new release on GitHub. You must provide your GitHub Personal token
         (get one from https://github.com/settings/tokens/new), the repository name
         and tag name. If the tag doesn't exist, one will be created on the commit or branch passed-in as
-        commitish. Out parameters provide the release's id, which can be used for later editing and the 
+        commitish. Out parameters provide the release's id, which can be used for later editing and the
         release html link to GitHub."
       end
 
@@ -76,9 +75,9 @@ module Fastlane
           FastlaneCore::ConfigItem.new(key: :repository_name,
                                        env_name: "FL_SET_GITHUB_RELEASE_REPOSITORY_NAME",
                                        description: "The path to your repo, e.g. 'KrauseFx/fastlane'",
-                                       verify_block: Proc.new do |value|
-                                          raise "Please only pass the path, e.g. 'KrauseFx/fastlane'".red if value.include?"github.com"
-                                          raise "Please only pass the path, e.g. 'KrauseFx/fastlane'".red if value.split('/').count != 2
+                                       verify_block: proc do |value|
+                                         raise "Please only pass the path, e.g. 'KrauseFx/fastlane'".red if value.include? "github.com"
+                                         raise "Please only pass the path, e.g. 'KrauseFx/fastlane'".red if value.split('/').count != 2
                                        end),
           FastlaneCore::ConfigItem.new(key: :api_token,
                                        env_name: "FL_GITHUB_RELEASE_API_TOKEN",
@@ -137,4 +136,4 @@ module Fastlane
       end
     end
   end
-end
+end