fastlane 0.1.8 → 0.1.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9a3a2a536f09df1917c15ac5eb551e903fa0815a
-  data.tar.gz: b3ecbd749ccfd75580392fc72c840ef53e2a09a1
+  metadata.gz: c464e783663a94ab157e27d681407a763976b625
+  data.tar.gz: 36abfb852e100300bfbe2a2ef82fa569f2d10014
 SHA512:
-  metadata.gz: 61d77640d296490e31906cfd8d45d2ed879978b3bbab42cbdb8bcda580bea2085e75b1c0e896dfd484a3b5d3e721a24d5592fb8463371b6730fd71698aff7e02
-  data.tar.gz: e73b1d0d0c6ae17295abb670b49f9fe296312de7da4f2bfdabdd7d42a2d1a9e348ec956d94b876850facf90bbba7a7f0a1612dc491f4b0905281ac146c2b0d10
+  metadata.gz: 864d22e356eb44b600e903526243f07cc84a10ce064acee755607a3f8b694956cc203b824f48d4732556200610bbccbfe971e7fb4494baf77232a5a3968adf95
+  data.tar.gz: 248eb32876dc82f653b7371f0a2f44a862af482c50f46320306df1405870c2afbeba79b594a55948ef4d1b77d3ec4bc368374073fadd94c4f1ba613b969467a6

data/README.md

@@ -178,11 +178,11 @@ Build your app right inside `fastlane` and the path to the resulting ipa is auto
 ipa({
   workspace: "MyApp.xcworkspace",
   configuration: "Debug",
-  scheme: "Debug",
+  scheme: "MyApp",
 })
 ```
 
-The path to the `ipa` is automatically used by `Crashlytics`, `Hockey` and `DeployGate`. To use also use it in `deliver` update your `Deliverfile`:
+The path to the `ipa` is automatically used by `Crashlytics`, `Hockey` and `DeployGate`. To also use it in `deliver` update your `Deliverfile`:
 
 ```ruby
 ipa ENV["IPA_OUTPUT_PATH"]
@@ -438,6 +438,7 @@ Actions::SharedValues::DEPLOYGATE_APP_INFO # Hash, generated by `deploygate`
 ```ruby
 before_all do
   ENV["SLACK_URL"] = "https://hooks.slack.com/services/..."
+  team_id "Q2CBPK58CA"
 
   increment_build_number
   cocoapods
@@ -474,6 +475,14 @@ error do |lane, exception|
 end
 ```
 
+#### Set Team ID for all tools
+
+To set a team ID for `sigh`, `PEM` and the other tools, add this code to your `before_all` block:
+
+```ruby
+team_id "Q2CBPK58CA"
+```
+
 #### Snapshot
 To skip cleaning the project on every build:
 ```ruby
@@ -495,6 +504,12 @@ Keep in mind the ```before_all``` and ```after_all``` block will be executed for
 #### Hide the `fastlane` folder
 Just rename the folder to `.fastlane` in case you don't want it to be visible in the Finder. 
 
+#### Select  Xcode version (e.g. Beta Version)
+If you want to use a Beta Xcode installation, you can add this to your `before_all` block.
+```
+ENV['DEVELOPER_DIR'] = '/Applications/Xcode-Beta6.3.app/Contents/Developer'
+```
+
 #### Load own actions from external folder
 Add this to the top of your `Fastfile` (*.* is the `fastlane` folder)
 ```ruby

data/bin/fastlane

@@ -1,6 +1,6 @@
 #!/usr/bin/env ruby
 
-$:.push File.expand_path("../../lib", __FILE__)
+$LOAD_PATH.push File.expand_path('../../lib', __FILE__)
 
 require 'fastlane'
 require 'commander'
@@ -8,7 +8,6 @@ require 'fastlane/new_action'
 
 HighLine.track_eof = false
 
-
 class FastlaneApplication
   include Commander::Methods
 
@@ -26,11 +25,11 @@ class FastlaneApplication
       c.syntax = 'fastlane run [lane]'
       c.description = 'Drive the fastlane for a specific environment.'
 
-      c.action do |args, options|
+      c.action do |args, _options|
         if Fastlane::FastlaneFolder.path
           Fastlane::LaneManager.cruise_lanes(args)
         else
-          create = agree("Could not find fastlane in current directory. Would you like to set it up? (y/n)".yellow, true)
+          create = agree('Could not find fastlane in current directory. Would you like to set it up? (y/n)'.yellow, true)
           Fastlane::Setup.new.run if create
         end
       end
@@ -40,7 +39,7 @@ class FastlaneApplication
       c.syntax = 'fastlane init'
       c.description = 'Helps you setting up fastlane based on your existing tools.'
 
-      c.action do |args, options|
+      c.action do |_args, _options|
         Fastlane::Setup.new.run
       end
     end
@@ -49,7 +48,7 @@ class FastlaneApplication
       c.syntax = 'fastlane new_action'
       c.description = 'Create a new custom action for fastlane.'
 
-      c.action do |args, options|
+      c.action do |_args, _options|
         Fastlane::NewAction.run
       end
     end

data/lib/assets/FastfileTemplate

@@ -10,9 +10,15 @@ before_all do
 
   # sh "./customShellScript.sh"
 
+  cocoapods
+
   # increment_build_number
 
-  cocoapods
+  ipa({
+    workspace: "MyApp.xcworkspace",
+    configuration: "Debug",
+    scheme: "MyApp",
+  })
 
   xctool
 end

data/lib/fastlane.rb

@@ -1,28 +1,35 @@
 require 'json'
 require 'fastlane/version'
 require 'fastlane/fast_file'
-require 'fastlane/helper'
 require 'fastlane/dependency_checker'
 require 'fastlane/runner'
 require 'fastlane/setup'
 require 'fastlane/fastlane_folder'
-require 'fastlane/update_checker'
 require 'fastlane/junit_generator'
 require 'fastlane/lane_manager'
 require 'fastlane/actions/actions_helper'
 
+require 'fastlane_core'
+
 # Third Party code
 require 'colored'
 
 module Fastlane
-  TMP_FOLDER = "/tmp/fastlane/"
+  Helper = FastlaneCore::Helper # you gotta love Ruby: Helper.* should use the Helper class contained in FastlaneCore
 
-  UpdateChecker.verify_latest_version
+  FastlaneCore::UpdateChecker.verify_latest_version('fastlane', Fastlane::VERSION)
 
   Fastlane::Actions.load_default_actions
 
   if Fastlane::FastlaneFolder.path
-    actions_path = File.join(Fastlane::FastlaneFolder.path, "actions")
-    Fastlane::Actions.load_external_actions(actions_path) if File.directory?actions_path
+    actions_path = File.join(Fastlane::FastlaneFolder.path, 'actions')
+    Fastlane::Actions.load_external_actions(actions_path) if File.directory?(actions_path)
   end
 end
+
+
+class String
+  def classify
+    split('_').collect!(&:capitalize).join
+  end
+end

data/lib/fastlane/actions/actions_helper.rb

@@ -7,19 +7,19 @@ module Fastlane
     end
 
     def self.executed_actions
-      @@executed_actions ||= []
+      @executed_actions ||= []
     end
 
     # The shared hash can be accessed by any action and contains information like the screenshots path or beta URL
     def self.lane_context
-      @@lane_context ||= {}
+      @lane_context ||= {}
     end
 
     # Pass a block which should be tracked. One block = one testcase
     # @param step_name (String) the name of the currently built code (e.g. snapshot, sigh, ...)
     def self.execute_action(step_name)
-      raise "No block given".red unless block_given?
-      
+      raise 'No block given'.red unless block_given?
+
       start = Time.now
       error = nil
       exc = nil
@@ -34,7 +34,7 @@ module Fastlane
       # This is also called, when the block has a return statement
       duration = Time.now - start
 
-      self.executed_actions << {
+      executed_actions << {
         name: step_name,
         error: error,
         time: duration
@@ -46,33 +46,34 @@ module Fastlane
     # Execute a shell command
     # This method will output the string and execute it
     def self.sh(command)
-      return sh_no_action(command)
+      sh_no_action(command)
     end
 
     def self.sh_no_action(command)
-      command = command.join(" ") if command.kind_of?Array # since it's an array of one element when running from the Fastfile
-      Helper.log.info ["[SHELL COMMAND]", command.yellow].join(': ')
-
-      result = ""
-      unless Helper.is_test?
-
-        PTY.spawn(command) do |stdin, stdout, pid|
-          stdin.each do |line|
-            Helper.log.info ["[SHELL OUTPUT]", line.strip].join(': ')
+      command = command.join(' ') if command.is_a?(Array) # since it's an array of one element when running from the Fastfile
+      Helper.log.info ['[SHELL COMMAND]', command.yellow].join(': ')
+
+      result = ''
+      unless Helper.test?
+        exit_status = nil
+        status = IO.popen(command, err: [:child, :out]) do |io|
+          io.each do |line|
+            Helper.log.info ['[SHELL OUTPUT]', line.strip].join(': ')
             result << line
           end
-
-          Process.wait(pid)
+          io.close
+          exit_status = $?.to_i
         end
 
-        if $?.exitstatus.to_i != 0
-          raise "Exit status of command '#{command}' was #{$?.exitstatus.to_s} instead of 0. \n#{result}" # this will also append the output to the exception (for the Jenkins reports)
+        if exit_status != 0
+          # this will also append the output to the exception (for the Jenkins reports)
+          raise "Exit status of command '#{command}' was #{exit_status} instead of 0. \n#{result}"
         end
       else
         result << command # only for the tests
       end
 
-      return result
+      result
     end
 
     def self.load_default_actions
@@ -82,14 +83,14 @@ module Fastlane
     end
 
     def self.load_external_actions(path)
-      raise "You need to pass a valid path" unless File.exists?path
+      raise 'You need to pass a valid path' unless File.exist?(path)
 
       Dir[File.expand_path '*.rb', path].each do |file|
         require file
-        
-        file_name = File.basename(file).gsub(".rb", "")
 
-        class_name = file_name.classify + "Action"
+        file_name = File.basename(file).gsub('.rb', '')
+
+        class_name = file_name.classify + 'Action'
         class_ref = nil
         begin
           class_ref = Fastlane::Actions.const_get(class_name)
@@ -98,16 +99,16 @@ module Fastlane
             Helper.log.info "Successfully loaded custom action '#{file}'.".green
           else
             Helper.log.error "Could not find method 'run' in class #{class_name}.".red
-            Helper.log.error "For more information, check out the docs: https://github.com/KrauseFx/fastlane"
+            Helper.log.error 'For more information, check out the docs: https://github.com/KrauseFx/fastlane'
             raise "Plugin '#{file_name}' is damaged!"
           end
         rescue NameError => ex
           # Action not found
           Helper.log.error "Could not find '#{class_name}' class defined.".red
-          Helper.log.error "For more information, check out the docs: https://github.com/KrauseFx/fastlane"
+          Helper.log.error 'For more information, check out the docs: https://github.com/KrauseFx/fastlane'
           raise "Plugin '#{file_name}' is damaged!"
         end
       end
     end
   end
-end
+end

data/lib/fastlane/actions/crashlytics.rb

@@ -1,13 +1,13 @@
 # TODO: Workaround, since crashlytics.rb from shenzhen includes the code for commander.
-def command(param)
+def command(_param)
 end
 
 module Fastlane
   module Actions
     class CrashlyticsAction
       def self.run(params)
-        require "shenzhen"
-        require "shenzhen/plugins/crashlytics"
+        require 'shenzhen'
+        require 'shenzhen/plugins/crashlytics'
 
         assert_params_given!(params)
 
@@ -23,19 +23,19 @@ module Fastlane
 
         assert_valid_params!(crashlytics_path, api_token, build_secret, ipa_path)
 
-        Helper.log.info "Uploading the IPA to Crashlytics. Go for a coffee ☕️.".green
+        Helper.log.info 'Uploading the IPA to Crashlytics. Go for a coffee ☕️.'.green
 
-        return if Helper.is_test?
+        return if Helper.test?
 
         client = Shenzhen::Plugins::Crashlytics::Client.new(crashlytics_path, api_token, build_secret)
 
         response = client.upload_build(ipa_path, file: ipa_path, notes: notes_path, emails: emails, groups: groups)
 
         if response
-          Helper.log.info "Build successfully uploaded to Crashlytics".green
+          Helper.log.info 'Build successfully uploaded to Crashlytics'.green
         else
-          Helper.log.fatal "Error uploading to Crashlytics."
-          raise "Error when trying to upload ipa to Crashlytics".red
+          Helper.log.fatal 'Error uploading to Crashlytics.'
+          raise 'Error when trying to upload ipa to Crashlytics'.red
         end
       end
 
@@ -43,7 +43,7 @@ module Fastlane
 
       def self.assert_params_given!(params)
         return unless params.empty?
-        raise "You have to pass Crashlytics parameters to the Crashlytics action, take a look at https://github.com/KrauseFx/fastlane#crashlytics".red
+        raise 'You have to pass Crashlytics parameters to the Crashlytics action, take a look at https://github.com/KrauseFx/fastlane#crashlytics'.red
       end
 
       def self.assert_valid_params!(crashlytics_path, api_token, build_secret, ipa_path)
@@ -54,7 +54,7 @@ module Fastlane
       end
 
       def self.assert_valid_crashlytics_path!(crashlytics_path)
-        return if crashlytics_path && File.exists?(crashlytics_path)
+        return if crashlytics_path && File.exist?(crashlytics_path)
         raise "No Crashlytics path given or found, pass using `crashlytics_path: 'path'`".red
       end
 
@@ -69,12 +69,16 @@ module Fastlane
       end
 
       def self.assert_valid_ipa_path!(ipa_path)
-        return if ipa_path && File.exists?(ipa_path)
+        return if ipa_path && File.exist?(ipa_path)
         raise "No IPA file given or found, pass using `ipa_path: 'path/app.ipa'`".red
       end
 
-      private_class_method :assert_params_given!, :assert_valid_params!,
-        :assert_valid_crashlytics_path!, :assert_valid_api_token!, :assert_valid_build_secret!, :assert_valid_ipa_path!
+      private_class_method :assert_params_given!,
+                           :assert_valid_params!,
+                           :assert_valid_crashlytics_path!,
+                           :assert_valid_api_token!,
+                           :assert_valid_build_secret!,
+                           :assert_valid_ipa_path!
     end
   end
 end

data/lib/fastlane/actions/deliver.rb

@@ -1,28 +1,28 @@
 module Fastlane
   module Actions
     module SharedValues
-      
     end
 
     class DeliverAction
       def self.run(params)
         require 'deliver'
-        
-        ENV["DELIVER_SCREENSHOTS_PATH"] = Actions.lane_context[SharedValues::SNAPSHOT_SCREENSHOTS_PATH]
-        
+
+        ENV['DELIVER_SCREENSHOTS_PATH'] = Actions.lane_context[SharedValues::SNAPSHOT_SCREENSHOTS_PATH]
+
         force = params.include?(:force)
         beta = params.include?(:beta)
         skip_deploy = params.include?(:skip_deploy)
 
         Dir.chdir(FastlaneFolder.path || Dir.pwd) do
           # This should be executed in the fastlane folder
-          Deliver::Deliverer.new(nil, force: force, 
-                                is_beta_ipa: beta, 
-                                skip_deploy: skip_deploy)
+          Deliver::Deliverer.new(nil,
+                                 force: force,
+                                 is_beta_ipa: beta,
+                                 skip_deploy: skip_deploy)
 
-          Actions.lane_context[SharedValues::IPA_OUTPUT_PATH] = ENV["DELIVER_IPA_PATH"] # deliver will store it in the environment
+          Actions.lane_context[SharedValues::IPA_OUTPUT_PATH] = ENV['DELIVER_IPA_PATH'] # deliver will store it in the environment
         end
       end
     end
   end
-end
+end

data/lib/fastlane/actions/deploygate.rb

@@ -1,5 +1,5 @@
 # TODO: Workaround, since deploygate.rb from shenzhen includes the code for commander
-def command(param)
+def command(_param)
 end
 
 module Fastlane
@@ -19,35 +19,34 @@ module Fastlane
 
         # Available options: https://deploygate.com/docs/api
         options = {
-          ipa: Actions.lane_context[SharedValues::IPA_OUTPUT_PATH],
+          ipa: Actions.lane_context[SharedValues::IPA_OUTPUT_PATH]
         }.merge(params.first || {})
         assert_options!(options)
 
-        Helper.log.info "Starting with ipa upload to DeployGate... this could take some time ⏳".green
+        Helper.log.info 'Starting with ipa upload to DeployGate... this could take some time ⏳'.green
         client = Shenzhen::Plugins::DeployGate::Client.new(
           options.delete(:api_token),
           options.delete(:user)
         )
 
-        return if Helper.is_test?
+        return if Helper.test?
 
         response = client.upload_build(options.delete(:ipa), options)
         if parse_response(response)
           Helper.log.info "DeployGate URL: #{Actions.lane_context[SharedValues::DEPLOYGATE_URL]}"
           Helper.log.info "Build successfully uploaded to DeployGate as revision \##{Actions.lane_context[SharedValues::DEPLOYGATE_REVISION]}!".green
         else
-          raise "Error when trying to upload ipa to DeployGate".red
+          raise 'Error when trying to upload ipa to DeployGate'.red
         end
       end
 
-      private
-
       def self.assert_options!(options)
         raise "No API Token for DeployGate given, pass using `api_token: 'token'`".red unless options[:api_token].to_s.length > 0
         raise "No User for app given, pass using `user: 'user'`".red unless options[:user].to_s.length > 0
         raise "No IPA file given or found, pass using `ipa: 'path.ipa'`".red unless options[:ipa]
-        raise "IPA file on path '#{File.expand_path(options[:ipa])}' not found".red unless File.exists?(options[:ipa])
+        raise "IPA file on path '#{File.expand_path(options[:ipa])}' not found".red unless File.exist?(options[:ipa])
       end
+      private_class_method :assert_options!
 
       def self.parse_response(response)
         if response.body && response.body.key?('error')
@@ -69,19 +68,21 @@ module Fastlane
         end
         true
       end
+      private_class_method :parse_response
 
       def self.help_message(response)
         message =
           case response.body['message']
             when 'you are not authenticated'
-              "Invalid API Token specified."
+              'Invalid API Token specified.'
             when 'application create error: permit'
-              "Access denied: May be trying to upload to wrong user or updating app you join as a tester?"
+              'Access denied: May be trying to upload to wrong user or updating app you join as a tester?'
             when 'application create error: limit'
-              "Plan limit: You have reached to the limit of current plan or your plan was expired."
+              'Plan limit: You have reached to the limit of current plan or your plan was expired.'
           end
         Helper.log.error message.red if message
       end
+      private_class_method :help_message
     end
   end
-end
+end