fastlane 0.1.8 → 0.1.9

data/lib/fastlane/actions/frameit.rb

@@ -1,17 +1,16 @@
 module Fastlane
   module Actions
     module SharedValues
-      
     end
 
     class FrameitAction
       def self.run(params)
-        return if Helper.is_test?
-        
+        return if Helper.test?
+
         require 'frameit'
 
         color = Frameit::Editor::Color::BLACK
-        color = Frameit::Editor::Color::SILVER if [:silver, :white].include?params.first
+        color = Frameit::Editor::Color::SILVER if [:silver, :white].include?(params.first)
 
         screenshots_folder = Actions.lane_context[SharedValues::SNAPSHOT_SCREENSHOTS_PATH]
         screenshots_folder ||= FastlaneFolder.path
@@ -22,4 +21,4 @@ module Fastlane
       end
     end
   end
-end
+end

data/lib/fastlane/actions/hipchat.rb

@@ -1,7 +1,6 @@
 module Fastlane
   module Actions
     module SharedValues
-
     end
 
     class HipchatAction
@@ -14,58 +13,69 @@ module Fastlane
         require 'net/http'
         require 'uri'
 
-        api_token = ENV["HIPCHAT_API_TOKEN"]
-        api_version = ENV["HIPCHAT_API_VERSION"]
+        api_token = ENV['HIPCHAT_API_TOKEN']
+        api_version = ENV['HIPCHAT_API_VERSION']
 
         unless api_token
           Helper.log.fatal "Please add 'ENV[\"HIPCHAT_API_TOKEN\"] = \"your token\"' to your Fastfile's `before_all` section.".red
-          raise "No HIPCHAT_API_TOKEN given.".red
+          raise 'No HIPCHAT_API_TOKEN given.'.red
         end
-        if api_version.nil? or ![1,2].include?api_version[0].to_i
+        if api_version.nil? || ![1, 2].include?(api_version[0].to_i)
           Helper.log.fatal "Please add 'ENV[\"HIPCHAT_API_VERSION\"] = \"1 or 2\"' to your Fastfile's `before_all` section.".red
-          raise "No HIPCHAT_API_VERSION given.".red
+          raise 'No HIPCHAT_API_VERSION given.'.red
         end
 
         channel = options[:channel]
         color = (options[:success] ? 'green' : 'red')
-        message = "<table><tr><td><img src=\"https://s3-eu-west-1.amazonaws.com/fastlane.tools/fastlane.png\" style=\"width:50px;height:auto\"></td><td>" + options[:message] + "</td></tr></table>"
+        message = "<table><tr><td><img src=\"https://s3-eu-west-1.amazonaws.com/fastlane.tools/fastlane.png\" width=\"50\" height=\"50\"></td><td>" + options[:message] + '</td></tr></table>'
 
         if api_version.to_i == 1
           ########## running on V1 ##########
-          if isUser(channel)
-            raise "HipChat private message not working with API V1 please use API V2 instead".red
+          if user?(channel)
+            raise 'HipChat private message not working with API V1 please use API V2 instead'.red
           else
             uri = URI.parse('https://api.hipchat.com/v1/rooms/message')
-            response = Net::HTTP.post_form(uri, {"from" => "fastlane", "auth_token" => api_token, "color" => color, "message_format" => "html", "room_id" => channel, "message" => message})
-            checkResponseCodeForRoom(response, channel)
+            response = Net::HTTP.post_form(uri, { 'from' => 'fastlane',
+                                                  'auth_token' => api_token,
+                                                  'color' => color,
+                                                  'message_format' => 'html',
+                                                  'room_id' => channel,
+                                                  'message' => message })
+
+            check_response_code(response, channel)
           end
         else
           ########## running on V2 ##########
-          if isUser(channel)
+          if user?(channel)
             channel.slice!(0)
-            params = {'message' => message, 'message_format' => 'html'}
-            json_headers = {"Content-Type" => "application/json",
-                            "Accept" => "application/json", "Authorization" => "Bearer #{api_token}"}
+            params = { 'message' => message, 'message_format' => 'html' }
+            json_headers = { 'Content-Type' => 'application/json',
+                             'Accept' => 'application/json', 'Authorization' => "Bearer #{api_token}" }
 
             uri = URI.parse("https://api.hipchat.com/v2/user/#{channel}/message")
             http = Net::HTTP.new(uri.host, uri.port)
             http.use_ssl = true
 
             response = http.post(uri.path, params.to_json, json_headers)
-            checkResponseCode(response, channel)
+            check_response_code(response, channel)
           else
             uri = URI.parse("https://api.hipchat.com/v2/room/#{channel}/notification")
-            response = Net::HTTP.post_form(uri, {"from" => "fastlane", "auth_token" => api_token, "color" => color, "message_format" => "html", "message" => message})
-            checkResponseCode(response, channel)
+            response = Net::HTTP.post_form(uri, { 'from' => 'fastlane',
+                                                  'auth_token' => api_token,
+                                                  'color' => color,
+                                                  'message_format' => 'html',
+                                                  'message' => message })
+
+            check_response_code(response, channel)
           end
         end
       end
 
-      def self.isUser(channel)
-        return channel.to_s.start_with?('@')
+      def self.user?(channel)
+        channel.to_s.start_with?('@')
       end
 
-      def self.checkResponseCode(response, channel)
+      def self.check_response_code(response, channel)
         case response.code.to_i
           when 200, 204
             true

data/lib/fastlane/actions/hockey.rb

@@ -1,5 +1,5 @@
 # TODO: Workaround, since hockeyapp.rb from shenzhen includes the code for commander
-def command(param)
+def command(_param)
 end
 
 module Fastlane
@@ -13,7 +13,7 @@ module Fastlane
       def self.run(params)
         # Available options: http://support.hockeyapp.net/kb/api/api-versions#upload-version
         options = {
-          notes: "No changelog given",
+          notes: 'No changelog given',
           status: 2,
           notify: 1
         }.merge(params.first)
@@ -26,26 +26,27 @@ module Fastlane
 
         raise "No API Token for Hockey given, pass using `api_token: 'token'`".red unless options[:api_token].to_s.length > 0
         raise "No IPA file given or found, pass using `ipa: 'path.ipa'`".red unless options[:ipa]
-        raise "IPA file on path '#{File.expand_path(options[:ipa])}' not found".red unless File.exists?(options[:ipa])
+        raise "IPA file on path '#{File.expand_path(options[:ipa])}' not found".red unless File.exist?(options[:ipa])
 
         if options[:dsym]
           options[:dsym_filename] = options[:dsym]
-        else  
-          dsym_path = options[:ipa].gsub("ipa", "app.dSYM.zip")
-          if File.exists?(dsym_path)
+        else
+          dsym_path = options[:ipa].gsub('ipa', 'app.dSYM.zip')
+          if File.exist?(dsym_path)
             options[:dsym_filename] = dsym_path
           else
             Helper.log.info "Symbols not found on path #{File.expand_path(dsym_path)}. Crashes won't be symbolicated properly".yellow
           end
         end
 
-        raise "Symbols on path '#{File.expand_path(options[:dsym_filename])}' not found".red if (options[:dsym_filename] && !File.exists?(options[:dsym_filename])) 
+        raise "Symbols on path '#{File.expand_path(options[:dsym_filename])}' not found".red if (options[:dsym_filename] &&
+                                                                                                !File.exist?(options[:dsym_filename]))
+
+        Helper.log.info 'Starting with ipa upload to HockeyApp... this could take some time.'.green
 
-        Helper.log.info "Starting with ipa upload to HockeyApp... this could take some time.".green
-        
         client = Shenzhen::Plugins::HockeyApp::Client.new(options[:api_token])
 
-        return if Helper.is_test?
+        return if Helper.test?
 
         response = client.upload_build(options[:ipa], options)
         case response.status
@@ -54,14 +55,14 @@ module Fastlane
 
             Actions.lane_context[SharedValues::HOCKEY_DOWNLOAD_LINK] = url
             Actions.lane_context[SharedValues::HOCKEY_BUILD_INFORMATION] = response.body
-            
+
             Helper.log.info "Public Download URL: #{url}" if url
-            Helper.log.info "Build successfully uploaded to HockeyApp!".green
+            Helper.log.info 'Build successfully uploaded to HockeyApp!'.green
           else
             Helper.log.fatal "Error uploading to HockeyApp: #{response.body}"
-            raise "Error when trying to upload ipa to HockeyApp".red
+            raise 'Error when trying to upload ipa to HockeyApp'.red
           end
       end
     end
   end
-end
+end

data/lib/fastlane/actions/increment_build_number.rb

@@ -6,7 +6,7 @@ module Fastlane
 
     class IncrementBuildNumberAction
       def self.run(params)
-        # More information about how to set up your project and how it works: 
+        # More information about how to set up your project and how it works:
         # https://developer.apple.com/library/ios/qa/qa1827/_index.html
         # Attention: This is NOT the version number - but the build number
 
@@ -17,10 +17,10 @@ module Fastlane
           if custom_number
             command = "agvtool new-version -all #{custom_number}"
           else
-            command = "agvtool next-version -all"
+            command = 'agvtool next-version -all'
           end
 
-          if Helper.is_test?
+          if Helper.test?
             Actions.lane_context[SharedValues::BUILD_NUMBER] = command
           else
 
@@ -33,10 +33,10 @@ module Fastlane
 
           end
         rescue => ex
-          Helper.log.error "Make sure to to follow the steps to setup your Xcode project: https://developer.apple.com/library/ios/qa/qa1827/_index.html".yellow
+          Helper.log.error 'Make sure to to follow the steps to setup your Xcode project: https://developer.apple.com/library/ios/qa/qa1827/_index.html'.yellow
           raise ex
         end
       end
     end
   end
-end
+end

data/lib/fastlane/actions/install_cocapods.rb

@@ -1,9 +1,9 @@
 module Fastlane
   module Actions
     class CocoapodsAction
-      def self.run(params)
-        Actions.sh("pod install")
+      def self.run(_params)
+        Actions.sh('pod install')
       end
     end
   end
-end
+end

data/lib/fastlane/actions/ipa.rb

@@ -1,24 +1,23 @@
 module Fastlane
   module Actions
-
     module SharedValues
       IPA_OUTPUT_PATH = :IPA_OUTPUT_PATH
       DSYM_OUTPUT_PATH = :DSYM_OUTPUT_PATH
     end
 
-    # -w, --workspace WORKSPACE Workspace (.xcworkspace) file to use to build app (automatically detected in current directory) 
-    # -p, --project PROJECT Project (.xcodeproj) file to use to build app (automatically detected in current directory, overridden by --workspace option, if passed) 
-    # -c, --configuration CONFIGURATION Configuration used to build 
-    # -s, --scheme SCHEME  Scheme used to build app 
-    # --xcconfig XCCONFIG  use an extra XCCONFIG file to build the app 
-    # --xcargs XCARGS      pass additional arguments to xcodebuild when building the app. Be sure to quote multiple args. 
-    # --[no-]clean         Clean project before building 
-    # --[no-]archive       Archive project after building 
-    # -d, --destination DESTINATION Destination. Defaults to current directory 
-    # -m, --embed PROVISION Sign .ipa file with .mobileprovision 
-    # -i, --identity IDENTITY Identity to be used along with --embed 
-    # --sdk SDK            use SDK as the name or path of the base SDK when building the project 
-    # --ipa IPA            specify the name of the .ipa file to generate (including file extension) 
+    # -w, --workspace WORKSPACE Workspace (.xcworkspace) file to use to build app (automatically detected in current directory)
+    # -p, --project PROJECT Project (.xcodeproj) file to use to build app (automatically detected in current directory, overridden by --workspace option, if passed)
+    # -c, --configuration CONFIGURATION Configuration used to build
+    # -s, --scheme SCHEME  Scheme used to build app
+    # --xcconfig XCCONFIG  use an extra XCCONFIG file to build the app
+    # --xcargs XCARGS      pass additional arguments to xcodebuild when building the app. Be sure to quote multiple args.
+    # --[no-]clean         Clean project before building
+    # --[no-]archive       Archive project after building
+    # -d, --destination DESTINATION Destination. Defaults to current directory
+    # -m, --embed PROVISION Sign .ipa file with .mobileprovision
+    # -i, --identity IDENTITY Identity to be used along with --embed
+    # --sdk SDK            use SDK as the name or path of the base SDK when building the project
+    # --ipa IPA            specify the name of the .ipa file to generate (including file extension)
 
     ARGS_MAP = {
       workspace: '-w',
@@ -36,7 +35,6 @@ module Fastlane
 
     class IpaAction
       def self.run(params)
-        
         # The args we will build with
         build_args = nil
 
@@ -61,10 +59,10 @@ module Fastlane
         # If no dest directory given, default to current directory
         absolute_dest_directory ||= Dir.pwd
 
-        if Helper.is_test?
-          Actions.lane_context[SharedValues::IPA_OUTPUT_PATH] = File.join(absolute_dest_directory, "test.ipa")
-          Actions.lane_context[SharedValues::DSYM_OUTPUT_PATH] = File.join(absolute_dest_directory, "test.app.dSYM.zip")
-          return build_args 
+        if Helper.test?
+          Actions.lane_context[SharedValues::IPA_OUTPUT_PATH] = File.join(absolute_dest_directory, 'test.ipa')
+          Actions.lane_context[SharedValues::DSYM_OUTPUT_PATH] = File.join(absolute_dest_directory, 'test.app.dSYM.zip')
+          return build_args
         end
 
         # Joins args into space delimited string
@@ -73,7 +71,7 @@ module Fastlane
         command = "ipa build #{build_args}"
         Helper.log.debug command
         Actions.sh command
-        
+
         # Finds absolute path of IPA and dSYM
         absolute_ipa_path = find_ipa_file(absolute_dest_directory)
         absolute_dsym_path = find_dsym_file(absolute_dest_directory)
@@ -87,13 +85,13 @@ module Fastlane
 
       def self.params_to_build_args(params)
         # Remove nil value params unless :clean or :archive
-        params = params.delete_if { |k, v| (k != :clean && k != :archive ) && v.nil? }
+        params = params.delete_if { |k, v| (k != :clean && k != :archive) && v.nil? }
 
         # Maps nice developer param names to Shenzhen's `ipa build` arguments
-        params.collect do |k,v|
+        params.collect do |k, v|
           v ||= ''
           if args = ARGS_MAP[k]
-            value = (v.to_s.length > 0 ? "\"#{v}\"" : "")
+            value = (v.to_s.length > 0 ? "\"#{v}\"" : '')
             "#{ARGS_MAP[k]} #{value}".strip
           end
         end.compact
@@ -101,15 +99,13 @@ module Fastlane
 
       def self.find_ipa_file(dir)
         # Finds last modified .ipa in the destination directory
-        Dir[File.join(dir, "*.ipa")].sort { |a,b| File.mtime(b) <=> File.mtime(a) }.first
+        Dir[File.join(dir, '*.ipa')].sort { |a, b| File.mtime(b) <=> File.mtime(a) }.first
       end
 
       def self.find_dsym_file(dir)
         # Finds last modified .dSYM.zip in the destination directory
-        Dir[File.join(dir, "*.dSYM.zip")].sort { |a,b| File.mtime(b) <=> File.mtime(a) }.first
+        Dir[File.join(dir, '*.dSYM.zip')].sort { |a, b| File.mtime(b) <=> File.mtime(a) }.first
       end
-
     end
-
   end
-end
+end

data/lib/fastlane/actions/produce.rb

@@ -7,29 +7,28 @@ module Fastlane
     class ProduceAction
       def self.run(params)
         require 'produce'
-        
+
         hash = params.first || {}
-        raise "Parameter of produce must be a hash".red unless hash.kind_of?Hash
+        raise 'Parameter of produce must be a hash'.red unless hash.is_a?(Hash)
 
         hash.each do |key, value|
           ENV[key.to_s.upcase] = value.to_s
         end
 
-        return if Helper.is_test?
+        return if Helper.test?
 
         Dir.chdir(FastlaneFolder.path || Dir.pwd) do
           # This should be executed in the fastlane folder
-          
+
           CredentialsManager::PasswordManager.shared_manager(ENV['PRODUCE_USERNAME']) if ENV['PRODUCE_USERNAME']
           Produce::Config.shared_config # to ask for missing information right in the beginning
-          
-          apple_id = Produce::Manager.start_producing.to_s
 
+          apple_id = Produce::Manager.start_producing.to_s
 
           Actions.lane_context[SharedValues::PRODUCE_APPLE_ID] = apple_id
-          ENV["PRODUCE_APPLE_ID"] = apple_id
+          ENV['PRODUCE_APPLE_ID'] = apple_id
         end
       end
     end
   end
-end
+end

data/lib/fastlane/actions/say.rb

@@ -7,4 +7,4 @@ module Fastlane
       end
     end
   end
-end
+end

data/lib/fastlane/actions/sigh.rb

@@ -9,16 +9,16 @@ module Fastlane
         require 'sigh'
         require 'credentials_manager/appfile_config'
 
-        type = Sigh::DeveloperCenter::APPSTORE
-        type = Sigh::DeveloperCenter::ADHOC if params.include? :adhoc
-        type = Sigh::DeveloperCenter::DEVELOPMENT if params.include? :development
-        
-        return type if Helper.is_test?
+        type = FastlaneCore::DeveloperCenter::APPSTORE
+        type = FastlaneCore::DeveloperCenter::ADHOC if params.include? :adhoc
+        type = FastlaneCore::DeveloperCenter::DEVELOPMENT if params.include? :development
+
+        return type if Helper.test?
 
         app = CredentialsManager::AppfileConfig.try_fetch_value(:app_identifier)
-        raise "No app_identifier definied in `./fastlane/Appfile`".red unless app
+        raise 'No app_identifier definied in `./fastlane/Appfile`'.red unless app
 
-        path = Sigh::DeveloperCenter.new.run(app, type)
+        path = FastlaneCore::DeveloperCenter.new.run(app, type)
         output_path = File.expand_path(File.join('.', File.basename(path)))
         FileUtils.mv(path, output_path)
         Helper.log.info "Exported provisioning profile to '#{output_path}'".green

data/lib/fastlane/actions/slack.rb

@@ -1,7 +1,6 @@
 module Fastlane
   module Actions
     module SharedValues
-
     end
 
     class SlackAction
@@ -9,7 +8,7 @@ module Fastlane
         return ENV['GIT_BRANCH'] if ENV['GIT_BRANCH'].to_s.length > 0 # set by Jenkins
         s = `git rev-parse --abbrev-ref HEAD`
         return s if s.to_s.length > 0
-        return nil
+        nil
       end
 
       def self.git_author
@@ -24,7 +23,7 @@ module Fastlane
       def self.last_git_commit
         s = `git log -1 --pretty=%B`.strip
         return s if s.to_s.length > 0
-        return nil
+        nil
       end
 
       def self.run(params)
@@ -38,18 +37,18 @@ module Fastlane
         color = (options[:success] ? 'good' : 'danger')
         options[:message] = Slack::Notifier::LinkFormatter.format(options[:message])
 
-        url = ENV["SLACK_URL"]
+        url = ENV['SLACK_URL']
         unless url
           Helper.log.fatal "Please add 'ENV[\"SLACK_URL\"] = \"https://hooks.slack.com/services/...\"' to your Fastfile's `before_all` section.".red
-          raise "No SLACK_URL given.".red
+          raise 'No SLACK_URL given.'.red
         end
 
         notifier = Slack::Notifier.new url
 
         notifier.username = 'fastlane'
         if options[:channel].to_s.length > 0
-          notifier.channel = options[:channel] 
-          notifier.channel = ('#' + notifier.channel) unless ["#", "@"].include?notifier.channel[0] # send message to channel by default
+          notifier.channel = options[:channel]
+          notifier.channel = ('#' + notifier.channel) unless ['#', '@'].include?(notifier.channel[0]) # send message to channel by default
         end
 
         test_result = {
@@ -58,13 +57,13 @@ module Fastlane
           color: color,
           fields: [
             {
-              title: "Lane",
+              title: 'Lane',
               value: Actions.lane_context[Actions::SharedValues::LANE_NAME],
               short: true
             },
             {
-              title: "Test Result",
-              value: (options[:success] ? "Success" : "Error"),
+              title: 'Test Result',
+              value: (options[:success] ? 'Success' : 'Error'),
               short: true
             }
           ]
@@ -72,18 +71,18 @@ module Fastlane
 
         if git_branch
           test_result[:fields] << {
-            title: "Git Branch",
+            title: 'Git Branch',
             value: git_branch,
             short: true
           }
         end
 
         if git_author
-          if ENV["FASTLANE_SLACK_HIDE_AUTHOR_ON_SUCCESS"] and success
+          if ENV['FASTLANE_SLACK_HIDE_AUTHOR_ON_SUCCESS'] && success
             # We only show the git author if the build failed
           else
             test_result[:fields] << {
-              title: "Git Author",
+              title: 'Git Author',
               value: git_author,
               short: true
             }
@@ -92,21 +91,21 @@ module Fastlane
 
         if last_git_commit
           test_result[:fields] << {
-            title: "Git Commit",
+            title: 'Git Commit',
             value: last_git_commit,
             short: false
           }
         end
 
-        result = notifier.ping "",
-                      icon_url: 'https://s3-eu-west-1.amazonaws.com/fastlane.tools/fastlane.png',
-                      attachments: [test_result]
+        result = notifier.ping '',
+                               icon_url: 'https://s3-eu-west-1.amazonaws.com/fastlane.tools/fastlane.png',
+                               attachments: [test_result]
 
         unless result.code.to_i == 200
           Helper.log.debug result
-          raise "Error pushing Slack message, maybe the integration has no permission to post on this channel? Try removing the channel parameter in your Fastfile.".red
+          raise 'Error pushing Slack message, maybe the integration has no permission to post on this channel? Try removing the channel parameter in your Fastfile.'.red
         else
-          Helper.log.info "Successfully sent Slack notification".green
+          Helper.log.info 'Successfully sent Slack notification'.green
         end
       end
     end