fastlane 0.1.8 → 0.1.9

data/lib/fastlane/actions/snapshot.rb

@@ -10,9 +10,9 @@ module Fastlane
         clean = false if params.include?(:noclean)
         $verbose = true if params.include?(:verbose)
 
-        if Helper.is_test?
+        if Helper.test?
           Actions.lane_context[SharedValues::SNAPSHOT_SCREENSHOTS_PATH] = Dir.pwd
-          return clean 
+          return clean
         end
 
         require 'snapshot'
@@ -28,4 +28,4 @@ module Fastlane
       end
     end
   end
-end
+end

data/lib/fastlane/actions/team_id.rb

@@ -0,0 +1,19 @@
+module Fastlane
+  module Actions
+    module SharedValues
+    end
+
+    class TeamIdAction
+      def self.run(params)
+        team = params.first
+        raise "Please pass your Team ID (e.g. team_id 'Q2CBPK58CA')".red unless team.to_s.length > 0
+
+        Helper.log.info "Setting Team ID to '#{team}' for all build steps"
+
+        [:CERT_TEAM_ID, :SIGH_TEAM_ID, :PEM_TEAM_ID, :PRODUCE_TEAM_ID, :SIGH_TEAM_ID, :FASTLANE_TEAM_ID].each do |current|
+          ENV[current.to_s] = team
+        end
+      end
+    end
+  end
+end

data/lib/fastlane/actions/testmunk.rb

@@ -1,22 +1,21 @@
 # How it works:
-# You can run your functional calabash testcases on real ios hardware. Follow the steps to set up your free account on testmunk.com or see below. After tests are executed you will get an email with test results. An API extension to see test results directly in Jenkins is in the works.
+# You can run your functional calabash testcases on real ios hardware.
+# Follow the steps to set up your free account on testmunk.com or see below.
+# After tests are executed you will get an email with test results.
+# An API extension to see test results directly in Jenkins is in the works.
 
-
-# Setup 
+# Setup
 # 1) Create a free account on testmunk.com
 # 2) Create an own project under your account (top right) after you are logged in. You will need to use this project name within your REST API upload path.
 # 3) Upload testcases (features in calabash) over the testmunk REST API (http://docs.testmunk.com/en/latest/rest.html#upload-testcases).
 
-
 module Fastlane
   module Actions
     module SharedValues
-      
     end
 
     class TestmunkAction
-      def self.run(params)
-        
+      def self.run(_params)
         raise "Please pass your Testmunk email address using `ENV['TESTMUNK_EMAIL'] = 'value'`" unless ENV['TESTMUNK_EMAIL']
         raise "Please pass your Testmunk API Key using `ENV['TESTMUNK_API'] = 'value'`" unless ENV['TESTMUNK_API']
         raise "Please pass your Testmunk app name using `ENV['TESTMUNK_APP'] = 'value'`" unless ENV['TESTMUNK_APP']
@@ -24,7 +23,7 @@ module Fastlane
         ipa_path = ENV['TESTMUNK_IPA'] || ENV[Actions::SharedValues::IPA_OUTPUT_PATH.to_s]
         raise "Please pass a path to your ipa file using `ENV['TESTMUNK_IPA'] = 'value'`" unless ipa_path
 
-        Helper.log.info "Testmunk: Uploading the .ipa and starting your tests".green
+        Helper.log.info 'Testmunk: Uploading the .ipa and starting your tests'.green
 
         response = system("#{"curl -H 'Accept: application/vnd.testmunk.v1+json'" +
             " -F 'file=@#{ipa_path}' -F 'autoStart=true'" +
@@ -32,11 +31,11 @@ module Fastlane
             " https://#{ENV['TESTMUNK_API']}@api.testmunk.com/apps/#{ENV['TESTMUNK_APP']}/testruns"}")
 
         if response
-          Helper.log.info "Your tests are being executed right now. Please wait for the mail with results and decide if you want to continue.".green
+          Helper.log.info 'Your tests are being executed right now. Please wait for the mail with results and decide if you want to continue.'.green
         else
-          raise "Something went wrong while uploading your app to Testmunk".red
+          raise 'Something went wrong while uploading your app to Testmunk'.red
         end
       end
     end
   end
-end
+end

data/lib/fastlane/actions/xctool.rb

@@ -2,12 +2,12 @@ module Fastlane
   module Actions
     class XctoolAction
       def self.run(params)
-        unless Helper.is_test?
-          raise "xctool not installed, please install using `brew install xctool`".red if `which xctool`.length == 0
+        unless Helper.test?
+          raise 'xctool not installed, please install using `brew install xctool`'.red if `which xctool`.length == 0
         end
-        
-        Actions.sh("xctool " + params.join(" "))
+
+        Actions.sh('xctool ' + params.join(' '))
       end
     end
   end
-end
+end

data/lib/fastlane/dependency_checker.rb

@@ -1,18 +1,18 @@
 module Fastlane
   class DependencyChecker
     def self.check_dependencies
-      self.check_xcode_select unless Helper.is_test?
+      check_xcode_select unless Helper.test?
     end
-  
+
     def self.check_xcode_select
-      unless `xcode-select -v`.include?"xcode-select version "
+      unless `xcode-select -v`.include?('xcode-select version ')
         Helper.log.fatal '#############################################################'
-        Helper.log.fatal "# You have to install the Xcode commdand line tools to use fastlane"
-        Helper.log.fatal "# Install the latest version of Xcode from the AppStore"
-        Helper.log.fatal "# Run xcode-select --install to install the developer tools"
+        Helper.log.fatal '# You have to install the Xcode commdand line tools to use fastlane'
+        Helper.log.fatal '# Install the latest version of Xcode from the AppStore'
+        Helper.log.fatal '# Run xcode-select --install to install the developer tools'
         Helper.log.fatal '#############################################################'
         raise "Run 'xcode-select --install' and start fastlane again"
       end
     end
   end
-end
+end

data/lib/fastlane/fast_file.rb

@@ -4,13 +4,12 @@ module Fastlane
 
     # @return The runner which can be executed to trigger the given actions
     def initialize(path = nil)
-      if (path || '').length > 0
-        raise "Could not find Fastfile at path '#{path}'".red unless File.exists?path
-        @path = path
-        content = File.read(path)
+      return unless (path || '').length > 0
+      raise "Could not find Fastfile at path '#{path}'".red unless File.exist?(path)
+      @path = path
+      content = File.read(path)
 
-        parse(content)
-      end
+      parse(content)
     end
 
     def parse(data)
@@ -20,7 +19,7 @@ module Fastlane
         eval(data) # this is okay in this case
       end
 
-      return self
+      self
     end
 
     def lane(key, &block)
@@ -44,12 +43,12 @@ module Fastlane
       # Overwrite this, since there is already a 'say' method defined in the Ruby standard library
       value ||= yield
       Actions.execute_action('say') do
-        Fastlane::Actions::SayAction.run([value])  
+        Fastlane::Actions::SayAction.run([value])
       end
     end
 
     def actions_path(path)
-      raise "Path '#{path}' not found!".red unless File.directory?path
+      raise "Path '#{path}' not found!".red unless File.directory?(path)
 
       Actions.load_external_actions(path)
     end
@@ -61,10 +60,10 @@ module Fastlane
       end
     end
 
-    def method_missing(method_sym, *arguments, &block)
+    def method_missing(method_sym, *arguments, &_block)
       # First, check if there is a predefined method in the actions folder
 
-      class_name = method_sym.to_s.classify + "Action"
+      class_name = method_sym.to_s.classify + 'Action'
       class_ref = nil
       begin
         class_ref = Fastlane::Actions.const_get(class_name)
@@ -73,10 +72,10 @@ module Fastlane
         raise "Could not find method '#{method_sym}'. Check out the README for more details: https://github.com/KrauseFx/fastlane".red
       end
 
-      if class_ref and class_ref.respond_to?(:run)
+      if class_ref && class_ref.respond_to?(:run)
         Helper.log.info "Step: #{method_sym.to_s}".green
 
-        Dir.chdir("..") do # go up from the fastlane folder, to the project folder
+        Dir.chdir('..') do # go up from the fastlane folder, to the project folder
           Actions.execute_action(method_sym) do
             class_ref.run(arguments)
           end
@@ -86,4 +85,4 @@ module Fastlane
       end
     end
   end
-end
+end

data/lib/fastlane/fastlane_folder.rb

@@ -1,18 +1,18 @@
 module Fastlane
   class FastlaneFolder
     FOLDER_NAME = 'fastlane'
-    
+
     def self.path
-      return "./#{FOLDER_NAME}/" if File.directory?"./#{FOLDER_NAME}/"
-      return "./.#{FOLDER_NAME}/" if File.directory?"./.#{FOLDER_NAME}/" # hidden folder
-      return "./" if File.basename(Dir.getwd) == FOLDER_NAME and File.exists?"Fastfile" # inside the folder
-      return "./" if File.basename(Dir.getwd) == FOLDER_NAME and File.exists?"Fastfile" # inside the folder and hidden
-      return nil
+      return "./#{FOLDER_NAME}/" if File.directory?("./#{FOLDER_NAME}/")
+      return "./.#{FOLDER_NAME}/" if File.directory?("./.#{FOLDER_NAME}/") # hidden folder
+      return './' if File.basename(Dir.getwd) == FOLDER_NAME && File.exist?('Fastfile') # inside the folder
+      return './' if File.basename(Dir.getwd) == FOLDER_NAME && File.exist?('Fastfile') # inside the folder and hidden
+      nil
     end
 
     def self.setup?
-      return false unless self.path
-      return File.exists?self.path
+      return false unless path
+      File.exist?(path)
     end
 
     def self.create_folder!
@@ -21,4 +21,4 @@ module Fastlane
       Helper.log.info "Created new folder '#{path}'.".green
     end
   end
-end
+end

data/lib/fastlane/junit_generator.rb

@@ -7,26 +7,25 @@ module Fastlane
       # And http://nelsonwells.net/2012/09/how-jenkins-ci-parses-and-displays-junit-output/
 
       containing_folder = Fastlane::FastlaneFolder.path || Dir.pwd
-      path = File.join(containing_folder, "report.xml")
-
+      path = File.join(containing_folder, 'report.xml')
 
       builder = Nokogiri::XML::Builder.new(encoding: 'UTF-8') do |xml|
-        xml.testsuites(name: "fastlane") {
-          xml.testsuite(name: "deploy") {
+        xml.testsuites(name: 'fastlane') do
+          xml.testsuite(name: 'deploy') do
             results.each_with_index do |current, index|
-              xml.testcase(name: [index, current[:name]].join(": "), time: current[:time]) {
+              xml.testcase(name: [index, current[:name]].join(': '), time: current[:time]) do
                 xml.failure(message: current[:error]) if current[:error]
                 xml.system_out current[:output] if current[:output]
-              }
+              end
             end
-          }
-        }
+          end
+        end
       end
-      result = builder.to_xml.gsub("system_", "system-").gsub("", " ") # Jenkins can not parse 'ESC' symbol
+      result = builder.to_xml.gsub('system_', 'system-').gsub("", ' ') # Jenkins can not parse 'ESC' symbol
 
       File.write(path, result)
 
-      return path
+      path
     end
   end
-end
+end

data/lib/fastlane/lane_manager.rb

@@ -1,7 +1,7 @@
 module Fastlane
   class LaneManager
     def self.cruise_lanes(lanes)
-      raise "lanes must be an array" unless lanes.kind_of?Array
+      raise 'lanes must be an array' unless lanes.is_a?(Array)
       ff = Fastlane::FastFile.new(File.join(Fastlane::FastlaneFolder.path, 'Fastfile'))
 
       if lanes.count == 0
@@ -16,7 +16,7 @@ module Fastlane
         end
       rescue => ex
         if Actions.lane_context.count > 0
-          Helper.log.info "Variable Dump:".yellow
+          Helper.log.info 'Variable Dump:'.yellow
           Helper.log.info Actions.lane_context
         end
         Helper.log.fatal ex
@@ -32,12 +32,12 @@ module Fastlane
         if duration > 5
           Helper.log.info "fastlane.tools just saved you #{duration} minutes! 🎉".green
         else
-          Helper.log.info "fastlane.tools finished successfully 🎉".green
+          Helper.log.info 'fastlane.tools finished successfully 🎉'.green
         end
       else
-        Helper.log.fatal "fastlane finished with errors".red
+        Helper.log.fatal 'fastlane finished with errors'.red
         raise e
       end
     end
   end
-end
+end

data/lib/fastlane/new_action.rb

@@ -2,29 +2,29 @@ module Fastlane
   # Guides the new user through creating a new action
   module NewAction
     def self.run
-      name = self.fetch_name
-      self.generate_action(name)
+      name = fetch_name
+      generate_action(name)
     end
 
     def self.fetch_name
-      puts "Must be lower case, and use a'_' between words. Do not use a '.'".green
+      puts "Must be lower case, and use a '_' between words. Do not use '.'".green
       puts "examples: 'testflight', 'upload_to_s3'".green
-      name = ask("Name of your action: ")
-      while not name_valid?name
-        puts "Name invalid!"
-        name = ask("Name of your action: ")
+      name = ask('Name of your action: ')
+      while !name_valid?(name)
+        puts 'Name invalid!'
+        name = ask('Name of your action: ')
       end
       name
     end
 
     def self.generate_action(name)
-      template = File.read("#{Helper.gem_path}/lib/assets/custom_action_template.rb")
+      template = File.read("#{Helper.gem_path('fastlane')}/lib/assets/custom_action_template.rb")
       template.gsub!('[[NAME]]', name)
       template.gsub!('[[NAME_UP]]', name.upcase)
-      template.gsub!('[[NAME_CLASS]]', name.classify + "Action")
+      template.gsub!('[[NAME_CLASS]]', name.classify + 'Action')
 
-      actions_path = File.join(FastlaneFolder.path, "actions")
-      FileUtils.mkdir_p(actions_path) unless File.directory?actions_path
+      actions_path = File.join((FastlaneFolder.path || Dir.pwd), 'actions')
+      FileUtils.mkdir_p(actions_path) unless File.directory?(actions_path)
 
       path = File.join(actions_path, "#{name}.rb")
       File.write(path, template)
@@ -32,8 +32,9 @@ module Fastlane
     end
 
     private
-      def self.name_valid?(name)
-        name == name.downcase and name.length > 0 and not name.include?"."
-      end
+
+    def self.name_valid?(name)
+      name == name.downcase && name.length > 0 && !name.include?('.')
+    end
   end
-end
+end

data/lib/fastlane/runner.rb

@@ -1,6 +1,5 @@
 module Fastlane
   class Runner
-
     def execute(key)
       key = key.to_sym
       Helper.log.info "Driving the lane '#{key}'".green
@@ -10,7 +9,7 @@ module Fastlane
 
       Dir.chdir(Fastlane::FastlaneFolder.path || Dir.pwd) do # the file is located in the fastlane folder
         @before_all.call if @before_all
-        
+
         return_val = nil
 
         if blocks[key]
@@ -51,8 +50,9 @@ module Fastlane
     end
 
     private
-      def blocks
-        @blocks ||= {}
-      end
+
+    def blocks
+      @blocks ||= {}
+    end
   end
-end
+end

data/lib/fastlane/setup.rb

@@ -1,40 +1,39 @@
+# rubocop:disable Metrics/LineLength
+
 module Fastlane
   class Setup
     def run
       raise "Fastlane already set up at path #{folder}".yellow if FastlaneFolder.setup?
 
       show_infos
-      response = agree("Do you want to get started? This will move your Deliverfile and Snapfile (if they exist) (y/n)".yellow, true)
-
-      if response
-        response = agree("Do you have everything commited in version control? If not please do so! (y/n)".yellow, true)
-        if response
-          begin
-            FastlaneFolder.create_folder!
-            copy_existing_files
-            generate_app_metadata
-            detect_installed_tools # after copying the existing files
-            ask_to_enable_other_tools
-            FileUtils.mkdir(File.join(folder, "actions"))
-            generate_fastfile
-            Helper.log.info "Successfully finished setting up fastlane".green
-          rescue Exception => ex # this will also be caused by Ctrl + C
-            # Something went wrong with the setup, clear the folder again
-            # and restore previous files
-            Helper.log.fatal "Error occured with the setup program! Reverting changes now!".red
-            restore_previous_state
-            raise ex
-          end
-        end
+      response = agree('Do you want to get started? This will move your Deliverfile and Snapfile (if they exist) (y/n)'.yellow, true)
+      return unless response
+      response = agree('Do you have everything commited in version control? If not please do so! (y/n)'.yellow, true)
+      return unless response
+      begin
+        FastlaneFolder.create_folder!
+        copy_existing_files
+        generate_app_metadata
+        detect_installed_tools # after copying the existing files
+        ask_to_enable_other_tools
+        FileUtils.mkdir(File.join(folder, 'actions'))
+        generate_fastfile
+        Helper.log.info 'Successfully finished setting up fastlane'.green
+      rescue Exception => ex # this will also be caused by Ctrl + C
+        # Something went wrong with the setup, clear the folder again
+        # and restore previous files
+        Helper.log.fatal 'Error occured with the setup program! Reverting changes now!'.red
+        restore_previous_state
+        raise ex
       end
     end
 
     def show_infos
-      Helper.log.info "This setup will help you get up and running in no time.".green
-      Helper.log.info "First, it will move the config files from `deliver` and `snapshot`".green
+      Helper.log.info 'This setup will help you get up and running in no time.'.green
+      Helper.log.info 'First, it will move the config files from `deliver` and `snapshot`'.green
       Helper.log.info "into the subfolder `fastlane`.\n".green
       Helper.log.info "Fastlane will check what tools you're already using and set up".green
-      Helper.log.info "the tool automatically for you. Have fun! ".green
+      Helper.log.info 'the tool automatically for you. Have fun! '.green
     end
 
     def files_to_copy
@@ -43,34 +42,33 @@ module Fastlane
 
     def copy_existing_files
       files_to_copy.each do |current|
-        if File.exists?current
-          file_name = File.basename(current)
-          to_path = File.join(folder, file_name)
-          Helper.log.info "Moving '#{current}' to '#{to_path}'".green
-          FileUtils.mv(current, to_path)
-        end
+        next unless File.exist?(current)
+        file_name = File.basename(current)
+        to_path = File.join(folder, file_name)
+        Helper.log.info "Moving '#{current}' to '#{to_path}'".green
+        FileUtils.mv(current, to_path)
       end
     end
 
     def generate_app_metadata
-      Helper.log.info "------------------------------"
-      Helper.log.info "To not re-enter your username and app identifier every time you run one of the fastlane tools or fastlane, these will be stored from now on.".green
-      app_identifier = ask("App Identifier (com.krausefx.app): ".yellow)
-      apple_id = ask("Your Apple ID: ".yellow)
-      template = File.read("#{Helper.gem_path}/lib/assets/AppfileTemplate")
+      Helper.log.info '------------------------------'
+      Helper.log.info 'To not re-enter your username and app identifier every time you run one of the fastlane tools or fastlane, these will be stored from now on.'.green
+      app_identifier = ask('App Identifier (com.krausefx.app): '.yellow)
+      apple_id = ask('Your Apple ID: '.yellow)
+      template = File.read("#{Helper.gem_path('fastlane')}/lib/assets/AppfileTemplate")
       template.gsub!('[[APP_IDENTIFIER]]', app_identifier)
       template.gsub!('[[APPLE_ID]]', apple_id)
-      path = File.join(folder, "Appfile")
+      path = File.join(folder, 'Appfile')
       File.write(path, template)
       Helper.log.info "Created new file '#{path}'. Edit it to manage your preferred app metadata information.".green
     end
 
     def detect_installed_tools
       @tools = {}
-      @tools[:deliver] = File.exists?(File.join(folder, 'Deliverfile'))
-      @tools[:snapshot] = File.exists?(File.join(folder, 'Snapfile'))
-      @tools[:xctool] = File.exists?('./.xctool-args')
-      @tools[:cocoapods] = File.exists?('./Podfile') 
+      @tools[:deliver] = File.exist?(File.join(folder, 'Deliverfile'))
+      @tools[:snapshot] = File.exist?(File.join(folder, 'Snapfile'))
+      @tools[:xctool] = File.exist?('./.xctool-args')
+      @tools[:cocoapods] = File.exist?('./Podfile')
       @tools[:sigh] = false
     end
 
@@ -84,11 +82,11 @@ module Fastlane
         end
       else
         # deliver already enabled
-        Helper.log.info "-------------------------------------------------------------------------------------------"
-        Helper.log.info "Since all files are moved into the `fastlane` subfolder, you have to adapt your Deliverfile".yellow
-        Helper.log.info "Update your `ipa` and `beta_ipa` block of your Deliverfile to go a folder up before building".yellow
+        Helper.log.info '-------------------------------------------------------------------------------------------'
+        Helper.log.info 'Since all files are moved into the `fastlane` subfolder, you have to adapt your Deliverfile'.yellow
+        Helper.log.info 'Update your `ipa` and `beta_ipa` block of your Deliverfile to go a folder up before building'.yellow
         Helper.log.info "e.g. `system('cd ..; ipa build')`".yellow
-        Helper.log.info "Please read the above carefully and click Enter to confirm.".green
+        Helper.log.info 'Please read the above carefully and click Enter to confirm.'.green
         STDIN.gets
       end
 
@@ -103,13 +101,11 @@ module Fastlane
         end
       end
 
-      if agree("Do you want to use 'sigh', which will maintain and download the provisioning profile for your app? (y/n)".yellow, true)
-        @tools[:sigh] = true
-      end
+      @tools[:sigh] = true if agree("Do you want to use 'sigh', which will maintain and download the provisioning profile for your app? (y/n)".yellow, true)
     end
 
     def generate_fastfile
-      template = File.read("#{Helper.gem_path}/lib/assets/FastfileTemplate")
+      template = File.read("#{Helper.gem_path('fastlane')}/lib/assets/FastfileTemplate")
 
       template.gsub!('deliver', '# deliver') unless @tools[:deliver]
       template.gsub!('snapshot', '# snapshot') unless @tools[:snapshot]
@@ -122,7 +118,7 @@ module Fastlane
         Helper.log.info "'#{key}' not enabled.".yellow unless value
       end
 
-      path = File.join(folder, "Fastfile")
+      path = File.join(folder, 'Fastfile')
       File.write(path, template)
       Helper.log.info "Created new file '#{path}'. Edit it to manage your own deployment lanes.".green
     end
@@ -136,14 +132,14 @@ module Fastlane
       files_to_copy.each do |current|
         from_path = File.join(folder, current)
         to_path = File.basename(current)
-        if File.exists?from_path
+        if File.exist?(from_path)
           Helper.log.info "Moving '#{from_path}' to '#{to_path}'".yellow
           FileUtils.mv(from_path, to_path)
         end
       end
 
       Helper.log.info "Deleting the 'fastlane' folder".yellow
-      FileUtils.rm_rf(folder) 
+      FileUtils.rm_rf(folder)
     end
   end
-end
+end