fastlane 2.238.0 → 2.241.0

data/fastlane/lib/fastlane/fastlane_require.rb

@@ -27,7 +27,11 @@ module Fastlane
         UI.important("Installing Ruby gem '#{gem_name}'...")
 
         spec_name = self.find_gem_name(gem_name)
-        UI.important("Found gem \"#{spec_name}\" instead of the required name \"#{gem_name}\"") if spec_name != gem_name
+        if spec_name != gem_name
+          message = "Could not find gem '#{gem_name}' on RubyGems"
+          message += ". Did you mean '#{spec_name}'? Fix the name in your Fastfile" if spec_name
+          UI.user_error!(message)
+        end
 
         return if Helper.test?
 

data/fastlane/lib/fastlane/helper/git_helper.rb

@@ -9,9 +9,10 @@ module Fastlane
       end.freeze
     end
 
-    def self.git_log_between(pretty_format, from, to, merge_commit_filtering, date_format = nil, ancestry_path, app_path)
+    def self.git_log_between(pretty_format, from, to, matching_pattern, merge_commit_filtering, date_format = nil, ancestry_path, app_path)
       command = %w(git log)
       command << "--pretty=#{pretty_format}"
+      command << "--grep=#{matching_pattern}" if matching_pattern
       command << "--date=#{date_format}" if date_format
       command << '--ancestry-path' if ancestry_path
       command << "#{from}...#{to}"
@@ -24,9 +25,10 @@ module Fastlane
       nil
     end
 
-    def self.git_log_last_commits(pretty_format, commit_count, merge_commit_filtering, date_format = nil, ancestry_path, app_path)
+    def self.git_log_last_commits(pretty_format, commit_count, matching_pattern, merge_commit_filtering, date_format = nil, ancestry_path, app_path)
       command = %w(git log)
       command << "--pretty=#{pretty_format}"
+      command << "--grep=#{matching_pattern}" if matching_pattern
       command << "--date=#{date_format}" if date_format
       command << '--ancestry-path' if ancestry_path
       command << '-n' << commit_count.to_s

data/fastlane/lib/fastlane/helper/sh_helper.rb

@@ -8,12 +8,13 @@ module Fastlane
     # When running this in tests, it will return the actual command instead of executing it
     # @param log [Boolean] should fastlane print out the executed command
     # @param error_callback [Block] a callback invoked with the command output if there is a non-zero exit status
-    def self.sh(*command, log: true, error_callback: nil, &b)
-      sh_control_output(*command, print_command: log, print_command_output: log, error_callback: error_callback, &b)
+    # @param stdin [String] data written to the command's standard input, which is then closed; it is never printed
+    def self.sh(*command, log: true, error_callback: nil, stdin: nil, &b)
+      sh_control_output(*command, print_command: log, print_command_output: log, error_callback: error_callback, stdin: stdin, &b)
     end
 
-    def self.sh_no_action(*command, log: true, error_callback: nil, &b)
-      sh_control_output(*command, print_command: log, print_command_output: log, error_callback: error_callback, &b)
+    def self.sh_no_action(*command, log: true, error_callback: nil, stdin: nil, &b)
+      sh_control_output(*command, print_command: log, print_command_output: log, error_callback: error_callback, stdin: stdin, &b)
     end
 
     # @param command The command to be executed (variadic)
@@ -25,7 +26,7 @@ module Fastlane
     # @yieldparam [String] result The complete output to stdout and stderr of the completed command
     # @yieldparam [String] cmd A shell command equivalent to the arguments passed
     # rubocop: disable Metrics/PerceivedComplexity
-    def self.sh_control_output(*command, print_command: true, print_command_output: true, error_callback: nil)
+    def self.sh_control_output(*command, print_command: true, print_command_output: true, error_callback: nil, stdin: nil)
       print_command = print_command_output = true if $troubleshoot
       # Set the encoding first, the user might have set it wrong
       previous_encoding = [Encoding.default_external, Encoding.default_internal]
@@ -51,15 +52,32 @@ module Fastlane
         # sh "ls -la /Applications/Xcode\ 7.3.1.app"
         # sh "ls", "-la", "/Applications/Xcode 7.3.1.app"
         # sh({ "FOO" => "Hello" }, "echo $FOO")
-        Open3.popen2e(*command) do |stdin, io, thread|
+        sanitized_output = false
+        Open3.popen2e(*command) do |command_stdin, io, thread|
+          # From a thread, so a command that writes a lot before reading its input cannot block on a full pipe
+          writer = stdin && Thread.new do
+            command_stdin.write(stdin)
+          rescue Errno::EPIPE
+            # The command exited without reading all of it; its exit status says what happened
+          ensure
+            command_stdin.close
+          end
           io.sync = true
           io.each do |line|
-            UI.command_output(line.strip) if print_command_output
+            if print_command_output
+              # Ensure the string being stripped is in valid UTF-8 format; Otherwise warn at the end
+              text = line.encode('UTF-8', invalid: :replace)
+              UI.command_output(text.strip)
+              sanitized_output = true if text != line
+            end
             result << line
           end
           exit_status = thread.value
+          writer&.join
         end
 
+        UI.important("Command output wasn't valid UTF-8 and was sanitized. Please report the issue.") if sanitized_output
+
         # Checking Process::Status#exitstatus instead of #success? makes for more
         # testable code. (Tests mock exitstatus only.) This is also consistent
         # with previous implementations of sh and... probably portable to all

data/fastlane/lib/fastlane/new_action.rb

@@ -18,7 +18,7 @@ module Fastlane
     end
 
     def self.generate_action(name)
-      template = File.read("#{Fastlane::ROOT}/lib/assets/custom_action_template.rb")
+      template = File.read("#{Fastlane::ROOT}/lib/assets/custom_action_template.rb.template")
       template.gsub!('[[NAME]]', name)
       template.gsub!('[[NAME_UP]]', name.upcase)
       template.gsub!('[[NAME_CLASS]]', name.fastlane_class + 'Action')

data/fastlane/lib/fastlane/plugins/plugin_fetcher.rb

@@ -14,7 +14,7 @@ module Fastlane
       loop do
         url = "https://rubygems.org/api/v1/search.json?query=#{PluginManager.plugin_prefix}&page=#{page}"
         FastlaneCore::UI.verbose("RubyGems API Request: #{url}")
-        results = JSON.parse(URI.open(url).read)
+        results = JSON.parse(URI.parse(url).open.read)
         break if results.count == 0
 
         plugins += results.collect do |current|

data/fastlane/lib/fastlane/plugins/plugin_info_collector.rb

@@ -68,7 +68,7 @@ module Fastlane
       require 'json'
       require 'open-uri'
       url = "https://rubygems.org/api/v1/gems/#{name}.json"
-      response = JSON.parse(URI.open(url).read)
+      response = JSON.parse(URI.parse(url).open.read)
       return !!response['version']
     rescue
       false

data/fastlane/lib/fastlane/plugins/plugin_manager.rb

@@ -66,6 +66,15 @@ module Fastlane
       end
     end
 
+    # Returns the fastlane plugins the given gem depends on, directly or through other gems
+    def plugins_required_by(gem_name)
+      rubygem = Bundler.rubygems.find_name(gem_name).first
+      return [] unless rubygem
+      collect_bundler_runtime_dependencies([], rubygem).map(&:name).keep_if do |current|
+        current.start_with?(self.class.plugin_prefix)
+      end
+    end
+
     # Check if a plugin is added as dependency to either the
     # Gemfile or the Pluginfile
     def plugin_is_added_as_dependency?(plugin_name)
@@ -159,7 +168,7 @@ module Fastlane
       require 'open-uri'
       url = "https://rubygems.org/api/v1/gems/#{gem_name}.json"
       begin
-        JSON.parse(URI.open(url).read)
+        JSON.parse(URI.parse(url).open.read)
       rescue
         nil
       end
@@ -278,11 +287,12 @@ module Fastlane
     #   fastlane-plugin-[plugin_name]
     # This will make sure to load the action
     # and all its helpers
-    def load_plugins(print_table: true)
+    # @param plugins [Array] the plugins to load, the available plugins by default
+    def load_plugins(print_table: true, plugins: nil)
       UI.verbose("Checking if there are any plugins that should be loaded...")
 
       loaded_plugins = false
-      available_plugins.each do |gem_name|
+      (plugins || available_plugins).each do |gem_name|
         UI.verbose("Loading '#{gem_name}' plugin")
         begin
           # BEFORE requiring the gem, we get a list of loaded actions
@@ -306,7 +316,7 @@ module Fastlane
         end
       end
 
-      if !loaded_plugins && self.pluginfile_content.to_s.include?(PluginManager.plugin_prefix)
+      if plugins.nil? && !loaded_plugins && self.pluginfile_content.to_s.include?(PluginManager.plugin_prefix)
         UI.error("It seems like you wanted to load some plugins, however they couldn't be loaded")
         UI.error("Please follow the troubleshooting guide: #{TROUBLESHOOTING_URL}")
       end
@@ -317,6 +327,12 @@ module Fastlane
       print_plugin_information(self.plugin_references) unless skip_print_plugin_info
     end
 
+    # Loads the plugins the given gem depends on that are not loaded yet
+    def load_plugins_required_by(gem_name, print_table: true)
+      plugins = plugins_required_by(gem_name) - self.plugin_references.keys
+      load_plugins(print_table: print_table, plugins: plugins) unless plugins.empty?
+    end
+
     # Prints a table all the plugins that were loaded
     def print_plugin_information(references)
       no_action_found = false
@@ -395,5 +411,21 @@ module Fastlane
         actions: references
       }
     end
+
+    private
+
+    # recursively collect runtime dependencies
+    def collect_bundler_runtime_dependencies(collection, source)
+      # Compare by name: one gem can be required with different version constraints
+      known = collection.map(&:name)
+      runtime_deps = source.dependencies.select { |d| d.type == :runtime && !known.include?(d.name) }.uniq(&:name)
+      collection.concat(runtime_deps)
+      runtime_deps.each do |d|
+        collect_bundler_runtime_dependencies(collection, d.to_spec)
+      rescue Gem::MissingSpecError
+        # ignoring unresolvable dependencies
+      end
+      collection
+    end
   end
 end

data/fastlane/lib/fastlane/plugins/template/%gem_name%.gemspec.erb

@@ -15,7 +15,7 @@ Gem::Specification.new do |spec|
   spec.files         = Dir["lib/**/*"] + %w(README.md LICENSE)
   spec.require_paths = ['lib']
   spec.metadata['rubygems_mfa_required'] = 'true'
-  spec.required_ruby_version = '>= 3.0'
+  spec.required_ruby_version = '>= <%= Fastlane::MINIMUM_RUBY %>'
 
   # Don't add a dependency to fastlane or fastlane_re
   # since this would cause a circular dependency

data/fastlane/lib/fastlane/plugins/template/.github/workflows/test.yml

@@ -8,7 +8,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        ruby-version: ['3.0', '3.1', '3.2', '3.3', '3.4']
+        ruby-version: ['3.2', '3.3', '3.4']
     steps:
       - uses: actions/checkout@v6
 

data/fastlane/lib/fastlane/plugins/template/.rubocop.yml

@@ -1,9 +1,9 @@
 ---
+plugins:
+- rubocop-performance
 require:
 - rubocop/require_tools
-- rubocop-performance
 AllCops:
-  TargetRubyVersion: 3.0
   SuggestExtensions: false
   NewCops: enable
   Include:
@@ -13,14 +13,16 @@ AllCops:
   - "*/lib/assets/*Template"
   - "*/lib/assets/*TemplateAndroid"
   Exclude:
-  - "**/lib/assets/custom_action_template.rb"
   - "./vendor/**/*"
   - "**/lib/assets/DefaultFastfileTemplate"
   - "**/lib/assets/MatchfileTemplate"
-  - "**/spec/fixtures/broken_files/broken_file.rb"
   - "**/*.provisionprofile"
 Lint/ErbNewArguments:
   Enabled: false
+Style/HashSyntax:
+  EnforcedShorthandSyntax: either
+Naming/BlockForwarding:
+  EnforcedStyle: explicit
 Style/SlicingWithRange:
   Enabled: false
 Style/MultipleComparison:
@@ -136,7 +138,7 @@ Lint/UnusedMethodArgument:
 Lint/ParenthesesAsGroupedExpression:
   Exclude:
   - "**/spec/**/*"
-Naming/PredicateName:
+Naming/PredicatePrefix:
   Enabled: false
 Style/PerlBackrefs:
   Enabled: false
@@ -145,8 +147,6 @@ Layout/SpaceAroundOperators:
   - "**/spec/actions_specs/xcodebuild_spec.rb"
 Naming/FileName:
   Exclude:
-  - "**/Dangerfile"
-  - "**/Brewfile"
   - "**/Gemfile"
   - "**/Podfile"
   - "**/Rakefile"

data/fastlane/lib/fastlane/swift_lane_manager.rb

@@ -3,6 +3,10 @@ require_relative 'swift_runner_upgrader.rb'
 
 module Fastlane
   class SwiftLaneManager < LaneManagerBase
+    # The runner protocol version this fastlane ships, see main.swift
+    RUNNER_PROTOCOL_VERSION = 1
+    RUNNER_PROTOCOL_VERSION_REGEX = /FastlaneRunnerProtocolVersion \[(\d+)\]/
+
     # @param lane_name The name of the lane to execute
     # @param parameters [Hash] The parameters passed from the command line to the lane
     def self.cruise_lane(lane, parameters = nil, disable_runner_upgrades: false, swift_server_port: nil)
@@ -26,6 +30,7 @@ module Fastlane
         end
 
         self.ensure_runner_built!
+        self.warn_if_runner_outdated
         swift_server_port ||= 2000
         socket_thread = self.start_socket_thread(port: swift_server_port)
         sleep(0.250) while socket_thread[:ready].nil?
@@ -229,6 +234,17 @@ module Fastlane
       end
     end
 
+    # The protocol version compiled into the built runner, 0 for runners from before it had one
+    def self.runner_protocol_version
+      File.binread(FastlaneCore::FastlaneFolder.swift_runner_path)[RUNNER_PROTOCOL_VERSION_REGEX, 1].to_i
+    end
+
+    def self.warn_if_runner_outdated
+      return if runner_protocol_version >= RUNNER_PROTOCOL_VERSION
+
+      UI.important("Your FastlaneRunner is outdated for this version of fastlane. Run a lane outside CI, without `disable_runner_upgrades`, to update it, then commit the changes.")
+    end
+
     def self.ensure_runner_built!
       UI.verbose("Checking for new user-provided tool configuration files")
       # if self.link_user_configs_to_project returns true, that means we need to rebuild the runner
@@ -236,11 +252,13 @@ module Fastlane
 
       if FastlaneCore::FastlaneFolder.swift_runner_built?
         runner_last_modified_age = File.mtime(FastlaneCore::FastlaneFolder.swift_runner_path).to_i
-        fastfile_last_modified_age = File.mtime(FastlaneCore::FastlaneFolder.fastfile_path).to_i
+        # The Fastfile, and the runner's own files, which an upgrade or a pull can change without touching the Fastfile
+        sources = [FastlaneCore::FastlaneFolder.fastfile_path] + Dir[File.join(FastlaneCore::FastlaneFolder.swift_folder_path, '**', '*.swift')]
+        changed = sources.find { |source| File.mtime(source).to_i > runner_last_modified_age }
 
-        if runner_last_modified_age < fastfile_last_modified_age
-          # It's older than the Fastfile, so build it again
-          UI.verbose("Found changes to user's Fastfile.swift, setting re-build runner flag")
+        if changed
+          # It's older than one of its sources, so build it again
+          UI.verbose("Found changes to #{changed}, setting re-build runner flag")
           runner_needs_building = true
         end
       else

data/fastlane/lib/fastlane/version.rb

@@ -1,8 +1,9 @@
 module Fastlane
-  VERSION = '2.238.0'.freeze
+  VERSION = '2.241.0'.freeze
   SUMMARY = "The easiest way to build and release mobile apps.".freeze
   DESCRIPTION = "The easiest way to automate beta deployments and releases for your iOS and Android apps".freeze
   MINIMUM_XCODE_RELEASE = "7.0".freeze
-  RUBOCOP_REQUIREMENT = '1.50.2'.freeze
+  RUBOCOP_REQUIREMENT = '1.91.0'.freeze
+  MINIMUM_RUBY = '3.2.0'.freeze
   SUGGESTED_MINIMUM_RUBY = '3.3.0'.freeze
 end

data/fastlane/swift/Deliverfile.swift

@@ -17,4 +17,4 @@ public class Deliverfile: DeliverfileProtocol {
     // during the `init` process, and you won't see this message
 }
 
-// Generated with fastlane 2.238.0
+// Generated with fastlane 2.241.0

data/fastlane/swift/DeliverfileProtocol.swift

@@ -179,6 +179,9 @@ public protocol DeliverfileProtocol: AnyObject {
     /// Metadata: Path to the app review attachment file
     var appReviewAttachmentFile: String? { get }
 
+    /// Metadata: Path to the routing app coverage file (`.geojson`) that is required for routing apps
+    var routingAppCoverageFile: String? { get }
+
     /// Metadata: The localised app description
     var description: [String: Any]? { get }
 
@@ -465,6 +468,10 @@ public extension DeliverfileProtocol {
         return nil
     }
 
+    var routingAppCoverageFile: String? {
+        return nil
+    }
+
     var description: [String: Any]? {
         return nil
     }
@@ -532,4 +539,4 @@ public extension DeliverfileProtocol {
 
 // Please don't remove the lines below
 // They are used to detect outdated files
-// FastlaneRunnerAPIVersion [0.9.152]
+// FastlaneRunnerAPIVersion [0.9.156]