fastlane 2.238.0 → 2.241.0

data/deliver/lib/deliver/upload_metadata.rb

@@ -357,6 +357,7 @@ module Deliver
       review_information(version)
       app_clip_review_information(version)
       review_attachment_file(version)
+      routing_app_coverage_file(version)
       app_rating(app_info)
     end
 
@@ -534,16 +535,14 @@ module Deliver
       if locales_to_enable.count > 0
         lng_text = "language"
         lng_text += "s" if locales_to_enable.count != 1
-        Helper.show_loading_indicator("Activating info #{lng_text} #{locales_to_enable.join(', ')}...")
-
-        locales_to_enable.each do |locale|
-          app_info.create_app_info_localization(attributes: {
-            locale: locale
-          })
+        Helper.with_loading_indicator("Activating info #{lng_text} #{locales_to_enable.join(', ')}...") do
+          locales_to_enable.each do |locale|
+            app_info.create_app_info_localization(attributes: {
+              locale: locale
+            })
+          end
         end
 
-        Helper.hide_loading_indicator
-
         # Refresh version localizations
         localizations = app_info.get_app_info_localizations
       end
@@ -569,16 +568,14 @@ module Deliver
       if locales_to_enable.count > 0
         lng_text = "language"
         lng_text += "s" if locales_to_enable.count != 1
-        Helper.show_loading_indicator("Activating version #{lng_text} #{locales_to_enable.join(', ')}...")
-
-        locales_to_enable.each do |locale|
-          version.create_app_store_version_localization(attributes: {
-            locale: locale
-          })
+        Helper.with_loading_indicator("Activating version #{lng_text} #{locales_to_enable.join(', ')}...") do
+          locales_to_enable.each do |locale|
+            version.create_app_store_version_localization(attributes: {
+              locale: locale
+            })
+          end
         end
 
-        Helper.hide_loading_indicator
-
         # Refresh version localizations
         localizations = version.get_app_store_version_localizations
       end
@@ -766,6 +763,27 @@ module Deliver
       end
     end
 
+    def routing_app_coverage_file(version)
+      # Skip logic entirely if no coverage file passed. So status-quo stays the same.
+      return unless options[:routing_app_coverage_file]
+
+      routing_app_coverage =
+        begin
+          version.fetch_routing_app_coverage
+        rescue => error
+          UI.error("Error fetching routing app coverage - #{error.message}")
+          nil
+        end
+
+      if routing_app_coverage
+        UI.message("Removing previous routing app coverage file from App Store Connect")
+        routing_app_coverage.delete!
+      end
+
+      UI.message("Uploading routing app coverage file to App Store Connect")
+      version.upload_routing_app_coverage(path: options[:routing_app_coverage_file])
+    end
+
     def app_rating(app_info)
       return unless options[:app_rating_config_path]
 

data/deliver/lib/deliver/upload_screenshots.rb

@@ -41,25 +41,23 @@ module Deliver
       if locales_to_enable.count > 0
         lng_text = "language"
         lng_text += "s" if locales_to_enable.count != 1
-        Helper.show_loading_indicator("Activating #{lng_text} #{locales_to_enable.join(', ')}...")
-
-        locales_to_enable.each do |locale|
-          version.create_app_store_version_localization(attributes: {
-            locale: locale
-          })
+        Helper.with_loading_indicator("Activating #{lng_text} #{locales_to_enable.join(', ')}...") do
+          locales_to_enable.each do |locale|
+            version.create_app_store_version_localization(attributes: {
+              locale: locale
+            })
+          end
         end
 
-        Helper.hide_loading_indicator
-
         # Refresh version localizations
         localizations = version.get_app_store_version_localizations
       end
 
       upload_screenshots(localizations, screenshots_per_language, options[:screenshot_processing_timeout])
 
-      Helper.show_loading_indicator("Sorting screenshots uploaded...")
-      sort_screenshots(localizations)
-      Helper.hide_loading_indicator
+      Helper.with_loading_indicator("Sorting screenshots uploaded...") do
+        sort_screenshots(localizations)
+      end
 
       UI.success("Successfully uploaded screenshots to App Store Connect")
     end
@@ -159,9 +157,9 @@ module Deliver
 
       UI.verbose('Uploading jobs are completed')
 
-      Helper.show_loading_indicator("Waiting for all the screenshots to finish being processed...")
-      states = wait_for_complete(iterator, timeout_seconds)
-      Helper.hide_loading_indicator
+      states = Helper.with_loading_indicator("Waiting for all the screenshots to finish being processed...") do
+        wait_for_complete(iterator, timeout_seconds)
+      end
       retry_upload_screenshots_if_needed(iterator, states, total_number_of_screenshots, tries, timeout_seconds, localizations, screenshots_per_language)
 
       UI.message("Successfully uploaded all screenshots")
@@ -171,13 +169,17 @@ module Deliver
     def wait_for_complete(iterator, timeout_seconds)
       start_time = Time.now
       loop do
+        # App Store Connect publishes a screenshot's `sourceFileChecksum` asynchronously,
+        # shortly after its state becomes COMPLETE. (#30094)
+        number_of_screenshots_missing_checksum = 0
         states = iterator.each_app_screenshot.map { |_, _, app_screenshot| app_screenshot }.each_with_object({}) do |app_screenshot, hash|
           state = app_screenshot.asset_delivery_state['state']
           hash[state] ||= 0
           hash[state] += 1
+          number_of_screenshots_missing_checksum += 1 if state == 'COMPLETE' && app_screenshot.source_file_checksum.nil?
         end
 
-        is_processing = states.fetch('UPLOAD_COMPLETE', 0) > 0
+        is_processing = states.fetch('UPLOAD_COMPLETE', 0) > 0 || number_of_screenshots_missing_checksum > 0
         return states unless is_processing
 
         if Time.now - start_time > timeout_seconds
@@ -185,7 +187,11 @@ module Deliver
           return states
         end
 
-        UI.verbose("There are still incomplete screenshots - #{states}")
+        if number_of_screenshots_missing_checksum > 0
+          UI.verbose("There are still incomplete screenshots - #{states}, missing checksum: #{number_of_screenshots_missing_checksum}")
+        else
+          UI.verbose("There are still incomplete screenshots - #{states}")
+        end
         sleep(5)
       end
     end
@@ -205,9 +211,9 @@ module Deliver
         UI.user_error!("Failed verification of all screenshots uploaded... #{incomplete_screenshot_count} incomplete screenshot(s) still exist")
       else
         UI.error("Failed to upload all screenshots... Tries remaining: #{tries}")
-        # Delete bad entries before retry
+        # Delete bad entries before retry (not complete OR missing checksum)
         iterator.each_app_screenshot do |_, _, app_screenshot|
-          app_screenshot.delete! unless app_screenshot.complete?
+          app_screenshot.delete! unless app_screenshot.complete? && !app_screenshot.source_file_checksum.nil?
         end
         upload_screenshots(localizations, screenshots_per_language, timeout_seconds, tries: tries)
       end

data/docs/README.md

@@ -0,0 +1,25 @@
+<h3 align="center">
+  <a href="https://github.com/fastlane/fastlane/blob/master/fastlane/assets/fastlane_text.png">
+  <img src="https://github.com/fastlane/fastlane/blob/master/fastlane/assets/fastlane_text.png?raw=true" alt="fastlane Logo" width="500">
+  </a>
+</h3>
+
+# _fastlane_ Documentation
+
+## Contributing
+
+- [Contributing to _fastlane_](CONTRIBUTING.md)
+- [Designing _fastlane_ code](Design.md)
+- [Tooling and Debugging](ToolsAndDebugging.md)
+
+## Testing
+
+- [Testing _fastlane_](Testing.md)
+- [When a spec passes alone and fails in the split](ParallelTesting.md)
+
+## Project
+
+- [_fastlane_'s Philosophy](VISION.md)
+- [Maintaining _fastlane_](Maintaining.md)
+- [Code of Conduct](CODE_OF_CONDUCT.md)
+- [Security Policy](SECURITY.md)

data/fastlane/lib/assets/TeamTable.md.erb

@@ -0,0 +1,28 @@
+<table id='team'>
+<%- team.each_slice(5) do |row| -%>
+<tr>
+<%- row.each do |github_user, user| -%>
+<td id='<%= ERB::Util.h(user['name'].downcase.tr(' ', '-')) %>'>
+<a href='https://github.com/<%= github_user %>'>
+<img src='https://github.com/<%= github_user %>.png?size=200' width='140'>
+</a>
+<%- if user['twitter'] -%>
+<h4 align='center'><a href='https://twitter.com/<%= user['twitter'] %>'><%= ERB::Util.h(user['name']) %></a></h4>
+<%- else -%>
+<h4 align='center'><%= ERB::Util.h(user['name']) %></h4>
+<%- end -%>
+</td>
+<%- end -%>
+</tr>
+<%- end -%>
+</table>
+<%- unless alumni.empty? -%>
+
+### _fastlane_ alumni
+
+_fastlane_ wouldn't be what it is today without the countless hours these former team members have dedicated to the project ❤️
+
+<p id='alumni'>
+<%= alumni.map { |github_user, user| "<a href='https://github.com/#{github_user}'>#{ERB::Util.h(user['name'])}</a>" }.join(",\n") %>
+</p>
+<%- end -%>

data/fastlane/lib/fastlane/actions/appaloosa.rb

@@ -33,7 +33,8 @@ module Fastlane
         path = json_res['path']
         uri = URI.parse(Base64.decode64(s3_sign))
         File.open(file, 'rb') do |f|
-          http = Net::HTTP.new(uri.host)
+          http = Net::HTTP.new(uri.host, uri.port)
+          http.use_ssl = (uri.scheme == 'https')
           put = Net::HTTP::Put.new(uri.request_uri)
           put.body = f.read
           put['content-type'] = ''

data/fastlane/lib/fastlane/actions/appium.rb

@@ -37,7 +37,7 @@ module Fastlane
 
       def self.invoke_appium_server(params)
         appium = detect_appium(params)
-        Process.spawn("#{appium} -a #{params[:host]} -p #{params[:port]}")
+        Process.spawn(appium, "-a", params[:host].to_s, "-p", params[:port].to_s)
       end
 
       def self.detect_appium(params)

data/fastlane/lib/fastlane/actions/apteligent.rb

@@ -99,7 +99,14 @@ module Fastlane
       end
 
       def self.category
-        :beta
+        :deprecated
+      end
+
+      def self.deprecated_notes
+        [
+          "VMware stopped selling Apteligent to new customers on February 4, 2019, and announced moving its capabilities to VMware Workspace ONE Intelligence.",
+          "See [Apteligent moving to Workspace ONE Intelligence](https://vcdx181.com/2019/01/20/apteligent-moving-to-workspace-one-intelligence/)."
+        ].join("\n")
       end
     end
   end

data/fastlane/lib/fastlane/actions/build_and_upload_to_appetize.rb

@@ -1,8 +1,10 @@
+require 'tmpdir'
+
 module Fastlane
   module Actions
     class BuildAndUploadToAppetizeAction < Action
       def self.run(params)
-        tmp_path = "/tmp/fastlane_build"
+        tmp_path = Dir.mktmpdir("fastlane_build-")
 
         xcodebuild_configs = params[:xcodebuild]
         xcodebuild_configs[:sdk] = "iphonesimulator"

data/fastlane/lib/fastlane/actions/changelog_from_git_commits.rb

@@ -37,9 +37,9 @@ module Fastlane
 
         Dir.chdir(params[:path]) do
           if params[:commits_count]
-            changelog = Actions.git_log_last_commits(params[:pretty], params[:commits_count], merge_commit_filtering, params[:date_format], params[:ancestry_path], params[:app_path])
+            changelog = Actions.git_log_last_commits(params[:pretty], params[:commits_count], params[:matching_pattern], merge_commit_filtering, params[:date_format], params[:ancestry_path], params[:app_path])
           else
-            changelog = Actions.git_log_between(params[:pretty], from, to, merge_commit_filtering, params[:date_format], params[:ancestry_path], params[:app_path])
+            changelog = Actions.git_log_between(params[:pretty], from, to, params[:matching_pattern], merge_commit_filtering, params[:date_format], params[:ancestry_path], params[:app_path])
           end
 
           changelog = changelog.gsub("\n\n", "\n") if changelog # as there are duplicate newlines
@@ -104,6 +104,10 @@ module Fastlane
                                        description: 'The format applied to each commit while generating the collected value',
                                        optional: true,
                                        default_value: '%B'),
+          FastlaneCore::ConfigItem.new(key: :matching_pattern,
+                                       env_name: 'FL_CHANGELOG_FROM_GIT_COMMITS_MATCHING_PATTERN',
+                                       description: 'A regexp pattern to filter only the commits matching the pattern',
+                                       optional: true),
           FastlaneCore::ConfigItem.new(key: :date_format,
                                        env_name: 'FL_CHANGELOG_FROM_GIT_COMMITS_DATE_FORMAT',
                                        description: 'The date format applied to each commit while generating the collected value',
@@ -179,6 +183,7 @@ module Fastlane
             pretty: "- (%ae) %s",                    # Optional, lets you provide a custom format to apply to each commit when generating the changelog text
             date_format: "short",                    # Optional, lets you provide an additional date format to dates within the pretty-formatted string
             match_lightweight_tag: false,            # Optional, lets you ignore lightweight (non-annotated) tags when searching for the last tag
+            matching_pattern: "[.*?].*",             # Optional, lets you filter out commits not matching the regex pattern
             merge_commit_filtering: "exclude_merges" # Optional, lets you filter out merge commits
           )'
         ]

data/fastlane/lib/fastlane/actions/clean_build_artifacts.rb

@@ -45,6 +45,9 @@ module Fastlane
         [
           "This action deletes the files that get created in your repo as a result of running the _gym_ and _sigh_ commands. It doesn't delete the `fastlane/report.xml` though, this is probably more suited for the .gitignore.",
           "",
+          "From _cert_ it only deletes the `.cer` file. The private key (`<certificate id>.p12`, despite its name an unencrypted PEM key) and the `.certSigningRequest` that _cert_ writes to its `output_path` when it creates a certificate are kept: " \
+          "_cert_ uses that `.p12` to install the certificate on a machine that doesn't have it, and on systems other than macOS it is the only copy of the key. Keep them out of version control.",
+          "",
           "Useful if you quickly want to send out a test build by dropping down to the command line and typing something like `fastlane beta`, without leaving your repo in a messy state afterwards."
         ].join("\n")
       end

data/fastlane/lib/fastlane/actions/danger.rb

@@ -14,15 +14,15 @@ module Fastlane
         base = params[:base]
         head = params[:head]
         pr = params[:pr]
-        cmd << "--danger_id=#{danger_id}" if danger_id
-        cmd << "--dangerfile=#{dangerfile}" if dangerfile
+        cmd << "--danger_id=#{danger_id.shellescape}" if danger_id
+        cmd << "--dangerfile=#{dangerfile.shellescape}" if dangerfile
         cmd << "--fail-on-errors=true" if params[:fail_on_errors]
         cmd << "--fail-if-no-pr=true" if params[:fail_if_no_pr]
         cmd << "--new-comment" if params[:new_comment]
         cmd << "--remove-previous-comments" if params[:remove_previous_comments]
-        cmd << "--base=#{base}" if base
-        cmd << "--head=#{head}" if head
-        cmd << "pr #{pr}" if pr
+        cmd << "--base=#{base.shellescape}" if base
+        cmd << "--head=#{head.shellescape}" if head
+        cmd << "pr #{pr.shellescape}" if pr
 
         ENV['DANGER_GITHUB_API_TOKEN'] = params[:github_api_token] if params[:github_api_token]
         ENV['DANGER_GITHUB_HOST'] = params[:github_enterprise_host] if params[:github_enterprise_host]

data/fastlane/lib/fastlane/actions/docs/build_app.md

@@ -6,8 +6,7 @@
 
 <p align="center">
     <a href="#whats-gym">Features</a> &bull;
-    <a href="#usage">Usage</a> &bull;
-    <a href="#tips">Tips</a>
+    <a href="#usage">Usage</a>
 </p>
 
 -------

data/fastlane/lib/fastlane/actions/docs/create_app_online.md

@@ -10,8 +10,7 @@ _produce_ creates new iOS apps on both the Apple Developer Portal and App Store
 
 <p align="center">
     <a href="#features">Features</a> &bull;
-    <a href="#usage">Usage</a> &bull;
-    <a href="#how-does-it-work">How does it work?</a>
+    <a href="#usage">Usage</a>
 </p>
 
 -------

data/fastlane/lib/fastlane/actions/docs/get_certificates.md

@@ -4,9 +4,7 @@
 
 -------
 <p align="center">
-    <a href="#why">Why?</a> &bull;
     <a href="#usage">Usage</a> &bull;
-    <a href="#how-does-it-work">How does it work?</a> &bull;
     <a href="#tips">Tips</a>
 </p>
 

data/fastlane/lib/fastlane/actions/docs/get_push_certificate.md

@@ -17,9 +17,7 @@ To automate iOS Provisioning profiles you can use [_match_](https://docs.fastlan
 <p align="center">
     <a href="#features">Features</a> &bull;
     <a href="#usage">Usage</a> &bull;
-    <a href="#how-does-it-work">How does it work?</a> &bull;
-    <a href="#tips">Tips</a> &bull;
-    <a href="#need-help">Need help?</a>
+    <a href="#how-does-it-work">How does it work?</a>
 </p>
 
 -------
@@ -74,6 +72,12 @@ If you want to generate a Website Push certificate:
 fastlane pem --website_push
 ```
 
+If you want to generate a VoIP Services certificate (the type PushKit requires):
+
+```no-highlight
+fastlane pem --voip_push
+```
+
 Set a password for your `p12` file:
 
 ```no-highlight

data/fastlane/lib/fastlane/actions/docs/sync_code_signing.md

@@ -81,12 +81,15 @@ Use Git Storage to store all code signing identities in a private git repo, owne
 
 First, enter the URL to your private (!) Git repo (You can create one for free on e.g. [GitHub](https://github.com/new) or [BitBucket](https://bitbucket.org/repo/create)). The URL you enter can be either a `https://` or a `git` URL. `fastlane match init` won't read or modify your certificates or profiles yet, and also won't validate your git URL.
 
+You'll then be asked which branch of that repo to use, defaulting to `main` if you leave the answer blank.
+
 This will create a `Matchfile` in your current directory (or in your `./fastlane/` folder).
 
 Example content (for more advanced setups check out the [fastlane section](#fastlane)):
 
 ```ruby-skip-tests
 git_url("https://github.com/fastlane/certificates")
+git_branch("main")
 
 app_identifier("tools.fastlane.app")
 username("user@fastlane.tools")
@@ -94,7 +97,7 @@ username("user@fastlane.tools")
 
 ##### Git Storage on GitHub
 
-If your machine is currently using SSH to authenticate with GitHub, you'll want to use a `git` URL, otherwise, you may see an authentication error when you attempt to use match. Alternatively, you can set a basic authorization for _match_:
+If your machine is currently using SSH to authenticate with GitHub, you'll want to use a `git` URL, otherwise, you may see an authentication error when you attempt to use match. Alternatively, you can set a basic authorization for _match_ (needs git 2.31 or later):
 
 Using parameter:
 
@@ -138,7 +141,7 @@ You can find more information about GitHub basic authentication and personal tok
 
 ##### Git Storage on Azure DevOps
 
-If you're running a pipeline on Azure DevOps and using git storage in a another repository on the same project, you might want to use `bearer` token authentication.
+If you're running a pipeline on Azure DevOps and using git storage in a another repository on the same project, you might want to use `bearer` token authentication (needs git 2.31 or later).
 
 Using parameter:
 
@@ -259,7 +262,7 @@ If you want to use a single developer and/or distribution certificate for multip
 
 ```ruby-skip-tests
 git_url("https://github.com/example/example-repo.git")
-git_branch("master")
+git_branch("main")
 ```
 
 _match_ will reuse certificates and will create separate provisioning profiles for each app.
@@ -408,6 +411,13 @@ If you're not using `Fastfile`, you can also use the `force_for_new_devices` opt
 fastlane match adhoc --force_for_new_devices
 ```
 
+##### Offline profile use
+
+If your profile requires the 'Offline support (7 day validity)' setting for use without Internet, use `offline_profile: true` to add this permission to generated profiles.
+
+> [!NOTE]
+> Offline profiles can only be created when logging in with an Apple ID. Apple's App Store Connect API (`api_key` / `api_key_path`) does not support this setting, so _match_ will fail with a clear error if both are combined.
+
 ##### Managed capabilities
 
 > [!IMPORTANT]

data/fastlane/lib/fastlane/actions/ensure_no_debug_code.rb

@@ -2,7 +2,7 @@ module Fastlane
   module Actions
     class EnsureNoDebugCodeAction < Action
       def self.run(params)
-        command = "grep -RE '#{params[:text]}' '#{File.absolute_path(params[:path])}'"
+        command = "grep -RE #{params[:text].shellescape} #{File.absolute_path(params[:path]).shellescape}"
 
         extensions = []
         extensions << params[:extension] unless params[:extension].nil?
@@ -20,7 +20,7 @@ module Fastlane
           command << " --include=\\*.#{extensions.join(',')}"
         end
 
-        command << " --exclude #{params[:exclude]}" if params[:exclude]
+        command << " --exclude #{params[:exclude].shellescape}" if params[:exclude]
 
         if params[:exclude_dirs]
           params[:exclude_dirs].each do |dir|

data/fastlane/lib/fastlane/actions/get_managed_play_store_publishing_rights.rb

@@ -92,6 +92,7 @@ module Fastlane
                                        conflicting_options: [:json_key],
                                        optional: true,
                                        description: "The raw service account JSON data used to authenticate with Google",
+                                       sensitive: true,
                                        code_gen_sensitive: true,
                                        default_value: CredentialsManager::AppfileConfig.try_fetch_value(:json_key_data_raw),
                                        default_value_dynamic: true,

data/fastlane/lib/fastlane/actions/github_api.rb

@@ -250,12 +250,11 @@ module Fastlane
         def call_endpoint(url, http_method, headers, body, secure)
           require 'excon'
 
-          Excon.defaults[:ssl_verify_peer] = secure
           middlewares = Excon.defaults[:middlewares] + [Excon::Middleware::RedirectFollower] # allow redirect in case of repo renames
 
           UI.verbose("#{http_method} : #{url}")
 
-          connection = Excon.new(url)
+          connection = Excon.new(url, ssl_verify_peer: secure)
           connection.request(
             method: http_method,
             headers: headers,

data/fastlane/lib/fastlane/actions/hg_commit_version_bump.rb

@@ -92,7 +92,7 @@ module Fastlane
         end
 
         # create a commit with a message
-        command = "hg commit -m '#{params[:message]}'"
+        command = "hg commit -m #{params[:message].shellescape}"
         return command if Helper.test?
         begin
           Actions.sh(command)

data/fastlane/lib/fastlane/actions/increment_build_number.rb

@@ -37,7 +37,7 @@ module Fastlane
         command = [
           command_prefix,
           'agvtool',
-          params[:build_number] ? "new-version#{mode} #{params[:build_number].to_s.strip}" : "next-version#{mode}",
+          params[:build_number] ? "new-version#{mode} #{params[:build_number].to_s.strip.shellescape}" : "next-version#{mode}",
           command_suffix
         ].join(' ')
 

data/fastlane/lib/fastlane/actions/increment_version_number.rb

@@ -77,7 +77,7 @@ module Fastlane
 
         command = [
           command_prefix,
-          "agvtool new-marketing-version #{next_version_number.to_s.strip}"
+          "agvtool new-marketing-version #{next_version_number.to_s.strip.shellescape}"
         ].join(' ')
 
         if Helper.test?

data/fastlane/lib/fastlane/actions/install_xcode_plugin.rb

@@ -25,11 +25,14 @@ module Fastlane
           end
         end
 
-        zip_path = File.join(Dir.tmpdir, 'plugin.zip')
-        Action.sh("curl", "-L", "-s", "-o", zip_path, params[:url])
-        plugins_path = "#{ENV['HOME']}/Library/Application Support/Developer/Shared/Xcode/Plug-ins"
-        FileUtils.mkdir_p(plugins_path)
-        Action.sh("unzip", "-qo", zip_path, "-d", plugins_path)
+        Dir.mktmpdir do |dir|
+          zip_path = File.join(dir, 'plugin.zip')
+          # -f fails on an HTTP error instead of saving the error page; --proto also applies to redirects
+          Action.sh("curl", "-f", "-L", "-s", "--proto", "=https", "-o", zip_path, params[:url])
+          plugins_path = "#{ENV['HOME']}/Library/Application Support/Developer/Shared/Xcode/Plug-ins"
+          FileUtils.mkdir_p(plugins_path)
+          Action.sh("unzip", "-qo", zip_path, "-d", plugins_path)
+        end
 
         UI.success("Plugin #{File.basename(params[:url], '.zip')} installed successfully")
         UI.message("Please restart Xcode to use the newly installed plugin")
@@ -85,7 +88,14 @@ module Fastlane
       end
 
       def self.category
-        :misc
+        :deprecated
+      end
+
+      def self.deprecated_notes
+        [
+          "Since Xcode 8, which added runtime library validation and source editor extensions ([New Features in Xcode 8](https://developer.apple.com/library/archive/documentation/DeveloperTools/Conceptual/WhatsNewXcode/Chapters/xcode_8_0.html)), Xcode only loads plugins once you re-sign it yourself, and Xcode 14 removed its plugin system.",
+          "A source editor extension ships inside a macOS app: install the app, then enable the extension in the Extensions section of System Settings."
+        ].join("\n")
       end
     end
   end

data/fastlane/lib/fastlane/actions/lcov.rb

@@ -1,3 +1,5 @@
+require 'tmpdir'
+
 module Fastlane
   module Actions
     class LcovAction < Action
@@ -42,7 +44,7 @@ module Fastlane
       end
 
       def self.gen_cov(options)
-        tmp_cov_file = "/tmp/coverage.info"
+        tmp_cov_file = File.join(Dir.mktmpdir("lcov-"), "coverage.info")
         output_dir = options[:output_dir]
         derived_data_path = derived_data_dir(options)
 
@@ -91,7 +93,14 @@ module Fastlane
       end
 
       def self.category
-        :testing
+        :deprecated
+      end
+
+      def self.deprecated_notes
+        [
+          "Xcode records coverage as LLVM `.profdata`, not the gcov `.gcda` files that `lcov --capture --directory` reads, and this action looks for them under `Build/Intermediates`, which Xcode now names `Build/Intermediates.noindex`.",
+          "Use `slather`, or `xcrun llvm-cov export -format=lcov` to produce an lcov file."
+        ].join("\n")
       end
     end
   end

data/fastlane/lib/fastlane/actions/nexus_upload.rb

@@ -9,9 +9,24 @@ module Fastlane
         command += ssl_options(params)
         command += proxy_options(params)
         command += upload_options(params)
+        command << "--config -"
         command << upload_url(params)
 
-        Fastlane::Actions.sh(command.join(' '), log: params[:verbose])
+        Fastlane::Actions.sh(command.join(' '), log: params[:verbose], stdin: curl_config(params))
+      end
+
+      def self.curl_config(params)
+        config = "user = #{curl_config_string("#{params[:username]}:#{params[:password]}")}\n"
+        if params[:proxy_address] && params[:proxy_port] && params[:proxy_username] && params[:proxy_password]
+          config << "proxy-user = #{curl_config_string("#{params[:proxy_username]}:#{params[:proxy_password]}")}\n"
+        end
+        config
+      end
+
+      # Quotes a value for a curl config file, using the escapes listed under `-K, --config` in `man curl`.
+      def self.curl_config_string(value)
+        escapes = { "\\" => "\\\\", "\"" => "\\\"", "\t" => "\\t", "\n" => "\\n", "\r" => "\\r", "\v" => "\\v" }
+        "\"#{value.gsub(/[\\"\t\n\r\v]/, escapes)}\""
       end
 
       def self.upload_url(params)
@@ -61,8 +76,6 @@ module Fastlane
           options << "--upload-file #{file_path}"
         end
 
-        options << "-u #{params[:username].shellescape}:#{params[:password].shellescape}"
-
         options
       end
 
@@ -79,7 +92,6 @@ module Fastlane
         options = []
         if params[:proxy_address] && params[:proxy_port] && params[:proxy_username] && params[:proxy_password]
           options << "-x #{params[:proxy_address].shellescape}:#{params[:proxy_port].shellescape}"
-          options << "--proxy-user #{params[:proxy_username].shellescape}:#{params[:proxy_password].shellescape}"
         end
 
         options