fastlane 2.143.0 → 2.147.0

data/fastlane/lib/assets/custom_action_template.rb

@@ -29,8 +29,8 @@ module Fastlane
       end
 
       def self.available_options
-        # Define all options your action supports. 
-        
+        # Define all options your action supports.
+
         # Below a few examples
         [
           FastlaneCore::ConfigItem.new(key: :api_token,
@@ -67,13 +67,13 @@ module Fastlane
 
       def self.is_supported?(platform)
         # you can do things like
-        # 
+        #
         #  true
-        # 
+        #
         #  platform == :ios
-        # 
+        #
         #  [:ios, :mac].include?(platform)
-        # 
+        #
 
         platform == :ios
       end

data/fastlane/lib/fastlane/actions/automatic_code_signing.rb

@@ -3,6 +3,8 @@ module Fastlane
   module Actions
     class AutomaticCodeSigningAction < Action
       def self.run(params)
+        UI.deprecated("The `automatic_code_signing` action has been deprecated,")
+        UI.deprecated("Please use `update_code_signing_settings` action instead.")
         FastlaneCore::PrintTable.print_values(config: params, title: "Summary for Automatic Codesigning")
         path = params[:path]
         path = File.join(File.expand_path(path), "project.pbxproj")
@@ -201,7 +203,11 @@ module Fastlane
       end
 
       def self.category
-        :code_signing
+        :deprecated
+      end
+
+      def self.deprecated_notes
+        "Please use `update_code_signing_settings` action instead."
       end
 
       def self.return_value

data/fastlane/lib/fastlane/actions/clean_build_artifacts.rb

@@ -21,6 +21,9 @@ module Fastlane
           File.delete(file)
         end
 
+        Actions.lane_context[Actions::SharedValues::SIGH_PROFILE_PATHS] = nil
+        Actions.lane_context[Actions::SharedValues::DSYM_PATHS] = nil
+
         UI.success('Cleaned up build artifacts 🐙')
       end
 

data/fastlane/lib/fastlane/actions/cocoapods.rb

@@ -156,7 +156,7 @@ module Fastlane
         [
           'cocoapods',
           'cocoapods(
-            clean: true,
+            clean_install: true,
             podfile: "./CustomPodfile"
           )'
         ]

data/fastlane/lib/fastlane/actions/crashlytics.rb

@@ -66,7 +66,7 @@ module Fastlane
       end
 
       def self.description
-        "Upload a new build to [Crashlytics Beta](http://try.crashlytics.com/beta/)"
+        "Refer to [Firebase App Distribution](https://appdistro.page.link/fastlane-repo)"
       end
 
       def self.available_options
@@ -169,6 +169,10 @@ module Fastlane
 
       def self.details
         [
+          "Crashlytics Beta has been deprecated and replaced with Firebase App Distribution.",
+          "Beta will continue working until May 4, 2020.",
+          "Check out the [Firebase App Distribution docs](https://github.com/fastlane/fastlane-plugin-firebase_app_distribution) to get started.",
+          "",
           "Additionally, you can specify `notes`, `emails`, `groups` and `notifications`.",
           "Distributing to Groups: When using the `groups` parameter, it's important to use the group **alias** names for each group you'd like to distribute to. A group's alias can be found in the web UI. If you're viewing the Beta page, you can open the groups dialog by clicking the 'Manage Groups' button.",
           "This action uses the `submit` binary provided by the Crashlytics framework. If the binary is not found in its usual path, you'll need to specify the path manually by using the `crashlytics_path` option."
@@ -196,7 +200,15 @@ module Fastlane
       end
 
       def self.category
-        :beta
+        :deprecated
+      end
+
+      def self.deprecated_notes
+        [
+          "Crashlytics Beta has been deprecated and replaced with Firebase App Distribution.",
+          "Beta will continue working until May 4, 2020.",
+          "Check out the [Firebase App Distribution docs](https://github.com/fastlane/fastlane-plugin-firebase_app_distribution) to get started."
+        ].join("\n")
       end
     end
   end

data/fastlane/lib/fastlane/actions/create_pull_request.rb

@@ -15,6 +15,7 @@ module Fastlane
           'base' => params[:base]
         }
         payload['body'] = params[:body] if params[:body]
+        payload['draft'] = params[:draft] if params[:draft]
 
         GithubApiAction.run(
           server_url: params[:api_url],
@@ -176,6 +177,11 @@ module Fastlane
                                        description: "The contents of the pull request",
                                        is_string: true,
                                        optional: true),
+          FastlaneCore::ConfigItem.new(key: :draft,
+                                       env_name: "GITHUB_PULL_REQUEST_DRAFT",
+                                       description: "Indicates whether the pull request is a draft",
+                                       type: Boolean,
+                                       optional: true),
           FastlaneCore::ConfigItem.new(key: :labels,
                                        env_name: "GITHUB_PULL_REQUEST_LABELS",
                                        description: "The labels for the pull request",
@@ -226,7 +232,7 @@ module Fastlane
       end
 
       def self.author
-        ["seei", "tommeier", "marumemomo", "elneruda"]
+        ["seei", "tommeier", "marumemomo", "elneruda", "kagemiku"]
       end
 
       def self.is_supported?(platform)

data/fastlane/lib/fastlane/actions/docs/capture_ios_screenshots.md

@@ -190,10 +190,16 @@ The `Snapfile` can contain all the options that are also available on `fastlane
 scheme("UITests")
 
 devices([
-  "iPhone 6",
-  "iPhone 6 Plus",
-  "iPhone 5",
-  "iPhone 4s"
+  "iPad (7th generation)",
+  "iPad Air (3rd generation)",
+  "iPad Pro (11-inch)",
+  "iPad Pro (12.9-inch) (3rd generation)",
+  "iPad Pro (9.7-inch)",
+  "iPhone 11",
+  "iPhone 11 Pro",
+  "iPhone 11 Pro Max",
+  "iPhone 8",
+  "iPhone 8 Plus"
 ])
 
 languages([
@@ -210,6 +216,8 @@ output_directory('./screenshots')
 
 clear_previous_screenshots(true)
 
+override_status_bar(true)
+
 add_photos(["MyTestApp/Assets/demo.jpg"])
 ```
 
@@ -320,7 +328,7 @@ To get more information about language and locale codes please read [Internation
 
 ## Use a clean status bar
 
-You can use [SimulatorStatusMagic](https://github.com/shinydevelopment/SimulatorStatusMagic) to clean up the status bar.
+You can set `override_status_bar` to `true` to set the status bar to Tuesday January 9th at 9:41AM with full battery and reception.
 
 ## Editing the `Snapfile`
 

data/fastlane/lib/fastlane/actions/docs/frame_screenshots.md

@@ -329,7 +329,7 @@ Use [_deliver_](https://docs.fastlane.tools/actions/deliver/) to upload iOS scre
 
 ## Use a clean status bar
 
-You can use [SimulatorStatusMagic](https://github.com/shinydevelopment/SimulatorStatusMagic) to clean up the status bar.
+You can set `override_status_bar` to `true` in snapshot to set the status bar to Tuesday January 9th at 9:41AM with full battery and reception.
 
 ## Gray artifacts around text
 

data/fastlane/lib/fastlane/actions/docs/sync_code_signing.md

@@ -6,7 +6,7 @@
 
 A new approach to iOS code signing: Share one code signing identity across your development team to simplify your codesigning setup and prevent code signing issues.
 
-_match_ is the implementation of the [codesigning.guide concept](https://codesigning.guide). _match_ creates all required certificates & provisioning profiles and stores them in a separate git repository. Every team member with access to the repo can use those credentials for code signing. _match_ also automatically repairs broken and expired credentials. It's the easiest way to share signing credentials across teams
+_match_ is the implementation of the [codesigning.guide concept](https://codesigning.guide). _match_ creates all required certificates & provisioning profiles and stores them in a separate git repository, Google Cloud, or Amazon S3. Every team member with access to the selected storage can use those credentials for code signing. _match_ also automatically repairs broken and expired credentials. It's the easiest way to share signing credentials across teams
 
 [More information on how to get started with codesigning](https://docs.fastlane.tools/codesigning/getting-started/)
 
@@ -465,13 +465,13 @@ You'll be asked for the new password on all your machines on the next run.
 
 ### Import
 
-To import and encrypt a certificate (`.cer`) and the private key (`.p12`) into the _match_ repo run:
+To import and encrypt a certificate (`.cer`), the private key (`.p12`) and the provisioning profiles (`.mobileprovision` or `.provisionprofile`) into the _match_ repo run:
 
 ```no-highlight
 fastlane match import
 ```
 
-You'll be prompted for the certificate (`.cer`) and the private key (`.p12`) paths. _match_ will first validate the certificate (`.cer`) against the Developer Portal before importing the certificate (`.cer`) and the private key (`.p12`).
+You'll be prompted for the certificate (`.cer`), the private key (`.p12`) and the provisioning profiles (`.mobileprovision` or `.provisionprofile`) paths. _match_ will first validate the certificate (`.cer`) against the Developer Portal before importing the certificate, the private key and the provisioning profiles into the specified _match_ repository.
 
 ### Manual Decrypt
 

data/fastlane/lib/fastlane/actions/get_version_number.rb

@@ -82,7 +82,7 @@ module Fastlane
       def self.get_version_number_from_build_settings!(target, variable, configuration = nil)
         target.build_configurations.each do |config|
           if configuration.nil? || config.name == configuration
-            value = config.build_settings[variable]
+            value = config.resolve_build_setting(variable)
             return value if value
           end
         end

data/fastlane/lib/fastlane/actions/git_branch.rb

@@ -1,7 +1,7 @@
 module Fastlane
   module Actions
     module SharedValues
-      GIT_BRANCH_ENV_VARS = %w(GIT_BRANCH BRANCH_NAME TRAVIS_BRANCH BITRISE_GIT_BRANCH CI_BUILD_REF_NAME CI_COMMIT_REF_NAME WERCKER_GIT_BRANCH BUILDKITE_BRANCH).freeze
+      GIT_BRANCH_ENV_VARS = %w(GIT_BRANCH BRANCH_NAME TRAVIS_BRANCH BITRISE_GIT_BRANCH CI_BUILD_REF_NAME CI_COMMIT_REF_NAME WERCKER_GIT_BRANCH BUILDKITE_BRANCH APPCENTER_BRANCH).freeze
     end
 
     class GitBranchAction < Action

data/fastlane/lib/fastlane/actions/pod_lib_lint.rb

@@ -26,6 +26,7 @@ module Fastlane
         command << "--platforms=#{params[:platforms]}" if params[:platforms]
         command << "--skip-import-validation" if params[:skip_import_validation]
         command << "--skip-tests" if params[:skip_tests]
+        command << "--analyze" if params[:analyze]
 
         result = Actions.sh(command.join(' '))
         UI.success("Pod lib lint Successfully ⬆️ ")
@@ -144,7 +145,12 @@ module Fastlane
                                        description: "Lint skips building and running tests during validation (available since cocoapods >= 1.3)",
                                        type: Boolean,
                                        default_value: false,
-                                       env_name: "FL_POD_LIB_LINT_SKIP_TESTS")
+                                       env_name: "FL_POD_LIB_LINT_SKIP_TESTS"),
+          FastlaneCore::ConfigItem.new(key: :analyze,
+                                       description: "Validate with the Xcode Static Analysis tool (available since cocoapods >= 1.6.1)",
+                                       type: Boolean,
+                                       default_value: false,
+                                       env_name: "FL_POD_LIB_LINT_ANALYZE")
         ]
       end
 

data/fastlane/lib/fastlane/actions/set_pod_key.rb

@@ -8,9 +8,9 @@ module Fastlane
         cmd << ['bundle exec'] if params[:use_bundle_exec] && shell_out_should_use_bundle_exec?
         cmd << ['pod keys set']
 
-        cmd << ["\"#{params[:key].shellescape}\""]
-        cmd << ["\"#{params[:value].shellescape}\""]
-        cmd << ["\"#{params[:project].shellescape}\""] if params[:project]
+        cmd << ["\"#{params[:key]}\""]
+        cmd << ["\"#{params[:value]}\""]
+        cmd << ["\"#{params[:project]}\""] if params[:project]
 
         Actions.sh(cmd.join(' '))
       end

data/fastlane/lib/fastlane/actions/setup_ci.rb

@@ -93,7 +93,7 @@ module Fastlane
                                        env_name: "FL_SETUP_CI_PROVIDER",
                                        description: "CI provider. If none is set, the provider is detected automatically",
                                        is_string: true,
-                                       default_value: false,
+                                       optional: true,
                                        verify_block: proc do |value|
                                          value = value.to_s
                                          # Validate both 'travis' and 'circleci' for backwards compatibility, even

data/fastlane/lib/fastlane/actions/setup_jenkins.rb

@@ -14,7 +14,10 @@ module Fastlane
         "SCAN_DERIVED_DATA_PATH",
         "SCAN_OUTPUT_DIRECTORY",
         "SCAN_RESULT_BUNDLE",
-        "XCODE_DERIVED_DATA_PATH"
+        "XCODE_DERIVED_DATA_PATH",
+        "MATCH_KEYCHAIN_NAME",
+        "MATCH_KEYCHAIN_PASSWORD",
+        "MATCH_READONLY"
       ].freeze
 
       def self.run(params)
@@ -40,6 +43,9 @@ module Fastlane
             add_to_search_list: params[:add_keychain_to_search_list],
             set_default: params[:set_default_keychain]
           )
+          ENV['MATCH_KEYCHAIN_NAME'] ||= keychain_path
+          ENV['MATCH_KEYCHAIN_PASSWORD'] ||= params[:keychain_password]
+          ENV["MATCH_READONLY"] ||= true.to_s
         end
 
         # Code signing identity
@@ -90,6 +96,7 @@ module Fastlane
       def self.details
         list = <<-LIST.markdown_list(true)
           Adds and unlocks keychains from Jenkins 'Keychains and Provisioning Profiles Plugin'
+          Sets unlocked keychain to be used by Match
           Sets code signing identity from Jenkins 'Keychains and Provisioning Profiles Plugin'
           Sets output directory to './output' (gym, scan and backup_xcarchive)
           Sets derived data path to './derivedData' (xcodebuild, gym, scan and clear_derived_data, carthage)
@@ -99,7 +106,9 @@ module Fastlane
         [
           list,
           "This action helps with Jenkins integration. Creates own derived data for each job. All build results like IPA files and archives will be stored in the `./output` directory.",
-          "The action also works with [Keychains and Provisioning Profiles Plugin](https://wiki.jenkins-ci.org/display/JENKINS/Keychains+and+Provisioning+Profiles+Plugin), the selected keychain will be automatically unlocked and the selected code signing identity will be used. By default this action will only work when _fastlane_ is executed on a CI system."
+          "The action also works with [Keychains and Provisioning Profiles Plugin](https://wiki.jenkins-ci.org/display/JENKINS/Keychains+and+Provisioning+Profiles+Plugin), the selected keychain will be automatically unlocked and the selected code signing identity will be used.",
+          "[Match](https://docs.fastlane.tools/actions/match/) will be also set up to use the unlocked keychain and set in read-only mode, if its environment variables were not yet defined.",
+          "By default this action will only work when _fastlane_ is executed on a CI system."
         ].join("\n")
       end
 

data/fastlane/lib/fastlane/actions/slather.rb

@@ -241,7 +241,7 @@ module Fastlane
           FastlaneCore::ConfigItem.new(key: :ignore,
                                        env_name: "FL_SLATHER_IGNORE",
                                        description: "Tell slather to ignore files matching a path or any path from an array of paths",
-                                       is_string: false,
+                                       type: Array,
                                        optional: true),
           FastlaneCore::ConfigItem.new(key: :verbose,
                                        env_name: "FL_SLATHER_VERBOSE",

data/fastlane/lib/fastlane/actions/swiftlint.rb

@@ -13,13 +13,7 @@ module Fastlane
 
         command = (params[:executable] || "swiftlint").dup
         command << " #{params[:mode]}"
-        command << " --path #{params[:path].shellescape}" if params[:path]
-        command << supported_option_switch(params, :strict, "0.9.2", true)
-        command << " --config #{params[:config_file].shellescape}" if params[:config_file]
-        command << " --reporter #{params[:reporter]}" if params[:reporter]
-        command << supported_option_switch(params, :quiet, "0.9.0", true)
-        command << supported_option_switch(params, :format, "0.11.0", true) if params[:mode] == :autocorrect
-        command << " --compiler-log-path #{params[:compiler_log_path].shellescape}" if params[:compiler_log_path]
+        command << optional_flags(params)
 
         if params[:files]
           if version < Gem::Version.new('0.5.1')
@@ -41,12 +35,33 @@ module Fastlane
         end
       end
 
+      def self.optional_flags(params)
+        command = ""
+        command << " --path #{params[:path].shellescape}" if params[:path]
+        command << supported_option_switch(params, :strict, "0.9.2", true)
+        command << " --config #{params[:config_file].shellescape}" if params[:config_file]
+        command << " --reporter #{params[:reporter]}" if params[:reporter]
+        command << supported_option_switch(params, :quiet, "0.9.0", true)
+        command << supported_option_switch(params, :format, "0.11.0", true) if params[:mode] == :autocorrect
+        command << supported_no_cache_option(params) if params[:no_cache]
+        command << " --compiler-log-path #{params[:compiler_log_path].shellescape}" if params[:compiler_log_path]
+        return command
+      end
+
       # Get current SwiftLint version
       def self.swiftlint_version(executable: nil)
         binary = executable || 'swiftlint'
         Gem::Version.new(`#{binary} version`.chomp)
       end
 
+      def self.supported_no_cache_option(params)
+        if params[:mode] == :autocorrect || params[:mode] == :lint
+          return " --no-cache"
+        else
+          return ""
+        end
+      end
+
       # Return "--option" switch if option is on and current SwiftLint version is greater or equal than min version.
       # Return "" otherwise.
       def self.supported_option_switch(params, option, min_version, can_ignore = false)
@@ -139,6 +154,12 @@ module Fastlane
                                        is_string: false,
                                        type: Boolean,
                                        optional: true),
+          FastlaneCore::ConfigItem.new(key: :no_cache,
+                                       description: "Ignore the cache when mode is :autocorrect or :lint",
+                                       default_value: false,
+                                       is_string: false,
+                                       type: Boolean,
+                                       optional: true),
           FastlaneCore::ConfigItem.new(key: :compiler_log_path,
                                        description: "Compiler log path when mode is :analyze",
                                        is_string: true,

data/fastlane/lib/fastlane/actions/testfairy.rb

@@ -2,6 +2,8 @@ module Fastlane
   module Actions
     module SharedValues
       TESTFAIRY_BUILD_URL = :TESTFAIRY_BUILD_URL
+      TESTFAIRY_DOWNLOAD_URL = :TESTFAIRY_DOWNLOAD_URL
+      TESTFAIRY_LANDING_PAGE = :TESTFAIRY_LANDING_PAGE
     end
 
     class TestfairyAction < Action
@@ -107,6 +109,8 @@ module Fastlane
         response = self.upload_build(params[:upload_url], path, client_options, params[:timeout])
         if parse_response(response)
           UI.success("Build URL: #{Actions.lane_context[SharedValues::TESTFAIRY_BUILD_URL]}")
+          UI.success("Download URL: #{Actions.lane_context[SharedValues::TESTFAIRY_DOWNLOAD_URL]}")
+          UI.success("Landing Page URL: #{Actions.lane_context[SharedValues::TESTFAIRY_LANDING_PAGE]}")
           UI.success("Build successfully uploaded to TestFairy.")
         else
           UI.user_error!("Error when trying to upload ipa to TestFairy")
@@ -120,8 +124,12 @@ module Fastlane
       def self.parse_response(response)
         if response.body && response.body.key?('status') && response.body['status'] == 'ok'
           build_url = response.body['build_url']
+          app_url = response.body['app_url']
+          landing_page_url = response.body['landing_page_url']
 
           Actions.lane_context[SharedValues::TESTFAIRY_BUILD_URL] = build_url
+          Actions.lane_context[SharedValues::TESTFAIRY_DOWNLOAD_URL] = app_url
+          Actions.lane_context[SharedValues::TESTFAIRY_LANDING_PAGE] = landing_page_url
 
           return true
         else
@@ -244,7 +252,12 @@ module Fastlane
             api_key: "...",
             ipa: "./ipa_file.ipa",
             comment: "Build #{lane_context[SharedValues::BUILD_NUMBER]}",
-          )'
+          )',
+          'testfairy(
+            api_key: "...",
+            apk: "../build/app/outputs/apk/qa/release/app-qa-release.apk",
+            comment: "Build #{lane_context[SharedValues::BUILD_NUMBER]}",
+           )'
         ]
       end
 
@@ -254,12 +267,14 @@ module Fastlane
 
       def self.output
         [
-          ['TESTFAIRY_BUILD_URL', 'URL of the newly uploaded build']
+          ['TESTFAIRY_BUILD_URL', 'URL for the sessions of the newly uploaded build'],
+          ['TESTFAIRY_DOWNLOAD_URL', 'URL directly to the newly uploaded build'],
+          ['TESTFAIRY_LANDING_PAGE', 'URL of the build\'s landing page']
         ]
       end
 
       def self.authors
-        ["taka0125", "tcurdt", "vijaysharm"]
+        ["taka0125", "tcurdt", "vijaysharm", "cdm2012"]
       end
 
       def self.is_supported?(platform)