fastlane 2.143.0 → 2.147.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e92b08dddc966a17437ad382e38fcc8e5a5f06a0d1d6e7f692574b9919ec5804
-  data.tar.gz: 2328317029dd9a9648ad22c61b028532cb2d1e18d792e6678d581d9e92494575
+  metadata.gz: 0bf4c8ac33bb5351c05ee6b2c04c193b206c90348e9bc6ffd048c9f31b42785c
+  data.tar.gz: a52d63e8b602d173b5c41913c08e9e4995749b023b2e8364460d987757a3d6cd
 SHA512:
-  metadata.gz: 68a71d0cc29672e7d94851c951a040f8515985d655f306be4089b46f7a9d90079a995b6404402fda53d053c59f060b08d8acbdcfd4fb2acf753622258b94d8d7
-  data.tar.gz: 6889b1d8b59cbce13d432a0759381a29d84144c625feb3547c0b872611c07db87bb7827cbf613eee60fd2af21e6fc5bb322b2d595255a17d7a40ecaf0b90462d
+  metadata.gz: 3b5bdab3f6410a68b90b5086cb18a67434f2a572dee70a18b21bd034fcaa48783e933b7c5c888dbd749efe5250715aca42d88da73d036adaf347ed10c3b1a9c0
+  data.tar.gz: 3274baacd53911b6975b144771b18f33c58a7d25a4ef61f1d5791fbf31c30491967824780d4f89b54b9f08ff7f44a2e28a32ae62d70ba785cb1bfb2ae4ad66c6

data/README.md

@@ -34,23 +34,49 @@ If the above doesn't help, please [submit an issue](https://github.com/fastlane/
 <!-- This table is regenerated and resorted on each release -->
 <table id='team'>
 <tr>
+<td id='aaron-brager'>
+<a href='https://github.com/getaaron'>
+<img src='https://github.com/getaaron.png?size=140'>
+</a>
+<h4 align='center'><a href='https://twitter.com/getaaron'>Aaron Brager</a></h4>
+</td>
+<td id='jorge-revuelta-h'>
+<a href='https://github.com/minuscorp'>
+<img src='https://github.com/minuscorp.png?size=140'>
+</a>
+<h4 align='center'><a href='https://twitter.com/minuscorp'>Jorge Revuelta H</a></h4>
+</td>
 <td id='josh-holtz'>
 <a href='https://github.com/joshdholtz'>
 <img src='https://github.com/joshdholtz.png?size=140'>
 </a>
 <h4 align='center'><a href='https://twitter.com/joshdholtz'>Josh Holtz</a></h4>
 </td>
-<td id='danielle-tomlinson'>
-<a href='https://github.com/endocrimes'>
-<img src='https://github.com/endocrimes.png?size=140'>
+<td id='luka-mirosevic'>
+<a href='https://github.com/lmirosevic'>
+<img src='https://github.com/lmirosevic.png?size=140'>
 </a>
-<h4 align='center'><a href='https://twitter.com/endocrimes'>Danielle Tomlinson</a></h4>
+<h4 align='center'><a href='https://twitter.com/lmirosevic'>Luka Mirosevic</a></h4>
 </td>
-<td id='jérôme-lacoste'>
-<a href='https://github.com/lacostej'>
-<img src='https://github.com/lacostej.png?size=140'>
+<td id='daniel-jankowski'>
+<a href='https://github.com/mollyIV'>
+<img src='https://github.com/mollyIV.png?size=140'>
 </a>
-<h4 align='center'><a href='https://twitter.com/lacostej'>Jérôme Lacoste</a></h4>
+<h4 align='center'><a href='https://twitter.com/mollyIV'>Daniel Jankowski</a></h4>
+</td>
+</tr>
+<tr>
+<td id='jimmy-dee'>
+<a href='https://github.com/jdee'>
+<img src='https://github.com/jdee.png?size=140'>
+</a>
+<h4 align='center'>Jimmy Dee</h4>
+</td>
+<td id='manu-wallner'>
+<a href='https://github.com/milch'>
+<img src='https://github.com/milch.png?size=140'>
+</a>
+<h4 align='center'><a href='https://twitter.com/acrooow'>Manu Wallner</a></h4>
 </td>
 <td id='fumiya-nakamura'>
 <a href='https://github.com/nafu'>
@@ -58,63 +84,63 @@ If the above doesn't help, please [submit an issue](https://github.com/fastlane/
 </a>
 <h4 align='center'><a href='https://twitter.com/nafu003'>Fumiya Nakamura</a></h4>
 </td>
-<td id='olivier-halligon'>
-<a href='https://github.com/AliSoftware'>
-<img src='https://github.com/AliSoftware.png?size=140'>
+<td id='iulian-onofrei'>
+<a href='https://github.com/revolter'>
+<img src='https://github.com/revolter.png?size=140'>
 </a>
-<h4 align='center'><a href='https://twitter.com/aligatr'>Olivier Halligon</a></h4>
+<h4 align='center'><a href='https://twitter.com/Revolt666'>Iulian Onofrei</a></h4>
 </td>
-</tr>
-<tr>
-<td id='luka-mirosevic'>
-<a href='https://github.com/lmirosevic'>
-<img src='https://github.com/lmirosevic.png?size=140'>
+<td id='stefan-natchev'>
+<a href='https://github.com/snatchev'>
+<img src='https://github.com/snatchev.png?size=140'>
 </a>
-<h4 align='center'><a href='https://twitter.com/lmirosevic'>Luka Mirosevic</a></h4>
+<h4 align='center'><a href='https://twitter.com/snatchev'>Stefan Natchev</a></h4>
 </td>
+</tr>
+<tr>
 <td id='max-ott'>
 <a href='https://github.com/max-ott'>
 <img src='https://github.com/max-ott.png?size=140'>
 </a>
 <h4 align='center'><a href='https://twitter.com/ott_max'>Max Ott</a></h4>
 </td>
-<td id='jan-piotrowski'>
-<a href='https://github.com/janpio'>
-<img src='https://github.com/janpio.png?size=140'>
+<td id='jérôme-lacoste'>
+<a href='https://github.com/lacostej'>
+<img src='https://github.com/lacostej.png?size=140'>
 </a>
-<h4 align='center'><a href='https://twitter.com/Sujan'>Jan Piotrowski</a></h4>
+<h4 align='center'><a href='https://twitter.com/lacostej'>Jérôme Lacoste</a></h4>
 </td>
-<td id='jorge-revuelta-h'>
-<a href='https://github.com/minuscorp'>
-<img src='https://github.com/minuscorp.png?size=140'>
+<td id='danielle-tomlinson'>
+<a href='https://github.com/endocrimes'>
+<img src='https://github.com/endocrimes.png?size=140'>
 </a>
-<h4 align='center'><a href='https://twitter.com/minuscorp'>Jorge Revuelta H</a></h4>
+<h4 align='center'><a href='https://twitter.com/endocrimes'>Danielle Tomlinson</a></h4>
 </td>
-<td id='manu-wallner'>
-<a href='https://github.com/milch'>
-<img src='https://github.com/milch.png?size=140'>
+<td id='felix-krause'>
+<a href='https://github.com/KrauseFx'>
+<img src='https://github.com/KrauseFx.png?size=140'>
 </a>
-<h4 align='center'><a href='https://twitter.com/acrooow'>Manu Wallner</a></h4>
+<h4 align='center'><a href='https://twitter.com/KrauseFx'>Felix Krause</a></h4>
 </td>
-</tr>
-<tr>
-<td id='andrew-mcburney'>
-<a href='https://github.com/armcburney'>
-<img src='https://github.com/armcburney.png?size=140'>
+<td id='maksym-grebenets'>
+<a href='https://github.com/mgrebenets'>
+<img src='https://github.com/mgrebenets.png?size=140'>
 </a>
-<h4 align='center'><a href='https://twitter.com/armcburney'>Andrew McBurney</a></h4>
+<h4 align='center'><a href='https://twitter.com/mgrebenets'>Maksym Grebenets</a></h4>
 </td>
-<td id='daniel-jankowski'>
-<a href='https://github.com/mollyIV'>
-<img src='https://github.com/mollyIV.png?size=140'>
+</tr>
+<tr>
+<td id='kohki-miki'>
+<a href='https://github.com/giginet'>
+<img src='https://github.com/giginet.png?size=140'>
 </a>
-<h4 align='center'><a href='https://twitter.com/mollyIV'>Daniel Jankowski</a></h4>
+<h4 align='center'><a href='https://twitter.com/giginet'>Kohki Miki</a></h4>
 </td>
-<td id='joshua-liebowitz'>
-<a href='https://github.com/taquitos'>
-<img src='https://github.com/taquitos.png?size=140'>
+<td id='jan-piotrowski'>
+<a href='https://github.com/janpio'>
+<img src='https://github.com/janpio.png?size=140'>
 </a>
-<h4 align='center'><a href='https://twitter.com/taquitos'>Joshua Liebowitz</a></h4>
+<h4 align='center'><a href='https://twitter.com/Sujan'>Jan Piotrowski</a></h4>
 </td>
 <td id='helmut-januschka'>
 <a href='https://github.com/hjanuschka'>
@@ -122,57 +148,31 @@ If the above doesn't help, please [submit an issue](https://github.com/fastlane/
 </a>
 <h4 align='center'><a href='https://twitter.com/hjanuschka'>Helmut Januschka</a></h4>
 </td>
-<td id='kohki-miki'>
-<a href='https://github.com/giginet'>
-<img src='https://github.com/giginet.png?size=140'>
-</a>
-<h4 align='center'><a href='https://twitter.com/giginet'>Kohki Miki</a></h4>
-</td>
-</tr>
-<tr>
 <td id='matthew-ellis'>
 <a href='https://github.com/matthewellis'>
 <img src='https://github.com/matthewellis.png?size=140'>
 </a>
 <h4 align='center'><a href='https://twitter.com/mellis1995'>Matthew Ellis</a></h4>
 </td>
-<td id='jimmy-dee'>
-<a href='https://github.com/jdee'>
-<img src='https://github.com/jdee.png?size=140'>
-</a>
-<h4 align='center'>Jimmy Dee</h4>
-</td>
-<td id='iulian-onofrei'>
-<a href='https://github.com/revolter'>
-<img src='https://github.com/revolter.png?size=140'>
-</a>
-<h4 align='center'><a href='https://twitter.com/Revolt666'>Iulian Onofrei</a></h4>
-</td>
-<td id='stefan-natchev'>
-<a href='https://github.com/snatchev'>
-<img src='https://github.com/snatchev.png?size=140'>
-</a>
-<h4 align='center'><a href='https://twitter.com/snatchev'>Stefan Natchev</a></h4>
-</td>
-<td id='felix-krause'>
-<a href='https://github.com/KrauseFx'>
-<img src='https://github.com/KrauseFx.png?size=140'>
+<td id='andrew-mcburney'>
+<a href='https://github.com/armcburney'>
+<img src='https://github.com/armcburney.png?size=140'>
 </a>
-<h4 align='center'><a href='https://twitter.com/KrauseFx'>Felix Krause</a></h4>
+<h4 align='center'><a href='https://twitter.com/armcburney'>Andrew McBurney</a></h4>
 </td>
 </tr>
 <tr>
-<td id='maksym-grebenets'>
-<a href='https://github.com/mgrebenets'>
-<img src='https://github.com/mgrebenets.png?size=140'>
+<td id='joshua-liebowitz'>
+<a href='https://github.com/taquitos'>
+<img src='https://github.com/taquitos.png?size=140'>
 </a>
-<h4 align='center'><a href='https://twitter.com/mgrebenets'>Maksym Grebenets</a></h4>
+<h4 align='center'><a href='https://twitter.com/taquitos'>Joshua Liebowitz</a></h4>
 </td>
-<td id='aaron-brager'>
-<a href='https://github.com/getaaron'>
-<img src='https://github.com/getaaron.png?size=140'>
+<td id='olivier-halligon'>
+<a href='https://github.com/AliSoftware'>
+<img src='https://github.com/AliSoftware.png?size=140'>
 </a>
-<h4 align='center'><a href='https://twitter.com/getaaron'>Aaron Brager</a></h4>
+<h4 align='center'><a href='https://twitter.com/aligatr'>Olivier Halligon</a></h4>
 </td>
 </table>
 

data/credentials_manager/lib/credentials_manager/appfile_config.rb

@@ -119,6 +119,10 @@ module CredentialsManager
       setter(:itc_team_name, *args, &block)
     end
 
+    def itc_provider(*args, &block)
+      setter(:itc_provider, *args, &block)
+    end
+
     # Android
     def json_key_file(*args, &block)
       setter(:json_key_file, *args, &block)

data/deliver/lib/deliver/app_screenshot.rb

@@ -316,6 +316,7 @@ module Deliver
     def self.resolve_ipadpro_conflict_if_needed(screen_size, filename)
       is_3rd_gen = [
         "iPad Pro (12.9-inch) (3rd generation)", # default simulator name has this
+        "iPad Pro (12.9-inch) (4th generation)", # default simulator name has this
         "ipadPro129" # downloaded screenshots name has this
       ].any? { |key| filename.include?(key) }
       if is_3rd_gen

data/deliver/lib/deliver/options.rb

@@ -30,6 +30,7 @@ module Deliver
         # version
         FastlaneCore::ConfigItem.new(key: :app_version,
                                      short_option: '-z',
+                                     env_name: "DELIVER_APP_VERSION",
                                      description: "The version that should be edited or created",
                                      optional: true),
 
@@ -68,6 +69,7 @@ module Deliver
                                      end),
         FastlaneCore::ConfigItem.new(key: :build_number,
                                      short_option: "-n",
+                                     env_name: "DELIVER_BUILD_NUMBER",
                                      description: "If set the given build number (already uploaded to iTC) will be used instead of the current built one",
                                      optional: true,
                                      conflicting_options: [:ipa, :pkg],
@@ -93,6 +95,7 @@ module Deliver
                                      description: "Modify live metadata, this option disables ipa upload and screenshot upload",
                                      is_string: false),
         FastlaneCore::ConfigItem.new(key: :use_live_version,
+                                     env_name: "DELIVER_USE_LIVE_VERSION",
                                      description: "Force usage of live version rather than edit version",
                                      is_string: false,
                                      default_value: false),
@@ -100,27 +103,33 @@ module Deliver
         # paths
         FastlaneCore::ConfigItem.new(key: :metadata_path,
                                      short_option: '-m',
+                                     env_name: "DELIVER_METADATA_PATH",
                                      description: "Path to the folder containing the metadata files",
                                      optional: true),
         FastlaneCore::ConfigItem.new(key: :screenshots_path,
                                      short_option: '-w',
+                                     env_name: "DELIVER_SCREENSHOTS_PATH",
                                      description: "Path to the folder containing the screenshots",
                                      optional: true),
 
         # skip
         FastlaneCore::ConfigItem.new(key: :skip_binary_upload,
+                                     env_name: "DELIVER_SKIP_BINARY_UPLOAD",
                                      description: "Skip uploading an ipa or pkg to App Store Connect",
                                      is_string: false,
                                      default_value: false),
         FastlaneCore::ConfigItem.new(key: :skip_screenshots,
+                                     env_name: "DELIVER_SKIP_SCREENSHOTS",
                                      description: "Don't upload the screenshots",
                                      is_string: false,
                                      default_value: false),
         FastlaneCore::ConfigItem.new(key: :skip_metadata,
+                                     env_name: "DELIVER_SKIP_METADATA",
                                      description: "Don't upload the metadata (e.g. title, description). This will still upload screenshots",
                                      is_string: false,
                                      default_value: false),
         FastlaneCore::ConfigItem.new(key: :skip_app_version_update,
+                                     env_name: "DELIVER_SKIP_APP_VERSION_UPDATE",
                                      description: "Don't update app version for submission",
                                      is_string: false,
                                      default_value: false),
@@ -128,6 +137,7 @@ module Deliver
         # how to operate
         FastlaneCore::ConfigItem.new(key: :force,
                                      short_option: "-f",
+                                     env_name: "DELIVER_FORCE",
                                      description: "Skip the HTML report file verification",
                                      is_string: false,
                                      default_value: false),
@@ -149,6 +159,7 @@ module Deliver
 
         # release
         FastlaneCore::ConfigItem.new(key: :automatic_release,
+                                     env_name: "DELIVER_AUTOMATIC_RELEASE",
                                      description: "Should the app be automatically released once it's approved? (Can not be used together with `auto_release_date`)",
                                      is_string: false,
                                      default_value: false),
@@ -162,11 +173,13 @@ module Deliver
                                        UI.user_error!("You can't use 'auto_release_date' and '#{value.key}' options together.")
                                      end),
         FastlaneCore::ConfigItem.new(key: :phased_release,
+                                     env_name: "DELIVER_PHASED_RELEASE",
                                      description: "Enable the phased release feature of iTC",
                                      optional: true,
                                      is_string: false,
                                      default_value: false),
         FastlaneCore::ConfigItem.new(key: :reset_ratings,
+                                    env_name: "DELIVER_RESET_RATINGS",
                                     description: "Reset the summary rating when you release a new version of the application",
                                     optional: true,
                                     is_string: false,
@@ -175,11 +188,13 @@ module Deliver
         # other app configuration
         FastlaneCore::ConfigItem.new(key: :price_tier,
                                      short_option: "-r",
+                                     env_name: "DELIVER_PRICE_TIER",
                                      description: "The price tier of this application",
                                      is_string: false,
                                      optional: true),
         FastlaneCore::ConfigItem.new(key: :app_rating_config_path,
                                      short_option: "-g",
+                                     env_name: "DELIVER_APP_RATING_CONFIG_PATH",
                                      description: "Path to the app rating's config",
                                      is_string: true,
                                      optional: true,
@@ -244,7 +259,10 @@ module Deliver
         FastlaneCore::ConfigItem.new(key: :itc_provider,
                                      env_name: "DELIVER_ITC_PROVIDER",
                                      description: "The provider short name to be used with the iTMSTransporter to identify your team. This value will override the automatically detected provider short name. To get provider short name run `pathToXcode.app/Contents/Applications/Application\\ Loader.app/Contents/itms/bin/iTMSTransporter -m provider -u 'USERNAME' -p 'PASSWORD' -account_type itunes_connect -v off`. The short names of providers should be listed in the second column",
-                                     optional: true),
+                                     optional: true,
+                                     code_gen_sensitive: true,
+                                     default_value: CredentialsManager::AppfileConfig.try_fetch_value(:itc_provider),
+                                     default_value_dynamic: true),
         # rubocop:enable Metrics/LineLength
 
         # precheck
@@ -271,6 +289,7 @@ module Deliver
 
         # Non Localised
         FastlaneCore::ConfigItem.new(key: :app_icon,
+                                     env_name: "DELIVER_APP_ICON_PATH",
                                      description: "Metadata: The path to the app icon",
                                      optional: true,
                                      short_option: "-l",
@@ -279,6 +298,7 @@ module Deliver
                                        UI.user_error!("'#{value}' doesn't seem to be one of the supported files. supported: #{Deliver::UploadAssets::SUPPORTED_ICON_EXTENSIONS.join(',')}") unless Deliver::UploadAssets::SUPPORTED_ICON_EXTENSIONS.include?(File.extname(value).downcase)
                                      end),
         FastlaneCore::ConfigItem.new(key: :apple_watch_app_icon,
+                                     env_name: "DELIVER_APPLE_WATCH_APP_ICON_PATH",
                                      description: "Metadata: The path to the Apple Watch app icon",
                                      optional: true,
                                      short_option: "-q",
@@ -287,30 +307,37 @@ module Deliver
                                        UI.user_error!("'#{value}' doesn't seem to be one of the supported files. supported: #{Deliver::UploadAssets::SUPPORTED_ICON_EXTENSIONS.join(',')}") unless Deliver::UploadAssets::SUPPORTED_ICON_EXTENSIONS.include?(File.extname(value).downcase)
                                      end),
         FastlaneCore::ConfigItem.new(key: :copyright,
+                                     env_name: "DELIVER_COPYRIGHT",
                                      description: "Metadata: The copyright notice",
                                      optional: true,
                                      is_string: true),
         FastlaneCore::ConfigItem.new(key: :primary_category,
+                                     env_name: "DELIVER_PRIMARY_CATEGORY",
                                      description: "Metadata: The english name of the primary category (e.g. `Business`, `Books`)",
                                      optional: true,
                                      is_string: true),
         FastlaneCore::ConfigItem.new(key: :secondary_category,
+                                     env_name: "DELIVER_SECONDARY_CATEGORY",
                                      description: "Metadata: The english name of the secondary category (e.g. `Business`, `Books`)",
                                      optional: true,
                                      is_string: true),
         FastlaneCore::ConfigItem.new(key: :primary_first_sub_category,
+                                     env_name: "DELIVER_PRIMARY_FIRST_SUB_CATEGORY",
                                      description: "Metadata: The english name of the primary first sub category (e.g. `Educational`, `Puzzle`)",
                                      optional: true,
                                      is_string: true),
         FastlaneCore::ConfigItem.new(key: :primary_second_sub_category,
+                                     env_name: "DELIVER_PRIMARY_SECOND_SUB_CATEGORY",
                                      description: "Metadata: The english name of the primary second sub category (e.g. `Educational`, `Puzzle`)",
                                      optional: true,
                                      is_string: true),
         FastlaneCore::ConfigItem.new(key: :secondary_first_sub_category,
+                                     env_name: "DELIVER_SECONDARY_FIRST_SUB_CATEGORY",
                                      description: "Metadata: The english name of the secondary first sub category (e.g. `Educational`, `Puzzle`)",
                                      optional: true,
                                      is_string: true),
         FastlaneCore::ConfigItem.new(key: :secondary_second_sub_category,
+                                     env_name: "DELIVER_SECONDARY_SECOND_SUB_CATEGORY",
                                      description: "Metadata: The english name of the secondary second sub category (e.g. `Educational`, `Puzzle`)",
                                      optional: true,
                                      is_string: true),
@@ -325,6 +352,7 @@ module Deliver
                                      is_string: false,
                                      type: Hash),
         FastlaneCore::ConfigItem.new(key: :app_review_attachment_file,
+                                     env_name: "DELIVER_APP_REVIEW_ATTACHMENT_FILE",
                                      description: "Metadata: Path to the app review attachment file",
                                      optional: true,
                                      is_string: true),
@@ -391,6 +419,7 @@ module Deliver
         # The verify_block has been removed from here and verification now happens in Deliver::DetectValues
         # Verification needed Spaceship::Tunes.client which required the Deliver::Runner to already by started
         FastlaneCore::ConfigItem.new(key: :languages,
+                                     env_name: "DELIVER_LANGUAGES",
                                      description: "Metadata: List of languages to activate",
                                      type: Array,
                                      optional: true),

data/deliver/lib/deliver/setup.rb

@@ -67,7 +67,7 @@ module Deliver
           else
             content = app_details.send(key)[language].to_s
           end
-          content << "\n"
+          content += "\n"
           resulting_path = File.join(path, language, "#{key}.txt")
           FileUtils.mkdir_p(File.expand_path('..', resulting_path))
           File.write(resulting_path, content)
@@ -82,7 +82,7 @@ module Deliver
         else
           content = app_details.send(key).to_s
         end
-        content << "\n"
+        content += "\n"
         resulting_path = File.join(path, "#{key}.txt")
         File.write(resulting_path, content)
         UI.message("Writing to '#{resulting_path}'")
@@ -91,7 +91,7 @@ module Deliver
       # Trade Representative Contact Information
       UploadMetadata::TRADE_REPRESENTATIVE_CONTACT_INFORMATION_VALUES.each do |key, option_name|
         content = v.send(key).to_s
-        content << "\n"
+        content += "\n"
         base_dir = File.join(path, UploadMetadata::TRADE_REPRESENTATIVE_CONTACT_INFORMATION_DIR)
         FileUtils.mkdir_p(base_dir)
         resulting_path = File.join(base_dir, "#{option_name}.txt")
@@ -102,7 +102,7 @@ module Deliver
       # Review information
       UploadMetadata::REVIEW_INFORMATION_VALUES.each do |key, option_name|
         content = v.send(key).to_s
-        content << "\n"
+        content += "\n"
         base_dir = File.join(path, UploadMetadata::REVIEW_INFORMATION_DIR)
         FileUtils.mkdir_p(base_dir)
         resulting_path = File.join(base_dir, "#{option_name}.txt")