familia 2.0.0.pre17 → 2.0.0.pre19

data/try/unit/horreum/json_type_preservation_try.rb

@@ -0,0 +1,248 @@
+# frozen_string_literal: true
+
+require_relative '../../support/helpers/test_helpers'
+
+Familia.debug = false
+
+# Setup: Define test model with various field types
+class JsonTestModel < Familia::Horreum
+  identifier_field :model_id
+  field :model_id
+  field :name           # String
+  field :age            # Integer
+  field :active         # Boolean
+  field :score          # Float
+  field :metadata       # Hash
+  field :tags           # Array
+  field :nested_data    # Hash with nested structures
+  field :badge_number   # String that looks numeric
+  field :status         # String that looks boolean
+  field :placeholder    # String that looks like null
+end
+
+@test_id = "json_test_#{Familia.now.to_i}"
+
+## String fields preserve String type
+@model = JsonTestModel.new(model_id: @test_id, name: "Test User")
+@model.save
+@loaded = JsonTestModel.find(@test_id)
+@loaded.name
+#=> "Test User"
+
+## String field returns String class
+@loaded.name.class
+#=> String
+
+## Integer fields preserve Integer type (not String)
+@model = JsonTestModel.new(model_id: @test_id, age: 35)
+@model.save
+@loaded = JsonTestModel.find(@test_id)
+@loaded.age
+#=> 35
+
+## Integer field returns Integer class (not String)
+@loaded.age.class
+#=> Integer
+
+## Boolean true preserves TrueClass type (not String "true")
+@model = JsonTestModel.new(model_id: @test_id, active: true)
+@model.save
+@loaded = JsonTestModel.find(@test_id)
+@loaded.active
+#=> true
+
+## Boolean true returns TrueClass
+@loaded.active.class
+#=> TrueClass
+
+## Boolean false preserves FalseClass type (not String "false")
+@model = JsonTestModel.new(model_id: @test_id, active: false)
+@model.save
+@loaded = JsonTestModel.find(@test_id)
+@loaded.active
+#=> false
+
+## Boolean false returns FalseClass
+@loaded.active.class
+#=> FalseClass
+
+## Float fields preserve Float type
+@model = JsonTestModel.new(model_id: @test_id, score: 98.6)
+@model.save
+@loaded = JsonTestModel.find(@test_id)
+@loaded.score
+#=> 98.6
+
+## Float field returns Float class
+@loaded.score.class
+#=> Float
+
+## Hash fields preserve Hash structure
+@model = JsonTestModel.new(model_id: @test_id, metadata: { "key" => "value", "count" => 42 })
+@model.save
+@loaded = JsonTestModel.find(@test_id)
+@loaded.metadata
+#=> {"key"=>"value", "count"=>42}
+
+## Hash field returns Hash class
+@loaded.metadata.class
+#=> Hash
+
+## Array fields preserve Array structure and element types
+@model = JsonTestModel.new(model_id: @test_id, tags: ["ruby", "redis", 123, true])
+@model.save
+@loaded = JsonTestModel.find(@test_id)
+@loaded.tags
+#=> ["ruby", "redis", 123, true]
+
+## Array field returns Array class
+@loaded.tags.class
+#=> Array
+
+## Array preserves Integer element type
+@loaded.tags[2].class
+#=> Integer
+
+## Array preserves Boolean element type
+@loaded.tags[3].class
+#=> TrueClass
+
+## Nested Hash structures preserve types at all levels
+@nested = {
+  "user" => {
+    "name" => "John",
+    "age" => 30,
+    "active" => true,
+    "roles" => ["admin", "user"]
+  },
+  "count" => 5
+}
+@model = JsonTestModel.new(model_id: @test_id, nested_data: @nested)
+@model.save
+@loaded = JsonTestModel.find(@test_id)
+@loaded.nested_data["user"]["age"].class
+#=> Integer
+
+## Nested Hash Boolean preserved
+@loaded.nested_data["user"]["active"].class
+#=> TrueClass
+
+## Nested Hash top-level Integer preserved
+@loaded.nested_data["count"].class
+#=> Integer
+## Round-trip consistency: save → load → save → load maintains types
+@model = JsonTestModel.new(
+  model_id: @test_id,
+  name: "Round Trip",
+  age: 42,
+  active: true,
+  score: 99.9,
+  tags: [1, 2, 3]
+)
+@model.save
+@first_load = JsonTestModel.find(@test_id)
+@first_load.save  # Re-save without modification
+@second_load = JsonTestModel.find(@test_id)
+[@second_load.age.class, @second_load.active.class, @second_load.tags[0].class]
+#=> [Integer, TrueClass, Integer]
+
+## batch_update preserves types
+@model = JsonTestModel.new(model_id: @test_id)
+@model.batch_update(name: "Batch", age: 50, active: false, tags: ["one", 2])
+@loaded = JsonTestModel.find(@test_id)
+[@loaded.name, @loaded.age, @loaded.active, @loaded.tags[1]]
+#=> ["Batch", 50, false, 2]
+
+## batch_update types verification
+[@loaded.age.class, @loaded.active.class, @loaded.tags[1].class]
+#=> [Integer, FalseClass, Integer]
+
+## refresh! maintains type preservation
+@model = JsonTestModel.new(model_id: @test_id, age: 25, active: true)
+@model.save
+# Modify directly in Redis to simulate external change
+@model.dbclient.hset(@model.dbkey, "age", Familia::JsonSerializer.dump(30))
+@model.refresh!
+[@model.age, @model.age.class]
+#=> [30, Integer]
+
+## to_h returns string keys (external API compatibility)
+@model = JsonTestModel.new(model_id: @test_id, name: "API Test", age: 40)
+@hash = @model.to_h
+@hash.keys.first.class
+#=> String
+
+## to_h has string key for name field
+@hash.key?("name")
+#=> true
+
+## Nil values are handled correctly
+@model = JsonTestModel.new(model_id: @test_id, name: "Nil Test", age: nil, active: nil)
+@model.save
+@loaded = JsonTestModel.find(@test_id)
+[@loaded.age, @loaded.active]
+#=> [nil, nil]
+
+## Empty string preserved correctly
+@model = JsonTestModel.new(model_id: @test_id, name: "")
+@model.save
+@loaded = JsonTestModel.find(@test_id)
+@loaded.name
+#=> ""
+
+## Empty string has String class
+@loaded.name.class
+#=> String
+
+## String fields with numeric values preserve String type (badge "007")
+@model = JsonTestModel.new(model_id: @test_id, badge_number: "007")
+@model.save
+@loaded = JsonTestModel.find(@test_id)
+@loaded.badge_number
+#=> "007"
+
+## Badge number preserves String class (not Integer)
+@loaded.badge_number.class
+#=> String
+
+## String "true" stays String (not Boolean)
+@model = JsonTestModel.new(model_id: @test_id, status: "true")
+@model.save
+@loaded = JsonTestModel.find(@test_id)
+[@loaded.status, @loaded.status.class]
+#=> ["true", String]
+
+## String "false" stays String (not Boolean)
+@model = JsonTestModel.new(model_id: @test_id, status: "false")
+@model.save
+@loaded = JsonTestModel.find(@test_id)
+[@loaded.status, @loaded.status.class]
+#=> ["false", String]
+
+## String "null" stays String (not nil)
+@model = JsonTestModel.new(model_id: @test_id, placeholder: "null")
+@model.save
+@loaded = JsonTestModel.find(@test_id)
+[@loaded.placeholder, @loaded.placeholder.class]
+#=> ["null", String]
+
+## Numeric string "123" preserves String type
+@model = JsonTestModel.new(model_id: @test_id, badge_number: "123")
+@model.save
+@loaded = JsonTestModel.find(@test_id)
+[@loaded.badge_number, @loaded.badge_number.class]
+#=> ["123", String]
+
+## Zero values preserved with correct types
+@model = JsonTestModel.new(model_id: @test_id, age: 0, score: 0.0)
+@model.save
+@loaded = JsonTestModel.find(@test_id)
+[@loaded.age, @loaded.score]
+#=> [0, 0.0]
+
+## Zero Integer and Float have correct classes
+[@loaded.age.class, @loaded.score.class]
+#=> [Integer, Float]
+
+# Teardown: Clean up test data
+JsonTestModel.destroy!(@test_id) if JsonTestModel.exists?(@test_id)

data/try/{horreum → unit/horreum}/relations_try.rb

@@ -1,7 +1,7 @@
 # try/horreum/relations_try.rb
 # Test Horreum Database type relations functionality
 
-require_relative '../helpers/test_helpers'
+require_relative '../../support/helpers/test_helpers'
 
 Familia.debug = false
 
@@ -92,15 +92,15 @@ prefs = @test_user.preferences
 @test_user.preferences.size
 #=> 2
 
-## Clearing a counter returns false when not set yet
+## Clearing a counter returns 0 when not set yet
 @test_product.views.clear
 @test_product.views.clear
-#=> false
+#=> 0
 
-## Clearing a counter returns true when it is set
+## Clearing a counter returns 1 when it is set
 @test_product.views.increment
 @test_product.views.clear
-#=> true
+#=> 1
 
 ## Counter Database type works
 @test_product.views.increment

data/try/{horreum → unit/horreum}/serialization_persistent_fields_try.rb

@@ -1,36 +1,42 @@
 # try/horreum/serialization_persistent_fields_try.rb
 
-require_relative '../helpers/test_helpers'
+require_relative '../../support/helpers/test_helpers'
 
 Familia.debug = false
 
-# Test class with mixed field categories for serialization
+# Test class with mixed field types for serialization
 class SerializationCategoryTest < Familia::Horreum
+  feature :transient_fields
+
   identifier_field :id
   field :id
   field :name                           # persistent by default
-  field :email, category: :encrypted    # persistent, encrypted category
-  field :tryouts_cache_data, category: :transient # should be excluded from serialization
-  field :description, category: :persistent # explicitly persistent
-  field :temp_settings, category: :transient # should be excluded
-  field :metadata, category: :persistent # explicitly persistent
+  field :email                          # persistent field
+  transient_field :tryouts_cache_data   # should be excluded from serialization
+  field :description                    # explicitly persistent
+  transient_field :temp_settings        # should be excluded
+  field :metadata                       # explicitly persistent
 end
 
 # Class with all transient fields
 class AllTransientSerializationTest < Familia::Horreum
+  feature :transient_fields
+
   identifier_field :id
   field :id
-  field :temp1, category: :transient
-  field :temp2, category: :transient
+  transient_field :temp1
+  transient_field :temp2
 end
 
-# Mixed categories with aliased fields
+# Mixed field types with aliased fields
 class AliasedSerializationTest < Familia::Horreum
+  feature :transient_fields
+
   identifier_field :id
   field :id
-  field :internal_name, as: :display_name, category: :persistent
-  field :temp_cache, as: :cache, category: :transient
-  field :user_data, as: :data, category: :encrypted
+  field :internal_name, as: :display_name
+  transient_field :temp_cache, as: :cache
+  field :user_data, as: :data
 end
 
 # Setup test instance with all field types
@@ -66,7 +72,7 @@ end
 @hash_result.key?("name")
 #=> true
 
-## to_h includes encrypted persistent fields
+## to_h includes regular persistent fields
 @hash_result.key?("email")
 #=> true
 
@@ -82,9 +88,9 @@ end
 @hash_result.key?(:temp_settings)
 #=> false
 
-## to_h serializes complex values correctly
-@hash_result["metadata"]
-#=:> String
+## to_h returns actual Ruby values (Hash, not serialized JSON string)
+@hash_result["metadata"].class
+#=> Hash
 
 ## to_a excludes transient fields
 @array_result = @serialization_test.to_a
@@ -133,7 +139,7 @@ SerializationCategoryTest.persistent_fields.include?(:email)
 @all_transient.to_a
 #=> ["transient_test_1"]
 
-## Aliased fields serialization uses original field names
+## Aliased fields serialization uses original field names (transient excluded)
 @aliased_hash = @aliased_test.to_h
 @aliased_hash.keys.sort
 #=> ["id", "internal_name", "user_data"]

data/try/{horreum → unit/horreum}/serialization_try.rb

@@ -1,6 +1,6 @@
 # try/horreum/serialization_try.rb
 
-require_relative '../helpers/test_helpers'
+require_relative '../../support/helpers/test_helpers'
 
 Familia.debug = false
 
@@ -20,10 +20,10 @@ Familia.dbclient.set('debug:starting_save_if_not_exists_tests', Familia.now.to_s
 @new_customer.save_if_not_exists
 #=> true
 
-## save_if_not_exists raises error when customer already exists
+## save_if_not_exists! raises error when customer already exists
 @duplicate_customer = Customer.new "new-customer-#{@test_id}@test.com"
 @duplicate_customer.name = 'Duplicate Customer'
-@duplicate_customer.save_if_not_exists
+@duplicate_customer.save_if_not_exists!
 #=!> Familia::RecordExistsError
 #==> error.message.include?("Key already exists")
 
@@ -103,9 +103,9 @@ Familia.dbclient.set('debug:ending_save_if_not_exists_tests', Familia.now.to_s)
 [@customer.name, @customer.email]
 #=> ["Bob Jones", "jane@example.com"]
 
-## serialize_value handles strings
+## serialize_value handles strings with JSON encoding
 @customer.serialize_value('test string')
-#=> "test string"
+#=> "\"test string\""
 
 ## serialize_value handles numbers
 @customer.serialize_value(42)
@@ -121,7 +121,7 @@ Familia.dbclient.set('debug:ending_save_if_not_exists_tests', Familia.now.to_s)
 
 ## deserialize_value handles JSON strings back to objects
 @customer.deserialize_value('{"key":"value","num":123}')
-#=> {:key=>"value", :num=>123}
+#=> {"key"=>"value", "num"=>123}
 
 ## deserialize_value handles JSON arrays
 @customer.deserialize_value('[1,2,"three"]')

data/try/{horreum → unit/horreum}/settings_try.rb

@@ -2,7 +2,7 @@
 
 # Test Horreum settings
 
-require_relative '../helpers/test_helpers'
+require_relative '../../support/helpers/test_helpers'
 
 ## database selection inheritance
 user_class = Class.new(Familia::Horreum) do