familia 2.0.0.pre17 → 2.0.0.pre19

data/try/{data_types → unit/data_types}/unsortedset_try.rb

@@ -1,6 +1,6 @@
 # try/data_types/unsortedset_try.rb
 
-require_relative '../helpers/test_helpers'
+require_relative '../../support/helpers/test_helpers'
 
 @a = Bone.new 'atoken'
 

data/try/{horreum → unit/horreum}/auto_indexing_on_save_try.rb

@@ -5,7 +5,7 @@
 # Tests automatic index population when Familia::Horreum objects are saved
 #
 
-require_relative '../helpers/test_helpers'
+require_relative '../../support/helpers/test_helpers'
 
 # Test classes for auto-indexing functionality
 class ::AutoIndexUser < Familia::Horreum
@@ -43,6 +43,19 @@ class ::AutoIndexEmployee < Familia::Horreum
   multi_index :department, :dept_index, within: AutoIndexCompany
 end
 
+class ::AutoIndexWithTransient < Familia::Horreum
+  feature :transient_fields
+  feature :relationships
+
+  identifier_field :id
+  field :id
+  field :email
+  transient_field :temp_value
+
+  unique_index :email, :email_index
+end
+
+
 # Setup
 @user_id = "user_#{rand(1000000)}"
 @user = AutoIndexUser.new(user_id: @user_id, email: 'test@example.com', username: 'testuser', department: 'engineering')
@@ -125,9 +138,9 @@ AutoIndexUser.email_index.has_key?('')
 AutoIndexUser.email_index.has_key?('')
 #=> true
 
-## Auto-indexing works with create method
+## Auto-indexing works with create! method
 @user2_id = "user_#{rand(1000000)}"
-@user2 = AutoIndexUser.create(user_id: @user2_id, email: 'create@example.com', username: 'createuser', department: 'marketing')
+@user2 = AutoIndexUser.create!(user_id: @user2_id, email: 'create@example.com', username: 'createuser', department: 'marketing')
 AutoIndexUser.find_by_email('create@example.com')&.user_id
 #=> @user2_id
 
@@ -152,22 +165,11 @@ old_email = @user2.email
 # =============================================
 
 ## Auto-indexing works with transient fields
-class ::AutoIndexWithTransient < Familia::Horreum
-  feature :transient_fields
-  feature :relationships
-
-  identifier_field :id
-  field :id
-  field :email
-  transient_field :temp_value
-
-  unique_index :email, :email_index
-end
-
 @transient_id = "trans_#{rand(1000000)}"
-@transient_obj = AutoIndexWithTransient.new(id: @transient_id, email: 'transient@example.com', temp_value: 'ignored')
+@transient_obj = AutoIndexWithTransient.new(id: @transient_id, email: "transient_#{rand(1000000)}@example.com", temp_value: 'ignored')
 @transient_obj.save
-AutoIndexWithTransient.find_by_email('transient@example.com')&.id
+@transient_email = @transient_obj.email
+AutoIndexWithTransient.find_by_email(@transient_email)&.id
 #=> @transient_id
 
 ## Auto-indexing works regardless of other features
@@ -175,6 +177,20 @@ AutoIndexWithTransient.find_by_email('transient@example.com')&.id
 @transient_obj.class.respond_to?(:indexing_relationships)
 #=> true
 
+## Guard validation prevents duplicate transient field email
+@transient_dup = AutoIndexWithTransient.new(id: "trans_dup_#{rand(1000000)}", email: @transient_email, temp_value: 'duplicate')
+begin
+  @transient_dup.save
+rescue Familia::RecordExistsError => ex
+  Familia.ld ex.backtrace.join("\n")
+  ex.message
+end
+#=:> String
+#=~> /Key already exists/
+#=~> /AutoIndexWithTransient exists /
+#=~> /email=#{@transient_email}/
+#=/=> @transient_email.nil?
+
 # =============================================
 # 5. Performance and Behavior Verification
 # =============================================

data/try/unit/horreum/automatic_index_validation_try.rb

@@ -0,0 +1,253 @@
+# try/unit/horreum/automatic_index_validation_try.rb
+
+#
+# Automatic index validation tests
+# Tests that unique index validation happens automatically when adding to indexes
+#
+
+require_relative '../../support/helpers/test_helpers'
+
+# Test classes for automatic validation
+class ::AutoValidCompany < Familia::Horreum
+  feature :relationships
+
+  identifier_field :company_id
+  field :company_id
+  field :name
+end
+
+class ::AutoValidEmployee < Familia::Horreum
+  feature :relationships
+
+  identifier_field :emp_id
+  field :emp_id
+  field :badge_number
+  field :email
+
+  # Instance-scoped unique index (should auto-validate in add_to_* methods)
+  unique_index :badge_number, :badge_index, within: AutoValidCompany
+
+  # Class-level unique index (auto-validates in save)
+  unique_index :email, :email_index
+end
+
+class ::AutoValidUser < Familia::Horreum
+  feature :relationships
+
+  identifier_field :user_id
+  field :user_id
+  field :email
+
+  unique_index :email, :email_index
+end
+
+# Setup
+@company_id = "comp_#{rand(1000000)}"
+@company = AutoValidCompany.new(company_id: @company_id, name: 'Test Corp')
+@company.save
+
+@emp1_id = "emp_#{rand(1000000)}"
+@emp2_id = "emp_#{rand(1000000)}"
+
+# =============================================
+# 1. Automatic Validation in add_to_* Methods
+# =============================================
+
+## First employee can add badge to company index
+@emp1 = AutoValidEmployee.new(emp_id: @emp1_id, badge_number: 'BADGE123', email: 'emp1@example.com')
+@emp1.save  # Save first to establish class-level email index
+@emp1.add_to_auto_valid_company_badge_index(@company)
+@company.badge_index.has_key?('BADGE123')
+#=> true
+
+## Duplicate badge is automatically rejected without manual guard call
+@emp2 = AutoValidEmployee.new(emp_id: @emp2_id, badge_number: 'BADGE123', email: 'emp2@example.com')
+begin
+  @emp2.add_to_auto_valid_company_badge_index(@company)
+  false
+rescue Familia::RecordExistsError => e
+  e.message.include?('AutoValidEmployee exists in AutoValidCompany with badge_number=BADGE123')
+end
+#=> true
+
+## Badge was not added after validation failure
+@company.badge_index.get('BADGE123')
+#=> @emp1_id
+
+## Different badge number works fine
+@emp2.badge_number = 'BADGE456'
+@emp2.add_to_auto_valid_company_badge_index(@company)
+@company.badge_index.has_key?('BADGE456')
+#=> true
+
+## Same employee can re-add (idempotent)
+@emp1.add_to_auto_valid_company_badge_index(@company)
+@company.badge_index.get('BADGE123')
+#=> @emp1_id
+
+## Different company allows same badge (scoped uniqueness)
+@company2_id = "comp_#{rand(1000000)}"
+@company2 = AutoValidCompany.new(company_id: @company2_id, name: 'Other Corp')
+@company2.save
+@emp3_id = "emp_#{rand(1000000)}"
+@emp3 = AutoValidEmployee.new(emp_id: @emp3_id, badge_number: 'BADGE123', email: 'emp3@example.com')
+@emp3.add_to_auto_valid_company_badge_index(@company2)
+@company2.badge_index.has_key?('BADGE123')
+#=> true
+
+## Nil badge_number handled gracefully (no validation or addition)
+@emp_nil = AutoValidEmployee.new(emp_id: "emp_nil_#{rand(1000000)}", badge_number: nil, email: 'empnil@example.com')
+@emp_nil.add_to_auto_valid_company_badge_index(@company)
+#=> nil
+
+## Nil parent handled gracefully (no validation or addition)
+@emp4 = AutoValidEmployee.new(emp_id: "emp4_#{rand(1000000)}", badge_number: 'BADGE789', email: 'emp4@example.com')
+@emp4.add_to_auto_valid_company_badge_index(nil)
+#=> nil
+
+# =============================================
+# 2. Transaction Detection in save()
+# =============================================
+
+## Normal save works outside transaction
+@user1_id = "user_#{rand(1000000)}"
+@user1 = AutoValidUser.new(user_id: @user1_id, email: 'user1@example.com')
+@user1.save
+#=> true
+
+## save() raises error when called within transaction
+@user2_id = "user_#{rand(1000000)}"
+begin
+  AutoValidUser.transaction do
+    @user2 = AutoValidUser.new(user_id: @user2_id, email: 'user2@example.com')
+    @user2.save
+  end
+  false
+rescue Familia::OperationModeError => e
+  e.message.include?('Cannot call save within a transaction')
+end
+#=> true
+
+## Object was not saved due to transaction error
+AutoValidUser.find_by_email('user2@example.com')
+#=> nil
+
+## Transaction with explicit field updates works (bypass save)
+@user3_id = "user_#{rand(1000000)}"
+@user3 = AutoValidUser.new(user_id: @user3_id, email: 'user3@example.com')
+AutoValidUser.transaction do |_tx|
+  @user3.hmset(@user3.to_h_for_storage)
+end
+@user3.exists?
+#=> true
+
+## save() works after transaction completes
+@user4_id = "user_#{rand(1000000)}"
+AutoValidUser.transaction do
+  # Do something else in transaction
+end
+@user4 = AutoValidUser.new(user_id: @user4_id, email: 'user4@example.com')
+@user4.save
+#=> true
+
+# =============================================
+# 3. Combined Automatic Validation Scenarios
+# =============================================
+
+## Employee with duplicate class-level email caught in save
+@emp5_id = "emp_#{rand(1000000)}"
+@emp5 = AutoValidEmployee.new(emp_id: @emp5_id, badge_number: 'BADGE999', email: 'emp1@example.com')
+begin
+  @emp5.save
+  false
+rescue Familia::RecordExistsError => e
+  e.message.include?('AutoValidEmployee exists email=emp1@example.com')
+end
+#=> true
+
+## Employee can save with unique email
+@emp1.save
+AutoValidEmployee.find_by_email('emp1@example.com')&.emp_id
+#=> @emp1_id
+
+## After save, duplicate instance-scoped index still caught automatically
+@emp6_id = "emp_#{rand(1000000)}"
+@emp6 = AutoValidEmployee.new(emp_id: @emp6_id, badge_number: 'BADGE123', email: 'emp6@example.com')
+@emp6.save  # Class-level index is fine
+begin
+  @emp6.add_to_auto_valid_company_badge_index(@company)  # Instance-scoped duplicate
+  false
+rescue Familia::RecordExistsError => e
+  e.message.include?('badge_number=BADGE123')
+end
+#=> true
+
+# =============================================
+# 4. Error Message Quality
+# =============================================
+
+## Instance-scoped validation error includes both class names
+begin
+  @emp2.badge_number = 'BADGE123'  # Reset to duplicate
+  @emp2.add_to_auto_valid_company_badge_index(@company)
+rescue Familia::RecordExistsError => e
+  [e.message.include?('AutoValidEmployee'), e.message.include?('AutoValidCompany')]
+end
+#=> [true, true]
+
+## Instance-scoped validation error includes field name and value
+begin
+  @emp2.add_to_auto_valid_company_badge_index(@company)
+rescue Familia::RecordExistsError => e
+  [e.message.include?('badge_number'), e.message.include?('BADGE123')]
+end
+#=> [true, true]
+
+## Error type is RecordExistsError
+begin
+  @emp2.add_to_auto_valid_company_badge_index(@company)
+rescue => e
+  e.class
+end
+#=> Familia::RecordExistsError
+
+# =============================================
+# 5. Performance - No Double Validation
+# =============================================
+
+## Manual guard call before add_to_* is redundant but harmless
+@emp7_id = "emp_#{rand(1000000)}"
+@emp7 = AutoValidEmployee.new(emp_id: @emp7_id, badge_number: 'BADGE777', email: 'emp7@example.com')
+@emp7.guard_unique_auto_valid_company_badge_index!(@company)
+@emp7.add_to_auto_valid_company_badge_index(@company)
+@company.badge_index.has_key?('BADGE777')
+#=> true
+
+## Manual guard call detects duplicate
+@emp8_id = "emp_#{rand(1000000)}"
+@emp8 = AutoValidEmployee.new(emp_id: @emp8_id, badge_number: 'BADGE777', email: 'emp8@example.com')
+begin
+  @emp8.guard_unique_auto_valid_company_badge_index!(@company)  # Should fail - duplicate badge
+  false
+rescue Familia::RecordExistsError
+  true
+end
+#=> true
+
+# Teardown - clean up test objects
+[@emp1, @emp2, @emp3, @emp_nil, @emp4, @emp5, @emp6, @emp7, @emp8].compact.each do |obj|
+  obj.destroy! if obj.respond_to?(:destroy!) && obj.respond_to?(:exists?) && obj.exists?
+end
+
+[@user1, @user3, @user4].compact.each do |obj|
+  obj.destroy! if obj.respond_to?(:destroy!) && obj.respond_to?(:exists?) && obj.exists?
+end
+
+[@company, @company2].each do |obj|
+  obj.destroy! if obj.respond_to?(:destroy!) && obj.respond_to?(:exists?) && obj.exists?
+end
+
+# Clean up class-level indexes
+[AutoValidEmployee.email_index, AutoValidUser.email_index].each do |index|
+  index.delete! if index.respond_to?(:delete!) && index.respond_to?(:exists?) && index.exists?
+end

data/try/{horreum → unit/horreum}/base_try.rb

@@ -1,6 +1,6 @@
 # try/horreum/base_try.rb
 
-require_relative '../helpers/test_helpers'
+require_relative '../../support/helpers/test_helpers'
 
 Familia.debug = false
 
@@ -41,7 +41,7 @@ Familia.debug = false
 
 ## Remove the key
 @hashkey.delete!
-#=> true
+#=> 1
 
 ## Horreum objects can update and save their fields (1 of 2)
 @customer.name = 'John Doe'
@@ -203,11 +203,11 @@ end
 @aliased.display_size! 100
 #=> true
 
-## Aliased field refresh works correctly
+## Aliased field refresh works correctly (type preserved)
 @aliased.width = 50  # unsaved change
 @aliased.refresh!
 @aliased.width
-#=> "100"
+#=> 100
 
 ## Fast method with custom name
 class CustomFastMethodTest < Familia::Horreum

data/try/{horreum → unit/horreum}/class_methods_try.rb

@@ -2,7 +2,7 @@
 
 # Test Horreum class methods
 
-require_relative '../helpers/test_helpers'
+require_relative '../../support/helpers/test_helpers'
 
 TestUser = Class.new(Familia::Horreum) do
   identifier_field :email
@@ -16,9 +16,9 @@ module AnotherModuleName
   end
 end
 
-## create factory method with existence checking
+## create! factory method with existence checking
 TestUser
-#==> _.respond_to?(:create)
+#==> _.respond_to?(:create!)
 #==> _.respond_to?(:exists?)
 
 ## multiget method is available

data/try/{horreum → unit/horreum}/commands_try.rb

@@ -2,7 +2,7 @@
 
 # Test Horreum Valkey/Redis commands
 
-require_relative '../helpers/test_helpers'
+require_relative '../../support/helpers/test_helpers'
 
 ## hget/hset operations
 begin

data/try/{horreum → unit/horreum}/defensive_initialization_try.rb

@@ -1,6 +1,6 @@
 # try/horreum/defensive_initialization_try.rb
 
-require_relative '../helpers/test_helpers'
+require_relative '../../support/helpers/test_helpers'
 
 # Test defensive initialization behavior
 class User < Familia::Horreum

data/try/{horreum → unit/horreum}/destroy_related_fields_cleanup_try.rb

@@ -9,7 +9,7 @@
 # This addresses the bug where destroy! only deleted the main object key
 # but left related field keys in the database.
 
-require_relative '../helpers/test_helpers'
+require_relative '../../support/helpers/test_helpers'
 
 MANY_FIELD_MULTIPLIER = 10
 

data/try/{horreum → unit/horreum}/enhanced_conflict_handling_try.rb

@@ -1,6 +1,6 @@
 # try/horreum/enhanced_conflict_handling_try.rb
 
-require_relative '../helpers/test_helpers'
+require_relative '../../support/helpers/test_helpers'
 
 Familia.debug = false
 

data/try/{horreum → unit/horreum}/field_categories_try.rb

@@ -1,44 +1,53 @@
 # try/horreum/field_categories_try.rb
 
-require_relative '../helpers/test_helpers'
+require_relative '../../support/helpers/test_helpers'
 
 Familia.debug = false
 
-# Define test class with various field categories
+# Define test class with various field types
 class FieldCategoryTest < Familia::Horreum
+  feature :encrypted_fields
+  feature :transient_fields
+
   identifier_field :id
   field :id
-  field :name                           # default category (:field)
-  field :email, category: :encrypted    # encrypted category
-  field :tryouts_cache_data, category: :transient # transient category
-  field :description, category: :persistent # explicit persistent category
-  field :settings, category: nil        # nil category (defaults to :field)
+  field :name                           # regular field
+  encrypted_field :email                # encrypted field
+  transient_field :tryouts_cache_data   # transient field
+  field :description                    # regular persistent field
+  field :settings                       # regular field
 end
 
 # Test class with multiple transient fields
 class MultiTransientTest < Familia::Horreum
+  feature :transient_fields
+
   identifier_field :id
   field :id
   field :permanent_data
-  field :temp1, category: :transient
-  field :temp2, category: :transient
-  field :temp3, category: :transient
+  transient_field :temp1
+  transient_field :temp2
+  transient_field :temp3
 end
 
-# Field categories work with field aliasing
+# Field types work with field aliasing
 class AliasedCategoryTest < Familia::Horreum
+  feature :transient_fields
+
   identifier_field :id
   field :id
-  field :internal_temp, as: :temp, category: :transient
-  field :internal_perm, as: :perm, category: :persistent
+  transient_field :internal_temp, as: :temp
+  field :internal_perm, as: :perm
 end
 
 # Test edge case with all transient fields
 class AllTransientTest < Familia::Horreum
+  feature :transient_fields
+
   identifier_field :id
   field :id
-  field :temp1, category: :transient
-  field :temp2, category: :transient
+  transient_field :temp1
+  transient_field :temp2
 end
 
 ## Field types are stored correctly
@@ -58,11 +67,11 @@ FieldCategoryTest.field_types[:email].category
 FieldCategoryTest.field_types[:tryouts_cache_data].category
 #=> :transient
 
-## Explicit persistent category field has correct category
+## Regular fields have :field category
 FieldCategoryTest.field_types[:description].category
-#=> :persistent
+#=> :field
 
-## Nil category field defaults to :field
+## Regular fields default to :field category
 FieldCategoryTest.field_types[:settings].category
 #=> :field
 

data/try/{horreum → unit/horreum}/field_definition_try.rb

@@ -1,6 +1,6 @@
 # try/horreum/field_definition_try.rb
 
-require_relative '../helpers/test_helpers'
+require_relative '../../support/helpers/test_helpers'
 
 Familia.debug = false
 

data/try/{horreum → unit/horreum}/initialization_try.rb

@@ -1,6 +1,6 @@
 # try/horreum/initialization_try.rb
 
-require_relative '../helpers/test_helpers'
+require_relative '../../support/helpers/test_helpers'
 
 Familia.debug = false
 
@@ -97,11 +97,11 @@ Familia.debug = false
 @complex.save
 @complex.refresh!
 [@complex.custid, @complex.name, @complex.role, @complex.verified]
-#=> ["complex@test.com", "Complex User", "admin", "true"]
+#=> ["complex@test.com", "Complex User", "admin", true]
 
 ## Clean up saved test objects
 [@customer6, @complex].map(&:delete!)
-#=> [true, true]
+#=> [1, 1]
 
 ## "Cleaning up" test objects that were never saved returns true regardless
 ## b/c it takes place in a transaction and it's the transaction's success