facter 2.0.2 → 2.1.0

data/spec/unit/util/macosx_spec.rb

@@ -1,9 +1,10 @@
 #! /usr/bin/env ruby
 
 require 'spec_helper'
-require 'facter/util/macosx'
+require 'facter/util/config'
+require 'facter/util/macosx' unless Facter::Util::Config.is_windows?
 
-describe Facter::Util::Macosx do
+describe "Facter::Util::Macosx", :unless => Facter::Util::Config.is_windows? do
   let(:badplist) do
     '<?xml version="1.0" encoding="UTF-8"?>
     <!DOCTYPE plist PUBLIC -//Apple Computer//DTD PLIST 1.0//EN http://www.apple.com/DTDs/PropertyList-1.0.dtd>

data/spec/unit/util/manufacturer_spec.rb

@@ -63,6 +63,17 @@ describe Facter::Manufacturer do
     Facter.value(:reldate).should == "12/01/2006"
   end
 
+  it "can parse smbios output that contains non-UTF8 characters" do
+    smbios_output = my_fixture_read("smartos_smbios")
+    Facter::Core::Execution.stubs(:exec).with('/usr/sbin/smbios 2>/dev/null').returns(smbios_output)
+    Facter.fact(:kernel).stubs(:value).returns("SunOS")
+
+    query = { 'BIOS information' => [ { 'Release Date:' => 'reldate' } ] }
+
+    Facter::Manufacturer.dmi_find_system_info(query)
+    Facter.value(:reldate).should == "06/11/2007"
+  end
+
   it "should not split on dmi keys containing the string Handle" do
     dmidecode_output = <<-eos
 Handle 0x1000, DMI type 16, 15 bytes
@@ -176,4 +187,37 @@ Handle 0x001F
     Facter.value(:serialnumber).should == "56 4d 40 2b 4d 81 94 d6-e6 c5 56 a4 56 0c 9e 9f"
     Facter.value(:productname).should == "VMware Virtual Platform"
   end
+
+  describe "using sysctl to look up manufacturer information" do
+    before do
+      Facter.fact(:kernel).stubs(:value).returns 'OpenBSD'
+    end
+
+    let(:mfg_keys) do
+      {
+        'hw.vendor'   => 'manufacturer',
+        'hw.product'  => 'productname',
+        'hw.serialno' => 'serialnumber'
+      }
+    end
+
+    it "creates a new fact for the each hash key" do
+      mfg_keys.values.each do |value|
+        Facter.expects(:add).with(value)
+      end
+      described_class.sysctl_find_system_info(mfg_keys)
+    end
+
+    it "uses sysctl to determine the value for that fact" do
+      mfg_keys.keys.each do |sysctl|
+        Facter::Util::POSIX.expects(:sysctl).with(sysctl).returns "sysctl #{sysctl}"
+      end
+
+      described_class.sysctl_find_system_info(mfg_keys)
+
+      mfg_keys.invert.each_pair do |factname, value|
+        expect(Facter.value(factname)).to eq "sysctl #{value}"
+      end
+    end
+  end
 end

data/spec/unit/util/operatingsystem_spec.rb

@@ -0,0 +1,92 @@
+require 'spec_helper'
+require 'facter/util/operatingsystem'
+
+describe Facter::Util::Operatingsystem do
+  describe "reading the os-release file" do
+
+    it "correctly parses the file on Cumulus Linux"  do
+      values = described_class.os_release(my_fixture('cumuluslinux.txt'))
+
+      expect(values).to eq({
+        'NAME' => "Cumulus Linux",
+        'VERSION_ID' => "1.5.2",
+        'VERSION' => "1.5.2-28283a7-201311181623-final",
+        'PRETTY_NAME' => "Cumulus Linux",
+        'ID' => "cumulus-linux",
+        'ID_LIKE' => "debian",
+        'CPE_NAME' => "cpe:/o:cumulusnetworks:cumulus_linux:1.5.2-28283a7-201311181623-final",
+        'HOME_URL' => "http://www.cumulusnetworks.com/",
+      })
+    end
+
+    it "correctly parses the file on Sabayon" do
+      values = described_class.os_release(my_fixture('sabayon.txt'))
+
+      expect(values).to eq({
+        "NAME" => "Sabayon",
+        "ID" => "sabayon",
+        "PRETTY_NAME" => "Sabayon/Linux",
+        "ANSI_COLOR" => "1;32",
+        "HOME_URL" => "http://www.sabayon.org/",
+        "SUPPORT_URL" => "http://forum.sabayon.org/",
+        "BUG_REPORT_URL" => "https://bugs.sabayon.org/",
+      })
+    end
+
+    it "correctly parses the file on Debian Wheezy" do
+      values = described_class.os_release(my_fixture('wheezy.txt'))
+
+      expect(values).to eq({
+        "PRETTY_NAME" => "Debian GNU/Linux 7 (wheezy)",
+        "NAME" => "Debian GNU/Linux",
+        "VERSION_ID" => "7",
+        "VERSION" => "7 (wheezy)",
+        "ID" => "debian",
+        "ANSI_COLOR" => "1;31",
+        "HOME_URL" => "http://www.debian.org/",
+        "SUPPORT_URL" => "http://www.debian.org/support/",
+        "BUG_REPORT_URL" => "http://bugs.debian.org/",
+      })
+    end
+
+    it "correctly parses the file on Debian Wheezy" do
+      values = described_class.os_release(my_fixture('wheezy.txt'))
+
+      expect(values).to eq({
+        "PRETTY_NAME" => "Debian GNU/Linux 7 (wheezy)",
+        "NAME" => "Debian GNU/Linux",
+        "VERSION_ID" => "7",
+        "VERSION" => "7 (wheezy)",
+        "ID" => "debian",
+        "ANSI_COLOR" => "1;31",
+        "HOME_URL" => "http://www.debian.org/",
+        "SUPPORT_URL" => "http://www.debian.org/support/",
+        "BUG_REPORT_URL" => "http://bugs.debian.org/",
+      })
+    end
+
+
+    it "correctly parses the file on RedHat 7" do
+      values = described_class.os_release(my_fixture('redhat-7.txt'))
+      expect(values).to eq({
+        "NAME" => "Red Hat Enterprise Linux Everything",
+        "VERSION" => "7.0 (Maipo)",
+        "ID" => "rhel",
+        "VERSION_ID" => "7.0",
+        "PRETTY_NAME" => "Red Hat Enterprise Linux Everything 7.0 (Maipo)",
+        "ANSI_COLOR" => "0;31",
+        "CPE_NAME" => "cpe:/o:redhat:enterprise_linux:7.0:beta:everything",
+        "REDHAT_BUGZILLA_PRODUCT" => "Red Hat Enterprise Linux 7",
+        "REDHAT_BUGZILLA_PRODUCT_VERSION" => "7.0",
+        "REDHAT_SUPPORT_PRODUCT" => "Red Hat Enterprise Linux",
+        "REDHAT_SUPPORT_PRODUCT_VERSION" => "7.0",
+      })
+    end
+
+    it "does not try to read an unreadable '/etc/os-release' file" do
+      File.expects(:readable?).with('/some/nonexistent/file').returns false
+
+      expect(described_class.os_release('/some/nonexistent/file')).to be_empty
+    end
+  end
+end

data/spec/unit/util/partitions/partitions_spec.rb

@@ -0,0 +1,67 @@
+require 'spec_helper'
+require 'facter'
+require 'facter/util/partitions/linux'
+
+describe 'Facter::Util::Partitions::Linux' do
+  describe 'on Linux OS' do
+    before :each do
+      Facter.fact(:kernel).stubs(:value).returns("Linux")
+
+      File.stubs(:exist?).with('/sys/block/').returns(true)
+      File.stubs(:exist?).with("/sys/block/./device").returns(false)
+      File.stubs(:exist?).with("/sys/block/../device").returns(false)
+      File.stubs(:exist?).with('/dev/disk/by-uuid/').returns(true)
+
+      devices = [".", "..", "sda", "sdb", "sdc"]
+      Dir.stubs(:entries).with('/sys/block/').returns(devices)
+      
+      Facter::Core::Execution.stubs(:which).with('mount').returns(true)
+      Facter::Core::Execution.stubs(:which).with('blkid').returns(true)
+
+      test_parts = {
+        'sda1' => '13459663-22cc-47b4-a9e6-21dea9906e03',  
+        'sdb2' => '98043570-eb10-457f-9718-0b85a26e66bf',  
+        'sdc3' => 'a35fb506-e831-4752-9899-dff6c601214b',
+      }
+      
+      Dir.stubs(:entries).with('/dev/disk/by-uuid/').returns(test_parts.values)
+      test_parts.each do |part,uuid|
+        device = part.match(/(\D+)/)[1]
+        File.stubs(:exist?).with("/sys/block/#{device}/device").returns(true)
+        File.stubs(:symlink?).with("/dev/disk/by-uuid/#{uuid}").returns(true)
+        File.stubs(:readlink).with("/dev/disk/by-uuid/#{uuid}").returns("/dev/#{part}")
+        Dir.stubs(:glob).with("/sys/block/#{device}/#{device}*").returns(["/sys/block/#{device}/#{part}"])
+        Facter::Util::Partitions::Linux.stubs(:read_size).returns('12345')
+        Facter::Core::Execution.stubs(:exec).with("blkid /dev/#{part}").returns("/dev/#{part}: UUID=\"#{uuid}\" TYPE=\"ext4\"")
+      end
+
+      Facter::Core::Execution.stubs(:exec).with('mount').returns(my_fixture_read("mount"))
+    end
+
+    it '.list should return a list of partitions' do
+      Facter::Util::Partitions::Linux.list.should == ['sda1', 'sdb2', 'sdc3']
+    end
+
+    it '.uuid should return a string containing the uuid' do
+      Facter::Util::Partitions::Linux.uuid('sda1').should == '13459663-22cc-47b4-a9e6-21dea9906e03'
+      Facter::Util::Partitions::Linux.uuid('sdb2').should == '98043570-eb10-457f-9718-0b85a26e66bf'
+      Facter::Util::Partitions::Linux.uuid('sdc3').should == 'a35fb506-e831-4752-9899-dff6c601214b'
+    end
+
+    it '.size should return a string containing the size' do
+      Facter::Util::Partitions::Linux.size('sda1').should == '12345'
+    end
+
+    it '.mount should return a string containing the mount point of the partition' do
+      Facter::Util::Partitions::Linux.mount('sda1').should == '/home'
+      Facter::Util::Partitions::Linux.mount('sdb2').should == '/'
+      Facter::Util::Partitions::Linux.mount('sdc3').should == '/var'
+    end
+
+    it '.filesystem should return a string containing the filesystem on the partition' do
+      Facter::Util::Partitions::Linux.filesystem('sda1').should == 'ext4'
+      Facter::Util::Partitions::Linux.filesystem('sdb2').should == 'ext4'
+      Facter::Util::Partitions::Linux.filesystem('sdc3').should == 'ext4'
+    end
+  end
+end

data/spec/unit/util/partitions_spec.rb

@@ -0,0 +1,19 @@
+require 'spec_helper'
+require 'facter'
+require 'facter/util/partitions'
+
+describe 'Facter::Util::Partitions' do
+  describe 'on unsupported OSs' do
+    before :each do
+      Facter.fact(:kernel).stubs(:value).returns("SunOS")
+    end
+    
+    it 'list should return empty array' do
+      Facter::Util::Partitions.list.should == []
+    end
+
+    it 'available? should return false' do
+      Facter::Util::Partitions.available?.should == false
+    end
+  end
+end

data/spec/unit/util/posix_spec.rb

@@ -0,0 +1,11 @@
+require 'spec_helper'
+require 'facter/util/posix'
+
+describe Facter::Util::POSIX do
+  describe "retrieving values via sysctl" do
+    it "returns the result of the sysctl command" do
+      Facter::Util::Resolution.expects(:exec).with("sysctl -n hw.pagesize 2>/dev/null").returns("somevalue")
+      expect(described_class.sysctl("hw.pagesize")).to eq "somevalue"
+    end
+  end
+end

data/spec/unit/util/values_spec.rb

@@ -128,4 +128,44 @@ describe Facter::Util::Values do
       end
     end
   end
+
+  describe "flatten_structure" do
+    it "converts a string to a hash containing that string" do
+      input = "foo"
+      output = described_class.flatten_structure("path", input)
+      expect(output).to eq({"path" => "foo"})
+    end
+
+    it "converts an array to a hash with the array elements with indexes" do
+      input = ["foo"]
+      output = described_class.flatten_structure("path", input)
+      expect(output).to eq({"path_0" => "foo"})
+    end
+
+    it "prefixes a non-nested hash with the given path" do
+      input = {"foo" => "bar"}
+      output = described_class.flatten_structure("path", input)
+      expect(output).to eq({"path_foo" => "bar"})
+    end
+
+    it "flattens elements till it reaches the first non-flattenable structure" do
+      input = {
+        "first" => "second",
+        "arr" => ["zero", "one"],
+        "nested_array" => [
+          "hash" => "string",
+        ],
+        "top" => {"middle" => ['bottom']},
+      }
+      output = described_class.flatten_structure("path", input)
+
+      expect(output).to eq({
+        "path_first" => "second",
+        "path_arr_0" => "zero",
+        "path_arr_1" => "one",
+        "path_nested_array_0_hash" => "string",
+        "path_top_middle_0" => "bottom"
+      })
+    end
+  end
 end

data/spec/unit/util/virtual_spec.rb

@@ -127,6 +127,16 @@ describe Facter::Util::Virtual do
     Facter::Util::Virtual.should_not be_ovirt
   end
 
+  it "detects GCE if the DMI product name is Google" do
+    File.stubs(:read).with("/sys/devices/virtual/dmi/id/product_name").returns("Google")
+    expect(Facter::Util::Virtual.gce?).to be_true
+  end
+
+  it "does not detect GCE if the DMI product name is not Google" do
+    File.stubs(:read).with("/sys/devices/virtual/dmi/id/product_name").returns('')
+    expect(Facter::Util::Virtual.gce?).to be_false
+  end
+
   fixture_path = fixtures('virtual', 'proc_self_status')
 
   test_cases = [
@@ -202,14 +212,14 @@ describe Facter::Util::Virtual do
   it "should detect kvm on FreeBSD" do
     FileTest.stubs(:exists?).with("/proc/cpuinfo").returns(false)
     Facter.fact(:kernel).stubs(:value).returns("FreeBSD")
-    Facter::Core::Execution.stubs(:exec).with("/sbin/sysctl -n hw.model").returns("QEMU Virtual CPU version 0.12.4")
+    Facter::Util::POSIX.stubs(:sysctl).with("hw.model").returns("QEMU Virtual CPU version 0.12.4")
     Facter::Util::Virtual.should be_kvm
   end
 
   it "should detect kvm on OpenBSD" do
     FileTest.stubs(:exists?).with("/proc/cpuinfo").returns(false)
     Facter.fact(:kernel).stubs(:value).returns("OpenBSD")
-    Facter::Core::Execution.stubs(:exec).with("/sbin/sysctl -n hw.model").returns('QEMU Virtual CPU version (cpu64-rhel6) ("AuthenticAMD" 686-class, 512KB L2 cache)')
+    Facter::Util::POSIX.stubs(:sysctl).with("hw.model").returns('QEMU Virtual CPU version (cpu64-rhel6) ("AuthenticAMD" 686-class, 512KB L2 cache)')
     Facter::Util::Virtual.should be_kvm
   end
 
@@ -291,4 +301,64 @@ describe Facter::Util::Virtual do
   context "on windows" do
     it_should_behave_like "virt-what", "windows", 'c:\windows\system32\virt-what', "NUL"
   end
+
+  describe '.lxc?' do
+    subject do
+      Facter::Util::Virtual.lxc?
+    end
+
+    fixture_path = fixtures('virtual', 'proc_1_cgroup')
+
+    context '/proc/1/cgroup has at least one hierarchy rooted in /lxc/' do
+      before :each do
+        fakepath = Pathname.new(File.join(fixture_path, 'in_a_container'))
+        Pathname.stubs(:new).with('/proc/1/cgroup').returns(fakepath)
+      end
+
+      it 'is true' do
+        subject.should be_true
+      end
+    end
+
+    context '/proc/1/cgroup has no hierarchies rooted in /lxc/' do
+      before :each do
+        fakepath = Pathname.new(File.join(fixture_path, 'not_in_a_container'))
+        Pathname.stubs(:new).with('/proc/1/cgroup').returns(fakepath)
+      end
+
+      it 'is false' do
+        subject.should be_false
+      end
+    end
+  end
+
+  describe '.docker?' do
+    subject do
+      Facter::Util::Virtual.docker?
+    end
+
+    fixture_path = fixtures('virtual', 'proc_1_cgroup')
+
+    context '/proc/1/cgroup has at least one hierarchy rooted in /docker/' do
+      before :each do
+        fakepath = Pathname.new(File.join(fixture_path, 'in_a_docker_container'))
+        Pathname.stubs(:new).with('/proc/1/cgroup').returns(fakepath)
+      end
+
+      it 'is true' do
+        subject.should be_true
+      end
+    end
+
+    context '/proc/1/cgroup has no hierarchies rooted in /docker/' do
+      before :each do
+        fakepath = Pathname.new(File.join(fixture_path, 'not_in_a_container'))
+        Pathname.stubs(:new).with('/proc/1/cgroup').returns(fakepath)
+      end
+
+      it 'is false' do
+        subject.should be_false
+      end
+    end
+  end
 end

data/spec/unit/virtual_spec.rb

@@ -2,10 +2,12 @@
 
 require 'spec_helper'
 require 'facter/util/virtual'
-require 'facter/util/macosx'
+require 'facter/util/macosx' unless Facter::Util::Config.is_windows?
 
 describe "Virtual fact" do
   before(:each) do
+    Facter::Util::Virtual.stubs(:docker?).returns(false)
+    Facter::Util::Virtual.stubs(:lxc?).returns(false)
     Facter::Util::Virtual.stubs(:zone?).returns(false)
     Facter::Util::Virtual.stubs(:openvz?).returns(false)
     Facter::Util::Virtual.stubs(:vserver?).returns(false)
@@ -16,6 +18,7 @@ describe "Virtual fact" do
     Facter::Util::Virtual.stubs(:virt_what).returns(nil)
     Facter::Util::Virtual.stubs(:rhev?).returns(false)
     Facter::Util::Virtual.stubs(:ovirt?).returns(false)
+    Facter::Util::Virtual.stubs(:gce?).returns(false)
     Facter::Util::Virtual.stubs(:virtualbox?).returns(false)
   end
 
@@ -47,28 +50,23 @@ describe "Virtual fact" do
     Facter.fact(:virtual).value.should == "zlinux"
   end
 
-  describe "on Darwin" do
+  describe "on Darwin", :unless => Facter::Util::Config.is_windows? do
     before do
       Facter.fact(:kernel).stubs(:value).returns("Darwin")
     end
 
-    it "should be parallels with Parallels vendor id" do
-      Facter::Util::Macosx.stubs(:profiler_data).returns({ "spdisplays_vendor-id" => "0x1ab8" })
+    it "should be parallels with Parallels ethernet vendor id" do
+      Facter::Util::Macosx.stubs(:profiler_data).returns({ "spethernet_subsystem-vendor-id" => "0x1ab8" })
       Facter.fact(:virtual).value.should == "parallels"
     end
 
-    it "should be parallels with Parallels vendor name" do
-      Facter::Util::Macosx.stubs(:profiler_data).returns({ "spdisplays_vendor" => "Parallels" })
-      Facter.fact(:virtual).value.should == "parallels"
-    end
-
-    it "should be vmware with VMWare vendor id" do
-      Facter::Util::Macosx.stubs(:profiler_data).returns({ "spdisplays_vendor-id" => "0x15ad" })
-      Facter.fact(:virtual).value.should == "vmware"
+    it "should be virtualbox with VirtualBox boot rom name" do
+      Facter::Util::Macosx.stubs(:profiler_data).returns({ "boot_rom_version" => "VirtualBox" })
+      Facter.fact(:virtual).value.should == "virtualbox"
     end
 
-    it "should be vmware with VMWare vendor name" do
-      Facter::Util::Macosx.stubs(:profiler_data).returns({ "spdisplays_vendor" => "VMWare" })
+    it "should be vmware with VMware machine model" do
+      Facter::Util::Macosx.stubs(:profiler_data).returns({ "machine_model" => "VMware7,1" })
       Facter.fact(:virtual).value.should == "vmware"
     end
   end
@@ -164,6 +162,12 @@ describe "Virtual fact" do
       Facter.fact(:virtual).value.should == "ovirt"
     end
 
+    it "is gce based on DMI info" do
+      Facter.fact(:kernel).stubs(:value).returns("Linux")
+      Facter::Util::Virtual.stubs(:gce?).returns(true)
+      Facter.fact(:virtual).value.should == "gce"
+    end
+
     it "should be hyperv with Microsoft vendor name from lspci 2>/dev/null" do
       Facter::Core::Execution.stubs(:exec).with('lspci 2>/dev/null').returns("00:08.0 VGA compatible controller: Microsoft Corporation Hyper-V virtual VGA")
       Facter.fact(:virtual).value.should == "hyperv"
@@ -175,6 +179,28 @@ describe "Virtual fact" do
       Facter.fact(:virtual).value.should == "hyperv"
     end
 
+    context "In a Linux Container (LXC)" do
+      before :each do
+        Facter.fact(:kernel).stubs(:value).returns("Linux")
+      end
+
+      it 'is "lxc" when Facter::Util::Virtual.lxc? is true' do
+        Facter::Util::Virtual.stubs(:lxc?).returns(true)
+        Facter.fact(:virtual).value.should == 'lxc'
+      end
+    end
+
+    context "In a Docker Container (docker)" do
+      before :each do
+        Facter.fact(:kernel).stubs(:value).returns("Linux")
+      end
+
+      it 'is "docker" when Facter::Util::Virtual.docker? is true' do
+        Facter::Util::Virtual.stubs(:docker?).returns(true)
+        Facter.fact(:virtual).value.should == 'docker'
+      end
+    end
+
     context "In Google Compute Engine" do
       before :each do
         Facter.fact(:kernel).stubs(:value).returns("Linux")
@@ -254,24 +280,29 @@ describe "Virtual fact" do
     end
 
     it "should be parallels with Parallels product name from sysctl" do
-      Facter::Core::Execution.stubs(:exec).with('sysctl -n hw.product 2>/dev/null').returns("Parallels Virtual Platform")
+      Facter::Util::POSIX.stubs(:sysctl).with('hw.product').returns("Parallels Virtual Platform")
       Facter.fact(:virtual).value.should == "parallels"
     end
 
     it "should be vmware with VMware product name from sysctl" do
-      Facter::Core::Execution.stubs(:exec).with('sysctl -n hw.product 2>/dev/null').returns("VMware Virtual Platform")
+      Facter::Util::POSIX.stubs(:sysctl).with('hw.product').returns("VMware Virtual Platform")
       Facter.fact(:virtual).value.should == "vmware"
     end
 
     it "should be virtualbox with VirtualBox product name from sysctl" do
-      Facter::Core::Execution.stubs(:exec).with('sysctl -n hw.product 2>/dev/null').returns("VirtualBox")
+      Facter::Util::POSIX.stubs(:sysctl).with('hw.product').returns("VirtualBox")
       Facter.fact(:virtual).value.should == "virtualbox"
     end
 
     it "should be xenhvm with Xen HVM product name from sysctl" do
-      Facter::Core::Execution.stubs(:exec).with('sysctl -n hw.product 2>/dev/null').returns("HVM domU")
+      Facter::Util::POSIX.stubs(:sysctl).with('hw.product').returns("HVM domU")
       Facter.fact(:virtual).value.should == "xenhvm"
     end
+
+    it "should be ovirt with oVirt Node product name from sysctl" do
+      Facter::Util::POSIX.stubs(:sysctl).with('hw.product').returns("oVirt Node")
+      Facter.fact(:virtual).value.should == "ovirt"
+    end
   end
 
   describe "on Windows" do
@@ -467,4 +498,22 @@ describe "is_virtual fact" do
     Facter.fact(:virtual).stubs(:value).returns("ovirt")
     Facter.fact(:is_virtual).value.should == "true"
   end
+
+  it "should be true when running on ovirt" do
+    Facter.fact(:kernel).stubs(:value).returns("Linux")
+    Facter.fact(:virtual).stubs(:value).returns("gce")
+    Facter.fact(:is_virtual).value.should == "true"
+  end
+
+  it "should be true when running in LXC" do
+    Facter.fact(:kernel).stubs(:value).returns("Linux")
+    Facter.fact(:virtual).stubs(:value).returns("lxc")
+    Facter.fact(:is_virtual).value.should == "true"
+  end
+
+  it "should be true when running in docker" do
+    Facter.fact(:kernel).stubs(:value).returns("Linux")
+    Facter.fact(:virtual).stubs(:value).returns("docker")
+    Facter.fact(:is_virtual).value.should == "true"
+  end
 end