facter 2.0.2 → 2.1.0

data/spec/unit/netmask_spec.rb

@@ -27,6 +27,17 @@ describe "The netmask fact" do
       "ifconfig_ubuntu_1204.txt"
   end
 
+  context "on AIX" do
+    before :each do
+      Facter.fact(:kernel).stubs(:value).returns("AIX")
+    end
+
+    example_behavior_for "netmask from ifconfig output",
+      "AIX 7", "255.255.255.0",
+      "ifconfig_aix_7.txt"
+
+  end
+
   context "on Darwin" do
     before :each do
       Facter.fact(:kernel).stubs(:value).returns("Darwin")

data/spec/unit/operatingsystem_spec.rb

@@ -58,6 +58,7 @@ describe "Operating System fact" do
       "Debian"      => "/etc/debian_version",
       "Gentoo"      => "/etc/gentoo-release",
       "Fedora"      => "/etc/fedora-release",
+      "Mageia"      => "/etc/mageia-release",
       "Mandriva"    => "/etc/mandriva-release",
       "Mandrake"    => "/etc/mandrake-release",
       "MeeGo"       => "/etc/meego-release",
@@ -89,6 +90,13 @@ describe "Operating System fact" do
         Facter.fact(:operatingsystem).value.should == "Ubuntu"
       end
 
+      it "on LinuxMint should use the lsbdistid fact" do
+        FileUtils.stubs(:exists?).with("/etc/debian_version").returns true
+
+        Facter.stubs(:value).with(:lsbdistid).returns("LinuxMint")
+        Facter.fact(:operatingsystem).value.should == "LinuxMint"
+      end
+
     end
 
 
@@ -137,5 +145,16 @@ describe "Operating System fact" do
       File.expects(:read).with("/etc/redhat-release").returns("Scientific Linux CERN SLC 5.7 (Boron)")
       Facter.fact(:operatingsystem).value.should == "SLC"
     end
+
+    it "should identify Cumulus Linux" do
+      Facter::Util::Operatingsystem.expects(:os_release).returns({'NAME' => 'Cumulus Linux'})
+      Facter.fact(:operatingsystem).value.should == "CumulusLinux"
+    end
+
+    it "should not use '/etc/os-release' on platforms other than Cumulus Linux" do
+      Facter::Util::Operatingsystem.expects(:os_release).returns({'NAME' => 'Debian GNU/Linux'})
+      FileTest.expects(:exists?).with('/etc/debian_version').returns true
+      Facter.fact(:operatingsystem).value.should == "Debian"
+    end
   end
 end

data/spec/unit/operatingsystemmajrelease_spec.rb

@@ -3,7 +3,7 @@ require 'spec_helper'
 require 'facter'
 
 describe "OS Major Release fact" do
-  ['Amazon','CentOS','CloudLinux','Debian','Fedora','OEL','OracleLinux','OVS','RedHat','Scientific','SLC'].each do |operatingsystem|
+  ['Amazon','CentOS','CloudLinux','Debian','Fedora','OEL','OracleLinux','OVS','RedHat','Scientific','SLC','CumulusLinux'].each do |operatingsystem|
     context "on #{operatingsystem} operatingsystems" do
       it "should be derived from operatingsystemrelease" do
         Facter.fact(:kernel).stubs(:value).returns("Linux")

data/spec/unit/operatingsystemrelease_spec.rb

@@ -17,6 +17,7 @@ describe "Operating System Release fact" do
     "OpenWrt"    => "/etc/openwrt_version",
     "CentOS"    => "/etc/redhat-release",
     "RedHat"    => "/etc/redhat-release",
+    "LinuxMint"   => "/etc/linuxmint/info",
     "Scientific"  => "/etc/redhat-release",
     "Fedora"    => "/etc/fedora-release",
     "MeeGo"     => "/etc/meego-release",
@@ -225,4 +226,11 @@ describe "Operating System Release fact" do
       Facter.fact(:operatingsystemrelease).value.should == "10.04"
     end
   end
+
+  it "uses '/etc/os-release for Cumulus Linux" do
+    Facter.fact(:kernel).stubs(:value).returns("Linux")
+    Facter.fact(:operatingsystem).stubs(:value).returns("CumulusLinux")
+    Facter::Util::Operatingsystem.expects(:os_release).returns({'VERSION_ID' => '1.5.0'})
+    Facter.fact(:operatingsystemrelease).value.should == "1.5.0"
+  end
 end

data/spec/unit/osfamily_spec.rb

@@ -0,0 +1,62 @@
+#! /usr/bin/env ruby
+
+require 'spec_helper'
+
+describe "OS Family fact" do
+
+  {
+    'Archlinux'    => 'Archlinux',
+    'SmartOS'      => 'Solaris',
+    'OpenIndiana'  => 'Solaris',
+    'OmniOS'       => 'Solaris',
+    'Nexenta'      => 'Solaris',
+    'Solaris'      => 'Solaris',
+    'Ubuntu'       => 'Debian',
+    'Debian'       => 'Debian',
+    'LinuxMint'    => 'Debian',
+    'Gentoo'       => 'Gentoo',
+    'Fedora'       => 'RedHat',
+    'Amazon'       => 'RedHat',
+    'OracleLinux'  => 'RedHat',
+    'OVS'          => 'RedHat',
+    'OEL'          => 'RedHat',
+    'CentOS'       => 'RedHat',
+    'SLC'          => 'RedHat',
+    'Scientific'   => 'RedHat',
+    'CloudLinux'   => 'RedHat',
+    'PSBM'         => 'RedHat',
+    'Ascendos'     => 'RedHat',
+    'XenServer'    => 'RedHat',
+    'RedHat'       => 'RedHat',
+    'SLES'         => 'Suse',
+    'SLED'         => 'Suse',
+    'OpenSuSE'     => 'Suse',
+    'SuSE'         => 'Suse',
+    'Mageia'       => 'Mandrake',
+    'Mandriva'     => 'Mandrake',
+    'Mandrake'     => 'Mandrake',
+  }.each do |os,family|
+    it "should return #{family} on operatingsystem #{os}" do
+      Facter.fact(:operatingsystem).stubs(:value).returns os
+      Facter.fact(:osfamily).value.should == family
+    end
+  end
+
+  [
+    'MeeGo',
+    'VMWareESX',
+    'Bluewhite64',
+    'Slamd64',
+    'Slackware',
+    'Alpine',
+    'ESXi',
+    'windows',
+    'HP-UX'
+  ].each do |os|
+    it "should return the kernel fact on operatingsystem #{os}" do
+      Facter.fact(:operatingsystem).stubs(:value).returns os
+      Facter.fact(:kernel).stubs(:value).returns 'random_kernel_fact'
+      Facter.fact(:osfamily).value.should == 'random_kernel_fact'
+    end
+  end
+end

data/spec/unit/partitions_spec.rb

@@ -0,0 +1,48 @@
+#!/usr/bin/env ruby
+
+require 'spec_helper'
+require 'facter'
+
+describe "Partition facts" do
+
+  describe "on non-Linux OS" do
+
+    it "should not exist when kernel isn't Linux" do
+      Facter.fact(:kernel).stubs(:value).returns("SunOS")
+      Facter.fact(:partitions).value.should == nil
+    end
+  end
+
+  describe "on Linux" do
+    it "should return a structured fact with uuid, size, mount point and filesytem for each partition" do
+      partitions = {
+        'sda1' => {
+          'uuid'       => '13459663-22cc-47b4-a9e6-21dea9906e03',
+          'size'       => '1234',
+          'mount'      => '/',
+          'filesystem' => 'ext4',
+        },
+        'sdb2' => {
+          'uuid'       => '98043570-eb10-457f-9718-0b85a26e66bf',
+          'size'       => '5678',
+          'mount'      => '/home',
+          'filesystem' => 'xfs',
+        },
+      }
+
+      Facter::Util::Partitions.stubs(:list).returns( partitions.keys )
+
+      partitions.each do |part,vals|
+        Facter::Util::Partitions.stubs(:uuid).with(part).returns(vals['uuid'])
+        Facter::Util::Partitions.stubs(:size).with(part).returns(vals['size'])
+        Facter::Util::Partitions.stubs(:mount).with(part).returns(vals['mount'])
+        Facter::Util::Partitions.stubs(:filesystem).with(part).returns(vals['filesystem'])
+      end
+
+      Facter.fact(:partitions).value.should == {
+        'sda1' => { 'uuid' => '13459663-22cc-47b4-a9e6-21dea9906e03', 'size' => '1234', 'mount' => '/', 'filesystem' => 'ext4' },
+        'sdb2' => { 'uuid' => '98043570-eb10-457f-9718-0b85a26e66bf', 'size' => '5678', 'mount' => '/home', 'filesystem' => 'xfs' },
+      }
+    end
+  end
+end

data/spec/unit/physicalprocessorcount_spec.rb

@@ -1,6 +1,7 @@
 #! /usr/bin/env ruby
 
 require 'spec_helper'
+require 'facter/util/posix'
 
 describe "Physical processor count facts" do
 
@@ -73,4 +74,12 @@ describe "Physical processor count facts" do
       end
     end
   end
+
+  describe "on openbsd" do
+    it "should return 4 physical CPUs" do
+      Facter.fact(:kernel).stubs(:value).returns("OpenBSD")
+      Facter::Util::POSIX.expects(:sysctl).with("hw.ncpufound").returns("4")
+      Facter.fact(:physicalprocessorcount).value.should == "4"
+    end
+  end
 end

data/spec/unit/processor_spec.rb

@@ -1,5 +1,6 @@
 #! /usr/bin/env ruby
 
+require 'facter/util/posix'
 require 'facter/util/processor'
 require 'spec_helper'
 require 'facter_spec/cpuinfo'
@@ -185,35 +186,42 @@ describe "Processor facts" do
 
     it "should be 2 on dual-processor Darwin box" do
       Facter.fact(:kernel).stubs(:value).returns("Darwin")
-      Facter::Core::Execution.stubs(:execute).with("sysctl -n hw.ncpu", anything).returns('2')
+      Facter::Util::POSIX.stubs(:sysctl).with("hw.ncpu").returns('2')
 
       Facter.fact(:processorcount).value.should == "2"
     end
 
     it "should be 2 on dual-processor OpenBSD box" do
       Facter.fact(:kernel).stubs(:value).returns("OpenBSD")
-      Facter::Core::Execution.stubs(:execute).with("sysctl -n hw.ncpu", anything).returns('2')
+      Facter::Util::POSIX.stubs(:sysctl).with("hw.ncpu").returns('2')
 
       Facter.fact(:processorcount).value.should == "2"
     end
 
+    it "should print the correct CPU Model on OpenBSD" do
+      Facter.fact(:kernel).stubs(:value).returns("OpenBSD")
+      Facter::Util::POSIX.stubs(:sysctl).with("hw.model").returns('SomeVendor CPU 4.2GHz')
+
+      Facter.fact(:processor).value.should == "SomeVendor CPU 4.2GHz"
+    end
+
     it "should be 2 on dual-processor FreeBSD box" do
       Facter.fact(:kernel).stubs(:value).returns("FreeBSD")
-      Facter::Core::Execution.stubs(:execute).with("sysctl -n hw.ncpu", anything).returns('2')
+      Facter::Util::POSIX.stubs(:sysctl).with("hw.ncpu").returns('2')
 
       Facter.fact(:processorcount).value.should == "2"
     end
 
     it "should print the correct CPU Model on FreeBSD" do
       Facter.fact(:kernel).stubs(:value).returns("FreeBSD")
-      Facter::Core::Execution.stubs(:execute).with("sysctl -n hw.model", anything).returns('SomeVendor CPU 3GHz')
+      Facter::Util::POSIX.stubs(:sysctl).with("hw.model").returns('SomeVendor CPU 3GHz')
 
       Facter.fact(:processor).value.should == "SomeVendor CPU 3GHz"
     end
 
     it "should be 2 on dual-processor DragonFly box" do
       Facter.fact(:kernel).stubs(:value).returns("DragonFly")
-      Facter::Core::Execution.stubs(:execute).with("sysctl -n hw.ncpu", anything).returns('2')
+      Facter::Util::POSIX.stubs(:sysctl).with("hw.ncpu").returns('2')
 
       Facter.fact(:processorcount).value.should == "2"
     end
@@ -234,7 +242,7 @@ describe "Processor facts" do
     let(:kstat_sparc) { @fixture_kstat_sparc }
     let(:kstat_x86_64) { @fixture_kstat_x86_64 }
 
-    %w{ 5.8 5.9 5.10 5.11 }.each do |release|
+    %w{ 5.5.1 5.6 5.7 }.each do |release|
       %w{ sparc x86_64 }.each do |arch|
         it "uses kstat on release #{release} (#{arch})" do
           Facter.stubs(:value).with(:kernelrelease).returns(release)
@@ -246,7 +254,7 @@ describe "Processor facts" do
       end
     end
 
-    %w{ 5.5.1 5.6 5.7 }.each do |release|
+    %w{ 5.8 5.9 5.10 5.11 }.each do |release|
       it "uses psrinfo on release #{release}" do
         Facter.stubs(:value).with(:kernelrelease).returns(release)
 

data/spec/unit/util/config_spec.rb

@@ -5,6 +5,19 @@ require 'spec_helper'
 describe Facter::Util::Config do
   include PuppetlabsSpec::Files
 
+  describe "ENV['HOME'] is unset", :unless => Facter::Util::Root.root? do
+    around do |example|
+      Facter::Core::Execution.with_env('HOME' => nil) do
+        example.run
+      end
+    end
+
+    it "should not set @external_facts_dirs" do
+      Facter::Util::Config.setup_default_ext_facts_dirs
+      Facter::Util::Config.external_facts_dirs.should be_empty
+    end
+  end
+
   describe "is_windows? function" do
     it "should detect windows if Ruby RbConfig::CONFIG['host_os'] returns a windows OS" do
       host_os = ["mswin","win32","dos","mingw","cygwin"]

data/spec/unit/util/dhcp_servers_spec.rb

@@ -0,0 +1,63 @@
+#! /usr/bin/env ruby
+
+require 'spec_helper'
+require 'facter/util/dhcp_servers'
+
+describe Facter::Util::DHCPServers do
+
+  describe "retrieving the gateway device" do
+    it "returns nil when there are no default routes" do
+      Facter::Util::FileRead.stubs(:read).with('/proc/net/route').returns(my_fixture_read('route_nogw'))
+      described_class.gateway_device.should be_nil
+    end
+
+    it "returns the interface associated with the first default route" do
+      Facter::Util::FileRead.stubs(:read).with('/proc/net/route').returns(my_fixture_read('route'))
+      described_class.gateway_device.should eq "eth0"
+    end
+  end
+
+  describe "nmcli_version" do
+    {
+      'nmcli tool, version 0.9.8.0' => [0, 9, 8, 0],
+      'nmcli tool, version 0.9.8.10' => [0, 9, 8, 10],
+      'nmcli tool, version 0.9.8.9' => [0, 9, 8, 9],
+      'nmcli tool, version 0.9.9.0' => [0, 9, 9, 0],
+      'nmcli tool, version 0.9.9.9' => [0, 9, 9, 9],
+      'version 0.9.9.0-20.git20131003.fc20' => [0, 9, 9, 0],
+      'nmcli tool, version 0.9.9' => [0, 9, 9, 0],
+      'nmcli tool, version 0.9' => [0, 9, 0, 0],
+      'nmcli tool, version 1' => [1, 0, 0, 0]
+    }.each do |version, expected|
+      it "should turn #{version} into the integer #{expected}" do
+        Facter::Core::Execution.stubs(:which).with('nmcli').returns('/usr/bin/nmcli')
+        Facter::Core::Execution.stubs(:exec).with('nmcli --version').returns(version)
+        
+        result = Facter::Util::DHCPServers.nmcli_version
+        result.is_a?(Array).should be true
+        result.should == expected
+      end
+    end
+  end
+
+  describe "device_dhcp_server" do
+    {
+        '0.1.2.3' => false,
+        '0.9.8.10' => false,
+        '0.9.9.0' => true,
+        '0.9.10.0' => true,
+        '0.10.0.0' => true,
+        '1.0.0.0' => true
+    }.each do |version, uses_show|
+      it "should use #{if uses_show then 'show' else 'list' end} for version #{version}" do
+        command = if uses_show then 'nmcli -f all d show eth0' else 'nmcli -f all d list iface eth0' end
+        Facter::Core::Execution.stubs(:which).with('nmcli').returns('/usr/bin/nmcli')
+        Facter::Core::Execution.stubs(:exec).with('nmcli --version').returns "nmcli tool, version #{version}"
+        Facter::Core::Execution.stubs(:exec).with(command).returns 'DHCP4.OPTION[1]: dhcp_server_identifier = 192.168.1.1'
+        Facter::Util::DHCPServers.device_dhcp_server('eth0').should == '192.168.1.1'
+      end
+    end
+  end
+end
+
+

data/spec/unit/util/ec2_spec.rb

@@ -4,6 +4,10 @@ require 'spec_helper'
 require 'facter/util/ec2'
 
 describe Facter::Util::EC2 do
+  before do
+    # Squelch deprecation notices
+    Facter.stubs(:warnonce)
+  end
   # This is the standard prefix for making an API call in EC2 (or fake)
   # environments.
   let(:api_prefix) { "http://169.254.169.254" }

data/spec/unit/util/formatter_spec.rb

@@ -0,0 +1,50 @@
+require 'spec_helper'
+require 'facter/util/formatter'
+
+describe Facter::Util::Formatter do
+  describe "formatting as json" do
+    it "formats the text as json when json is available", :if => Facter.json? do
+      JSON.expects(:pretty_generate).with({"hello" => "world"}).returns(%Q({"hello": "world"}))
+      expect(described_class.format_json({"hello" => "world"})).to eq %Q({"hello": "world"})
+    end
+
+    it "raises an error when JSON is not available" do
+      Facter.stubs(:json?).returns false
+      expect {
+        described_class.format_json({"hello" => "world"})
+      }.to raise_error(/'json' library is not present/)
+    end
+  end
+
+  describe "formatting as yaml" do
+    it "dumps the text as YAML" do
+      expect(described_class.format_yaml({"hello" => "world"})).to match(/hello: world/)
+    end
+  end
+
+  describe "formatting as plaintext" do
+    it "formats a single string value without quotes" do
+      expect(described_class.format_plaintext({"foo" => "bar"})).to eq "bar"
+    end
+
+    it "formats a structured value with #inspect" do
+      value = ["bar"]
+      value.expects(:inspect).returns %Q(["bar"])
+      hash = {"foo" => value, "baz" => "quux"}
+      expect(described_class.format_plaintext(hash)).to match(%Q([bar]))
+    end
+    it "formats multiple string values as key/value pairs" do
+      hash = {"foo" => "bar", "baz" => "quux"}
+      expect(described_class.format_plaintext(hash)).to match(/foo => bar/)
+      expect(described_class.format_plaintext(hash)).to match(/baz => quux/)
+    end
+
+    it "formats multiple structured values with #inspect" do
+      value = ["bar"]
+      value.expects(:inspect).twice.returns %Q(["bar"])
+      hash = {"foo" => value, "baz" => "quux"}
+      expect(described_class.format_plaintext(hash)).to match(/foo => \["bar"\]/)
+      expect(described_class.format_plaintext(hash)).to match(/baz => quux/)
+    end
+  end
+end

data/spec/unit/util/loader_spec.rb

@@ -277,10 +277,10 @@ describe Facter::Util::Loader do
   end
 
   it "should load facts on the facter search path only once" do
-    facterlibdir = File.expand_path(File.dirname(__FILE__) + '../../../fixtures/unit/util/loader')
+    loader = loader_from(:env => {})
+    loader.load_all
 
-    Facter::Util::Loader.new('FACTERLIB' => facterlibdir).load_all
-
-    Facter.value(:nosuchfact).should be_nil
+    loader.expects(:kernel_load).with(regexp_matches(/ec2/)).never
+    loader.load(:ec2)
   end
 end