facter 1.6.4 → 1.6.5

data/spec/unit/operatingsystemrelease_spec.rb

@@ -1,8 +1,6 @@
-#!/usr/bin/env ruby
+#!/usr/bin/env rspec
 
-require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
-
-require 'facter'
+require 'spec_helper'
 
 describe "Operating System Release fact" do
 

data/spec/unit/physicalprocessorcount_spec.rb

@@ -1,6 +1,6 @@
 #!/usr/bin/env rspec
 
-require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
+require 'spec_helper'
 
 describe "Physical processor count facts" do
 

data/spec/unit/processor_spec.rb

@@ -1,12 +1,9 @@
-#!/usr/bin/env ruby
+#!/usr/bin/env rspec
 
-$basedir = File.expand_path(File.dirname(__FILE__) + '/..')
-require File.join($basedir, 'spec_helper')
-
-require 'facter'
+require 'spec_helper'
 
 def cpuinfo_fixture(filename)
-    cpuinfo = File.open(File.join($basedir, 'fixtures', 'cpuinfo', filename)).readlines
+  File.open(fixtures('cpuinfo', filename)).readlines
 end
 
 describe "Processor facts" do
@@ -74,18 +71,18 @@ describe "Processor facts" do
     end
 
     it "should detect the correct processor count on x86_64" do
-      fixture_data = File.read(File.expand_path(File.dirname(__FILE__) + '/../fixtures/processorcount/solaris-x86_64-kstat-cpu-info'))
+      fixture_data = File.read(fixtures('processorcount','solaris-x86_64-kstat-cpu-info'))
       Facter::Util::Resolution.expects(:exec).with("/usr/bin/kstat cpu_info").returns(fixture_data)
       Facter.fact(:processorcount).value.should == 8
     end
 
     it "should detect the correct processor count on sparc" do
-      fixture_data = File.read(File.expand_path(File.dirname(__FILE__) + '/../fixtures/processorcount/solaris-sparc-kstat-cpu-info'))
+      fixture_data = File.read(fixtures('processorcount','solaris-sparc-kstat-cpu-info'))
       Facter::Util::Resolution.expects(:exec).with("/usr/bin/kstat cpu_info").returns(fixture_data)
       Facter.fact(:processorcount).value.should == 8
     end
   end
-  
+
   describe "on Unixes" do
     before :each do
       Facter.collection.loader.load(:processor)
@@ -106,102 +103,102 @@ describe "Processor facts" do
       Facter.fact(:architecture).stubs(:value).returns("ppc64")
       File.stubs(:exists?).with("/proc/cpuinfo").returns(true)
       File.stubs(:readlines).with("/proc/cpuinfo").returns(cpuinfo_fixture("ppc64"))
-    
+
       Facter.fact(:processorcount).value.should == "2"
     end
-  
+
     it "should be 2 in panda-armel fixture on Linux" do
       Facter.fact(:kernel).stubs(:value).returns("Linux")
       Facter.fact(:architecture).stubs(:value).returns("arm")
       File.stubs(:exists?).with("/proc/cpuinfo").returns(true)
       File.stubs(:readlines).with("/proc/cpuinfo").returns(cpuinfo_fixture("panda-armel"))
-    
+
       Facter.fact(:processorcount).value.should == "2"
     end
-  
+
     it "should be 1 in bbg3-armel fixture on Linux" do
       Facter.fact(:kernel).stubs(:value).returns("Linux")
       Facter.fact(:architecture).stubs(:value).returns("arm")
       File.stubs(:exists?).with("/proc/cpuinfo").returns(true)
       File.stubs(:readlines).with("/proc/cpuinfo").returns(cpuinfo_fixture("bbg3-armel"))
-    
+
       Facter.fact(:processorcount).value.should == "1"
     end
-  
+
     it "should be 1 in beaglexm-armel fixture on Linux" do
       Facter.fact(:kernel).stubs(:value).returns("Linux")
       Facter.fact(:architecture).stubs(:value).returns("arm")
       File.stubs(:exists?).with("/proc/cpuinfo").returns(true)
       File.stubs(:readlines).with("/proc/cpuinfo").returns(cpuinfo_fixture("beaglexm-armel"))
-    
+
       Facter.fact(:processorcount).value.should == "1"
     end
-    
+
     it "should be 1 in amd64solo fixture on Linux" do
       Facter.fact(:kernel).stubs(:value).returns("Linux")
       Facter.fact(:architecture).stubs(:value).returns("amd64")
       File.stubs(:exists?).with("/proc/cpuinfo").returns(true)
       File.stubs(:readlines).with("/proc/cpuinfo").returns(cpuinfo_fixture("amd64solo"))
-    
+
       Facter.fact(:processorcount).value.should == "1"
     end
-    
+
     it "should be 2 in amd64dual fixture on Linux" do
       Facter.fact(:kernel).stubs(:value).returns("Linux")
       Facter.fact(:architecture).stubs(:value).returns("amd64")
       File.stubs(:exists?).with("/proc/cpuinfo").returns(true)
       File.stubs(:readlines).with("/proc/cpuinfo").returns(cpuinfo_fixture("amd64dual"))
-    
+
       Facter.fact(:processorcount).value.should == "2"
     end
-    
+
     it "should be 3 in amd64tri fixture on Linux" do
       Facter.fact(:kernel).stubs(:value).returns("Linux")
       Facter.fact(:architecture).stubs(:value).returns("amd64")
       File.stubs(:exists?).with("/proc/cpuinfo").returns(true)
       File.stubs(:readlines).with("/proc/cpuinfo").returns(cpuinfo_fixture("amd64tri"))
-    
+
       Facter.fact(:processorcount).value.should == "3"
     end
-      
+
     it "should be 4 in amd64quad fixture on Linux" do
       Facter.fact(:kernel).stubs(:value).returns("Linux")
       Facter.fact(:architecture).stubs(:value).returns("amd64")
       File.stubs(:exists?).with("/proc/cpuinfo").returns(true)
       File.stubs(:readlines).with("/proc/cpuinfo").returns(cpuinfo_fixture("amd64quad"))
-  
+
       Facter.fact(:processorcount).value.should == "4"
     end
-  
+
     it "should be 2 on dual-processor Darwin box" do
       Facter.fact(:kernel).stubs(:value).returns("Darwin")
       Facter::Util::Resolution.stubs(:exec).with("sysctl -n hw.ncpu").returns('2')
-  
+
       Facter.fact(:processorcount).value.should == "2"
     end
-    
+
     it "should be 2 on dual-processor OpenBSD box" do
       Facter.fact(:kernel).stubs(:value).returns("OpenBSD")
       Facter::Util::Resolution.stubs(:exec).with("sysctl -n hw.ncpu").returns('2')
-  
+
       Facter.fact(:processorcount).value.should == "2"
     end
 
     it "should be 2 on dual-processor DragonFly box" do
       Facter.fact(:kernel).stubs(:value).returns("DragonFly")
       Facter::Util::Resolution.stubs(:exec).with("sysctl -n hw.ncpu").returns('2')
-  
+
       Facter.fact(:processorcount).value.should == "2"
     end
- 
+
     it "should be 6 on six-processor AIX box" do
       Facter.fact(:kernel).stubs(:value).returns("AIX")
       Facter::Util::Resolution.stubs(:exec).with("lsdev -Cc processor").returns("proc0 Available 00-00 Processor\nproc2 Available 00-02 Processor\nproc4 Available 00-04 Processor\nproc6 Available 00-06 Processor\nproc8 Available 00-08 Processor\nproc10 Available 00-10 Processor")
       Facter::Util::Resolution.stubs(:exec).with("lsattr -El proc0 -a type").returns("type PowerPC_POWER3 Processor type False")
-  
+
       Facter.fact(:processorcount).value.should == "6"
     end
-    
+
     it "should be 2 via sysfs when cpu0 and cpu1 are present" do
       Facter.fact(:kernel).stubs(:value).returns("Linux")
       File.stubs(:exists?).with('/sys/devices/system/cpu').returns(true)
@@ -212,10 +209,10 @@ describe "Processor facts" do
         /sys/devices/system/cpu/cpu0
         /sys/devices/system/cpu/cpu1
       })
-  
+
       Facter.fact(:processorcount).value.should == "2"
     end
-  
+
     it "should be 16 via sysfs when cpu0 through cpu15 are present" do
       Facter.fact(:kernel).stubs(:value).returns("Linux")
       File.stubs(:exists?).with('/sys/devices/system/cpu').returns(true)
@@ -240,7 +237,7 @@ describe "Processor facts" do
         /sys/devices/system/cpu/cpu14
         /sys/devices/system/cpu/cpu15
       })
-    
+
       Facter.fact(:processorcount).value.should == "16"
     end
   end

data/spec/unit/selinux_spec.rb

@@ -1,8 +1,6 @@
-#!/usr/bin/env ruby
+#!/usr/bin/env rspec
 
-require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
-
-require 'facter'
+require 'spec_helper'
 
 describe "SELinux facts" do
 
@@ -50,8 +48,7 @@ describe "SELinux facts" do
   it "should return the SELinux current mode" do
     Facter.fact(:selinux).stubs(:value).returns("true")
 
-    sample_output_file = File.dirname(__FILE__) + '/data/selinux_sestatus'
-    selinux_sestatus = File.read(sample_output_file)
+    selinux_sestatus = my_fixture_read("selinux_sestatus")
 
     Facter::Util::Resolution.stubs(:exec).with('/usr/sbin/sestatus').returns(selinux_sestatus)
 
@@ -61,8 +58,7 @@ describe "SELinux facts" do
   it "should return the SELinux mode from the configuration file" do
     Facter.fact(:selinux).stubs(:value).returns("true")
 
-    sample_output_file = File.dirname(__FILE__) + '/data/selinux_sestatus'
-    selinux_sestatus = File.read(sample_output_file)
+    selinux_sestatus = my_fixture_read("selinux_sestatus")
 
     Facter::Util::Resolution.stubs(:exec).with('/usr/sbin/sestatus').returns(selinux_sestatus)
 
@@ -72,8 +68,7 @@ describe "SELinux facts" do
   it "should return the SELinux configuration file policy" do
     Facter.fact(:selinux).stubs(:value).returns("true")
 
-    sample_output_file = File.dirname(__FILE__) + '/data/selinux_sestatus'
-    selinux_sestatus = File.read(sample_output_file)
+    selinux_sestatus = my_fixture_read("selinux_sestatus")
 
     Facter::Util::Resolution.stubs(:exec).with('/usr/sbin/sestatus').returns(selinux_sestatus)
 

data/spec/unit/uniqueid_spec.rb

@@ -0,0 +1,27 @@
+#!/usr/bin/env ruby
+
+require 'spec_helper'
+require 'facter'
+
+describe "Uniqueid fact" do
+  it "should match hostid on Solaris" do
+    Facter.fact(:kernel).stubs(:value).returns("SunOS")
+    Facter::Util::Resolution.stubs(:exec).with("hostid").returns("Larry")
+
+    Facter.fact(:uniqueid).value.should == "Larry"
+  end
+
+  it "should match hostid on Linux" do
+    Facter.fact(:kernel).stubs(:value).returns("Linux")
+    Facter::Util::Resolution.stubs(:exec).with("hostid").returns("Curly")
+
+    Facter.fact(:uniqueid).value.should == "Curly"
+  end
+
+  it "should match hostid on AIX" do
+    Facter.fact(:kernel).stubs(:value).returns("AIX")
+    Facter::Util::Resolution.stubs(:exec).with("hostid").returns("Moe")
+
+    Facter.fact(:uniqueid).value.should == "Moe"
+  end
+end

data/spec/unit/uptime_spec.rb

@@ -1,8 +1,6 @@
-#!/usr/bin/env ruby
+#!/usr/bin/env rspec
 
-require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
-
-require 'facter'
+require 'spec_helper'
 require 'facter/util/uptime'
 
 describe "uptime facts:" do

data/spec/unit/util/collection_spec.rb

@@ -1,7 +1,6 @@
-#!/usr/bin/env ruby
-
-require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
+#!/usr/bin/env rspec
 
+require 'spec_helper'
 require 'facter/util/collection'
 
 describe Facter::Util::Collection do
@@ -93,6 +92,16 @@ describe Facter::Util::Collection do
 
         @coll.add(:myname) {}
       end
+
+      it "should discard resolutions that throw an exception when added" do
+        lambda {
+          @coll.add('yay') do
+            raise
+            setcode { 'yay' }
+          end
+        }.should_not raise_error
+        @coll.value('yay').should be_nil
+      end
     end
   end
 

data/spec/unit/util/config_spec.rb

@@ -0,0 +1,24 @@
+#!/usr/bin/env rspec
+
+require 'spec_helper'
+require 'facter/util/config'
+
+describe Facter::Util::Config do
+  describe "is_windows? function" do
+    it "should detect windows if RbConfig returns a windows OS" do
+      host_os = ["mswin","win32","dos","mingw","cygwin"]
+      host_os.each do |h|
+        RbConfig::CONFIG.expects(:[]).with('host_os').returns(h)
+        Facter::Util::Config.is_windows?.should be_true
+      end
+    end
+
+    it "should not detect windows if RbConfig returns a non-windows OS" do
+      host_os = ["darwin","linux"]
+      host_os.each do |h|
+        RbConfig::CONFIG.expects(:[]).with('host_os').returns(h)
+        Facter::Util::Config.is_windows?.should be_false
+      end
+    end
+  end
+end

data/spec/unit/util/confine_spec.rb

@@ -1,7 +1,6 @@
-#!/usr/bin/env ruby
-
-require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
+#!/usr/bin/env rspec
 
+require 'spec_helper'
 require 'facter/util/confine'
 require 'facter/util/values'
 

data/spec/unit/util/ec2_spec.rb

@@ -0,0 +1,112 @@
+#!/usr/bin/env rspec
+
+require 'spec_helper'
+require 'facter/util/ec2'
+
+describe Facter::Util::EC2 do
+  # This is the standard prefix for making an API call in EC2 (or fake)
+  # environments.
+  let(:api_prefix) { "http://169.254.169.254" }
+
+  describe "is_ec2_arp? method" do
+    describe "on linux" do
+      before :each do
+        # Return fake kernel
+        Facter.stubs(:value).with(:kernel).returns("linux")
+      end
+
+      it "should succeed if arp table contains fe:ff:ff:ff:ff:ff" do
+        ec2arp = my_fixture_read("linux-arp-ec2.out")
+        Facter::Util::Resolution.expects(:exec).with("arp -an").\
+          at_least_once.returns(ec2arp)
+        Facter::Util::EC2.has_ec2_arp?.should == true
+      end
+
+      it "should fail if arp table does not contain fe:ff:ff:ff:ff:ff" do
+        ec2arp = my_fixture_read("linux-arp-not-ec2.out")
+        Facter::Util::Resolution.expects(:exec).with("arp -an").
+          at_least_once.returns(ec2arp)
+        Facter::Util::EC2.has_ec2_arp?.should == false
+      end
+    end
+
+    describe "on windows" do
+      before :each do
+        # Return fake kernel
+        Facter.stubs(:value).with(:kernel).returns("windows")
+      end
+
+      it "should succeed if arp table contains fe-ff-ff-ff-ff-ff" do
+        ec2arp = my_fixture_read("windows-2008-arp-a.out")
+        Facter::Util::Resolution.expects(:exec).with("arp -a").\
+          at_least_once.returns(ec2arp)
+        Facter::Util::EC2.has_ec2_arp?.should == true
+      end
+
+      it "should fail if arp table does not contain fe-ff-ff-ff-ff-ff" do
+        ec2arp = my_fixture_read("windows-2008-arp-a-not-ec2.out")
+        Facter::Util::Resolution.expects(:exec).with("arp -a").
+          at_least_once.returns(ec2arp)
+        Facter::Util::EC2.has_ec2_arp?.should == false
+      end
+    end
+  end
+
+  describe "is_euca_mac? method" do
+    it "should return true when the mac is a eucalyptus one" do
+      Facter.expects(:value).with(:macaddress).\
+        at_least_once.returns("d0:0d:1a:b0:a1:00")
+
+      Facter::Util::EC2.has_euca_mac?.should == true
+    end
+
+    it "should return false when the mac is not a eucalyptus one" do
+      Facter.expects(:value).with(:macaddress).\
+        at_least_once.returns("0c:1d:a0:bc:aa:02")
+
+      Facter::Util::EC2.has_euca_mac?.should == false
+    end
+  end
+
+  describe "can_connect? method" do
+    it "returns true if api responds" do
+      # Return something upon connecting to the root
+      Module.any_instance.expects(:open).with("#{api_prefix}:80/").\
+        at_least_once.returns("2008-02-01\nlatest")
+
+      Facter::Util::EC2.can_connect?.should == true
+    end
+
+    describe "when connection times out" do
+      before :each do
+        # Emulate a timeout when connecting by throwing an exception
+        Module.any_instance.expects(:open).with("#{api_prefix}:80/").\
+          at_least_once.raises(Timeout::Error)
+      end
+
+      it "should not raise exception" do
+        expect { Facter::Util::EC2.can_connect? }.to_not raise_error
+      end
+
+      it "should return false" do
+        Facter::Util::EC2.can_connect?.should == false
+      end
+    end
+
+    describe "when connection is refused" do
+      before :each do
+        # Emulate a connection refused
+        Module.any_instance.expects(:open).with("#{api_prefix}:80/").\
+          at_least_once.raises(Errno::ECONNREFUSED)
+      end
+
+      it "should not raise exception" do
+        expect { Facter::Util::EC2.can_connect? }.to_not raise_error
+      end
+
+      it "should return false" do
+        Facter::Util::EC2.can_connect?.should == false
+      end
+    end
+  end
+end