facter 1.6.4 → 1.6.5

data/spec/unit/architecture_spec.rb

@@ -1,8 +1,6 @@
-#!/usr/bin/env ruby
+#!/usr/bin/env rspec
 
-require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
-
-require 'facter'
+require 'spec_helper'
 
 describe "Architecture fact" do
 

data/spec/unit/domain_spec.rb

@@ -1,4 +1,6 @@
-require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
+#!/usr/bin/env rspec
+
+require 'spec_helper'
 
 describe "Domain name facts" do
 

data/spec/unit/ec2_spec.rb

@@ -0,0 +1,140 @@
+#!/usr/bin/env rspec
+
+require 'spec_helper'
+require 'facter/util/ec2'
+
+describe "ec2 facts" do
+  # This is the standard prefix for making an API call in EC2 (or fake)
+  # environments.
+  let(:api_prefix) { "http://169.254.169.254" }
+
+  describe "when running on ec2" do
+    before :each do
+      # This is an ec2 instance, not a eucalyptus instance
+      Facter::Util::EC2.expects(:has_euca_mac?).at_least_once.returns(false)
+      Facter::Util::EC2.expects(:has_ec2_arp?).at_least_once.returns(true)
+
+      # Assume we can connect
+      Facter::Util::EC2.expects(:can_connect?).at_least_once.returns(true)
+    end
+
+    it "should create flat meta-data facts" do
+      Object.any_instance.expects(:open).
+        with("#{api_prefix}/2008-02-01/meta-data/").
+        at_least_once.returns(StringIO.new("foo"))
+
+      Object.any_instance.expects(:open).
+        with("#{api_prefix}/2008-02-01/meta-data/foo").
+        at_least_once.returns(StringIO.new("bar"))
+
+      # No user-data
+      Object.any_instance.expects(:open).
+        with("#{api_prefix}/2008-02-01/user-data/").
+        at_least_once.returns(StringIO.new(""))
+
+      Facter.collection.loader.load(:ec2)
+      Facter.fact(:ec2_foo).value.should == "bar"
+    end
+
+    it "should create flat meta-data facts with comma seperation" do
+      Object.any_instance.expects(:open).
+        with("#{api_prefix}/2008-02-01/meta-data/").
+        at_least_once.returns(StringIO.new("foo"))
+
+      Object.any_instance.expects(:open).
+        with("#{api_prefix}/2008-02-01/meta-data/foo").
+        at_least_once.returns(StringIO.new("bar\nbaz"))
+
+      # No user-data
+      Object.any_instance.expects(:open).
+        with("#{api_prefix}/2008-02-01/user-data/").
+        at_least_once.returns(StringIO.new(""))
+
+      Facter.collection.loader.load(:ec2)
+      Facter.fact(:ec2_foo).value.should == "bar,baz"
+    end
+
+    it "should create structured meta-data facts" do
+      Object.any_instance.expects(:open).
+        with("#{api_prefix}/2008-02-01/meta-data/").
+        at_least_once.returns(StringIO.new("foo/"))
+
+      Object.any_instance.expects(:open).
+        with("#{api_prefix}/2008-02-01/meta-data/foo/").
+        at_least_once.returns(StringIO.new("bar"))
+
+      Object.any_instance.expects(:open).
+        with("#{api_prefix}/2008-02-01/meta-data/foo/bar").
+        at_least_once.returns(StringIO.new("baz"))
+
+      # No user-data
+      Object.any_instance.expects(:open).
+        with("#{api_prefix}/2008-02-01/user-data/").
+        at_least_once.returns(StringIO.new(""))
+
+      Facter.collection.loader.load(:ec2)
+      Facter.fact(:ec2_foo_bar).value.should == "baz"
+    end
+
+    it "should create ec2_user_data fact" do
+      # No meta-data
+      Object.any_instance.expects(:open).
+        with("#{api_prefix}/2008-02-01/meta-data/").
+        at_least_once.returns(StringIO.new(""))
+
+      Object.any_instance.expects(:open).
+        with("#{api_prefix}/2008-02-01/user-data/").
+        at_least_once.returns(StringIO.new("test"))
+
+      Facter.collection.loader.load(:ec2)
+      Facter.fact(:ec2_userdata).value.should == ["test"]
+    end
+  end
+
+  describe "when running on eucalyptus" do
+    before :each do
+      # Return false for ec2, true for eucalyptus
+      Facter::Util::EC2.expects(:has_euca_mac?).at_least_once.returns(true)
+      Facter::Util::EC2.expects(:has_ec2_arp?).never
+
+      # Assume we can connect
+      Facter::Util::EC2.expects(:can_connect?).at_least_once.returns(true)
+    end
+
+    it "should create ec2_user_data fact" do
+      # No meta-data
+      Object.any_instance.expects(:open).\
+        with("#{api_prefix}/2008-02-01/meta-data/").\
+        at_least_once.returns(StringIO.new(""))
+
+      Object.any_instance.expects(:open).\
+        with("#{api_prefix}/2008-02-01/user-data/").\
+        at_least_once.returns(StringIO.new("test"))
+
+      # Force a fact load
+      Facter.collection.loader.load(:ec2)
+
+      Facter.fact(:ec2_userdata).value.should == ["test"]
+    end
+  end
+
+  describe "when api connect test fails" do
+    it "should not populate ec2_userdata" do
+      # Emulate ec2 for now as it matters little to this test
+      Facter::Util::EC2.expects(:has_euca_mac?).at_least_once.returns(true)
+      Facter::Util::EC2.expects(:has_ec2_arp?).never
+      Facter::Util::EC2.expects(:can_connect?).at_least_once.returns(false)
+
+      # The API should never be called at this point
+      Object.any_instance.expects(:open).
+        with("#{api_prefix}/2008-02-01/meta-data/").never
+      Object.any_instance.expects(:open).
+        with("#{api_prefix}/2008-02-01/user-data/").never
+
+      # Force a fact load
+      Facter.collection.loader.load(:ec2)
+
+      Facter.fact(:ec2_userdata).should == nil
+    end
+  end
+end

data/spec/unit/facter_spec.rb

@@ -1,6 +1,6 @@
-#!/usr/bin/env ruby
+#!/usr/bin/env rspec
 
-require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
+require 'spec_helper'
 
 describe Facter do
 

data/spec/unit/hardwareisa_spec.rb

@@ -0,0 +1,34 @@
+#!/usr/bin/env ruby
+
+require 'spec_helper'
+require 'facter'
+
+describe "Hardwareisa fact" do
+  it "should match uname -p on Linux" do
+    Facter.fact(:kernel).stubs(:value).returns("Linux")
+    Facter::Util::Resolution.stubs(:exec).with("uname -p").returns("Inky")
+
+    Facter.fact(:hardwareisa).value.should == "Inky"
+  end
+
+  it "should match uname -p on Darwin" do
+    Facter.fact(:kernel).stubs(:value).returns("Darwin")
+    Facter::Util::Resolution.stubs(:exec).with("uname -p").returns("Blinky")
+
+    Facter.fact(:hardwareisa).value.should == "Blinky"
+  end
+
+  it "should match uname -p on SunOS" do
+    Facter.fact(:kernel).stubs(:value).returns("SunOS")
+    Facter::Util::Resolution.stubs(:exec).with("uname -p").returns("Pinky")
+
+    Facter.fact(:hardwareisa).value.should == "Pinky"
+  end
+
+  it "should match uname -p on FreeBSD" do
+    Facter.fact(:kernel).stubs(:value).returns("FreeBSD")
+    Facter::Util::Resolution.stubs(:exec).with("uname -p").returns("Clyde")
+
+    Facter.fact(:hardwareisa).value.should == "Clyde"
+  end
+end

data/spec/unit/hostname_spec.rb

@@ -1,4 +1,6 @@
-require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
+#!/usr/bin/env rspec
+
+require 'spec_helper'
 
 describe "Hostname facts" do
 

data/spec/unit/id_spec.rb

@@ -1,6 +1,6 @@
-#!/usr/bin/env ruby
+#!/usr/bin/env rspec
 
-require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
+require 'spec_helper'
 
 describe "id fact" do
 

data/spec/unit/interfaces_spec.rb

@@ -1,8 +1,6 @@
-#!/usr/bin/env ruby
+#!/usr/bin/env rspec
 
-require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
-
-require 'facter'
+require 'spec_helper'
 require 'facter/util/ip'
 
 describe "Per Interface IP facts" do

data/spec/unit/ipaddress6_spec.rb

@@ -1,16 +1,13 @@
-#!/usr/bin/env ruby
+#!/usr/bin/env rspec
 
-$basedir = File.expand_path(File.dirname(__FILE__) + '/..')
-require File.join($basedir, 'spec_helper')
-
-require 'facter'
+require 'spec_helper'
 
 def ifconfig_fixture(filename)
-  ifconfig = File.new(File.join($basedir, 'fixtures', 'ifconfig', filename)).read
+  File.read(fixtures('ifconfig', filename))
 end
 
 def netsh_fixture(filename)
-  ifconfig = File.new(File.join($basedir, 'fixtures', 'netsh', filename)).read
+  File.read(fixtures('netsh', filename))
 end
 
 describe "IPv6 address fact" do

data/spec/unit/lsbmajdistrelease_spec.rb

@@ -0,0 +1,13 @@
+#!/usr/bin/env ruby
+
+require 'spec_helper'
+require 'facter'
+
+describe "LSB distribution major release fact" do
+    it "should be derived from lsb_release" do
+        Facter.fact(:kernel).stubs(:value).returns("Linux")
+        Facter.stubs(:value).with(:lsbdistrelease).returns("10.10")
+
+        Facter.fact(:lsbmajdistrelease).value.should == "10"
+    end
+end

data/spec/unit/macaddress_spec.rb

@@ -1,16 +1,13 @@
-#!/usr/bin/env ruby
+#!/usr/bin/env rspec
 
-$basedir = File.expand_path(File.dirname(__FILE__) + '/..')
-require File.join($basedir, 'spec_helper')
-
-require 'facter'
+require 'spec_helper'
 
 def ifconfig_fixture(filename)
-  ifconfig = File.new(File.join($basedir, 'fixtures', 'ifconfig', filename)).read
+  File.read(fixtures('ifconfig', filename))
 end
 
 def netsh_fixture(filename)
-  ifconfig = File.new(File.join($basedir, 'fixtures', 'netsh', filename)).read
+  File.read(fixtures('netsh', filename))
 end
 
 describe "macaddress fact" do

data/spec/unit/memory_spec.rb

@@ -1,8 +1,6 @@
-#!/usr/bin/env ruby
+#!/usr/bin/env rspec
 
-require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
-
-require 'facter'
+require 'spec_helper'
 
 describe "Memory facts" do
   before do
@@ -78,7 +76,7 @@ EOS
     end
 
     it "should return the current memorysize" do
-      Facter.fact(:memorytotal).value.should == "254.94 MB"
+      Facter.fact(:memorysize).value.should == "254.94 MB"
     end
   end
 
@@ -118,7 +116,7 @@ EOS
     end
 
     it "should return the current memorysize" do
-      Facter.fact(:memorytotal).value.should == "237.00 MB"
+      Facter.fact(:memorysize).value.should == "237.00 MB"
     end
   end
 
@@ -147,4 +145,11 @@ EOS
       Facter.fact(:MemoryTotal).value.should == '3.91 GB'
     end
   end
+
+  it "should use the memorysize fact for the memorytotal fact" do
+    Facter.fact("memorysize").expects(:value).once.returns "yay"
+    Facter::Util::Resolution.expects(:exec).never
+    Facter::Memory.expects(:meminfo_number).never
+    Facter.fact("memorytotal").value.should == "yay"
+  end
 end

data/spec/unit/operatingsystem_spec.rb

@@ -1,17 +1,11 @@
-#!/usr/bin/env ruby
+#!/usr/bin/env rspec
 
-require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
-
-require 'facter'
+require 'spec_helper'
 
 describe "Operating System fact" do
 
-  before do
-    Facter.clear
-  end
-
-  after do
-    Facter.clear
+  before :each do
+    FileTest.stubs(:exists?).returns false
   end
 
   it "should default to the kernel name" do
@@ -19,74 +13,112 @@ describe "Operating System fact" do
 
     Facter.fact(:operatingsystem).value.should == "Nutmeg"
   end
-
-  it "should be Solaris for SunOS" do
-     Facter.fact(:kernel).stubs(:value).returns("SunOS")
-
-     Facter.fact(:operatingsystem).value.should == "Solaris"
-  end
-
   it "should be ESXi for VMkernel" do
      Facter.fact(:kernel).stubs(:value).returns("VMkernel")
 
      Facter.fact(:operatingsystem).value.should == "ESXi"
   end
 
-  it "should identify Oracle VM as OVS" do
-    Facter.fact(:kernel).stubs(:value).returns("Linux")
-    Facter.stubs(:value).with(:lsbdistid).returns(nil)
-    FileTest.stubs(:exists?).returns false
+  describe "on Solaris variants" do
+    before :each do
+      Facter.fact(:kernel).stubs(:value).returns("SunOS")
+    end
 
-    FileTest.expects(:exists?).with("/etc/ovs-release").returns true
-    FileTest.expects(:exists?).with("/etc/enterprise-release").returns true
+    it "should be Nexenta if /etc/debian_version is present" do
+      FileTest.expects(:exists?).with("/etc/debian_version").returns true
+      Facter.fact(:operatingsystem).value.should == "Nexenta"
+    end
 
-    Facter.fact(:operatingsystem).value.should == "OVS"
+    it "should be Solaris for SunOS if no other variants match" do
+      Facter.fact(:operatingsystem).value.should == "Solaris"
+    end
   end
-   
-  it "should identify VMWare ESX" do
-    Facter.fact(:kernel).stubs(:value).returns("Linux")
-    Facter.stubs(:value).with(:lsbdistid).returns(nil)
-    FileTest.stubs(:exists?).returns false
-
-    FileTest.expects(:exists?).with("/etc/vmware-release").returns true
-
-    Facter.fact(:operatingsystem).value.should == "VMWareESX"
-  end
-
-  it "should identify Alpine Linux" do
-    Facter.fact(:kernel).stubs(:value).returns("Linux")
-    
-    FileTest.stubs(:exists?).returns false
-    
-    FileTest.expects(:exists?).with("/etc/alpine-release").returns true
-
-    Facter.fact(:operatingsystem).value.should == "Alpine"
-  end
-
-  it "should identify Scientific Linux" do
-    Facter.fact(:kernel).stubs(:value).returns("Linux")
-    FileTest.stubs(:exists?).returns false
-
-    FileTest.expects(:exists?).with("/etc/redhat-release").returns true
-    File.expects(:read).with("/etc/redhat-release").returns("Scientific Linux SLC 5.7 (Boron)")
-    Facter.fact(:operatingsystem).value.should == "Scientific"
-  end
-
-  it "should differentiate between Scientific Linux CERN and Scientific Linux" do
-    Facter.fact(:kernel).stubs(:value).returns("Linux")
-    FileTest.stubs(:exists?).returns false
-
-    FileTest.expects(:exists?).with("/etc/redhat-release").returns true
-    File.expects(:read).with("/etc/redhat-release").returns("Scientific Linux CERN SLC 5.7 (Boron)")
-    Facter.fact(:operatingsystem).value.should == "SLC"
-  end
-
-  it "should identify Ascendos Linux" do
-    Facter.fact(:kernel).stubs(:value).returns("Linux")
-    FileTest.stubs(:exists?).returns false
 
-    FileTest.expects(:exists?).with("/etc/redhat-release").returns true
-    File.expects(:read).with("/etc/redhat-release").returns("Ascendos release 6.0 (Nameless)")
-    Facter.fact(:operatingsystem).value.should == "Ascendos"
+  describe "on Linux" do
+    before :each do
+      Facter.fact(:kernel).stubs(:value).returns("Linux")
+    end
+
+    {
+      "Debian"      => "/etc/debian_version",
+      "Gentoo"      => "/etc/gentoo-release",
+      "Fedora"      => "/etc/fedora-release",
+      "Mandriva"    => "/etc/mandriva-release",
+      "Mandrake"    => "/etc/mandrake-release",
+      "MeeGo"       => "/etc/meego-release",
+      "Archlinux"   => "/etc/arch-release",
+      "OracleLinux" => "/etc/oracle-release",
+      "Alpine"      => "/etc/alpine-release",
+      "VMWareESX"   => "/etc/vmware-release",
+      "Bluewhite64" => "/etc/bluewhite64-version",
+      "Slamd64"     => "/etc/slamd64-version",
+      "Slackware"   => "/etc/slackware-version",
+      "Amazon"      => "/etc/system-release",
+    }.each_pair do |distribution, releasefile|
+      it "should be #{distribution} if #{releasefile} exists" do
+        FileTest.expects(:exists?).with(releasefile).returns true
+        Facter.fact(:operatingsystem).value.should == distribution
+      end
+    end
+
+    describe "depending on LSB release information" do
+      before :each do
+        Facter.collection.loader.load(:lsb)
+      end
+
+      it "on Ubuntu should use the lsbdistid fact" do
+        FileUtils.stubs(:exists?).with("/etc/debian_version").returns true
+
+        Facter.fact(:lsbdistid).expects(:value).returns("Ubuntu")
+        Facter.fact(:operatingsystem).value.should == "Ubuntu"
+      end
+
+    end
+
+
+    # Check distributions that rely on the contents of /etc/redhat-release
+    {
+      "RedHat"     => "Red Hat Enterprise Linux Server release 6.0 (Santiago)",
+      "CentOS"     => "CentOS release 5.6 (Final)",
+      "Scientific" => "Scientific Linux release 6.0 (Carbon)",
+      "SLC"        => "Scientific Linux CERN SLC release 5.7 (Boron)",
+      "Ascendos"   => "Ascendos release 6.0 (Nameless)",
+      "CloudLinux" => "CloudLinux Server release 5.5",
+    }.each_pair do |operatingsystem, string|
+      it "should be #{operatingsystem} based on /etc/redhat-release contents #{string}" do
+        FileTest.expects(:exists?).with("/etc/redhat-release").returns true
+        File.expects(:read).with("/etc/redhat-release").returns string
+
+        Facter.fact(:operatingsystem).value.should == operatingsystem
+      end
+    end
+
+    describe "Oracle variant" do
+      it "should be OVS if /etc/ovs-release exists" do
+        Facter.stubs(:value).with(:lsbdistid)
+        FileTest.expects(:exists?).with("/etc/enterprise-release").returns true
+        FileTest.expects(:exists?).with("/etc/ovs-release").returns true
+        Facter.fact(:operatingsystem).value.should == "OVS"
+      end
+
+      it "should be OEL if /etc/ovs-release doesn't exist" do
+        FileTest.expects(:exists?).with("/etc/enterprise-release").returns true
+        FileTest.expects(:exists?).with("/etc/ovs-release").returns false
+        Facter.fact(:operatingsystem).value.should == "OEL"
+      end
+    end
+
+    it "should identify VMWare ESX" do
+      Facter.stubs(:value).with(:lsbdistid).returns(nil)
+
+      FileTest.expects(:exists?).with("/etc/vmware-release").returns true
+      Facter.fact(:operatingsystem).value.should == "VMWareESX"
+    end
+
+    it "should differentiate between Scientific Linux CERN and Scientific Linux" do
+      FileTest.expects(:exists?).with("/etc/redhat-release").returns true
+      File.expects(:read).with("/etc/redhat-release").returns("Scientific Linux CERN SLC 5.7 (Boron)")
+      Facter.fact(:operatingsystem).value.should == "SLC"
+    end
   end
 end