execute_with_rescue 0.0.1 → 0.0.2

data/spec/core_spec.rb

@@ -1,50 +1,50 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe ExecuteWithRescue::Mixins::Core do
-  describe '#execute_with_rescue' do
+  describe "#execute_with_rescue" do
     let!(:service_instance) { service_class.new }
     def service_call
       service_instance.call
     end
 
-    context 'without a block' do
+    context "without a block" do
       let!(:service_class) { TestServiceWithoutBlockInExecute }
 
       specify do
-        expect { service_call }
-        .to raise_error(LocalJumpError)
+        expect { service_call }.
+          to raise_error(LocalJumpError)
       end
     end
 
-    context 'with private method call' do
+    context "with private method call" do
       let!(:service_class) { TestServiceWithPrivateMethodCallInExecute }
 
       specify do
-        expect { service_call }
-        .to_not raise_error
+        expect { service_call }.
+          to_not raise_error
       end
     end
 
-    context 'without calling rescue_from' do
+    context "without calling rescue_from" do
       let!(:service_class) { TestServiceWithError }
 
       specify do
-        expect { service_call }
-        .to raise_error(StandardError)
+        expect { service_call }.
+          to raise_error(StandardError)
       end
     end
 
-    context 'with calling rescue_from' do
+    context "with calling rescue_from" do
       let!(:service_class) { TestServiceWithRescue }
 
       specify do
-        expect { service_call }
-        .to raise_error(TestServiceWithRescue::CustomError)
+        expect { service_call }.
+          to raise_error(TestServiceWithRescue::CustomError)
       end
 
-      context 'with single hook' do
-        context 'with nothing' do
-          describe 'in before hook' do
+      context "with single hook" do
+        context "with nothing" do
+          describe "in before hook" do
             specify do
               expect do
                 TestService.class_eval do
@@ -53,7 +53,7 @@ describe ExecuteWithRescue::Mixins::Core do
               end.to raise_error(ArgumentError)
             end
           end
-          describe 'in after hook' do
+          describe "in after hook" do
             specify do
               expect do
                 TestService.class_eval do
@@ -64,7 +64,7 @@ describe ExecuteWithRescue::Mixins::Core do
           end
         end
 
-        context 'with symbol of a non-existing method name' do
+        context "with symbol of a non-existing method name" do
           let!(:temp_class) do
             Class.new(TestServiceWithPrivateMethodCallInExecute).tap do |klass|
               klass.class_eval do
@@ -75,71 +75,77 @@ describe ExecuteWithRescue::Mixins::Core do
           let!(:service_class) { temp_class }
 
           specify do
-            expect { service_call }
-            .to raise_error(ExecuteWithRescue::Errors::NoHookMethod)
+            expect { service_call }.
+              to raise_error(ExecuteWithRescue::Errors::NoHookMethod)
           end
         end
 
-        context 'with symbol of an existing method name' do
-          context 'with before hook' do
+        context "with symbol of an existing method name" do
+          context "with before hook" do
             let!(:service_class) { TestServiceWithSymbolBeforeHook }
 
             specify do
-              expect { service_call }
-              .to change{ service_instance.hook_exec_count }.from(0).to(1)
+              expect { service_call }.
+                to change { service_instance.hook_exec_count }.
+                from(0).to(1)
             end
           end
 
-          context 'with after hook' do
+          context "with after hook" do
             let!(:service_class) { TestServiceWithSymbolAfterHook }
 
             specify do
-              expect { service_call }
-              .to change{ service_instance.hook_exec_count }.from(0).to(1)
+              expect { service_call }.
+                to change { service_instance.hook_exec_count }.
+                from(0).to(1)
             end
           end
 
-          context 'with before & after hook' do
+          context "with before & after hook" do
             let!(:service_class) { TestServiceWithSymbolBeforeAfterHook }
 
             specify do
-              expect { service_call }
-              .to change{ service_instance.hook_exec_count }.from(0).to(2)
+              expect { service_call }.
+                to change { service_instance.hook_exec_count }.
+                from(0).to(2)
             end
           end
         end
 
-        context 'with block' do
-          context 'with before hook' do
+        context "with block" do
+          context "with before hook" do
             let!(:service_class) { TestServiceWithBlockBeforeHook }
 
             specify do
-              expect { service_call }
-              .to change{ service_instance.hook_exec_count }.from(0).to(1)
+              expect { service_call }.
+                to change { service_instance.hook_exec_count }.
+                from(0).to(1)
             end
           end
 
-          context 'with after hook' do
+          context "with after hook" do
             let!(:service_class) { TestServiceWithBlockAfterHook }
 
             specify do
-              expect { service_call }
-              .to change{ service_instance.hook_exec_count }.from(0).to(1)
+              expect { service_call }.
+                to change { service_instance.hook_exec_count }.
+                from(0).to(1)
             end
           end
 
-          context 'with before & after hook' do
+          context "with before & after hook" do
             let!(:service_class) { TestServiceWithBlockBeforeAfterHook }
 
             specify do
-              expect { service_call }
-              .to change{ service_instance.hook_exec_count }.from(0).to(2)
+              expect { service_call }.
+                to change { service_instance.hook_exec_count }.
+                from(0).to(2)
             end
           end
         end
 
-        context 'with other type of things' do
-          let!(:temp_class){ Class.new(TestService) }
+        context "with other type of things" do
+          let!(:temp_class) { Class.new(TestService) }
 
           specify do
             expect do
@@ -149,64 +155,64 @@ describe ExecuteWithRescue::Mixins::Core do
         end
       end
 
-      context 'with multiple hooks' do
-        context 'without inheritance' do
+      context "with multiple hooks" do
+        context "without inheritance" do
           let!(:service_class) { TestServiceWithManySymbolBeforeHook }
 
           specify do
-            expect { service_call }
-            .to change{ service_instance.hook_exec_count }.from(0).to(3)
+            expect { service_call }.
+              to change { service_instance.hook_exec_count }.
+              from(0).to(3)
           end
         end
-        context 'with inheritance' do
+        context "with inheritance" do
           let!(:service_class) { TestServiceWithManySymbolBeforeHookInherited }
 
           specify do
-            expect { service_call }
-            .to change{ service_instance.hook_exec_count }.from(0).to(5)
+            expect { service_call }.
+              to change { service_instance.hook_exec_count }.
+              from(0).to(5)
           end
         end
       end
 
-      context 'with tampered internal class attribuite' do
+      context "with tampered internal class attribuite" do
         let!(:temp_class) do
           Class.new(TestServiceWithPrivateMethodCallInExecute).tap do |klass|
             klass.class_eval do
-              _execute_with_rescue_before_hooks << Hash.new
+              _execute_with_rescue_before_hooks << {}
             end
           end
         end
         let!(:service_class) { temp_class }
 
-        specify 'after hooks run in reverse order of the define order' do
-          expect { service_call }
-          .to raise_error(ExecuteWithRescue::Errors::UnsupportedHookValue)
+        specify "after hooks run in reverse order of the define order" do
+          expect { service_call }.
+            to raise_error(ExecuteWithRescue::Errors::UnsupportedHookValue)
         end
       end
 
-
-
-      describe 'after hook execution' do
-        describe 'after an error is raised in block' do
-
+      describe "after hook execution" do
+        describe "after an error is raised in block" do
           let!(:service_class) { TestServiceWithErrorAndAfterHook }
 
-          specify 'after hooks are run after exception is raised' do
+          specify "after hooks are run after exception is raised" do
             expect(service_instance.hook_exec_count).to eq(0)
 
-            expect { service_call }
-            .to raise_error(RuntimeError)
+            expect { service_call }.
+              to raise_error(RuntimeError)
 
             expect(service_instance.hook_exec_count).to eq(1)
           end
         end
 
-        describe 'order' do
+        describe "order" do
           let!(:service_class) { TestServiceWithManyAfterHooks }
 
-          specify 'after hooks run in reverse order of the define order' do
-            expect { service_call }
-            .to change{ service_instance.some_data_array }.from([]).to([2,1])
+          specify "after hooks run in reverse order of the define order" do
+            expect { service_call }.
+              to change { service_instance.some_data_array }.
+              from([]).to([2, 1])
           end
         end
       end

data/spec/fixtures/test_service_classes.rb

@@ -29,7 +29,7 @@ class TestServiceWithError < TestService
 
   def call
     execute_with_rescue do
-      raise StandardError
+      fail StandardError
     end
   end
 end
@@ -41,7 +41,7 @@ class TestServiceWithRescue < TestServiceWithError
   private
 
   def handle_error
-    raise CustomError
+    fail CustomError
   end
 end
 class TestServiceWithHook < TestServiceWithRescue
@@ -56,6 +56,7 @@ class TestServiceWithHook < TestServiceWithRescue
   def handle_error
     # do nothing
   end
+
   def inc_hook_exec_count
     @hook_exec_count += 1
   end
@@ -82,9 +83,11 @@ class TestServiceWithBlockBeforeAfterHook < TestServiceWithHook
 end
 
 class TestServiceWithManySymbolBeforeHook < TestServiceWithHook
-  add_execute_with_rescue_before_hooks(:inc_hook_exec_count,
-                                       :inc_hook_exec_count,
-                                       :inc_hook_exec_count)
+  add_execute_with_rescue_before_hooks(
+    :inc_hook_exec_count,
+    :inc_hook_exec_count,
+    :inc_hook_exec_count,
+  )
 end
 class TestServiceWithManySymbolBeforeHookInherited <
     TestServiceWithManySymbolBeforeHook
@@ -111,9 +114,8 @@ class TestServiceWithManyAfterHooks < TestServiceWithHook
   end
 end
 
-
 class TestServiceWithErrorAndAfterHook < TestServiceWithBlockAfterHook
   def handle_error
-    raise RuntimeError
+    fail RuntimeError
   end
 end

data/spec/spec_helper.rb

@@ -1,14 +1,15 @@
 if ENV["TRAVIS"]
-  require 'coveralls'
+  require "coveralls"
   Coveralls.wear!
 end
 
-require 'execute_with_rescue'
+require "execute_with_rescue"
 
-require 'fixtures/test_service_classes'
-require 'rspec'
+require "fixtures/test_service_classes"
+require "rspec"
+require "rspec/its"
 
-require 'logger'
+require "logger"
 
-RSpec.configure do |config|
+RSpec.configure do
 end

metadata

@@ -1,131 +1,160 @@
 --- !ruby/object:Gem::Specification
 name: execute_with_rescue
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - PikachuEXE
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-03-26 00:00:00.000000000 Z
+date: 2016-12-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 3.2.0
-    - - <
+        version: 4.0.0
+    - - "<"
       - !ruby/object:Gem::Version
-        version: 5.0.0
+        version: 5.1.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 3.2.0
-    - - <
+        version: 4.0.0
+    - - "<"
       - !ruby/object:Gem::Version
-        version: 5.0.0
+        version: 5.1.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.5'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.5'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '10.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '10.0'
 - !ruby/object:Gem::Dependency
   name: appraisal
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.5.2
+        version: '2.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.5.2
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.14.0
+        version: '3.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.14.0
+        version: '3.0'
+- !ruby/object:Gem::Dependency
+  name: rspec-its
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: coveralls
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0.7'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0.7'
 - !ruby/object:Gem::Dependency
   name: gem-release
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0.7'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0.7'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.30'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.30'
 description: |2
-                           Saves your from writing `begin...rescue...ensure...end` everywhere.
-                           This assumes you know how to use `rescue_from` not just within a controller.
+      Saves your from writing `begin...rescue...ensure...end` everywhere.
+      This assumes you know how to use `rescue_from` not just within a controller.
 email:
 - pikachuexe@gmail.com
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .rspec
-- .travis.yml
+- ".gitignore"
+- ".rspec"
+- ".rubocop.yml"
+- ".travis.yml"
 - Appraisals
 - CHANGELOG.md
 - Gemfile
@@ -133,9 +162,10 @@ files:
 - README.md
 - Rakefile
 - execute_with_rescue.gemspec
-- gemfiles/rails_3_2.gemfile
 - gemfiles/rails_4_0.gemfile
 - gemfiles/rails_4_1.gemfile
+- gemfiles/rails_4_2.gemfile
+- gemfiles/rails_5_0.gemfile
 - lib/execute_with_rescue.rb
 - lib/execute_with_rescue/errors.rb
 - lib/execute_with_rescue/mixins/core.rb
@@ -153,17 +183,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.9.3
+      version: 2.1.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: 1.4.0
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.5.2
 signing_key: 
 specification_version: 4
 summary: Execute code without writting rescue in methods with before and after hooks.