execute_with_rescue 0.0.1 → 0.0.2

data/.travis.yml

@@ -1,13 +1,25 @@
+# Send builds to container-based infrastructure
+# http://docs.travis-ci.com/user/workers/container-based-infrastructure/
+sudo: false
 language: ruby
 cache:
-  - bundler
+- bundler
 rvm:
-  - 1.9.3
-  - 2.0.0
-  - 2.1.0
-  - 2.1.1
+  - 2.1.10
+  - 2.2.6
+  - 2.3.3
+  - ruby-head
 gemfile:
-  - gemfiles/rails_3_2.gemfile
   - gemfiles/rails_4_0.gemfile
   - gemfiles/rails_4_1.gemfile
+  - gemfiles/rails_4_2.gemfile
+matrix:
+  fast_finish: true
+  allow_failures:
+    - rvm: ruby-head
+  include:
+  - rvm: 2.3.3
+    gemfile: gemfiles/rails_5_0.gemfile
+  - rvm: ruby-head
+    gemfile: gemfiles/rails_5_0.gemfile
 

data/Appraisals

@@ -1,11 +1,20 @@
-appraise "rails-3-2" do
-  gem "activesupport", "3.2.17"
+appraise "rails_4_0" do
+  version = "~> 4.0.12"
+  gem "activesupport", version
 end
 
-appraise "rails-4-0" do
-  gem "activesupport", "4.0.4"
+appraise "rails_4_1" do
+  version = "~> 4.1.8"
+  gem "activesupport", version
 end
 
-appraise "rails-4-1" do
-  gem "activesupport", "4.1.0.rc1"
+appraise "rails_4_2" do
+  version = "~> 4.2.0"
+  gem "activesupport", version
 end
+
+appraise "rails_5_0" do
+  version = "~> 5.0.0"
+  gem "activesupport", version
+end
+

data/CHANGELOG.md

@@ -1,5 +1,40 @@
-### Changelog
+# Change Log
+All notable changes to this project will be documented in this file.
+This project adheres to [Semantic Versioning](http://semver.org/).
+
+
+## [Unreleased]
+
+### Added
+
+- Nothing
+
+### Changed
+
+- Nothing
+
+### Fixed
+
+- Nothing
+
+
+## [0.0.2] - 2016-12-23
+
+### Changed
+
+- Add support for AR 5.0.x
+- Drop support for AR 3.x
+- Drop support for Ruby < 2.1
+
+
+## 0.0.1 - 2014-03-26
+
+### Added
+
+- Initial Release
+
+
+[0.0.2]: https://github.com/AssetSync/asset_sync/compare/v0.0.2...HEAD
+[Unreleased]: https://github.com/AssetSync/asset_sync/compare/v0.0.1...v0.0.2
 
 
-- **0.0.1**
-  - Initail Release

data/Gemfile

@@ -1,4 +1,4 @@
-source 'https://rubygems.org'
+source "https://rubygems.org"
 
-# Specify your gem's dependencies in execute_with_rescue.gemspec
+# Specify your gem"s dependencies in execute_with_rescue.gemspec
 gemspec

data/README.md

@@ -10,17 +10,13 @@ Calling `airbrake` manually sometimes is the best option, but not all the time.
 I might release another gem for that airbrake adapter.  
 
 
-## Support
-===========
-Tested against:
-- Active Support of version `3.2`, `4.0` and `4.1` (pre-3.2 got wrong dependency & I don't want to support)
-- MRI `1.9.3`, `2.0.0`, `2.1.0`, `2.1.1`
-
-[![Build Status](http://img.shields.io/travis/PikachuEXE/execute_with_rescue.svg)](https://travis-ci.org/PikachuEXE/execute_with_rescue)
-[![Gem Version](http://img.shields.io/gem/v/execute_with_rescue.svg)](http://badge.fury.io/rb/execute_with_rescue)
-[![Dependency Status](http://img.shields.io/gemnasium/PikachuEXE/execute_with_rescue.svg)](https://gemnasium.com/PikachuEXE/execute_with_rescue)
-[![Coverage Status](http://img.shields.io/coveralls/PikachuEXE/execute_with_rescue.svg)](https://coveralls.io/r/PikachuEXE/execute_with_rescue)
-[![Code Climate](http://img.shields.io/codeclimate/github/PikachuEXE/execute_with_rescue.svg)](https://codeclimate.com/github/PikachuEXE/execute_with_rescue)
+## Status
+
+[![Build Status](http://img.shields.io/travis/PikachuEXE/execute_with_rescue.svg?style=flat-square)](https://travis-ci.org/PikachuEXE/execute_with_rescue)
+[![Gem Version](http://img.shields.io/gem/v/execute_with_rescue.svg?style=flat-square)](http://badge.fury.io/rb/execute_with_rescue)
+[![Dependency Status](http://img.shields.io/gemnasium/PikachuEXE/execute_with_rescue.svg?style=flat-square)](https://gemnasium.com/PikachuEXE/execute_with_rescue)
+[![Coverage Status](http://img.shields.io/coveralls/PikachuEXE/execute_with_rescue.svg?style=flat-square)](https://coveralls.io/r/PikachuEXE/execute_with_rescue)
+[![Code Climate](http://img.shields.io/codeclimate/github/PikachuEXE/execute_with_rescue.svg?style=flat-square)](https://codeclimate.com/github/PikachuEXE/execute_with_rescue)
 
 
 ## Installation

data/Rakefile

@@ -1,16 +1,18 @@
-require "bundler/gem_tasks"
-require "rubygems"
-require "bundler/setup"
-
-require "rspec/core/rake_task"
 require "appraisal"
+require "bundler"
+require "rspec/core/rake_task"
+require "rubocop/rake_task"
+
+Bundler::GemHelper.install_tasks
 
 RSpec::Core::RakeTask.new(:spec)
 
+RuboCop::RakeTask.new(:rubocop)
+
 if !ENV["APPRAISAL_INITIALIZED"] && !ENV["TRAVIS"]
   task :default do
-    sh "rake appraisal:install && rake appraisal spec"
+    sh "appraisal install && rake appraisal spec"
   end
 else
-  task :default => :spec
+  task default: [:spec]
 end

data/execute_with_rescue.gemspec

@@ -1,18 +1,21 @@
 # coding: utf-8
-lib = File.expand_path('../lib', __FILE__)
+lib = File.expand_path("../lib", __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require 'execute_with_rescue/version'
+require "execute_with_rescue/version"
 
 Gem::Specification.new do |spec|
   spec.name          = "execute_with_rescue"
   spec.version       = ExecuteWithRescue::VERSION
   spec.authors       = ["PikachuEXE"]
   spec.email         = ["pikachuexe@gmail.com"]
-  spec.summary       = %q{Execute code without writting rescue in methods with before and after hooks. You can also create some extensions yourself.}
-  spec.description   = <<-DESC
-                         Saves your from writing `begin...rescue...ensure...end` everywhere.
-                         This assumes you know how to use `rescue_from` not just within a controller.
-                       DESC
+  spec.summary       = <<-SUMMARY
+    Execute code without writting rescue in methods with before and after hooks.
+    You can also create some extensions yourself.
+  SUMMARY
+  spec.description = <<-DESC
+    Saves your from writing `begin...rescue...ensure...end` everywhere.
+    This assumes you know how to use `rescue_from` not just within a controller.
+  DESC
   spec.homepage      = "http://github.com/PikachuEXE/execute_with_rescue"
   spec.license       = "MIT"
 
@@ -21,16 +24,18 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "activesupport", ">= 3.2.0", "< 5.0.0"
+  spec.add_dependency "activesupport", ">= 4.0.0", "< 5.1.0"
 
   spec.add_development_dependency "bundler", "~> 1.5"
-  spec.add_development_dependency "rake"
-  spec.add_development_dependency "appraisal", ">= 0.5.2"
-  spec.add_development_dependency "rspec", "~> 2.14.0"
+  spec.add_development_dependency "rake", "~> 10.0"
+  spec.add_development_dependency "appraisal", "~> 2.0"
+  spec.add_development_dependency "rspec", "~> 3.0"
+  spec.add_development_dependency "rspec-its", "~> 1.0"
   spec.add_development_dependency "coveralls", ">= 0.7"
   spec.add_development_dependency "gem-release", ">= 0.7"
+  spec.add_development_dependency "rubocop", "~> 0.30"
 
-  spec.required_ruby_version = ">= 1.9.3"
+  spec.required_ruby_version = ">= 2.1.0"
 
   spec.required_rubygems_version = ">= 1.4.0"
 end

data/gemfiles/rails_4_0.gemfile

@@ -2,6 +2,6 @@
 
 source "https://rubygems.org"
 
-gem "activesupport", "4.0.4"
+gem "activesupport", "~> 4.0.12"
 
-gemspec :path=>"../"
+gemspec :path => "../"

data/gemfiles/rails_4_1.gemfile

@@ -2,6 +2,6 @@
 
 source "https://rubygems.org"
 
-gem "activesupport", "4.1.0.rc1"
+gem "activesupport", "~> 4.1.8"
 
-gemspec :path=>"../"
+gemspec :path => "../"

data/gemfiles/{rails_3_2.gemfile → rails_4_2.gemfile}

@@ -2,6 +2,6 @@
 
 source "https://rubygems.org"
 
-gem "activesupport", "3.2.17"
+gem "activesupport", "~> 4.2.0"
 
-gemspec :path=>"../"
+gemspec :path => "../"

data/gemfiles/rails_5_0.gemfile

@@ -0,0 +1,7 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "activesupport", "~> 5.0.0"
+
+gemspec :path => "../"

data/lib/execute_with_rescue/mixins/core.rb

@@ -1,8 +1,8 @@
-require 'active_support/concern'
-require 'active_support/rescuable'
-require 'active_support/core_ext/class/attribute'
+require "active_support/concern"
+require "active_support/rescuable"
+require "active_support/core_ext/class/attribute"
 
-require 'execute_with_rescue/errors'
+require "execute_with_rescue/errors"
 
 module ExecuteWithRescue
   module Mixins
@@ -13,13 +13,17 @@ module ExecuteWithRescue
         include ActiveSupport::Rescuable
 
         # Use active support or inheritance will be broken
-        class_attribute :_execute_with_rescue_before_hooks,
-                        instance_reader: true,
-                        instance_writer: false
+        class_attribute(
+          :_execute_with_rescue_before_hooks,
+          instance_reader: true,
+          instance_writer: false,
+        )
         self._execute_with_rescue_before_hooks = []
-        class_attribute :_execute_with_rescue_after_hooks,
-                        instance_reader: true,
-                        instance_writer: false
+        class_attribute(
+          :_execute_with_rescue_after_hooks,
+          instance_reader: true,
+          instance_writer: false,
+        )
         self._execute_with_rescue_after_hooks = []
 
         class << self
@@ -45,14 +49,16 @@ module ExecuteWithRescue
             # Must use setter to avoid changing parent setting
             self._execute_with_rescue_before_hooks =
               [
-                self._execute_with_rescue_before_hooks,
+                _execute_with_rescue_before_hooks,
                 # Add method names first, block later
                 method_names,
                 block,
               ].flatten.compact
           end
-          alias_method :add_execute_with_rescue_before_hook,
-                       :add_execute_with_rescue_before_hooks
+          alias_method(
+            :add_execute_with_rescue_before_hook,
+            :add_execute_with_rescue_before_hooks,
+          )
 
           # Pass method names or/and a block to be executed after yield
           # Similar to add_execute_with_rescue_before_hooks
@@ -64,23 +70,25 @@ module ExecuteWithRescue
             # Must use setter to avoid changing parent setting
             self._execute_with_rescue_after_hooks =
               [
-                self._execute_with_rescue_after_hooks,
+                _execute_with_rescue_after_hooks,
                 # Add method names first, block later
                 method_names,
                 block,
               ].flatten.compact
           end
-          alias_method :add_execute_with_rescue_after_hook,
-                       :add_execute_with_rescue_after_hooks
+          alias_method(
+            :add_execute_with_rescue_after_hook,
+            :add_execute_with_rescue_after_hooks,
+          )
 
-          # @private
+          # @api private
           # @discuss
           #   Should this moved into another module?
           #   (without being mixed in)
           def _validate_execute_with_rescue_hook!(method_names, block)
-            raise ArgumentError if (method_names.empty? && block.nil?)
-            raise ExecuteWithRescue::Errors::UnsupportedHookValue unless
-              method_names.all?{|m| m.is_a?(Symbol)}
+            fail ArgumentError if method_names.empty? && block.nil?
+            fail ExecuteWithRescue::Errors::UnsupportedHookValue unless
+              method_names.all? { |m| m.is_a?(Symbol) }
           end
         end
       end
@@ -91,7 +99,7 @@ module ExecuteWithRescue
       # after you have call `rescue_from` at class level
       # This saves you from typing:
       # ```
-      # being
+      # begin
       #   # Some code that might cause exception
       # rescue
       #   rescue_with_handler(exception) || raise
@@ -102,6 +110,8 @@ module ExecuteWithRescue
       # You can use `alias_method` to create a shorter alias, I use `execute`
       # But some gem might use that name already, so be careful
       #
+      # @api
+      #
       # @param block [Proc]
       #   a block to be executed
       #
@@ -129,44 +139,46 @@ module ExecuteWithRescue
         _run_execute_with_rescue_before_hooks
         yield
       rescue Exception => exception
-        rescue_with_handler(exception) || raise
+        rescue_with_handler(exception) || fail
       ensure
         _run_execute_with_rescue_after_hooks
       end
 
-      # @private
+      # @api private
       def _run_execute_with_rescue_before_hooks
         _execute_with_rescue_before_hooks.each do |before_hook|
           _run_execute_with_rescue_hook(before_hook)
         end
       end
 
-      # @private
+      # @api private
       def _run_execute_with_rescue_after_hooks
-        _execute_with_rescue_after_hooks.reverse.each do |after_hook|
+        _execute_with_rescue_after_hooks.reverse_each do |after_hook|
           _run_execute_with_rescue_hook(after_hook)
         end
       end
 
-      # @private
+      # @api private
       def _run_execute_with_rescue_hook(method_name_or_block)
         case method_name_or_block
         when Symbol
-          begin
-            self.send(method_name_or_block)
-          rescue NoMethodError
-            raise ExecuteWithRescue::Errors::NoHookMethod,
-                  "method `#{method_name_or_block}` does not exists"
-          end
-        # block are converted to Proc as argument
+          _run_execute_with_rescue_hook_with_symbol(method_name_or_block)
         when Proc
+          # block are converted to Proc as argument
           instance_eval(&method_name_or_block)
         else
           # This should not happen unless someone tamper the class attribute
           # without using the provided methods
-          raise ExecuteWithRescue::Errors::UnsupportedHookValue
+          fail ExecuteWithRescue::Errors::UnsupportedHookValue
         end
       end
+
+      def _run_execute_with_rescue_hook_with_symbol(method_name)
+        send(method_name)
+      rescue NoMethodError
+        fail ExecuteWithRescue::Errors::NoHookMethod,
+          "method `#{method_name}` does not exists"
+      end
     end
   end
 end

data/lib/execute_with_rescue/version.rb

@@ -1,3 +1,3 @@
 module ExecuteWithRescue
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

data/lib/execute_with_rescue.rb

@@ -1,6 +1,6 @@
-require 'execute_with_rescue/version'
-require 'execute_with_rescue/errors'
-require 'execute_with_rescue/mixins/core'
+require "execute_with_rescue/version"
+require "execute_with_rescue/errors"
+require "execute_with_rescue/mixins/core"
 
 module ExecuteWithRescue
 end