excellent 1.5.4

data/spec/checks/rails/validations_check_spec.rb

@@ -0,0 +1,81 @@
+require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
+
+describe Simplabs::Excellent::Checks::Rails::ValidationsCheck do
+
+  before do
+    @excellent = Simplabs::Excellent::Runner.new(Simplabs::Excellent::Checks::Rails::ValidationsCheck.new)
+  end
+
+  describe '#evaluate' do
+
+    it 'should ignore classes that are not active record models' do
+      code = <<-END
+        class Test
+        end
+      END
+      @excellent.check_code(code)
+      warnings = @excellent.warnings
+
+      warnings.should be_empty
+    end
+
+    it 'should reject an active record model that does not validate anything' do
+      code = <<-END
+        class User < ActiveRecord::Base
+        end
+      END
+      @excellent.check_code(code)
+      warnings = @excellent.warnings
+
+      warnings.should_not be_empty
+      warnings[0].info.should        == { :class => 'User' }
+      warnings[0].line_number.should == 1
+      warnings[0].message.should     == 'User does not validate any attributes.'
+    end
+
+    it 'should accept an active record model that validates attributes using a macro method' do
+      code = <<-END
+        class User < ActiveRecord::Base
+          validates_presence_of :login
+        end
+      END
+      @excellent.check_code(code)
+      warnings = @excellent.warnings
+
+      warnings.should be_empty
+    end
+
+    %(validate validate_on_create validate_on_update).each do |method|
+
+      it "should accept an active record model that validates attribute by overriding #{method}" do
+        code = <<-END
+          class User < ActiveRecord::Base
+            def #{method}
+            end
+          end
+        END
+        @excellent.check_code(code)
+        warnings = @excellent.warnings
+
+        warnings.should be_empty
+      end
+
+    end
+
+    it 'should also work with namespaced models' do
+      code = <<-END
+        class Backend::User < ActiveRecord::Base
+        end
+      END
+      @excellent.check_code(code)
+      warnings = @excellent.warnings
+
+      warnings.should_not be_empty
+      warnings[0].info.should        == { :class => 'Backend::User' }
+      warnings[0].line_number.should == 1
+      warnings[0].message.should     == 'Backend::User does not validate any attributes.'
+    end
+
+  end
+
+end

data/spec/checks/singleton_variable_check_spec.rb

@@ -0,0 +1,66 @@
+require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
+
+describe Simplabs::Excellent::Checks::SingletonVariableCheck do
+
+  before(:each) do
+    @excellent = Simplabs::Excellent::Runner.new(Simplabs::Excellent::Checks::SingletonVariableCheck.new)
+  end
+
+  describe '#evaluate' do
+
+    it 'should reject singleton variables' do
+      code = <<-END
+        @@foo
+      END
+      @excellent.check_code(code)
+      warnings = @excellent.warnings
+
+      warnings.should_not be_empty
+      warnings[0].info.should        == { :variable => 'foo' }
+      warnings[0].line_number.should == 2
+      warnings[0].message.should     == 'Singleton variable foo used.'
+    end
+
+    it 'should also work for namespaced classes' do
+      code = <<-END
+        module Outer
+          module Inner
+            class Class
+              @@foo
+            end
+          end
+        end
+      END
+      @excellent.check_code(code)
+      warnings = @excellent.warnings
+
+      warnings.should_not be_empty
+      warnings[0].info.should        == { :variable => 'Outer::Inner::Class.foo' }
+      warnings[0].line_number.should == 5
+      warnings[0].message.should     == 'Singleton variable Outer::Inner::Class.foo used.'
+    end
+
+    it 'should also work for singleton variables that occur within methods' do
+      code = <<-END
+        module Outer
+          module Inner
+            class Class
+              def method
+                @@foo
+              end
+            end
+          end
+        end
+      END
+      @excellent.check_code(code)
+      warnings = @excellent.warnings
+
+      warnings.should_not be_empty
+      warnings[0].info.should        == { :variable => 'Outer::Inner::Class.foo' }
+      warnings[0].line_number.should == 6
+      warnings[0].message.should     == 'Singleton variable Outer::Inner::Class.foo used.'
+    end
+
+  end
+
+end

data/spec/extensions/string_spec.rb

@@ -0,0 +1,13 @@
+require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
+
+describe String do
+
+  describe '#underscore' do
+
+    it 'should correctly add underscores to "AbcMetricMethodCheck"' do
+      'AbcMetricMethodCheck'.underscore.should == 'abc_metric_method_check'
+    end
+
+  end
+
+end

data/spec/spec_helper.rb

@@ -0,0 +1,13 @@
+$LOAD_PATH.unshift(File.expand_path(File.dirname(__FILE__) + "/../lib"))
+
+require 'rubygems'
+require 'spec'
+require 'simplabs/excellent'
+
+begin
+  require 'ruby-debug'
+  Debugger.start
+  Debugger.settings[:autoeval] = true if Debugger.respond_to?(:settings)
+rescue LoadError
+  # ruby-debug wasn't available so neither can the debugging be
+end

metadata

@@ -0,0 +1,189 @@
+--- !ruby/object:Gem::Specification 
+name: excellent
+version: !ruby/object:Gem::Version 
+  version: 1.5.4
+platform: ruby
+authors: 
+- Marco Otte-Witte
+autorequire: 
+bindir: bin
+cert_chain: []
+
+date: 2009-08-05 00:00:00 +02:00
+default_executable: 
+dependencies: 
+- !ruby/object:Gem::Dependency 
+  name: ruby_parser
+  type: :runtime
+  version_requirement: 
+  version_requirements: !ruby/object:Gem::Requirement 
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        version: "2.0"
+    version: 
+- !ruby/object:Gem::Dependency 
+  name: sexp_processor
+  type: :runtime
+  version_requirement: 
+  version_requirements: !ruby/object:Gem::Requirement 
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        version: "3.0"
+    version: 
+- !ruby/object:Gem::Dependency 
+  name: facets
+  type: :runtime
+  version_requirement: 
+  version_requirements: !ruby/object:Gem::Requirement 
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        version: "2.7"
+    version: 
+description: 
+email: marco.otte-witte@simplabs.com
+executables: 
+- excellent
+extensions: []
+
+extra_rdoc_files: []
+
+files: 
+- History.txt
+- README.rdoc
+- VERSION.yml
+- bin/excellent
+- lib/simplabs/excellent/checks/abc_metric_method_check.rb
+- lib/simplabs/excellent/checks/assignment_in_conditional_check.rb
+- lib/simplabs/excellent/checks/base.rb
+- lib/simplabs/excellent/checks/case_missing_else_check.rb
+- lib/simplabs/excellent/checks/class_line_count_check.rb
+- lib/simplabs/excellent/checks/class_name_check.rb
+- lib/simplabs/excellent/checks/control_coupling_check.rb
+- lib/simplabs/excellent/checks/cyclomatic_complexity_block_check.rb
+- lib/simplabs/excellent/checks/cyclomatic_complexity_check.rb
+- lib/simplabs/excellent/checks/cyclomatic_complexity_method_check.rb
+- lib/simplabs/excellent/checks/empty_rescue_body_check.rb
+- lib/simplabs/excellent/checks/flog_block_check.rb
+- lib/simplabs/excellent/checks/flog_check.rb
+- lib/simplabs/excellent/checks/flog_class_check.rb
+- lib/simplabs/excellent/checks/flog_method_check.rb
+- lib/simplabs/excellent/checks/for_loop_check.rb
+- lib/simplabs/excellent/checks/global_variable_check.rb
+- lib/simplabs/excellent/checks/line_count_check.rb
+- lib/simplabs/excellent/checks/method_line_count_check.rb
+- lib/simplabs/excellent/checks/method_name_check.rb
+- lib/simplabs/excellent/checks/module_line_count_check.rb
+- lib/simplabs/excellent/checks/module_name_check.rb
+- lib/simplabs/excellent/checks/name_check.rb
+- lib/simplabs/excellent/checks/nested_iterators_check.rb
+- lib/simplabs/excellent/checks/parameter_number_check.rb
+- lib/simplabs/excellent/checks/rails/attr_accessible_check.rb
+- lib/simplabs/excellent/checks/rails/attr_protected_check.rb
+- lib/simplabs/excellent/checks/rails/custom_initialize_method_check.rb
+- lib/simplabs/excellent/checks/rails/instance_var_in_partial_check.rb
+- lib/simplabs/excellent/checks/rails/params_hash_in_view_check.rb
+- lib/simplabs/excellent/checks/rails/session_hash_in_view_check.rb
+- lib/simplabs/excellent/checks/rails/validations_check.rb
+- lib/simplabs/excellent/checks/rails.rb
+- lib/simplabs/excellent/checks/singleton_variable_check.rb
+- lib/simplabs/excellent/checks.rb
+- lib/simplabs/excellent/command_line_runner.rb
+- lib/simplabs/excellent/extensions/sexp.rb
+- lib/simplabs/excellent/extensions/string.rb
+- lib/simplabs/excellent/formatters/base.rb
+- lib/simplabs/excellent/formatters/html.rb
+- lib/simplabs/excellent/formatters/text.rb
+- lib/simplabs/excellent/formatters.rb
+- lib/simplabs/excellent/parsing/abc_measure.rb
+- lib/simplabs/excellent/parsing/block_context.rb
+- lib/simplabs/excellent/parsing/call_context.rb
+- lib/simplabs/excellent/parsing/case_context.rb
+- lib/simplabs/excellent/parsing/class_context.rb
+- lib/simplabs/excellent/parsing/code_processor.rb
+- lib/simplabs/excellent/parsing/conditional_context.rb
+- lib/simplabs/excellent/parsing/cvar_context.rb
+- lib/simplabs/excellent/parsing/cyclomatic_complexity_measure.rb
+- lib/simplabs/excellent/parsing/flog_measure.rb
+- lib/simplabs/excellent/parsing/for_loop_context.rb
+- lib/simplabs/excellent/parsing/gvar_context.rb
+- lib/simplabs/excellent/parsing/if_context.rb
+- lib/simplabs/excellent/parsing/ivar_context.rb
+- lib/simplabs/excellent/parsing/method_context.rb
+- lib/simplabs/excellent/parsing/module_context.rb
+- lib/simplabs/excellent/parsing/parser.rb
+- lib/simplabs/excellent/parsing/resbody_context.rb
+- lib/simplabs/excellent/parsing/scopeable.rb
+- lib/simplabs/excellent/parsing/sexp_context.rb
+- lib/simplabs/excellent/parsing/singleton_method_context.rb
+- lib/simplabs/excellent/parsing/until_context.rb
+- lib/simplabs/excellent/parsing/while_context.rb
+- lib/simplabs/excellent/parsing.rb
+- lib/simplabs/excellent/rake/excellent_task.rb
+- lib/simplabs/excellent/rake.rb
+- lib/simplabs/excellent/runner.rb
+- lib/simplabs/excellent/warning.rb
+- lib/simplabs/excellent.rb
+- spec/checks/abc_metric_method_check_spec.rb
+- spec/checks/assignment_in_conditional_check_spec.rb
+- spec/checks/case_missing_else_check_spec.rb
+- spec/checks/class_line_count_check_spec.rb
+- spec/checks/class_name_check_spec.rb
+- spec/checks/control_coupling_check_spec.rb
+- spec/checks/cyclomatic_complexity_block_check_spec.rb
+- spec/checks/cyclomatic_complexity_method_check_spec.rb
+- spec/checks/empty_rescue_body_check_spec.rb
+- spec/checks/flog_block_check_spec.rb
+- spec/checks/flog_class_check_spec.rb
+- spec/checks/flog_method_check_spec.rb
+- spec/checks/for_loop_check_spec.rb
+- spec/checks/global_variable_check_spec.rb
+- spec/checks/method_line_count_check_spec.rb
+- spec/checks/method_name_check_spec.rb
+- spec/checks/module_line_count_check_spec.rb
+- spec/checks/module_name_check_spec.rb
+- spec/checks/nested_iterators_check_spec.rb
+- spec/checks/parameter_number_check_spec.rb
+- spec/checks/rails/attr_accessible_check_spec.rb
+- spec/checks/rails/attr_protected_check_spec.rb
+- spec/checks/rails/custom_initialize_method_check_spec.rb
+- spec/checks/rails/instance_var_in_partial_check_spec.rb
+- spec/checks/rails/params_hash_in_view_check_spec.rb
+- spec/checks/rails/session_hash_in_view_check_spec.rb
+- spec/checks/rails/validations_check_spec.rb
+- spec/checks/singleton_variable_check_spec.rb
+- spec/extensions/string_spec.rb
+- spec/spec_helper.rb
+has_rdoc: true
+homepage: http://github.com/simplabs/excellent
+licenses: []
+
+post_install_message: 
+rdoc_options: 
+- --inline-source
+- --charset=UTF-8
+require_paths: 
+- lib
+required_ruby_version: !ruby/object:Gem::Requirement 
+  requirements: 
+  - - ">="
+    - !ruby/object:Gem::Version 
+      version: "0"
+  version: 
+required_rubygems_version: !ruby/object:Gem::Requirement 
+  requirements: 
+  - - ">="
+    - !ruby/object:Gem::Version 
+      version: "0"
+  version: 
+requirements: []
+
+rubyforge_project: 
+rubygems_version: 1.3.5
+signing_key: 
+specification_version: 2
+summary: Source Code analysis gem for Ruby and Rails
+test_files: []
+