excellent 1.5.4

data/spec/checks/nested_iterators_check_spec.rb

@@ -0,0 +1,44 @@
+require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
+
+describe Simplabs::Excellent::Checks::NestedIteratorsCheck do
+
+  before do
+    @excellent = Simplabs::Excellent::Runner.new(Simplabs::Excellent::Checks::NestedIteratorsCheck.new)
+  end
+
+  describe '#evaluate' do
+
+    it 'should reject a block inside a block' do
+      code = <<-END
+        method1 do
+          method2 do
+          end
+        end
+      END
+      @excellent.check_code(code)
+      warnings = @excellent.warnings
+
+      warnings.should_not be_empty
+      warnings[0].info.should        == { :block => 'block', :parent => 'block' }
+      warnings[0].line_number.should == 2
+      warnings[0].message.should     == 'block inside of block.'
+    end
+
+    it 'should accept 2 blocks inside a method that are not nested' do
+      code = <<-END
+        def method
+          method1 do
+          end
+          method2 do
+          end
+        end
+      END
+      @excellent.check_code(code)
+      warnings = @excellent.warnings
+
+      warnings.should be_empty
+    end
+
+  end
+
+end

data/spec/checks/parameter_number_check_spec.rb

@@ -0,0 +1,97 @@
+require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
+
+describe Simplabs::Excellent::Checks::ParameterNumberCheck do
+
+  before(:each) do
+    @excellent = Simplabs::Excellent::Runner.new(Simplabs::Excellent::Checks::ParameterNumberCheck.new({ :threshold => 1 }))
+  end
+
+  describe '#evaluate' do
+
+    it 'should accept methods with less parameters than the threshold' do
+      code = <<-END
+        def zero_parameter_method
+        end
+      END
+      @excellent.check_code(code)
+
+      @excellent.warnings.should be_empty
+    end
+
+    it 'should accept methods with the same number of parameters as the threshold' do
+      code = <<-END
+        def one_parameter_method(first_parameter)
+        end
+      END
+      @excellent.check_code(code)
+
+      @excellent.warnings.should be_empty
+    end
+
+    it 'should reject methods with more parameters than the threshold' do
+      code = <<-END
+        def two_parameter_method(first_parameter, second_parameter)
+        end
+      END
+
+      verify_warning_found(code, 'two_parameter_method')
+    end
+
+    it 'should work with default values on parameters' do
+      code = <<-END
+        def two_parameter_method(first_parameter = 1, second_parameter = 2)
+        end
+      END
+
+      verify_warning_found(code, 'two_parameter_method')
+    end
+
+    it 'should work with methods defined on objects' do
+      code = <<-END
+        def object.two_parameter_method(first_parameter = 1, second_parameter = 2)
+        end
+      END
+
+      verify_warning_found(code, 'object.two_parameter_method')
+    end
+
+    it 'should work with methods defined directly on classes' do
+      code = <<-END
+        def Class.two_parameter_method(first_parameter = 1, second_parameter = 2)
+        end
+      END
+
+      verify_warning_found(code, 'Class.two_parameter_method')
+    end
+
+    it 'should reject yield calls with more parameters than the threshold' do
+      code = <<-END
+        two_parameter_method do |first_parameter, second_parameter|
+        end
+      END
+
+      verify_warning_found(code, 'block')
+    end
+
+    it 'should reject yield calls on a receiver with more parameters than the threshold' do
+      code = <<-END
+        receiver.two_parameter_method do |first_parameter, second_parameter|
+        end
+      END
+
+      verify_warning_found(code, 'block')
+    end
+
+  end
+
+  def verify_warning_found(code, name)
+    @excellent.check_code(code)
+    warnings = @excellent.warnings
+
+    warnings.should_not be_empty
+    warnings[0].info.should        == { :method => name, :parameters => 2 }
+    warnings[0].line_number.should == 1
+    warnings[0].message.should     == "#{name} has 2 parameters."
+  end
+
+end

data/spec/checks/rails/attr_accessible_check_spec.rb

@@ -0,0 +1,79 @@
+require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
+
+describe Simplabs::Excellent::Checks::Rails::AttrAccessibleCheck do
+
+  before do
+    @excellent = Simplabs::Excellent::Runner.new(Simplabs::Excellent::Checks::Rails::AttrAccessibleCheck.new)
+  end
+
+  describe '#evaluate' do
+
+    it 'should ignore classes that are not active record models' do
+      code = <<-END
+        class Test
+        end
+      END
+      @excellent.check_code(code)
+      warnings = @excellent.warnings
+
+      warnings.should be_empty
+    end
+
+    it 'should reject an active record model that does not specify attr_accessible' do
+      code = <<-END
+        class User < ActiveRecord::Base
+        end
+      END
+      @excellent.check_code(code)
+      warnings = @excellent.warnings
+
+      warnings.should_not be_empty
+      warnings[0].info.should        == { :class => 'User' }
+      warnings[0].line_number.should == 1
+      warnings[0].message.should     == 'User does not specify attr_accessible.'
+    end
+
+    it 'should reject an active record model that does specify attr_protected' do
+      code = <<-END
+        class User < ActiveRecord::Base
+          attr_protected :first_name
+        end
+      END
+      @excellent.check_code(code)
+      warnings = @excellent.warnings
+
+      warnings.should_not be_empty
+      warnings[0].info.should        == { :class => 'User' }
+      warnings[0].line_number.should == 1
+      warnings[0].message.should     == 'User does not specify attr_accessible.'
+    end
+
+    it 'should accept an active record model that does specify attr_accessible' do
+      code = <<-END
+        class User < ActiveRecord::Base
+          attr_accessible :first_name
+        end
+      END
+      @excellent.check_code(code)
+      warnings = @excellent.warnings
+
+      warnings.should be_empty
+    end
+
+    it 'should also work with namespaced models' do
+      code = <<-END
+        class Backend::User < ActiveRecord::Base
+        end
+      END
+      @excellent.check_code(code)
+      warnings = @excellent.warnings
+
+      warnings.should_not be_empty
+      warnings[0].info.should        == { :class => 'Backend::User' }
+      warnings[0].line_number.should == 1
+      warnings[0].message.should     == 'Backend::User does not specify attr_accessible.'
+    end
+
+  end
+
+end

data/spec/checks/rails/attr_protected_check_spec.rb

@@ -0,0 +1,77 @@
+require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
+
+describe Simplabs::Excellent::Checks::Rails::AttrProtectedCheck do
+
+  before do
+    @excellent = Simplabs::Excellent::Runner.new(Simplabs::Excellent::Checks::Rails::AttrProtectedCheck.new)
+  end
+
+  describe '#evaluate' do
+
+    it 'should ignore classes that are not active record models' do
+      code = <<-END
+        class Test
+        end
+      END
+      @excellent.check_code(code)
+      warnings = @excellent.warnings
+
+      warnings.should be_empty
+    end
+
+    it 'should reject an active record model that does specify attr_protected' do
+      code = <<-END
+        class User < ActiveRecord::Base
+          attr_protected :first_name
+        end
+      END
+      @excellent.check_code(code)
+      warnings = @excellent.warnings
+
+      warnings.should_not be_empty
+      warnings[0].info.should        == { :class => 'User' }
+      warnings[0].line_number.should == 1
+      warnings[0].message.should     == 'User specifies attr_protected.'
+    end
+
+    it 'should accept an active record model that does specify attr_accessible' do
+      code = <<-END
+        class User < ActiveRecord::Base
+          attr_accessible :first_name
+        end
+      END
+      @excellent.check_code(code)
+      warnings = @excellent.warnings
+
+      warnings.should be_empty
+    end
+
+    it 'should accept an active record model that specifies neither attr_accessible not attr_protected' do
+      code = <<-END
+        class User < ActiveRecord::Base
+        end
+      END
+      @excellent.check_code(code)
+      warnings = @excellent.warnings
+
+      warnings.should be_empty
+    end
+
+    it 'should also work with namespaced models' do
+      code = <<-END
+        class Backend::User < ActiveRecord::Base
+          attr_protected :first_name
+        end
+      END
+      @excellent.check_code(code)
+      warnings = @excellent.warnings
+
+      warnings.should_not be_empty
+      warnings[0].info.should        == { :class => 'Backend::User' }
+      warnings[0].line_number.should == 1
+      warnings[0].message.should     == 'Backend::User specifies attr_protected.'
+    end
+
+  end
+
+end

data/spec/checks/rails/custom_initialize_method_check_spec.rb

@@ -0,0 +1,58 @@
+require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
+
+describe Simplabs::Excellent::Checks::Rails::CustomInitializeMethodCheck do
+
+  before do
+    @excellent = Simplabs::Excellent::Runner.new(Simplabs::Excellent::Checks::Rails::CustomInitializeMethodCheck.new)
+  end
+
+  describe '#evaluate' do
+
+    it 'should ignore classes that are not active record models' do
+      code = <<-END
+        class Test
+          def initialize
+          end
+        end
+      END
+      @excellent.check_code(code)
+      warnings = @excellent.warnings
+
+      warnings.should be_empty
+    end
+
+    it 'should reject an active record model that defines initialize' do
+      code = <<-END
+        class User < ActiveRecord::Base
+          def initialize
+          end
+        end
+      END
+      @excellent.check_code(code)
+      warnings = @excellent.warnings
+
+      warnings.should_not be_empty
+      warnings[0].info.should        == { :class => 'User' }
+      warnings[0].line_number.should == 1
+      warnings[0].message.should     == 'User defines initialize method.'
+    end
+
+    it 'should also work with namespaced models' do
+      code = <<-END
+        class Backend::User < ActiveRecord::Base
+          def initialize
+          end
+        end
+      END
+      @excellent.check_code(code)
+      warnings = @excellent.warnings
+
+      warnings.should_not be_empty
+      warnings[0].info.should        == { :class => 'Backend::User' }
+      warnings[0].line_number.should == 1
+      warnings[0].message.should     == 'Backend::User defines initialize method.'
+    end
+
+  end
+
+end

data/spec/checks/rails/instance_var_in_partial_check_spec.rb

@@ -0,0 +1,40 @@
+require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
+
+describe Simplabs::Excellent::Checks::Rails::InstanceVarInPartialCheck do
+
+  before do
+    @excellent = Simplabs::Excellent::Runner.new(Simplabs::Excellent::Checks::Rails::InstanceVarInPartialCheck.new)
+  end
+
+  describe '#evaluate' do
+
+    it 'should accept partials that do not use instance variables' do
+      code = <<-END
+        <div>
+          <%= 'some text' %>
+        </div>
+      END
+      @excellent.check('_dummy-file.html.erb', code)
+      warnings = @excellent.warnings
+
+      warnings.should be_empty
+    end
+
+    it 'should reject partials that use instance variables' do
+      code = <<-END
+        <div>
+          <%= @ivar %>
+        </div>
+      END
+      @excellent.check('_dummy-file.html.erb', code)
+      warnings = @excellent.warnings
+
+      warnings.should_not be_empty
+      warnings[0].info.should        == { :variable => 'ivar' }
+      warnings[0].line_number.should == 2
+      warnings[0].message.should     == 'Instance variable ivar used in partial.'
+    end
+
+  end
+
+end

data/spec/checks/rails/params_hash_in_view_check_spec.rb

@@ -0,0 +1,40 @@
+require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
+
+describe Simplabs::Excellent::Checks::Rails::ParamsHashInViewCheck do
+
+  before do
+    @excellent = Simplabs::Excellent::Runner.new(Simplabs::Excellent::Checks::Rails::ParamsHashInViewCheck.new)
+  end
+
+  describe '#evaluate' do
+
+    it 'should accept views that do not use the params hash' do
+      code = <<-END
+        <div>
+          <%= 'some text' %>
+        </div>
+      END
+      @excellent.check('dummy-file.html.erb', code)
+      warnings = @excellent.warnings
+
+      warnings.should be_empty
+    end
+
+    it 'should reject views that use the params hash' do
+      code = <<-END
+        <div>
+          <%= params[:q] %>
+        </div>
+      END
+      @excellent.check('dummy-file.html.erb', code)
+      warnings = @excellent.warnings
+
+      warnings.should_not be_empty
+      warnings[0].info.should        == {}
+      warnings[0].line_number.should == 2
+      warnings[0].message.should     == 'Params hash used in view.'
+    end
+
+  end
+
+end

data/spec/checks/rails/session_hash_in_view_check_spec.rb

@@ -0,0 +1,40 @@
+require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
+
+describe Simplabs::Excellent::Checks::Rails::SessionHashInViewCheck do
+
+  before do
+    @excellent = Simplabs::Excellent::Runner.new(Simplabs::Excellent::Checks::Rails::SessionHashInViewCheck.new)
+  end
+
+  describe '#evaluate' do
+
+    it 'should accept views that do not use the session hash' do
+      code = <<-END
+        <div>
+          <%= 'some text' %>
+        </div>
+      END
+      @excellent.check('dummy-file.html.erb', code)
+      warnings = @excellent.warnings
+
+      warnings.should be_empty
+    end
+
+    it 'should reject views that use the session hash' do
+      code = <<-END
+        <div>
+          <%= session[:someCount] %>
+        </div>
+      END
+      @excellent.check('dummy-file.html.erb', code)
+      warnings = @excellent.warnings
+
+      warnings.should_not be_empty
+      warnings[0].info.should        == {}
+      warnings[0].line_number.should == 2
+      warnings[0].message.should     == 'Session hash used in view.'
+    end
+
+  end
+
+end