espn 0.1.3 → 0.2.0

data/spec/espn/client/scores_spec.rb

@@ -3,71 +3,88 @@ require 'spec_helper'
 describe ESPN::Client::Scores do
   before do
     @client = ESPN::Client.new
+    stub_get 'scores.json'
+  end
+
+  describe '#score' do
+    it 'should return an event' do
+      @client.score(1).competitions.is_a?(Array).should be_true
+    end
+
+    it 'should request the specific event' do
+      @client.score(1)
+      assert_requested :get, espn_url('sports/events/1')
+    end
   end
 
   describe '#scores' do
+    it 'returns an array of events with scores' do
+      @client.scores.first.respond_to?(:competitions).should be_true
+    end
 
     it 'gets all scores' do
-      stub_get('sports/events')
       @client.scores
       assert_requested :get, espn_url('sports/events')
     end
 
-    context 'with a sport param' do
-      it 'should include the sport in the request' do
-        stub_get('sports/baseball/events')
-        @client.scores(sport: 'baseball')
-        assert_requested :get, espn_url('sports/baseball/events')
+    context 'when passing values as args' do
+      context 'when passing the sport' do
+        it 'should request scores for that sport' do
+          @client.scores(:baseball)
+          assert_requested :get, espn_url('sports/baseball/events')
+        end
       end
 
-      context 'with a event_id param' do
-        it 'should include the sport and event_id params in the request' do
-          stub_get('sports/baseball/events/5')
-          @client.scores(sport: 'baseball', event_id: 5)
-          assert_requested :get, espn_url('sports/baseball/events/5')
+      context 'when passing the league' do
+        it 'should request scores for that league' do
+          @client.scores(:nba)
+          assert_requested :get, espn_url('sports/basketball/nba/events')
         end
       end
-    end
 
-    context 'with a sport and a league param' do
-      it 'should include the sport and league params in the request' do
-        stub_get('sports/baseball/mlb/events')
-        @client.scores(sport: 'baseball', league: 'mlb')
-        assert_requested :get, espn_url('sports/baseball/mlb/events')
+      context 'when passing the sport and league' do
+        it 'should request scores for that league and sport' do
+          @client.scores(:baseball, :nba)
+          assert_requested :get, espn_url('sports/baseball/nba/events')
+        end
       end
 
-      context 'with a event_id param' do
-        it 'should include the sport, league and event_id params' do
-          stub_get('sports/baseball/mlb/events/1')
-          @client.scores(sport: 'baseball', league: 'mlb', event_id: 1)
-          assert_requested :get, espn_url('sports/baseball/mlb/events/1')
+      context 'when passing the league in the opts hash' do
+        it 'should override the arg' do
+          @client.scores(:nba, league: 'mlb')
+          assert_requested :get, espn_url('sports/basketball/mlb/events')
         end
       end
-    end
 
-    context 'with a event_id param' do
-      it 'should include the event_id in the request' do
-        stub_get('sports/events/5')
-        @client.scores(event_id: 5)
-        assert_requested :get, espn_url('sports/events/5')
+      context 'when passing the sport in the opts hash' do
+        it 'should override the arg' do
+          @client.scores(:baseball, sport: 'basketball')
+          assert_requested :get, espn_url('sports/basketball/events')
+        end
       end
     end
 
-    context 'with a league param and no sport param' do
-      it 'should not include either in the request' do
-        stub_get('sports/events')
-        @client.scores(league: 'mlb')
-        assert_requested :get, espn_url('sports/events')
+    context 'when passing values in the opts hash' do
+      context 'with a sport param' do
+        it 'should include the sport in the request' do
+          @client.scores(sport: 'baseball')
+          assert_requested :get, espn_url('sports/baseball/events')
+        end
+      end
+
+      context 'with a sport and a league param' do
+        it 'should include the sport and league params in the request' do
+          @client.scores(sport: 'baseball', league: 'mlb')
+          assert_requested :get, espn_url('sports/baseball/mlb/events')
+        end
       end
 
-      context 'with a event_id param' do
-        it 'should include the event_id in the request' do
-          stub_get('sports/events/2')
-          @client.scores(league: 'mlb', event_id: 2)
-          assert_requested :get, espn_url('sports/events/2')
+      context 'with a league param and no sport param' do
+        it 'should map the league to a sport' do
+          @client.scores(league: 'mlb')
+          assert_requested :get, espn_url('sports/baseball/mlb/events')
         end
       end
     end
-
   end
 end

data/spec/espn/client/sports_spec.rb

@@ -3,39 +3,77 @@ require 'spec_helper'
 describe ESPN::Client::Sports do
   before do
     @client = ESPN::Client.new
+    stub_get 'sports.json'
   end
 
   describe '#sports' do
+    it 'returns an array of sports' do
+      @client.sports.first.name.should eq('baseball')
+    end
 
     it 'gets all sports' do
-      stub_get('sports')
       @client.sports
       assert_requested :get, espn_url('sports')
     end
 
-    context 'with a sport param' do
-      it 'should include the sport param in the request' do
-        stub_get('sports/baseball')
-        @client.sports(sport: 'baseball')
-        assert_requested :get, espn_url('sports/baseball')
+    context 'when passing values as args' do
+      context 'when passing the sport' do
+        it 'should request that sport' do
+          @client.sports(:baseball)
+          assert_requested :get, espn_url('sports/baseball')
+        end
       end
-    end
 
-    context 'with a sport and a league param' do
-      it 'should include both params in the request' do
-        stub_get('sports/baseball/mlb')
-        @client.sports(sport: 'baseball', league: 'mlb')
-        assert_requested :get, espn_url('sports/baseball/mlb')
+      context 'when passing the league' do
+        it 'should request that league' do
+          @client.sports(:mlb)
+          assert_requested :get, espn_url('sports/baseball/mlb')
+        end
+      end
+
+      context 'when passing the sport and league' do
+        it 'should request that sport and league' do
+          @client.sports(:baseball, :nba)
+          assert_requested :get, espn_url('sports/baseball/nba')
+        end
+      end
+
+      context 'when passing the league in the opts hash' do
+        it 'should override the arg' do
+          @client.sports(:nba, league: 'mlb')
+          assert_requested :get, espn_url('sports/basketball/mlb')
+        end
       end
-    end
 
-    context 'with a league param but no sport param' do
-      it 'should not include the league param in the request' do
-        stub_get('sports')
-        @client.sports(league: 'mlb')
-        assert_requested :get, espn_url('sports')
+      context 'when passing the sport in the opts hash' do
+        it 'should override the arg' do
+          @client.sports(:baseball, sport: :basketball)
+          assert_requested :get, espn_url('sports/basketball')
+        end
       end
     end
 
+    context 'when passing values in the opts hash' do
+      context 'with a sport param' do
+        it 'should include the sport param in the request' do
+          @client.sports(sport: 'baseball')
+          assert_requested :get, espn_url('sports/baseball')
+        end
+      end
+
+      context 'with a sport and a league param' do
+        it 'should include both params in the request' do
+          @client.sports(sport: 'baseball', league: 'mlb')
+          assert_requested :get, espn_url('sports/baseball/mlb')
+        end
+      end
+
+      context 'with a league param but no sport param' do
+        it 'should map the league to a sport' do
+          @client.sports(league: 'mlb')
+          assert_requested :get, espn_url('sports/baseball/mlb')
+        end
+      end
+    end
   end
 end

data/spec/espn/client/standings_spec.rb

@@ -3,39 +3,62 @@ require 'spec_helper'
 describe ESPN::Client::Standings do
   before do
     @client = ESPN::Client.new
+    stub_get 'standings.json'
   end
 
   describe '#standings' do
+    it 'returns an array of standings' do
+      team = @client.standings(:mlb).first.groups.first
+      team.competitors.is_a?(Array).should be_true
+    end
 
-    it 'gets all standings' do
-      stub_get('sports/standings')
-      @client.standings
-      assert_requested :get, espn_url('sports/standings')
+    it 'gets all standings for a given league' do
+      @client.standings(:mlb)
+      assert_requested :get, espn_url('sports/baseball/mlb/standings')
     end
 
-    context 'with a sport param' do
-      it 'should include the sport in the request' do
-        stub_get('sports/baseball/standings')
-        @client.standings(sport: 'baseball')
-        assert_requested :get, espn_url('sports/baseball/standings')
+    context 'when league is not passed' do
+      it 'should raise an argument error' do
+        expect { @client.standings }.to raise_error(ArgumentError)
       end
     end
 
-    context 'with a sport and a league param' do
-      it 'should include the sport and league params in the request' do
-        stub_get('sports/baseball/mlb/standings')
-        @client.standings(sport: 'baseball', league: 'mlb')
-        assert_requested :get, espn_url('sports/baseball/mlb/standings')
+    context 'when invalid league is passed' do
+      it 'should raise an argument error' do
+        expect { @client.standings(:foobar) }.to raise_error(ArgumentError)
       end
     end
 
-    context 'with a league param and no sport param' do
-      it 'should not include either in the request' do
-        stub_get('sports/standings')
-        @client.standings(league: 'mlb')
-        assert_requested :get, espn_url('sports/standings')
+    context 'when passing values as args' do
+      context 'when passing the league' do
+        it 'should map that league to a sport' do
+          @client.standings(:mlb)
+          assert_requested :get, espn_url('sports/baseball/mlb/standings')
+        end
+      end
+
+      context 'when passing the sport and league' do
+        it 'should get standings for that sport and league' do
+          @client.standings(:football, :nfl)
+          assert_requested :get, espn_url('sports/football/nfl/standings')
+        end
       end
     end
 
+    context 'when passing values in the opts hash' do
+      context 'with a league param' do
+        it 'should map the league to a sport' do
+          @client.standings(league: 'mlb')
+          assert_requested :get, espn_url('sports/baseball/mlb/standings')
+        end
+      end
+
+      context 'with a sport and a league param' do
+        it 'should include the sport and league params in the request' do
+          @client.standings(sport: 'baseball', league: 'mlb')
+          assert_requested :get, espn_url('sports/baseball/mlb/standings')
+        end
+      end
+    end
   end
 end

data/spec/espn/client/teams_spec.rb

@@ -3,71 +3,89 @@ require 'spec_helper'
 describe ESPN::Client::Teams do
   before do
     @client = ESPN::Client.new
+    stub_get 'teams.json'
   end
 
-  describe '#teams' do
+  describe '#team' do
+    it 'should return a team' do
+      @client.team(1, :mlb).name.should eq('Phillies')
+    end
 
-    it 'gets all teams' do
-      stub_get('sports/teams')
-      @client.teams
-      assert_requested :get, espn_url('sports/teams')
+    it 'should get a team for the given league' do
+      @client.team(1, :mlb)
+      assert_requested :get, espn_url('sports/baseball/mlb/teams/1')
     end
 
-    context 'with a sport param' do
-      it 'should include the sport in the request' do
-        stub_get('sports/baseball/teams')
-        @client.teams(sport: 'baseball')
-        assert_requested :get, espn_url('sports/baseball/teams')
-      end
+    it 'should accept a league in the opts hash' do
+      @client.team(1, league: 'mlb')
+      assert_requested :get, espn_url('sports/baseball/mlb/teams/1')
+    end
 
-      context 'with a team_id param' do
-        it 'should include the sport and team_id params in the request' do
-          stub_get('sports/baseball/teams/5')
-          @client.teams(sport: 'baseball', team_id: 5)
-          assert_requested :get, espn_url('sports/baseball/teams/5')
-        end
+    context 'when league is not passed' do
+      it 'should raise an argument error' do
+        expect { @client.team(1) }.to raise_error(ArgumentError)
       end
     end
 
-    context 'with a sport and a league param' do
-      it 'should include the sport and league params in the request' do
-        stub_get('sports/baseball/mlb/teams')
-        @client.teams(sport: 'baseball', league: 'mlb')
-        assert_requested :get, espn_url('sports/baseball/mlb/teams')
+    context 'when invalid league is passed' do
+      it 'should raise an argument error' do
+        expect { @client.team(1, :foobar) }.to raise_error(ArgumentError)
       end
+    end
+  end
 
-      context 'with a team_id param' do
-        it 'should include the sport, league and team_id params' do
-          stub_get('sports/baseball/mlb/teams/1')
-          @client.teams(sport: 'baseball', league: 'mlb', team_id: 1)
-          assert_requested :get, espn_url('sports/baseball/mlb/teams/1')
-        end
+  describe '#teams' do
+    it 'returns an array of teams' do
+      @client.teams(:mlb).first.name.should eq('Phillies')
+    end
+
+    it 'gets all teams for a given league' do
+      @client.teams(:nba)
+      assert_requested :get, espn_url('sports/basketball/nba/teams')
+    end
+
+    context 'when league is not passed' do
+      it 'should raise an argument error' do
+        expect { @client.teams }.to raise_error(ArgumentError)
       end
     end
 
-    context 'with a team_id param' do
-      it 'should include the team_id in the request' do
-        stub_get('sports/teams/5')
-        @client.teams(team_id: 5)
-        assert_requested :get, espn_url('sports/teams/5')
+    context 'when invalid league is passed' do
+      it 'should raise an argument error' do
+        expect { @client.teams(:foobar) }.to raise_error(ArgumentError)
       end
     end
 
-    context 'with a league param and no sport param' do
-      it 'should not include either in the request' do
-        stub_get('sports/teams')
-        @client.teams(league: 'mlb')
-        assert_requested :get, espn_url('sports/teams')
+    context 'when passing values as args' do
+      context 'when passing a league' do
+        it 'should map that league to a sport' do
+          @client.teams(:mlb)
+          assert_requested :get, espn_url('sports/baseball/mlb/teams')
+        end
       end
 
-      context 'with a team_id param' do
-        it 'should include the team_id in the request' do
-          stub_get('sports/teams/2')
-          @client.teams(league: 'mlb', team_id: 2)
-          assert_requested :get, espn_url('sports/teams/2')
+      context 'when passing a sport and a league' do
+        it 'should get teams for that sport and league' do
+          @client.teams(:football, :nfl)
+          assert_requested :get, espn_url('sports/football/nfl/teams')
         end
       end
     end
 
+    context 'when passing values in the opts hash' do
+      context 'when passing a league' do
+        it 'should map that league to a sport' do
+          @client.teams(league: 'mlb')
+          assert_requested :get, espn_url('sports/baseball/mlb/teams')
+        end
+      end
+
+      context 'when passing a sport and a league' do
+        it 'should get teams for that sport and league' do
+          @client.teams(sport: 'football', league: 'nfl')
+          assert_requested :get, espn_url('sports/football/nfl/teams')
+        end
+      end
+    end
   end
 end

data/spec/espn/client/video_spec.rb

@@ -3,27 +3,23 @@ require 'spec_helper'
 describe ESPN::Client::Video do
   before do
     @client = ESPN::Client.new
+    stub_get 'videos.json'
   end
 
-  it 'should get all clips' do
-    stub_get('video/channels/clips')
-    @client.video
-    assert_requested :get, espn_url('video/channels/clips')
+  it 'should return an array of channels' do
+    results = @client.videos(1)
+    results.first.name.should eq('This is a video channel.')
   end
 
-  context 'with a category_id param' do
-    it 'should include the category_id in the request' do
-      stub_get('video/channels/1/clips')
-      @client.video(category_id: 1)
-      assert_requested :get, espn_url('video/channels/1/clips')
-    end
+  it 'should get all clips for a given channel' do
+    @client.videos(1)
+    assert_requested :get, espn_url('video/channels/1/clips')
   end
 
   context 'with a clip_id param' do
     it 'should include the clip_id in the request' do
-      stub_get('video/channels/clips/2')
-      @client.video(clip_id: 2)
-      assert_requested :get, espn_url('video/channels/clips/2')
+      @client.videos(1, clip_id: 2)
+      assert_requested :get, espn_url('video/channels/1/clips/2')
     end
   end