espn 0.1.3 → 0.2.0

data/spec/espn/client/athletes_spec.rb

@@ -3,71 +3,62 @@ require 'spec_helper'
 describe ESPN::Client::Athletes do
   before do
     @client = ESPN::Client.new
+    stub_get 'athletes.json'
   end
 
-  describe '#athletes' do
+  describe '#athlete' do
+    it 'should return an athlete' do
+      @client.athlete(1, :mlb).fullName.should eq('Chase Utley')
+    end
 
-    it 'gets all athletes' do
-      stub_get('sports/athletes')
-      @client.athletes
-      assert_requested :get, espn_url('sports/athletes')
+    it 'should get an athlete for the given league' do
+      @client.athlete(1, :mlb)
+      assert_requested :get, espn_url('sports/baseball/mlb/athletes/1')
     end
 
-    context 'with a sport param' do
-      it 'should include the sport in the request' do
-        stub_get('sports/baseball/athletes')
-        @client.athletes(sport: 'baseball')
-        assert_requested :get, espn_url('sports/baseball/athletes')
-      end
+    it 'should accept a league in the opts hash' do
+      @client.athlete(1, league: 'mlb')
+      assert_requested :get, espn_url('sports/baseball/mlb/athletes/1')
+    end
 
-      context 'with a athlete_id param' do
-        it 'should include the sport and athlete_id params in the request' do
-          stub_get('sports/baseball/athletes/5')
-          @client.athletes(sport: 'baseball', athlete_id: 5)
-          assert_requested :get, espn_url('sports/baseball/athletes/5')
-        end
+    context 'when league is not passed' do
+      it 'should raise an argument error' do
+        expect { @client.athlete(1) }.to raise_error(ArgumentError)
       end
     end
 
-    context 'with a sport and a league param' do
-      it 'should include the sport and league params in the request' do
-        stub_get('sports/baseball/mlb/athletes')
-        @client.athletes(sport: 'baseball', league: 'mlb')
-        assert_requested :get, espn_url('sports/baseball/mlb/athletes')
+    context 'when invalid league is passed' do
+      it 'should raise an argument error' do
+        expect { @client.athlete(1, :foobar) }.to raise_error(ArgumentError)
       end
+    end
+  end
 
-      context 'with a athlete_id param' do
-        it 'should include the sport, league and athlete_id params' do
-          stub_get('sports/baseball/mlb/athletes/1')
-          @client.athletes(sport: 'baseball', league: 'mlb', athlete_id: 1)
-          assert_requested :get, espn_url('sports/baseball/mlb/athletes/1')
-        end
-      end
+  describe '#athletes' do
+    it 'should return an array of athletes' do
+      @client.athletes(:mlb).first.fullName.should eq('Chase Utley')
     end
 
-    context 'with a athlete_id param' do
-      it 'should include the athlete_id in the request' do
-        stub_get('sports/athletes/5')
-        @client.athletes(athlete_id: 5)
-        assert_requested :get, espn_url('sports/athletes/5')
-      end
+    it 'should get athletes for the given league' do
+      @client.athletes(:nba)
+      assert_requested :get, espn_url('sports/basketball/nba/athletes')
     end
 
-    context 'with a league param and no sport param' do
-      it 'should not include either in the request' do
-        stub_get('sports/athletes')
-        @client.athletes(league: 'mlb')
-        assert_requested :get, espn_url('sports/athletes')
-      end
+    it 'should accept a league in the opts hash' do
+      @client.athletes(league: 'mlb')
+      assert_requested :get, espn_url('sports/baseball/mlb/athletes')
+    end
 
-      context 'with a athlete_id param' do
-        it 'should include the athlete_id in the request' do
-          stub_get('sports/athletes/2')
-          @client.athletes(league: 'mlb', athlete_id: 2)
-          assert_requested :get, espn_url('sports/athletes/2')
-        end
+    context 'when league is not passed' do
+      it 'should raise an argument error' do
+        expect { @client.athletes }.to raise_error(ArgumentError)
       end
     end
 
+    context 'when invalid league is passed' do
+      it 'should raise an argument error' do
+        expect { @client.athletes(:foobar) }.to raise_error(ArgumentError)
+      end
+    end
   end
 end

data/spec/espn/client/audio_spec.rb

@@ -3,44 +3,45 @@ require 'spec_helper'
 describe ESPN::Client::Audio do
   before do
     @client = ESPN::Client.new
+    stub_get 'audio.json'
   end
 
-  it 'should get all podcasts' do
-    stub_get('audio/podcasts')
-    @client.audio
-    assert_requested :get, espn_url('audio/podcasts')
-  end
+  describe '#audio' do
+    it 'should return an array of podcast recordings' do
+      @client.audio.first.categories.first.respond_to?(:podcast).should be_true
+    end
 
-  context 'with a method param' do
-    context 'if method is podcast_recordings' do
-      it 'should include podcasts/recordings in the request' do
-        stub_get('audio/podcasts/recordings')
-        @client.audio(method: 'podcast_recordings')
-        assert_requested :get, espn_url('audio/podcasts/recordings')
-      end
+    it 'should get all podcasts by default' do
+      @client.audio
+      assert_requested :get, espn_url('audio/podcasts')
     end
 
-    it 'should include the method in the request' do
-      stub_get('audio/recordings')
-      @client.audio(method: 'recordings')
-      assert_requested :get, espn_url('audio/recordings')
+    context 'with a method param' do
+      it 'should include the method in the request' do
+        @client.audio(method: 'recordings')
+        assert_requested :get, espn_url('audio/recordings')
+      end
+
+      context 'if method is podcast_recordings' do
+        it 'should convert to podcasts/recordings' do
+          @client.audio(method: 'podcast_recordings')
+          assert_requested :get, espn_url('audio/podcasts/recordings')
+        end
+      end
     end
-  end
 
-  context 'with a podcast_id param' do
-    it 'should include the podcast_id in the param' do
-      stub_get('audio/podcasts/1')
-      @client.audio(podcast_id: 1)
-      assert_requested :get, espn_url('audio/podcasts/1')
+    context 'with a podcast_id param' do
+      it 'should include the podcast_id in the param' do
+        @client.audio(podcast_id: 1)
+        assert_requested :get, espn_url('audio/podcasts/1')
+      end
     end
-  end
 
-  context 'with a recording_id param' do
-    it 'should include the recording_id in the param' do
-      stub_get('audio/podcasts/2')
-      @client.audio(recording_id: 2)
-      assert_requested :get, espn_url('audio/podcasts/2')
+    context 'with a recording_id param' do
+      it 'should include the recording_id in the param' do
+        @client.audio(recording_id: 2)
+        assert_requested :get, espn_url('audio/podcasts/2')
+      end
     end
   end
-
 end

data/spec/espn/client/headlines_spec.rb

@@ -3,60 +3,105 @@ require 'spec_helper'
 describe ESPN::Client::Headlines do
   before do
     @client = ESPN::Client.new
+    stub_get 'headlines.json'
+  end
+
+  describe '#headline' do
+    it 'should include the id in the request' do
+      @client.headline(5)
+      assert_requested :get, espn_url('sports/news/5')
+    end
+
+    it 'should not return an array' do
+      @client.headline(5).should_not be_a(Array)
+    end
+
+    it 'should return the headline' do
+      @client.headline(5).type.should eq('HeadlineNews')
+    end
   end
 
   describe '#headlines' do
+    it 'should return an array of headlines' do
+      @client.headlines.first.type.should eq('HeadlineNews')
+    end
+
     it 'should get headlines for sports by default' do
-      stub_get('sports/news')
       @client.headlines
       assert_requested :get, espn_url('sports/news')
     end
 
-    context 'with a section param' do
-      it 'should get headlines for that section' do
-        stub_get('cities/news')
-        @client.headlines(section: 'cities')
-        assert_requested :get, espn_url('cities/news')
+    context 'when passing values as args' do
+      context 'when passing the sport' do
+        it 'should request headlines for that sport' do
+          @client.headlines('horse-racing')
+          assert_requested :get, espn_url('sports/horse-racing/news')
+        end
       end
-    end
 
-    context 'with a sport param' do
-      it 'should include the sport in the request' do
-        stub_get('sports/baseball/news')
-        @client.headlines(sport: 'baseball')
-        assert_requested :get, espn_url('sports/baseball/news')
+      context 'when passing the league' do
+        it 'should request headlines for that league' do
+          @client.headlines(:mlb)
+          assert_requested :get, espn_url('sports/baseball/mlb/news')
+        end
       end
-    end
 
-    context 'with a sport and league param' do
-      it 'should include both params in the request' do
-        stub_get('sports/baseball/mlb/news')
-        @client.headlines(sport: 'baseball', league: 'mlb')
-        assert_requested :get, espn_url('sports/baseball/mlb/news')
+      context 'when passing the league and sport' do
+        it 'should request headlines for that sport and league' do
+          @client.headlines('horse-racing', 'mlb')
+          assert_requested :get, espn_url('sports/horse-racing/mlb/news')
+        end
       end
-    end
 
-    context 'with a league param but no sport param' do
-      it 'should not include the league in the request' do
-        stub_get('sports/news')
-        @client.headlines(league: 'mlb')
-        assert_requested :get, espn_url('sports/news')
+      context 'when passing sport in the opts hash' do
+        it 'should override the symbol with the opts' do
+          @client.headlines(:basketball, sport: 'baseball')
+          assert_requested :get, espn_url('sports/baseball/news')
+        end
       end
-    end
 
-    context 'with a method param' do
-      it 'should include the method in the request' do
-        stub_get('sports/news/headlines/top')
-        @client.headlines(method: 'top')
-        assert_requested :get, espn_url('sports/news/headlines/top')
+      context 'when passing league in the opts hash' do
+        it 'should override the symbol with the opts' do
+          @client.headlines('wnba', league: 'mlb')
+          assert_requested :get, espn_url('sports/basketball/mlb/news')
+        end
       end
     end
 
-    context 'with a headline_id param' do
-      it 'should include the headline_id in the request' do
-        stub_get('sports/news/5')
-        @client.headlines(headline_id: 5)
-        assert_requested :get, espn_url('sports/news/5')
+    context 'when passing values in the opts hash' do
+      context 'with a section param' do
+        it 'should get headlines for that section' do
+          @client.headlines(section: 'cities')
+          assert_requested :get, espn_url('cities/news')
+        end
+      end
+
+      context 'with a sport param' do
+        it 'should get headlines for that sport' do
+          @client.headlines(sport: 'baseball')
+          assert_requested :get, espn_url('sports/baseball/news')
+        end
+      end
+
+      context 'with a sport and league param' do
+        it 'should get headlines for that sport and league' do
+          @client.headlines(sport: 'baseball', league: 'mlb')
+          assert_requested :get, espn_url('sports/baseball/mlb/news')
+        end
+      end
+
+      context 'with a league param but no sport param' do
+        it 'should get headlines for that league mapped to a sport' do
+          @client.headlines(league: 'mlb')
+          assert_requested :get, espn_url('sports/baseball/mlb/news')
+        end
+      end
+
+      context 'with a method param' do
+        it 'should get headlines for that method' do
+          @client.headlines(method: 'top')
+          assert_requested :get, espn_url('sports/news/headlines/top')
+        end
       end
     end
   end

data/spec/espn/client/medals_spec.rb

@@ -3,10 +3,10 @@ require 'spec_helper'
 describe ESPN::Client::Medals do
   before do
     @client = ESPN::Client.new
+    stub_get 'medals.json'
   end
 
   it 'should get all medals' do
-    stub_get('sports/olympics/medals')
     @client.medals
     assert_requested :get, espn_url('sports/olympics/medals')
   end

data/spec/espn/client/notes_spec.rb

@@ -3,71 +3,65 @@ require 'spec_helper'
 describe ESPN::Client::Notes do
   before do
     @client = ESPN::Client.new
+    stub_get 'notes.json'
+  end
+
+  describe '#note' do
+    it 'should return a note' do
+      @client.note(1).headline.should eq('Cowboys Stink')
+    end
+
+    it 'should include the id in the request' do
+      @client.note(1)
+      assert_requested :get, espn_url('sports/news/notes/1')
+    end
   end
 
   describe '#notes' do
+    it 'should return an array of notes' do
+      @client.notes.first.respond_to?(:headline).should be_true
+    end
 
-    it 'gets all notes' do
-      stub_get('sports/news/notes')
+    it 'gets all notes by default' do
       @client.notes
       assert_requested :get, espn_url('sports/news/notes')
     end
 
-    context 'with a sport param' do
-      it 'should include the sport in the request' do
-        stub_get('sports/baseball/news/notes')
-        @client.notes(sport: 'baseball')
-        assert_requested :get, espn_url('sports/baseball/news/notes')
-      end
-
-      context 'with a note_id param' do
-        it 'should include the sport and note_id params in the request' do
-          stub_get('sports/baseball/news/notes/5')
-          @client.notes(sport: 'baseball', note_id: 5)
-          assert_requested :get, espn_url('sports/baseball/news/notes/5')
+    context 'when passing values as args' do
+      context 'when passing the sport' do
+        it 'should request notes for that sport' do
+          @client.notes(:football)
+          assert_requested :get, espn_url('sports/football/news/notes')
         end
       end
-    end
-
-    context 'with a sport and a league param' do
-      it 'should include the sport and league params in the request' do
-        stub_get('sports/baseball/mlb/news/notes')
-        @client.notes(sport: 'baseball', league: 'mlb')
-        assert_requested :get, espn_url('sports/baseball/mlb/news/notes')
-      end
 
-      context 'with a note_id param' do
-        it 'should include the sport, league and note_id params' do
-          stub_get('sports/baseball/mlb/news/notes/1')
-          @client.notes(sport: 'baseball', league: 'mlb', note_id: 1)
-          assert_requested :get, espn_url('sports/baseball/mlb/news/notes/1')
+      context 'when passing the league' do
+        it 'should request notes for the league' do
+          @client.notes(:nfl)
+          assert_requested :get, espn_url('sports/football/nfl/news/notes')
         end
       end
-    end
 
-    context 'with a note_id param' do
-      it 'should include the note_id in the request' do
-        stub_get('sports/news/notes/5')
-        @client.notes(note_id: 5)
-        assert_requested :get, espn_url('sports/news/notes/5')
+      context 'when passing the league and sport' do
+        it 'should request notes for that league and sport' do
+          @client.notes(:baseball, 'mlb')
+          assert_requested :get, espn_url('sports/baseball/mlb/news/notes')
+        end
       end
-    end
 
-    context 'with a league param and no sport param' do
-      it 'should not include either in the request' do
-        stub_get('sports/news/notes')
-        @client.notes(league: 'mlb')
-        assert_requested :get, espn_url('sports/news/notes')
+      context 'when passing sport in the opts hash' do
+        it 'should override the symbol with the opts' do
+          @client.notes(:basketball, sport: 'baseball')
+          assert_requested :get, espn_url('sports/baseball/news/notes')
+        end
       end
 
-      context 'with a note_id param' do
-        it 'should include the note_id in the request' do
-          stub_get('sports/news/notes/2')
-          @client.notes(league: 'mlb', note_id: 2)
-          assert_requested :get, espn_url('sports/news/notes/2')
+      context 'when passing league in the opts hash' do
+        it 'should override the symbol with the opts' do
+          @client.notes('wnba', league: 'mlb')
+          assert_requested :get, espn_url('sports/basketball/mlb/news/notes')
         end
       end
     end
-
   end
 end

data/spec/espn/client/now_spec.rb

@@ -3,17 +3,16 @@ require 'spec_helper'
 describe ESPN::Client::Now do
   before do
     @client = ESPN::Client.new
+    stub_get 'now.json'
   end
 
   it 'gets all latest content' do
-    stub_get('now')
     @client.now
     assert_requested :get, espn_url('now')
   end
 
   context 'with a method param' do
     it 'should include the method in the request' do
-      stub_get('now/popular')
       @client.now(method: 'popular')
       assert_requested :get, espn_url('now/popular')
     end