enju_library 0.2.0 → 0.2.1

data/spec/controllers/shelves_controller_spec.rb

@@ -7,109 +7,109 @@ describe ShelvesController do
     FactoryGirl.attributes_for(:shelf)
   end
 
-  describe "GET index", :solr => true do
+  describe 'GET index', solr: true do
     before do
       Shelf.reindex
     end
 
-    describe "When logged in as Administrator" do
+    describe 'When logged in as Administrator' do
       login_fixture_admin
 
-      it "assigns all shelves as @shelves" do
+      it 'assigns all shelves as @shelves' do
         get :index
         assigns(:shelves).should_not be_empty
       end
     end
 
-    describe "When logged in as Librarian" do
+    describe 'When logged in as Librarian' do
       login_fixture_librarian
 
-      it "assigns all shelves as @shelves" do
+      it 'assigns all shelves as @shelves' do
         get :index
         assigns(:shelves).should_not be_empty
       end
     end
 
-    describe "When logged in as User" do
+    describe 'When logged in as User' do
       login_fixture_user
 
-      it "assigns all shelves as @shelves" do
+      it 'assigns all shelves as @shelves' do
         get :index
         assigns(:shelves).should_not be_empty
       end
     end
 
-    describe "When not logged in" do
-      it "assigns all shelves as @shelves" do
+    describe 'When not logged in' do
+      it 'assigns all shelves as @shelves' do
         get :index
         assigns(:shelves).should_not be_empty
         response.should be_success
       end
 
-      it "assigns all shelves as @shelves with library_id" do
-        get :index, :library_id => 'kamata'
+      it 'assigns all shelves as @shelves with library_id' do
+        get :index, library_id: 'kamata'
         assigns(:shelves).map(&:id).should eq(Library.friendly.find('kamata').shelves.order(:position).page(1).pluck(:id))
         response.should be_success
       end
 
-      it "assigns all shelves as @shelves with select mode" do
-        get :index, :mode => 'select'
+      it 'assigns all shelves as @shelves with select mode' do
+        get :index, mode: 'select'
         assigns(:shelves).should eq(Shelf.real.order(:position))
         response.should be_success
       end
     end
   end
 
-  describe "GET show" do
-    describe "When logged in as Administrator" do
+  describe 'GET show' do
+    describe 'When logged in as Administrator' do
       login_fixture_admin
 
-      it "assigns the requested shelf as @shelf" do
-        get :show, :id => 1
+      it 'assigns the requested shelf as @shelf' do
+        get :show, id: 1
         assigns(:shelf).should eq(Shelf.find(1))
       end
     end
 
-    describe "When not logged in" do
-      it "assigns the requested shelf as @shelf" do
-        get :show, :id => 1
+    describe 'When not logged in' do
+      it 'assigns the requested shelf as @shelf' do
+        get :show, id: 1
         assigns(:shelf).should eq(Shelf.find(1))
       end
     end
   end
 
-  describe "GET new" do
-    describe "When logged in as Administrator" do
+  describe 'GET new' do
+    describe 'When logged in as Administrator' do
       login_fixture_admin
 
-      it "assigns the requested shelf as @shelf" do
+      it 'assigns the requested shelf as @shelf' do
         get :new
         assigns(:shelf).should_not be_valid
       end
     end
 
-    describe "When logged in as Librarian" do
+    describe 'When logged in as Librarian' do
       login_fixture_librarian
 
-      it "assigns the requested shelf as @shelf" do
+      it 'assigns the requested shelf as @shelf' do
         get :new
         assigns(:shelf).should be_nil
         response.should be_forbidden
       end
     end
 
-    describe "When logged in as User" do
+    describe 'When logged in as User' do
       login_fixture_user
 
-      it "should not assign the requested shelf as @shelf" do
+      it 'should not assign the requested shelf as @shelf' do
         get :new
         assigns(:shelf).should be_nil
         response.should be_forbidden
       end
     end
 
-    describe "When not logged in" do
-      it "should not assign the requested shelf as @shelf" do
+    describe 'When not logged in' do
+      it 'should not assign the requested shelf as @shelf' do
         get :new
         assigns(:shelf).should be_nil
         response.should redirect_to(new_user_session_url)
@@ -117,320 +117,320 @@ describe ShelvesController do
     end
   end
 
-  describe "GET edit" do
-    describe "When logged in as Administrator" do
+  describe 'GET edit' do
+    describe 'When logged in as Administrator' do
       login_fixture_admin
 
-      it "assigns the requested shelf as @shelf" do
+      it 'assigns the requested shelf as @shelf' do
         shelf = FactoryGirl.create(:shelf)
-        get :edit, :id => shelf.id
+        get :edit, id: shelf.id
         assigns(:shelf).should eq(shelf)
       end
     end
 
-    describe "When logged in as Librarian" do
+    describe 'When logged in as Librarian' do
       login_fixture_librarian
 
-      it "assigns the requested shelf as @shelf" do
+      it 'assigns the requested shelf as @shelf' do
         shelf = FactoryGirl.create(:shelf)
-        get :edit, :id => shelf.id
+        get :edit, id: shelf.id
         assigns(:shelf).should eq(shelf)
       end
     end
 
-    describe "When logged in as User" do
+    describe 'When logged in as User' do
       login_fixture_user
 
-      it "assigns the requested shelf as @shelf" do
+      it 'assigns the requested shelf as @shelf' do
         shelf = FactoryGirl.create(:shelf)
-        get :edit, :id => shelf.id
+        get :edit, id: shelf.id
         response.should be_forbidden
       end
     end
 
-    describe "When not logged in" do
-      it "should not assign the requested shelf as @shelf" do
+    describe 'When not logged in' do
+      it 'should not assign the requested shelf as @shelf' do
         shelf = FactoryGirl.create(:shelf)
-        get :edit, :id => shelf.id
+        get :edit, id: shelf.id
         response.should redirect_to(new_user_session_url)
       end
     end
   end
 
-  describe "POST create" do
+  describe 'POST create' do
     before(:each) do
       @attrs = valid_attributes
-      @invalid_attrs = {:name => ''}
+      @invalid_attrs = { name: '' }
     end
 
-    describe "When logged in as Administrator" do
+    describe 'When logged in as Administrator' do
       login_fixture_admin
 
-      describe "with valid params" do
-        it "assigns a newly created shelf as @shelf" do
-          post :create, :shelf => @attrs
+      describe 'with valid params' do
+        it 'assigns a newly created shelf as @shelf' do
+          post :create, shelf: @attrs
           assigns(:shelf).should be_valid
         end
 
-        it "redirects to the created patron" do
-          post :create, :shelf => @attrs
+        it 'redirects to the created patron' do
+          post :create, shelf: @attrs
           response.should redirect_to(assigns(:shelf))
         end
       end
 
-      describe "with invalid params" do
-        it "assigns a newly created but unsaved shelf as @shelf" do
-          post :create, :shelf => @invalid_attrs
+      describe 'with invalid params' do
+        it 'assigns a newly created but unsaved shelf as @shelf' do
+          post :create, shelf: @invalid_attrs
           assigns(:shelf).should_not be_valid
         end
 
-        it "should be successful" do
-          post :create, :shelf => @invalid_attrs
+        it 'should be successful' do
+          post :create, shelf: @invalid_attrs
           response.should be_success
         end
       end
     end
 
-    describe "When logged in as Librarian" do
+    describe 'When logged in as Librarian' do
       login_fixture_librarian
 
-      describe "with valid params" do
-        it "assigns a newly created shelf as @shelf" do
-          post :create, :shelf => @attrs
+      describe 'with valid params' do
+        it 'assigns a newly created shelf as @shelf' do
+          post :create, shelf: @attrs
           assigns(:shelf).should be_nil
         end
 
-        it "should be forbidden" do
-          post :create, :shelf => @attrs
+        it 'should be forbidden' do
+          post :create, shelf: @attrs
           response.should be_forbidden
         end
       end
 
-      describe "with invalid params" do
-        it "assigns a newly created but unsaved shelf as @shelf" do
-          post :create, :shelf => @invalid_attrs
+      describe 'with invalid params' do
+        it 'assigns a newly created but unsaved shelf as @shelf' do
+          post :create, shelf: @invalid_attrs
           assigns(:shelf).should be_nil
         end
 
-        it "should be forbidden" do
-          post :create, :shelf => @invalid_attrs
+        it 'should be forbidden' do
+          post :create, shelf: @invalid_attrs
           response.should be_forbidden
         end
       end
     end
 
-    describe "When logged in as User" do
+    describe 'When logged in as User' do
       login_fixture_user
 
-      describe "with valid params" do
-        it "assigns a newly created shelf as @shelf" do
-          post :create, :shelf => @attrs
+      describe 'with valid params' do
+        it 'assigns a newly created shelf as @shelf' do
+          post :create, shelf: @attrs
           assigns(:shelf).should be_nil
         end
 
-        it "should be forbidden" do
-          post :create, :shelf => @attrs
+        it 'should be forbidden' do
+          post :create, shelf: @attrs
           response.should be_forbidden
         end
       end
 
-      describe "with invalid params" do
-        it "assigns a newly created but unsaved shelf as @shelf" do
-          post :create, :shelf => @invalid_attrs
+      describe 'with invalid params' do
+        it 'assigns a newly created but unsaved shelf as @shelf' do
+          post :create, shelf: @invalid_attrs
           assigns(:shelf).should be_nil
         end
 
-        it "should be forbidden" do
-          post :create, :shelf => @invalid_attrs
+        it 'should be forbidden' do
+          post :create, shelf: @invalid_attrs
           response.should be_forbidden
         end
       end
     end
 
-    describe "When not logged in" do
-      describe "with valid params" do
-        it "assigns a newly created shelf as @shelf" do
-          post :create, :shelf => @attrs
+    describe 'When not logged in' do
+      describe 'with valid params' do
+        it 'assigns a newly created shelf as @shelf' do
+          post :create, shelf: @attrs
           assigns(:shelf).should be_nil
         end
 
-        it "should be forbidden" do
-          post :create, :shelf => @attrs
+        it 'should be forbidden' do
+          post :create, shelf: @attrs
           response.should redirect_to(new_user_session_url)
         end
       end
 
-      describe "with invalid params" do
-        it "assigns a newly created but unsaved shelf as @shelf" do
-          post :create, :shelf => @invalid_attrs
+      describe 'with invalid params' do
+        it 'assigns a newly created but unsaved shelf as @shelf' do
+          post :create, shelf: @invalid_attrs
           assigns(:shelf).should be_nil
         end
 
-        it "should be forbidden" do
-          post :create, :shelf => @invalid_attrs
+        it 'should be forbidden' do
+          post :create, shelf: @invalid_attrs
           response.should redirect_to(new_user_session_url)
         end
       end
     end
   end
 
-  describe "PUT update" do
+  describe 'PUT update' do
     before(:each) do
       @shelf = FactoryGirl.create(:shelf)
       @attrs = valid_attributes
-      @invalid_attrs = {:name => ''}
+      @invalid_attrs = { name: '' }
     end
 
-    describe "When logged in as Administrator" do
+    describe 'When logged in as Administrator' do
       login_fixture_admin
 
-      describe "with valid params" do
-        it "updates the requested shelf" do
-          put :update, :id => @shelf.id, :shelf => @attrs
+      describe 'with valid params' do
+        it 'updates the requested shelf' do
+          put :update, id: @shelf.id, shelf: @attrs
         end
 
-        it "assigns the requested shelf as @shelf" do
-          put :update, :id => @shelf.id, :shelf => @attrs
+        it 'assigns the requested shelf as @shelf' do
+          put :update, id: @shelf.id, shelf: @attrs
           assigns(:shelf).should eq(@shelf)
         end
 
-        it "moves its position when specified" do
-          put :update, :id => @shelf.id, :shelf => @attrs, :move => 'lower'
+        it 'moves its position when specified' do
+          put :update, id: @shelf.id, shelf: @attrs, move: 'lower'
           response.should redirect_to(shelves_url(library_id: @shelf.library_id))
         end
       end
 
-      describe "with invalid params" do
-        it "assigns the requested shelf as @shelf" do
-          put :update, :id => @shelf.id, :shelf => @invalid_attrs
-          response.should render_template("edit")
+      describe 'with invalid params' do
+        it 'assigns the requested shelf as @shelf' do
+          put :update, id: @shelf.id, shelf: @invalid_attrs
+          response.should render_template('edit')
         end
       end
     end
 
-    describe "When logged in as Librarian" do
+    describe 'When logged in as Librarian' do
       login_fixture_librarian
 
-      describe "with valid params" do
-        it "updates the requested shelf" do
-          put :update, :id => @shelf.id, :shelf => @attrs
+      describe 'with valid params' do
+        it 'updates the requested shelf' do
+          put :update, id: @shelf.id, shelf: @attrs
         end
 
-        it "assigns the requested shelf as @shelf" do
-          put :update, :id => @shelf.id, :shelf => @attrs
+        it 'assigns the requested shelf as @shelf' do
+          put :update, id: @shelf.id, shelf: @attrs
           assigns(:shelf).should eq(@shelf)
           response.should be_forbidden
         end
       end
 
-      describe "with invalid params" do
-        it "assigns the requested shelf as @shelf" do
-          put :update, :id => @shelf.id, :shelf => @invalid_attrs
+      describe 'with invalid params' do
+        it 'assigns the requested shelf as @shelf' do
+          put :update, id: @shelf.id, shelf: @invalid_attrs
           response.should be_forbidden
         end
       end
     end
 
-    describe "When logged in as User" do
+    describe 'When logged in as User' do
       login_fixture_user
 
-      describe "with valid params" do
-        it "updates the requested shelf" do
-          put :update, :id => @shelf.id, :shelf => @attrs
+      describe 'with valid params' do
+        it 'updates the requested shelf' do
+          put :update, id: @shelf.id, shelf: @attrs
         end
 
-        it "assigns the requested shelf as @shelf" do
-          put :update, :id => @shelf.id, :shelf => @attrs
+        it 'assigns the requested shelf as @shelf' do
+          put :update, id: @shelf.id, shelf: @attrs
           assigns(:shelf).should eq(@shelf)
           response.should be_forbidden
         end
       end
 
-      describe "with invalid params" do
-        it "assigns the requested shelf as @shelf" do
-          put :update, :id => @shelf.id, :shelf => @invalid_attrs
+      describe 'with invalid params' do
+        it 'assigns the requested shelf as @shelf' do
+          put :update, id: @shelf.id, shelf: @invalid_attrs
           response.should be_forbidden
         end
       end
     end
 
-    describe "When not logged in" do
-      describe "with valid params" do
-        it "updates the requested shelf" do
-          put :update, :id => @shelf.id, :shelf => @attrs
+    describe 'When not logged in' do
+      describe 'with valid params' do
+        it 'updates the requested shelf' do
+          put :update, id: @shelf.id, shelf: @attrs
         end
 
-        it "should be forbidden" do
-          put :update, :id => @shelf.id, :shelf => @attrs
+        it 'should be forbidden' do
+          put :update, id: @shelf.id, shelf: @attrs
           response.should redirect_to(new_user_session_url)
         end
       end
 
-      describe "with invalid params" do
-        it "assigns the requested shelf as @shelf" do
-          put :update, :id => @shelf.id, :shelf => @invalid_attrs
+      describe 'with invalid params' do
+        it 'assigns the requested shelf as @shelf' do
+          put :update, id: @shelf.id, shelf: @invalid_attrs
           response.should redirect_to(new_user_session_url)
         end
       end
     end
   end
 
-  describe "DELETE destroy" do
+  describe 'DELETE destroy' do
     before(:each) do
       @shelf = FactoryGirl.create(:shelf)
     end
 
-    describe "When logged in as Administrator" do
+    describe 'When logged in as Administrator' do
       login_fixture_admin
 
-      it "destroys the requested shelf" do
-        delete :destroy, :id => @shelf.id
+      it 'destroys the requested shelf' do
+        delete :destroy, id: @shelf.id
       end
 
-      it "redirects to the shelves list" do
-        delete :destroy, :id => @shelf.id
+      it 'redirects to the shelves list' do
+        delete :destroy, id: @shelf.id
         response.should redirect_to(shelves_url)
       end
 
-      it "should not destroy a shelf that has id 1" do
-        delete :destroy, :id => 1
+      it 'should not destroy a shelf that has id 1' do
+        delete :destroy, id: 1
         response.should be_forbidden
       end
     end
 
-    describe "When logged in as Librarian" do
+    describe 'When logged in as Librarian' do
       login_fixture_librarian
 
-      it "destroys the requested shelf" do
-        delete :destroy, :id => @shelf.id
+      it 'destroys the requested shelf' do
+        delete :destroy, id: @shelf.id
       end
 
-      it "should be forbidden" do
-        delete :destroy, :id => @shelf.id
+      it 'should be forbidden' do
+        delete :destroy, id: @shelf.id
         response.should be_forbidden
       end
     end
 
-    describe "When logged in as User" do
+    describe 'When logged in as User' do
       login_fixture_user
 
-      it "destroys the requested shelf" do
-        delete :destroy, :id => @shelf.id
+      it 'destroys the requested shelf' do
+        delete :destroy, id: @shelf.id
       end
 
-      it "should be forbidden" do
-        delete :destroy, :id => @shelf.id
+      it 'should be forbidden' do
+        delete :destroy, id: @shelf.id
         response.should be_forbidden
       end
     end
 
-    describe "When not logged in" do
-      it "destroys the requested shelf" do
-        delete :destroy, :id => @shelf.id
+    describe 'When not logged in' do
+      it 'destroys the requested shelf' do
+        delete :destroy, id: @shelf.id
       end
 
-      it "should be forbidden" do
-        delete :destroy, :id => @shelf.id
+      it 'should be forbidden' do
+        delete :destroy, id: @shelf.id
         response.should redirect_to(new_user_session_url)
       end
     end