enju_library 0.2.0 → 0.2.1

data/spec/controllers/baskets_controller_spec.rb

@@ -3,120 +3,120 @@ require 'rails_helper'
 describe BasketsController do
   fixtures :all
 
-  describe "GET index" do
-    describe "When logged in as Administrator" do
+  describe 'GET index' do
+    describe 'When logged in as Administrator' do
       login_fixture_admin
 
-      it "assigns all baskets as @baskets" do
-        get :index, :user_id => users(:user1).username
+      it 'assigns all baskets as @baskets' do
+        get :index, user_id: users(:user1).username
         assigns(:baskets).should_not be_empty
         response.should be_success
       end
 
-      it "should get index without user_id" do
+      it 'should get index without user_id' do
         get :index
         response.should be_success
       end
     end
 
-    describe "When logged in as Librarian" do
+    describe 'When logged in as Librarian' do
       login_fixture_librarian
 
-      it "assigns all baskets as @baskets" do
-        get :index, :user_id => users(:user1).username
+      it 'assigns all baskets as @baskets' do
+        get :index, user_id: users(:user1).username
         assigns(:baskets).should_not be_empty
         response.should be_success
       end
     end
 
-    describe "When logged in as User" do
+    describe 'When logged in as User' do
       login_fixture_user
 
-      it "assigns all baskets as @baskets" do
-        get :index, :user_id => users(:user1).username
+      it 'assigns all baskets as @baskets' do
+        get :index, user_id: users(:user1).username
         assigns(:baskets).should be_nil
         response.should be_forbidden
       end
     end
 
-    describe "When not logged in" do
-      it "assigns all baskets as @baskets" do
-        get :index, :user_id => users(:user1).username
+    describe 'When not logged in' do
+      it 'assigns all baskets as @baskets' do
+        get :index, user_id: users(:user1).username
         assigns(:baskets).should be_nil
         response.should redirect_to(new_user_session_url)
       end
     end
   end
 
-  describe "GET show" do
-    describe "When logged in as Administrator" do
+  describe 'GET show' do
+    describe 'When logged in as Administrator' do
       login_fixture_admin
 
-      it "assigns the requested basket as @basket" do
-        get :show, :id => 1, :user_id => users(:admin).username
+      it 'assigns the requested basket as @basket' do
+        get :show, id: 1, user_id: users(:admin).username
         assigns(:basket).should eq(Basket.find(1))
       end
     end
 
-    describe "When logged in as Librarian" do
+    describe 'When logged in as Librarian' do
       login_fixture_librarian
 
-      it "assigns the requested basket as @basket" do
-        get :show, :id => 1, :user_id => users(:admin).username
+      it 'assigns the requested basket as @basket' do
+        get :show, id: 1, user_id: users(:admin).username
         assigns(:basket).should eq(Basket.find(1))
       end
     end
 
-    describe "When logged in as User" do
+    describe 'When logged in as User' do
       login_fixture_user
 
-      it "assigns the requested basket as @basket" do
-        get :show, :id => 1, :user_id => users(:admin).username
+      it 'assigns the requested basket as @basket' do
+        get :show, id: 1, user_id: users(:admin).username
         assigns(:basket).should eq(Basket.find(1))
         response.should be_forbidden
       end
     end
 
-    describe "When not logged in" do
-      it "assigns the requested basket as @basket" do
-        get :show, :id => 1, :user_id => users(:admin).username
+    describe 'When not logged in' do
+      it 'assigns the requested basket as @basket' do
+        get :show, id: 1, user_id: users(:admin).username
         assigns(:basket).should eq(Basket.find(1))
         response.should redirect_to(new_user_session_url)
       end
     end
   end
 
-  describe "GET new" do
-    describe "When logged in as Administrator" do
+  describe 'GET new' do
+    describe 'When logged in as Administrator' do
       login_fixture_admin
 
-      it "assigns the requested basket as @basket" do
+      it 'assigns the requested basket as @basket' do
         get :new
         assigns(:basket).should_not be_valid
       end
     end
 
-    describe "When logged in as Librarian" do
+    describe 'When logged in as Librarian' do
       login_fixture_librarian
 
-      it "assigns the requested basket as @basket" do
+      it 'assigns the requested basket as @basket' do
         get :new
         assigns(:basket).should_not be_valid
       end
     end
 
-    describe "When logged in as User" do
+    describe 'When logged in as User' do
       login_fixture_user
 
-      it "should not assign the requested basket as @basket" do
+      it 'should not assign the requested basket as @basket' do
         get :new
         assigns(:basket).should be_nil
         response.should be_forbidden
       end
     end
 
-    describe "When not logged in" do
-      it "should not assign the requested basket as @basket" do
+    describe 'When not logged in' do
+      it 'should not assign the requested basket as @basket' do
         get :new
         assigns(:basket).should be_nil
         response.should redirect_to(new_user_session_url)
@@ -124,175 +124,175 @@ describe BasketsController do
     end
   end
 
-  describe "GET edit" do
-    describe "When logged in as Administrator" do
+  describe 'GET edit' do
+    describe 'When logged in as Administrator' do
       login_fixture_admin
       before(:each) do
         @basket = baskets(:basket_00001)
       end
 
-      it "assigns the requested basket as @basket" do
-        get :edit, :id => @basket.id
+      it 'assigns the requested basket as @basket' do
+        get :edit, id: @basket.id
         assigns(:basket).should eq(@basket)
       end
     end
 
-    describe "When logged in as Librarian" do
+    describe 'When logged in as Librarian' do
       login_fixture_librarian
       before(:each) do
         @basket = baskets(:basket_00001)
       end
 
-      it "assigns the requested basket as @basket" do
-        get :edit, :id => @basket.id
+      it 'assigns the requested basket as @basket' do
+        get :edit, id: @basket.id
         assigns(:basket).should eq(@basket)
       end
     end
 
-    describe "When logged in as User" do
+    describe 'When logged in as User' do
       login_fixture_user
       before(:each) do
         @basket = baskets(:basket_00001)
       end
 
-      it "should not assign the requested basket as @basket" do
-        get :edit, :id => @basket.id
+      it 'should not assign the requested basket as @basket' do
+        get :edit, id: @basket.id
         assigns(:basket).should eq(@basket)
         response.should be_forbidden
       end
     end
 
-    describe "When not logged in" do
+    describe 'When not logged in' do
       before(:each) do
         @basket = baskets(:basket_00001)
       end
 
-      it "should not assign the requested basket as @basket" do
-        get :edit, :id => @basket.id
+      it 'should not assign the requested basket as @basket' do
+        get :edit, id: @basket.id
         assigns(:basket).should eq(@basket)
         response.should redirect_to new_user_session_url
       end
     end
   end
 
-  describe "POST create" do
+  describe 'POST create' do
     before(:each) do
-      @attrs = {:user_number => users(:user1).profile.user_number }
-      @invalid_attrs = {:user_number => 'invalid'}
+      @attrs = { user_number: users(:user1).profile.user_number }
+      @invalid_attrs = { user_number: 'invalid' }
     end
 
-    describe "When logged in as Administrator" do
+    describe 'When logged in as Administrator' do
       login_fixture_admin
 
-      describe "with valid params" do
-        it "assigns a newly created basket as @basket" do
-          post :create, :basket => {:user_number => users(:user1).profile.user_number }
+      describe 'with valid params' do
+        it 'assigns a newly created basket as @basket' do
+          post :create, basket: { user_number: users(:user1).profile.user_number }
           assigns(:basket).should be_valid
         end
       end
 
-      describe "with blank params" do
-        it "assigns a newly created basket as @basket" do
-          post :create, :basket => { note: 'test' }
+      describe 'with blank params' do
+        it 'assigns a newly created basket as @basket' do
+          post :create, basket: { note: 'test' }
           assigns(:basket).should_not be_valid
         end
       end
 
-      describe "with invalid params" do
-        it "assigns a newly created basket as @basket" do
-          post :create, :basket => @invalid_attrs
+      describe 'with invalid params' do
+        it 'assigns a newly created basket as @basket' do
+          post :create, basket: @invalid_attrs
           assigns(:basket).should_not be_valid
         end
       end
     end
 
-    describe "When logged in as Librarian" do
+    describe 'When logged in as Librarian' do
       login_fixture_librarian
 
-      describe "with valid params" do
-        it "assigns a newly created basket as @basket" do
-          post :create, :basket => {:user_number => users(:user1).profile.user_number }
+      describe 'with valid params' do
+        it 'assigns a newly created basket as @basket' do
+          post :create, basket: { user_number: users(:user1).profile.user_number }
           assigns(:basket).should be_valid
         end
       end
 
-      describe "with blank params" do
-        it "assigns a newly created basket as @basket" do
-          post :create, :basket => { note: 'test' }
+      describe 'with blank params' do
+        it 'assigns a newly created basket as @basket' do
+          post :create, basket: { note: 'test' }
           assigns(:basket).should_not be_valid
         end
       end
 
-      describe "with invalid params" do
-        it "assigns a newly created basket as @basket" do
-          post :create, :basket => @invalid_attrs
+      describe 'with invalid params' do
+        it 'assigns a newly created basket as @basket' do
+          post :create, basket: @invalid_attrs
           assigns(:basket).should_not be_valid
         end
       end
 
-      it "should not create basket when user is suspended" do
-        post :create, :basket => {:user_number => users(:user4).profile.user_number }
+      it 'should not create basket when user is suspended' do
+        post :create, basket: { user_number: users(:user4).profile.user_number }
         assigns(:basket).should_not be_valid
-        assigns(:basket).errors["base"].include?(I18n.t('basket.this_account_is_suspended')).should be_truthy
+        assigns(:basket).errors['base'].include?(I18n.t('basket.this_account_is_suspended')).should be_truthy
         response.should be_success
       end
 
-      it "should not create basket when user is not found" do
-        post :create, :basket => {:user_number => 'not found' }
+      it 'should not create basket when user is not found' do
+        post :create, basket: { user_number: 'not found' }
         assigns(:basket).should_not be_valid
-        assigns(:basket).errors["base"].include?(I18n.t('user.not_found')).should be_truthy
+        assigns(:basket).errors['base'].include?(I18n.t('user.not_found')).should be_truthy
         response.should be_success
       end
 
-      it "should not create basket without user_number" do
-        post :create, :basket => { note: 'test' }
+      it 'should not create basket without user_number' do
+        post :create, basket: { note: 'test' }
         assigns(:basket).should_not be_valid
         response.should be_success
       end
 
-      it "should create basket" do
-        post :create, :basket => {:user_number => users(:user1).profile.user_number }
+      it 'should create basket' do
+        post :create, basket: { user_number: users(:user1).profile.user_number }
         assigns(:basket).should be_valid
         response.should redirect_to new_checked_item_url(basket_id: assigns(:basket).id)
       end
 
-      it "should not create basket without user_number" do
-        post :create, :basket => { note: 'test' }
+      it 'should not create basket without user_number' do
+        post :create, basket: { note: 'test' }
         assigns(:basket).should_not be_valid
         response.should be_success
       end
     end
 
-    describe "When logged in as User" do
+    describe 'When logged in as User' do
       login_fixture_user
 
-      describe "with valid params" do
-        it "assigns a newly created basket as @basket" do
-          post :create, :basket => {:user_number => users(:user1).profile.user_number }
+      describe 'with valid params' do
+        it 'assigns a newly created basket as @basket' do
+          post :create, basket: { user_number: users(:user1).profile.user_number }
           assigns(:basket).should be_nil
         end
 
-        it "should be forbidden" do
-          post :create, :basket => {:user_number => users(:user1).profile.user_number }
+        it 'should be forbidden' do
+          post :create, basket: { user_number: users(:user1).profile.user_number }
           response.should be_forbidden
         end
       end
 
-      it "should not create basket" do
-        post :create, :basket => {:user_number => users(:user1).profile.user_number }
+      it 'should not create basket' do
+        post :create, basket: { user_number: users(:user1).profile.user_number }
         response.should be_forbidden
       end
     end
 
-    describe "When not logged in" do
-      describe "with blank params" do
-        it "assigns a newly created basket as @basket" do
-          post :create, :basket => { note: 'test' }
+    describe 'When not logged in' do
+      describe 'with blank params' do
+        it 'assigns a newly created basket as @basket' do
+          post :create, basket: { note: 'test' }
           assigns(:basket).should be_nil
         end
 
-        it "should be redirected to new_user_session_url" do
-          post :create, :basket => { note: 'test' }
+        it 'should be redirected to new_user_session_url' do
+          post :create, basket: { note: 'test' }
           assigns(:basket).should be_nil
           assert_response :redirect
           response.should redirect_to new_user_session_url
@@ -301,21 +301,21 @@ describe BasketsController do
     end
   end
 
-  describe "PUT update" do
+  describe 'PUT update' do
     before(:each) do
-      @attrs = {:user_id => users(:user1).username}
+      @attrs = { user_id: users(:user1).username }
     end
 
-    describe "When logged in as Librarian" do
+    describe 'When logged in as Librarian' do
       login_fixture_librarian
 
-      describe "with valid params" do
-        it "updates the requested basket" do
-          put :update, :id => 8, :basket => @attrs
+      describe 'with valid params' do
+        it 'updates the requested basket' do
+          put :update, id: 8, basket: @attrs
         end
 
-        it "assigns the requested basket as @basket" do
-          put :update, :id => 8, :basket => @attrs
+        it 'assigns the requested basket as @basket' do
+          put :update, id: 8, basket: @attrs
           assigns(:basket).checkouts.order('created_at DESC').first.item.circulation_status.name.should eq 'On Loan'
           response.should redirect_to(checkouts_url(user_id: assigns(:basket).user.username))
         end
@@ -323,55 +323,55 @@ describe BasketsController do
     end
   end
 
-  describe "DELETE destroy" do
+  describe 'DELETE destroy' do
     before(:each) do
       @basket = FactoryGirl.create(:basket)
     end
 
-    describe "When logged in as Administrator" do
+    describe 'When logged in as Administrator' do
       login_fixture_admin
 
-      it "should destroy basket without user_id" do
-        delete :destroy, :id => 1, :basket => {:user_id => nil}, :user_id => users(:user1).username
+      it 'should destroy basket without user_id' do
+        delete :destroy, id: 1, basket: { user_id: nil }, user_id: users(:user1).username
         response.should redirect_to(checkouts_url(user_id: assigns(:basket).user.username))
       end
 
-      it "should destroy basket" do
-        delete :destroy, :id => 1, :basket => { }, :user_id => users(:user1).username
+      it 'should destroy basket' do
+        delete :destroy, id: 1, basket: {}, user_id: users(:user1).username
         response.should redirect_to(checkouts_url(user_id: assigns(:basket).user.username))
       end
     end
 
-    describe "When logged in as Librarian" do
+    describe 'When logged in as Librarian' do
       login_fixture_librarian
 
-      it "should destroy basket without user_id" do
-        delete :destroy, :id => 1, :basket => {:user_id => nil}, :user_id => users(:user1).username
+      it 'should destroy basket without user_id' do
+        delete :destroy, id: 1, basket: { user_id: nil }, user_id: users(:user1).username
         response.should redirect_to(checkouts_url(user_id: assigns(:basket).user.username))
       end
 
-      it "should destroy basket" do
-        delete :destroy, :id => 1, :basket => { }, :user_id => users(:user1).username
+      it 'should destroy basket' do
+        delete :destroy, id: 1, basket: {}, user_id: users(:user1).username
         response.should redirect_to(checkouts_url(user_id: assigns(:basket).user.username))
       end
     end
 
-    describe "When logged in as User" do
+    describe 'When logged in as User' do
       login_fixture_user
 
-      it "should not destroy basket" do
-        delete :destroy, :id => 3, :user_id => users(:user1).username
+      it 'should not destroy basket' do
+        delete :destroy, id: 3, user_id: users(:user1).username
         response.should be_forbidden
       end
     end
-  
-    describe "When not logged in" do
-      it "destroys the requested basket" do
-        delete :destroy, :id => @basket.id
+
+    describe 'When not logged in' do
+      it 'destroys the requested basket' do
+        delete :destroy, id: @basket.id
       end
 
-      it "should be forbidden" do
-        delete :destroy, :id => @basket.id
+      it 'should be forbidden' do
+        delete :destroy, id: @basket.id
         response.should redirect_to new_user_session_url
       end
     end