elmas 2.4.2 → 2.5.0

data/lib/elmas/resources/shared_sales_attributes.rb

@@ -1,16 +1,11 @@
+# frozen_string_literal: true
+
 module Elmas
   module SharedSalesAttributes
-    SHARED_SALES_ATTRIBUTES = [
-      :currency, :invoice_to, :invoice_to_contact_person, :invoice_date,
-      :description, :document, :order_date, :ordered_by_contact_person,
-      :tax_schedule, :order_number, :payment_condition, :payment_reference,
-      :remarks, :your_ref, :amount_DC
-    ].freeze
+    SHARED_SALES_ATTRIBUTES = %i[currency invoice_to invoice_to_contact_person invoice_date description document order_date ordered_by_contact_person
+                                 tax_schedule order_number payment_condition payment_reference remarks your_ref amount_DC].freeze
 
-    SHARED_LINE_ATTRIBUTES = [
-      :discount, :quantity, :amount_FC, :description, :VAT_code, :cost_center,
-      :cost_unit, :VAT_percentage, :unit_code, :tax_schedule, :net_price, :notes,
-      :pricelist, :project, :amount_DC
-    ].freeze
+    SHARED_LINE_ATTRIBUTES = %i[discount quantity amount_FC description VAT_code cost_center cost_unit VAT_percentage unit_code tax_schedule
+                                net_price notes pricelist project amount_DC].freeze
   end
 end

data/lib/elmas/resources/time_transaction.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Elmas
   class TimeTransaction
     include Elmas::Resource
@@ -7,22 +9,16 @@ module Elmas
     end
 
     def mandatory_attributes
-      [:account, :item, :quantity]
+      %i[account item quantity]
     end
 
     # https://start.exactonline.nl/docs/HlpRestAPIResourcesDetails.aspx?name=ProjectTimeTransactions
     def other_attributes
-      [
-        :account, :account_name, :activity, :activity_description, :amount, :amount_fc,
-        :attachment, :created, :creator, :creator_full_name, :currency, :date,
-        :division, :division_description, :employee, :end_time, :entry_number,
-        :error_text, :hour_status, :item, :item_description, :item_divisable,
-        :modified, :modifier, :modifier_full_name, :notes, :price, :price_fc, :project,
-        :project_account, :project_account_code, :project_account_name,
-        :project_description, :quantity, :start_time, :subscription,
-        :subscription_account, :subscription_account_code, :subscription_account_name,
-        :subscription_description, :subscription_number, :type
-      ]
+      %i[account account_name activity activity_description amount amount_fc attachment created creator creator_full_name currency date division
+         division_description employee end_time entry_number error_text hour_status item item_description item_divisable modified modifier
+         modifier_full_name notes price price_fc project project_account project_account_code project_account_name project_description quantity
+         start_time subscription subscription_account subscription_account_code subscription_account_name subscription_description
+         subscription_number type]
     end
   end
 end

data/lib/elmas/resources/transaction.rb

@@ -1,9 +1,11 @@
+# frozen_string_literal: true
+
 module Elmas
   class Transaction
     include Elmas::Resource
 
     def valid_actions
-      [:get]
+      %i[get]
     end
 
     def base_path
@@ -15,7 +17,7 @@ module Elmas
     end
 
     def other_attributes
-      [:description]
+      %i[description]
     end
   end
 end

data/lib/elmas/resources/transaction_line.rb

@@ -1,9 +1,11 @@
+# frozen_string_literal: true
+
 module Elmas
   class TransactionLine
     include Elmas::Resource
 
     def valid_actions
-      [:get]
+      %i[get]
     end
 
     def base_path
@@ -15,7 +17,7 @@ module Elmas
     end
 
     def other_attributes
-      [:asset_code]
+      %i[asset_code]
     end
   end
 end

data/lib/elmas/resources/vat_code.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Elmas
   class VatCode
     include Elmas::Resource
@@ -7,17 +9,12 @@ module Elmas
     end
 
     def other_attributes
-      [
-        :account, :calculation_basis, :charged, :EU_sales_listing,
-        :GL_discount_purchase, :GL_discount_sales, :GL_to_claim, :GL_to_pay,
-        :intra_stat, :is_blocked, :legal_text, :tax_return_type, :type,
-        :vat_doc_type, :vat_margin, :VAT_partial_ratio, :VAT_percentages,
-        :VAT_transaction_type
-      ]
+      %i[account calculation_basis charged EU_sales_listing GL_discount_purchase GL_discount_sales GL_to_claim GL_to_pay intra_stat is_blocked
+         legal_text tax_return_type type vat_doc_type vat_margin VAT_partial_ratio VAT_percentages VAT_transaction_type]
     end
 
     def mandatory_attributes
-      [:code, :description]
+      %i[code description]
     end
   end
 end

data/lib/elmas/response.rb

@@ -1,9 +1,12 @@
+# frozen_string_literal: true
+
 require File.expand_path("../parser", __FILE__)
 require File.expand_path("../utils", __FILE__)
 
 module Elmas
   class Response
-    attr_accessor :status_code, :body, :response
+    attr_accessor :status_code, :response
+    attr_writer :body
 
     def initialize(response)
       @response = response
@@ -63,7 +66,7 @@ module Elmas
 
     def raise_and_log_error
       log_error
-      fail BadRequestException.new(@response, parsed)
+      raise BadRequestException.new(@response, parsed)
     end
   end
 end

data/lib/elmas/result_set.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Elmas
   class ResultSet
     attr_reader :records
@@ -45,10 +47,10 @@ module Elmas
     def resource_class
       @resource_class ||= begin
         constant_name = type.classify
-        fail NameError unless constant_name =~ /\A[a-zA-Z0-9]+\z/
+        raise NameError unless constant_name =~ /\A[a-zA-Z0-9]+\z/
 
         klass = Elmas.const_get(constant_name, false)
-        fail NameError unless klass.included_modules.include?(Elmas::Resource)
+        raise NameError unless klass.included_modules.include?(Elmas::Resource)
 
         klass
       rescue NameError

data/lib/elmas/sanitizer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "active_support"
 require "active_support/time"
 require "active_support/core_ext/time/zones"
@@ -20,17 +22,17 @@ module Elmas
       # rubocop:disable Metrics/PerceivedComplexity
       def sanitize_relationship(value)
         if value.is_a?(Elmas::Resource)
-          return value.id # Turn relation into ID
+          value.id # Turn relation into ID
         elsif value.is_a?(Array)
-          return sanitize_has_many(value)
+          sanitize_has_many(value)
         elsif value.is_a?(Time) || value.is_a?(Date) || value.is_a?(DateTime)
-          return sanitize_date_time(value)
+          sanitize_date_time(value)
         elsif value.is_a?(String) && value.match(/(Date\()/)
           number = value.scan(/\d+/).first.to_i / 1000.0
           Time.zone = ActiveSupport::TimeZone.new("Europe/Amsterdam")
-          return sanitize_date_time(Time.zone.at(number))
+          sanitize_date_time(Time.zone.at(number))
         else
-          return value
+          value
         end
       end
       # rubocop:enable Metrics/CyclomaticComplexity

data/lib/elmas/uri.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Elmas
   module Resource
     module UriMethods

data/lib/elmas/utils.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Elmas
   module Utils
     def self.demodulize(class_name_in_module)

data/lib/elmas/version.rb

@@ -1,8 +1,10 @@
+# frozen_string_literal: true
+
 module Elmas
   class Version
     MAJOR = 2
-    MINOR = 4
-    PATCH = 2
+    MINOR = 5
+    PATCH = 0
 
     class << self
       def to_s

metadata

@@ -1,71 +1,71 @@
 --- !ruby/object:Gem::Specification
 name: elmas
 version: !ruby/object:Gem::Version
-  version: 2.4.2
+  version: 2.5.0
 platform: ruby
 authors:
 - Marthyn
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-07-12 00:00:00.000000000 Z
+date: 2017-12-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: faraday
+  name: activeresource
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.12.1
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.12.1
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: mechanize
+  name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.7.5
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.7.5
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: activesupport
+  name: faraday
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.12.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.12.1
 - !ruby/object:Gem::Dependency
-  name: activeresource
+  name: mechanize
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 2.7.5
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 2.7.5
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -81,7 +81,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: dotenv
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -95,7 +95,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: guard-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -109,7 +109,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: simplecov
+  name: guard-rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -123,7 +123,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: simplecov-rcov
+  name: listen
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -137,7 +137,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: webmock
+  name: mutant-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -151,7 +151,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rubycritic
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -165,7 +165,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: guard-rspec
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -179,7 +179,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: guard-rubocop
+  name: ruby_dep
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -193,7 +193,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: listen
+  name: rubycritic
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -207,7 +207,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: ruby_dep
+  name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -221,7 +221,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: mutant-rspec
+  name: simplecov-rcov
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -235,7 +235,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: dotenv
+  name: webmock
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -276,7 +276,6 @@ files:
 - lib/elmas/client.rb
 - lib/elmas/config.rb
 - lib/elmas/exception.rb
-- lib/elmas/log.rb
 - lib/elmas/oauth.rb
 - lib/elmas/parser.rb
 - lib/elmas/request.rb
@@ -287,9 +286,12 @@ files:
 - lib/elmas/resources/bank_entry.rb
 - lib/elmas/resources/bank_entry_line.rb
 - lib/elmas/resources/base_entry_line.rb
+- lib/elmas/resources/cash_entry.rb
+- lib/elmas/resources/cash_entry_line.rb
 - lib/elmas/resources/contact.rb
 - lib/elmas/resources/costcenter.rb
 - lib/elmas/resources/costunit.rb
+- lib/elmas/resources/division.rb
 - lib/elmas/resources/document.rb
 - lib/elmas/resources/document_attachment.rb
 - lib/elmas/resources/general_journal_entry.rb

data/lib/elmas/log.rb

@@ -1,19 +0,0 @@
-require "logger"
-
-module Elmas
-  module Log
-    def logger
-      dir = File.dirname("./tmp/errors.log")
-      FileUtils.mkdir_p(dir) unless File.directory?(dir)
-      Logger.new("./tmp/errors.log", "daily")
-    end
-
-    def info(msg)
-      logger.info(msg)
-    end
-
-    def error(msg)
-      logger.error(msg)
-    end
-  end
-end