elmas 2.4.2 → 2.5.0

data/lib/elmas/resources/item.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Elmas
   class Item
     include Elmas::Resource
@@ -7,26 +9,27 @@ module Elmas
     end
 
     def mandatory_attributes
-      [:code, :description]
+      %i[code description]
     end
 
-    def other_attributes # rubocop:disable Metrics/MethodLength
-      [
-        :class_01, :class_02, :class_03, :class_04, :class_05, :copy_remarks,
-        :cost_price_currency, :cost_price_new, :cost_price_standard, :end_date,
-        :extra_description, :free_bool_field_01, :free_bool_field_02, :free_bool_field_03,
-        :free_bool_field_04, :free_bool_field_05, :free_date_field_01, :free_date_field_02,
-        :free_date_field_03, :free_date_field_04, :free_date_field_05, :free_number_field_01,
-        :free_number_field_02, :free_number_field_03, :free_number_field_04, :free_number_field_05,
-        :free_number_field_06, :free_number_field_07, :free_number_field_08, :free_text_field_01,
-        :free_text_field_02, :free_text_field_03, :free_text_field_04, :free_text_field_05,
-        :free_text_field_06, :free_text_field_07, :free_text_field_08, :free_text_field_09,
-        :free_text_field_10, :GL_costs, :GL_revenue, :GL_stock, :is_batch_item,
-        :is_batch_number_item, :is_fraction_allowed_item, :is_make_item, :is_new_contract,
-        :is_on_demand_item, :is_package_item, :is_registration_code_item, :is_purchase_item,
-        :is_sales_item, :is_serial_item, :is_serial_number_item, :is_stock_item,
-        :is_subcontracted_item, :is_time, :is_webshop_item, :item_group, :notes,
-        :sales_vat_code, :search_code, :security_level, :start_date, :unit
+    # rubocop:disable Metrics/MethodLength
+    def other_attributes
+      %i[
+        class_01 class_02 class_03 class_04 class_05 copy_remarks
+        cost_price_currency cost_price_new cost_price_standard end_date
+        extra_description free_bool_field_01 free_bool_field_02 free_bool_field_03
+        free_bool_field_04 free_bool_field_05 free_date_field_01 free_date_field_02
+        free_date_field_03 free_date_field_04 free_date_field_05 free_number_field_01
+        free_number_field_02 free_number_field_03 free_number_field_04 free_number_field_05
+        free_number_field_06 free_number_field_07 free_number_field_08 free_text_field_01
+        free_text_field_02 free_text_field_03 free_text_field_04 free_text_field_05
+        free_text_field_06 free_text_field_07 free_text_field_08 free_text_field_09
+        free_text_field_10 GL_costs GL_revenue GL_stock is_batch_item
+        is_batch_number_item is_fraction_allowed_item is_make_item is_new_contract
+        is_on_demand_item is_package_item is_registration_code_item is_purchase_item
+        is_sales_item is_serial_item is_serial_number_item is_stock_item
+        is_subcontracted_item is_time is_webshop_item item_group notes
+        sales_vat_code search_code security_level start_date unit
       ]
     end
   end

data/lib/elmas/resources/item_group.rb

@@ -1,9 +1,11 @@
+# frozen_string_literal: true
+
 module Elmas
   class ItemGroup
     include Elmas::Resource
 
     def valid_actions
-      [:get]
+      %i[get]
     end
 
     def base_path
@@ -11,7 +13,7 @@ module Elmas
     end
 
     def other_attributes
-      [:code]
+      %i[code]
     end
 
     def mandatory_attributes

data/lib/elmas/resources/journal.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Elmas
   class Journal
     include Elmas::Resource
@@ -11,10 +13,10 @@ module Elmas
     end
 
     def other_attributes
-      [
-        :code, :description, :allow_variable_currency, :allow_variable_exchange_rate,
-        :allow_VAT, :auto_save, :bank, :bank_account_ID, :bank_account_including_mask,
-        :currency, :GL_account, :payment_in_transit_account, :type
+      %i[
+        code description allow_variable_currency allow_variable_exchange_rate
+        allow_VAT auto_save bank bank_account_ID bank_account_including_mask
+        currency GL_account payment_in_transit_account type
       ]
     end
   end

data/lib/elmas/resources/layout.rb

@@ -1,9 +1,11 @@
+# frozen_string_literal: true
+
 module Elmas
   class Layout
     include Elmas::Resource
 
     def valid_actions
-      [:get]
+      %i[get]
     end
 
     def base_path
@@ -15,9 +17,9 @@ module Elmas
     end
 
     def other_attributes
-      [
-        :id, :created, :creator, :creator_full_name, :division,
-        :modified, :modifier, :modifier_full_name, :subject, :type
+      %i[
+        id created creator creator_full_name division
+        modified modifier modifier_full_name subject type
       ]
     end
   end

data/lib/elmas/resources/mailbox.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Elmas
   class Mailbox
     include Elmas::Resource
@@ -7,14 +9,14 @@ module Elmas
     end
 
     def other_attributes
-      [
-        :account, :description, :for_division, :publish,
-        :type, :valid_from, :valid_to
+      %i[
+        account description for_division publish
+        type valid_from valid_to
       ]
     end
 
     def mandatory_attributes
-      [:mailbox]
+      %i[mailbox]
     end
   end
 end

data/lib/elmas/resources/payment_condition.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Elmas
   class PaymentCondition
     include Elmas::Resource
@@ -7,16 +9,16 @@ module Elmas
     end
 
     def mandatory_attributes
-      [:code]
+      %i[code]
     end
 
-    # https://start.exactonline.nl/docs/HlpRestAPIResourcesDetails.aspx?name=CashflowPaymentConditions
+    # https//start.exactonline.nl/docs/HlpRestAPIResourcesDetails.aspx?name=CashflowPaymentConditions
     def other_attributes
-      [
-        :created, :description, :discount_payment_days,
-        :discount_percentage, :payment_days, :payment_discount_type,
-        :payment_end_of_months, :payment_method, :percentage,
-        :VAT_calculation
+      %i[
+        created description discount_payment_days
+        discount_percentage payment_days payment_discount_type
+        payment_end_of_months payment_method percentage
+        VAT_calculation
       ]
     end
   end

data/lib/elmas/resources/printed_sales_invoice.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Elmas
   # We can use the PrintedSalesInvoice to change the status of SalesInvoices from
   # Open to 'Verwerkt' while at the same time sending a PDF of the invoice to the
@@ -9,7 +11,7 @@ module Elmas
     include Elmas::Resource
 
     def valid_actions
-      [:post]
+      %i[post]
     end
 
     def base_path
@@ -17,18 +19,18 @@ module Elmas
     end
 
     def mandatory_attributes
-      [:invoice_ID]
+      %i[invoice_ID]
     end
 
-    # https://start.exactonline.nl/docs/HlpRestAPIResourcesDetails.aspx?name=SalesInvoicePrintedSalesInvoices
+    # https//start.exactonline.nl/docs/HlpRestAPIResourcesDetails.aspx?name=SalesInvoicePrintedSalesInvoices
     def other_attributes
-      [
-        :division, :document, :document_creation_error, :document_creation_success,
-        :document_layout, :email_creation_error, :email_creation_success, :email_layout,
-        :extra_text, :invoice_date, :postbox_message_creation_error,
-        :postbox_message_creation_success, :postbox_sender, :reporting_period,
-        :reporting_year, :send_email_to_customer, :send_invoice_to_customer_postbox,
-        :send_output_based_on_account
+      %i[
+        division document document_creation_error document_creation_success
+        document_layout email_creation_error email_creation_success email_layout
+        extra_text invoice_date postbox_message_creation_error
+        postbox_message_creation_success postbox_sender reporting_period
+        reporting_year send_email_to_customer send_invoice_to_customer_postbox
+        send_output_based_on_account
       ]
     end
   end

data/lib/elmas/resources/project.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Elmas
   class Project
     include Elmas::Resource
@@ -7,28 +9,18 @@ module Elmas
     end
 
     def mandatory_attributes
-      [:account, :description, :code, :type]
+      %i[account description code type]
     end
 
     # https://start.exactonline.nl/docs/HlpRestAPIResourcesDetails.aspx?name=ProjectProjects
-    def other_attributes # rubocop:disable Metrics/MethodLength
-      [
-        :account, :account_code, :AccountContact, :account_name,
-        :allow_additional_invoicing, :block_entry, :block_rebilling,
-        :budgeted_amount, :budgeted_costs, :budgeted_hours_per_hour_type,
-        :BudgetedRevenue, :BudgetType, :BudgetTypeDescription, :clasification,
-        :classification_description, :code, :costs_amount_fc, :created,
-        :creator, :creator_full_name, :customer_p_onumber, :description,
-        :division, :division_name, :end_date, :fixed_price_item,
-        :fixed_price_item_description, :invoice_as_quoted, :invoice_terms,
-        :manager, :manager_fullname, :markup_percentage, :modified, :modifier,
-        :modifier_full_name, :notes, :prepaid_item, :prepaid_item_description,
-        :prepaid_type, :prepaid_type_description,
-        :project_restriction_employees, :project_restriction_items,
-        :project_restriction_rebillings, :sales_time_quantity,
-        :source_quotation, :start_date, :time_quantity_to_alert, :type,
-        :type_description, :use_billing_milestones
-      ]
+    def other_attributes
+      %i[account account_code AccountContact account_name allow_additional_invoicing block_entry block_rebilling budgeted_amount budgeted_costs
+         budgeted_hours_per_hour_type BudgetedRevenue BudgetType BudgetTypeDescription clasification classification_description code costs_amount_fc
+         created creator creator_full_name customer_p_onumber description division division_name end_date fixed_price_item
+         fixed_price_item_description invoice_as_quoted invoice_terms manager manager_fullname markup_percentage modified modifier modifier_full_name
+         notes prepaid_item prepaid_item_description prepaid_type prepaid_type_description project_restriction_employees project_restriction_items
+         project_restriction_rebillings sales_time_quantity source_quotation start_date time_quantity_to_alert type type_description
+         use_billing_milestones]
     end
   end
 end

data/lib/elmas/resources/purchase_entry.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Elmas
   class PurchaseEntry
     include Elmas::Resource
@@ -7,15 +9,12 @@ module Elmas
     end
 
     def mandatory_attributes
-      [:journal, :purchase_entry_lines, :supplier]
+      %i[journal purchase_entry_lines supplier]
     end
 
     def other_attributes
-      [
-        :currency, :batch_number, :description, :document, :due_date, :entry_date,
-        :entry_number, :external_link_reference, :invoice_number, :rate, :reporting_period,
-        :reporting_year, :reversal, :VAT_amount_FC, :your_ref
-      ]
+      %i[currency batch_number description document due_date entry_date entry_number external_link_reference invoice_number rate reporting_period
+         reporting_year reversal VAT_amount_FC your_ref]
     end
   end
 end

data/lib/elmas/resources/purchase_entry_line.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Elmas
   class PurchaseEntryLine < Elmas::BaseEntryLine
     include Elmas::Resource

data/lib/elmas/resources/receivables_list.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Elmas
   # We can use the AgingReceivablesList to change the status of SalesInvoices from
   # Open to 'Verwerkt' while at the same time sending a PDF of the invoice to the
@@ -22,11 +24,8 @@ module Elmas
 
     # https://start.exactonline.nl/docs/HlpRestAPIResourcesDetails.aspx?name=ReadFinancialReceivablesList
     def other_attributes
-      [
-        :description, :hid, :account_code, :account_id, :account_name, :amount, :amount_in_transit,
-        :currency_code, :description, :due_date, :entry_number, :id, :invoice_date, :invoice_number,
-        :journal_code, :journal_description, :your_ref
-      ]
+      %i[description hid account_code account_id account_name amount amount_in_transit currency_code description due_date entry_number id
+         invoice_date invoice_number journal_code journal_description your_ref]
     end
   end
 end

data/lib/elmas/resources/sales_entry.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Elmas
   class SalesEntry
     # A sales entry needs multiple sales entry lines
@@ -9,16 +11,12 @@ module Elmas
     end
 
     def mandatory_attributes
-      [:journal, :customer, :sales_entry_lines]
+      %i[journal customer sales_entry_lines]
     end
 
     def other_attributes
-      [
-        :batch_number, :currency, :document, :due_date, :entry_date,
-        :entry_number, :invoice_number, :order_number, :payment_condition,
-        :payment_reference, :process_number, :rate, :reporting_period,
-        :reporting_year, :reversal, :VAT_amount_FC, :your_ref, :description
-      ]
+      %i[batch_number currency document due_date entry_date entry_number invoice_number order_number payment_condition payment_reference
+         process_number rate reporting_period reporting_year reversal VAT_amount_FC your_ref description]
     end
   end
 end

data/lib/elmas/resources/sales_entry_line.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Elmas
   class SalesEntryLine < Elmas::BaseEntryLine
     # A sales entry line belongs to a sales entry

data/lib/elmas/resources/sales_invoice.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Elmas
   class SalesInvoice
     # An sales_invoice usually has multiple sales_invoice lines
@@ -10,15 +12,12 @@ module Elmas
     end
 
     def mandatory_attributes
-      [:journal, :ordered_by]
+      [:ordered_by]
     end
 
     def other_attributes
       SHARED_SALES_ATTRIBUTES.inject(
-        [
-          :sales_invoice_lines, :due_date, :sales_person,
-          :starter_sales_invoice_status, :type
-        ],
+        %i[sales_invoice_lines due_date sales_person starter_sales_invoice_status type],
         :<<
       )
     end

data/lib/elmas/resources/sales_invoice_line.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Elmas
   class SalesInvoiceLine
     # An sales_invoice_line should always have a reference to an item and to an sales_invoice.
@@ -9,15 +11,12 @@ module Elmas
     end
 
     def mandatory_attributes
-      [:item, :invoice_ID]
+      %i[item invoice_ID]
     end
 
     def other_attributes
       SHARED_LINE_ATTRIBUTES.inject(
-        [
-          :employee, :end_time, :line_number, :start_time, :subscription,
-          :VAT_amount_DC, :VAT_amount_FC, :GL_account, :discount, :unit_price
-        ],
+        %i[employee end_time line_number start_time subscription VAT_amount_DC VAT_amount_FC GL_account discount unit_price],
         :<<
       )
     end

data/lib/elmas/resources/sales_item_prices.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Elmas
   class SalesItemPrices
     include Elmas::Resource
@@ -9,11 +11,8 @@ module Elmas
     def mandatory_attributes; end
 
     def other_attributes
-      [
-        :account, :account_name, :created, :creator, :creator_full_name, :currency, :default_item_unit, :default_item_unit_description,
-        :division, :end_date, :item, :item_code, :item_description, :modified, :modifier, :modifier_full_name, :number_of_items_per_unit,
-        :price, :quantity, :start_date, :unit, :unit_description
-      ]
+      %i[account account_name created creator creator_full_name currency default_item_unit default_item_unit_description division end_date item
+         item_code item_description modified modifier modifier_full_name number_of_items_per_unit price quantity start_date unit unit_description]
     end
   end
 end

data/lib/elmas/resources/sales_order.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Elmas
   class SalesOrder
     include Elmas::Resource
@@ -8,15 +10,12 @@ module Elmas
     end
 
     def mandatory_attributes
-      [:sales_order_lines, :ordered_by]
+      %i[sales_order_lines ordered_by]
     end
 
     def other_attributes
       SHARED_SALES_ATTRIBUTES.inject(
-        [
-          :deliver_to_contact_person, :delivery_date, :delivery_status,
-          :sales_person, :shipping_method, :status, :tax_schedule, :warehouse_ID
-        ],
+        %i[deliver_to_contact_person delivery_date delivery_status sales_person shipping_method status tax_schedule warehouse_ID],
         :<<
       )
     end

data/lib/elmas/resources/sales_order_line.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Elmas
   class SalesOrderLine
     include Elmas::Resource
@@ -8,15 +10,12 @@ module Elmas
     end
 
     def mandatory_attributes
-      [:item, :order_ID]
+      %i[item order_ID]
     end
 
     def other_attributes
       SHARED_LINE_ATTRIBUTES.inject(
-        [
-          :amount_FC, :delivery_date, :item_version, :order_number, :unit_price,
-          :use_drop_shipment, :VAT_amount
-        ],
+        %i[amount_FC delivery_date item_version order_number unit_price use_drop_shipment VAT_amount],
         :<<
       )
     end