dscf-credit 0.1.1 → 0.1.2

data/db/migrate/20250822091131_create_dscf_credit_credit_lines.rb

@@ -8,8 +8,10 @@ class CreateDscfCreditCreditLines < ActiveRecord::Migration[8.0]
       t.text :description
       t.string :status, default: 'pending'
       t.references :created_by, polymorphic: true, null: false
-      t.references :approved_by, polymorphic: true, null: true
-      t.datetime :approval_date
+      t.references :reviewed_by, polymorphic: true, null: true
+      t.datetime :review_date
+      t.jsonb :review_feedback, default: {}
+      t.string :document_reference
 
       t.timestamps
     end
@@ -18,8 +20,9 @@ class CreateDscfCreditCreditLines < ActiveRecord::Migration[8.0]
     add_index :dscf_credit_credit_lines, :code
     add_index :dscf_credit_credit_lines, :status
     add_index :dscf_credit_credit_lines, [ :created_by_type, :created_by_id ]
-    add_index :dscf_credit_credit_lines, [ :approved_by_type, :approved_by_id ]
-    add_index :dscf_credit_credit_lines, :approval_date
+    add_index :dscf_credit_credit_lines, [ :reviewed_by_type, :reviewed_by_id ]
+    add_index :dscf_credit_credit_lines, :review_date
+    add_index :dscf_credit_credit_lines, :document_reference
     add_index :dscf_credit_credit_lines, [ :bank_id, :code ], unique: true
   end
 end

data/db/migrate/20250822091820_create_dscf_credit_system_configs.rb

@@ -5,13 +5,16 @@ class CreateDscfCreditSystemConfigs < ActiveRecord::Migration[8.0]
       t.text :config_value, null: false
       t.string :status, default: 'pending'
       t.references :last_updated_by, polymorphic: true, null: false
-      t.references :approved_by, polymorphic: true, null: false
+      t.references :reviewed_by, polymorphic: true, null: false
+      t.datetime :review_date
+      t.jsonb :review_feedback, default: {}
 
       t.timestamps
     end
 
     add_index :dscf_credit_system_configs, [ :last_updated_by_type, :last_updated_by_id ]
-    add_index :dscf_credit_system_configs, [ :approved_by_type, :approved_by_id ]
+    add_index :dscf_credit_system_configs, [ :reviewed_by_type, :reviewed_by_id ]
     add_index :dscf_credit_system_configs, :status
+    add_index :dscf_credit_system_configs, :review_date
   end
 end

data/db/migrate/20250822092040_create_dscf_credit_scoring_param_types.rb

@@ -0,0 +1,12 @@
+class CreateDscfCreditScoringParamTypes < ActiveRecord::Migration[8.0]
+  def change
+    create_table :dscf_credit_scoring_param_types do |t|
+      t.string :name, null: false
+      t.text :description
+
+      t.timestamps
+    end
+
+    add_index :dscf_credit_scoring_param_types, :name, unique: true
+  end
+end

data/db/migrate/20250822092050_create_dscf_credit_scoring_parameters.rb

@@ -5,26 +5,31 @@ class CreateDscfCreditScoringParameters < ActiveRecord::Migration[8.0]
       t.string :name, null: false
       t.text :description
       t.string :data_type, null: false
-      t.string :type, null: false
       t.decimal :weight, precision: 5, scale: 4, null: false
       t.decimal :min_value, precision: 15, scale: 2
       t.decimal :max_value, precision: 15, scale: 2
       t.boolean :active, default: true
       t.references :previous_version, foreign_key: { to_table: :dscf_credit_scoring_parameters }, null: true
       t.references :created_by, polymorphic: true, null: false
-      t.references :approved_by, polymorphic: true, null: false
-      t.datetime :expires_at
+      t.references :reviewed_by, polymorphic: true, null: false
+      t.datetime :review_date
+      t.jsonb :review_feedback, default: {}
+      t.string :source
+      t.references :scoring_param_type, null: false, foreign_key: { to_table: :dscf_credit_scoring_param_types }
+      t.string :document_reference
+      t.string :status, default: 'pending'
 
       t.timestamps
     end
 
     add_index :dscf_credit_scoring_parameters, :name
     add_index :dscf_credit_scoring_parameters, :data_type
-    add_index :dscf_credit_scoring_parameters, :type
     add_index :dscf_credit_scoring_parameters, :active
     add_index :dscf_credit_scoring_parameters, [ :created_by_type, :created_by_id ]
-    add_index :dscf_credit_scoring_parameters, [ :approved_by_type, :approved_by_id ]
-    add_index :dscf_credit_scoring_parameters, :expires_at
+    add_index :dscf_credit_scoring_parameters, [ :reviewed_by_type, :reviewed_by_id ]
+    add_index :dscf_credit_scoring_parameters, :review_date
+    add_index :dscf_credit_scoring_parameters, :source
+    add_index :dscf_credit_scoring_parameters, :document_reference
     add_index :dscf_credit_scoring_parameters, [ :bank_id, :name, :active ]
   end
 end

data/db/migrate/20250822092246_create_dscf_credit_loan_profiles.rb

@@ -7,8 +7,9 @@ class CreateDscfCreditLoanProfiles < ActiveRecord::Migration[8.0]
       t.string :status, default: 'pending'
       t.decimal :total_amount, precision: 15, scale: 2, default: 0
       t.decimal :available_amount, precision: 15, scale: 2, default: 0
-      t.references :approved_by, polymorphic: true, null: false
-      t.text :rejection_reason
+      t.references :reviewed_by, polymorphic: true, null: false
+      t.datetime :review_date
+      t.jsonb :review_feedback, default: {}
 
       t.timestamps
     end
@@ -17,7 +18,8 @@ class CreateDscfCreditLoanProfiles < ActiveRecord::Migration[8.0]
     add_index :dscf_credit_loan_profiles, :total_amount
     add_index :dscf_credit_loan_profiles, :available_amount
     add_index :dscf_credit_loan_profiles, [ :backer_type, :backer_id ]
-    add_index :dscf_credit_loan_profiles, [ :approved_by_type, :approved_by_id ]
+    add_index :dscf_credit_loan_profiles, [ :reviewed_by_type, :reviewed_by_id ]
+    add_index :dscf_credit_loan_profiles, :review_date
     add_index :dscf_credit_loan_profiles, [ :bank_id, :user_id, :status ]
     add_index :dscf_credit_loan_profiles, [ :user_id, :status ]
     add_index :dscf_credit_loan_profiles, [ :total_amount, :available_amount ]

data/db/migrate/20250822092417_create_dscf_credit_loan_profile_scoring_specs.rb

@@ -6,8 +6,9 @@ class CreateDscfCreditLoanProfileScoringSpecs < ActiveRecord::Migration[8.0]
       t.decimal :score, precision: 5, scale: 2, null: false
       t.boolean :active, default: true
       t.references :created_by, polymorphic: true, null: false
-      t.references :approved_by, polymorphic: true, null: false
-      t.datetime :expires_at
+      t.references :reviewed_by, polymorphic: true, null: false
+      t.datetime :review_date
+      t.jsonb :review_feedback, default: {}
 
       t.timestamps
     end
@@ -15,8 +16,8 @@ class CreateDscfCreditLoanProfileScoringSpecs < ActiveRecord::Migration[8.0]
     add_index :dscf_credit_loan_profile_scoring_specs, :score
     add_index :dscf_credit_loan_profile_scoring_specs, :active
     add_index :dscf_credit_loan_profile_scoring_specs, [ :created_by_type, :created_by_id ]
-    add_index :dscf_credit_loan_profile_scoring_specs, [ :approved_by_type, :approved_by_id ]
-    add_index :dscf_credit_loan_profile_scoring_specs, :expires_at
+    add_index :dscf_credit_loan_profile_scoring_specs, [ :reviewed_by_type, :reviewed_by_id ]
+    add_index :dscf_credit_loan_profile_scoring_specs, :review_date
     add_index :dscf_credit_loan_profile_scoring_specs, :scoring_input_data, using: :gin
     add_index :dscf_credit_loan_profile_scoring_specs, [ :loan_profile_id, :active ]
   end

data/db/migrate/20250822092436_create_dscf_credit_facilitators.rb

@@ -7,7 +7,9 @@ class CreateDscfCreditFacilitators < ActiveRecord::Migration[8.0]
       t.string :type, null: false
       t.decimal :total_limit, precision: 15, scale: 2
       t.string :kyc_status, default: 'pending'
-      t.references :kyc_approved_by, polymorphic: true, null: false
+      t.references :kyc_reviewed_by, polymorphic: true, null: false
+      t.datetime :kyc_review_date
+      t.jsonb :review_feedback, default: {}
 
       t.timestamps
     end
@@ -15,7 +17,8 @@ class CreateDscfCreditFacilitators < ActiveRecord::Migration[8.0]
     add_index :dscf_credit_facilitators, :name
     add_index :dscf_credit_facilitators, :type
     add_index :dscf_credit_facilitators, :kyc_status
-    add_index :dscf_credit_facilitators, [ :kyc_approved_by_type, :kyc_approved_by_id ]
+    add_index :dscf_credit_facilitators, [ :kyc_reviewed_by_type, :kyc_reviewed_by_id ]
+    add_index :dscf_credit_facilitators, :kyc_review_date
     add_index :dscf_credit_facilitators, [ :bank_id, :user_id ], unique: true
     add_index :dscf_credit_facilitators, [ :user_id, :kyc_status ]
   end

data/db/migrate/20250822092528_create_dscf_credit_facilitator_performances.rb

@@ -9,7 +9,6 @@ class CreateDscfCreditFacilitatorPerformances < ActiveRecord::Migration[8.0]
       t.integer :previous_performance_id
       t.jsonb :input_data
       t.references :created_by, polymorphic: true, null: false
-      t.datetime :expires_at
 
       t.timestamps
     end
@@ -19,8 +18,6 @@ class CreateDscfCreditFacilitatorPerformances < ActiveRecord::Migration[8.0]
     add_index :dscf_credit_facilitator_performances, :total_outstanding_amount
     add_index :dscf_credit_facilitator_performances, :approval_required
     add_index :dscf_credit_facilitator_performances, [ :created_by_type, :created_by_id ]
-    add_index :dscf_credit_facilitator_performances, :expires_at
     add_index :dscf_credit_facilitator_performances, :input_data, using: :gin
-    add_index :dscf_credit_facilitator_performances, [ :facilitator_id, :expires_at ]
   end
 end

data/db/seeds.rb

@@ -306,14 +306,16 @@ puts "Seeding system configs..."
 Dscf::Credit::SystemConfig.find_or_create_by(config_definition: config_def1) do |config|
   config.config_value = '500000.00'
   config.status = 'approved'
-  config.approved_by = admin_user
+  config.reviewed_by = admin_user
+  config.review_date = Time.current
   config.last_updated_by = admin_user
 end
 
 Dscf::Credit::SystemConfig.find_or_create_by(config_definition: config_def2) do |config|
   config.config_value = 'daily'
   config.status = 'approved'
-  config.approved_by = admin_user
+  config.reviewed_by = admin_user
+  config.review_date = Time.current
   config.last_updated_by = admin_user
 end
 
@@ -341,6 +343,28 @@ corporate_category = Dscf::Credit::Category.find_or_create_by(type: 'credit_line
   category.description = 'Corporate credit category for large businesses'
 end
 
+# 4.6. Scoring Param Types (independent)
+puts "Seeding scoring param types..."
+consumer_type = Dscf::Credit::ScoringParamType.find_or_create_by(name: 'Consumer') do |type|
+  type.description = 'Parameters for consumer credit scoring'
+end
+
+facilitator_type = Dscf::Credit::ScoringParamType.find_or_create_by(name: 'Facilitator') do |type|
+  type.description = 'Parameters for facilitator credit scoring'
+end
+
+wholesaler_type = Dscf::Credit::ScoringParamType.find_or_create_by(name: 'Wholesaler') do |type|
+  type.description = 'Parameters for wholesaler credit scoring'
+end
+
+retailer_type = Dscf::Credit::ScoringParamType.find_or_create_by(name: 'Retailer') do |type|
+  type.description = 'Parameters for retailer credit scoring'
+end
+
+manufacturer_type = Dscf::Credit::ScoringParamType.find_or_create_by(name: 'Manufacturer') do |type|
+  type.description = 'Parameters for manufacturer credit scoring'
+end
+
 # 5. Credit Lines (depends on banks, users, and categories)
 puts "Seeding credit lines..."
 credit_line1 = Dscf::Credit::CreditLine.find_or_create_by(bank: bank1, name: 'SME Credit Line') do |line|
@@ -349,8 +373,8 @@ credit_line1 = Dscf::Credit::CreditLine.find_or_create_by(bank: bank1, name: 'SM
   line.description = 'Credit line for Small and Medium Enterprises'
   line.status = 'approved'
   line.created_by = admin_user
-  line.approved_by = bank_admin
-  line.approval_date = 1.week.ago
+  line.reviewed_by = bank_admin
+  line.review_date = 1.week.ago
 end
 
 credit_line2 = Dscf::Credit::CreditLine.find_or_create_by(bank: bank1, name: 'Personal Credit Line') do |line|
@@ -359,8 +383,8 @@ credit_line2 = Dscf::Credit::CreditLine.find_or_create_by(bank: bank1, name: 'Pe
   line.description = 'Personal credit line for individuals'
   line.status = 'approved'
   line.created_by = admin_user
-  line.approved_by = bank_admin
-  line.approval_date = 5.days.ago
+  line.reviewed_by = bank_admin
+  line.review_date = 5.days.ago
 end
 
 Dscf::Credit::CreditLine.find_or_create_by(bank: bank2, name: 'Agricultural Credit Line') do |line|
@@ -369,7 +393,7 @@ Dscf::Credit::CreditLine.find_or_create_by(bank: bank2, name: 'Agricultural Cred
   line.description = 'Credit line for agricultural sector'
   line.status = 'pending'
   line.created_by = bank_admin
-  line.approved_by = admin_user
+  line.reviewed_by = admin_user
 end
 
 # 6. Credit Line Specs (depends on credit lines)
@@ -420,14 +444,15 @@ scoring_param1 = Dscf::Credit::ScoringParameter.find_or_create_by(
 ) do |param|
   param.description = 'Monthly income of the applicant'
   param.data_type = 'decimal'
-  param.type = 'financial'
   param.weight = 0.3
   param.min_value = 0
   param.max_value = 1000000
   param.active = true
-  param.approved_by = admin_user
+  param.reviewed_by = admin_user
+  param.review_date = Time.current
   param.created_by = admin_user
-  param.expires_at = 1.year.from_now
+  param.source = 'internal'
+  param.document_reference = 'DOC-SP-001'
 end
 
 scoring_param2 = Dscf::Credit::ScoringParameter.find_or_create_by(
@@ -436,14 +461,15 @@ scoring_param2 = Dscf::Credit::ScoringParameter.find_or_create_by(
 ) do |param|
   param.description = 'Credit history score from credit bureau'
   param.data_type = 'integer'
-  param.type = 'credit_history'
   param.weight = 0.4
   param.min_value = 300
   param.max_value = 850
   param.active = true
-  param.approved_by = admin_user
+  param.reviewed_by = admin_user
+  param.review_date = Time.current
   param.created_by = admin_user
-  param.expires_at = 1.year.from_now
+  param.source = 'external'
+  param.document_reference = 'DOC-SP-002'
 end
 
 scoring_param3 = Dscf::Credit::ScoringParameter.find_or_create_by(
@@ -452,12 +478,13 @@ scoring_param3 = Dscf::Credit::ScoringParameter.find_or_create_by(
 ) do |param|
   param.description = 'Type of employment (permanent, contract, self-employed)'
   param.data_type = 'string'
-  param.type = 'employment'
   param.weight = 0.2
   param.active = true
-  param.approved_by = bank_admin
+  param.reviewed_by = bank_admin
+  param.review_date = Time.current
   param.created_by = admin_user
-  param.expires_at = 1.year.from_now
+  param.source = 'internal'
+  param.document_reference = 'DOC-SP-003'
 end
 
 # 8. Parameter Normalizers (depends on scoring parameters)
@@ -576,7 +603,8 @@ loan_profile1 = Dscf::Credit::LoanProfile.find_or_create_by(
   profile.status = 'approved'
   profile.total_amount = 100000.00
   profile.available_amount = 75000.00
-  profile.approved_by = bank_admin
+  profile.reviewed_by = bank_admin
+  profile.review_date = Time.current
   # Note: backer will be set when facilitators are created via API
 end
 
@@ -593,9 +621,9 @@ Dscf::Credit::LoanProfileScoringSpec.create!(
   },
   score: 78.5,
   active: true,
-  approved_by: admin_user,
-  created_by: admin_user,
-  expires_at: 6.months.from_now
+  reviewed_by: admin_user,
+  review_date: Time.current,
+  created_by: admin_user
 )
 
 # 13. Payment Requests (depends on users)

data/lib/dscf/credit/version.rb

@@ -1,5 +1,5 @@
 module Dscf
   module Credit
-    VERSION = "0.1.1"
+    VERSION = "0.1.2"
   end
 end

data/spec/factories/dscf/credit/categories.rb

@@ -3,6 +3,7 @@ FactoryBot.define do
     type { %w[scoring loan_profile payment risk_assessment].sample }
     sequence(:name) { |n| "#{type.humanize} Category #{n}" }
     description { Faker::Lorem.paragraph }
+    document_reference { Faker::Alphanumeric.alphanumeric(number: 10).upcase }
 
     trait :scoring do
       type { "scoring" }

data/spec/factories/dscf/credit/credit_lines.rb

@@ -3,26 +3,28 @@ FactoryBot.define do
     association :bank, factory: :bank
     association :category, factory: :category
     association :created_by, factory: :user if defined?(Dscf::Core::User)
-    association :approved_by, factory: :user if defined?(Dscf::Core::User)
+    association :reviewed_by, factory: :user if defined?(Dscf::Core::User)
     name { "#{Faker::Finance.credit_card(:visa)} Credit Line" }
     sequence(:code) { |n| "CL#{n.to_s.rjust(4, '0')}" }
     description { Faker::Lorem.paragraph }
     status { %w[pending approved active suspended].sample }
-    approval_date { Faker::Date.between(from: 6.months.ago, to: Date.current) if status.in?(%w[approved active]) }
+    review_date { Faker::Date.between(from: 6.months.ago, to: Date.current) if status.in?(%w[approved active]) }
+    document_reference { Faker::Alphanumeric.alphanumeric(number: 10).upcase }
+    review_feedback { {} }
 
     trait :pending do
       status { "pending" }
-      approval_date { nil }
+      review_date { nil }
     end
 
     trait :approved do
       status { "approved" }
-      approval_date { Faker::Date.between(from: 6.months.ago, to: Date.current) }
+      review_date { Faker::Date.between(from: 6.months.ago, to: Date.current) }
     end
 
     trait :active do
       status { "active" }
-      approval_date { Faker::Date.between(from: 6.months.ago, to: Date.current) }
+      review_date { Faker::Date.between(from: 6.months.ago, to: Date.current) }
     end
 
     trait :suspended do

data/spec/factories/dscf/credit/facilitator_performances.rb

@@ -7,7 +7,6 @@ FactoryBot.define do
     total_outstanding_amount { Faker::Number.decimal(l_digits: 6, r_digits: 2) }
     approval_required { [ true, false ].sample }
     input_data { Faker::Json.shallow_json(width: 3, options: { key: 'Name.name', value: 'Number.number' }) }
-    expires_at { Faker::Date.between(from: 1.month.from_now, to: 1.year.from_now) }
 
     trait :high_performance do
       score { Faker::Number.between(from: 80.0, to: 100.0) }
@@ -22,9 +21,5 @@ FactoryBot.define do
     trait :requiring_approval do
       approval_required { true }
     end
-
-    trait :expired do
-      expires_at { Faker::Date.between(from: 1.year.ago, to: 1.month.ago) }
-    end
   end
 end

data/spec/factories/dscf/credit/facilitators.rb

@@ -2,22 +2,27 @@ FactoryBot.define do
   factory :facilitator, class: "Dscf::Credit::Facilitator" do
     association :bank, factory: :bank
     association :user, factory: :user if defined?(Dscf::Core::User)
-    association :kyc_approved_by, factory: :user if defined?(Dscf::Core::User)
+    association :kyc_reviewed_by, factory: :user if defined?(Dscf::Core::User)
     name { Faker::Name.name }
     type { %w[individual corporate agent].sample }
     total_limit { Faker::Number.decimal(l_digits: 6, r_digits: 2) }
     kyc_status { %w[pending approved rejected].sample }
+    kyc_review_date { Faker::Date.between(from: 6.months.ago, to: Date.current) if kyc_status == "approved" }
+    review_feedback { {} }
 
     trait :pending_kyc do
       kyc_status { "pending" }
+      kyc_review_date { nil }
     end
 
     trait :approved do
       kyc_status { "approved" }
+      kyc_review_date { Faker::Date.between(from: 6.months.ago, to: Date.current) }
     end
 
     trait :rejected do
       kyc_status { "rejected" }
+      kyc_review_date { nil }
     end
 
     trait :individual do

data/spec/factories/dscf/credit/loan_profile_scoring_specs.rb

@@ -2,11 +2,12 @@ FactoryBot.define do
   factory :loan_profile_scoring_spec, class: "Dscf::Credit::LoanProfileScoringSpec" do
     association :loan_profile, factory: :loan_profile
     association :created_by, factory: :user if defined?(Dscf::Core::User)
-    association :approved_by, factory: :user if defined?(Dscf::Core::User)
+    association :reviewed_by, factory: :user if defined?(Dscf::Core::User)
     scoring_input_data { Faker::Json.shallow_json(width: 5, options: { key: 'Name.name', value: 'Number.number' }) }
     score { Faker::Number.decimal(l_digits: 2, r_digits: 2) }
     active { true }
-    expires_at { Faker::Date.between(from: 3.months.from_now, to: 1.year.from_now) }
+    review_date { Faker::Date.between(from: 6.months.ago, to: Date.current) }
+    review_feedback { {} }
 
     trait :active do
       active { true }
@@ -23,9 +24,5 @@ FactoryBot.define do
     trait :low_score do
       score { Faker::Number.between(from: 0.0, to: 30.0) }
     end
-
-    trait :expired do
-      expires_at { Faker::Date.between(from: 1.year.ago, to: 1.month.ago) }
-    end
   end
 end

data/spec/factories/dscf/credit/loan_profiles.rb

@@ -1,27 +1,31 @@
 FactoryBot.define do
   factory :loan_profile, class: "Dscf::Credit::LoanProfile" do
     association :bank, factory: :bank
-    association :approved_by, factory: :user if defined?(Dscf::Core::User)
+    association :reviewed_by, factory: :user if defined?(Dscf::Core::User)
     association :user, factory: :user if defined?(Dscf::Core::User)
     association :backer, factory: :user if defined?(Dscf::Core::User)
-    status { %w[pending approved rejected].sample }
+    status { %w[pending approved rejected kyc_approved kyc_rejected].sample }
     total_amount { Faker::Number.decimal(l_digits: 6, r_digits: 2).to_f }
     available_amount { total_amount - Faker::Number.decimal(l_digits: 4, r_digits: 2).to_f }
-    rejection_reason { Faker::Lorem.sentence if status == "rejected" }
+    review_date { Faker::Date.between(from: 6.months.ago, to: Date.current) if status == "approved" }
+    review_feedback { status == "rejected" ? { reason: Faker::Lorem.sentence } : {} }
 
     trait :pending do
       status { "pending" }
-      rejection_reason { nil }
+      review_feedback { {} }
+      review_date { nil }
     end
 
     trait :approved do
       status { "approved" }
-      rejection_reason { nil }
+      review_feedback { {} }
+      review_date { Faker::Date.between(from: 6.months.ago, to: Date.current) }
     end
 
     trait :rejected do
       status { "rejected" }
-      rejection_reason { Faker::Lorem.sentence }
+      review_feedback { { reason: Faker::Lorem.sentence } }
+      review_date { nil }
     end
 
     trait :fully_available do

data/spec/factories/dscf/credit/scoring_param_types.rb

@@ -0,0 +1,31 @@
+FactoryBot.define do
+  factory :scoring_param_type, class: "Dscf::Credit::ScoringParamType" do
+    name { Faker::Lorem.word.capitalize }
+    description { Faker::Lorem.paragraph }
+
+    trait :consumer do
+      name { "Consumer" }
+      description { "Parameters for consumer credit scoring" }
+    end
+
+    trait :facilitator do
+      name { "Facilitator" }
+      description { "Parameters for facilitator credit scoring" }
+    end
+
+    trait :wholesaler do
+      name { "Wholesaler" }
+      description { "Parameters for wholesaler credit scoring" }
+    end
+
+    trait :retailer do
+      name { "Retailer" }
+      description { "Parameters for retailer credit scoring" }
+    end
+
+    trait :manufacturer do
+      name { "Manufacturer" }
+      description { "Parameters for manufacturer credit scoring" }
+    end
+  end
+end

data/spec/factories/dscf/credit/scoring_parameters.rb

@@ -2,16 +2,20 @@ FactoryBot.define do
   factory :scoring_parameter, class: "Dscf::Credit::ScoringParameter" do
     association :bank, factory: :bank
     association :created_by, factory: :user if defined?(Dscf::Core::User)
-    association :approved_by, factory: :user if defined?(Dscf::Core::User)
-    name { Faker::Lorem.words(number: 2).join('_').downcase }
+    association :reviewed_by, factory: :user if defined?(Dscf::Core::User)
+    association :scoring_param_type, factory: :scoring_param_type
+    sequence(:name) { |n| "#{Faker::Lorem.words(number: 2).join('_').downcase}_#{n}" }
     description { Faker::Lorem.paragraph }
     data_type { %w[integer decimal boolean string].sample }
-    type { %w[income credit_history employment_status collateral].sample }
     weight { Faker::Number.decimal(l_digits: 0, r_digits: 4) }
     min_value { Faker::Number.decimal(l_digits: 2, r_digits: 2) }
     max_value { min_value + Faker::Number.decimal(l_digits: 3, r_digits: 2) }
     active { true }
-    expires_at { Faker::Date.between(from: 6.months.from_now, to: 2.years.from_now) }
+    review_date { Faker::Date.between(from: 6.months.ago, to: Date.current) }
+    source { Faker::Lorem.word }
+    document_reference { Faker::Alphanumeric.alphanumeric(number: 10).upcase }
+    status { "pending" }
+    review_feedback { {} }
 
     trait :active do
       active { true }
@@ -44,5 +48,23 @@ FactoryBot.define do
       min_value { nil }
       max_value { nil }
     end
+
+    trait :pending do
+      status { "pending" }
+    end
+
+    trait :approved do
+      status { "approved" }
+      review_date { Faker::Date.between(from: 6.months.ago, to: Date.current) }
+    end
+
+    trait :rejected do
+      status { "rejected" }
+      review_date { Faker::Date.between(from: 6.months.ago, to: Date.current) }
+    end
+
+    trait :modify do
+      status { "modify" }
+    end
   end
 end

data/spec/factories/dscf/credit/system_configs.rb

@@ -2,9 +2,11 @@ FactoryBot.define do
   factory :system_config, class: "Dscf::Credit::SystemConfig" do
     association :config_definition, factory: :system_config_definition
     association :last_updated_by, factory: :user if defined?(Dscf::Core::User)
-    association :approved_by, factory: :user if defined?(Dscf::Core::User)
+    association :reviewed_by, factory: :user if defined?(Dscf::Core::User)
     config_value { Faker::Lorem.word }
-    status { %w[pending approved rejected].sample }
+    status { %w[pending approved rejected modify].sample }
+    review_date { Faker::Date.between(from: 6.months.ago, to: Date.current) if status == 'approved' }
+    review_feedback { {} }
 
     trait :string_value do
       config_value { Faker::Lorem.sentence }
@@ -25,5 +27,9 @@ FactoryBot.define do
     trait :json_value do
       value { { key: Faker::Lorem.word, value: Faker::Number.number(digits: 3) }.to_json }
     end
+
+    trait :modify do
+      status { "modify" }
+    end
   end
 end