dscf-credit 0.1.1 → 0.1.2

data/app/models/dscf/credit/facilitator.rb

@@ -4,7 +4,7 @@ module Dscf::Credit
     self.inheritance_column = nil  # Disable STI since 'type' is a business attribute
 
     belongs_to :bank, class_name: "Dscf::Credit::Bank", foreign_key: "bank_id"
-    belongs_to :kyc_approved_by, polymorphic: true
+    belongs_to :kyc_reviewed_by, polymorphic: true
     if defined?(Dscf::Core::User)
       belongs_to :user, class_name: "Dscf::Core::User", foreign_key: "user_id"
     end
@@ -12,20 +12,21 @@ module Dscf::Credit
 
     validates :name, :type, presence: true
     validates :type, inclusion: { in: %w[individual corporate agent] }
-    validates :kyc_status, inclusion: { in: %w[pending approved rejected] }
     validates :user_id, uniqueness: { scope: :bank_id }
     validates :total_limit, numericality: { greater_than_or_equal_to: 0 }, allow_nil: true
 
+    enum :kyc_status, { pending: "pending", approved: "approved", rejected: "rejected" }
+
     scope :approved, -> { where(kyc_status: "approved") }
     scope :pending_kyc, -> { where(kyc_status: "pending") }
     scope :rejected, -> { where(kyc_status: "rejected") }
 
     def self.ransackable_attributes(auth_object = nil)
-      %w[id name type total_limit kyc_status created_at updated_at]
+      %w[id name type total_limit kyc_status kyc_review_date review_feedback created_at updated_at]
     end
 
     def self.ransackable_associations(auth_object = nil)
-      %w[bank user kyc_approved_by facilitator_performances]
+      %w[bank user kyc_reviewed_by facilitator_performances]
     end
   end
 end

data/app/models/dscf/credit/facilitator_performance.rb

@@ -11,7 +11,6 @@ module Dscf::Credit
     validates :score, numericality: { greater_than_or_equal_to: 0 }, allow_nil: true
 
     scope :requiring_approval, -> { where(approval_required: true) }
-    scope :expired, -> { where("expires_at < ?", Time.current) }
-    scope :current, -> { where("expires_at IS NULL OR expires_at > ?", Time.current) }
+    scope :current, -> { where("created_at > ?", 30.days.ago) }  # Assuming current means recent
   end
 end

data/app/models/dscf/credit/loan_profile.rb

@@ -3,7 +3,7 @@ module Dscf::Credit
     self.table_name = "dscf_credit_loan_profiles"
 
     belongs_to :bank, class_name: "Dscf::Credit::Bank", foreign_key: "bank_id"
-    belongs_to :approved_by, polymorphic: true
+    belongs_to :reviewed_by, polymorphic: true
     belongs_to :backer, polymorphic: true, optional: true
     if defined?(Dscf::Core::User)
       belongs_to :user, class_name: "Dscf::Core::User", foreign_key: "user_id"
@@ -12,6 +12,7 @@ module Dscf::Credit
     has_many :loans, class_name: "Dscf::Credit::Loan", foreign_key: "loan_profile_id", dependent: :destroy
 
     validates :status, inclusion: { in: %w[pending approved rejected kyc_approved kyc_rejected] }
+    enum :status, { pending: "pending", approved: "approved", rejected: "rejected", kyc_approved: "kyc_approved", kyc_rejected: "kyc_rejected" }
     validates :total_amount, :available_amount, numericality: { greater_than_or_equal_to: 0 }
     validate :available_amount_not_greater_than_total_amount
 
@@ -25,11 +26,11 @@ module Dscf::Credit
     scope :by_available_amount_range, ->(min, max) { where(available_amount: min..max) }
 
     def self.ransackable_attributes(auth_object = nil)
-      %w[id status total_amount available_amount rejection_reason created_at updated_at reviewed_by_type reviewed_by_id]
+      %w[id status total_amount available_amount review_feedback review_date created_at updated_at reviewed_by_type reviewed_by_id]
     end
 
     def self.ransackable_associations(auth_object = nil)
-      %w[bank user backer approved_by reviewed_by loan_profile_scoring_specs loans]
+      %w[bank user backer reviewed_by loan_profile_scoring_specs loans]
     end
 
     private

data/app/models/dscf/credit/loan_profile_scoring_spec.rb

@@ -4,20 +4,19 @@ module Dscf::Credit
 
     belongs_to :loan_profile, class_name: "Dscf::Credit::LoanProfile", foreign_key: "loan_profile_id"
     belongs_to :created_by, polymorphic: true
-    belongs_to :approved_by, polymorphic: true
+    belongs_to :reviewed_by, polymorphic: true
 
     validates :scoring_input_data, :score, presence: true
     validates :score, numericality: { greater_than_or_equal_to: 0 }
 
     scope :active, -> { where(active: true) }
-    scope :expired, -> { where("expires_at < ?", Time.current) }
 
     def self.ransackable_attributes(auth_object = nil)
-      %w[id score active expires_at created_at updated_at]
+      %w[id score active review_date review_feedback created_at updated_at]
     end
 
     def self.ransackable_associations(auth_object = nil)
-      %w[loan_profile created_by approved_by]
+      %w[loan_profile created_by reviewed_by]
     end
   end
 end

data/app/models/dscf/credit/scoring_param_type.rb

@@ -0,0 +1,17 @@
+module Dscf::Credit
+  class ScoringParamType < ApplicationRecord
+    self.table_name = "dscf_credit_scoring_param_types"
+
+    has_many :scoring_parameters, class_name: "Dscf::Credit::ScoringParameter", foreign_key: "scoring_param_type_id", dependent: :restrict_with_error
+
+    validates :name, presence: true, uniqueness: true
+
+    def self.ransackable_attributes(auth_object = nil)
+      %w[id name description created_at updated_at]
+    end
+
+    def self.ransackable_associations(auth_object = nil)
+      %w[scoring_parameters]
+    end
+  end
+end

data/app/models/dscf/credit/scoring_parameter.rb

@@ -1,30 +1,31 @@
 module Dscf::Credit
   class ScoringParameter < ApplicationRecord
     self.table_name = "dscf_credit_scoring_parameters"
-    self.inheritance_column = nil  # Disable STI since 'type' is a business attribute
 
     belongs_to :bank, class_name: "Dscf::Credit::Bank", foreign_key: "bank_id"
     belongs_to :created_by, polymorphic: true
-    belongs_to :approved_by, polymorphic: true
+    belongs_to :reviewed_by, polymorphic: true
+    belongs_to :scoring_param_type, class_name: "Dscf::Credit::ScoringParamType", foreign_key: "scoring_param_type_id"
     belongs_to :previous_version, class_name: "Dscf::Credit::ScoringParameter", optional: true
     has_many :parameter_normalizers, class_name: "Dscf::Credit::ParameterNormalizer", foreign_key: "scoring_parameter_id", dependent: :destroy
     has_many :scoring_tables, class_name: "Dscf::Credit::ScoringTable", foreign_key: "scoring_parameter_id", dependent: :destroy
     has_many :credit_lines, through: :scoring_tables
 
-    validates :name, :data_type, :type, :weight, presence: true
+    validates :name, :data_type, :weight, presence: true
     validates :weight, numericality: { greater_than: 0, less_than_or_equal_to: 1 }
     validates :data_type, inclusion: { in: %w[integer decimal boolean string] }
-    validates :type, inclusion: { in: %w[income credit_history employment_status collateral] }
     validates :name, uniqueness: { scope: [ :bank_id, :active ] }
+    validates :status, inclusion: { in: %w[pending approved rejected modify] }
+    enum :status, { pending: "pending", approved: "approved", rejected: "rejected", modify: "modify" }
 
     scope :active, -> { where(active: true) }
 
     def self.ransackable_attributes(auth_object = nil)
-      %w[id name description data_type type weight min_value max_value active expires_at created_at updated_at]
+      %w[id name description data_type weight min_value max_value active status review_date review_feedback source document_reference created_at updated_at]
     end
 
     def self.ransackable_associations(auth_object = nil)
-      %w[bank created_by approved_by previous_version parameter_normalizers scoring_tables credit_lines]
+      %w[bank created_by reviewed_by scoring_param_type previous_version parameter_normalizers scoring_tables credit_lines]
     end
   end
 end

data/app/models/dscf/credit/system_config.rb

@@ -4,10 +4,11 @@ module Dscf::Credit
 
     belongs_to :config_definition, class_name: "Dscf::Credit::SystemConfigDefinition", foreign_key: "config_definition_id"
     belongs_to :last_updated_by, polymorphic: true
-    belongs_to :approved_by, polymorphic: true
+    belongs_to :reviewed_by, polymorphic: true
 
     validates :config_value, presence: true
-    validates :status, inclusion: { in: %w[pending approved rejected] }
+    validates :status, inclusion: { in: %w[pending approved rejected modify] }
+    enum :status, { pending: "pending", approved: "approved", rejected: "rejected", modify: "modify" }
     validates :config_definition_id, uniqueness: true
 
     scope :pending, -> { where(status: "pending") }
@@ -15,11 +16,11 @@ module Dscf::Credit
     scope :rejected, -> { where(status: "rejected") }
 
     def self.ransackable_attributes(auth_object = nil)
-      %w[id config_value status created_at updated_at]
+      %w[id config_value status review_date review_feedback created_at updated_at]
     end
 
     def self.ransackable_associations(auth_object = nil)
-      %w[config_definition last_updated_by approved_by]
+      %w[config_definition last_updated_by reviewed_by]
     end
   end
 end

data/app/serializers/dscf/credit/category_serializer.rb

@@ -1,6 +1,6 @@
 module Dscf::Credit
   class CategorySerializer < ActiveModel::Serializer
-    attributes :id, :type, :name, :description, :created_at, :updated_at
+    attributes :id, :type, :name, :description, :document_reference, :created_at, :updated_at
 
     has_many :credit_lines, serializer: Dscf::Credit::CreditLineSerializer
   end

data/app/serializers/dscf/credit/credit_line_serializer.rb

@@ -1,12 +1,12 @@
 module Dscf::Credit
   class CreditLineSerializer < ActiveModel::Serializer
-    attributes :id, :name, :code, :description, :status, :approval_date,
+    attributes :id, :name, :code, :description, :status, :review_date, :review_feedback, :document_reference,
                :created_at, :updated_at
 
     belongs_to :bank, serializer: Dscf::Credit::BankSerializer
     belongs_to :category, serializer: Dscf::Credit::CategorySerializer
     belongs_to :created_by, serializer: Dscf::Core::UserSerializer
-    belongs_to :approved_by, serializer: Dscf::Core::UserSerializer
+    belongs_to :reviewed_by, serializer: Dscf::Core::UserSerializer
     has_many :credit_line_specs, serializer: Dscf::Credit::CreditLineSpecSerializer
   end
 end

data/app/serializers/dscf/credit/facilitator_performance_serializer.rb

@@ -2,7 +2,7 @@ module Dscf::Credit
   class FacilitatorPerformanceSerializer < ActiveModel::Serializer
     attributes :id, :score, :total_outstanding_loans, :total_outstanding_amount,
                :approval_required, :previous_performance_id, :input_data,
-               :expires_at, :created_at, :updated_at
+               :created_at, :updated_at
 
     belongs_to :facilitator, serializer: Dscf::Credit::FacilitatorSerializer
     belongs_to :created_by, polymorphic: true

data/app/serializers/dscf/credit/facilitator_serializer.rb

@@ -1,11 +1,11 @@
 module Dscf::Credit
   class FacilitatorSerializer < ActiveModel::Serializer
-    attributes :id, :name, :type, :total_limit, :kyc_status,
+    attributes :id, :name, :type, :total_limit, :kyc_status, :kyc_review_date, :review_feedback,
                :created_at, :updated_at
 
     belongs_to :user, serializer: Dscf::Core::UserSerializer
     belongs_to :bank, serializer: Dscf::Credit::BankSerializer
-    belongs_to :kyc_approved_by, polymorphic: true
+    belongs_to :kyc_reviewed_by, polymorphic: true
     has_many :facilitator_performances, serializer: Dscf::Credit::FacilitatorPerformanceSerializer
   end
 end

data/app/serializers/dscf/credit/scoring_param_type_serializer.rb

@@ -0,0 +1,7 @@
+module Dscf::Credit
+  class ScoringParamTypeSerializer < ActiveModel::Serializer
+    attributes :id, :name, :description, :created_at, :updated_at
+
+    has_many :scoring_parameters, serializer: Dscf::Credit::ScoringParameterSerializer
+  end
+end

data/app/serializers/dscf/credit/scoring_parameter_serializer.rb

@@ -1,11 +1,12 @@
 module Dscf::Credit
   class ScoringParameterSerializer < ActiveModel::Serializer
-    attributes :id, :name, :description, :data_type, :type, :weight, :min_value,
-               :max_value, :active, :expires_at, :created_at, :updated_at
+    attributes :id, :name, :description, :data_type, :weight, :min_value,
+               :max_value, :active, :status, :review_date, :review_feedback, :source, :document_reference, :created_at, :updated_at
 
     belongs_to :bank, serializer: Dscf::Credit::BankSerializer
     belongs_to :created_by, polymorphic: true
-    belongs_to :approved_by, polymorphic: true
+    belongs_to :reviewed_by, polymorphic: true
+    belongs_to :scoring_param_type, serializer: Dscf::Credit::ScoringParamTypeSerializer
     belongs_to :previous_version, serializer: Dscf::Credit::ScoringParameterSerializer
     has_many :parameter_normalizers, serializer: Dscf::Credit::ParameterNormalizerSerializer
   end

data/app/serializers/dscf/credit/system_config_serializer.rb

@@ -1,6 +1,6 @@
 module Dscf::Credit
   class SystemConfigSerializer < ActiveModel::Serializer
-    attributes :id, :config_value, :status, :created_at, :updated_at
+    attributes :id, :config_value, :status, :review_date, :review_feedback, :created_at, :updated_at
 
     attribute :config_definition do
       {
@@ -13,6 +13,6 @@ module Dscf::Credit
     end
 
     belongs_to :last_updated_by, serializer: Dscf::Core::UserSerializer
-    belongs_to :approved_by, serializer: Dscf::Core::UserSerializer
+    belongs_to :reviewed_by, serializer: Dscf::Core::UserSerializer
   end
 end

data/app/services/dscf/credit/facilitator_approval_service.rb

@@ -29,15 +29,16 @@ module Dscf::Credit
       end
     end
 
-    def reject(rejection_reason = nil)
+    def reject(review_feedback = nil)
       ActiveRecord::Base.transaction do
         facilitator.update!(
           kyc_status: "rejected",
-          kyc_approved_by: approver
+          kyc_approved_by: approver,
+          review_feedback: review_feedback
         )
 
         begin
-          FacilitatorMailer.rejection_notification(facilitator, rejection_reason).deliver_now
+          FacilitatorMailer.rejection_notification(facilitator, review_feedback).deliver_now
         rescue => e
           Rails.logger.error "Failed to send rejection email: #{e.message}"
         end

data/app/services/dscf/credit/facilitator_creation_service.rb

@@ -0,0 +1,157 @@
+module Dscf::Credit
+  class FacilitatorCreationService
+    attr_reader :current_user, :facilitator_class
+
+    def initialize(current_user, facilitator_class = Dscf::Credit::Facilitator)
+      @current_user = current_user
+      @facilitator_class = facilitator_class
+    end
+
+    # Creates a single facilitator
+    # @param facilitator_params [Hash] The facilitator parameters
+    # @return [Dscf::Credit::Facilitator] The created facilitator
+    # @raise [StandardError] If creation fails
+    def create_single(facilitator_params)
+      ActiveRecord::Base.transaction do
+        facilitator_data = build_facilitator_data(facilitator_params)
+        facilitator = facilitator_class.new(facilitator_data)
+        facilitator.kyc_reviewed_by = current_user
+        facilitator.kyc_review_date = Time.current
+
+        if facilitator.save
+          create_initial_performance(facilitator)
+          facilitator
+        else
+          raise StandardError, facilitator.errors.full_messages.join(", ")
+        end
+      end
+    end
+
+    # Creates multiple facilitators in batch
+    # @param facilitators_params [Array<Hash>] Array of facilitator parameters
+    # @return [Hash] Results containing successful and failed creations
+    def create_batch(facilitators_params)
+      validate_batch_params(facilitators_params)
+
+      results = initialize_batch_results(facilitators_params.length)
+
+      facilitators_params.each_with_index do |facilitator_attrs, index|
+        process_single_facilitator_in_batch(facilitator_attrs, index, results)
+      end
+
+      results
+    end
+
+    private
+
+    def build_facilitator_data(facilitator_params)
+      user = find_user(facilitator_params[:user_id])
+      business = find_user_business(user)
+
+      facilitator_params.to_h.merge(
+        name: business.name,
+        type: business.business_type.name.downcase
+      )
+    end
+
+    def find_user(user_id)
+      user = Dscf::Core::User.find(user_id)
+      raise StandardError, "User not found with ID: #{user_id}" unless user
+      user
+    rescue ActiveRecord::RecordNotFound
+      raise StandardError, "User not found with ID: #{user_id}"
+    end
+
+    def find_user_business(user)
+      business = user.businesses.first
+      raise StandardError, "User must have a business associated to become a facilitator" unless business
+      business
+    end
+
+    def create_initial_performance(facilitator)
+      facilitator.facilitator_performances.create!(
+        total_outstanding_loans: 0,
+        total_outstanding_amount: 0.0,
+        approval_required: false,
+        created_by: current_user
+      )
+    end
+
+    def validate_batch_params(facilitators_params)
+      unless facilitators_params.is_a?(Array)
+        raise StandardError, "Expected an array of facilitator objects"
+      end
+
+      if facilitators_params.empty?
+        raise StandardError, "At least one facilitator is required"
+      end
+
+      if facilitators_params.length > 100
+        raise StandardError, "Maximum 100 facilitators allowed per batch"
+      end
+    end
+
+    def initialize_batch_results(total_count)
+      {
+        successful: [],
+        failed: [],
+        total_count: total_count,
+        success_count: 0,
+        failure_count: 0
+      }
+    end
+
+    def process_single_facilitator_in_batch(facilitator_attrs, index, results)
+      begin
+        permitted_attrs = permit_facilitator_attrs(facilitator_attrs)
+        facilitator = create_single(permitted_attrs)
+
+        add_successful_result(results, index, facilitator)
+      rescue StandardError => e
+        add_failed_result(results, index, facilitator_attrs, e)
+      end
+    end
+
+    def permit_facilitator_attrs(facilitator_attrs)
+      if facilitator_attrs.is_a?(ActionController::Parameters)
+        facilitator_attrs.permit(:user_id, :bank_id, :kyc_status)
+      else
+        ActionController::Parameters.new(facilitator_attrs)
+                                    .permit(:user_id, :bank_id, :kyc_status)
+      end
+    end
+
+    def add_successful_result(results, index, facilitator)
+      results[:successful] << {
+        index: index,
+        id: facilitator.id,
+        name: facilitator.name,
+        message: "Successfully created"
+      }
+      results[:success_count] += 1
+    end
+
+    def add_failed_result(results, index, facilitator_attrs, error)
+      business_name = extract_business_name_for_error(facilitator_attrs)
+
+      results[:failed] << {
+        index: index,
+        name: business_name,
+        errors: [ error.message ]
+      }
+      results[:failure_count] += 1
+    end
+
+    def extract_business_name_for_error(facilitator_attrs)
+      user_id = facilitator_attrs.try(:[], :user_id) || facilitator_attrs[:user_id]
+      return "Unknown Business" unless user_id
+
+      begin
+        user = Dscf::Core::User.find(user_id)
+        user.businesses.first&.name || "No Business Associated"
+      rescue
+        "Invalid User ID"
+      end
+    end
+  end
+end

data/config/locales/en.yml

@@ -41,18 +41,40 @@ en:
       update: "Failed to update bank staff"
       destroy: "Failed to remove bank staff"
 
+  scoring_param_type:
+    success:
+      index: "Scoring parameter types retrieved successfully"
+      show: "Scoring parameter type details retrieved successfully"
+      create: "Scoring parameter type created successfully"
+      update: "Scoring parameter type updated successfully"
+      destroy: "Scoring parameter type deleted successfully"
+    errors:
+      index: "Failed to retrieve scoring parameter types"
+      show: "Failed to retrieve scoring parameter type details"
+      create: "Failed to create scoring parameter type"
+      update: "Failed to update scoring parameter type"
+      destroy: "Failed to delete scoring parameter type"
+
   scoring_parameter:
     success:
       index: "Scoring parameters retrieved successfully"
       show: "Scoring parameter details retrieved successfully"
       create: "Scoring parameter created successfully"
       update: "Scoring parameter updated successfully"
+      approve: "Scoring parameter approved successfully"
+      reject: "Scoring parameter rejected successfully"
+      request_modification: "Modification requested for scoring parameter successfully"
+      resubmit: "Scoring parameter resubmitted successfully"
       destroy: "Scoring parameter deleted successfully"
     errors:
       index: "Failed to retrieve scoring parameters"
       show: "Failed to retrieve scoring parameter details"
       create: "Failed to create scoring parameter"
       update: "Failed to update scoring parameter"
+      approve: "Failed to approve scoring parameter"
+      reject: "Failed to reject scoring parameter"
+      request_modification: "Failed to request modification for scoring parameter"
+      resubmit: "Failed to resubmit scoring parameter"
       destroy: "Failed to delete scoring parameter"
 
   parameter_normalizer:
@@ -75,20 +97,24 @@ en:
       show: "Facilitator details retrieved successfully"
       create: "Facilitator created successfully"
       update: "Facilitator updated successfully"
-      approved: "Facilitator approved successfully"
-      rejected: "Facilitator rejected successfully"
-      limit_updated: "Facilitator limit updated successfully"
-      additional_info_submitted: "Additional information submitted successfully"
+      approve: "Facilitator approved successfully"
+      reject: "Facilitator rejected successfully"
+      set_limit: "Facilitator limit updated successfully"
+      submit_additional_info: "Additional information submitted successfully"
+      request_modification: "Modification requested for facilitator successfully"
+      resubmit: "Facilitator resubmitted successfully"
       batch_created_all: "All facilitators created successfully"
       batch_created_partial: "Batch processing completed with partial success"
     errors:
       create: "Failed to create facilitator"
       update: "Failed to update facilitator"
       show: "Failed to retrieve facilitator details"
-      approval_failed: "Failed to approve facilitator"
-      rejection_failed: "Failed to reject facilitator"
-      limit_update_failed: "Failed to update facilitator limit"
-      additional_info_failed: "Failed to submit additional information"
+      approve: "Failed to approve facilitator"
+      reject: "Failed to reject facilitator"
+      set_limit: "Failed to update facilitator limit"
+      submit_additional_info: "Failed to submit additional information"
+      request_modification: "Failed to request modification for facilitator"
+      resubmit: "Failed to resubmit facilitator"
       no_business: "User must have a business associated to become a facilitator"
       invalid_batch_format: "Invalid batch format"
       empty_batch: "Empty batch provided"
@@ -118,6 +144,8 @@ en:
       approve: "Credit line approved successfully"
       reject: "Credit line rejected successfully"
       destroy: "Credit line deleted successfully"
+      request_modification: "Modification requested successfully"
+      resubmit: "Credit line resubmitted successfully"
     errors:
       index: "Failed to retrieve credit lines"
       show: "Failed to retrieve credit line details"
@@ -126,6 +154,8 @@ en:
       approve: "Failed to approve credit line"
       reject: "Failed to reject credit line"
       destroy: "Failed to delete credit line"
+      request_modification: "Failed to request modification"
+      resubmit: "Failed to resubmit credit line"
 
   system_config_definition:
     success:
@@ -147,12 +177,20 @@ en:
       show: "System config details retrieved successfully"
       create: "System config created successfully"
       update: "System config updated successfully"
+      approve: "System config approved successfully"
+      reject: "System config rejected successfully"
+      request_modification: "Modification requested for system config successfully"
+      resubmit: "System config resubmitted successfully"
       destroy: "System config deleted successfully"
     errors:
       index: "Failed to retrieve system configs"
       show: "Failed to retrieve system config details"
       create: "Failed to create system config"
       update: "Failed to update system config"
+      approve: "Failed to approve system config"
+      reject: "Failed to reject system config"
+      request_modification: "Failed to request modification for system config"
+      resubmit: "Failed to resubmit system config"
       destroy: "Failed to delete system config"
 
   category:

data/config/routes.rb

@@ -4,20 +4,21 @@ Dscf::Credit::Engine.routes.draw do
   resources :bank_branches
   resources :payments, only: [ :index, :show, :create, :update, :destroy ]
   resources :loans, only: [ :index, :show, :create, :update, :destroy ]
+  resources :scoring_param_types
 
   resources :facilitators, only: [ :index, :show, :create, :update, :destroy ] do
     collection do
       post "batch_create", to: "facilitators#batch_create"
+      post "additional_info", to: "facilitators#submit_additional_info"
     end
     member do
       patch "approve", to: "facilitators#approve"
       patch "reject", to: "facilitators#reject"
+      patch "request_modification", to: "facilitators#request_modification"
       patch "set_limit", to: "facilitators#set_limit"
     end
   end
 
-  post "facilitators/additional_info", to: "facilitators#submit_additional_info"
-
   resources :loan_profiles, only: [ :index, :show, :create, :update, :destroy ] do
     member do
       get "kyc_review", to: "kyc_reviews#show"
@@ -26,14 +27,30 @@ Dscf::Credit::Engine.routes.draw do
   end
 
   resources :payment_requests
-  resources :scoring_parameters
+  resources :scoring_parameters do
+    member do
+      patch "approve"
+      patch "reject"
+      patch "request_modification"
+      patch "resubmit"
+    end
+  end
   resources :parameter_normalizers
-  resources :system_configs
+  resources :system_configs do
+    member do
+      patch "approve"
+      patch "reject"
+      patch "request_modification"
+      patch "resubmit"
+    end
+  end
   resources :system_config_definitions
   resources :credit_lines do
     member do
-      patch "approve", to: "credit_lines#approve"
-      patch "reject", to: "credit_lines#reject"
+      patch "approve"
+      patch "reject"
+      patch "request_modification"
+      patch "resubmit"
     end
   end
   resources :credit_line_specs

data/db/migrate/20250822091011_create_dscf_credit_categories.rb

@@ -4,12 +4,14 @@ class CreateDscfCreditCategories < ActiveRecord::Migration[8.0]
       t.string :type, null: false
       t.string :name, null: false
       t.text :description
+      t.string :document_reference
 
       t.timestamps
     end
 
     add_index :dscf_credit_categories, :type
     add_index :dscf_credit_categories, :name
+    add_index :dscf_credit_categories, :document_reference
     add_index :dscf_credit_categories, [ :type, :name ], unique: true
   end
 end