dscf-banking 0.1.2 → 0.1.12

data/app/services/dscf/banking/withdrawal_service.rb

@@ -1,100 +0,0 @@
-module Dscf::Banking
-  class WithdrawalService < BaseTransactionService
-    attr_reader :transaction
-
-    def initialize(account:, amount:, description:, transaction_type_code: "WITHDRAWAL")
-      super()
-      @account = account
-      @amount = amount.to_f
-      @description = description
-      @transaction_type_code = transaction_type_code
-      @transaction = nil
-    end
-
-    def execute
-      return self unless validate_withdrawal
-
-      ActiveRecord::Base.transaction do
-        create_withdrawal_transaction
-        return self unless success?
-
-        process_withdrawal
-        return self unless success?
-      end
-
-      self
-    end
-
-    private
-
-    def validate_withdrawal
-      # Validate account
-      return false unless validate_account_active(@account, "Source account")
-
-      # Validate amount
-      if @amount <= 0
-        add_error("Withdrawal amount must be greater than zero")
-        return false
-      end
-
-      # Validate sufficient funds
-      return false unless validate_sufficient_funds(@account, @amount)
-
-      true
-    end
-
-    def create_withdrawal_transaction
-      transaction_type = find_or_create_transaction_type(@transaction_type_code)
-      return unless transaction_type
-
-      # For withdrawals, we need a system account as the credit account
-      # This represents the external destination
-      system_account = find_or_create_system_account
-
-      @transaction = create_transaction(
-        account: @account, # Primary account for the transaction
-        transaction_type: transaction_type,
-        debit_account: @account, # Customer account being debited
-        credit_account: system_account, # External destination
-        amount: @amount,
-        currency: @account.currency,
-        description: @description,
-        status: :pending
-      )
-    end
-
-    def process_withdrawal
-      @transaction.update(status: :processing)
-
-      # Update account balance (decrease for withdrawal)
-      new_balance = @account.current_balance - @amount
-      new_available = @account.available_balance - @amount
-
-      if @account.update(current_balance: new_balance, available_balance: new_available)
-        @transaction.update(status: :completed)
-        true
-      else
-        @account.errors.full_messages.each { |msg| add_error(msg) }
-        @transaction.update(status: :failed)
-        false
-      end
-    end
-
-    def find_or_create_system_account
-      # Find or create a system account for external withdrawals
-      system_account = Dscf::Banking::Account.system_accounts
-                                            .where(currency: @account.currency)
-                                            .where("name LIKE ?", "%Withdrawal%")
-                                            .first
-
-      unless system_account
-        # In a real system, this would be pre-created during setup
-        # For now, we'll assume it exists or create a placeholder
-        add_error("System withdrawal account not found for currency #{@account.currency}")
-        return nil
-      end
-
-      system_account
-    end
-  end
-end

data/db/migrate/20250919084147_add_account_type_to_accounts.rb

@@ -1,6 +0,0 @@
-class AddAccountTypeToAccounts < ActiveRecord::Migration[8.0]
-  def change
-    add_column :dscf_banking_accounts, :system_account, :boolean, default: false, null: false
-    add_index :dscf_banking_accounts, :system_account
-  end
-end

data/db/migrate/20250919084927_make_account_associations_optional.rb

@@ -1,6 +0,0 @@
-class MakeAccountAssociationsOptional < ActiveRecord::Migration[8.0]
-  def change
-    change_column_null :dscf_banking_accounts, :virtual_account_product_id, true
-    change_column_null :dscf_banking_accounts, :application_id, true
-  end
-end

data/db/migrate/20250919182831_create_dscf_banking_transaction_types.rb

@@ -1,14 +0,0 @@
-class CreateDscfBankingTransactionTypes < ActiveRecord::Migration[8.0]
-  def change
-    create_table :dscf_banking_transaction_types do |t|
-      t.string :code, null: false, limit: 20
-      t.string :name, null: false, limit: 100
-      t.text :description
-
-      t.timestamps
-    end
-
-    add_index :dscf_banking_transaction_types, :code, unique: true
-    add_index :dscf_banking_transaction_types, :name, unique: true
-  end
-end

data/db/migrate/20250919184220_create_dscf_banking_transactions.rb

@@ -1,21 +0,0 @@
-class CreateDscfBankingTransactions < ActiveRecord::Migration[8.0]
-  def change
-    create_table :dscf_banking_transactions do |t|
-      t.references :account, null: false, foreign_key: { to_table: :dscf_banking_accounts }
-      t.references :transaction_type, null: false, foreign_key: { to_table: :dscf_banking_transaction_types }
-      t.decimal :amount, precision: 20, scale: 4, null: false
-      t.string :currency, null: false, default: "ETB"
-      t.string :reference_number, null: false
-      t.text :description
-      t.integer :status, default: 0, null: false
-      t.references :debit_account, null: false, foreign_key: { to_table: :dscf_banking_accounts }
-      t.references :credit_account, null: false, foreign_key: { to_table: :dscf_banking_accounts }
-
-      t.timestamps
-    end
-
-    add_index :dscf_banking_transactions, :status
-    add_index :dscf_banking_transactions, :reference_number, unique: true
-    add_index :dscf_banking_transactions, [ :account_id, :created_at ]
-  end
-end

data/db/seeds.rb

@@ -1,125 +0,0 @@
-# db/seeds.rb
-
-# DEBUG: Confirm seed file execution and model availability
-puts "Seed file started"
-puts "Dscf::Core::User loaded? => #{defined?(Dscf::Core::User)}"
-puts "Dscf::Core::Role loaded? => #{defined?(Dscf::Core::Role)}"
-
-# DSCF Banking Engine Seed Data
-# This file seeds the database with sample data for all models in the correct dependency order
-
-puts "Starting DSCF Banking Engine seed data..."
-
-
-# 1. Seed roles (if model exists)
-puts "Seeding roles..."
-if defined?(Dscf::Core::Role)
-  user_role = Dscf::Core::Role.find_or_create_by(code: 'user') do |role|
-    role.name = 'User'
-  end
-  officer_role = Dscf::Core::Role.find_or_create_by(code: 'virtual_account_officer') do |role|
-    role.name = 'Virtual Account Officer'
-  end
-  manager_role = Dscf::Core::Role.find_or_create_by(code: 'virtual_account_manager') do |role|
-    role.name = 'Virtual Account Manager'
-  end
-  kyc_officer_role = Dscf::Core::Role.find_or_create_by(code: 'kyc_officer') do |role|
-    role.name = 'KYC Officer'
-  end
-  branch_manager_role = Dscf::Core::Role.find_or_create_by(code: 'branch_manager') do |role|
-    role.name = 'Branch Manager'
-  end
-  puts "✓ Roles created/found"
-else
-  puts "Warning: Dscf::Core::Role model not found. Skipping role seeding."
-end
-# 2. Seed users with roles (if model exists)
-puts "Seeding users..."
-if defined?(Dscf::Core::User)
-  user1 = Dscf::Core::User.find_or_create_by(email: "user@banking.com") do |u|
-    u.phone = "+251911123456"
-    u.password = "SecurePassword123!"
-    u.verified_at = Time.current
-    u.temp_password = false
-  end
-  user1.roles << user_role if defined?(user_role)
-  puts "Created user: #{user1.email} (user@banking.com)"
-
-  user2 = Dscf::Core::User.find_or_create_by(email: "virtual_account_officer@banking.com") do |u|
-    u.phone = "+251922123456"
-    u.password = "SecurePassword123!"
-    u.verified_at = Time.current
-    u.temp_password = false
-  end
-  user2.roles << officer_role if defined?(officer_role)
-  puts "Created user: #{user2.email} (virtual_account_officer@banking.com)"
-
-  user3 = Dscf::Core::User.find_or_create_by(email: "virtual_account_manager@banking.com") do |u|
-    u.phone = "+251933123456"
-    u.password = "SecurePassword123!"
-    u.verified_at = Time.current
-    u.temp_password = false
-  end
-  user3.roles << manager_role if defined?(manager_role)
-  puts "Created user: #{user3.email} (virtual_account_manager@banking.com)"
-
-  user4 = Dscf::Core::User.find_or_create_by(email: "user_virtual_account_officer@banking.com") do |u|
-    u.phone = "+251944123456"
-    u.password = "SecurePassword123!"
-    u.verified_at = Time.current
-    u.temp_password = false
-  end
-  user4.roles << user_role if defined?(user_role)
-  user4.roles << officer_role if defined?(officer_role)
-  puts "Created user: #{user4.email} (user_virtual_account_officer@banking.com)"
-
-  user5 = Dscf::Core::User.find_or_create_by(email: "virtual_account_manager2@banking.com") do |u|
-    u.phone = "+251955123456"
-    u.password = "SecurePassword123!"
-    u.verified_at = Time.current
-    u.temp_password = false
-  end
-  user5.roles << manager_role if defined?(manager_role)
-  puts "Created user: #{user5.email} (virtual_account_manager2@banking.com)"
-
-  user6 = Dscf::Core::User.find_or_create_by(email: "kyc_officer@banking.com") do |u|
-    u.phone = "+251966123456"
-    u.password = "SecurePassword123!"
-    u.verified_at = Time.current
-    u.temp_password = false
-  end
-  user6.roles << kyc_officer_role if defined?(kyc_officer_role)
-  puts "Created user: #{user6.email} (kyc_officer@banking.com)"
-
-  user7 = Dscf::Core::User.find_or_create_by(email: "branch_manager@banking.com") do |u|
-    u.phone = "+251977123456"
-    u.password = "SecurePassword123!"
-    u.verified_at = Time.current
-    u.temp_password = false
-  end
-  user7.roles << branch_manager_role if defined?(branch_manager_role)
-  puts "Created user: #{user7.email} (branch_manager@banking.com)"
-else
-  puts "Warning: Dscf::Core::User model not found. Skipping user seeding."
-end# 3. Seed transaction types (engine model)
-puts "Seeding transaction types..."
-if defined?(Dscf::Banking::TransactionType)
-  transaction_types = [
-    { name: "Deposit", code: "DEP" },
-    { name: "Withdrawal", code: "WDL" },
-    { name: "Transfer", code: "TRF" },
-    { name: "Interest Credit", code: "INTC" },
-    { name: "Fee Debit", code: "FEED" }
-  ]
-
-  transaction_types.each do |attrs|
-    Dscf::Banking::TransactionType.find_or_create_by(code: attrs[:code]) do |tt|
-      tt.name = attrs[:name]
-    end
-  end
-  puts "✓ Transaction types created/found"
-else
-  puts "Warning: Dscf::Banking::TransactionType not found. Skipping transaction type seeding."
-end
-
-puts "DSCF Banking Engine seed data completed successfully!"

data/spec/factories/dscf/banking/transaction_types.rb

@@ -1,56 +0,0 @@
-FactoryBot.define do
-  factory :dscf_banking_transaction_type, class: "Dscf::Banking::TransactionType" do
-    sequence(:code) { |n| "TXN_TYPE_#{n}" }
-    sequence(:name) { |n| "Transaction Type #{n}" }
-    description { "Test transaction type description" }
-
-    trait :deposit do
-      code { "DEPOSIT" }
-      name { "Deposit" }
-      description { "Customer deposit from external source" }
-    end
-
-    trait :withdrawal do
-      code { "WITHDRAWAL" }
-      name { "Withdrawal" }
-      description { "Customer withdrawal to external destination" }
-    end
-
-    trait :transfer do
-      code { "TRANSFER" }
-      name { "Transfer" }
-      description { "Transfer between customer accounts" }
-    end
-
-    trait :interest_credit do
-      code { "INTEREST_CREDIT" }
-      name { "Interest Credit" }
-      description { "Interest payment to customer account" }
-    end
-
-    trait :interest_expense do
-      code { "INTEREST_EXPENSE" }
-      name { "Interest Expense" }
-      description { "Interest expense booking" }
-    end
-
-    trait :tax_withholding do
-      code { "TAX_WITHHOLDING" }
-      name { "Tax Withholding" }
-      description { "Tax withholding on interest payments" }
-    end
-
-    trait :settlement do
-      code { "SETTLEMENT" }
-      name { "Settlement" }
-      description { "Settlement transaction with core banking system" }
-    end
-  end
-
-  # Alias for shared spec compatibility
-  factory :transaction_type, class: "Dscf::Banking::TransactionType" do
-    sequence(:code) { |n| "TXN_TYPE_#{n}" }
-    sequence(:name) { |n| "Transaction Type #{n}" }
-    description { "Test transaction type description" }
-  end
-end

data/spec/factories/dscf/banking/transactions.rb

@@ -1,52 +0,0 @@
-FactoryBot.define do
-  factory :dscf_banking_transaction, class: "Dscf::Banking::Transaction" do
-    association :account, factory: :dscf_banking_account
-    association :transaction_type, factory: [ :dscf_banking_transaction_type, :deposit ]
-    association :debit_account, factory: :dscf_banking_account
-    association :credit_account, factory: :dscf_banking_account
-
-    amount { 1000.00 }
-    currency { "ETB" }
-    description { "Test transaction" }
-    status { :pending }
-
-    trait :deposit do
-      association :transaction_type, factory: [ :dscf_banking_transaction_type, :deposit ]
-
-      after(:build) do |transaction|
-        transaction.credit_account = transaction.account
-        transaction.debit_account = create(:dscf_banking_account, :settlement_account, currency: transaction.currency)
-      end
-    end
-
-    trait :withdrawal do
-      association :transaction_type, factory: [ :dscf_banking_transaction_type, :withdrawal ]
-
-      after(:build) do |transaction|
-        transaction.debit_account = transaction.account
-        transaction.credit_account = create(:dscf_banking_account, :settlement_account, currency: transaction.currency)
-      end
-    end
-
-    trait :completed do
-      status { :completed }
-    end
-
-    trait :failed do
-      status { :failed }
-    end
-  end
-
-  # Alias for shared spec compatibility
-  factory :transaction, class: "Dscf::Banking::Transaction" do
-    association :account, factory: :dscf_banking_account
-    association :transaction_type, factory: [ :dscf_banking_transaction_type, :deposit ]
-    association :debit_account, factory: :dscf_banking_account
-    association :credit_account, factory: :dscf_banking_account
-
-    amount { 1000.00 }
-    currency { "ETB" }
-    description { "Test transaction" }
-    status { :pending }
-  end
-end