dscf-banking 0.1.2 → 0.1.12

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0e4889491f1e8d88b8355eb069e349a28b386c19ceb0b24ad31c106568e9ac46
-  data.tar.gz: 9c9a3692230d26e79093a1fad8ad6efced44e35682155608cf7d172c3d843d16
+  metadata.gz: 0a18bbdf6cbc7d9686c18ee99a8bce779e501210894a6518e1f111f350592a5d
+  data.tar.gz: 2f65b9bd050c1a61ff5b6e45687f34ed1edcb8f6fb79eff1d124625baca58b13
 SHA512:
-  metadata.gz: f691b1c9f323255accfc2bc3bd910b0eba87518fd2cdec4839f4f611a9338de25a65e5886bec16a8e5f13904d7223c34ab7b4f0f4a0f6d73905e19097386a441
-  data.tar.gz: 616b0ea1fbfcb0e939e424ebddaa4c5f23391bf29177df480dc064884e83c2e6bfdac14069b5e2411ed2cc5355a412ff5ecd4e160ba350e14cf759dcffc86099
+  metadata.gz: 33b71cb30dcd71b6fbcb435c58509f82ce9c6f450cbf5d7de29309731e86462f808385084d90745f84f962de0e6169c865feccab3fb203fe4d476488ff2d26c8
+  data.tar.gz: 4341ddcaf03f9e40d28eb600c948e0ef8f1d85bebb860f8464d1f03267473b10963b169799b19d0153aec4b8d6441c7934666987f3991e1872b3b6ab725b7f2a

data/app/models/dscf/banking/account.rb

@@ -1,7 +1,7 @@
 module Dscf::Banking
   class Account < ApplicationRecord
-    belongs_to :virtual_account_product, optional: true
-    belongs_to :application, optional: true
+    belongs_to :virtual_account_product
+    belongs_to :application
 
     enum :status, {
       draft: 0,
@@ -17,16 +17,12 @@ module Dscf::Banking
     validates :currency, presence: true
     validates :current_balance, :available_balance, :minimum_balance,
               numericality: { greater_than_or_equal_to: 0 }
-    validates :system_account, inclusion: { in: [ true, false ] }
-    validate :system_account_associations
 
     before_validation :generate_account_number, on: :create
     before_validation :set_defaults, on: :create
 
     scope :active_accounts, -> { where(active: true, status: :active) }
     scope :by_currency, ->(currency) { where(currency: currency) }
-    scope :customer_accounts, -> { where(system_account: false) }
-    scope :system_accounts, -> { where(system_account: true) }
 
     def sufficient_funds_for_withdrawal?(amount)
       available_balance - amount >= minimum_balance
@@ -88,23 +84,5 @@ module Dscf::Banking
       self.minimum_balance ||= 0
       self.name ||= "Account Holder"
     end
-
-    def system_account_associations
-      if system_account?
-        if virtual_account_product.present?
-          errors.add(:virtual_account_product, "must be blank for system accounts")
-        end
-        if application.present?
-          errors.add(:application, "must be blank for system accounts")
-        end
-      else
-        unless virtual_account_product.present?
-          errors.add(:virtual_account_product, "must be present for customer accounts")
-        end
-        unless application.present?
-          errors.add(:application, "must be present for customer accounts")
-        end
-      end
-    end
   end
 end

data/config/routes.rb

@@ -22,18 +22,4 @@ Dscf::Banking::Engine.routes.draw do
       post :reject
     end
   end
-
-  resources :transaction_types
-
-  resources :transactions do
-    collection do
-      post :transfer
-      post :deposit
-      post :withdrawal
-    end
-    member do
-      post :cancel
-      get :details
-    end
-  end
 end

data/lib/dscf/banking/version.rb

@@ -1,5 +1,5 @@
 module Dscf
   module Banking
-    VERSION = "0.1.2"
+    VERSION = "0.1.12"
   end
 end

data/spec/factories/dscf/banking/accounts.rb

@@ -10,7 +10,6 @@ FactoryBot.define do
     minimum_balance { 0 }
     status { :draft }
     active { true }
-    system_account { false }
     account_properties { {} }
 
     trait :active do
@@ -33,33 +32,6 @@ FactoryBot.define do
       available_balance { 1000 }
       minimum_balance { 100 }
     end
-
-    trait :system_account do
-      system_account { true }
-      virtual_account_product { nil }
-      application { nil }
-    end
-
-    trait :settlement_account do
-      system_account { true }
-      name { "Core Banking Settlement Account" }
-      virtual_account_product { nil }
-      application { nil }
-    end
-
-    trait :interest_expense_account do
-      system_account { true }
-      name { "Interest Expense Account" }
-      virtual_account_product { nil }
-      application { nil }
-    end
-
-    trait :tax_liability_account do
-      system_account { true }
-      name { "Interest Tax Payable Account" }
-      virtual_account_product { nil }
-      application { nil }
-    end
   end
 
   # Alias for shared spec compatibility

data/spec/factories/dscf/banking/applications.rb

@@ -4,7 +4,6 @@ FactoryBot.define do
     association :virtual_account_product
     applicant_type { :individual }
     status { :draft }
-    sequence(:application_number) { |n| "IND#{Date.current.strftime('%Y%m%d')}#{n.to_s.rjust(4, '0')}" }
 
     form_data do
       {
@@ -24,7 +23,7 @@ FactoryBot.define do
 
     trait :business do
       applicant_type { :business }
-      sequence(:application_number) { |n| "BUS#{Date.current.strftime('%Y%m%d')}#{n.to_s.rjust(4, '0')}" }
+      application_type { :current }
       form_data do
         {
           business_name: Faker::Company.name,
@@ -45,21 +44,21 @@ FactoryBot.define do
     trait :under_review do
       status { :under_review }
       submitted_at { 2.days.ago }
-      association :assigned_kyc_officer, factory: :user
+      association :assigned_kyc_officer, factory: [ :user, :dscf_core ]
     end
 
     trait :approved do
       status { :approved }
       submitted_at { 3.days.ago }
-      association :assigned_kyc_officer, factory: :user
-      association :assigned_branch_manager, factory: :user
+      association :assigned_kyc_officer, factory: [ :user, :dscf_core ]
+      association :assigned_branch_manager, factory: [ :user, :dscf_core ]
     end
 
     trait :rejected do
       status { :rejected }
       submitted_at { 3.days.ago }
       rejection_reason { "Incomplete documentation" }
-      association :assigned_kyc_officer, factory: :user
+      association :assigned_kyc_officer, factory: [ :user, :dscf_core ]
     end
   end
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: dscf-banking
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.12
 platform: ruby
 authors:
 - Eyosiyas Mekbib
 bindir: bin
 cert_chain: []
-date: 2025-09-20 00:00:00.000000000 Z
+date: 2025-09-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -447,8 +447,6 @@ files:
 - app/controllers/dscf/banking/interest_rate_types_controller.rb
 - app/controllers/dscf/banking/product_approvals_controller.rb
 - app/controllers/dscf/banking/product_categories_controller.rb
-- app/controllers/dscf/banking/transaction_types_controller.rb
-- app/controllers/dscf/banking/transactions_controller.rb
 - app/controllers/dscf/banking/virtual_account_products_controller.rb
 - app/jobs/dscf/banking/application_job.rb
 - app/mailers/dscf/banking/application_mailer.rb
@@ -462,8 +460,6 @@ files:
 - app/models/dscf/banking/product_approval.rb
 - app/models/dscf/banking/product_audit_log.rb
 - app/models/dscf/banking/product_category.rb
-- app/models/dscf/banking/transaction.rb
-- app/models/dscf/banking/transaction_type.rb
 - app/models/dscf/banking/virtual_account_product.rb
 - app/serializers/dscf/banking/account_serializer.rb
 - app/serializers/dscf/banking/application_serializer.rb
@@ -472,14 +468,8 @@ files:
 - app/serializers/dscf/banking/interest_rate_type_serializer.rb
 - app/serializers/dscf/banking/product_approval_serializer.rb
 - app/serializers/dscf/banking/product_category_serializer.rb
-- app/serializers/dscf/banking/transaction_serializer.rb
-- app/serializers/dscf/banking/transaction_type_serializer.rb
 - app/serializers/dscf/banking/virtual_account_product_serializer.rb
 - app/services/dscf/banking/account_creation_service.rb
-- app/services/dscf/banking/base_transaction_service.rb
-- app/services/dscf/banking/deposit_service.rb
-- app/services/dscf/banking/transfer_service.rb
-- app/services/dscf/banking/withdrawal_service.rb
 - config/routes.rb
 - db/migrate/20250830211002_create_dscf_banking_product_categories.rb
 - db/migrate/20250830211027_create_dscf_banking_interest_rate_types.rb
@@ -492,11 +482,6 @@ files:
 - db/migrate/20250831084706_allow_null_virtual_account_product_id_in_product_audit_logs.rb
 - db/migrate/20250912193134_create_dscf_banking_applications.rb
 - db/migrate/20250912203527_create_dscf_banking_accounts.rb
-- db/migrate/20250919084147_add_account_type_to_accounts.rb
-- db/migrate/20250919084927_make_account_associations_optional.rb
-- db/migrate/20250919182831_create_dscf_banking_transaction_types.rb
-- db/migrate/20250919184220_create_dscf_banking_transactions.rb
-- db/seeds.rb
 - lib/dscf/banking.rb
 - lib/dscf/banking/engine.rb
 - lib/dscf/banking/version.rb
@@ -509,8 +494,6 @@ files:
 - spec/factories/dscf/banking/product_approvals.rb
 - spec/factories/dscf/banking/product_audit_logs.rb
 - spec/factories/dscf/banking/product_categories.rb
-- spec/factories/dscf/banking/transaction_types.rb
-- spec/factories/dscf/banking/transactions.rb
 - spec/factories/dscf/banking/virtual_account_products.rb
 homepage: https://mksaddis.com/
 licenses: []

data/app/controllers/dscf/banking/transaction_types_controller.rb

@@ -1,27 +0,0 @@
-module Dscf::Banking
-  class TransactionTypesController < ApplicationController
-    include Dscf::Core::Common
-
-    private
-
-    def model_params
-      params.require(:payload).permit(
-        :code,
-        :name,
-        :description
-      )
-    end
-
-    def eager_loaded_associations
-      []
-    end
-
-    def allowed_order_columns
-      %w[id code name created_at updated_at]
-    end
-
-    def default_serializer_includes
-      {}
-    end
-  end
-end