draper 0.18.0 → 1.1.0

data/{performance → spec/performance}/decorators.rb

@@ -1,6 +1,5 @@
 require "./performance/models"
-class ProductDecorator < Draper::Base
-  decorates :product
+class ProductDecorator < Draper::Decorator
 
   def awesome_title
     "Awesome Title"
@@ -21,8 +20,7 @@ class ProductDecorator < Draper::Base
 
 end
 
-class FastProductDecorator < Draper::Base
-  decorates :product
+class FastProductDecorator < Draper::Decorator
 
   def awesome_title
     "Awesome Title"

data/spec/spec_helper.rb

@@ -1,54 +1,36 @@
 require 'bundler/setup'
-require 'ammeter/init'
-require 'rails'
-
-require 'action_view'
-Bundler.require
-
-require './spec/support/samples/active_record'
-require './spec/support/samples/decorator'
-require './spec/support/samples/decorator_with_allows'
-require './spec/support/samples/decorator_with_multiple_allows'
-require './spec/support/samples/decorator_with_application_helper'
-require './spec/support/samples/decorator_with_denies'
-require './spec/support/samples/decorator_with_denies_all'
-require './spec/support/samples/decorator_with_special_methods'
-require './spec/support/samples/enumerable_proxy'
-require './spec/support/samples/namespaced_product'
-require './spec/support/samples/namespaced_product_decorator'
-require './spec/support/samples/non_active_model_product'
-require './spec/support/samples/product'
-require './spec/support/samples/product_decorator'
-require './spec/support/samples/products_decorator'
-require './spec/support/samples/sequel_product'
-require './spec/support/samples/specific_product_decorator'
-require './spec/support/samples/some_thing'
-require './spec/support/samples/some_thing_decorator'
-require './spec/support/samples/widget'
-require './spec/support/samples/widget_decorator'
-
+require 'draper'
 require 'action_controller'
 require 'action_controller/test_case'
 
-module ActionController
-  class Base
-    Draper::System.setup_action_controller(self)
-  end
+RSpec.configure do |config|
+  config.treat_symbols_as_metadata_keys_with_true_values = true
+  config.expect_with(:rspec) {|c| c.syntax = :expect}
+  config.order = :random
 end
 
-module ActiveRecord
-  class Relation
-  end
-end
+class Model; include Draper::Decoratable; end
+
+class Product < Model; end
+class ProductDecorator < Draper::Decorator; end
+class ProductsDecorator < Draper::CollectionDecorator; end
+
+class ProductPresenter < Draper::Decorator; end
 
-class ApplicationController < ActionController::Base
-  def hello_world
-    "Hello, World!"
-  end
-  helper_method :hello_world
+class OtherDecorator < Draper::Decorator; end
+
+module Namespaced
+  class Product < Model; end
+  class ProductDecorator < Draper::Decorator; end
+
+  class OtherDecorator < Draper::Decorator; end
 end
 
+# After each example, revert changes made to the class
+def protect_class(klass)
+  before { stub_const klass.name, Class.new(klass) }
+end
 
-class << Rails
-  undef application # Avoid silly Rails bug: https://github.com/rails/rails/pull/6429
+def protect_module(mod)
+  before { stub_const mod.name, mod.dup }
 end

data/spec/support/dummy_app.rb

@@ -0,0 +1,85 @@
+require 'socket'
+require 'net/http'
+
+# Adapted from code by Jon Leighton
+# https://github.com/jonleighton/focused_controller/blob/ec7ccf1/test/acceptance/app_test.rb
+
+class DummyApp
+
+  def initialize(environment)
+    raise ArgumentError, "Environment must be development or production" unless ["development", "production"].include?(environment.to_s)
+    @environment = environment
+  end
+
+  attr_reader :environment
+
+  def url
+    "http://#{localhost}:#{port}"
+  end
+
+  def get(path)
+    Net::HTTP.get(URI(url + path))
+  end
+
+  def within_app(&block)
+    Dir.chdir(root, &block)
+  end
+
+  def start_server
+    within_app do
+      IO.popen("bundle exec rails s -e #{@environment} -p #{port} 2>&1") do |out|
+        start   = Time.now
+        started = false
+        output  = ""
+        timeout = 60.0
+
+        while !started && !out.eof? && Time.now - start <= timeout
+          output << read_output(out)
+          sleep 0.1
+
+          begin
+            TCPSocket.new(localhost, port)
+          rescue Errno::ECONNREFUSED
+          else
+            started = true
+          end
+        end
+
+        raise "Server failed to start:\n#{output}" unless started
+
+        yield
+
+        Process.kill("KILL", out.pid)
+        File.delete("tmp/pids/server.pid")
+      end
+    end
+  end
+
+  private
+
+  def root
+    File.expand_path("../../dummy", __FILE__)
+  end
+
+  def localhost
+    "127.0.0.1"
+  end
+
+  def port
+    @port ||= begin
+      server = TCPServer.new(localhost, 0)
+      server.addr[1]
+    ensure
+      server.close if server
+    end
+  end
+
+  def read_output(stream)
+    read = IO.select([stream], [], [stream], 0.1)
+    output = ""
+    loop { output << stream.read_nonblock(1024) } if read
+    output
+  rescue Errno::EAGAIN, Errno::EWOULDBLOCK, EOFError
+    output
+  end
+end

data/spec/support/matchers/have_text.rb

@@ -0,0 +1,50 @@
+require 'capybara'
+
+module HaveTextMatcher
+  def have_text(text)
+    HaveText.new(text)
+  end
+
+  class HaveText
+    def initialize(text)
+      @text = text
+    end
+
+    def in(css)
+      @css = css
+      self
+    end
+
+    def matches?(subject)
+      @subject = Capybara.string(subject)
+
+      @subject.has_css?(@css || "*", text: @text)
+    end
+
+    def failure_message_for_should
+      "expected to find #{@text.inspect} #{within}"
+    end
+
+    def failure_message_for_should_not
+      "expected not to find #{@text.inspect} #{within}"
+    end
+
+    private
+
+    def within
+      if @css && @subject.has_css?(@css)
+        "within\n#{@subject.find(@css).native}"
+      else
+        "#{inside} within\n#{@subject.native}"
+      end
+    end
+
+    def inside
+      @css ? "inside #{@css.inspect}" : "anywhere"
+    end
+  end
+end
+
+RSpec.configure do |config|
+  config.include HaveTextMatcher
+end

data/spec/support/shared_examples/decoratable_equality.rb

@@ -0,0 +1,40 @@
+shared_examples_for "decoration-aware #==" do |subject|
+  it "is true for itself" do
+    expect(subject == subject).to be_true
+  end
+
+  it "is false for another object" do
+    expect(subject == Object.new).to be_false
+  end
+
+  it "is true for a decorated version of itself" do
+    decorated = double(source: subject, decorated?: true)
+
+    expect(subject == decorated).to be_true
+  end
+
+  it "is false for a decorated other object" do
+    decorated = double(source: Object.new, decorated?: true)
+
+    expect(subject == decorated).to be_false
+  end
+
+  it "is false for a decoratable object with a `source` association" do
+    decoratable = double(source: subject, decorated?: false)
+
+    expect(subject == decoratable).to be_false
+  end
+
+  it "is false for an undecoratable object with a `source` association" do
+    undecoratable = double(source: subject)
+
+    expect(subject == undecoratable).to be_false
+  end
+
+  it "is true for a multiply-decorated version of itself" do
+    decorated = double(source: subject, decorated?: true)
+    redecorated = double(source: decorated, decorated?: true)
+
+    expect(subject == redecorated).to be_true
+  end
+end

data/spec/support/shared_examples/view_helpers.rb

@@ -0,0 +1,39 @@
+shared_examples_for "view helpers" do |subject|
+  describe "#helpers" do
+    it "returns the current view context" do
+      Draper::ViewContext.stub current: :current_view_context
+      expect(subject.helpers).to be :current_view_context
+    end
+
+    it "is aliased to #h" do
+      Draper::ViewContext.stub current: :current_view_context
+      expect(subject.h).to be :current_view_context
+    end
+  end
+
+  describe "#localize" do
+    it "delegates to #helpers" do
+      subject.stub helpers: double
+      subject.helpers.should_receive(:localize).with(:an_object, some: "parameter")
+      subject.localize(:an_object, some: "parameter")
+    end
+
+    it "is aliased to #l" do
+      subject.stub helpers: double
+      subject.helpers.should_receive(:localize).with(:an_object, some: "parameter")
+      subject.l(:an_object, some: "parameter")
+    end
+  end
+
+  describe ".helpers" do
+    it "returns the current view context" do
+      Draper::ViewContext.stub current: :current_view_context
+      expect(subject.class.helpers).to be :current_view_context
+    end
+
+    it "is aliased to .h" do
+      Draper::ViewContext.stub current: :current_view_context
+      expect(subject.class.h).to be :current_view_context
+    end
+  end
+end