draper 0.18.0 → 1.1.0

data/spec/dummy/spec/decorators/devise_spec.rb

@@ -0,0 +1,64 @@
+require 'spec_helper'
+
+if defined?(Devise)
+  describe "A decorator spec" do
+    it "can sign in a real user" do
+      user = User.new
+      sign_in user
+
+      expect(helper.current_user).to be user
+    end
+
+    it "can sign in a mock user" do
+      user = double("User")
+      sign_in :user, user
+
+      expect(helper.current_user).to be user
+    end
+
+    it "can sign in a real admin" do
+      admin = Admin.new
+      sign_in admin
+
+      expect(helper.current_admin).to be admin
+    end
+
+    it "can sign in a mock admin" do
+      admin = double("Admin")
+      sign_in :admin, admin
+
+      expect(helper.current_admin).to be admin
+    end
+
+    it "can sign out a real user" do
+      user = User.new
+      sign_in user
+      sign_out user
+
+      expect(helper.current_user).to be_nil
+    end
+
+    it "can sign out a mock user" do
+      user = double("User")
+      sign_in :user, user
+      sign_out :user
+
+      expect(helper.current_user).to be_nil
+    end
+
+    it "can sign out without a user" do
+      sign_out :user
+
+      expect(helper.current_user).to be_nil
+    end
+
+    it "is backwards-compatible" do
+      user = double("User")
+      ActiveSupport::Deprecation.silence do
+        sign_in user
+      end
+
+      expect(helper.current_user).to be user
+    end
+  end
+end

data/spec/dummy/spec/decorators/helpers_spec.rb

@@ -0,0 +1,21 @@
+require 'spec_helper'
+
+describe "A decorator spec" do
+  it "can access helpers through `helper`" do
+    expect(helper.content_tag(:p, "Help!")).to eq "<p>Help!</p>"
+  end
+
+  it "can access helpers through `helpers`" do
+    expect(helpers.content_tag(:p, "Help!")).to eq "<p>Help!</p>"
+  end
+
+  it "can access helpers through `h`" do
+    expect(h.content_tag(:p, "Help!")).to eq "<p>Help!</p>"
+  end
+
+  it "gets the same helper object as a decorator" do
+    decorator = Draper::Decorator.new(Object.new)
+
+    expect(helpers).to be decorator.helpers
+  end
+end

data/spec/dummy/spec/decorators/post_decorator_spec.rb

@@ -0,0 +1,46 @@
+require 'spec_helper'
+
+describe PostDecorator do
+  let(:decorator) { PostDecorator.new(source) }
+  let(:source) { Post.create }
+
+  it "can use built-in helpers" do
+    expect(decorator.truncated).to eq "Once upon a..."
+  end
+
+  it "can use built-in private helpers" do
+    expect(decorator.html_escaped).to eq "<script>danger</script>"
+  end
+
+  it "can use user-defined helpers from app/helpers" do
+    expect(decorator.hello_world).to eq "Hello, world!"
+  end
+
+  it "can use path helpers with its model" do
+    expect(decorator.path_with_model).to eq "/en/posts/#{source.id}"
+  end
+
+  it "can use path helpers with its id" do
+    expect(decorator.path_with_id).to eq "/en/posts/#{source.id}"
+  end
+
+  it "can use url helpers with its model" do
+    expect(decorator.url_with_model).to eq "http://www.example.com:12345/en/posts/#{source.id}"
+  end
+
+  it "can use url helpers with its id" do
+    expect(decorator.url_with_id).to eq "http://www.example.com:12345/en/posts/#{source.id}"
+  end
+
+  it "can be passed implicitly to url_for" do
+    expect(decorator.link).to eq "<a href=\"/en/posts/#{source.id}\">#{source.id}</a>"
+  end
+
+  it "serializes overriden attributes" do
+    expect(decorator.serializable_hash["updated_at"]).to be :overridden
+  end
+
+  it "uses a test view context from ApplicationController" do
+    expect(Draper::ViewContext.current.controller).to be_an ApplicationController
+  end
+end

data/spec/dummy/spec/decorators/spec_type_spec.rb

@@ -0,0 +1,7 @@
+require 'spec_helper'
+
+describe "A spec in this folder" do
+  it "is a decorator spec" do
+    expect(example.metadata[:type]).to be :decorator
+  end
+end

data/spec/dummy/spec/decorators/view_context_spec.rb

@@ -0,0 +1,22 @@
+require 'spec_helper'
+
+def it_does_not_leak_view_context
+  2.times do
+    it "has an independent view context" do
+      expect(Draper::ViewContext.current).not_to be :leaked
+      Draper::ViewContext.current = :leaked
+    end
+  end
+end
+
+describe "A decorator spec", type: :decorator do
+  it_does_not_leak_view_context
+end
+
+describe "A controller spec", type: :controller do
+  it_does_not_leak_view_context
+end
+
+describe "A mailer spec", type: :mailer do
+  it_does_not_leak_view_context
+end

data/spec/dummy/spec/mailers/post_mailer_spec.rb

@@ -0,0 +1,33 @@
+require 'spec_helper'
+
+describe PostMailer do
+  describe "#decorated_email" do
+    let(:email_body) { Capybara.string(email.body.to_s) }
+    let(:email) { PostMailer.decorated_email(post).deliver }
+    let(:post) { Post.create }
+
+    it "decorates" do
+      expect(email_body).to have_content "Today"
+    end
+
+    it "can use path helpers with a model" do
+      expect(email_body).to have_css "#path_with_model", text: "/en/posts/#{post.id}"
+    end
+
+    it "can use path helpers with an id" do
+      expect(email_body).to have_css "#path_with_id", text: "/en/posts/#{post.id}"
+    end
+
+    it "can use url helpers with a model" do
+      expect(email_body).to have_css "#url_with_model", text: "http://www.example.com:12345/en/posts/#{post.id}"
+    end
+
+    it "can use url helpers with an id" do
+      expect(email_body).to have_css "#url_with_id", text: "http://www.example.com:12345/en/posts/#{post.id}"
+    end
+
+    it "uses the correct view context controller" do
+      expect(email_body).to have_css "#controller", text: "PostMailer"
+    end
+  end
+end

data/spec/dummy/spec/models/mongoid_post_spec.rb

@@ -0,0 +1,10 @@
+require 'spec_helper'
+
+if defined?(Mongoid)
+  describe MongoidPost do
+    it "is decoratable" do
+      expect(MongoidPost).to respond_to :decorator_class
+      expect(MongoidPost.new).to respond_to :decorate
+    end
+  end
+end

data/spec/dummy/spec/models/post_spec.rb

@@ -0,0 +1,14 @@
+require 'spec_helper'
+
+describe Post do
+  describe "#==" do
+    it "is true for other instances' decorators" do
+      Post.create
+      one = Post.first
+      other = Post.first
+
+      expect(one).not_to be other
+      expect(one == other.decorate).to be_true
+    end
+  end
+end

data/spec/dummy/spec/spec_helper.rb

@@ -0,0 +1,9 @@
+ENV['RAILS_ENV'] ||= 'test'
+require File.expand_path('../../config/environment', __FILE__)
+require 'rspec/rails'
+
+RSpec.configure do |config|
+  config.treat_symbols_as_metadata_keys_with_true_values = true
+  config.expect_with(:rspec) {|c| c.syntax = :expect}
+  config.order = :random
+end

data/spec/dummy/test/decorators/minitest/devise_test.rb

@@ -0,0 +1,64 @@
+require 'minitest_helper'
+
+if defined?(Devise)
+  describe "A decorator test" do
+    it "can sign in a real user" do
+      user = User.new
+      sign_in user
+
+      assert_same user, helper.current_user
+    end
+
+    it "can sign in a mock user" do
+      user = Object.new
+      sign_in :user, user
+
+      assert_same user, helper.current_user
+    end
+
+    it "can sign in a real admin" do
+      admin = Admin.new
+      sign_in admin
+
+      assert_same admin, helper.current_admin
+    end
+
+    it "can sign in a mock admin" do
+      admin = Object.new
+      sign_in :admin, admin
+
+      assert_same admin, helper.current_admin
+    end
+
+    it "can sign out a real user" do
+      user = User.new
+      sign_in user
+      sign_out user
+
+      assert helper.current_user.nil?
+    end
+
+    it "can sign out a mock user" do
+      user = Object.new
+      sign_in :user, user
+      sign_out :user
+
+      assert helper.current_user.nil?
+    end
+
+    it "can sign out without a user" do
+      sign_out :user
+
+      assert helper.current_user.nil?
+    end
+
+    it "is backwards-compatible" do
+      user = Object.new
+      ActiveSupport::Deprecation.silence do
+        sign_in user
+      end
+
+      assert_same user, helper.current_user
+    end
+  end
+end

data/spec/dummy/test/decorators/minitest/helpers_test.rb

@@ -0,0 +1,21 @@
+require 'minitest_helper'
+
+describe "A decorator test" do
+  it "can access helpers through `helper`" do
+    assert_equal "<p>Help!</p>", helper.content_tag(:p, "Help!")
+  end
+
+  it "can access helpers through `helpers`" do
+    assert_equal "<p>Help!</p>", helpers.content_tag(:p, "Help!")
+  end
+
+  it "can access helpers through `h`" do
+    assert_equal "<p>Help!</p>", h.content_tag(:p, "Help!")
+  end
+
+  it "gets the same helper object as a decorator" do
+    decorator = Draper::Decorator.new(Object.new)
+
+    assert_same decorator.helpers, helpers
+  end
+end

data/spec/dummy/test/decorators/minitest/spec_type_test.rb

@@ -0,0 +1,52 @@
+require 'minitest_helper'
+
+def it_is_a_decorator_test
+  it "is a decorator test" do
+    assert_kind_of Draper::TestCase, self
+  end
+end
+
+def it_is_not_a_decorator_test
+  it "is not a decorator test" do
+    refute_kind_of Draper::TestCase, self
+  end
+end
+
+ProductDecorator = Class.new(Draper::Decorator)
+ProductsDecorator = Class.new(Draper::CollectionDecorator)
+
+describe ProductDecorator do
+  it_is_a_decorator_test
+end
+
+describe ProductsDecorator do
+  it_is_a_decorator_test
+end
+
+describe "ProductDecorator" do
+  it_is_a_decorator_test
+end
+
+describe "AnyDecorator" do
+  it_is_a_decorator_test
+end
+
+describe "Any decorator" do
+  it_is_a_decorator_test
+end
+
+describe "AnyDecoratorTest" do
+  it_is_a_decorator_test
+end
+
+describe "Any decorator test" do
+  it_is_a_decorator_test
+end
+
+describe Object do
+  it_is_not_a_decorator_test
+end
+
+describe "Nope" do
+  it_is_not_a_decorator_test
+end

data/spec/dummy/test/decorators/minitest/view_context_test.rb

@@ -0,0 +1,24 @@
+require 'minitest_helper'
+
+def it_does_not_leak_view_context
+  2.times do
+    it "has an independent view context" do
+      refute_equal :leaked, Draper::ViewContext.current
+      Draper::ViewContext.current = :leaked
+    end
+  end
+end
+
+describe "A decorator test" do
+  it_does_not_leak_view_context
+end
+
+describe "A controller test" do
+  tests Class.new(ActionController::Base)
+
+  it_does_not_leak_view_context
+end
+
+describe "A mailer test" do
+  it_does_not_leak_view_context
+end

data/spec/dummy/test/decorators/test_unit/devise_test.rb

@@ -0,0 +1,64 @@
+require 'test_helper'
+
+if defined?(Devise)
+  class DeviseTest < Draper::TestCase
+    def test_sign_in_a_real_user
+      user = User.new
+      sign_in user
+
+      assert_same user, helper.current_user
+    end
+
+    def test_sign_in_a_mock_user
+      user = Object.new
+      sign_in :user, user
+
+      assert_same user, helper.current_user
+    end
+
+    def test_sign_in_a_real_admin
+      admin = Admin.new
+      sign_in admin
+
+      assert_same admin, helper.current_admin
+    end
+
+    def test_sign_in_a_mock_admin
+      admin = Object.new
+      sign_in :admin, admin
+
+      assert_same admin, helper.current_admin
+    end
+
+    def test_sign_out_a_real_user
+      user = User.new
+      sign_in user
+      sign_out user
+
+      assert helper.current_user.nil?
+    end
+
+    def test_sign_out_a_mock_user
+      user = Object.new
+      sign_in :user, user
+      sign_out :user
+
+      assert helper.current_user.nil?
+    end
+
+    def test_sign_out_without_a_user
+      sign_out :user
+
+      assert helper.current_user.nil?
+    end
+
+    def test_backwards_compatibility
+      user = Object.new
+      ActiveSupport::Deprecation.silence do
+        sign_in user
+      end
+
+      assert_same user, helper.current_user
+    end
+  end
+end

data/spec/dummy/test/decorators/test_unit/helpers_test.rb

@@ -0,0 +1,21 @@
+require 'test_helper'
+
+class HelpersTest < Draper::TestCase
+  def test_access_helpers_through_helper
+    assert_equal "<p>Help!</p>", helper.content_tag(:p, "Help!")
+  end
+
+  def test_access_helpers_through_helpers
+    assert_equal "<p>Help!</p>", helpers.content_tag(:p, "Help!")
+  end
+
+  def test_access_helpers_through_h
+    assert_equal "<p>Help!</p>", h.content_tag(:p, "Help!")
+  end
+
+  def test_same_helper_object_as_decorators
+    decorator = Draper::Decorator.new(Object.new)
+
+    assert_same decorator.helpers, helpers
+  end
+end

data/spec/dummy/test/decorators/test_unit/view_context_test.rb

@@ -0,0 +1,24 @@
+require 'test_helper'
+
+def it_does_not_leak_view_context
+  2.times do |n|
+    define_method("test_has_independent_view_context_#{n}") do
+      refute_equal :leaked, Draper::ViewContext.current
+      Draper::ViewContext.current = :leaked
+    end
+  end
+end
+
+class DecoratorTest < Draper::TestCase
+  it_does_not_leak_view_context
+end
+
+class ControllerTest < ActionController::TestCase
+  tests Class.new(ActionController::Base)
+
+  it_does_not_leak_view_context
+end
+
+class MailerTest < ActionMailer::TestCase
+  it_does_not_leak_view_context
+end

data/spec/dummy/test/minitest_helper.rb

@@ -0,0 +1,4 @@
+ENV['RAILS_ENV'] ||= 'test'
+require File.expand_path('../../config/environment', __FILE__)
+require 'minitest/autorun'
+require 'minitest/rails'

data/spec/dummy/test/test_helper.rb

@@ -0,0 +1,3 @@
+ENV['RAILS_ENV'] ||= 'test'
+require File.expand_path('../../config/environment', __FILE__)
+require 'rails/test_help'

data/spec/generators/decorator/decorator_generator_spec.rb

@@ -1,4 +1,5 @@
 require 'spec_helper'
+require 'ammeter/init'
 
 # Generators are not automatically loaded by Rails
 require 'generators/decorator/decorator_generator'
@@ -15,8 +16,7 @@ describe Rails::Generators::DecoratorGenerator do
     describe 'app/decorators/your_model_decorator.rb' do
       subject { file('app/decorators/your_model_decorator.rb') }
       it { should exist }
-      it { should contain "class YourModelDecorator < Draper::Base" }
-      it { should contain "decorates :your_model" }
+      it { should contain "class YourModelDecorator < Draper::Decorator" }
     end
   end
 
@@ -31,15 +31,15 @@ describe Rails::Generators::DecoratorGenerator do
   end
 
   context 'parent decorator' do
-    describe 'decorator inhereted from Draper::Base' do
+    describe 'decorator inherited from Draper::Decorator' do
       before { run_generator ["YourModel"] }
 
       subject { file('app/decorators/your_model_decorator.rb') }
       it { should exist }
-      it { should contain "class YourModelDecorator < Draper::Base" }
+      it { should contain "class YourModelDecorator < Draper::Decorator" }
     end
 
-    describe "decorator inhereted from ApplicationDecorator if it's present" do
+    describe "decorator inherited from ApplicationDecorator if it's present" do
       before do
        class ApplicationDecorator; end
        run_generator ["YourModel"]
@@ -81,7 +81,7 @@ describe Rails::Generators::DecoratorGenerator do
     describe 'test/decorators/YourModel_decorator_test.rb' do
       subject { file('test/decorators/your_model_decorator_test.rb') }
       it { should exist }
-      it { should contain "class YourModelDecoratorTest < ActiveSupport::TestCase" }
+      it { should contain "class YourModelDecoratorTest < Draper::TestCase" }
     end
   end
 
@@ -91,7 +91,48 @@ describe Rails::Generators::DecoratorGenerator do
     describe 'test/decorators/your_model_decorator_test.rb' do
       subject { file('test/decorators/namespace/your_model_decorator_test.rb') }
       it { should exist }
-      it { should contain "class Namespace::YourModelDecoratorTest < ActiveSupport::TestCase" }
+      it { should contain "class Namespace::YourModelDecoratorTest < Draper::TestCase" }
     end
   end
+
+  context 'using minitest-rails' do
+    before { run_generator ["YourModel", "-t=mini_test"] }
+
+    describe 'test/decorators/your_model_decorator_test.rb' do
+      subject { file('test/decorators/your_model_decorator_test.rb') }
+      it { should exist }
+      it { should contain "class YourModelDecoratorTest < Draper::TestCase" }
+    end
+  end
+
+  context 'using minitest-rails with namespaced model' do
+    before { run_generator ["Namespace::YourModel", "-t=mini_test"] }
+
+    describe 'test/decorators/your_model_decorator_test.rb' do
+      subject { file('test/decorators/namespace/your_model_decorator_test.rb') }
+      it { should exist }
+      it { should contain "class Namespace::YourModelDecoratorTest < Draper::TestCase" }
+    end
+  end
+
+  context 'using minitest-rails with spec syntax' do
+    before { run_generator ["YourModel", "-t=mini_test", "--spec"] }
+
+    describe 'test/decorators/your_model_decorator_test.rb' do
+      subject { file('test/decorators/your_model_decorator_test.rb') }
+      it { should exist }
+      it { should contain "describe YourModelDecorator" }
+    end
+  end
+
+  context 'using minitest-rails with spec syntax with namespaced model' do
+    before { run_generator ["Namespace::YourModel", "-t=mini_test", "--spec"] }
+
+    describe 'test/decorators/your_model_decorator_test.rb' do
+      subject { file('test/decorators/namespace/your_model_decorator_test.rb') }
+      it { should exist }
+      it { should contain "describe Namespace::YourModelDecorator" }
+    end
+  end
+
 end

data/spec/integration/integration_spec.rb

@@ -0,0 +1,58 @@
+require 'spec_helper'
+require 'support/dummy_app'
+require 'support/matchers/have_text'
+
+app = DummyApp.new(ENV["RAILS_ENV"])
+spec_types = {
+  view: ["/posts/1", "PostsController"],
+  mailer: ["/posts/1/mail", "PostMailer"]
+}
+
+app.start_server do
+  spec_types.each do |type, (path, controller)|
+    page = app.get(path)
+
+    describe "in a #{type}" do
+      it "runs in the correct environment" do
+        expect(page).to have_text(app.environment).in("#environment")
+      end
+
+      it "uses the correct view context controller" do
+        expect(page).to have_text(controller).in("#controller")
+      end
+
+      it "can use built-in helpers" do
+        expect(page).to have_text("Once upon a...").in("#truncated")
+      end
+
+      it "can use built-in private helpers" do
+        # Nokogiri unescapes text!
+        expect(page).to have_text("<script>danger</script>").in("#html_escaped")
+      end
+
+      it "can use user-defined helpers from app/helpers" do
+        expect(page).to have_text("Hello, world!").in("#hello_world")
+      end
+
+      it "can use user-defined helpers from the controller" do
+        expect(page).to have_text("Goodnight, moon!").in("#goodnight_moon")
+      end
+
+      it "can use path helpers with a model" do
+        expect(page).to have_text("/en/posts/1").in("#path_with_model")
+      end
+
+      it "can use path helpers with an id" do
+        expect(page).to have_text("/en/posts/1").in("#path_with_id")
+      end
+
+      it "can use url helpers with a model" do
+        expect(page).to have_text("http://www.example.com:12345/en/posts/1").in("#url_with_model")
+      end
+
+      it "can use url helpers with an id" do
+        expect(page).to have_text("http://www.example.com:12345/en/posts/1").in("#url_with_id")
+      end
+    end
+  end
+end