dor-services 6.0.0 → 6.0.1

data/lib/dor/services/thumbnail_service.rb

@@ -1,27 +1,29 @@
+# frozen_string_literal: true
+
 module Dor
   # Responsible for finding a path to a thumbnail based on the contentMetadata of an object
   class ThumbnailService
     # allow the mimetype attribute to be lower or camelcase when searching to make it more robust
-    MIME_TYPE_FINDER = "@mimetype='image/jp2' or @mimeType='image/jp2'".freeze
+    MIME_TYPE_FINDER = "@mimetype='image/jp2' or @mimeType='image/jp2'"
 
     # these are the finders we will use to search for a thumb resource in contentMetadata, they will be searched in the order provided, stopping when one is reached
     THUMB_XPATH_FINDERS = [
       # first find a file of mimetype jp2 explicitly marked as a thumb in the resource type and with a thumb=yes attribute
-      { image_type: 'local', finder: "/contentMetadata/resource[@type='thumb' and @thumb='yes']/file[#{MIME_TYPE_FINDER}]"},
+      { image_type: 'local', finder: "/contentMetadata/resource[@type='thumb' and @thumb='yes']/file[#{MIME_TYPE_FINDER}]" },
       # same thing for external files
-      { image_type: 'external', finder: "/contentMetadata/resource[@type='thumb' and @thumb='yes']/externalFile[#{MIME_TYPE_FINDER}]"},
+      { image_type: 'external', finder: "/contentMetadata/resource[@type='thumb' and @thumb='yes']/externalFile[#{MIME_TYPE_FINDER}]" },
       # next find any image or page resource types with the thumb=yes attribute of mimetype jp2
-      { image_type: 'local', finder: "/contentMetadata/resource[(@type='page' or @type='image') and @thumb='yes']/file[#{MIME_TYPE_FINDER}]"},
+      { image_type: 'local', finder: "/contentMetadata/resource[(@type='page' or @type='image') and @thumb='yes']/file[#{MIME_TYPE_FINDER}]" },
       # same thing for external file
-      { image_type: 'external', finder: "/contentMetadata/resource[(@type='page' or @type='image') and @thumb='yes']/externalFile[#{MIME_TYPE_FINDER}]"},
+      { image_type: 'external', finder: "/contentMetadata/resource[(@type='page' or @type='image') and @thumb='yes']/externalFile[#{MIME_TYPE_FINDER}]" },
       # next find a file of mimetype jp2 and resource type=thumb but not marked with the thumb directive
-      { image_type: 'local', finder: "/contentMetadata/resource[@type='thumb']/file[#{MIME_TYPE_FINDER}]"},
+      { image_type: 'local', finder: "/contentMetadata/resource[@type='thumb']/file[#{MIME_TYPE_FINDER}]" },
       # same thing for external file
-      { image_type: 'external', finder: "/contentMetadata/resource[@type='thumb']/externalFile[#{MIME_TYPE_FINDER}]"},
+      { image_type: 'external', finder: "/contentMetadata/resource[@type='thumb']/externalFile[#{MIME_TYPE_FINDER}]" },
       # finally find the first page or image resource of mimetype jp2
-      { image_type: 'local', finder: "/contentMetadata/resource[@type='page' or @type='image']/file[#{MIME_TYPE_FINDER}]"},
+      { image_type: 'local', finder: "/contentMetadata/resource[@type='page' or @type='image']/file[#{MIME_TYPE_FINDER}]" },
       # same thing for external file
-      { image_type: 'external', finder: "/contentMetadata/resource[@type='page' or @type='image']/externalFile[#{MIME_TYPE_FINDER}]"}
+      { image_type: 'external', finder: "/contentMetadata/resource[@type='page' or @type='image']/externalFile[#{MIME_TYPE_FINDER}]" }
     ].freeze
 
     # @params [Dor::Item] object
@@ -34,19 +36,21 @@ module Dor
     # @return [String] the computed thumb filename, with the druid prefix and a slash in front of it, e.g. oo000oo0001/filenamewith space.jp2
     def thumb
       return unless object.respond_to?(:contentMetadata) && object.contentMetadata.present?
+
       cm = object.contentMetadata.ng_xml
       thumb_image = nil
 
       THUMB_XPATH_FINDERS.each do |search_path|
         thumb_files = cm.xpath(search_path[:finder]) # look for a thumb
         next if thumb_files.empty?
+
         # if we find one, return the filename based on whether it is a local file or external file
         thumb_image = if search_path[:image_type] == 'local'
                         "#{object.remove_druid_prefix}/#{thumb_files[0]['id']}"
                       else
                         "#{object.remove_druid_prefix(thumb_files[0]['objectId'])}/#{thumb_files[0]['fileId']}"
                       end
-        break  # break out of the loop so we stop searching
+        break # break out of the loop so we stop searching
       end
 
       thumb_image

data/lib/dor/utils/hydrus_shims.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Hydrus
   # These shims allow DOR to interact seamlessly with Hydrus' custom models
   class Item < Dor::Item

data/lib/dor/utils/ng_tidy.rb

@@ -1,5 +1,6 @@
-class Nokogiri::XML::Text
+# frozen_string_literal: true
 
+class Nokogiri::XML::Text
   def normalize
     content =~ /\S/ ? content.gsub(/\s+/, ' ').strip : content
   end
@@ -7,19 +8,15 @@ class Nokogiri::XML::Text
   def normalize!
     self.content = normalize
   end
-
 end
 
 class Nokogiri::XML::Node
-
   def normalize_text!
     xpath('//text()').each { |t| t.normalize! }
   end
-
 end
 
 class Nokogiri::XML::Document
-
   PRETTIFY_XSLT = Nokogiri::XSLT <<-EOC
     <xsl:stylesheet version="1.0" xmlns:xsl="http://www.w3.org/1999/XSL/Transform">
       <xsl:output omit-xml-declaration="yes" indent="yes"/>
@@ -29,10 +26,9 @@ class Nokogiri::XML::Document
         </xsl:copy>
       </xsl:template>
     </xsl:stylesheet>
-    EOC
+  EOC
 
   def prettify
     PRETTIFY_XSLT.transform(self).to_xml
   end
-
 end

data/lib/dor/utils/predicate_patch.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Monkey patch ActiveFedora::RelsExtDatastream.short_predicate to
 # create missing mappings on the fly.
 

data/lib/dor/utils/sdr_client.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'moab'
 module Sdr
   class Client
@@ -10,6 +12,7 @@ module Sdr
         begin
           doc = Nokogiri::XML xml
           raise if doc.root.name != 'currentVersion'
+
           return Integer(doc.text)
         rescue
           raise "Unable to parse XML from SDR current_version API call: #{xml}"

data/lib/dor/utils/solr_doc_helper.rb

@@ -1,8 +1,10 @@
+# frozen_string_literal: true
+
 module SolrDocHelper
   def add_solr_value(solr_doc, field_name, value, field_type = :default, index_types = [:searchable])
     case field_type
-      when :symbol
-        index_types << field_type
+    when :symbol
+      index_types << field_type
     end
     ::Solrizer.insert_field(solr_doc, field_name, value, *index_types)
   end

data/lib/dor/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Dor
-  VERSION = '6.0.0'.freeze
+  VERSION = '6.0.1'
 end

data/lib/dor/workflow/document.rb

@@ -1,130 +1,135 @@
+# frozen_string_literal: true
+
 module Dor
-module Workflow
-  class Document
-    include SolrDocHelper
-    include ::OM::XML::Document
-
-    set_terminology do |t|
-      t.root(:path => 'workflow')
-      t.repository(:path => {:attribute => 'repository'})
-      t.workflowId(:path => {:attribute => 'id'})
-      t.process do
-        t.name_(:path => {:attribute => 'name'})
-        t.status(:path => {:attribute => 'status'})
-        t.timestamp(:path => {:attribute => 'datetime'}) # , :data_type => :date)
-        t.elapsed(:path => {:attribute => 'elapsed'})
-        t.lifecycle(:path => {:attribute => 'lifecycle'})
-        t.attempts(:path => {:attribute => 'attempts'}, :index_as => [:not_searchable])
-        t.version(:path => {:attribute => 'version'})
+  module Workflow
+    class Document
+      include SolrDocHelper
+      include ::OM::XML::Document
+
+      set_terminology do |t|
+        t.root(:path => 'workflow')
+        t.repository(:path => { :attribute => 'repository' })
+        t.workflowId(:path => { :attribute => 'id' })
+        t.process do
+          t.name_(:path => { :attribute => 'name' })
+          t.status(:path => { :attribute => 'status' })
+          t.timestamp(:path => { :attribute => 'datetime' }) # , :data_type => :date)
+          t.elapsed(:path => { :attribute => 'elapsed' })
+          t.lifecycle(:path => { :attribute => 'lifecycle' })
+          t.attempts(:path => { :attribute => 'attempts' }, :index_as => [:not_searchable])
+          t.version(:path => { :attribute => 'version' })
+        end
       end
-    end
 
-    @@definitions = {}
+      @@definitions = {}
 
-    def initialize(node)
-      self.ng_xml = Nokogiri::XML(node)
-    end
+      def initialize(node)
+        self.ng_xml = Nokogiri::XML(node)
+      end
 
-    # is this an incomplete workflow with steps that have a priority > 0
-    def expedited?
-      processes.any? { |proc| !proc.completed? && proc.priority.to_i > 0 }
-    end
+      # is this an incomplete workflow with steps that have a priority > 0
+      def expedited?
+        processes.any? { |proc| !proc.completed? && proc.priority.to_i > 0 }
+      end
 
-    # @return [Integer] value of the first > 0 priority.  Defaults to 0
-    def priority
-      processes.map {|proc| proc.priority.to_i }.detect(0) {|p| p > 0}
-    end
+      # @return [Integer] value of the first > 0 priority.  Defaults to 0
+      def priority
+        processes.map { |proc| proc.priority.to_i }.detect(0) { |p| p > 0 }
+      end
 
-    # @return [Boolean] if any process node does not have version, returns true, false otherwise (all processes have version)
-    def active?
-      ng_xml.at_xpath('/workflow/process[not(@version)]') ? true : false
-    end
+      # @return [Boolean] if any process node does not have version, returns true, false otherwise (all processes have version)
+      def active?
+        ng_xml.at_xpath('/workflow/process[not(@version)]') ? true : false
+      end
 
-    # @return [Dor::WorkflowDefinitionDs]
-    def definition
-      @definition ||= begin
-        if @@definitions.key? workflowId.first
-          @@definitions[workflowId.first]
-        else
-          wfo = Dor::WorkflowObject.find_by_name(workflowId.first)
-          wf_def = wfo ? wfo.definition : nil
-          @@definitions[workflowId.first] = wf_def
-          wf_def
+      # @return [Dor::WorkflowDefinitionDs]
+      def definition
+        @definition ||= begin
+          if @@definitions.key? workflowId.first
+            @@definitions[workflowId.first]
+          else
+            wfo = Dor::WorkflowObject.find_by_name(workflowId.first)
+            wf_def = wfo ? wfo.definition : nil
+            @@definitions[workflowId.first] = wf_def
+            wf_def
+          end
         end
       end
-    end
 
-    def [](value)
-      processes.find { |p| p.name == value }
-    end
+      def [](value)
+        processes.find { |p| p.name == value }
+      end
 
-    def processes
-      # if the workflow service didnt return any processes, dont return any processes from the reified wf
-      return [] if ng_xml.search('/workflow/process').length == 0
-      @processes ||=
-      if definition
-        definition.processes.collect do |process|
-          node = ng_xml.at("/workflow/process[@name = '#{process.name}']")
-          process.update!(node, self)
-        end
-      else
-        find_by_terms(:workflow, :process).collect do |x|
-          pnode = Dor::Workflow::Process.new(repository, workflowId, {})
-          pnode.update!(x, self)
-        end.sort_by(&:datetime)
+      def processes
+        # if the workflow service didnt return any processes, dont return any processes from the reified wf
+        return [] if ng_xml.search('/workflow/process').length == 0
+
+        @processes ||=
+          if definition
+            definition.processes.collect do |process|
+              node = ng_xml.at("/workflow/process[@name = '#{process.name}']")
+              process.update!(node, self)
+            end
+          else
+            find_by_terms(:workflow, :process).collect do |x|
+              pnode = Dor::Workflow::Process.new(repository, workflowId, {})
+              pnode.update!(x, self)
+            end.sort_by(&:datetime)
+          end
       end
-    end
 
-    def workflow_should_show_completed?(processes)
-      processes.all? {|p| ['skipped', 'completed', '', nil].include?(p.status)}
-    end
+      def workflow_should_show_completed?(processes)
+        processes.all? { |p| ['skipped', 'completed', '', nil].include?(p.status) }
+      end
+
+      def to_solr(solr_doc = {}, *args)
+        wf_name = workflowId.first
+        repo = repository.first
+        wf_solr_type = :string
+        wf_solr_attrs = [:symbol]
+        add_solr_value(solr_doc, 'wf',     wf_name, wf_solr_type, wf_solr_attrs)
+        add_solr_value(solr_doc, 'wf_wps', wf_name, wf_solr_type, wf_solr_attrs)
+        add_solr_value(solr_doc, 'wf_wsp', wf_name, wf_solr_type, wf_solr_attrs)
+        status = processes.empty? ? 'empty' : (workflow_should_show_completed?(processes) ? 'completed' : 'active')
+        errors = processes.count(&:error?)
+        add_solr_value(solr_doc, 'workflow_status', [wf_name, status, errors, repo].join('|'), wf_solr_type, wf_solr_attrs)
 
-    def to_solr(solr_doc = {}, *args)
-      wf_name = workflowId.first
-      repo = repository.first
-      wf_solr_type = :string
-      wf_solr_attrs = [:symbol]
-      add_solr_value(solr_doc, 'wf',     wf_name, wf_solr_type, wf_solr_attrs)
-      add_solr_value(solr_doc, 'wf_wps', wf_name, wf_solr_type, wf_solr_attrs)
-      add_solr_value(solr_doc, 'wf_wsp', wf_name, wf_solr_type, wf_solr_attrs)
-      status = processes.empty? ? 'empty' : (workflow_should_show_completed?(processes) ? 'completed' : 'active')
-      errors = processes.count(&:error?)
-      add_solr_value(solr_doc, 'workflow_status', [wf_name, status, errors, repo].join('|'), wf_solr_type, wf_solr_attrs)
-
-      processes.each do |process|
-        next unless process.status.present?
-        # add a record of the robot having operated on this item, so we can track robot activity
-        if !process.date_time.blank? && process.status && (process.status == 'completed' || process.status == 'error')
-          solr_doc["wf_#{wf_name}_#{process.name}_dttsi"] = Time.parse(process.date_time).utc.iso8601
+        processes.each do |process|
+          next unless process.status.present?
+
+          # add a record of the robot having operated on this item, so we can track robot activity
+          if !process.date_time.blank? && process.status && (process.status == 'completed' || process.status == 'error')
+            solr_doc["wf_#{wf_name}_#{process.name}_dttsi"] = Time.parse(process.date_time).utc.iso8601
+          end
+          # index the error message without the druid so we hopefully get some overlap
+          add_solr_value(solr_doc, 'wf_error', "#{wf_name}:#{process.name}:#{process.error_message}", wf_solr_type, wf_solr_attrs) if process.error_message
+          add_solr_value(solr_doc, 'wf_wsp', "#{wf_name}:#{process.status}", wf_solr_type, wf_solr_attrs)
+          add_solr_value(solr_doc, 'wf_wsp', "#{wf_name}:#{process.status}:#{process.name}", wf_solr_type, wf_solr_attrs)
+          add_solr_value(solr_doc, 'wf_wps', "#{wf_name}:#{process.name}", wf_solr_type, wf_solr_attrs)
+          add_solr_value(solr_doc, 'wf_wps', "#{wf_name}:#{process.name}:#{process.status}", wf_solr_type, wf_solr_attrs)
+          add_solr_value(solr_doc, 'wf_swp', "#{process.status}", wf_solr_type, wf_solr_attrs)
+          add_solr_value(solr_doc, 'wf_swp', "#{process.status}:#{wf_name}", wf_solr_type, wf_solr_attrs)
+          add_solr_value(solr_doc, 'wf_swp', "#{process.status}:#{wf_name}:#{process.name}", wf_solr_type, wf_solr_attrs)
+          next unless process.state != process.status
+
+          add_solr_value(solr_doc, 'wf_wsp', "#{wf_name}:#{process.state}:#{process.name}", wf_solr_type, wf_solr_attrs)
+          add_solr_value(solr_doc, 'wf_wps', "#{wf_name}:#{process.name}:#{process.state}", wf_solr_type, wf_solr_attrs)
+          add_solr_value(solr_doc, 'wf_swp', "#{process.state}", wf_solr_type, wf_solr_attrs)
+          add_solr_value(solr_doc, 'wf_swp', "#{process.state}:#{wf_name}", wf_solr_type, wf_solr_attrs)
+          add_solr_value(solr_doc, 'wf_swp', "#{process.state}:#{wf_name}:#{process.name}", wf_solr_type, wf_solr_attrs)
         end
-        # index the error message without the druid so we hopefully get some overlap
-        add_solr_value(solr_doc, 'wf_error', "#{wf_name}:#{process.name}:#{process.error_message}", wf_solr_type, wf_solr_attrs) if process.error_message
-        add_solr_value(solr_doc, 'wf_wsp', "#{wf_name}:#{process.status}", wf_solr_type, wf_solr_attrs)
-        add_solr_value(solr_doc, 'wf_wsp', "#{wf_name}:#{process.status}:#{process.name}", wf_solr_type, wf_solr_attrs)
-        add_solr_value(solr_doc, 'wf_wps', "#{wf_name}:#{process.name}", wf_solr_type, wf_solr_attrs)
-        add_solr_value(solr_doc, 'wf_wps', "#{wf_name}:#{process.name}:#{process.status}", wf_solr_type, wf_solr_attrs)
-        add_solr_value(solr_doc, 'wf_swp', "#{process.status}", wf_solr_type, wf_solr_attrs)
-        add_solr_value(solr_doc, 'wf_swp', "#{process.status}:#{wf_name}", wf_solr_type, wf_solr_attrs)
-        add_solr_value(solr_doc, 'wf_swp', "#{process.status}:#{wf_name}:#{process.name}", wf_solr_type, wf_solr_attrs)
-        next unless process.state != process.status
-        add_solr_value(solr_doc, 'wf_wsp', "#{wf_name}:#{process.state}:#{process.name}", wf_solr_type, wf_solr_attrs)
-        add_solr_value(solr_doc, 'wf_wps', "#{wf_name}:#{process.name}:#{process.state}", wf_solr_type, wf_solr_attrs)
-        add_solr_value(solr_doc, 'wf_swp', "#{process.state}", wf_solr_type, wf_solr_attrs)
-        add_solr_value(solr_doc, 'wf_swp', "#{process.state}:#{wf_name}", wf_solr_type, wf_solr_attrs)
-        add_solr_value(solr_doc, 'wf_swp', "#{process.state}:#{wf_name}:#{process.name}", wf_solr_type, wf_solr_attrs)
-      end
 
-      solr_doc[Solrizer.solr_name('wf_wps', :symbol)].uniq! if solr_doc[Solrizer.solr_name('wf_wps', :symbol)]
-      solr_doc[Solrizer.solr_name('wf_wsp', :symbol)].uniq! if solr_doc[Solrizer.solr_name('wf_wsp', :symbol)]
-      solr_doc[Solrizer.solr_name('wf_swp', :symbol)].uniq! if solr_doc[Solrizer.solr_name('wf_swp', :symbol)]
-      solr_doc['workflow_status'].uniq! if solr_doc['workflow_status']
+        solr_doc[Solrizer.solr_name('wf_wps', :symbol)]&.uniq!
+        solr_doc[Solrizer.solr_name('wf_wsp', :symbol)]&.uniq!
+        solr_doc[Solrizer.solr_name('wf_swp', :symbol)]&.uniq!
+        solr_doc['workflow_status']&.uniq!
 
-      solr_doc
-    end
+        solr_doc
+      end
 
-    def inspect
-      "#<#{self.class.name}:#{object_id}>"
+      def inspect
+        "#<#{self.class.name}:#{object_id}>"
+      end
     end
   end
 end
-end

data/lib/dor/workflow/process.rb

@@ -1,108 +1,111 @@
+# frozen_string_literal: true
+
 module Dor
-module Workflow
-  class Process
-    attr_reader :owner, :repo, :workflow
+  module Workflow
+    class Process
+      attr_reader :owner, :repo, :workflow
 
-    # @param repo [String] the name of the repository, typically 'dor'
-    # @param workflow [String] the name of the workflow, e.g. 'assemblyWF'
-    # @param attrs [Nokogiri::XML::Node, Hash]
-    def initialize(repo, workflow, attrs)
-      @workflow = workflow
-      @repo = repo
-      if attrs.is_a? Nokogiri::XML::Node
-        init_from_node(attrs)
-      else
-        @attrs = attrs
+      # @param repo [String] the name of the repository, typically 'dor'
+      # @param workflow [String] the name of the workflow, e.g. 'assemblyWF'
+      # @param attrs [Nokogiri::XML::Node, Hash]
+      def initialize(repo, workflow, attrs)
+        @workflow = workflow
+        @repo = repo
+        if attrs.is_a? Nokogiri::XML::Node
+          init_from_node(attrs)
+        else
+          @attrs = attrs
+        end
       end
-    end
 
-    def init_from_node(node)
-      @attrs = {
-        'name'         => node['name'],
-        'sequence'     => node['sequence'] ? node['sequence'].to_i : nil,
-        'status'       => node['status'],    # TODO: see how this affects argo
-        'lifecycle'    => node['lifecycle'],
-        'label'        => node.at_xpath('label/text()').to_s,
-        'batch_limit'  => node['batch-limit'] ? node['batch-limit'].to_i : nil,
-        'error_limit'  => node['error-limit'] ? node['error-limit'].to_i : nil,
-        'priority'     => node['priority'] ? node['priority'].to_i : 0,
-        'prerequisite' => node.xpath('prereq').collect { |p|
-          repo = (p['repository'].nil? || p['repository'] == @repo    ) ? nil : p['repository']
-          wf   = (p['workflow'].nil? || p['workflow'] == @workflow) ? nil : p['workflow']
-          [repo, wf, p.text.to_s].compact.join(':')
+      def init_from_node(node)
+        @attrs = {
+          'name' => node['name'],
+          'sequence' => node['sequence'] ? node['sequence'].to_i : nil,
+          'status' => node['status'], # TODO: see how this affects argo
+          'lifecycle' => node['lifecycle'],
+          'label' => node.at_xpath('label/text()').to_s,
+          'batch_limit' => node['batch-limit'] ? node['batch-limit'].to_i : nil,
+          'error_limit' => node['error-limit'] ? node['error-limit'].to_i : nil,
+          'priority' => node['priority'] ? node['priority'].to_i : 0,
+          'prerequisite' => node.xpath('prereq').collect { |p|
+            repo = (p['repository'].nil? || p['repository'] == @repo) ? nil : p['repository']
+            wf   = (p['workflow'].nil? || p['workflow'] == @workflow) ? nil : p['workflow']
+            [repo, wf, p.text.to_s].compact.join(':')
+          }
         }
-      }
-    end
+      end
 
-    def name          ; @attrs['name']         ; end
-    def sequence      ; @attrs['sequence']     ; end
-    def lifecycle     ; @attrs['lifecycle']    ; end
-    def label         ; @attrs['label']        ; end
-    def batch_limit   ; @attrs['batch_limit']  ; end
-    def error_limit   ; @attrs['error_limit']  ; end
-    def error_message ; @attrs['errorMessage'] ; end
-    def prerequisite  ; @attrs['prerequisite'] ; end
-    def status        ; @attrs['status']       ; end
-    def note          ; @attrs['note']         ; end
-    def version       ; @attrs['version']      ; end
-    def priority      ; @attrs['priority']     ; end
-    def completed?    ; status == 'completed'  ; end
-    def error?        ; status == 'error'      ; end
-    def waiting?      ; status == 'waiting'    ; end
-    def date_time     ; @attrs['datetime']     ; end
+      def name; @attrs['name']; end
+      def sequence; @attrs['sequence']; end
+      def lifecycle; @attrs['lifecycle']; end
+      def label; @attrs['label']; end
+      def batch_limit; @attrs['batch_limit']; end
+      def error_limit; @attrs['error_limit']; end
+      def error_message; @attrs['errorMessage']; end
+      def prerequisite; @attrs['prerequisite']; end
+      def status; @attrs['status']; end
+      def note; @attrs['note']; end
+      def version; @attrs['version']; end
+      def priority; @attrs['priority']; end
+      def completed?; status == 'completed'; end
+      def error?; status == 'error'; end
+      def waiting?; status == 'waiting'; end
+      def date_time; @attrs['datetime']; end
 
-    def archived?
-      @attrs['archived'] =~ /true$/i
-    end
+      def archived?
+        @attrs['archived'] =~ /true$/i
+      end
 
-    def ready?
-      self.waiting? && !prerequisite.nil? && prerequisite.all? { |pr| (prq = owner[pr]) && prq.completed? }
-    end
+      def ready?
+        self.waiting? && !prerequisite.nil? && prerequisite.all? { |pr| (prq = owner[pr]) && prq.completed? }
+      end
 
-    def blocked?
-      self.waiting? && !prerequisite.nil? && prerequisite.any? { |pr| (prq = owner[pr]) && (prq.error? || prq.blocked?) }
-    end
+      def blocked?
+        self.waiting? && !prerequisite.nil? && prerequisite.any? { |pr| (prq = owner[pr]) && (prq.error? || prq.blocked?) }
+      end
 
-    def state
-      if blocked?
-        'blocked'
-      elsif ready?
-        'ready'
-      else
-        status
+      def state
+        if blocked?
+          'blocked'
+        elsif ready?
+          'ready'
+        else
+          status
+        end
       end
-    end
 
-    def attempts
-      @attrs['attempts'].to_i
-    end
+      def attempts
+        @attrs['attempts'].to_i
+      end
 
-    def datetime
-      @attrs['datetime'] ? Time.parse(@attrs['datetime']) : nil
-    end
+      def datetime
+        @attrs['datetime'] ? Time.parse(@attrs['datetime']) : nil
+      end
 
-    def elapsed
-      @attrs['elapsed'].nil? ? nil : @attrs['elapsed'].to_f
-    end
+      def elapsed
+        @attrs['elapsed'].nil? ? nil : @attrs['elapsed'].to_f
+      end
+
+      # Updates this object with the attributes passed in.
+      # @param info [Hash,Nokogiri::XML::Element,NilClass]
+      # @param new_owner [Dor::Workflow::Document]
+      def update!(info, new_owner)
+        raise ArgumentError, 'Owner can not be nil. It must be an instance of Dor::Workflow::Document' unless new_owner
 
-    # Updates this object with the attributes passed in.
-    # @param info [Hash,Nokogiri::XML::Element,NilClass]
-    # @param new_owner [Dor::Workflow::Document]
-    def update!(info, new_owner)
-      raise ArgumentError, 'Owner can not be nil. It must be an instance of Dor::Workflow::Document' unless new_owner
-      @owner = new_owner
-      return self if info.nil?
+        @owner = new_owner
+        return self if info.nil?
 
-      if info.is_a? Nokogiri::XML::Node
-        info = Hash[info.attributes.collect { |k, v| [k, v.value] }]
+        if info.is_a? Nokogiri::XML::Node
+          info = Hash[info.attributes.collect { |k, v| [k, v.value] }]
+        end
+        @attrs.merge! info
+        self
       end
-      @attrs.merge! info
-      self
-    end
 
-    def to_hash
-      @attrs.reject { |k, v| v.nil? || v == 0 || (v.respond_to?(:empty?) && v.empty?) }
+      def to_hash
+        @attrs.reject { |k, v| v.nil? || v == 0 || (v.respond_to?(:empty?) && v.empty?) }
+      end
     end
   end
 end
-end