doorkeeper 5.4.0.rc1 → 5.5.0

data/spec/support/helpers/config_helper.rb

@@ -1,11 +0,0 @@
-# frozen_string_literal: true
-
-module ConfigHelper
-  def config_is_set(setting, value = nil, &block)
-    setting_ivar = "@#{setting}"
-    value = block_given? ? block : value
-    Doorkeeper.config.instance_variable_set(setting_ivar, value)
-  end
-end
-
-RSpec.configuration.send :include, ConfigHelper

data/spec/support/helpers/model_helper.rb

@@ -1,78 +0,0 @@
-# frozen_string_literal: true
-
-module ModelHelper
-  def client_exists(client_attributes = {})
-    @client = FactoryBot.create(:application, client_attributes)
-  end
-
-  def create_resource_owner
-    @resource_owner = User.create!(name: "Joe", password: "sekret")
-  end
-
-  def authorization_code_exists(options = {})
-    @authorization = FactoryBot.create(:access_grant, options)
-  end
-
-  def access_token_exists(options = {})
-    @access_token = FactoryBot.create(:access_token, options)
-  end
-
-  def access_grant_should_exist_for(client, resource_owner)
-    grant = Doorkeeper::AccessGrant.first
-
-    expect(grant.application).to have_attributes(id: client.id)
-      .and(be_instance_of(Doorkeeper::Application))
-
-    expect(grant.resource_owner_id).to eq(resource_owner.id)
-  end
-
-  def access_token_should_exist_for(client, resource_owner)
-    token = Doorkeeper::AccessToken.first
-
-    expect(token.application).to have_attributes(id: client.id)
-      .and(be_instance_of(Doorkeeper::Application))
-
-    expect(token.resource_owner_id).to eq(resource_owner.id)
-  end
-
-  def access_grant_should_not_exist
-    expect(Doorkeeper::AccessGrant.all).to be_empty
-  end
-
-  def access_token_should_not_exist
-    expect(Doorkeeper::AccessToken.all).to be_empty
-  end
-
-  def access_grant_should_have_scopes(*args)
-    grant = Doorkeeper::AccessGrant.first
-    expect(grant.scopes).to eq(Doorkeeper::OAuth::Scopes.from_array(args))
-  end
-
-  def access_token_should_have_scopes(*args)
-    grant = Doorkeeper::AccessToken.last
-    expect(grant.scopes).to eq(Doorkeeper::OAuth::Scopes.from_array(args))
-  end
-
-  def uniqueness_error
-    case DOORKEEPER_ORM
-    when :active_record
-      ActiveRecord::RecordNotUnique
-    when :sequel
-      error_classes = [Sequel::UniqueConstraintViolation, Sequel::ValidationFailed]
-      proc { |error| expect(error.class).to be_in(error_classes) }
-    when :mongo_mapper
-      error_classes = [MongoMapper::DocumentNotValid, Mongo::OperationFailure]
-      proc { |error| expect(error.class).to be_in(error_classes) }
-    when /mongoid/
-      error_classes = [Mongoid::Errors::Validations]
-      error_classes << Moped::Errors::OperationFailure if defined?(::Moped) # Mongoid 4
-      error_classes << Mongo::Error::OperationFailure if defined?(::Mongo) # Mongoid 5
-
-      proc { |error| expect(error.class).to be_in(error_classes) }
-    else
-      raise "'#{DOORKEEPER_ORM}' ORM is not supported!"
-    end
-  end
-end
-
-RSpec.configuration.send :include, ModelHelper

data/spec/support/helpers/request_spec_helper.rb

@@ -1,110 +0,0 @@
-# frozen_string_literal: true
-
-module RequestSpecHelper
-  def i_am_logged_in
-    allow(Doorkeeper.configuration).to receive(:authenticate_admin).and_return(->(*) {})
-  end
-
-  def i_should_see(content)
-    expect(page).to have_content(content)
-  end
-
-  def i_should_not_see(content)
-    expect(page).to have_no_content(content)
-  end
-
-  def i_should_be_on(path)
-    expect(current_path).to eq(path)
-  end
-
-  def url_should_have_param(param, value)
-    expect(current_params[param]).to eq(value)
-  end
-
-  def url_should_not_have_param(param)
-    expect(current_params).not_to have_key(param)
-  end
-
-  def current_params
-    Rack::Utils.parse_query(current_uri.query)
-  end
-
-  def current_uri
-    URI.parse(page.current_url)
-  end
-
-  def request_response
-    respond_to?(:response) ? response : page.driver.response
-  end
-
-  def json_response
-    JSON.parse(request_response.body)
-  end
-
-  def should_have_header(header, value)
-    expect(headers[header]).to eq(value)
-  end
-
-  def should_have_status(status)
-    expect(page.driver.response.status).to eq(status)
-  end
-
-  def with_access_token_header(token)
-    with_header "Authorization", "Bearer #{token}"
-  end
-
-  def with_header(header, value)
-    page.driver.header(header, value)
-  end
-
-  def basic_auth_header_for_client(client)
-    ActionController::HttpAuthentication::Basic.encode_credentials client.uid, client.secret
-  end
-
-  def should_have_json(key, value)
-    expect(json_response.fetch(key)).to eq(value)
-  end
-
-  def should_have_json_within(key, value, range)
-    expect(json_response.fetch(key)).to be_within(range).of(value)
-  end
-
-  def should_not_have_json(key)
-    expect(json_response).not_to have_key(key)
-  end
-
-  def sign_in
-    visit "/"
-    click_on "Sign in"
-  end
-
-  def create_access_token(authorization_code, client, code_verifier = nil)
-    page.driver.post token_endpoint_url(code: authorization_code, client: client, code_verifier: code_verifier)
-  end
-
-  def i_should_see_translated_error_message(key)
-    i_should_see translated_error_message(key)
-  end
-
-  def i_should_not_see_translated_error_message(key)
-    i_should_not_see translated_error_message(key)
-  end
-
-  def translated_error_message(key)
-    I18n.translate(key, scope: %i[doorkeeper errors messages])
-  end
-
-  def i_should_see_translated_invalid_request_error_message(key, value)
-    i_should_see translated_invalid_request_error_message(key, value)
-  end
-
-  def translated_invalid_request_error_message(key, value)
-    I18n.translate key, scope: %i[doorkeeper errors messages invalid_request], value: value
-  end
-
-  def response_status_should_be(status)
-    expect(request_response.status.to_i).to eq(status)
-  end
-end
-
-RSpec.configuration.send :include, RequestSpecHelper

data/spec/support/helpers/url_helper.rb

@@ -1,62 +0,0 @@
-# frozen_string_literal: true
-
-module UrlHelper
-  def token_endpoint_url(options = {})
-    parameters = {
-      code: options[:code],
-      client_id: options[:client_id] || options[:client].try(:uid),
-      client_secret: options[:client_secret] || options[:client].try(:secret),
-      redirect_uri: options[:redirect_uri] || options[:client].try(:redirect_uri),
-      grant_type: options[:grant_type] || "authorization_code",
-      code_verifier: options[:code_verifier],
-      code_challenge_method: options[:code_challenge_method],
-    }.reject { |_, v| v.blank? }
-    "/oauth/token?#{build_query(parameters)}"
-  end
-
-  def password_token_endpoint_url(options = {})
-    parameters = {
-      code: options[:code],
-      client_id: options[:client_id] || options[:client].try(:uid),
-      client_secret: options[:client_secret] || options[:client].try(:secret),
-      username: options[:resource_owner_username] || options[:resource_owner].try(:name),
-      password: options[:resource_owner_password] || options[:resource_owner].try(:password),
-      scope: options[:scope],
-      grant_type: "password",
-    }
-    "/oauth/token?#{build_query(parameters)}"
-  end
-
-  def authorization_endpoint_url(options = {})
-    parameters = {
-      client_id: options[:client_id] || options[:client].try(:uid),
-      redirect_uri: options[:redirect_uri] || options[:client].try(:redirect_uri),
-      response_type: options[:response_type] || "code",
-      scope: options[:scope],
-      state: options[:state],
-      code_challenge: options[:code_challenge],
-      code_challenge_method: options[:code_challenge_method],
-    }.reject { |_, v| v.blank? }
-    "/oauth/authorize?#{build_query(parameters)}"
-  end
-
-  def refresh_token_endpoint_url(options = {})
-    parameters = {
-      refresh_token: options[:refresh_token],
-      client_id: options[:client_id] || options[:client].try(:uid),
-      client_secret: options[:client_secret] || options[:client].try(:secret),
-      grant_type: options[:grant_type] || "refresh_token",
-    }
-    "/oauth/token?#{build_query(parameters)}"
-  end
-
-  def revocation_token_endpoint_url
-    "/oauth/revoke"
-  end
-
-  def build_query(hash)
-    Rack::Utils.build_query(hash)
-  end
-end
-
-RSpec.configuration.send :include, UrlHelper

data/spec/support/orm/active_record.rb

@@ -1,5 +0,0 @@
-# frozen_string_literal: true
-
-# load schema to in memory sqlite
-ActiveRecord::Migration.verbose = false
-load Rails.root + "db/schema.rb"

data/spec/support/shared/controllers_shared_context.rb

@@ -1,133 +0,0 @@
-# frozen_string_literal: true
-
-shared_context "valid token", token: :valid do
-  let(:token_string) { "1A2B3C4D" }
-
-  let :token do
-    double(
-      Doorkeeper::AccessToken,
-      accessible?: true, includes_scope?: true, acceptable?: true,
-      previous_refresh_token: "", revoke_previous_refresh_token!: true,
-    )
-  end
-
-  before :each do
-    allow(
-      Doorkeeper::AccessToken,
-    ).to receive(:by_token).with(token_string).and_return(token)
-  end
-end
-
-shared_context "invalid token", token: :invalid do
-  let(:token_string) { "1A2B3C4D" }
-
-  let :token do
-    double(
-      Doorkeeper::AccessToken,
-      accessible?: false, revoked?: false, expired?: false,
-      includes_scope?: false, acceptable?: false,
-      previous_refresh_token: "", revoke_previous_refresh_token!: true,
-    )
-  end
-
-  before :each do
-    allow(
-      Doorkeeper::AccessToken,
-    ).to receive(:by_token).with(token_string).and_return(token)
-  end
-end
-
-shared_context "authenticated resource owner" do
-  before do
-    user = double(:resource, id: 1)
-    allow(Doorkeeper.config).to receive(:authenticate_resource_owner) { proc { user } }
-  end
-end
-
-shared_context "not authenticated resource owner" do
-  before do
-    allow(Doorkeeper.config).to receive(:authenticate_resource_owner) { proc { redirect_to "/" } }
-  end
-end
-
-shared_context "valid authorization request" do
-  let :authorization do
-    double(:authorization, valid?: true, authorize: true, success_redirect_uri: "http://something.com/cb?code=token")
-  end
-
-  before do
-    allow(controller).to receive(:authorization) { authorization }
-  end
-end
-
-shared_context "invalid authorization request" do
-  let :authorization do
-    double(:authorization, valid?: false, authorize: false, redirect_on_error?: false)
-  end
-
-  before do
-    allow(controller).to receive(:authorization) { authorization }
-  end
-end
-
-shared_context "expired token", token: :expired do
-  let :token_string do
-    "1A2B3C4DEXP"
-  end
-
-  let :token do
-    double(
-      Doorkeeper::AccessToken,
-      accessible?: false, revoked?: false, expired?: true,
-      includes_scope?: false, acceptable?: false,
-      previous_refresh_token: "", revoke_previous_refresh_token!: true,
-    )
-  end
-
-  before :each do
-    allow(
-      Doorkeeper::AccessToken,
-    ).to receive(:by_token).with(token_string).and_return(token)
-  end
-end
-
-shared_context "revoked token", token: :revoked do
-  let :token_string do
-    "1A2B3C4DREV"
-  end
-
-  let :token do
-    double(
-      Doorkeeper::AccessToken,
-      accessible?: false, revoked?: true, expired?: false,
-      includes_scope?: false, acceptable?: false,
-      previous_refresh_token: "", revoke_previous_refresh_token!: true,
-    )
-  end
-
-  before :each do
-    allow(
-      Doorkeeper::AccessToken,
-    ).to receive(:by_token).with(token_string).and_return(token)
-  end
-end
-
-shared_context "forbidden token", token: :forbidden do
-  let :token_string do
-    "1A2B3C4DFORB"
-  end
-
-  let :token do
-    double(
-      Doorkeeper::AccessToken,
-      accessible?: true, includes_scope?: true, acceptable?: false,
-      previous_refresh_token: "", revoke_previous_refresh_token!: true,
-    )
-  end
-
-  before :each do
-    allow(
-      Doorkeeper::AccessToken,
-    ).to receive(:by_token).with(token_string).and_return(token)
-  end
-end

data/spec/support/shared/hashing_shared_context.rb

@@ -1,36 +0,0 @@
-# frozen_string_literal: true
-
-shared_context "with token hashing enabled" do
-  let(:hashed_or_plain_token_func) do
-    Doorkeeper::SecretStoring::Sha256Hash.method(:transform_secret)
-  end
-
-  before do
-    Doorkeeper.configure do
-      hash_token_secrets
-    end
-  end
-end
-
-shared_context "with token hashing and fallback lookup enabled" do
-  let(:hashed_or_plain_token_func) do
-    Doorkeeper::SecretStoring::Sha256Hash.method(:transform_secret)
-  end
-
-  before do
-    Doorkeeper.configure do
-      hash_token_secrets fallback: :plain
-    end
-  end
-end
-
-shared_context "with application hashing enabled" do
-  let(:hashed_or_plain_token_func) do
-    Doorkeeper::SecretStoring::Sha256Hash.method(:transform_secret)
-  end
-  before do
-    Doorkeeper.configure do
-      hash_application_secrets
-    end
-  end
-end

data/spec/support/shared/models_shared_examples.rb

@@ -1,56 +0,0 @@
-# frozen_string_literal: true
-
-shared_examples "an accessible token" do
-  describe :accessible? do
-    it "is accessible if token is not expired" do
-      allow(subject).to receive(:expired?).and_return(false)
-      should be_accessible
-    end
-
-    it "is not accessible if token is expired" do
-      allow(subject).to receive(:expired?).and_return(true)
-      should_not be_accessible
-    end
-  end
-end
-
-shared_examples "a revocable token" do
-  describe :accessible? do
-    before { subject.save! }
-
-    it "is accessible if token is not revoked" do
-      expect(subject).to be_accessible
-    end
-
-    it "is not accessible if token is revoked" do
-      subject.revoke
-      expect(subject).not_to be_accessible
-    end
-  end
-end
-
-shared_examples "a unique token" do
-  describe :token do
-    let(:owner) { FactoryBot.create(:resource_owner) }
-
-    it "is generated before validation" do
-      expect { subject.valid? }.to change { subject.token }.from(nil)
-    end
-
-    it "is not valid if token exists" do
-      token1 = FactoryBot.create factory_name, resource_owner_id: owner.id, resource_owner_type: owner.class.name
-      token2 = FactoryBot.create factory_name, resource_owner_id: owner.id, resource_owner_type: owner.class.name
-      token2.token = token1.token
-      expect(token2).not_to be_valid
-    end
-
-    it "expects database to throw an error when tokens are the same" do
-      token1 = FactoryBot.create factory_name, resource_owner_id: owner.id, resource_owner_type: owner.class.name
-      token2 = FactoryBot.create factory_name, resource_owner_id: owner.id, resource_owner_type: owner.class.name
-      token2.token = token1.token
-      expect do
-        token2.save!(validate: false)
-      end.to raise_error(uniqueness_error)
-    end
-  end
-end