doorkeeper 5.4.0.rc1 → 5.5.0

data/spec/lib/oauth/refresh_token_request_spec.rb

@@ -1,166 +0,0 @@
-# frozen_string_literal: true
-
-require "spec_helper"
-
-describe Doorkeeper::OAuth::RefreshTokenRequest do
-  let(:server) do
-    double :server, access_token_expires_in: 2.minutes
-  end
-
-  let(:refresh_token) do
-    FactoryBot.create(:access_token, use_refresh_token: true)
-  end
-
-  let(:client) { refresh_token.application }
-  let(:credentials) { Doorkeeper::OAuth::Client::Credentials.new(client.uid, client.secret) }
-
-  before do
-    allow(Doorkeeper::AccessToken).to receive(:refresh_token_revoked_on_use?).and_return(false)
-    allow(server).to receive(:option_defined?).with(:custom_access_token_expires_in).and_return(false)
-  end
-
-  subject { described_class.new(server, refresh_token, credentials) }
-
-  it "issues a new token for the client" do
-    expect { subject.authorize }.to change { client.reload.access_tokens.count }.by(1)
-    # #sort_by used for MongoDB ORM extensions for valid ordering
-    expect(client.reload.access_tokens.max_by(&:created_at).expires_in).to eq(refresh_token.expires_in)
-  end
-
-  it "issues a new token for the client with the same expiry as of original token" do
-    allow(server).to receive(:option_defined?).with(:custom_access_token_expires_in).and_return(true)
-    allow(Doorkeeper::AccessToken).to receive(:refresh_token_revoked_on_use?).and_return(false)
-
-    described_class.new(server, refresh_token, credentials).authorize
-
-    # #sort_by used for MongoDB ORM extensions for valid ordering
-    expect(client.reload.access_tokens.max_by(&:created_at).expires_in).to eq(refresh_token.expires_in)
-  end
-
-  it "revokes the previous token" do
-    expect { subject.authorize }.to change { refresh_token.revoked? }.from(false).to(true)
-  end
-
-  it "calls configured request callback methods" do
-    expect(Doorkeeper.configuration.before_successful_strategy_response)
-      .to receive(:call).with(subject).once
-
-    expect(Doorkeeper.configuration.after_successful_strategy_response)
-      .to receive(:call).with(subject, instance_of(Doorkeeper::OAuth::TokenResponse)).once
-
-    subject.authorize
-  end
-
-  it "requires the refresh token" do
-    request = described_class.new(server, nil, credentials)
-    request.validate
-    expect(request.error).to eq(:invalid_request)
-    expect(request.missing_param).to eq(:refresh_token)
-  end
-
-  it "requires credentials to be valid if provided" do
-    credentials = Doorkeeper::OAuth::Client::Credentials.new("invalid", "invalid")
-    request = described_class.new(server, refresh_token, credentials)
-    request.validate
-    expect(request.error).to eq(:invalid_client)
-  end
-
-  it "requires the token's client and current client to match" do
-    other_app = FactoryBot.create(:application)
-    credentials = Doorkeeper::OAuth::Client::Credentials.new(other_app.uid, other_app.secret)
-
-    request = described_class.new(server, refresh_token, credentials)
-    request.validate
-    expect(request.error).to eq(:invalid_grant)
-  end
-
-  it "rejects revoked tokens" do
-    refresh_token.revoke
-    subject.validate
-    expect(subject.error).to eq(:invalid_grant)
-  end
-
-  it "accepts expired tokens" do
-    refresh_token.expires_in = -1
-    refresh_token.save
-    subject.validate
-    expect(subject).to be_valid
-  end
-
-  context "refresh tokens expire on access token use" do
-    before do
-      allow(Doorkeeper::AccessToken).to receive(:refresh_token_revoked_on_use?).and_return(true)
-    end
-
-    it "issues a new token for the client" do
-      expect { subject.authorize }.to change { client.reload.access_tokens.count }.by(1)
-    end
-
-    it "does not revoke the previous token" do
-      subject.authorize
-      expect(refresh_token).not_to be_revoked
-    end
-
-    it "sets the previous refresh token in the new access token" do
-      subject.authorize
-      expect(
-        # #sort_by used for MongoDB ORM extensions for valid ordering
-        client.access_tokens.max_by(&:created_at).previous_refresh_token,
-      ).to eq(refresh_token.refresh_token)
-    end
-  end
-
-  context "clientless access tokens" do
-    let!(:refresh_token) { FactoryBot.create(:clientless_access_token, use_refresh_token: true) }
-
-    subject { described_class.new server, refresh_token, nil }
-
-    it "issues a new token without a client" do
-      expect { subject.authorize }.to change { Doorkeeper::AccessToken.count }.by(1)
-    end
-  end
-
-  context "with scopes" do
-    let(:refresh_token) do
-      FactoryBot.create :access_token,
-                        use_refresh_token: true,
-                        scopes: "public write"
-    end
-    let(:parameters) { {} }
-
-    subject { described_class.new server, refresh_token, credentials, parameters }
-
-    it "transfers scopes from the old token to the new token" do
-      subject.authorize
-      expect(Doorkeeper::AccessToken.last.scopes).to eq(%i[public write])
-    end
-
-    it "reduces scopes to the provided scopes" do
-      parameters[:scopes] = "public"
-      subject.authorize
-      expect(Doorkeeper::AccessToken.last.scopes).to eq(%i[public])
-    end
-
-    it "validates that scopes are included in the original access token" do
-      parameters[:scopes] = "public update"
-
-      subject.validate
-      expect(subject.error).to eq(:invalid_scope)
-    end
-
-    it "uses params[:scope] in favor of scopes if present (valid)" do
-      parameters[:scopes] = "public update"
-      parameters[:scope] = "public"
-      subject.authorize
-      expect(Doorkeeper::AccessToken.last.scopes).to eq(%i[public])
-    end
-
-    it "uses params[:scope] in favor of scopes if present (invalid)" do
-      parameters[:scopes] = "public"
-      parameters[:scope] = "public update"
-
-      subject.validate
-      expect(subject.error).to eq(:invalid_scope)
-    end
-  end
-end

data/spec/lib/oauth/scopes_spec.rb

@@ -1,146 +0,0 @@
-# frozen_string_literal: true
-
-require "spec_helper"
-
-describe Doorkeeper::OAuth::Scopes do
-  describe "#add" do
-    it "allows you to add scopes with symbols" do
-      subject.add :public
-      expect(subject.all).to eq(["public"])
-    end
-
-    it "allows you to add scopes with strings" do
-      subject.add "public"
-      expect(subject.all).to eq(["public"])
-    end
-
-    it "do not add already included scopes" do
-      subject.add :public
-      subject.add :public
-      expect(subject.all).to eq(["public"])
-    end
-  end
-
-  describe "#exists" do
-    before do
-      subject.add :public
-    end
-
-    it "returns true if scope with given name is present" do
-      expect(subject.exists?("public")).to be_truthy
-    end
-
-    it "returns false if scope with given name does not exist" do
-      expect(subject.exists?("other")).to be_falsey
-    end
-
-    it "handles symbols" do
-      expect(subject.exists?(:public)).to be_truthy
-      expect(subject.exists?(:other)).to be_falsey
-    end
-  end
-
-  describe ".from_string" do
-    let(:string) { "public write" }
-
-    subject { described_class.from_string(string) }
-
-    it { expect(subject).to be_a(described_class) }
-
-    describe "#all" do
-      it "should be an array of the expected scopes" do
-        scopes_array = subject.all
-        expect(scopes_array.size).to eq(2)
-        expect(scopes_array).to include("public")
-        expect(scopes_array).to include("write")
-      end
-    end
-  end
-
-  describe "#+" do
-    it "can add to another scope object" do
-      scopes = described_class.from_string("public") + described_class.from_string("admin")
-      expect(scopes.all).to eq(%w[public admin])
-    end
-
-    it "does not change the existing object" do
-      origin = described_class.from_string("public")
-      expect(origin.to_s).to eq("public")
-    end
-
-    it "can add an array to a scope object" do
-      scopes = described_class.from_string("public") + ["admin"]
-      expect(scopes.all).to eq(%w[public admin])
-    end
-
-    it "raises an error if cannot handle addition" do
-      expect do
-        described_class.from_string("public") + "admin"
-      end.to raise_error(NoMethodError)
-    end
-  end
-
-  describe "#&" do
-    it "can get intersection with another scope object" do
-      scopes = described_class.from_string("public admin") & described_class.from_string("write admin")
-      expect(scopes.all).to eq(%w[admin])
-    end
-
-    it "does not change the existing object" do
-      origin = described_class.from_string("public admin")
-      origin & described_class.from_string("write admin")
-      expect(origin.to_s).to eq("public admin")
-    end
-
-    it "can get intersection with an array" do
-      scopes = described_class.from_string("public admin") & %w[write admin]
-      expect(scopes.all).to eq(%w[admin])
-    end
-  end
-
-  describe "#==" do
-    it "is equal to another set of scopes" do
-      expect(described_class.from_string("public")).to eq(described_class.from_string("public"))
-    end
-
-    it "is equal to another set of scopes with no particular order" do
-      expect(described_class.from_string("public write")).to eq(described_class.from_string("write public"))
-    end
-
-    it "differs from another set of scopes when scopes are not the same" do
-      expect(described_class.from_string("public write")).not_to eq(described_class.from_string("write"))
-    end
-
-    it "does not raise an error when compared to a non-enumerable object" do
-      expect { described_class.from_string("public") == false }.not_to raise_error
-    end
-  end
-
-  describe "#has_scopes?" do
-    subject { described_class.from_string("public admin") }
-
-    it "returns true when at least one scope is included" do
-      expect(subject.has_scopes?(described_class.from_string("public"))).to be_truthy
-    end
-
-    it "returns true when all scopes are included" do
-      expect(subject.has_scopes?(described_class.from_string("public admin"))).to be_truthy
-    end
-
-    it "is true if all scopes are included in any order" do
-      expect(subject.has_scopes?(described_class.from_string("admin public"))).to be_truthy
-    end
-
-    it "is false if no scopes are included" do
-      expect(subject.has_scopes?(described_class.from_string("notexistent"))).to be_falsey
-    end
-
-    it "returns false when any scope is not included" do
-      expect(subject.has_scopes?(described_class.from_string("public nope"))).to be_falsey
-    end
-
-    it "is false if no scopes are included even for existing ones" do
-      expect(subject.has_scopes?(described_class.from_string("public admin notexistent"))).to be_falsey
-    end
-  end
-end

data/spec/lib/oauth/token_request_spec.rb

@@ -1,164 +0,0 @@
-# frozen_string_literal: true
-
-require "spec_helper"
-
-describe Doorkeeper::OAuth::TokenRequest do
-  let :application do
-    FactoryBot.create(:application, scopes: "public")
-  end
-
-  let :pre_auth do
-    server = Doorkeeper.config
-    allow(server).to receive(:default_scopes).and_return(Doorkeeper::OAuth::Scopes.from_string("public"))
-    allow(server).to receive(:grant_flows).and_return(Doorkeeper::OAuth::Scopes.from_string("implicit"))
-
-    client = Doorkeeper::OAuth::Client.new(application)
-
-    attributes = {
-      client_id: client.uid,
-      response_type: "token",
-      redirect_uri: "https://app.com/callback",
-    }
-
-    pre_auth = Doorkeeper::OAuth::PreAuthorization.new(server, attributes)
-    pre_auth.authorizable?
-    pre_auth
-  end
-
-  let :owner do
-    FactoryBot.create(:doorkeeper_testing_user)
-  end
-
-  subject do
-    described_class.new(pre_auth, owner)
-  end
-
-  it "creates an access token" do
-    expect do
-      subject.authorize
-    end.to change { Doorkeeper::AccessToken.count }.by(1)
-  end
-
-  it "returns a code response" do
-    expect(subject.authorize).to be_a(Doorkeeper::OAuth::CodeResponse)
-  end
-
-  context "when pre_auth is denied" do
-    it "does not create token and returns a error response" do
-      expect { subject.deny }.not_to(change { Doorkeeper::AccessToken.count })
-      expect(subject.deny).to be_a(Doorkeeper::OAuth::ErrorResponse)
-    end
-  end
-
-  describe "with custom expiration" do
-    context "when proper TTL returned" do
-      before do
-        Doorkeeper.configure do
-          orm DOORKEEPER_ORM
-          custom_access_token_expires_in do |context|
-            context.grant_type == Doorkeeper::OAuth::IMPLICIT ? 1234 : nil
-          end
-        end
-      end
-
-      it "should use the custom ttl" do
-        subject.authorize
-        token = Doorkeeper::AccessToken.first
-        expect(token.expires_in).to eq(1234)
-      end
-    end
-
-    context "when nil TTL returned" do
-      before do
-        Doorkeeper.configure do
-          orm DOORKEEPER_ORM
-          access_token_expires_in 654
-          custom_access_token_expires_in do |_context|
-            nil
-          end
-        end
-      end
-
-      it "should fallback to access_token_expires_in" do
-        subject.authorize
-        token = Doorkeeper::AccessToken.first
-        expect(token.expires_in).to eq(654)
-      end
-    end
-
-    context "when infinite TTL returned" do
-      before do
-        Doorkeeper.configure do
-          orm DOORKEEPER_ORM
-          access_token_expires_in 654
-          custom_access_token_expires_in do |_context|
-            Float::INFINITY
-          end
-        end
-      end
-
-      it "should fallback to access_token_expires_in" do
-        subject.authorize
-        token = Doorkeeper::AccessToken.first
-        expect(token.expires_in).to be_nil
-      end
-    end
-  end
-
-  context "token reuse" do
-    it "creates a new token if there are no matching tokens" do
-      allow(Doorkeeper.configuration).to receive(:reuse_access_token).and_return(true)
-      expect do
-        subject.authorize
-      end.to change { Doorkeeper::AccessToken.count }.by(1)
-    end
-
-    it "creates a new token if scopes do not match" do
-      allow(Doorkeeper.configuration).to receive(:reuse_access_token).and_return(true)
-      FactoryBot.create(
-        :access_token,
-        application_id: pre_auth.client.id,
-        resource_owner_id: owner.id,
-        resource_owner_type: owner.class.name,
-        scopes: "",
-      )
-
-      expect do
-        subject.authorize
-      end.to change { Doorkeeper::AccessToken.count }.by(1)
-    end
-
-    it "skips token creation if there is a matching one reusable" do
-      allow(Doorkeeper.configuration).to receive(:reuse_access_token).and_return(true)
-      allow(application.scopes).to receive(:has_scopes?).and_return(true)
-      allow(application.scopes).to receive(:all?).and_return(true)
-
-      FactoryBot.create(
-        :access_token, application_id: pre_auth.client.id,
-                       resource_owner_id: owner.id, resource_owner_type: owner.class.name, scopes: "public",
-      )
-
-      expect { subject.authorize }.not_to(change { Doorkeeper::AccessToken.count })
-    end
-
-    it "creates new token if there is a matching one but non reusable" do
-      allow(Doorkeeper.configuration).to receive(:reuse_access_token).and_return(true)
-      allow(application.scopes).to receive(:has_scopes?).and_return(true)
-      allow(application.scopes).to receive(:all?).and_return(true)
-
-      FactoryBot.create(
-        :access_token,
-        application_id: pre_auth.client.id,
-        resource_owner_id: owner.id,
-        resource_owner_type: owner.class.name,
-        scopes: "public",
-      )
-
-      allow_any_instance_of(Doorkeeper::AccessToken).to receive(:reusable?).and_return(false)
-
-      expect do
-        subject.authorize
-      end.to change { Doorkeeper::AccessToken.count }.by(1)
-    end
-  end
-end