dnsimple 4.6.0 → 7.0.0

data/spec/dnsimple/client/templates_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Dnsimple::Client, ".templates" do
@@ -75,13 +77,13 @@ describe Dnsimple::Client, ".templates" do
 
   describe "#create_template" do
     let(:account_id) { 1010 }
+    let(:attributes) { { name: "Beta", short_name: "beta", description: "A beta template." } }
 
     before do
       stub_request(:post, %r{/v2/#{account_id}/templates$})
           .to_return(read_http_fixture("createTemplate/created.http"))
     end
 
-    let(:attributes) { { name: "Beta", short_name: "beta", description: "A beta template." } }
 
     it "builds the correct request" do
       subject.create_template(account_id, attributes)
@@ -136,6 +138,7 @@ describe Dnsimple::Client, ".templates" do
 
   describe "#update_template" do
     let(:account_id) { 1010 }
+    let(:attributes) { { name: "Alpha", short_name: "alpha", description: "An alpha template." } }
     let(:template_id) { 1 }
 
     before do
@@ -143,7 +146,6 @@ describe Dnsimple::Client, ".templates" do
           .to_return(read_http_fixture("updateTemplate/success.http"))
     end
 
-    let(:attributes) { { name: "Alpha", short_name: "alpha", description: "An alpha template." } }
 
     it "builds the correct request" do
       subject.update_template(account_id, template_id, attributes)

data/spec/dnsimple/client/tlds_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Dnsimple::Client, ".tlds" do

data/spec/dnsimple/client/vanity_name_servers_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Dnsimple::Client, ".vanity_name_servers" do

data/spec/dnsimple/client/webhooks_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Dnsimple::Client, ".webhooks" do
@@ -47,13 +49,13 @@ describe Dnsimple::Client, ".webhooks" do
 
   describe "#create_webhook" do
     let(:account_id) { 1010 }
+    let(:attributes) { { url: "https://webhook.test" } }
 
     before do
       stub_request(:post, %r{/v2/#{account_id}/webhooks$})
           .to_return(read_http_fixture("createWebhook/created.http"))
     end
 
-    let(:attributes) { { url: "https://webhook.test" } }
 
     it "builds the correct request" do
       subject.create_webhook(account_id, attributes)

data/spec/dnsimple/client/zones_distributions_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Dnsimple::Client, ".zones" do

data/spec/dnsimple/client/zones_records_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Dnsimple::Client, ".zones" do
@@ -110,6 +112,7 @@ describe Dnsimple::Client, ".zones" do
 
   describe "#create_zone_record" do
     let(:account_id) { 1010 }
+    let(:attributes) { { type: "A", name: "www", content: "127.0.0.1", regions: %w(global) } }
     let(:zone_id) { "example.com" }
 
     before do
@@ -117,7 +120,6 @@ describe Dnsimple::Client, ".zones" do
           .to_return(read_http_fixture("createZoneRecord/created.http"))
     end
 
-    let(:attributes) { { type: "A", name: "www", content: "127.0.0.1", regions: %w(global) } }
 
     it "builds the correct request" do
       subject.create_zone_record(account_id, zone_id, attributes)
@@ -214,6 +216,7 @@ describe Dnsimple::Client, ".zones" do
 
   describe "#update_zone_record" do
     let(:account_id) { 1010 }
+    let(:attributes) { { content: "mxb.example.com", priority: "20", regions: ['global'] } }
     let(:zone_id) { "example.com" }
     let(:record_id) { 5 }
 
@@ -222,7 +225,6 @@ describe Dnsimple::Client, ".zones" do
           .to_return(read_http_fixture("updateZoneRecord/success.http"))
     end
 
-    let(:attributes) { { content: "mxb.example.com", priority: "20", regions: ['global'] } }
 
     it "builds the correct request" do
       subject.update_zone_record(account_id, zone_id, record_id, attributes)

data/spec/dnsimple/client/zones_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Dnsimple::Client, ".zones" do
@@ -87,7 +89,7 @@ describe Dnsimple::Client, ".zones" do
       expect(WebMock).to have_requested(:get, "https://api.dnsimple.test/v2/#{account_id}/zones?page=1&per_page=100&sort=name:desc")
     end
 
-    it "supports sorting" do
+    it "supports filtering" do
       subject.all_zones(account_id, filter: { name_like: "zone.test" })
 
       expect(WebMock).to have_requested(:get, "https://api.dnsimple.test/v2/#{account_id}/zones?page=1&per_page=100&name_like=zone.test")

data/spec/dnsimple/client_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Dnsimple::Client do
@@ -47,35 +49,35 @@ describe Dnsimple::Client do
 
   describe "#get" do
     it "delegates to #request" do
-      expect(subject).to receive(:execute).with(:get, "path", nil, foo: "bar").and_return(:returned)
+      allow(subject).to receive(:execute).with(:get, "path", nil, foo: "bar").and_return(:returned)
       expect(subject.get("path", foo: "bar")).to eq(:returned)
     end
   end
 
   describe "#post" do
     it "delegates to #request" do
-      expect(subject).to receive(:execute).with(:post, "path", { foo: "bar" }, {}).and_return(:returned)
+      allow(subject).to receive(:execute).with(:post, "path", { foo: "bar" }, {}).and_return(:returned)
       expect(subject.post("path", foo: "bar")).to eq(:returned)
     end
   end
 
   describe "#put" do
     it "delegates to #request" do
-      expect(subject).to receive(:execute).with(:put, "path", { foo: "bar" }, {}).and_return(:returned)
+      allow(subject).to receive(:execute).with(:put, "path", { foo: "bar" }, {}).and_return(:returned)
       expect(subject.put("path", foo: "bar")).to eq(:returned)
     end
   end
 
   describe "#patch" do
     it "delegates to #request" do
-      expect(subject).to receive(:execute).with(:patch, "path", { foo: "bar" }, {}).and_return(:returned)
+      allow(subject).to receive(:execute).with(:patch, "path", { foo: "bar" }, {}).and_return(:returned)
       expect(subject.patch("path", foo: "bar")).to eq(:returned)
     end
   end
 
   describe "#delete" do
     it "delegates to #request" do
-      expect(subject).to receive(:execute).with(:delete, "path", { foo: "bar" }, {}).and_return(:returned)
+      allow(subject).to receive(:execute).with(:delete, "path", { foo: "bar" }, {}).and_return(:returned)
       expect(subject.delete("path", foo: "bar")).to eq(:returned)
     end
   end
@@ -124,20 +126,20 @@ describe Dnsimple::Client do
     it "delegates to HTTParty" do
       stub_request(:get, %r{/foo})
 
-      expect(HTTParty).to receive(:get)
+      allow(HTTParty).to receive(:get)
           .with(
               "#{subject.base_url}foo",
               format: :json,
               basic_auth: { username: "user", password: "pass" },
               headers: { 'Accept' => 'application/json', 'User-Agent' => Dnsimple::Default::USER_AGENT }
             )
-          .and_return(double('response', code: 200))
+          .and_return(instance_double('response', code: 200))
 
       subject.request(:get, 'foo')
     end
 
     it "properly extracts processes options and encodes data" do
-      expect(HTTParty).to receive(:put)
+      allow(HTTParty).to receive(:put)
           .with(
               "#{subject.base_url}foo",
               format: :json,
@@ -146,13 +148,13 @@ describe Dnsimple::Client do
               basic_auth: { username: "user", password: "pass" },
               headers: { 'Accept' => 'application/json', 'Content-Type' => 'application/json', 'User-Agent' => Dnsimple::Default::USER_AGENT, "Custom" => "Header" }
             )
-          .and_return(double('response', code: 200))
+          .and_return(instance_double('response', code: 200))
 
       subject.request(:put, 'foo', { something: "else" }, { query: { foo: "bar" }, headers: { "Custom" => "Header" } })
     end
 
     it "handles non application/json content types" do
-      expect(HTTParty).to receive(:post)
+      allow(HTTParty).to receive(:post)
           .with(
               "#{subject.base_url}foo",
               format: :json,
@@ -160,13 +162,13 @@ describe Dnsimple::Client do
               basic_auth: { username: "user", password: "pass" },
               headers: { 'Accept' => 'application/json', 'Content-Type' => 'application/x-www-form-urlencoded', 'User-Agent' => Dnsimple::Default::USER_AGENT }
             )
-          .and_return(double('response', code: 200))
+          .and_return(instance_double('response', code: 200))
 
       subject.request(:post, 'foo', { something: "else" }, { headers: { "Content-Type" => "application/x-www-form-urlencoded" } })
     end
 
     it "includes options for proxy support" do
-      expect(HTTParty).to receive(:get)
+      allow(HTTParty).to receive(:get)
           .with(
               "#{subject.base_url}test",
               format: :json,
@@ -174,20 +176,20 @@ describe Dnsimple::Client do
               http_proxyport: "4321",
               headers: { 'Accept' => 'application/json', 'User-Agent' => Dnsimple::Default::USER_AGENT }
             )
-          .and_return(double('response', code: 200))
+          .and_return(instance_double('response', code: 200))
 
       subject = described_class.new(proxy: "example-proxy.com:4321")
       subject.request(:get, "test", nil, {})
     end
 
     it "supports custom user agent" do
-      expect(HTTParty).to receive(:get)
+      allow(HTTParty).to receive(:get)
           .with(
               "#{subject.base_url}test",
               format: :json,
-              headers: hash_including("User-Agent" => "#{Dnsimple::Default::USER_AGENT} customAgent")
+              headers: hash_including("User-Agent" => "customAgent #{Dnsimple::Default::USER_AGENT}")
             )
-          .and_return(double("response", code: 200))
+          .and_return(instance_double("response", code: 200))
 
       subject = described_class.new(user_agent: "customAgent")
       subject.request(:get, "test", nil)

data/spec/dnsimple/extra_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Dnsimple::Extra do

data/spec/dnsimple/options/base_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 RSpec.describe Dnsimple::Options::Base do

data/spec/dnsimple/options/list_options_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 RSpec.describe Dnsimple::Options::ListOptions do
@@ -12,14 +14,14 @@ RSpec.describe Dnsimple::Options::ListOptions do
       expect(options.to_h).to eq({})
     end
 
-    context 'query' do
+    describe 'query' do
       it 'adds "query" key if given options are filled' do
         options = described_class.new(a: 1)
         expect(options.to_h).to have_key(:query)
       end
     end
 
-    context 'pagination' do
+    describe 'pagination' do
       it 'adds "page" to "query"' do
         raw      = { page: '23' }
         expected = { query: raw }
@@ -45,7 +47,7 @@ RSpec.describe Dnsimple::Options::ListOptions do
       end
     end
 
-    context 'sorting' do
+    describe 'sorting' do
       it 'adds sorting policy to "query"' do
         raw      = { sort: 'name:desc' }
         expected = { query: raw }
@@ -71,7 +73,7 @@ RSpec.describe Dnsimple::Options::ListOptions do
       end
     end
 
-    context 'filtering' do
+    describe 'filtering' do
       it 'adds filtering policy to "query"' do
         raw      = { filter: { name_like: 'example' } }
         expected = { query: raw.fetch(:filter) }

data/spec/fixtures.http/accounts/success-account.http

@@ -2,7 +2,6 @@ HTTP/1.1 200 OK
 Server: nginx
 Date: Tue, 14 Jun 2016 12:02:58 GMT
 Content-Type: application/json; charset=utf-8
-Transfer-Encoding: chunked
 Connection: keep-alive
 X-RateLimit-Limit: 2400
 X-RateLimit-Remaining: 2391

data/spec/fixtures.http/accounts/success-user.http

@@ -2,7 +2,6 @@ HTTP/1.1 200 OK
 Server: nginx
 Date: Tue, 14 Jun 2016 12:05:38 GMT
 Content-Type: application/json; charset=utf-8
-Transfer-Encoding: chunked
 Connection: keep-alive
 X-RateLimit-Limit: 2400
 X-RateLimit-Remaining: 2390

data/spec/fixtures.http/addCollaborator/invite-success.http

@@ -2,7 +2,6 @@ HTTP/1.1 201 Created
 Server: nginx
 Date: Fri, 07 Oct 2016 08:51:12 GMT
 Content-Type: application/json; charset=utf-8
-Transfer-Encoding: chunked
 Connection: keep-alive
 X-RateLimit-Limit: 2400
 X-RateLimit-Remaining: 2398

data/spec/fixtures.http/addCollaborator/success.http

@@ -2,7 +2,6 @@ HTTP/1.1 201 Created
 Server: nginx
 Date: Fri, 07 Oct 2016 08:53:41 GMT
 Content-Type: application/json; charset=utf-8
-Transfer-Encoding: chunked
 Connection: keep-alive
 X-RateLimit-Limit: 2400
 X-RateLimit-Remaining: 2397

data/spec/fixtures.http/appliedServices/success.http

@@ -2,7 +2,6 @@ HTTP/1.1 200 OK
 Server: nginx
 Date: Wed, 15 Jun 2016 11:09:44 GMT
 Content-Type: application/json; charset=utf-8
-Transfer-Encoding: chunked
 Connection: keep-alive
 X-RateLimit-Limit: 2400
 X-RateLimit-Remaining: 2398

data/spec/fixtures.http/cancelDomainTransfer/success.http

@@ -0,0 +1,18 @@
+HTTP/1.1 202 Accepted
+Server: nginx
+Date: Fri, 05 Jun 2020 18:09:42 GMT
+Content-Type: application/json; charset=utf-8
+Connection: keep-alive
+X-RateLimit-Limit: 2400
+X-RateLimit-Remaining: 2394
+X-RateLimit-Reset: 1591384034
+Cache-Control: no-cache
+X-Request-Id: 3cf6dcfa-0bb5-439e-863a-af2ef08bc830
+X-Runtime: 0.912731
+X-Frame-Options: DENY
+X-Content-Type-Options: nosniff
+X-XSS-Protection: 1; mode=block
+X-Download-Options: noopen
+X-Permitted-Cross-Domain-Policies: none
+
+{"data":{"id":361,"domain_id":182245,"registrant_id":2715,"state":"transferring","auto_renew":false,"whois_privacy":false,"status_description":null,"created_at":"2020-06-05T18:08:00Z","updated_at":"2020-06-05T18:08:04Z"}}

data/spec/fixtures.http/changeDomainDelegation/success.http

@@ -2,7 +2,6 @@ HTTP/1.1 200 OK
 Server: nginx
 Date: Thu, 24 Mar 2016 11:17:01 GMT
 Content-Type: application/json; charset=utf-8
-Transfer-Encoding: chunked
 Connection: keep-alive
 Status: 200 OK
 X-RateLimit-Limit: 2400

data/spec/fixtures.http/changeDomainDelegationToVanity/success.http

@@ -2,7 +2,6 @@ HTTP/1.1 200 OK
 Server: nginx
 Date: Mon, 11 Jul 2016 09:40:19 GMT
 Content-Type: application/json; charset=utf-8
-Transfer-Encoding: chunked
 Connection: keep-alive
 X-RateLimit-Limit: 2400
 X-RateLimit-Remaining: 2399

data/spec/fixtures.http/checkDomain/success.http

@@ -2,7 +2,6 @@ HTTP/1.1 200 OK
 Server: nginx
 Date: Fri, 26 Feb 2016 16:04:05 GMT
 Content-Type: application/json; charset=utf-8
-Transfer-Encoding: chunked
 Connection: keep-alive
 Status: 200 OK
 X-RateLimit-Limit: 4000

data/spec/fixtures.http/checkDomainPremiumPrice/error_400_not_a_premium_domain.http

@@ -0,0 +1,18 @@
+HTTP/1.1 400 Bad Request
+Server: nginx
+Date: Mon, 27 Jul 2020 13:43:02 GMT
+Content-Type: application/json; charset=utf-8
+Connection: keep-alive
+X-RateLimit-Limit: 4800
+X-RateLimit-Remaining: 4786
+X-RateLimit-Reset: 1595859922
+Cache-Control: no-cache
+X-Request-Id: 382b409c-0f90-4758-af3b-0bccd31a9d0d
+X-Runtime: 1.346405
+X-Frame-Options: DENY
+X-Content-Type-Options: nosniff
+X-XSS-Protection: 1; mode=block
+X-Download-Options: noopen
+X-Permitted-Cross-Domain-Policies: none
+
+{"message":"`cocotero.love` is not a premium domain for registration"}

data/spec/fixtures.http/checkDomainPremiumPrice/error_400_tld_not_supported.http

@@ -0,0 +1,18 @@
+HTTP/1.1 400 Bad Request
+Server: nginx
+Date: Mon, 27 Jul 2020 13:41:23 GMT
+Content-Type: application/json; charset=utf-8
+Connection: keep-alive
+X-RateLimit-Limit: 2400
+X-RateLimit-Remaining: 2398
+X-RateLimit-Reset: 1595860823
+Cache-Control: no-cache
+X-Request-Id: 6986cca3-4f57-4814-9e81-1c484d61c7ea
+X-Runtime: 0.007339
+X-Frame-Options: DENY
+X-Content-Type-Options: nosniff
+X-XSS-Protection: 1; mode=block
+X-Download-Options: noopen
+X-Permitted-Cross-Domain-Policies: none
+
+{"message":"TLD .LOVE is not supported"}