dnsimple 4.6.0 → 7.0.0

data/lib/dnsimple/struct/domain_push.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Dnsimple
   module Struct
 

data/lib/dnsimple/struct/domain_registration.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Dnsimple
   module Struct
 

data/lib/dnsimple/struct/domain_renewal.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Dnsimple
   module Struct
 

data/lib/dnsimple/struct/domain_transfer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Dnsimple
   module Struct
 
@@ -20,6 +22,9 @@ module Dnsimple
       # @return [Bool] True if the domain WHOIS privacy was requested.
       attr_accessor :whois_privacy
 
+      # @return [String,nil] The reason if transfer failed.
+      attr_accessor :status_description
+
       # @return [String] When the domain renewal was created in DNSimple.
       attr_accessor :created_at
 

data/lib/dnsimple/struct/email_forward.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Dnsimple
   module Struct
 

data/lib/dnsimple/struct/extended_attribute.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Dnsimple
   module Struct
 

data/lib/dnsimple/struct/oauth_token.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Dnsimple
   module Struct
 

data/lib/dnsimple/struct/service.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Dnsimple
   module Struct
 

data/lib/dnsimple/struct/template.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Dnsimple
   module Struct
 

data/lib/dnsimple/struct/template_record.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Dnsimple
   module Struct
 

data/lib/dnsimple/struct/tld.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Dnsimple
   module Struct
 

data/lib/dnsimple/struct/user.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Dnsimple
   module Struct
 

data/lib/dnsimple/struct/vanity_name_server.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Dnsimple
   module Struct
 

data/lib/dnsimple/struct/webhook.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Dnsimple
   module Struct
 

data/lib/dnsimple/struct/whoami.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Dnsimple
   module Struct
 

data/lib/dnsimple/struct/whois_privacy.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Dnsimple
   module Struct
 

data/lib/dnsimple/struct/whois_privacy_renewal.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Dnsimple
   module Struct
 

data/lib/dnsimple/struct/zone.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Dnsimple
   module Struct
 

data/lib/dnsimple/struct/zone_distribution.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Dnsimple
   module Struct
 

data/lib/dnsimple/struct/zone_file.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Dnsimple
   module Struct
 

data/lib/dnsimple/struct/zone_record.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Dnsimple
   module Struct
 

data/lib/dnsimple/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Dnsimple
-  VERSION = "4.6.0".freeze
+  VERSION = "7.0.0"
 end

data/spec/dnsimple/client/accounts_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Dnsimple::Client, ".accounts" do

data/spec/dnsimple/client/certificates_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Dnsimple::Client, ".certificates" do
@@ -63,7 +65,7 @@ describe Dnsimple::Client, ".certificates" do
     end
 
     let(:account_id) { 1010 }
-    let(:domain_id) { "example.com" }
+    let(:domain_id) { "dnsimple.us" }
 
     it "delegates to client.paginate" do
       expect(subject).to receive(:paginate).with(:certificates, account_id, domain_id, foo: "bar")
@@ -71,16 +73,16 @@ describe Dnsimple::Client, ".certificates" do
     end
 
     it "supports sorting" do
-      subject.all_certificates(account_id, domain_id, sort: "id:asc,expires_on:desc")
+      subject.all_certificates(account_id, domain_id, sort: "id:asc,expiration:desc")
 
-      expect(WebMock).to have_requested(:get, "https://api.dnsimple.test/v2/#{account_id}/domains/#{domain_id}/certificates?page=1&per_page=100&sort=id:asc,expires_on:desc")
+      expect(WebMock).to have_requested(:get, "https://api.dnsimple.test/v2/#{account_id}/domains/#{domain_id}/certificates?page=1&per_page=100&sort=id:asc,expiration:desc")
     end
   end
 
   describe "#certificate" do
     let(:account_id)     { 1010 }
-    let(:domain_id)      { "weppos.net" }
-    let(:certificate_id) { 1 }
+    let(:domain_id)      { "bingo.pizza" }
+    let(:certificate_id) { 101967 }
 
     before do
       stub_request(:get, %r{/v2/#{account_id}/domains/#{domain_id}/certificates/#{certificate_id}})
@@ -106,19 +108,19 @@ describe Dnsimple::Client, ".certificates" do
 
       result = response.data
       expect(result).to be_a(Dnsimple::Struct::Certificate)
-      expect(result.id).to eq(1)
-      expect(result.domain_id).to eq(2)
-      expect(result.contact_id).to eq(3)
-      expect(result.common_name).to eq("www.weppos.net")
-      expect(result.alternate_names).to eq(%w( weppos.net www.weppos.net ))
+      expect(result.id).to eq(101967)
+      expect(result.domain_id).to eq(289333)
+      expect(result.contact_id).to eq(2511)
+      expect(result.common_name).to eq("www.bingo.pizza")
+      expect(result.alternate_names).to eq([])
       expect(result.years).to eq(1)
-      expect(result.csr).to eq("-----BEGIN CERTIFICATE REQUEST-----\nMIICljCCAX4CAQAwGTEXMBUGA1UEAwwOd3d3LndlcHBvcy5uZXQwggEiMA0GCSqG\nSIb3DQEBAQUAA4IBDwAwggEKAoIBAQC3MJwx9ahBG3kAwRjQdRvYZqtovUaxY6jp\nhd09975gO+2eYPDbc1yhNftVJ4KBT0zdEqzX0CwIlxE1MsnZ2YOsC7IJO531hMBp\ndBxM4tSG07xPz70AVUi9rY6YCUoJHmxoFbclpHFbtXZocR393WyzUK8047uM2mlz\n03AZKcMdyfeuo2/9TcxpTSCkklGqwqS9wtTogckaDHJDoBunAkMioGfOSMe7Yi6E\nYRtG4yPJYsDaq2yPJWV8+i0PFR1Wi5RCnPt0YdQWstHuZrxABi45+XVkzKtz3TUc\nYxrvPBucVa6uzd953u8CixNFkiOefvb/dajsv1GIwH6/Cvc1ftz1AgMBAAGgODA2\nBgkqhkiG9w0BCQ4xKTAnMCUGA1UdEQQeMByCDnd3dy53ZXBwb3MubmV0ggp3ZXBw\nb3MubmV0MA0GCSqGSIb3DQEBCwUAA4IBAQCDnVBO9RdJX0eFeZzlv5c8yG8duhKP\nl0Vl+V88fJylb/cbNj9qFPkKTK0vTXmS2XUFBChKPtLucp8+Z754UswX+QCsdc7U\nTTSG0CkyilcSubdZUERGej1XfrVQhrokk7Fu0Jh3BdT6REP0SIDTpA8ku/aRQiAp\np+h19M37S7+w/DMGDAq2LSX8jOpJ1yIokRDyLZpmwyLxutC21DXMGoJ3xZeUFrUT\nqRNwzkn2dJzgTrPkzhaXalUBqv+nfXHqHaWljZa/O0NVCFrHCdTdd53/6EE2Yabv\nq5SFTkRCpaxrvM/7a8Tr4ixD1/VKD6rw3+WC00000000000000000000\n-----END CERTIFICATE REQUEST-----\n")
+      expect(result.csr).to eq("-----BEGIN CERTIFICATE REQUEST-----\nMIICmTCCAYECAQAwGjEYMBYGA1UEAwwPd3d3LmJpbmdvLnBpenphMIIBIjANBgkq\nhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAw4+KoZ9IDCK2o5qAQpi+Icu5kksmjQzx\n5o5g4B6XhRxhsfHlK/i3iU5hc8CONjyVv8j82835RNsiKrflnxGa9SH68vbQfcn4\nIpbMz9c+Eqv5h0Euqlc3A4DBzp0unEu5QAUhR6Xu1TZIWDPjhrBOGiszRlLQcp4F\nzy6fD6j5/d/ylpzTp5v54j+Ey31Bz86IaBPtSpHI+Qk87Hs8DVoWxZk/6RlAkyur\nXDGWnPu9n3RMfs9ag5anFhggLIhCNtVN4+0vpgPQ59pqwYo8TfdYzK7WSKeL7geu\nCqVE3bHAqU6dLtgHOZfTkLwGycUh4p9aawuc6fsXHHYDpIL8s3vAvwIDAQABoDow\nOAYJKoZIhvcNAQkOMSswKTAnBgNVHREEIDAeggtiaW5nby5waXp6YYIPd3d3LmJp\nbmdvLnBpenphMA0GCSqGSIb3DQEBCwUAA4IBAQBwOLKv+PO5hSJkgqS6wL/wRqLh\nQ1zbcHRHAjRjnpRz06cDvN3X3aPI+lpKSNFCI0A1oKJG7JNtgxX3Est66cuO8ESQ\nPIb6WWN7/xlVlBCe7ZkjAFgN6JurFdclwCp/NI5wBCwj1yb3Ar5QQMFIZOezIgTI\nAWkQSfCmgkB96d6QlDWgidYDDjcsXugQveOQRPlHr0TsElu47GakxZdJCFZU+WPM\nodQQf5SaqiIK2YaH1dWO//4KpTS9QoTy1+mmAa27apHcmz6X6+G5dvpHZ1qH14V0\nJoMWIK+39HRPq6mDo1UMVet/xFUUrG/H7/tFlYIDVbSpVlpVAFITd/eQkaW/\n-----END CERTIFICATE REQUEST-----\n")
       expect(result.state).to eq("issued")
       expect(result.authority_identifier).to eq("letsencrypt")
       expect(result.auto_renew).to be(false)
-      expect(result.created_at).to eq("2016-06-11T18:47:08Z")
-      expect(result.updated_at).to eq("2016-06-11T18:47:37Z")
-      expect(result.expires_on).to eq("2016-09-09")
+      expect(result.created_at).to eq("2020-06-18T18:54:17Z")
+      expect(result.updated_at).to eq("2020-06-18T19:10:14Z")
+      expect(result.expires_at).to eq("2020-09-16T18:10:13Z")
     end
 
     context "when the certificate does not exist" do
@@ -229,7 +231,7 @@ describe Dnsimple::Client, ".certificates" do
 
   describe "#purchase_letsencrypt_certificate" do
     let(:account_id) { 1010 }
-    let(:domain_id)  { "example.com" }
+    let(:domain_id)  { "bingo.pizza" }
     let(:contact_id) { 100 }
 
     before do
@@ -262,9 +264,9 @@ describe Dnsimple::Client, ".certificates" do
       result = response.data
       expect(result).to be_a(Dnsimple::Struct::CertificatePurchase)
 
-      expect(result.id).to eq(300)
-      expect(result.certificate_id).to eq(300)
-      expect(result.state).to eq("requesting")
+      expect(result.id).to eq(101967)
+      expect(result.certificate_id).to eq(101967)
+      expect(result.state).to eq("new")
       expect(result.auto_renew).to be(false)
     end
 
@@ -282,8 +284,8 @@ describe Dnsimple::Client, ".certificates" do
 
   describe "#issue_letsencrypt_certificate" do
     let(:account_id) { 1010 }
-    let(:domain_id)  { "example.com" }
-    let(:certificate_id) { 200 }
+    let(:domain_id)  { "bingo.pizza" }
+    let(:certificate_id) { 101967 }
 
     before do
       stub_request(:post, %r{/v2/#{account_id}/domains/#{domain_id}/certificates/letsencrypt/#{certificate_id}/issue})
@@ -304,9 +306,9 @@ describe Dnsimple::Client, ".certificates" do
       result = response.data
       expect(result).to be_a(Dnsimple::Struct::Certificate)
 
-      expect(result.id).to eq(200)
-      expect(result.domain_id).to eq(300)
-      expect(result.common_name).to eq("www.example.com")
+      expect(result.id).to eq(101967)
+      expect(result.domain_id).to eq(289333)
+      expect(result.common_name).to eq("www.bingo.pizza")
       expect(result.alternate_names).to eq([])
       expect(result.years).to eq(1)
       expect(result.csr).to be(nil)
@@ -340,8 +342,8 @@ describe Dnsimple::Client, ".certificates" do
 
   describe "#purchase_letsencrypt_certificate_renewal" do
     let(:account_id) { 1010 }
-    let(:domain_id)  { "example.com" }
-    let(:certificate_id) { 200 }
+    let(:domain_id)  { "bingo.pizza" }
+    let(:certificate_id) { 101967 }
 
     before do
       stub_request(:post, %r{/v2/#{account_id}/domains/#{domain_id}/certificates/letsencrypt/#{certificate_id}/renewals})
@@ -371,9 +373,9 @@ describe Dnsimple::Client, ".certificates" do
       result = response.data
       expect(result).to be_a(Dnsimple::Struct::CertificateRenewal)
 
-      expect(result.id).to eq(999)
+      expect(result.id).to eq(65082)
       expect(result.old_certificate_id).to eq(certificate_id)
-      expect(result.new_certificate_id).to eq(300)
+      expect(result.new_certificate_id).to eq(101972)
       expect(result.state).to eq("new")
     end
 
@@ -391,9 +393,9 @@ describe Dnsimple::Client, ".certificates" do
 
   describe "#issue_letsencrypt_certificate_renewal" do
     let(:account_id) { 1010 }
-    let(:domain_id)  { "example.com" }
-    let(:certificate_id) { 300 }
-    let(:certificate_renewal_id) { 999 }
+    let(:domain_id)  { "bingo.pizza" }
+    let(:certificate_id) { 101972 }
+    let(:certificate_renewal_id) { 65082 }
 
     before do
       stub_request(:post, %r{/v2/#{account_id}/domains/#{domain_id}/certificates/letsencrypt/#{certificate_id}/renewals/#{certificate_renewal_id}/issue})
@@ -414,9 +416,9 @@ describe Dnsimple::Client, ".certificates" do
       result = response.data
       expect(result).to be_a(Dnsimple::Struct::Certificate)
 
-      expect(result.id).to eq(300)
-      expect(result.domain_id).to eq(300)
-      expect(result.common_name).to eq("www.example.com")
+      expect(result.id).to eq(101972)
+      expect(result.domain_id).to eq(289333)
+      expect(result.common_name).to eq("www.bingo.pizza")
       expect(result.alternate_names).to eq([])
       expect(result.years).to eq(1)
       expect(result.csr).to be(nil)

data/spec/dnsimple/client/client_service_spec.rb

@@ -1,10 +1,12 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Dnsimple::Client::ClientService do
 
   describe "#paginate" do
     service_class = Class.new(Dnsimple::Client::ClientService) do
-      Item = Class.new(Dnsimple::Struct::Base) do
+      Item = Class.new(Dnsimple::Struct::Base) do # rubocop:disable Lint/ConstantDefinitionInBlock
         attr_accessor :id
       end
 

data/spec/dnsimple/client/contacts_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Dnsimple::Client, ".contacts" do
@@ -84,13 +86,13 @@ describe Dnsimple::Client, ".contacts" do
 
   describe "#create_contact" do
     let(:account_id) { 1010 }
+    let(:attributes) { { first_name: "Simone", last_name: "Carletti", address1: "Italian Street", city: "Rome", state_province: "RM", postal_code: "00171", country: "IT", email: "example@example.com", phone: "+393391234567" } }
 
     before do
       stub_request(:post, %r{/v2/#{account_id}/contacts$})
           .to_return(read_http_fixture("createContact/created.http"))
     end
 
-    let(:attributes) { { first_name: "Simone", last_name: "Carletti", address1: "Italian Street", city: "Rome", state_province: "RM", postal_code: "00171", country: "IT", email: "example@example.com", phone: "+393391234567" } }
 
     it "builds the correct request" do
       subject.create_contact(account_id, attributes)
@@ -151,13 +153,13 @@ describe Dnsimple::Client, ".contacts" do
 
   describe "#update_contact" do
     let(:account_id) { 1010 }
+    let(:attributes) { { first_name: "Updated" } }
 
     before do
       stub_request(:patch, %r{/v2/#{account_id}/contacts/.+$})
           .to_return(read_http_fixture("updateContact/success.http"))
     end
 
-    let(:attributes) { { first_name: "Updated" } }
 
     it "builds the correct request" do
       subject.update_contact(account_id, contact_id = 1, attributes)

data/spec/dnsimple/client/domains_collaborators_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Dnsimple::Client, ".domains" do
@@ -61,7 +63,7 @@ describe Dnsimple::Client, ".domains" do
     let(:account_id) { 1010 }
     let(:domain_id)  { "example.com" }
 
-    context "invite user already registered on DNSimple" do
+    context "when inviting a user already registered on DNSimple" do
       before do
         stub_request(:post, %r{/v2/#{account_id}/domains/#{domain_id}/collaborators$})
             .to_return(read_http_fixture("addCollaborator/success.http"))
@@ -91,7 +93,7 @@ describe Dnsimple::Client, ".domains" do
       end
     end
 
-    context "invite not registered on DNSimple" do
+    context "when inviting a user not registered on DNSimple" do
       before do
         stub_request(:post, %r{/v2/#{account_id}/domains/#{domain_id}/collaborators$})
             .to_return(read_http_fixture("addCollaborator/invite-success.http"))

data/spec/dnsimple/client/domains_delegation_signer_records_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Dnsimple::Client, ".domains" do
@@ -97,6 +99,7 @@ describe Dnsimple::Client, ".domains" do
 
   describe "#create_delegation_signer_record" do
     let(:account_id) { 1010 }
+    let(:attributes) { { algorithm: "13", digest: "ABC123", digest_type: "2", keytag: "1111" } }
     let(:domain_id) { "example.com" }
 
     before do
@@ -104,7 +107,6 @@ describe Dnsimple::Client, ".domains" do
           .to_return(read_http_fixture("createDelegationSignerRecord/created.http"))
     end
 
-    let(:attributes) { { algorithm: "13", digest: "ABC123", digest_type: "2", keytag: "1111" } }
 
     it "builds the correct request" do
       subject.create_delegation_signer_record(account_id, domain_id, attributes)

data/spec/dnsimple/client/domains_dnssec_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Dnsimple::Client, ".domains" do

data/spec/dnsimple/client/domains_email_forwards_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Dnsimple::Client, ".domains" do
@@ -97,6 +99,7 @@ describe Dnsimple::Client, ".domains" do
 
   describe "#create_email_forward" do
     let(:account_id) { 1010 }
+    let(:attributes) { { from: "jim", to: "jim@another.com" } }
     let(:domain_id) { "example.com" }
 
     before do
@@ -104,7 +107,6 @@ describe Dnsimple::Client, ".domains" do
           .to_return(read_http_fixture("createEmailForward/created.http"))
     end
 
-    let(:attributes) { { from: "jim", to: "jim@another.com" } }
 
     it "builds the correct request" do
       subject.create_email_forward(account_id, domain_id, attributes)
@@ -127,7 +129,7 @@ describe Dnsimple::Client, ".domains" do
   describe "#email_forward" do
     let(:account_id) { 1010 }
     let(:domain_id) { "example.com" }
-    let(:email_forward_id) { 17706 }
+    let(:email_forward_id) { 41872 }
 
     before do
       stub_request(:get, %r{/v2/#{account_id}/domains/#{domain_id}/email_forwards.+$})
@@ -147,12 +149,12 @@ describe Dnsimple::Client, ".domains" do
 
       result = response.data
       expect(result).to be_a(Dnsimple::Struct::EmailForward)
-      expect(result.id).to eq(17706)
-      expect(result.domain_id).to eq(228963)
-      expect(result.from).to eq("jim@a-domain.com")
-      expect(result.to).to eq("jim@another.com")
-      expect(result.created_at).to eq("2016-02-04T14:26:50Z")
-      expect(result.updated_at).to eq("2016-02-04T14:26:50Z")
+      expect(result.id).to eq(41872)
+      expect(result.domain_id).to eq(235146)
+      expect(result.from).to eq("example@dnsimple.xyz")
+      expect(result.to).to eq("example@example.com")
+      expect(result.created_at).to eq("2021-01-25T13:54:40Z")
+      expect(result.updated_at).to eq("2021-01-25T13:54:40Z")
     end
 
     context "when the email forward does not exist" do