dm-accepts_nested_attributes_for 1.2.0

data/spec/shared/one_to_many_spec.rb

@@ -0,0 +1,107 @@
+describe "every accessible one_to_many association", :shared => true do
+
+  it "should allow to update an existing task via Project#tasks_attributes" do
+    project = Project.create :name => 'trippings'
+    task = Task.create(:project => project, :name => 'write specs')
+
+    Project.all.size.should == 1
+    Task.all.size.should    == 1
+
+    project.tasks_attributes = [{ :id => task.id, :name => 'write more specs' }]
+    project.save.should be_true
+
+    Project.all.size.should == 1
+    Task.all.size.should    == 1
+    Task.first.name.should  == 'write more specs'
+  end
+
+  it "should return the attributes written with Project#task_attributes= from the Project#task_attributes reader" do
+    project = Project.new :name => 'trippings'
+    project.tasks_attributes.should be_nil
+    project.tasks_attributes = [{ :name => 'write specs' }]
+    project.tasks_attributes.should == [{ :name => 'write specs' }]
+  end
+
+end
+
+describe "every accessible one_to_many association with a valid reject_if proc", :shared => true do
+
+  it "should not allow to create a new task via Project#tasks_attributes" do
+    project = Project.create :name => 'trippings'
+
+    Project.all.size.should == 1
+    Task.all.size.should    == 0
+
+    project.tasks_attributes = [{ :name => 'write specs' }]
+    project.save.should be_true
+
+    Project.all.size.should == 1
+    Task.all.size.should    == 0
+  end
+
+end
+
+describe "every accessible one_to_many association with no reject_if proc", :shared => true do
+
+  it "should allow to create a new task via Project#tasks_attributes" do
+    project = Project.create :name => 'trippings'
+
+    Project.all.size.should == 1
+    Task.all.size.should    == 0
+
+    project.tasks_attributes = [{ :name => 'write specs' }]
+
+    Project.all.size.should == 1
+    Task.all.size.should    == 0
+
+    project.save.should be_true
+
+    Project.all.size.should == 1
+    Task.all.size.should    == 1
+    Task.first.name.should  == 'write specs'
+  end
+
+end
+
+describe "every accessible one_to_many association with :allow_destroy => false", :shared => true do
+
+  it "should not allow to delete an existing task via Profile#tasks_attributes" do
+    project = Project.create :name => 'trippings'
+
+    task = Task.create(:project => project, :name => 'write specs')
+
+    Project.all.size.should == 1
+    Task.all.size.should    == 1
+
+    project.tasks_attributes = [{ :id => task.id, :_delete => true }]
+    project.save
+
+    Project.all.size.should == 1
+    Task.all.size.should    == 1
+  end
+
+end
+
+describe "every accessible one_to_many association with :allow_destroy => true", :shared => true do
+
+  it "should allow to delete an existing task via Profile#tasks_attributes" do
+    project = Project.create :name => 'trippings'
+
+    task = Task.create(:project => project, :name => 'write specs')
+    project.tasks.reload
+
+    Project.all.size.should == 1
+    Task.all.size.should    == 1
+
+    project.tasks_attributes = [{ :id => task.id, :_delete => true }]
+
+    Project.all.size.should == 1
+    Task.all.size.should    == 1
+
+    project.save
+
+    Project.all.size.should == 1
+    Task.all.size.should    == 0
+  end
+
+end

data/spec/shared/one_to_one_composite_spec.rb

@@ -0,0 +1,114 @@
+describe "every accessible one_to_one composite association", :shared => true do
+
+  it "should allow to update an existing profile via Person#profile_attributes" do
+    person = Person.create(:audit_id => 1, :name => 'Martin')
+    profile = Profile.create(:person => person, :nick => 'snusnu')
+    person.reload
+
+    Person.all.size.should    == 1
+    Profile.all.size.should   == 1
+
+    person.profile_attributes = { :nick => 'still snusnu somehow' }
+    person.save.should be_true
+
+    Person.all.size.should    == 1
+    Profile.all.size.should   == 1
+    Profile.first.nick.should == 'still snusnu somehow'
+  end
+
+  it "should return the attributes written to Person#profile_attributes from the Person#profile_attributes reader" do
+    person = Person.new :name => 'Martin'
+    person.profile_attributes.should be_nil
+    person.profile_attributes = { :nick => 'snusnu' }
+    person.profile_attributes.should == { :nick => 'snusnu' }
+  end
+
+end
+
+describe "every accessible one_to_one composite association with a valid reject_if proc", :shared => true do
+
+  it "should not allow to create a new profile via Person#profile_attributes" do
+    Person.all.size.should  == 0
+    Profile.all.size.should == 0
+
+    person = Person.new(:audit_id => 1, :name => 'Martin')
+    person.profile_attributes = { :nick => 'snusnu' }
+    person.save
+
+    Person.all.size.should  == 1
+    Profile.all.size.should == 0
+  end
+
+end
+
+describe "every accessible one_to_one composite association with no reject_if proc", :shared => true do
+
+  [[:new, 'a new'], [:create, 'an existing']].each do |ctor, ctor_desc|
+    it "should allow to create a new profile via Person#profile_attributes on #{ctor_desc} person" do
+      Person.all.size.should    == 0
+      Profile.all.size.should   == 0
+
+      person = Person.send(ctor, :audit_id => 1, :name => 'Martin')
+      person.profile_attributes = { :nick => 'snusnu' }
+
+      Person.all.size.should    == (ctor == :new ? 0 : 1)
+      Profile.all.size.should   == 0
+
+      person.save.should be_true
+
+      Person.all.size.should    == 1
+      Profile.all.size.should   == 1
+      Profile.first.nick.should == 'snusnu'
+      Profile.first.person_audit_id.should == person.audit_id
+    end
+  end
+
+end
+
+describe "every accessible one_to_one composite association with :allow_destroy => false", :shared => true do
+
+  it "should not allow to delete an existing profile via Person#profile_attributes" do
+    person = Person.create(:audit_id => 1, :name => 'Martin')
+
+    profile = Profile.create(:person => person, :nick => 'snusnu')
+    person.reload
+
+    Person.all.size.should  == 1
+    Profile.all.size.should == 1
+
+    person.profile_attributes = { :_delete => true }
+
+    Person.all.size.should  == 1
+    Profile.all.size.should == 1
+
+    person.save
+
+    Person.all.size.should  == 1
+    Profile.all.size.should == 1
+  end
+
+end
+
+describe "every accessible one_to_one composite association with :allow_destroy => true", :shared => true do
+
+  it "should allow to delete an existing profile via Person#profile_attributes" do
+    person = Person.create(:audit_id => 1, :name => 'Martin')
+
+    profile = Profile.create(:person => person, :nick => 'snusnu')
+    person.profile = profile
+
+    Person.all.size.should  == 1
+    Profile.all.size.should == 1
+
+    person.profile_attributes = { :_delete => true }
+
+    Person.all.size.should  == 1
+    Profile.all.size.should == 1
+
+    person.save
+
+    Person.all.size.should  == 1
+    Profile.all.size.should == 0
+  end
+
+end

data/spec/shared/one_to_one_spec.rb

@@ -0,0 +1,111 @@
+describe "every accessible one_to_one association", :shared => true do
+
+  it "should allow to update an existing profile via Person#profile_attributes" do
+    person = Person.create :name => 'Martin'
+    profile = Profile.create(:person => person, :nick => 'snusnu')
+    person.reload
+
+    Person.all.size.should    == 1
+    Profile.all.size.should   == 1
+
+    person.profile_attributes = { :id => profile.id, :nick => 'still snusnu somehow' }
+    person.save.should be_true
+
+    Person.all.size.should    == 1
+    Profile.all.size.should   == 1
+    Profile.first.nick.should == 'still snusnu somehow'
+  end
+
+  it "should return the attributes written to Person#profile_attributes from the Person#profile_attributes reader" do
+    person = Person.new :name => 'Martin'
+    person.profile_attributes.should be_nil
+    person.profile_attributes = { :nick => 'snusnu' }
+    person.profile_attributes.should == { :nick => 'snusnu' }
+  end
+
+end
+
+describe "every accessible one_to_one association with a valid reject_if proc", :shared => true do
+
+  it "should not allow to create a new profile via Person#profile_attributes" do
+    Person.all.size.should  == 0
+    Profile.all.size.should == 0
+
+    person = Person.new :name => 'Martin'
+    person.profile_attributes = { :nick => 'snusnu' }
+    person.save
+
+    Person.all.size.should  == 1
+    Profile.all.size.should == 0
+  end
+
+end
+
+describe "every accessible one_to_one association with no reject_if proc", :shared => true do
+
+  it "should allow to create a new profile via Person#profile_attributes" do
+    Person.all.size.should    == 0
+    Profile.all.size.should   == 0
+
+    person = Person.new :name => 'Martin'
+    person.profile_attributes = { :nick => 'snusnu' }
+
+    Person.all.size.should    == 0
+    Profile.all.size.should   == 0
+
+    person.save.should be_true
+
+    Person.all.size.should    == 1
+    Profile.all.size.should   == 1
+    Profile.first.nick.should == 'snusnu'
+  end
+
+end
+
+describe "every accessible one_to_one association with :allow_destroy => false", :shared => true do
+
+  it "should not allow to delete an existing profile via Person#profile_attributes" do
+    person = Person.create :name => 'Martin'
+
+    profile = Profile.create(:person => person, :nick => 'snusnu')
+    person.reload
+
+    Person.all.size.should  == 1
+    Profile.all.size.should == 1
+
+    person.profile_attributes = { :id => profile.id, :_delete => true }
+
+    Person.all.size.should  == 1
+    Profile.all.size.should == 1
+
+    person.save
+
+    Person.all.size.should  == 1
+    Profile.all.size.should == 1
+  end
+
+end
+
+describe "every accessible one_to_one association with :allow_destroy => true", :shared => true do
+
+  it "should allow to delete an existing profile via Person#profile_attributes" do
+    person = Person.create :name => 'Martin'
+
+    profile = Profile.create(:person => person, :nick => 'snusnu')
+    person.profile = profile
+
+    Person.all.size.should  == 1
+    Profile.all.size.should == 1
+
+    person.profile_attributes = { :id => profile.id, :_delete => true }
+
+    Person.all.size.should  == 1
+    Profile.all.size.should == 1
+
+    person.save
+
+    Person.all.size.should  == 1
+    Profile.all.size.should == 0
+  end
+
+end

data/spec/spec.opts

@@ -0,0 +1,4 @@
+--colour
+--loadby random
+--format profile
+--backtrace

data/spec/spec_helper.rb

@@ -0,0 +1,50 @@
+require 'dm-core/spec/setup'
+require 'dm-core/spec/lib/pending_helpers'
+require 'dm-core/spec/lib/spec_helper'
+
+require 'dm-accepts_nested_attributes'
+
+require 'shared/many_to_many_spec'
+require 'shared/many_to_one_spec'
+require 'shared/one_to_many_spec'
+require 'shared/one_to_one_spec'
+require 'shared/many_to_many_composite_spec'
+require 'shared/many_to_one_composite_spec'
+require 'shared/one_to_many_composite_spec'
+require 'shared/one_to_one_composite_spec'
+
+DataMapper::Spec.setup
+
+HAS_M2M_SUPPORT = !%w[in_memory yaml].include?(DataMapper::Spec.adapter_name)
+
+module ConstraintSupport
+
+  def constraint(type)
+    if DataMapper.const_defined?('Constraints')
+      { :constraint => type }
+    else
+      {}
+    end
+  end
+
+end
+
+Spec::Runner.configure do |config|
+
+  config.include(DataMapper::Spec::PendingHelpers)
+
+  config.after(:all) do
+    if DataMapper.respond_to?(:auto_migrate_down!, true)
+      DataMapper.send(:auto_migrate_down!, DataMapper::Spec.adapter.name)
+    end
+
+    DataMapper::Spec.cleanup_models
+  end
+
+  config.after(:suite) do
+    if DataMapper.respond_to?(:auto_migrate_down!, true)
+      DataMapper.send(:auto_migrate_down!, DataMapper::Spec.adapter.name)
+    end
+  end
+
+end

data/spec/update_dirty_spec.rb

@@ -0,0 +1,113 @@
+require 'spec_helper'
+
+describe "Person.has(n, :memberships)" do
+
+  before(:all) do
+    class ::Project
+      include DataMapper::Resource
+      extend ConstraintSupport
+    
+      property :id, Integer, :key => true, :min => 0
+      property :name, String, :required => true
+
+      has n, :memberships, constraint(:destroy)
+      has n, :people, :through => :memberships
+    end
+
+    class ::Person
+      include DataMapper::Resource
+      extend ConstraintSupport
+
+      property :id, Integer, :key => true, :min => 0
+      property :name, String, :required => true
+
+      has n, :memberships, constraint(:destroy)
+      has n, :projects, :through => :memberships
+      accepts_nested_attributes_for :memberships, :allow_destroy => true
+    end
+
+    class ::Membership
+      include DataMapper::Resource
+
+      property :person_id, Integer, :key => true, :min => 0
+      property :project_id, Integer, :key => true, :min => 0
+      property :role, String, :required => true
+
+      belongs_to :person
+      belongs_to :project
+
+      accepts_nested_attributes_for :person
+      accepts_nested_attributes_for :project
+    end
+
+    DataMapper.auto_migrate!
+  end
+
+  before(:each) do
+    Membership.all.destroy!
+    Person.all.destroy!
+    Project.all.destroy!
+  end
+
+  it "should allow to update an existing person, membership and project at the same time" do
+    person = Person.create(:id => 1, :name => 'snusnu')
+    project = Project.create(:id => 10, :name => 'dm-accepts_nested_attributes')
+    membership = Membership.create(:person => person, :project => project, :role => 'maintainer')
+
+    params = {
+      :name => 'Martin',
+      :memberships_attributes => [{
+        :project_id => project.id,
+        :role => 'still maintainer',
+        :project_attributes => { :name => 'tripping' }
+      }]
+    }
+
+    # Quick ordered hash hack: make sure the name attribute is updated first,
+    # making the person dirty.
+    class << params
+      def each
+        [:name, :memberships_attributes].each { |key| yield key, self[key] }
+      end
+    end
+
+    person.update params
+
+    Person.all.size.should == 1
+    Project.all.size.should == 1
+    Membership.all.size.should == 1
+
+    Person.first.attributes.should == { :id => 1, :name => 'Martin' }
+    Project.first.attributes.should == { :id => 10, :name => 'tripping' }
+    Membership.first.attributes.should == { :person_id => 1, :project_id => 10, :role => 'still maintainer' }
+  end
+
+  it "should not allow to update a dirty parent resource with nested attributes" do
+    person = Person.create(:id => 1, :name => 'snusnu')
+    project = Project.create(:id => 10, :name => 'dm-accepts_nested_attributes')
+    membership = Membership.create(:person => person, :project => project, :role => 'maintainer')
+
+    params = {
+      :name => 'Martin',
+      :memberships_attributes => [{
+        :project_id => project.id,
+        :role => 'still maintainer',
+        :person_attributes => { :name => 'Martin Gamsjaeger' }
+      }]
+    }
+    class <<params
+      def each
+        [:name, :memberships_attributes].each { |key| yield key, self[key] }
+      end
+    end
+    lambda { person.update(params) }.should raise_error(DataMapper::UpdateConflictError)
+
+    Person.all.size.should == 1
+    Project.all.size.should == 1
+    Membership.all.size.should == 1
+
+    Person.first.attributes.should == { :id => 1, :name => 'snusnu' }
+    Project.first.attributes.should == { :id => 10, :name => 'dm-accepts_nested_attributes' }
+    Membership.first.attributes.should == { :person_id => 1, :project_id => 10, :role => 'maintainer' }
+  end
+end