dm-accepts_nested_attributes_for 1.2.0

data/spec/shared/many_to_one_composite_spec.rb

@@ -0,0 +1,160 @@
+describe "every accessible many_to_one composite association", :shared => true do
+
+  it "should allow to update an existing person via Membership#person_attributes" do
+    Person.all.size.should     == 0
+    Project.all.size.should    == 0
+    Membership.all.size.should == 0
+
+    person = Person.create(:audit_id => 1, :name => 'Martin')
+    project = Project.create(:audit_id => 2, :name => 'trippings')
+    membership = Membership.new(:role => 'maintainer')
+    membership.person = person
+    membership.project = project
+    membership.save.should be_true
+
+    Person.all.size.should     == 1
+    Project.all.size.should    == 1
+    Membership.all.size.should == 1
+    Person.first.name.should   == 'Martin'
+
+    membership.person_attributes = { :id => person.id, :audit_id => person.audit_id, :name => 'Martin Gamsjaeger' }
+    membership.save.should be_true
+
+    Person.all.size.should     == 1
+    Project.all.size.should    == 1
+    Membership.all.size.should == 1
+    Person.first.name.should   == 'Martin Gamsjaeger'
+  end
+
+  it "should return the attributes written to Membership#person_attributes from the Membership#person_attributes reader" do
+    membership = Membership.new(:role => 'maintainer')
+    membership.person_attributes.should be_nil
+    membership.person_attributes = { :name => 'Martin' }
+    membership.person_attributes.should == { :name => 'Martin' }
+  end
+
+end
+
+describe "every accessible many_to_one composite association with a valid reject_if proc", :shared => true do
+
+  it "should not allow to create a new person via Membership#person_attributes" do
+    project = Project.create(:audit_id => 2, :name => 'trippings')
+
+    Person.all.size.should     == 0
+    Project.all.size.should    == 1
+    Membership.all.size.should == 0
+
+    membership = Membership.new(:project_id => project.id, :project_audit_id => project.audit_id, :role => 'maintainer')
+    membership.person_attributes = { :name => 'Martin' }
+
+    Person.all.size.should     == 0
+    Project.all.size.should    == 1
+    Membership.all.size.should == 0
+
+    begin
+      membership.save.should be(false)
+    rescue
+      # swallow native FK errors which is basically like expecting save to be false
+    end
+  end
+
+end
+
+describe "every accessible many_to_one composite association with no reject_if proc", :shared => true do
+
+  it "should allow to create a new person via Membership#person_attributes" do
+    project = Project.create(:audit_id => 2, :name => 'trippings')
+
+    Person.all.size.should     == 0
+    Project.all.size.should    == 1
+    Membership.all.size.should == 0
+
+    membership = Membership.new(:project_id => project.id, :project_audit_id => project.audit_id, :role => 'maintainer')
+    membership.person_attributes = { :audit_id => 1, :name => 'Martin' }
+
+    Person.all.size.should     == 0
+    Project.all.size.should    == 1
+    Membership.all.size.should == 0
+
+    membership.save.should be_true
+
+    Person.all.size.should     == 1
+    Project.all.size.should    == 1
+    Membership.all.size.should == 1
+    Person.first.name.should   == 'Martin'
+  end
+
+end
+
+describe "every accessible many_to_one composite association with :allow_destroy => false", :shared => true do
+
+  it "should not allow to delete an existing person via Membership#person_attributes" do
+    person = Person.create(:audit_id => 1, :name => 'Martin')
+    project = Project.create(:audit_id => 2, :name => 'trippings')
+    membership = Membership.new(:role => 'maintainer')
+    membership.person = person
+    membership.project = project
+    membership.save
+
+    Person.all.size.should     == 1
+    Project.all.size.should    == 1
+    Membership.all.size.should == 1
+
+    membership.person_attributes = {
+      :id => person.id,
+      :audit_id => person.audit_id,
+      :_delete => true
+    }
+
+    Person.all.size.should     == 1
+    Project.all.size.should    == 1
+    Membership.all.size.should == 1
+
+    membership.save
+
+    Person.all.size.should     == 1
+    Project.all.size.should    == 1
+    Membership.all.size.should == 1
+  end
+
+end
+
+describe "every accessible many_to_one composite association with :allow_destroy => true", :shared => true do
+
+  it "should allow to delete an existing person via Membership#person_attributes" do
+    Person.all.size.should     == 0
+    Project.all.size.should    == 0
+    Membership.all.size.should == 0
+
+    person = Person.create(:audit_id => 1, :name => 'Martin')
+    project = Project.create(:audit_id => 2, :name => 'trippings')
+
+    membership = Membership.new(:role => 'maintainer')
+    membership.person = person
+    membership.project = project
+    membership.save.should be_true
+
+    Person.all.size.should     == 1
+    Project.all.size.should    == 1
+    Membership.all.size.should == 1
+
+    membership.person_attributes = {
+      :id => person.id,
+      :audit_id => person.audit_id,
+      :_delete => true
+    }
+
+    Person.all.size.should     == 1
+    Project.all.size.should    == 1
+    Membership.all.size.should == 1
+
+    membership.save
+
+    Person.all.size.should     == 0
+    Project.all.size.should    == 1
+
+    # TODO also test this behavior in situations where setting the FK to nil is allowed
+
+  end
+
+end

data/spec/shared/many_to_one_spec.rb

@@ -0,0 +1,130 @@
+describe "every accessible many_to_one association", :shared => true do
+
+  it "should allow to update an existing person via Profile#person_attributes" do
+    Profile.all.size.should == 0
+    Person.all.size.should  == 0
+
+    profile = Profile.new :nick => 'snusnu'
+    person = Person.create(:name => 'Martin')
+    profile.person = person
+    profile.save.should be_true
+
+    Profile.all.size.should  == 1
+    Person.all.size.should   == 1
+    Person.first.name.should == 'Martin'
+
+    profile.person_attributes = { :id => person.id, :name => 'Martin Gamsjaeger' }
+    profile.save.should be_true
+
+    Profile.all.size.should  == 1
+    Person.all.size.should   == 1
+    Person.first.name.should == 'Martin Gamsjaeger'
+  end
+
+  it "should return the attributes written to Profile#person_attributes from the Profile#person_attributes reader" do
+    profile = Profile.new :nick => 'snusnu'
+    profile.person_attributes.should be_nil
+    profile.person_attributes = { :name => 'Martin' }
+    profile.person_attributes.should == { :name => 'Martin' }
+  end
+
+end
+
+describe "every accessible many_to_one association with a valid reject_if proc", :shared => true do
+
+  it "should not allow to create a new person via Profile#person_attributes" do
+    Profile.all.size.should == 0
+    Person.all.size.should  == 0
+
+    profile = Profile.new :nick => 'snusnu'
+    profile.person_attributes = { :name => 'Martin' }
+
+    Profile.all.size.should == 0
+    Person.all.size.should  == 0
+
+    begin
+      profile.save.should be(false)
+    rescue
+      # swallow native FK errors which is basically like expecting save to be false
+    end
+  end
+
+end
+
+describe "every accessible many_to_one association with no reject_if proc", :shared => true do
+
+  it "should allow to create a new person via Profile#person_attributes" do
+    Profile.all.size.should == 0
+    Person.all.size.should  == 0
+
+    profile = Profile.new :nick => 'snusnu'
+    profile.person_attributes = { :name => 'Martin' }
+
+    Profile.all.size.should == 0
+    Person.all.size.should  == 0
+
+    profile.save.should be_true
+
+    Profile.all.size.should  == 1
+    Person.all.size.should   == 1
+    Person.first.name.should == 'Martin'
+  end
+
+end
+
+describe "every accessible many_to_one association with :allow_destroy => false", :shared => true do
+
+  it "should not allow to delete an existing person via Profile#person_attributes" do
+    Profile.all.size.should == 0
+    Person.all.size.should  == 0
+
+    person = Person.create(:name => 'Martin')
+    profile = Profile.new :nick => 'snusnu'
+    profile.person = person
+    profile.save
+
+    Profile.all.size.should == 1
+    Person.all.size.should  == 1
+
+    profile.person_attributes = { :id => person.id, :_delete => true }
+
+    Profile.all.size.should == 1
+    Person.all.size.should  == 1
+
+    profile.save
+
+    Profile.all.size.should == 1
+    Person.all.size.should  == 1
+  end
+
+end
+
+describe "every accessible many_to_one association with :allow_destroy => true", :shared => true do
+
+  it "should allow to delete an existing person via Profile#person_attributes" do
+    Profile.all.size.should == 0
+    Person.all.size.should  == 0
+
+    person = Person.create(:name => 'Martin')
+
+    profile = Profile.new :nick => 'snusnu'
+    profile.person = person
+    profile.save.should be_true
+
+    Profile.all.size.should == 1
+    Person.all.size.should  == 1
+
+    profile.person_attributes = { :id => person.id, :_delete => true }
+
+    Profile.all.size.should == 1
+    Person.all.size.should  == 1
+
+    profile.save
+
+    Person.all.size.should  == 0
+
+    # TODO also test this behavior in situations where setting the FK to nil is allowed
+
+  end
+
+end

data/spec/shared/one_to_many_composite_spec.rb

@@ -0,0 +1,159 @@
+describe "every accessible one_to_many composite association", :shared => true do
+
+  it "should allow to update an existing membership via Person#memberships_attributes" do
+    Person.all.size.should     == 0
+    Project.all.size.should    == 0
+    Membership.all.size.should == 0
+
+    person = Person.create(:audit_id => 1, :name => 'snusnu')
+    project = Project.create(:audit_id => 2, :name => 'dm-accepts_nested_attributes')
+    membership = Membership.create(:person => person, :project => project, :role => 'maintainer')
+
+    Person.all.size.should     == 1
+    Project.all.size.should    == 1
+    Membership.all.size.should == 1
+
+    person.memberships_attributes = [{ :project_id => project.id, :project_audit_id => project.audit_id, :role => 'still maintainer' }]
+    person.save
+
+    Person.all.size.should     == 1
+    Project.all.size.should    == 1
+    Membership.all.size.should == 1
+
+    Membership.first.role.should == 'still maintainer'
+  end
+
+  it "should return the attributes written with Person#memberships_attributes= from the Person#memberships_attributes reader" do
+    person = Person.create(:audit_id => 1, :name => 'snusnu')
+    person.memberships_attributes.should be_nil
+    person.memberships_attributes = [{ :role => 'maintainer' }]
+    person.memberships_attributes.should == [{ :role => 'maintainer' }]
+  end
+
+end
+
+describe "every accessible one_to_many composite association with a valid reject_if proc", :shared => true do
+
+  it "should not allow to create a new membership via Project#memberships_attributes" do
+    person  = Person.create(:audit_id => 1, :name => 'snusnu')
+    project = Project.create(:audit_id => 2, :name => 'trippings')
+
+    Person.all.size.should     == 1
+    Project.all.size.should    == 1
+    Membership.all.size.should == 0
+
+    person.memberships_attributes = [{
+      :project_id => project.id,
+      :project_audit_id => project.audit_id,
+      :role => 'contributor'
+    }]
+    project.save.should be_true
+
+    Person.all.size.should     == 1
+    Project.all.size.should    == 1
+    Membership.all.size.should == 0
+  end
+
+end
+
+describe "every accessible one_to_many composite association with no reject_if proc", :shared => true do
+
+  it "should allow to create a new membership via Person#memberships_attributes" do
+    person  = Person.create(:audit_id => 1, :name => 'snusnu')
+    project = Project.create(:audit_id => 2, :name => 'trippings')
+
+    Person.all.size.should     == 1
+    Project.all.size.should    == 1
+    Membership.all.size.should == 0
+
+    person.memberships_attributes = [{
+      :project_id => project.id,
+      :project_audit_id => project.audit_id,
+      :role => 'contributor'
+    }]
+
+    Person.all.size.should     == 1
+    Project.all.size.should    == 1
+    Membership.all.size.should == 0
+
+    person.save.should be_true
+
+    Person.all.size.should     == 1
+    Project.all.size.should    == 1
+    Membership.all.size.should == 1
+
+    membership = Membership.first
+    membership.person.should  == person
+    membership.project.should == project
+    membership.role.should    == 'contributor'
+  end
+
+end
+
+describe "every accessible one_to_many composite association with :allow_destroy => false", :shared => true do
+
+  it "should not allow to delete an existing membership via Person#memberships_attributes" do
+    person  = Person.create(:audit_id => 1, :name => 'snusnu')
+    project = Project.create(:audit_id => 2, :name => 'trippings')
+
+    membership = Membership.create(:person => person, :project => project, :role => 'contributor')
+
+    Person.all.size.should     == 1
+    Project.all.size.should    == 1
+    Membership.all.size.should == 1
+
+    person.memberships_attributes = [{
+      :project_id => project.id,
+      :project_audit_id => project.audit_id,
+      :_delete => true
+    }]
+    person.save
+
+    Person.all.size.should     == 1
+    Project.all.size.should    == 1
+    Membership.all.size.should == 1
+
+    Person.first.attributes.should     == { :id => person.id, :audit_id => 1, :name => 'snusnu' }
+    Project.first.attributes.should    == { :id => project.id, :audit_id => 2, :name => 'trippings' }
+    Membership.first.attributes.should == {
+      :person_id => person.id,
+      :person_audit_id => person.audit_id,
+      :project_id => project.id,
+      :project_audit_id => project.audit_id,
+      :role => 'contributor'
+    }
+  end
+
+end
+
+describe "every accessible one_to_many composite association with :allow_destroy => true", :shared => true do
+
+  it "should allow to delete an existing membership via Person#membership_attributes" do
+    person  = Person.create(:audit_id => 1, :name => 'snusnu')
+    project = Project.create(:audit_id => 2, :name => 'trippings')
+
+    membership = Membership.create(:person => person, :project => project, :role => 'maintainer')
+    person.memberships.reload
+
+    Person.all.size.should     == 1
+    Project.all.size.should    == 1
+    Membership.all.size.should == 1
+
+    person.memberships_attributes = [{
+      :project_id => project.id,
+      :project_audit_id => project.audit_id,
+      :_delete => true
+    }]
+
+    Person.all.size.should     == 1
+    Project.all.size.should    == 1
+    Membership.all.size.should == 1
+
+    person.save
+
+    Person.all.size.should     == 1
+    Project.all.size.should    == 1
+    Membership.all.size.should == 0
+  end
+
+end