dima-jeweler 0.9.2 → 1.2.0

data/test/jeweler/commands/version/test_bump_major.rb

@@ -14,6 +14,7 @@ class Jeweler
           command.update_version
         end
       end
+
     end
   end
 end

data/test/test_application.rb

@@ -48,6 +48,10 @@ class TestApplication < Test::Unit::TestCase
   end
 
   def build_generator(name = 'zomg', options = {:testing_framework => :shoulda})
+    stub(Git).global_config() do
+      {'user.name' => 'John Doe', 'user.email' => 'john@example.com', 'github.user' => 'johndoe', 'github.token' => 'yyz'}
+    end
+
     Jeweler::Generator.new(name, options)
   end
 
@@ -73,9 +77,35 @@ class TestApplication < Test::Unit::TestCase
     end
   end
 
+  context "called with --invalid-argument" do
+    setup do
+      @generator = build_generator
+      stub(@generator).run
+      stub(Jeweler::Generator).new { raise "Shouldn't have made this far"}
+
+      assert_nothing_raised do
+        @result = run_application("--invalid-argument")
+      end
+    end
+
+    should_exit_with_code 1
+
+    should 'display invalid argument' do
+      assert_match '--invalid-argument', @stderr
+    end
+
+    should 'display usage on stderr' do
+      assert_match 'Usage:', @stderr
+    end
+
+    should 'not display anything on stdout' do
+      assert_equal '', @stdout.squeeze.strip
+    end
+  end
+
   context "when called with repo name" do
     setup do
-      @options = {:testing_framework => :shoulda}
+      @options = {:testing_framework => :shoulda, :documentation_framework => :rdoc}
       @generator = build_generator('zomg', @options)
 
       stub(@generator).run

data/test/test_gemspec_helper.rb

@@ -32,5 +32,9 @@ class TestGemspecHelper < Test::Unit::TestCase
     should "make valid spec" do
       assert @helper.valid?
     end
+
+    should "parse" do
+      @helper.parse
+    end
   end
 end

data/test/test_generator.rb

@@ -2,6 +2,10 @@ require 'test_helper'
 
 class TestGenerator < Test::Unit::TestCase
   def build_generator(testing_framework = nil, options = {})
+    stub(Git).global_config() do
+      {'user.name' => 'John Doe', 'user.email' => 'john@example.com', 'github.user' => 'johndoe', 'github.token' => 'yyz'}
+    end
+
     options[:testing_framework] = testing_framework
     Jeweler::Generator.new('the-perfect-gem', options)
   end
@@ -27,8 +31,12 @@ class TestGenerator < Test::Unit::TestCase
       assert_equal 'the-perfect-gem', build_generator.target_dir
     end
 
-    should "have TODO as default summary" do
-      assert_equal "TODO", build_generator.summary
+    should "have default summary" do
+      assert_equal "TODO: one-line summary of your gem", build_generator.summary
+    end
+
+    should "have default description" do
+      assert_equal "TODO: longer description of your gem", build_generator.description
     end
 
     should "not create repo by default" do
@@ -39,6 +47,14 @@ class TestGenerator < Test::Unit::TestCase
       assert ! build_generator.should_use_cucumber
     end
 
+    should "not use reek by default" do
+      assert ! build_generator.should_use_reek
+    end
+
+    should "not use roodi by default" do
+      assert ! build_generator.should_use_roodi
+    end
+
     should "raise error for invalid testing frameworks" do
       assert_raise ArgumentError do
         build_generator(:zomg_invalid)
@@ -46,134 +62,105 @@ class TestGenerator < Test::Unit::TestCase
     end
   end
 
-  context "test_or_spec" do
-    should "be test for shoulda" do
-      assert_equal 'test', build_generator(:shoulda).test_or_spec
-    end
-
-    should "be test for testunit" do
-      assert_equal 'test', build_generator(:testunit).test_or_spec
-    end
-
-    should "be test for minitest" do
-      assert_equal 'test', build_generator(:minitest).test_or_spec
-    end
-
-    should "be spec for bacon" do
-      assert_equal 'spec', build_generator(:bacon).test_or_spec
-    end
-
-    should "be spec for rspec" do
-      assert_equal 'spec', build_generator(:rspec).test_or_spec
-    end
-
-    should "be example for micronaut" do
-      assert_equal 'example', build_generator(:micronaut).test_or_spec
-    end
+  should "have the correct git remote" do
+    assert_equal 'git@github.com:johndoe/the-perfect-gem.git', build_generator.git_remote
   end
 
-  context "test_dir" do
-    should "be test for shoulda" do
-      assert_equal 'test', build_generator(:shoulda).test_dir
-    end
-
-    should "be test for testunit" do
-      assert_equal 'test', build_generator(:testunit).test_dir
-    end
-
-    should "be test for minitest" do
-      assert_equal 'test', build_generator(:minitest).test_dir
-    end
-
-    should "be spec for bacon" do
-      assert_equal 'spec', build_generator(:bacon).test_dir
-    end
-
-    should "be spec for rspec" do
-      assert_equal 'spec', build_generator(:rspec).test_dir
-    end
-
-    should "be examples for micronaut" do
-      assert_equal 'examples', build_generator(:micronaut).test_dir
-    end
+  should "have the correct project homepage" do
+    assert_equal 'http://github.com/johndoe/the-perfect-gem', build_generator.project_homepage
   end
 
-  context "default_task" do
-    should "be test for shoulda" do
-      assert_equal 'test', build_generator(:shoulda).default_task
-    end
-
-    should "be test for testunit" do
-      assert_equal 'test', build_generator(:testunit).default_task
-    end
-
-    should "be test for minitest" do
-      assert_equal 'test', build_generator(:minitest).default_task
-    end
-
-    should "be spec for bacon" do
-      assert_equal 'spec', build_generator(:bacon).default_task
-    end
-
-    should "be spec for rspec" do
-      assert_equal 'spec', build_generator(:rspec).default_task
-    end
-
-    should "be examples for micronaut" do
-      assert_equal 'examples', build_generator(:micronaut).default_task
-    end
+  should "have the correct constant name" do
+    assert_equal "ThePerfectGem", build_generator.constant_name
   end
 
-  context "feature_support_require" do
-    should "be test/unit/assertions for shoulda" do
-      assert_equal 'test/unit/assertions', build_generator(:shoulda).feature_support_require
-    end
-
-    should "be test/unit/assertions for testunit" do
-      assert_equal 'test/unit/assertions', build_generator(:testunit).feature_support_require
-    end
-
-    should "be mini/test for minitest" do
-      assert_equal 'mini/test', build_generator(:minitest).feature_support_require
-    end
-
-    should "be test/unit/assertions for bacon" do
-      assert_equal 'test/unit/assertions', build_generator(:bacon).feature_support_require
-    end
+  should "have the correct file name prefix" do
+    assert_equal "the_perfect_gem", build_generator.file_name_prefix
+  end
 
-    should "be spec/expectations for rspec" do
-      assert_equal 'spec/expectations', build_generator(:rspec).feature_support_require
-    end
+  should "have the correct require name" do
+    assert_equal "the-perfect-gem", build_generator.require_name
+  end
 
-    should "be micronaut/expectations for micronaut" do
-      assert_equal 'micronaut/expectations', build_generator(:micronaut).feature_support_require
-    end
+  should "have the correct lib file name" do
+    assert_equal "the-perfect-gem.rb", build_generator.lib_filename
   end
 
-  context "feature_support_extend" do
-    should "be Test::Unit::Assertions for shoulda" do
-      assert_equal 'Test::Unit::Assertions', build_generator(:shoulda).feature_support_extend
+  def self.should_have_generator_attribute(attribute, value)
+    should "have #{value} for #{attribute}" do
+      assert_equal value, build_generator(@framework).send(attribute)
     end
+  end
 
-    should "be Test::Unit::Assertions for testunit" do
-      assert_equal 'Test::Unit::Assertions', build_generator(:testunit).feature_support_extend
-    end
+  context "shoulda" do
+    setup { @framework = :shoulda }
+    should_have_generator_attribute :test_task, 'test'
+    should_have_generator_attribute :test_dir, 'test'
+    should_have_generator_attribute :default_task, 'test'
+    should_have_generator_attribute :feature_support_require, 'test/unit/assertions'
+    should_have_generator_attribute :feature_support_extend, 'Test::Unit::Assertions'
+    should_have_generator_attribute :test_pattern, 'test/**/*_test.rb'
+    should_have_generator_attribute :test_filename, 'the-perfect-gem_test.rb'
+    should_have_generator_attribute :test_helper_filename, 'test_helper.rb'
+  end
 
-    should "be Mini::Test::Assertions for minitest" do
-      assert_equal 'Mini::Test::Assertions', build_generator(:minitest).feature_support_extend
-    end
+  context "testunit" do
+    setup { @framework = :testunit }
+    should_have_generator_attribute :test_task, 'test'
+    should_have_generator_attribute :test_dir, 'test'
+    should_have_generator_attribute :default_task, 'test'
+    should_have_generator_attribute :feature_support_require, 'test/unit/assertions'
+    should_have_generator_attribute :feature_support_extend, 'Test::Unit::Assertions'
+    should_have_generator_attribute :test_pattern, 'test/**/*_test.rb'
+    should_have_generator_attribute :test_filename, 'the-perfect-gem_test.rb'
+    should_have_generator_attribute :test_helper_filename, 'test_helper.rb'
+  end
 
-    should "be Test::Unit::Assertions for bacon" do
-      assert_equal 'Test::Unit::Assertions', build_generator(:bacon).feature_support_extend
-    end
+  context "minitest" do
+    setup { @framework = :minitest }
+    should_have_generator_attribute :test_task, 'test'
+    should_have_generator_attribute :test_dir, 'test'
+    should_have_generator_attribute :default_task, 'test'
+    should_have_generator_attribute :feature_support_require, 'mini/test'
+    should_have_generator_attribute :feature_support_extend, 'Mini::Test::Assertions'
+    should_have_generator_attribute :test_pattern, 'test/**/*_test.rb'
+    should_have_generator_attribute :test_filename, 'the-perfect-gem_test.rb'
+    should_have_generator_attribute :test_helper_filename, 'test_helper.rb'
+  end
 
-    should "be nil for rspec" do
-      assert_equal nil, build_generator(:rspec).feature_support_extend
-    end
+  context "bacon" do
+    setup { @framework = :bacon }
+    should_have_generator_attribute :test_task, 'spec'
+    should_have_generator_attribute :test_dir, 'spec'
+    should_have_generator_attribute :default_task, 'spec'
+    should_have_generator_attribute :feature_support_require, 'test/unit/assertions'
+    should_have_generator_attribute :feature_support_extend, 'Test::Unit::Assertions'
+    should_have_generator_attribute :test_pattern, 'spec/**/*_spec.rb'
+    should_have_generator_attribute :test_filename, 'the-perfect-gem_spec.rb'
+    should_have_generator_attribute :test_helper_filename, 'spec_helper.rb'
+  end
 
-    should "be Micronaut::Matchers for micronaut" do
-      assert_equal 'Micronaut::Matchers', build_generator(:micronaut).feature_support_extend
-    end
+  context "rspec" do
+    setup { @framework = :rspec }
+    should_have_generator_attribute :test_task, 'spec'
+    should_have_generator_attribute :test_dir, 'spec'
+    should_have_generator_attribute :default_task, 'spec'
+    should_have_generator_attribute :feature_support_require, 'spec/expectations'
+    should_have_generator_attribute :feature_support_extend, nil
+    should_have_generator_attribute :test_pattern, 'spec/**/*_spec.rb'
+    should_have_generator_attribute :test_filename, 'the-perfect-gem_spec.rb'
+    should_have_generator_attribute :test_helper_filename, 'spec_helper.rb'
   end
 
+  context "micronaut" do
+    setup { @framework = :micronaut }
+    should_have_generator_attribute :test_task, 'examples'
+    should_have_generator_attribute :test_dir, 'examples'
+    should_have_generator_attribute :default_task, 'examples'
+    should_have_generator_attribute :feature_support_require, 'micronaut/expectations'
+    should_have_generator_attribute :feature_support_extend, 'Micronaut::Matchers'
+    should_have_generator_attribute :test_pattern, 'examples/**/*_example.rb'
+    should_have_generator_attribute :test_filename, 'the-perfect-gem_example.rb'
+    should_have_generator_attribute :test_helper_filename, 'example_helper.rb'
+  end
 end

data/test/test_generator_initialization.rb

@@ -0,0 +1,156 @@
+require 'test_helper'
+
+class TestGeneratorInitialization < Test::Unit::TestCase
+  def setup
+    @project_name = 'the-perfect-gem'
+    @git_name = 'foo'
+    @git_email = 'bar@example.com'
+    @github_user = 'technicalpickles'
+    @github_token = 'zomgtoken'
+  end
+
+  def stub_git_config(options = {})
+    stub(Git).global_config() { options }
+  end
+
+  def valid_git_config
+    { 'user.name' => @git_name, 'user.email' => @git_email, 'github.user' => @github_user, 'github.token' => @github_token }
+  end
+
+  context "given a nil github repo name" do
+    setup do
+      stub_git_config
+
+      @block = lambda {  }
+    end
+
+    should 'raise NoGithubRepoNameGiven' do
+      assert_raise Jeweler::NoGitHubRepoNameGiven do
+        Jeweler::Generator.new(nil)
+      end
+    end
+  end
+
+  context "without git user's name set" do
+    setup do
+      stub_git_config 'user.email' => @git_email
+    end
+
+    should 'raise an NoGitUserName' do
+      assert_raise Jeweler::NoGitUserName do
+        Jeweler::Generator.new(@project_name)
+      end
+    end
+  end
+
+  context "without git user's email set" do
+    setup do
+      stub_git_config 'user.name' => @git_name
+    end
+
+    should 'raise NoGitUserName' do
+      assert_raise Jeweler::NoGitUserEmail do
+        Jeweler::Generator.new(@project_name)
+      end
+    end
+  end
+
+  context "without github username set" do
+    setup do
+      stub_git_config 'user.email' => @git_email, 'user.name' => @git_name
+    end
+
+    should 'raise NotGitHubUser' do
+      assert_raise Jeweler::NoGitHubUser do
+        Jeweler::Generator.new(@project_name)
+      end
+    end
+  end
+  
+  context "without github token set" do
+    setup do
+      stub_git_config 'user.name' => @git_name, 'user.email' => @git_email, 'github.user' => @github_user
+    end
+
+    should 'raise NoGitHubToken if creating repo' do
+      assert_raise Jeweler::NoGitHubToken do
+        Jeweler::Generator.new(@project_name, :create_repo => true)
+      end
+    end
+  end
+
+  context "default configuration" do
+    setup do
+      stub_git_config valid_git_config
+      @generator = Jeweler::Generator.new(@project_name)
+    end
+
+    should "use shoulda for testing" do
+      assert_equal :shoulda, @generator.testing_framework
+    end
+
+    should "use rdoc for documentation" do
+      assert_equal :rdoc, @generator.documentation_framework
+    end
+
+    should "set todo in summary" do
+      assert_match /todo/i, @generator.summary
+    end
+
+    should "set todo in description" do
+      assert_match /todo/i, @generator.description
+    end
+
+    should "set target directory to the project name" do
+      assert_equal @project_name, @generator.target_dir
+    end
+
+    should "set user's name from git config" do
+      assert_equal @git_name, @generator.user_name
+    end
+
+    should "set email from git config" do
+      assert_equal @git_email, @generator.user_email
+    end
+
+    should "set a github remote based on username and project name" do
+      assert_equal "git@github.com:#{@github_user}/#{@project_name}.git", @generator.git_remote
+    end
+
+    should "set github username from git config" do
+      assert_equal @github_user, @generator.github_username
+    end
+
+    should "set project name as the-perfect-gem" do
+      assert_equal @project_name, @generator.project_name
+    end
+  end
+
+  context "using yard" do
+    setup do
+      @generator = Jeweler::Generator.new(@project_name, :documentation_framework => :yard)
+    end
+
+    should "set the doc_task to yardoc" do
+      assert_equal "yardoc", @generator.doc_task
+    end
+
+  end
+
+  context "using yard" do
+    setup do
+      @generator = Jeweler::Generator.new(@project_name, :documentation_framework => :rdoc)
+    end
+
+    should "set the doc_task to rdoc" do
+      assert_equal "rdoc", @generator.doc_task
+    end
+  end
+
+  context "using options" do
+    should "set documentation" do
+      generator = Jeweler::Generator.new(@project_name, :documentation_framework => :yard)
+      assert_equal :yard, generator.documentation_framework
+    end
+  end
+end