dima-jeweler 0.9.2 → 1.2.0

data/test/jeweler/commands/test_release_to_rubyforge.rb

@@ -1,43 +1,27 @@
 require 'test_helper'
 
-class RubyForgeStub
-  attr_accessor :userconfig
-  
-  def initialize
-    @userconfig = {}
-  end
-end
-
 class Jeweler
   module Commands
     class TestReleaseToRubyforge < Test::Unit::TestCase
+      def self.subject
+        Jeweler::Commands::ReleaseToRubyforge.new
+      end
 
-      context "after running when rubyforge_project is defined" do
+      rubyforge_command_context "rubyforge_project is defined in gemspec and package exists on rubyforge" do
         setup do
-          @rubyforge = RubyForgeStub.new
           stub(@rubyforge).configure
           stub(@rubyforge).login
           stub(@rubyforge).add_release("MyRubyForgeProjectName", "zomg", "1.2.3", "pkg/zomg-1.2.3.gem")
 
-          @gempsec = Object.new
           stub(@gemspec).description {"The zomg gem rocks."}
           stub(@gemspec).rubyforge_project {"MyRubyForgeProjectName"}
           stub(@gemspec).name {"zomg"}
           
-          @gemspec_helper = Object.new
           stub(@gemspec_helper).write
           stub(@gemspec_helper).gem_path {'pkg/zomg-1.2.3.gem'}
           stub(@gemspec_helper).update_version('1.2.3')
 
-          @output = StringIO.new
-
-          @command                = Jeweler::Commands::ReleaseToRubyforge.new
-          @command.output         = @output
-          @command.repo           = @repo
-          @command.gemspec        = @gemspec
-          @command.gemspec_helper = @gemspec_helper
           @command.version        = '1.2.3'
-          @command.ruby_forge     = @rubyforge
 
           @command.run
         end
@@ -49,7 +33,7 @@ class Jeweler
         should "login" do
           assert_received(@rubyforge) {|rubyforge| rubyforge.login }
         end
-        
+
         should "set release notes" do
           assert_equal "The zomg gem rocks.", @rubyforge.userconfig["release_notes"]
         end
@@ -61,80 +45,112 @@ class Jeweler
         should "add release" do
           assert_received(@rubyforge) {|rubyforge| rubyforge.add_release("MyRubyForgeProjectName", "zomg", "1.2.3", "pkg/zomg-1.2.3.gem") }
         end
-        
+      end
+
+      rubyforge_command_context "rubyforge_project is defined in gemspec and package does not exist on rubyforge" do
+        setup do
+          stub(@rubyforge).configure
+          stub(@rubyforge).login
+          stub(@rubyforge).scrape_config
+          stub(@rubyforge).add_release("MyRubyForgeProjectName", "zomg", "1.2.3", "pkg/zomg-1.2.3.gem") {
+            raise "no <package_id> configured for <zomg>"
+          }
+
+          stub(@gemspec).description {"The zomg gem rocks."}
+          stub(@gemspec).rubyforge_project {"MyRubyForgeProjectName"}
+          stub(@gemspec).name {"zomg"}
+          
+          stub(@gemspec_helper).write
+          stub(@gemspec_helper).gem_path {'pkg/zomg-1.2.3.gem'}
+          stub(@gemspec_helper).update_version('1.2.3')
+
+          @command.version        = '1.2.3'
+        end
+
+        should "raise MissingRubyForgePackageError" do
+          assert_raises Jeweler::MissingRubyForgePackageError do
+            @command.run
+          end
+        end
       end
       
-      context "after running when rubyforge_project is not defined in Jeweler::Tasks block in Rakefile" do
+      rubyforge_command_context "rubyforge_project is not defined in gemspec" do
         setup do
-          @rubyforge = RubyForgeStub.new
           stub(@rubyforge).configure
           stub(@rubyforge).login
           stub(@rubyforge).add_release(nil, "zomg", "1.2.3", "pkg/zomg-1.2.3.gem")
 
-          @gempsec = Object.new
           stub(@gemspec).description {"The zomg gem rocks."}
           stub(@gemspec).rubyforge_project { nil }
           stub(@gemspec).name {"zomg"}
           
-          @gemspec_helper = Object.new
           stub(@gemspec_helper).write
           stub(@gemspec_helper).gem_path {'pkg/zomg-1.2.3.gem'}
           stub(@gemspec_helper).update_version('1.2.3')
 
-          @output = StringIO.new
-
-          @command                = Jeweler::Commands::ReleaseToRubyforge.new
-          @command.output         = @output
-          @command.repo           = @repo
-          @command.gemspec        = @gemspec
-          @command.gemspec_helper = @gemspec_helper
           @command.version        = '1.2.3'
-          @command.ruby_forge     = @rubyforge
         end
         
-        should "raise error" do
-          assert_raises RuntimeError, /not configured/i do
+        should "raise NoRubyForgeProjectConfigured" do
+          assert_raises Jeweler::NoRubyForgeProjectInGemspecError do
             @command.run
           end
         end
       end
       
-      context "after running when rubyforge_project is not defined in ~/.rubyforge/auto_config.yml" do
+      rubyforge_command_context "after running when rubyforge_project is not defined in ~/.rubyforge/auto_config.yml" do
         setup do
-          @rubyforge = RubyForgeStub.new
           stub(@rubyforge).configure
           stub(@rubyforge).login
           stub(@rubyforge).add_release("some_project_that_doesnt_exist", "zomg", "1.2.3", "pkg/zomg-1.2.3.gem") do
             raise RuntimeError, "no <group_id> configured for <some_project_that_doesnt_exist>"
           end
 
-          @gempsec = Object.new
+          @rubyforge.autoconfig['package_ids'] = { 'zomg' => 1234 }
+
           stub(@gemspec).description {"The zomg gem rocks."}
           stub(@gemspec).rubyforge_project { "some_project_that_doesnt_exist" }
           stub(@gemspec).name {"zomg"}
           
-          @gemspec_helper = Object.new
           stub(@gemspec_helper).write
           stub(@gemspec_helper).gem_path {'pkg/zomg-1.2.3.gem'}
           stub(@gemspec_helper).update_version('1.2.3')
 
-          @output = StringIO.new
-
-          @command                = Jeweler::Commands::ReleaseToRubyforge.new
-          @command.output         = @output
-          @command.repo           = @repo
-          @command.gemspec        = @gemspec
-          @command.gemspec_helper = @gemspec_helper
           @command.version        = '1.2.3'
-          @command.ruby_forge     = @rubyforge
         end
         
-        should "raise error" do
-          assert_raises RuntimeError, /no <group_id> configured/i do
+        should "raise RubyForgeProjectNotConfiguredError" do
+          assert_raises RubyForgeProjectNotConfiguredError do
             @command.run
           end
         end
       end
+
+      build_command_context "build for jeweler" do
+        setup do
+          @command = Jeweler::Commands::ReleaseToRubyforge.build_for(@jeweler)
+        end
+
+        should "assign gemspec helper" do
+          assert_equal @gemspec_helper, @command.gemspec_helper
+        end
+
+        should "assign gemspec" do
+          assert_equal @gemspec, @command.gemspec
+        end
+
+        should "assign version" do
+          assert_equal @version, @command.version
+        end
+
+        should "assign output" do
+          assert_equal @output, @command.output
+        end
+
+        should "assign rubyforge" do
+          assert_equal @rubyforge, @command.rubyforge
+        end
+      end
       
     end
   end

data/test/jeweler/commands/test_setup_rubyforge.rb

@@ -0,0 +1,182 @@
+require 'test_helper'
+
+class Jeweler
+  module Commands
+    class TestSetupRubyforge < Test::Unit::TestCase
+      def self.subject
+        Jeweler::Commands::SetupRubyforge.new
+      end
+
+      rubyforge_command_context "package_exists?" do
+        setup do
+          stub(@gemspec).name { 'zomg' }
+        end
+
+        should "be true if rubyforge.lookup doesn't cause an Error" do
+          mock(@rubyforge).lookup('package', 'zomg')
+
+          assert @command.package_exists?
+        end
+
+        should "be false if rubyforge.lookup raises an error like: no <package_id> configured for <zomg>" do
+          mock(@rubyforge).lookup('package', 'zomg') do
+            raise RuntimeError, "no <package_id> configured for <zomg>"
+          end
+
+          assert ! @command.package_exists?
+        end
+
+        should "reraise any other Errors" do
+          mock(@rubyforge).lookup('package', 'zomg') do
+            raise RuntimeError, 'burnination!'
+          end
+
+          assert_raises RuntimeError, 'burnination!' do
+            @command.package_exists?
+          end
+        end
+      end
+
+      rubyforge_command_context "create_package" do
+        setup do
+          stub(@gemspec).name { 'zomg' }
+        end
+
+        context "when everything is happy" do
+          setup do
+            stub(@gemspec).rubyforge_project { 'myproject' }
+            stub(@rubyforge).create_package('myproject', 'zomg')
+
+            @command.create_package
+          end
+
+          should "create zomg package to myproject on rubyforge" do
+            assert_received(@rubyforge) {|rubyforge| rubyforge.create_package('myproject', 'zomg') }
+          end
+
+        end
+
+        context "when rubyforge project not existing or being setup in ~/.rubyforge/autoconfig.yml" do
+          setup do
+            stub(@gemspec).rubyforge_project { 'myproject' }
+            stub(@rubyforge).create_package('myproject', 'zomg')do
+              raise RuntimeError, "no <group_id> configured for <myproject>"
+            end
+          end
+
+          should "raise RubyForgeProjectNotConfiguredError" do
+            assert_raises RubyForgeProjectNotConfiguredError do
+              @command.create_package
+            end
+          end 
+        end
+      end
+
+
+      rubyforge_command_context "rubyforge_project defined in gemspec and project existing on rubyforge" do
+        setup do
+          stub(@rubyforge).configure
+          stub(@rubyforge).login
+
+          stub(@gemspec).name { 'zomg' }
+          stub(@gemspec).rubyforge_project { 'myproject' }
+
+          stub(@command).package_exists? { false }
+          stub(@command).create_package
+          @command.run
+        end
+
+        should "configure rubyforge" do
+          assert_received(@rubyforge) {|rubyforge| rubyforge.configure}
+        end
+
+        should "login to rubyforge" do
+          assert_received(@rubyforge) {|rubyforge| rubyforge.login}
+        end
+
+        should "create zomg package to myproject on rubyforge" do
+          assert_received(@command) {|command| command.create_package }
+        end
+      end
+
+      rubyforge_command_context "rubyforge_project defined in gemspec, project and project already existing on rubyforge" do
+        setup do
+          stub(@rubyforge).configure
+          stub(@rubyforge).login
+
+
+          stub(@gemspec).name { 'zomg' }
+          stub(@gemspec).rubyforge_project { 'myproject' }
+
+          stub(@command).package_exists? { true }
+          dont_allow(@command).create_package
+          @command.run
+        end
+
+        should "configure rubyforge" do
+          assert_received(@rubyforge) {|rubyforge| rubyforge.configure}
+        end
+
+        should "login to rubyforge" do
+          assert_received(@rubyforge) {|rubyforge| rubyforge.login}
+        end
+
+      end
+      
+
+      rubyforge_command_context "rubyforge_project is not defined" do
+        setup do
+          stub(@gemspec).name { 'zomg' }
+          stub(@gemspec).rubyforge_project { nil }
+        end
+
+        should "raise NoRubyForgeProjectConfigured" do
+          assert_raises Jeweler::NoRubyForgeProjectInGemspecError do
+            @command.run
+          end
+        end
+      end
+
+      rubyforge_command_context "rubyforge project not existing or being setup in ~/.rubyforge/autoconfig.yml" do
+        setup do
+          stub(@rubyforge).configure
+          stub(@rubyforge).login
+
+          stub(@gemspec).name { 'zomg' }
+          stub(@gemspec).rubyforge_project { 'some_project_that_doesnt_exist' }
+
+          stub(@command).package_exists? { false }
+          stub(@command).create_package do
+            raise RubyForgeProjectNotConfiguredError, 'some_project_that_doesnt_exist'
+          end
+        end
+
+        should "raise RubyForgeProjectNotConfiguredError" do
+          assert_raises RubyForgeProjectNotConfiguredError do
+            @command.run
+          end
+        end 
+
+      end
+
+      build_command_context "build for jeweler" do
+        setup do
+          @command = Jeweler::Commands::SetupRubyforge.build_for(@jeweler)
+        end
+
+        should "assign gemspec" do
+          assert_equal @gemspec, @command.gemspec
+        end
+
+        should "assign output" do
+          assert_equal @output, @command.output
+        end
+
+        should "assign rubyforge" do
+          assert_equal @rubyforge, @command.rubyforge
+        end
+      end
+
+    end
+  end
+end

data/test/jeweler/commands/test_validate_gemspec.rb

@@ -0,0 +1,27 @@
+require 'test_helper'
+
+class Jeweler
+  module Commands
+    class TestValidateGemspec < Test::Unit::TestCase
+
+      build_command_context "build context" do
+        setup do
+          @command = Jeweler::Commands::ValidateGemspec.build_for(@jeweler)
+        end
+
+        should "assign gemspec_helper" do
+          assert_same @gemspec_helper, @command.gemspec_helper
+        end
+
+        should "assign output" do
+          assert_same @output, @command.output
+        end
+
+        should "return Jeweler::Commands::ValidateGemspec" do
+          assert_kind_of Jeweler::Commands::ValidateGemspec, @command
+        end
+
+      end
+    end
+  end
+end

data/test/jeweler/commands/test_write_gemspec.rb

@@ -53,6 +53,40 @@ class Jeweler
 
       end
 
+      build_command_context "building for jeweler" do
+        setup do
+          @command = Jeweler::Commands::WriteGemspec.build_for(@jeweler)
+        end
+
+        should "assign base_dir" do
+          assert_same @base_dir, @command.base_dir
+        end
+
+        should "assign gemspec" do
+          assert_same @gemspec, @command.gemspec
+        end
+
+        should "assign version" do
+          assert_same @version, @command.version
+        end
+
+        should "assign output" do
+          assert_same @output, @command.output
+        end
+
+        should "assign gemspec_helper" do
+          assert_same @gemspec_helper, @command.gemspec_helper
+        end
+
+        should "assign version_helper" do
+          assert_same @version_helper, @command.version_helper
+        end
+
+        should "return WriteGemspec" do
+          assert_kind_of Jeweler::Commands::WriteGemspec, @command
+        end
+      end
+
     end
   end
 end

data/test/jeweler/commands/version/test_base.rb

@@ -0,0 +1,32 @@
+require 'test_helper'
+
+class Jeweler
+  module Commands
+    module Version
+      class TestBase < Test::Unit::TestCase
+        build_command_context "build for jeweler" do
+          setup do
+            @command = Jeweler::Commands::Version::Base.build_for(@jeweler)
+          end
+
+          should "assign repo" do
+            assert_equal @repo, @command.repo
+          end
+
+          should "assign version_helper" do
+            assert_equal @version_helper, @command.version_helper
+          end
+
+          should "assign gemspec" do
+            assert_equal @gemspec, @command.gemspec
+          end
+
+          should"assign commit" do
+            assert_equal @commit, @command.commit
+          end
+        end
+      end
+    end
+  end
+end
+