devise-jdguyot 1.2.rc

data/test/models/recoverable_test.rb

@@ -0,0 +1,190 @@
+require 'test_helper'
+
+class RecoverableTest < ActiveSupport::TestCase
+
+  def setup
+    setup_mailer
+  end
+
+  test 'should not generate reset password token after creating a record' do
+    assert_nil new_user.reset_password_token
+  end
+
+  test 'should never generate the same reset password token for different users' do
+    reset_password_tokens = []
+    3.times do
+      user = create_user
+      user.send_reset_password_instructions
+      token = user.reset_password_token
+      assert !reset_password_tokens.include?(token)
+      reset_password_tokens << token
+    end
+  end
+
+  test 'should reset password and password confirmation from params' do
+    user = create_user
+    user.reset_password!('123456789', '987654321')
+    assert_equal '123456789', user.password
+    assert_equal '987654321', user.password_confirmation
+  end
+
+  test 'should reset password and save the record' do
+    assert create_user.reset_password!('123456789', '123456789')
+  end
+
+  test 'should clear reset password token while reseting the password' do
+    user = create_user
+    assert_nil user.reset_password_token
+
+    user.send_reset_password_instructions
+    assert_present user.reset_password_token
+    assert user.reset_password!('123456789', '123456789')
+    assert_nil user.reset_password_token
+  end
+
+  test 'should not clear reset password token if record is invalid' do
+    user = create_user
+    user.send_reset_password_instructions
+    assert_present user.reset_password_token
+    assert_not user.reset_password!('123456789', '987654321')
+    assert_present user.reset_password_token
+  end
+
+  test 'should not reset password with invalid data' do
+    user = create_user
+    user.stubs(:valid?).returns(false)
+    assert_not user.reset_password!('123456789', '987654321')
+  end
+
+  test 'should reset reset password token and send instructions by email' do
+    user = create_user
+    assert_email_sent do
+      token = user.reset_password_token
+      user.send_reset_password_instructions
+      assert_not_equal token, user.reset_password_token
+    end
+  end
+
+  test 'should find a user to send instructions by email' do
+    user = create_user
+    reset_password_user = User.send_reset_password_instructions(:email => user.email)
+    assert_equal reset_password_user, user
+  end
+
+  test 'should return a new record with errors if user was not found by e-mail' do
+    reset_password_user = User.send_reset_password_instructions(:email => "invalid@email.com")
+    assert_not reset_password_user.persisted?
+    assert_equal "not found", reset_password_user.errors[:email].join
+  end
+
+  test 'should find a user to send instructions by authentication_keys' do
+    swap Devise, :authentication_keys => [:username, :email] do
+      user = create_user
+      reset_password_user = User.send_reset_password_instructions(:email => user.email, :username => user.username)
+      assert_equal reset_password_user, user
+    end
+  end
+
+  test 'should require all reset_password_keys' do
+      swap Devise, :reset_password_keys => [:username, :email] do
+          user = create_user
+          reset_password_user = User.send_reset_password_instructions(:email => user.email)
+          assert_not reset_password_user.persisted?
+          assert_equal "can't be blank", reset_password_user.errors[:username].join
+      end
+  end
+
+  test 'should reset reset_password_token before send the reset instructions email' do
+    user = create_user
+    token = user.reset_password_token
+    reset_password_user = User.send_reset_password_instructions(:email => user.email)
+    assert_not_equal token, user.reload.reset_password_token
+  end
+
+  test 'should send email instructions to the user reset his password' do
+    user = create_user
+    assert_email_sent do
+      User.send_reset_password_instructions(:email => user.email)
+    end
+  end
+
+  test 'should find a user to reset his password based on reset_password_token' do
+    user = create_user
+    user.send :generate_reset_password_token!
+
+    reset_password_user = User.reset_password_by_token(:reset_password_token => user.reset_password_token)
+    assert_equal reset_password_user, user
+  end
+
+  test 'should a new record with errors if no reset_password_token is found' do
+    reset_password_user = User.reset_password_by_token(:reset_password_token => 'invalid_token')
+    assert_not reset_password_user.persisted?
+    assert_equal "is invalid", reset_password_user.errors[:reset_password_token].join
+  end
+
+  test 'should a new record with errors if reset_password_token is blank' do
+    reset_password_user = User.reset_password_by_token(:reset_password_token => '')
+    assert_not reset_password_user.persisted?
+    assert_match "can't be blank", reset_password_user.errors[:reset_password_token].join
+  end
+
+  test 'should reset successfully user password given the new password and confirmation' do
+    user = create_user
+    old_password = user.password
+    user.send :generate_reset_password_token!
+
+    reset_password_user = User.reset_password_by_token(
+      :reset_password_token => user.reset_password_token,
+      :password => 'new_password',
+      :password_confirmation => 'new_password'
+    )
+    user.reload
+
+    assert_not user.valid_password?(old_password)
+    assert user.valid_password?('new_password')
+  end
+
+  test 'should not reset reset password token during reset_password_within time' do
+    swap Devise, :reset_password_within => 1.hour do
+      user = create_user
+      user.send_reset_password_instructions
+      3.times do
+        token = user.reset_password_token
+        user.send_reset_password_instructions
+        assert_equal token, user.reset_password_token
+      end
+    end
+  end
+
+  test 'should reset reset password token after reset_password_within time' do
+    swap Devise, :reset_password_within => 1.hour do
+      user = create_user
+      user.reset_password_sent_at = 2.days.ago
+      token = user.reset_password_token
+      user.send_reset_password_instructions
+      assert_not_equal token, user.reset_password_token
+    end
+  end
+
+  test 'should not reset password after reset_password_within time' do
+    swap Devise, :reset_password_within => 1.hour do
+      user = create_user
+      old_password = user.password
+      user.send :generate_reset_password_token!
+      user.reset_password_sent_at = 2.days.ago
+      user.save!
+
+      reset_password_user = User.reset_password_by_token(
+        :reset_password_token => user.reset_password_token,
+        :password => 'new_password',
+        :password_confirmation => 'new_password'
+      )
+      user.reload
+
+      assert user.valid_password?(old_password)
+      assert_not user.valid_password?('new_password')
+      assert_equal "is invalid", reset_password_user.errors[:reset_password_token].join
+    end
+  end
+
+end

data/test/models/rememberable_test.rb

@@ -0,0 +1,279 @@
+require 'test_helper'
+
+module SharedRememberableTest
+  extend ActiveSupport::Testing::Declarative
+
+  test 'should respond to remember_me attribute' do
+    assert resource_class.new.respond_to?(:remember_me)
+    assert resource_class.new.respond_to?(:remember_me=)
+  end
+
+  test 'forget_me should clear remember_created_at' do
+    resource = create_resource
+    resource.remember_me!
+    assert_not resource.remember_created_at.nil?
+    resource.forget_me!
+    assert resource.remember_created_at.nil?
+  end
+
+  test 'remember is expired if not created at timestamp is set' do
+    assert create_resource.remember_expired?
+  end
+
+  test 'serialize should return nil if no resource is found' do
+    assert_nil resource_class.serialize_from_cookie([0], "123")
+  end
+
+  test 'remember me return nil if is a valid resource with invalid token' do
+    resource = create_resource
+    assert_nil resource_class.serialize_from_cookie([resource.id], "123")
+  end
+
+  test 'remember for should fallback to devise remember for default configuration' do
+    swap Devise, :remember_for => 1.day do
+      resource = create_resource
+      resource.remember_me!
+      assert_not resource.remember_expired?
+    end
+  end
+
+  test 'remember expires at should sum date of creation with remember for configuration' do
+    swap Devise, :remember_for => 3.days do
+      resource = create_resource
+      resource.remember_me!
+      assert_equal 3.days.from_now.to_date, resource.remember_expires_at.to_date
+
+      Devise.remember_for = 5.days
+      assert_equal 5.days.from_now.to_date, resource.remember_expires_at.to_date
+    end
+  end
+
+  test 'remember should be expired if remember_for is zero' do
+    swap Devise, :remember_for => 0.days do
+      Devise.remember_for = 0.days
+      resource = create_resource
+      resource.remember_me!
+      assert resource.remember_expired?
+    end
+  end
+
+  test 'remember should be expired if it was created before limit time' do
+    swap Devise, :remember_for => 1.day do
+      resource = create_resource
+      resource.remember_me!
+      resource.remember_created_at = 2.days.ago
+      resource.save
+      assert resource.remember_expired?
+    end
+  end
+
+  test 'remember should not be expired if it was created whitin the limit time' do
+    swap Devise, :remember_for => 30.days do
+      resource = create_resource
+      resource.remember_me!
+      resource.remember_created_at = (30.days.ago + 2.minutes)
+      resource.save
+      assert_not resource.remember_expired?
+    end
+  end
+
+  test 'if extend_remember_period is false, remember_me! should generate a new timestamp if expired' do
+    swap Devise, :remember_for => 5.minutes do
+      resource = create_resource
+      resource.remember_me!(false)
+      assert resource.remember_created_at
+
+      resource.remember_created_at = old = 10.minutes.ago
+      resource.save
+
+      resource.remember_me!(false)
+      assert_not_equal old.to_i, resource.remember_created_at.to_i
+    end
+  end
+
+  test 'if extend_remember_period is false, remember_me! should not generate a new timestamp' do
+    swap Devise, :remember_for => 1.year do
+      resource = create_resource
+      resource.remember_me!(false)
+      assert resource.remember_created_at
+
+      resource.remember_created_at = old = 10.minutes.ago.utc
+      resource.save
+
+      resource.remember_me!(false)
+      assert_equal old.to_i, resource.remember_created_at.to_i
+    end
+  end
+
+  test 'if extend_remember_period is true, remember_me! should always generate a new timestamp' do
+    swap Devise, :remember_for => 1.year do
+      resource = create_resource
+      resource.remember_me!(true)
+      assert resource.remember_created_at
+
+      resource.remember_created_at = old = 10.minutes.ago
+      resource.save
+
+      resource.remember_me!(true)
+      assert_not_equal old, resource.remember_created_at
+    end
+  end
+end
+
+class RememberableTest < ActiveSupport::TestCase
+  include SharedRememberableTest
+
+  def resource_class
+    Admin
+  end
+
+  def create_resource
+    create_admin
+  end
+
+  test 'remember_me should generate a new token and save the record without validating' do
+    admin = create_admin
+    admin.expects(:valid?).never
+    token = admin.remember_token
+    admin.remember_me!
+    assert_not_equal token, admin.remember_token
+    assert_not admin.changed?
+  end
+
+  test 'forget_me should clear remember token and save the record without validating' do
+    admin = create_admin
+    admin.remember_me!
+    assert_not admin.remember_token.nil?
+    admin.expects(:valid?).never
+    admin.forget_me!
+    assert admin.remember_token.nil?
+    assert_not admin.changed?
+  end
+
+  test 'serialize into cookie' do
+    admin = create_admin
+    admin.remember_me!
+    assert_equal [admin.to_key, admin.remember_token], Admin.serialize_into_cookie(admin)
+  end
+
+  test 'serialize from cookie' do
+    admin = create_admin
+    admin.remember_me!
+    assert_equal admin, Admin.serialize_from_cookie(admin.to_key, admin.remember_token)
+  end
+
+  test 'if remember_across_browsers is true, remember_me! should create a new token if no token exists' do
+    swap Devise, :remember_across_browsers => true, :remember_for => 1.year do
+      admin = create_admin
+      assert_equal nil, admin.remember_token
+      admin.remember_me!
+      assert_not_equal nil, admin.remember_token
+    end
+  end
+
+  test 'if remember_across_browsers is true, remember_me! should create a new token if a token exists but has expired' do
+    swap Devise, :remember_across_browsers => true, :remember_for => 1.day do
+      admin = create_admin
+      admin.remember_me!
+      admin.remember_created_at = 2.days.ago
+      admin.save
+      token = admin.remember_token
+      admin.remember_me!
+      assert_not_equal token, admin.remember_token
+    end
+  end
+
+  test 'if remember_across_browsers is true, remember_me! should not create a new token if a token exists and has not expired' do
+    swap Devise, :remember_across_browsers => true, :remember_for => 2.days do
+      admin = create_admin
+      admin.remember_me!
+      admin.remember_created_at = 1.day.ago
+      admin.save
+      token = admin.remember_token
+      admin.remember_me!
+      assert_equal token, admin.remember_token
+    end
+  end
+
+  test 'if remember_across_browsers is false, remember_me! should create a new token if no token exists' do
+    swap Devise, :remember_across_browsers => false do
+      admin = create_admin
+      assert_equal nil, admin.remember_token
+      admin.remember_me!
+      assert_not_equal nil, admin.remember_token
+    end
+  end
+
+  test 'if remember_across_browsers is false, remember_me! should create a new token if a token exists but has expired' do
+    swap Devise, :remember_across_browsers => false, :remember_for => 1.day do
+      admin = create_admin
+      admin.remember_me!
+      admin.remember_created_at = 2.days.ago
+      admin.save
+      token = admin.remember_token
+      admin.remember_me!
+      assert_not_equal token, admin.remember_token
+    end
+  end
+
+  test 'if remember_across_browsers is false, remember_me! should create a new token if a token exists and has not expired' do
+    swap Devise, :remember_across_browsers => false, :remember_for => 2.days do
+      admin = create_admin
+      admin.remember_me!
+      admin.remember_created_at = 1.day.ago
+      admin.save
+      token = admin.remember_token
+      admin.remember_me!
+      assert_not_equal token, admin.remember_token
+    end
+  end
+end
+
+class WithSaltRememberableTest < ActiveSupport::TestCase
+  include SharedRememberableTest
+
+  setup do
+    assert_not User.new.respond_to?(:remember_token)
+  end
+
+  def resource_class
+    User
+  end
+
+  def create_resource
+    create_user
+  end
+
+  test 'remember_me should not generate a new token if using salt' do
+    user = create_user
+    user.expects(:valid?).never
+    user.remember_me!
+  end
+
+  test 'forget_me should not clear remember token if using salt' do
+    user = create_user
+    user.remember_me!
+    user.expects(:valid?).never
+    user.forget_me!
+  end
+
+  test 'serialize into cookie' do
+    user = create_user
+    user.remember_me!
+    assert_equal [user.to_key, user.authenticatable_salt], User.serialize_into_cookie(user)
+  end
+
+  test 'serialize from cookie' do
+    user = create_user
+    user.remember_me!
+    assert_equal user, User.serialize_from_cookie(user.to_key, user.authenticatable_salt)
+  end
+
+  test 'raises a RuntimeError if authenticatable_salt is nil' do
+    user = User.new
+    user.encrypted_password = nil
+    assert_raise RuntimeError do
+      user.rememberable_value
+    end
+  end
+end

data/test/models/timeoutable_test.rb

@@ -0,0 +1,28 @@
+require 'test_helper'
+
+class TimeoutableTest < ActiveSupport::TestCase
+
+  test 'should be expired' do
+    assert new_user.timedout?(31.minutes.ago)
+  end
+
+  test 'should not be expired' do
+    assert_not new_user.timedout?(29.minutes.ago)
+  end
+
+  test 'should not be expired when params is nil' do
+    assert_not new_user.timedout?(nil)
+  end
+
+  test 'fallback to Devise config option' do
+    swap Devise, :timeout_in => 1.minute do
+      user = new_user
+      assert user.timedout?(2.minutes.ago)
+      assert_not user.timedout?(30.seconds.ago)
+
+      Devise.timeout_in = 5.minutes
+      assert_not user.timedout?(2.minutes.ago)
+      assert user.timedout?(6.minutes.ago)
+    end
+  end
+end

data/test/models/token_authenticatable_test.rb

@@ -0,0 +1,37 @@
+require 'test_helper'
+
+class TokenAuthenticatableTest < ActiveSupport::TestCase
+
+  test 'should reset authentication token' do
+    user = new_user
+    user.reset_authentication_token
+    previous_token = user.authentication_token
+    user.reset_authentication_token
+    assert_not_equal previous_token, user.authentication_token
+  end
+
+  test 'should ensure authentication token' do
+    user = new_user
+    user.ensure_authentication_token
+    previous_token = user.authentication_token
+    user.ensure_authentication_token
+    assert_equal previous_token, user.authentication_token
+  end
+
+  test 'should authenticate a valid user with authentication token and return it' do
+    user = create_user
+    user.ensure_authentication_token!
+    user.confirm!
+    authenticated_user = User.find_for_token_authentication(:auth_token => user.authentication_token)
+    assert_equal authenticated_user, user
+  end
+
+  test 'should return nil when authenticating an invalid user by authentication token' do
+    user = create_user
+    user.ensure_authentication_token!
+    user.confirm!
+    authenticated_user = User.find_for_token_authentication(:auth_token => user.authentication_token.reverse)
+    assert_nil authenticated_user
+  end
+
+end

data/test/models/trackable_test.rb

@@ -0,0 +1,5 @@
+require 'test_helper'
+
+class TrackableTest < ActiveSupport::TestCase
+
+end

data/test/models/validatable_test.rb

@@ -0,0 +1,99 @@
+require 'test_helper'
+
+class ValidatableTest < ActiveSupport::TestCase
+  test 'should require email to be set' do
+    user = new_user(:email => nil)
+    assert user.invalid?
+    assert user.errors[:email]
+    assert_equal 'can\'t be blank', user.errors[:email].join
+  end
+
+  test 'should require uniqueness of email, allowing blank' do
+    existing_user = create_user
+
+    user = new_user(:email => '')
+    assert user.invalid?
+    assert_no_match(/taken/, user.errors[:email].join)
+
+    user.email = existing_user.email
+    assert user.invalid?
+    assert_match(/taken/, user.errors[:email].join)
+  end
+
+  test 'should require correct email format, allowing blank' do
+    user = new_user(:email => '')
+    assert user.invalid?
+    assert_not_equal 'is invalid', user.errors[:email].join
+
+    %w(invalid_email_format email@invalid invalid$character@mail.com other@not 123).each do |email|
+      user.email = email
+      assert user.invalid?, 'should be invalid with email ' << email
+      assert_equal 'is invalid', user.errors[:email].join
+    end
+  end
+
+  test 'should accept valid emails' do
+    %w(a.b.c@example.com test_mail@gmail.com any@any.net email@test.br 123@mail.test).each do |email|
+      user = new_user(:email => email)
+      assert user.valid?, 'should be valid with email ' << email
+      assert_blank user.errors[:email]
+    end
+  end
+
+  test 'should require password to be set when creating a new record' do
+    user = new_user(:password => '', :password_confirmation => '')
+    assert user.invalid?
+    assert_equal 'can\'t be blank', user.errors[:password].join
+  end
+
+  test 'should require confirmation to be set when creating a new record' do
+    user = new_user(:password => 'new_password', :password_confirmation => 'blabla')
+    assert user.invalid?
+    assert_equal 'doesn\'t match confirmation', user.errors[:password].join
+  end
+
+  test 'should require password when updating/reseting password' do
+    user = create_user
+
+    user.password = ''
+    user.password_confirmation = ''
+
+    assert user.invalid?
+    assert_equal 'can\'t be blank', user.errors[:password].join
+  end
+
+  test 'should require confirmation when updating/reseting password' do
+    user = create_user
+    user.password_confirmation = 'another_password'
+    assert user.invalid?
+    assert_equal 'doesn\'t match confirmation', user.errors[:password].join
+  end
+
+  test 'should require a password with minimum of 6 characters' do
+    user = new_user(:password => '12345', :password_confirmation => '12345')
+    assert user.invalid?
+    assert_equal 'is too short (minimum is 6 characters)', user.errors[:password].join
+  end
+
+  test 'should require a password with maximum of 20 characters long' do
+    user = new_user(:password => 'x'*21, :password_confirmation => 'x'*21)
+    assert user.invalid?
+    assert_equal 'is too long (maximum is 20 characters)', user.errors[:password].join
+  end
+
+  test 'should not require password length when it\'s not changed' do
+    user = create_user.reload
+    user.password = user.password_confirmation = nil
+    assert user.valid?
+  
+    user.password_confirmation = 'confirmation'
+    assert user.invalid?
+    assert_not (user.errors[:password].join =~ /is too long/)
+  end
+
+  test 'shuold not be included in objects with invalid API' do
+    assert_raise RuntimeError do
+      Class.new.send :include, Devise::Models::Validatable
+    end
+  end
+end