devise-jdguyot 1.2.rc

data/test/mapping_test.rb

@@ -0,0 +1,119 @@
+require 'test_helper'
+
+class FakeRequest < Struct.new(:path_info, :params)
+end
+
+class MappingTest < ActiveSupport::TestCase
+  def fake_request(path, params={})
+    FakeRequest.new(path, params)
+  end
+
+  test 'store options' do
+    mapping = Devise.mappings[:user]
+    assert_equal User,                mapping.to
+    assert_equal User.devise_modules, mapping.modules
+    assert_equal "users",             mapping.scoped_path
+    assert_equal :user,               mapping.singular
+    assert_equal "users",             mapping.path
+    assert_equal "/users",            mapping.fullpath
+  end
+
+  test 'store options with namespace' do
+    mapping = Devise.mappings[:publisher_account]
+    assert_equal Admin,                 mapping.to
+    assert_equal "publisher/accounts",  mapping.scoped_path
+    assert_equal :publisher_account,    mapping.singular
+    assert_equal "accounts",            mapping.path
+    assert_equal "/publisher/accounts", mapping.fullpath
+  end
+
+  test 'allows path to be given' do
+    assert_equal "admin_area", Devise.mappings[:admin].path
+  end
+
+  test 'sign_out_via defaults to :get' do
+    assert_equal :get, Devise.mappings[:user].sign_out_via
+  end
+
+  test 'allows custom sign_out_via to be given' do
+    assert_equal :delete,          Devise.mappings[:sign_out_via_delete].sign_out_via
+    assert_equal :post,            Devise.mappings[:sign_out_via_post].sign_out_via
+    assert_equal [:delete, :post], Devise.mappings[:sign_out_via_delete_or_post].sign_out_via
+  end
+
+  test 'allows custom singular to be given' do
+    assert_equal "accounts", Devise.mappings[:manager].path
+  end
+
+  test 'has strategies depending on the model declaration' do
+    assert_equal [:rememberable, :token_authenticatable, :database_authenticatable], Devise.mappings[:user].strategies
+    assert_equal [:rememberable, :database_authenticatable], Devise.mappings[:admin].strategies
+  end
+
+  test 'find scope for a given object' do
+    assert_equal :user, Devise::Mapping.find_scope!(User)
+    assert_equal :user, Devise::Mapping.find_scope!(:user)
+    assert_equal :user, Devise::Mapping.find_scope!(User.new)
+  end
+
+  test 'find scope works with single table inheritance' do
+    assert_equal :user, Devise::Mapping.find_scope!(Class.new(User))
+    assert_equal :user, Devise::Mapping.find_scope!(Class.new(User).new)
+  end
+
+  test 'find scope raises an error if cannot be found' do
+    assert_raise RuntimeError do
+      Devise::Mapping.find_scope!(String)
+    end
+  end
+
+  test 'return default path names' do
+    mapping = Devise.mappings[:user]
+    assert_equal 'sign_in',      mapping.path_names[:sign_in]
+    assert_equal 'sign_out',     mapping.path_names[:sign_out]
+    assert_equal 'password',     mapping.path_names[:password]
+    assert_equal 'confirmation', mapping.path_names[:confirmation]
+    assert_equal 'sign_up',      mapping.path_names[:sign_up]
+    assert_equal 'unlock',       mapping.path_names[:unlock]
+  end
+
+  test 'allow custom path names to be given' do
+    mapping = Devise.mappings[:manager]
+    assert_equal 'login',        mapping.path_names[:sign_in]
+    assert_equal 'logout',       mapping.path_names[:sign_out]
+    assert_equal 'secret',       mapping.path_names[:password]
+    assert_equal 'verification', mapping.path_names[:confirmation]
+    assert_equal 'register',     mapping.path_names[:sign_up]
+    assert_equal 'unblock',      mapping.path_names[:unlock]
+  end
+
+  test 'magic predicates' do
+    mapping = Devise.mappings[:user]
+    assert mapping.authenticatable?
+    assert mapping.confirmable?
+    assert mapping.recoverable?
+    assert mapping.rememberable?
+    assert mapping.registerable?
+
+    mapping = Devise.mappings[:admin]
+    assert mapping.authenticatable?
+    assert mapping.recoverable?
+    assert mapping.lockable?
+    assert_not mapping.confirmable?
+    assert_not mapping.omniauthable?
+  end
+  
+  test 'find mapping by path' do
+    assert_raise RuntimeError do
+      Devise::Mapping.find_by_path!('/accounts/facebook/callback')
+    end
+    
+    assert_nothing_raised do
+      Devise::Mapping.find_by_path!('/:locale/accounts/login')
+    end
+
+    assert_nothing_raised do
+      Devise::Mapping.find_by_path!('/accounts/facebook/callback', :path)
+    end
+  end  
+end

data/test/models/confirmable_test.rb

@@ -0,0 +1,221 @@
+require 'test_helper'
+
+class ConfirmableTest < ActiveSupport::TestCase
+
+  def setup
+    setup_mailer
+  end
+
+  test 'should generate confirmation token after creating a record' do
+    assert_nil new_user.confirmation_token
+    assert_not_nil create_user.confirmation_token
+  end
+
+  test 'should never generate the same confirmation token for different users' do
+    confirmation_tokens = []
+    3.times do
+      token = create_user.confirmation_token
+      assert !confirmation_tokens.include?(token)
+      confirmation_tokens << token
+    end
+  end
+
+  test 'should confirm a user by updating confirmed at' do
+    user = create_user
+    assert_nil user.confirmed_at
+    assert user.confirm!
+    assert_not_nil user.confirmed_at
+  end
+
+  test 'should clear confirmation token while confirming a user' do
+    user = create_user
+    assert_present user.confirmation_token
+    user.confirm!
+    assert_nil user.confirmation_token
+  end
+
+  test 'should verify whether a user is confirmed or not' do
+    assert_not new_user.confirmed?
+    user = create_user
+    assert_not user.confirmed?
+    user.confirm!
+    assert user.confirmed?
+  end
+
+  test 'should not confirm a user already confirmed' do
+    user = create_user
+    assert user.confirm!
+    assert_blank user.errors[:email]
+
+    assert_not user.confirm!
+    assert_equal "was already confirmed, please try signing in", user.errors[:email].join
+  end
+
+  test 'should find and confirm an user automatically' do
+    user = create_user
+    confirmed_user = User.confirm_by_token(user.confirmation_token)
+    assert_equal confirmed_user, user
+    assert user.reload.confirmed?
+  end
+
+  test 'should return a new record with errors when a invalid token is given' do
+    confirmed_user = User.confirm_by_token('invalid_confirmation_token')
+    assert_not confirmed_user.persisted?
+    assert_equal "is invalid", confirmed_user.errors[:confirmation_token].join
+  end
+
+  test 'should return a new record with errors when a blank token is given' do
+    confirmed_user = User.confirm_by_token('')
+    assert_not confirmed_user.persisted?
+    assert_equal "can't be blank", confirmed_user.errors[:confirmation_token].join
+  end
+
+  test 'should generate errors for a user email if user is already confirmed' do
+    user = create_user
+    user.confirmed_at = Time.now
+    user.save
+    confirmed_user = User.confirm_by_token(user.confirmation_token)
+    assert confirmed_user.confirmed?
+    assert_equal "was already confirmed, please try signing in", confirmed_user.errors[:email].join
+  end
+
+  test 'should send confirmation instructions by email' do
+    assert_email_sent do
+      create_user
+    end
+  end
+
+  test 'should not send confirmation when trying to save an invalid user' do
+    assert_email_not_sent do
+      user = new_user
+      user.stubs(:valid?).returns(false)
+      user.save
+    end
+  end
+
+  test 'should not generate a new token neither send e-mail if skip_confirmation! is invoked' do
+    user = new_user
+    user.skip_confirmation!
+
+    assert_email_not_sent do
+      user.save!
+      assert_nil user.confirmation_token
+      assert_not_nil user.confirmed_at
+    end
+  end
+
+  test 'should find a user to send confirmation instructions' do
+    user = create_user
+    confirmation_user = User.send_confirmation_instructions(:email => user.email)
+    assert_equal confirmation_user, user
+  end
+
+  test 'should return a new user if no email was found' do
+    confirmation_user = User.send_confirmation_instructions(:email => "invalid@email.com")
+    assert_not confirmation_user.persisted?
+  end
+
+  test 'should add error to new user email if no email was found' do
+    confirmation_user = User.send_confirmation_instructions(:email => "invalid@email.com")
+    assert confirmation_user.errors[:email]
+    assert_equal "not found", confirmation_user.errors[:email].join
+  end
+
+  test 'should send email instructions for the user confirm it\'s email' do
+    user = create_user
+    assert_email_sent do
+      User.send_confirmation_instructions(:email => user.email)
+    end
+  end
+  
+  test 'should always have confirmation token when email is sent' do
+    user = new_user
+    user.instance_eval { def confirmation_required?; false end }
+    user.save
+    user.send_confirmation_instructions
+    assert_not_nil user.reload.confirmation_token
+  end
+
+  test 'should not resend email instructions if the user change his email' do
+    user = create_user
+    user.email = 'new_test@example.com'
+    assert_email_not_sent do
+      user.save!
+    end
+  end
+
+  test 'should not reset confirmation status or token when updating email' do
+    user = create_user
+    user.confirm!
+    user.email = 'new_test@example.com'
+    user.save!
+
+    user.reload
+    assert user.confirmed?
+    assert_nil user.confirmation_token
+  end
+
+  test 'should not be able to send instructions if the user is already confirmed' do
+    user = create_user
+    user.confirm!
+    assert_not user.resend_confirmation_token
+    assert user.confirmed?
+    assert_equal 'was already confirmed, please try signing in', user.errors[:email].join
+  end
+
+  test 'confirm time should fallback to devise confirm in default configuration' do
+    swap Devise, :confirm_within => 1.day do
+      user = new_user
+      user.confirmation_sent_at = 2.days.ago
+      assert_not user.active?
+
+      Devise.confirm_within = 3.days
+      assert user.active?
+    end
+  end
+
+  test 'should be active when confirmation sent at is not overpast' do
+    swap Devise, :confirm_within => 5.days do
+      Devise.confirm_within = 5.days
+      user = create_user
+
+      user.confirmation_sent_at = 4.days.ago
+      assert user.active?
+
+      user.confirmation_sent_at = 5.days.ago
+      assert_not user.active?
+    end
+  end
+
+  test 'should be active when already confirmed' do
+    user = create_user
+    assert_not user.confirmed?
+    assert_not user.active?
+
+    user.confirm!
+    assert user.confirmed?
+    assert user.active?
+  end
+
+  test 'should not be active when confirm in is zero' do
+    Devise.confirm_within = 0.days
+    user = create_user
+    user.confirmation_sent_at = Date.today
+    assert_not user.active?
+  end
+
+  test 'should not be active without confirmation' do
+    user = create_user
+    user.confirmation_sent_at = nil
+    user.save
+    assert_not user.reload.active?
+  end
+  
+  test 'should be active without confirmation when confirmation is not required' do
+    user = create_user
+    user.instance_eval { def confirmation_required?; false end }
+    user.confirmation_sent_at = nil
+    user.save
+    assert user.reload.active?
+  end
+end

data/test/models/database_authenticatable_test.rb

@@ -0,0 +1,98 @@
+require 'test_helper'
+require 'digest/sha1'
+
+class DatabaseAuthenticatableTest < ActiveSupport::TestCase
+  test 'should downcase case insensitive keys when saving' do
+    # case_insensitive_keys is set to :email by default.
+    email = 'Foo@Bar.com'
+    user = new_user(:email => email)
+    
+    assert_equal email, user.email
+    user.save!
+    assert_equal email.downcase, user.email
+  end
+  
+  test 'should respond to password and password confirmation' do
+    user = new_user
+    assert user.respond_to?(:password)
+    assert user.respond_to?(:password_confirmation)
+  end
+
+  test 'should generate encrypted password while setting password' do
+    user = new_user
+    assert_present user.encrypted_password
+  end
+
+  test 'allow authenticatable_salt to work even with nil encrypted password' do
+    user = User.new
+    user.encrypted_password = nil
+    assert_nil user.authenticatable_salt
+  end
+
+  test 'should not generate encrypted password if password is blank' do
+    assert_blank new_user(:password => nil).encrypted_password
+    assert_blank new_user(:password => '').encrypted_password
+  end
+
+  test 'should encrypt password again if password has changed' do
+    user = create_user
+    encrypted_password = user.encrypted_password
+    user.password = user.password_confirmation = 'new_password'
+    user.save!
+    assert_not_equal encrypted_password, user.encrypted_password
+  end
+
+  test 'should test for a valid password' do
+    user = create_user
+    assert user.valid_password?('123456')
+    assert_not user.valid_password?('654321')
+  end
+
+  test 'should respond to current password' do
+    assert new_user.respond_to?(:current_password)
+  end
+
+  test 'should update password with valid current password' do
+    user = create_user
+    assert user.update_with_password(:current_password => '123456',
+      :password => 'pass321', :password_confirmation => 'pass321')
+    assert user.reload.valid_password?('pass321')
+  end
+
+  test 'should add an error to current password when it is invalid' do
+    user = create_user
+    assert_not user.update_with_password(:current_password => 'other',
+      :password => 'pass321', :password_confirmation => 'pass321')
+    assert user.reload.valid_password?('123456')
+    assert_match "is invalid", user.errors[:current_password].join
+  end
+
+  test 'should add an error to current password when it is blank' do
+    user = create_user
+    assert_not user.update_with_password(:password => 'pass321',
+      :password_confirmation => 'pass321')
+    assert user.reload.valid_password?('123456')
+    assert_match "can't be blank", user.errors[:current_password].join
+  end
+
+  test 'should ignore password and its confirmation if they are blank' do
+    user = create_user
+    assert user.update_with_password(:current_password => '123456', :email => "new@email.com")
+    assert_equal "new@email.com", user.email
+  end
+
+  test 'should not update password with invalid confirmation' do
+    user = create_user
+    assert_not user.update_with_password(:current_password => '123456',
+      :password => 'pass321', :password_confirmation => 'other')
+    assert user.reload.valid_password?('123456')
+  end
+
+  test 'should clean up password fields on failure' do
+    user = create_user
+    assert_not user.update_with_password(:current_password => '123456',
+      :password => 'pass321', :password_confirmation => 'other')
+    assert user.password.blank?
+    assert user.password_confirmation.blank?
+  end
+end

data/test/models/encryptable_test.rb

@@ -0,0 +1,65 @@
+require 'test_helper'
+
+class EncryptableTest < ActiveSupport::TestCase
+  def encrypt_password(admin, pepper=Admin.pepper, stretches=Admin.stretches, encryptor=Admin.encryptor_class)
+    encryptor.digest('123456', stretches, admin.password_salt, pepper)
+  end
+
+  def swap_with_encryptor(klass, encryptor, options={})
+    klass.instance_variable_set(:@encryptor_class, nil)
+
+    swap klass, options.merge(:encryptor => encryptor) do
+      begin
+        yield
+      ensure
+        klass.instance_variable_set(:@encryptor_class, nil)
+      end
+    end
+  end
+
+  test 'should generate salt while setting password' do
+    assert_present create_admin.password_salt
+  end
+
+  test 'should not change password salt when updating' do
+    admin = create_admin
+    salt = admin.password_salt
+    admin.expects(:password_salt=).never
+    admin.save!
+    assert_equal salt, admin.password_salt
+  end
+
+  test 'should generate a base64 hash using SecureRandom for password salt' do
+    swap_with_encryptor Admin, :sha1 do
+      ActiveSupport::SecureRandom.expects(:base64).with(44).returns('friendly_token')
+      assert_equal 'friendly_token', create_admin.password_salt
+    end
+  end
+
+  test 'should not generate salt if password is blank' do
+    assert_blank create_admin(:password => nil).password_salt
+    assert_blank create_admin(:password => '').password_salt
+  end
+
+  test 'should encrypt password again if password has changed' do
+    admin = create_admin
+    encrypted_password = admin.encrypted_password
+    admin.password = admin.password_confirmation = 'new_password'
+    admin.save!
+    assert_not_equal encrypted_password, admin.encrypted_password
+  end
+
+  test 'should respect encryptor configuration' do
+    swap_with_encryptor Admin, :sha512 do
+      admin = create_admin
+      assert_equal admin.encrypted_password, encrypt_password(admin, Admin.pepper, Admin.stretches, ::Devise::Encryptors::Sha512)
+    end
+  end
+
+  test 'should not validate password when salt is nil' do
+    admin = create_admin
+    admin.password_salt = nil
+    admin.save
+    assert_not admin.valid_password?('123456')
+  end
+end

data/test/models/lockable_test.rb

@@ -0,0 +1,204 @@
+require 'test_helper'
+
+class LockableTest < ActiveSupport::TestCase
+  def setup
+    setup_mailer
+  end
+
+  test "should respect maximum attempts configuration" do
+    user = create_user
+    user.confirm!
+    swap Devise, :maximum_attempts => 2 do
+      3.times { user.valid_for_authentication?{ false } }
+      assert user.reload.access_locked?
+    end
+  end
+
+  test "should clear failed_attempts on successfull validation" do
+    user = create_user
+    user.confirm!
+    user.valid_for_authentication?{ false }
+    assert_equal 1, user.reload.failed_attempts
+    user.valid_for_authentication?{ true }
+    assert_equal 0, user.reload.failed_attempts
+  end
+
+  test "should not touch failed_attempts if lock_strategy is none" do
+    user = create_user
+    user.confirm!
+    swap Devise, :lock_strategy => :none, :maximum_attempts => 2 do
+      3.times { user.valid_for_authentication?{ false } }
+      assert !user.access_locked?
+      assert_equal 0, user.failed_attempts
+    end
+  end
+
+  test 'should be valid for authentication with a unlocked user' do
+    user = create_user
+    user.lock_access!
+    user.unlock_access!
+    assert user.valid_for_authentication?{ true }
+  end
+
+  test "should verify whether a user is locked or not" do
+    user = create_user
+    assert_not user.access_locked?
+    user.lock_access!
+    assert user.access_locked?
+  end
+
+  test "active? should be the opposite of locked?" do
+    user = create_user
+    user.confirm!
+    assert user.active?
+    user.lock_access!
+    assert_not user.active?
+  end
+
+  test "should unlock an user by cleaning locked_at, falied_attempts and unlock_token" do
+    user = create_user
+    user.lock_access!
+    assert_not_nil user.reload.locked_at
+    assert_not_nil user.reload.unlock_token
+
+    user.unlock_access!
+    assert_nil user.reload.locked_at
+    assert_nil user.reload.unlock_token
+    assert_equal 0, user.reload.failed_attempts
+  end
+
+  test 'should not unlock an unlocked user' do
+    user = create_user
+    assert_not user.unlock_access!
+    assert_match "was not locked", user.errors[:email].join
+  end
+
+  test "new user should not be locked and should have zero failed_attempts" do
+    assert_not new_user.access_locked?
+    assert_equal 0, create_user.failed_attempts
+  end
+
+  test "should unlock user after unlock_in period" do
+    swap Devise, :unlock_in => 3.hours do
+      user = new_user
+      user.locked_at = 2.hours.ago
+      assert user.access_locked?
+
+      Devise.unlock_in = 1.hour
+      assert_not user.access_locked?
+    end
+  end
+
+  test "should not unlock in 'unlock_in' if :time unlock strategy is not set" do
+    swap Devise, :unlock_strategy => :email do
+      user = new_user
+      user.locked_at = 2.hours.ago
+      assert user.access_locked?
+    end
+  end
+
+  test "should set unlock_token when locking" do
+    user = create_user
+    assert_nil user.unlock_token
+    user.lock_access!
+    assert_not_nil user.unlock_token
+  end
+
+  test "should never generate the same unlock token for different users" do
+    unlock_tokens = []
+    3.times do
+      user = create_user
+      user.lock_access!
+      token = user.unlock_token
+      assert !unlock_tokens.include?(token)
+      unlock_tokens << token
+    end
+  end
+
+  test "should not generate unlock_token when :email is not an unlock strategy" do
+    swap Devise, :unlock_strategy => :time do
+      user = create_user
+      user.lock_access!
+      assert_nil user.unlock_token
+    end
+  end
+
+  test "should send email with unlock instructions when :email is an unlock strategy" do
+    swap Devise, :unlock_strategy => :email do
+      user = create_user
+      assert_email_sent do
+        user.lock_access!
+      end
+    end
+  end
+
+  test "should not send email with unlock instructions when :email is not an unlock strategy" do
+    swap Devise, :unlock_strategy => :time do
+      user = create_user
+      assert_email_not_sent do
+        user.lock_access!
+      end
+    end
+  end
+
+  test 'should find and unlock an user automatically' do
+    user = create_user
+    user.lock_access!
+    locked_user = User.unlock_access_by_token(user.unlock_token)
+    assert_equal locked_user, user
+    assert_not user.reload.access_locked?
+  end
+
+  test 'should return a new record with errors when a invalid token is given' do
+    locked_user = User.unlock_access_by_token('invalid_token')
+    assert_not locked_user.persisted?
+    assert_equal "is invalid", locked_user.errors[:unlock_token].join
+  end
+
+  test 'should return a new record with errors when a blank token is given' do
+    locked_user = User.unlock_access_by_token('')
+    assert_not locked_user.persisted?
+    assert_equal "can't be blank", locked_user.errors[:unlock_token].join
+  end
+
+  test 'should find a user to send unlock instructions' do
+    user = create_user
+    user.lock_access!
+    unlock_user = User.send_unlock_instructions(:email => user.email)
+    assert_equal unlock_user, user
+  end
+
+  test 'should return a new user if no email was found' do
+    unlock_user = User.send_unlock_instructions(:email => "invalid@email.com")
+    assert_not unlock_user.persisted?
+  end
+
+  test 'should add error to new user email if no email was found' do
+    unlock_user = User.send_unlock_instructions(:email => "invalid@email.com")
+    assert_equal 'not found', unlock_user.errors[:email].join
+  end
+
+  test 'should find a user to send unlock instructions by authentication_keys' do
+    swap Devise, :authentication_keys => [:username, :email] do
+      user = create_user
+      unlock_user = User.send_unlock_instructions(:email => user.email, :username => user.username)
+      assert_equal unlock_user, user
+    end
+  end
+
+  test 'should require all unlock_keys' do
+      swap Devise, :unlock_keys => [:username, :email] do
+          user = create_user
+          unlock_user = User.send_unlock_instructions(:email => user.email)
+          assert_not unlock_user.persisted?
+          assert_equal "can't be blank", unlock_user.errors[:username].join
+      end
+  end
+
+  test 'should not be able to send instructions if the user is not locked' do
+    user = create_user
+    assert_not user.resend_unlock_token
+    assert_not user.access_locked?
+    assert_equal 'was not locked', user.errors[:email].join
+  end
+end