detour 0.0.3 → 0.0.5

metadata

@@ -1,218 +1,207 @@
 --- !ruby/object:Gem::Specification
 name: detour
 version: !ruby/object:Gem::Version
-  version: 0.0.3
-  prerelease: 
+  version: 0.0.5
 platform: ruby
 authors:
 - Jonathan Clem
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-01-08 00:00:00.000000000 Z
+date: 2014-02-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '3.2'
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 3.2.16
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '3.2'
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 3.2.16
 - !ruby/object:Gem::Dependency
   name: indefinite_article
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0.2'
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 0.2.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0.2'
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 0.2.0
 - !ruby/object:Gem::Dependency
   name: capybara
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: database_cleaner
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 1.2.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 1.2.0
 - !ruby/object:Gem::Dependency
   name: factory_girl_rails
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: launchy
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: poltergeist
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: pry-nav
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec-rails
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: selenium-webdriver
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: shoulda-matchers
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: sqlite3-ruby
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: yard
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: Rollouts (feature flags) for Rails.
@@ -222,8 +211,8 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .travis.yml
+- ".gitignore"
+- ".travis.yml"
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -234,10 +223,13 @@ files:
 - app/assets/fonts/glyphicons-halflings-regular.ttf
 - app/assets/fonts/glyphicons-halflings-regular.woff
 - app/assets/images/detour/.gitkeep
+- app/assets/javascripts/detour/add_fields.js
 - app/assets/javascripts/detour/application.js
 - app/assets/javascripts/detour/bootstrap.js
 - app/assets/javascripts/detour/delete_feature.js
 - app/assets/javascripts/detour/delete_flag.js
+- app/assets/javascripts/detour/delete_group.js
+- app/assets/javascripts/detour/feature_lines.js
 - app/assets/javascripts/detour/modals.js
 - app/assets/javascripts/detour/tooltips.js
 - app/assets/stylesheets/detour/application.css
@@ -247,33 +239,45 @@ files:
 - app/controllers/detour/features_controller.rb
 - app/controllers/detour/flaggable_flags_controller.rb
 - app/controllers/detour/flags_controller.rb
+- app/controllers/detour/groups_controller.rb
 - app/helpers/detour/application_helper.rb
 - app/helpers/detour/flaggable_flags_helper.rb
 - app/helpers/detour/flags_helper.rb
 - app/models/detour/concerns/countable_flag.rb
-- app/models/detour/concerns/flag_actions.rb
+- app/models/detour/concerns/keepable.rb
 - app/models/detour/concerns/matchers.rb
+- app/models/detour/database_group_flag.rb
+- app/models/detour/defined_group.rb
+- app/models/detour/defined_group_flag.rb
 - app/models/detour/feature.rb
 - app/models/detour/flag.rb
 - app/models/detour/flag_in_flag.rb
-- app/models/detour/group_flag.rb
+- app/models/detour/flaggable_flag.rb
+- app/models/detour/group.rb
+- app/models/detour/membership.rb
 - app/models/detour/opt_out_flag.rb
 - app/models/detour/percentage_flag.rb
 - app/views/detour/application/index.html.erb
-- app/views/detour/features/_errors.html.erb
-- app/views/detour/features/_success.html.erb
-- app/views/detour/features/error.js.erb
-- app/views/detour/features/success.js.erb
 - app/views/detour/flaggable_flags/_errors.html.erb
 - app/views/detour/flaggable_flags/_flaggable_flag.html.erb
+- app/views/detour/flaggable_flags/_flaggable_flag_fields.html.erb
 - app/views/detour/flaggable_flags/error.js.erb
 - app/views/detour/flaggable_flags/index.html.erb
 - app/views/detour/flaggable_flags/success.js.erb
 - app/views/detour/flags/_feature_form.html.erb
 - app/views/detour/flags/index.html.erb
+- app/views/detour/groups/_group.html.erb
+- app/views/detour/groups/_membership_fields.html.erb
+- app/views/detour/groups/index.html.erb
+- app/views/detour/groups/show.html.erb
+- app/views/detour/memberships/_membership.html.erb
+- app/views/detour/shared/_errors.html.erb
 - app/views/detour/shared/_nav.html.erb
 - app/views/detour/shared/_spacer_cells.html.erb
+- app/views/detour/shared/error.js.erb
+- app/views/detour/shared/success.js.erb
 - app/views/layouts/detour/application.html.erb
+- config/locales/en.yml
 - config/routes.rb
 - detour.gemspec
 - lib/detour.rb
@@ -286,12 +290,13 @@ files:
 - lib/generators/detour_generator.rb
 - lib/generators/templates/detour.rb
 - lib/generators/templates/migration.rb
-- lib/tasks/detour.rake
+- lib/tasks/.gitkeep
 - script/rails
 - spec/controllers/detour/application_controller_spec.rb
 - spec/controllers/detour/features_controller_spec.rb
 - spec/controllers/detour/flaggable_flags_controller_spec.rb
 - spec/controllers/detour/flags_controller_spec.rb
+- spec/controllers/detour/groups_controller_spec.rb
 - spec/dummy/README.rdoc
 - spec/dummy/Rakefile
 - spec/dummy/app/assets/javascripts/application.js
@@ -334,31 +339,38 @@ files:
 - spec/dummy/public/500.html
 - spec/dummy/public/favicon.ico
 - spec/dummy/script/rails
+- spec/factories/database_group_flag.rb
+- spec/factories/defined_group_flag.rb
 - spec/factories/feature.rb
 - spec/factories/flag_in_flag.rb
-- spec/factories/group_flag.rb
+- spec/factories/group.rb
+- spec/factories/membership.rb
 - spec/factories/opt_out_flag.rb
 - spec/factories/percentage_flag.rb
 - spec/factories/user.rb
 - spec/factories/widget.rb
+- spec/features/database_group_flags_spec.rb
+- spec/features/database_groups_spec.rb
+- spec/features/defined_group_flags_spec.rb
 - spec/features/features_spec.rb
 - spec/features/flag_in_flags_spec.rb
-- spec/features/group_flags_spec.rb
 - spec/features/home_page_spec.rb
 - spec/features/opt_out_flags_spec.rb
 - spec/features/percentage_flags_spec.rb
-- spec/integration/flag_rollout_spec.rb
 - spec/integration/group_rollout_spec.rb
 - spec/integration/percentage_rollout_spec.rb
 - spec/lib/detour/acts_as_flaggable_spec.rb
 - spec/lib/detour/configuration_spec.rb
 - spec/lib/detour/flag_form_spec.rb
 - spec/lib/detour/flaggable_spec.rb
-- spec/lib/tasks/detour_spec.rb
+- spec/models/detour/database_group_flag_spec.rb
+- spec/models/detour/defined_group_spec.rb
 - spec/models/detour/feature_spec.rb
 - spec/models/detour/flag_in_flag_spec.rb
 - spec/models/detour/flag_spec.rb
+- spec/models/detour/flaggable_flag_spec.rb
 - spec/models/detour/group_flag_spec.rb
+- spec/models/detour/membership_spec.rb
 - spec/models/detour/opt_out_flag_spec.rb
 - spec/models/detour/percentage_flag_spec.rb
 - spec/spec_helper.rb
@@ -366,36 +378,33 @@ files:
 homepage: https://github.com/heroku/detour
 licenses:
 - MIT
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: 1.9.3
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 1765350424629187906
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.23
+rubygems_version: 2.2.0
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Rollouts (feature flags) for Rails.
 test_files:
 - spec/controllers/detour/application_controller_spec.rb
 - spec/controllers/detour/features_controller_spec.rb
 - spec/controllers/detour/flaggable_flags_controller_spec.rb
 - spec/controllers/detour/flags_controller_spec.rb
+- spec/controllers/detour/groups_controller_spec.rb
 - spec/dummy/README.rdoc
 - spec/dummy/Rakefile
 - spec/dummy/app/assets/javascripts/application.js
@@ -438,31 +447,38 @@ test_files:
 - spec/dummy/public/500.html
 - spec/dummy/public/favicon.ico
 - spec/dummy/script/rails
+- spec/factories/database_group_flag.rb
+- spec/factories/defined_group_flag.rb
 - spec/factories/feature.rb
 - spec/factories/flag_in_flag.rb
-- spec/factories/group_flag.rb
+- spec/factories/group.rb
+- spec/factories/membership.rb
 - spec/factories/opt_out_flag.rb
 - spec/factories/percentage_flag.rb
 - spec/factories/user.rb
 - spec/factories/widget.rb
+- spec/features/database_group_flags_spec.rb
+- spec/features/database_groups_spec.rb
+- spec/features/defined_group_flags_spec.rb
 - spec/features/features_spec.rb
 - spec/features/flag_in_flags_spec.rb
-- spec/features/group_flags_spec.rb
 - spec/features/home_page_spec.rb
 - spec/features/opt_out_flags_spec.rb
 - spec/features/percentage_flags_spec.rb
-- spec/integration/flag_rollout_spec.rb
 - spec/integration/group_rollout_spec.rb
 - spec/integration/percentage_rollout_spec.rb
 - spec/lib/detour/acts_as_flaggable_spec.rb
 - spec/lib/detour/configuration_spec.rb
 - spec/lib/detour/flag_form_spec.rb
 - spec/lib/detour/flaggable_spec.rb
-- spec/lib/tasks/detour_spec.rb
+- spec/models/detour/database_group_flag_spec.rb
+- spec/models/detour/defined_group_spec.rb
 - spec/models/detour/feature_spec.rb
 - spec/models/detour/flag_in_flag_spec.rb
 - spec/models/detour/flag_spec.rb
+- spec/models/detour/flaggable_flag_spec.rb
 - spec/models/detour/group_flag_spec.rb
+- spec/models/detour/membership_spec.rb
 - spec/models/detour/opt_out_flag_spec.rb
 - spec/models/detour/percentage_flag_spec.rb
 - spec/spec_helper.rb

data/app/models/detour/concerns/flag_actions.rb

@@ -1,141 +0,0 @@
-module Detour::Concerns
-  module FlagActions
-    extend ActiveSupport::Concern
-
-    module ClassMethods
-      # Add a record to the given feature. If the feature is not found, an
-      # ActiveRecord::RecordNotFound will be raised.
-      #
-      # @example
-      #   Detour::Feature.add_record_to_feature user, :new_ui
-      #
-      # @param [ActiveRecord::Base] record A record to add the feature to.
-      # @param [String,Symbol] feature_name The feature to be added to the record.
-      #
-      # @return [Detour::Flag] The
-      #   {Detour::Flag Flag} created.
-      def add_record_to_feature(record, feature_name)
-        feature = find_by_name!(feature_name)
-        feature.flag_in_flags.where(flaggable_type: record.class.to_s, flaggable_id: record.id).first_or_create!
-      end
-
-      # Remove a record from the given feature. If the feature is not found, an
-      # ActiveRecord::RecordNotFound will be raised.
-      #
-      # @example
-      #   Detour::Feature.remove_record_from_feature user, :new_ui
-      #
-      # @param [ActiveRecord::Base] record A record to remove the feature from.
-      # @param [String,Symbol] feature_name The feature to be removed from the
-      #   record.
-      def remove_record_from_feature(record, feature_name)
-        feature = find_by_name!(feature_name)
-        feature.flag_in_flags.where(flaggable_type: record.class.to_s, flaggable_id: record.id).destroy_all
-      end
-
-      # Opt the given record out of a feature. If the feature is not found, an
-      # ActiveRecord::RecordNotFound will be raised. An opt out ensures that no
-      # matter what, `record.rollout?(:rollout)` will always return false for any
-      # opted-out-of features.
-      #
-      # @param [ActiveRecord::Base] record A record to opt out of the feature.
-      # @param [String,Symbol] feature_name The feature to be opted out of.
-      #
-      # @example
-      #   Detour::Feature.opt_record_out_of_feature user, :new_ui
-      #
-      # @return [Detour::OptOut] The
-      #   {Detour::OptOut OptOut} created.
-      def opt_record_out_of_feature(record, feature_name)
-        feature = find_by_name!(feature_name)
-        feature.opt_out_flags.where(flaggable_type: record.class.to_s, flaggable_id: record.id).first_or_create!
-      end
-
-      # Remove any opt out for the given record out of a feature. If the feature
-      # is not found, an ActiveRecord::RecordNotFound will be raised.
-      #
-      # @example
-      #   Detour::Feature.un_opt_record_out_of_feature user, :new_ui
-      #
-      # @param [ActiveRecord::Base] record A record to un-opt-out of the feature.
-      # @param [String,Symbol] feature_name The feature to be un-opted-out of.
-      def un_opt_record_out_of_feature(record, feature_name)
-        feature = find_by_name!(feature_name)
-        feature.opt_out_flags.where(flaggable_type: record.class.to_s, flaggable_id: record.id).destroy_all
-      end
-
-      # Add a group to the given feature. If the feature is not found, an
-      # ActiveRecord::RecordNotFound will be raised.
-      #
-      # @example
-      #   Detour::Feature.add_group_to_feature "User", "admin", :delete_records
-      #
-      # @param [String] flaggable_type The class (as a string) that the group
-      #   should be associated with.
-      # @param [String] group_name The name of the group to have the feature
-      #   added to it.
-      # @param [String,Symbol] feature_name The feature to be added to the group.
-      #
-      # @return [Detour::Flag] The
-      #   {Detour::Flag Flag} created.
-      def add_group_to_feature(flaggable_type, group_name, feature_name)
-        feature = find_by_name!(feature_name)
-        feature.group_flags.where(flaggable_type: flaggable_type, group_name: group_name).first_or_create!
-      end
-
-      # Remove a group from agiven feature. If the feature is not found, an
-      # ActiveRecord::RecordNotFound will be raised.
-      #
-      # @example
-      #   Detour::Feature.remove_group_from_feature "User", "admin", :delete_records
-      #
-      # @param [String] flaggable_type The class (as a string) that the group should
-      #   be removed from.
-      # @param [String] group_name The name of the group to have the feature
-      #   removed from it.
-      # @param [String,Symbol] feature_name The feature to be removed from the
-      #   group.
-      def remove_group_from_feature(flaggable_type, group_name, feature_name)
-        feature = find_by_name!(feature_name)
-        feature.group_flags.where(flaggable_type: flaggable_type, group_name: group_name).destroy_all
-      end
-
-      # Add a percentage of records to the given feature. If the feature is not
-      # found, an ActiveRecord::RecordNotFound will be raised.
-      #
-      # @example
-      #   Detour::Feature.add_percentage_to_feature "User", 75, :delete_records
-      #
-      # @param [String] flaggable_type The class (as a string) that the percetnage
-      #   should be associated with.
-      # @param [Integer] percentage The percentage of `flaggable_type` records
-      #   that the feature will be available for.
-      # @param [String,Symbol] feature_name The feature to be added to the
-      #   percentage of records.
-      #
-      # @return [Detour::Flag] The
-      #   {Detour::Flag Flag} created.
-      def add_percentage_to_feature(flaggable_type, percentage, feature_name)
-        feature = find_by_name!(feature_name)
-
-        flag = feature.percentage_flags.where(flaggable_type: flaggable_type).first_or_initialize
-        flag.update_attributes!(percentage: percentage)
-      end
-
-      # Remove any percentage flags for the given feature. If the feature is not
-      # found, an ActiveRecord::RecordNotFound will be raised.
-      #
-      # @example
-      #   Detour::Feature.remove_percentage_from_feature "User", delete_records
-      #
-      # @param [String] flaggable_type The class (as a string) that the percetnage
-      #   should be removed from.
-      # @param [String,Symbol] feature_name The feature to have the percentage
-      #   flag removed from.
-      def remove_percentage_from_feature(flaggable_type, feature_name)
-        feature = find_by_name!(feature_name)
-        feature.percentage_flags.where(flaggable_type: flaggable_type).destroy_all
-      end
-    end
-  end
-end

data/app/models/detour/group_flag.rb

@@ -1,13 +0,0 @@
-# A group of flaggable records of a given class may be flagged into a feature
-# with this class.
-class Detour::GroupFlag < Detour::Flag
-  validates_presence_of   :group_name
-  validates_uniqueness_of :feature_id, scope: [:flaggable_type, :group_name]
-
-  attr_writer     :to_keep
-  attr_accessible :group_name
-
-  def to_keep
-    @to_keep || (!marked_for_destruction? && !new_record?)
-  end
-end

data/app/views/detour/features/_success.html.erb

@@ -1 +0,0 @@
-<div class="alert alert-success"><%= flash.notice %></div>

data/app/views/detour/features/error.js.erb

@@ -1,5 +0,0 @@
-if ($(".modal-body .panel-danger").length) {
-  $("#create-feature .modal-body .panel-danger").replaceWith("<%= j render "errors" %>");
-} else {
-  $("#create-feature .modal-body").prepend("<%= j render "errors" %>");
-}