detour 0.0.3 → 0.0.5

data/spec/models/detour/feature_spec.rb

@@ -3,7 +3,8 @@ require "fakefs/spec_helpers"
 
 describe Detour::Feature do
   it { should have_many(:flag_in_flags) }
-  it { should have_many(:group_flags) }
+  it { should have_many(:database_group_flags) }
+  it { should have_many(:defined_group_flags) }
   it { should have_many(:percentage_flags) }
   it { should have_many(:opt_out_flags) }
   it { should have_many(:flags).dependent(:destroy) }
@@ -11,6 +12,20 @@ describe Detour::Feature do
   it { should validate_uniqueness_of :name }
   it { should allow_mass_assignment_of :name }
 
+  it { should allow_value("foo").for(:name) }
+  it { should allow_value("foo_bar").for(:name) }
+  it { should allow_value("foo-bar").for(:name) }
+  it { should_not allow_value("foo-bar.").for(:name) }
+
+  describe "name format validation" do
+    let(:feature) { build :feature, name: "foo bar." }
+
+    it "returns a readable format error" do
+      feature.valid?
+      feature.errors[:name].should eq ["must be composed of letters, numbers, underscores, and dashes"]
+    end
+  end
+
   describe ".with_lines" do
     include FakeFS::SpecHelpers
 
@@ -55,116 +70,6 @@ describe Detour::Feature do
     end
   end
 
-  describe ".add_record_to_feature" do
-    let(:user)    { create :user }
-    let(:feature) { create :feature }
-
-    before do
-      Detour::Feature.add_record_to_feature user, feature.name
-    end
-
-    it "creates a flag for the given instance and feature" do
-      user.features.should include feature
-    end
-  end
-
-  describe ".remove_record_from_feature" do
-    let(:user)    { create :user }
-    let(:feature) { create :feature }
-
-    before do
-      Detour::Feature.add_record_to_feature user, feature.name
-      Detour::Feature.remove_record_from_feature user, feature.name
-    end
-
-    it "creates a flag for the given instance and feature" do
-      user.features.should_not include feature
-    end
-  end
-
-  describe ".opt_record_out_of_feature" do
-    let(:user)    { create :user }
-    let(:feature) { create :feature }
-
-    before do
-      Detour::Feature.add_percentage_to_feature user.class.to_s, 100, feature.name
-      Detour::Feature.opt_record_out_of_feature user, feature.name
-    end
-
-    it "opts the record out of the feature" do
-      user.has_feature?(feature.name).should be_false
-    end
-  end
-
-  describe ".un_opt_record_out_of_feature" do
-    let(:user)    { create :user }
-    let(:feature) { create :feature }
-
-    before do
-      Detour::Feature.add_percentage_to_feature user.class.to_s, 100, feature.name
-      Detour::Feature.opt_record_out_of_feature user, feature.name
-      Detour::Feature.un_opt_record_out_of_feature user, feature.name
-    end
-
-    it "opts the record out of the feature" do
-      user.has_feature?(feature.name).should be_true
-    end
-  end
-
-  describe ".add_group_to_feature" do
-    let(:feature) { create :feature }
-
-    before do
-      Detour.config.define_user_group :bar do
-      end
-      Detour::Feature.add_group_to_feature "User", :bar, feature.name
-    end
-
-    it "creates a flag for the given group and feature" do
-      feature.group_flags.where(flaggable_type: "User", group_name: "bar").first.should_not be_nil
-    end
-  end
-
-  describe ".remove_group_from_feature" do
-    let(:feature) { create :feature }
-
-    before do
-      Detour.config.define_user_group :bar do
-      end
-      Detour::Feature.add_group_to_feature "User", :bar, feature.name
-      Detour::Feature.remove_group_from_feature "User", :bar, feature.name
-    end
-
-    it "destroys flags for the given group and feature" do
-      feature.group_flags.where(flaggable_type: "User", group_name: "bar").first.should be_nil
-    end
-  end
-
-  describe ".add_percentage_to_feature" do
-    let(:feature) { create :feature }
-
-    before do
-      Detour::Feature.add_percentage_to_feature "User", 50, feature.name
-    end
-
-    it "creates a flag for the given percentage and feature" do
-      feature.percentage_flags.where(flaggable_type: "User", percentage: 50).first.should_not be_nil
-    end
-  end
-
-  describe ".remove_percentage_from_feature" do
-    let(:feature) { create :feature }
-
-    before do
-      Detour::Feature.add_percentage_to_feature "User", 50, feature.name
-      Detour::Feature.remove_percentage_from_feature "User", feature.name
-    end
-
-    it "creates a flag for the given percentage and feature" do
-      feature.percentage_flags.where(flaggable_type: "User").first.should be_nil
-    end
-  end
-
   describe "#to_s" do
     let(:feature) { create :feature }
 
@@ -187,8 +92,13 @@ describe Detour::Feature do
       feature.match?(user)
     end
 
-    it "checks if the user is flagged as part of a group" do
-      feature.should_receive(:match_groups?).with(user)
+    it "checks if the user is flagged as part of a database group" do
+      feature.should_receive(:match_database_groups?).with(user)
+      feature.match?(user)
+    end
+
+    it "checks if the user is flagged as part of a defined group" do
+      feature.should_receive(:match_defined_groups?).with(user)
       feature.match?(user)
     end
   end
@@ -236,7 +146,7 @@ describe Detour::Feature do
     let(:feature) { create :feature }
 
     before do
-      Detour::Feature.add_record_to_feature user, feature.name
+      create(:flag_in_flag, flaggable: user, feature: feature)
     end
 
     context "when the feature exists for the instance" do
@@ -272,12 +182,40 @@ describe Detour::Feature do
     end
   end
 
-  describe "#match_groups?" do
+  describe "#match_database_group?" do
+    let(:user)        { create :user, name: "foo" }
+    let(:user2)       { create :user }
+    let(:widget)      { create :widget }
+    let(:feature)     { create :feature }
+    let(:group)       { create :group }
+    let!(:membership) { create :membership, group: group, member: user }
+    let!(:flag)       { create :database_group_flag, feature: feature, flaggable_type: user.class.to_s, group: group }
+
+    context "when the instance is in the group" do
+      it "returns true" do
+        feature.match_database_groups?(user).should be_true
+      end
+    end
+
+    context "when the instance is not in the group" do
+      it "returns false" do
+        feature.match_database_groups?(user2).should be_false
+      end
+    end
+
+    context "when the instance is not of the type of the group" do
+      it "returns false" do
+        feature.match_database_groups?(widget).should be_false
+      end
+    end
+  end
+
+  describe "#match_defined_groups?" do
     let(:user)    { create :user, name: "foo" }
     let(:user2)   { create :user }
     let(:widget)  { create :widget }
     let(:feature) { create :feature }
-    let!(:flag)   { create :group_flag, feature: feature, flaggable_type: user.class.to_s, group_name: "foo_users" }
+    let!(:flag)   { create :defined_group_flag, feature: feature, flaggable_type: user.class.to_s, group_name: "foo_users" }
 
     before do
       Detour.config.define_user_group "foo_users" do |user|
@@ -287,19 +225,19 @@ describe Detour::Feature do
 
     context "when the instance matches the block" do
       it "returns true" do
-        feature.match_groups?(user).should be_true
+        feature.match_defined_groups?(user).should be_true
       end
     end
 
     context "when the instance does not match the block" do
       it "returns false" do
-        feature.match_groups?(user2).should be_false
+        feature.match_defined_groups?(user2).should be_false
       end
     end
 
     context "when the instance is not of the type of the block" do
       it "returns false" do
-        feature.match_groups?(widget).should be_false
+        feature.match_defined_groups?(widget).should be_false
       end
     end
   end

data/spec/models/detour/flag_in_flag_spec.rb

@@ -1,10 +1,7 @@
 require "spec_helper"
 
 describe Detour::FlagInFlag do
-  it { should be_a Detour::Flag }
-  it { should belong_to :flaggable }
-  it { should validate_presence_of :flaggable }
-  it { should allow_mass_assignment_of :flaggable }
+  it { should be_a Detour::FlaggableFlag }
 
   it "validates uniquness of feature_id on flaggable" do
     user  = create :user

data/spec/models/detour/flaggable_flag_spec.rb

@@ -0,0 +1,25 @@
+require "spec_helper"
+
+describe Detour::FlaggableFlag do
+  it { should belong_to :flaggable }
+  it { should validate_presence_of :flaggable }
+  it { should allow_mass_assignment_of :flaggable }
+
+  describe "before validating" do
+    it "sets its flaggable" do
+      feature = create(:feature)
+      user    = create(:user)
+      flag    = create(:flag_in_flag, flaggable: nil, feature: feature, flaggable_key: user.id, flaggable_type: "User")
+      flag.flaggable_id.should eq user.id
+    end
+
+    context "when the flaggable is not found" do
+      let(:flag) { build :flag_in_flag, flaggable: nil, flaggable_key: 1, flaggable_type: "User" }
+
+      it "is invalidated" do
+        flag.valid?
+        flag.errors["User"].should eq ['"1" could not be found']
+      end
+    end
+  end
+end

data/spec/models/detour/group_flag_spec.rb

@@ -1,6 +1,6 @@
 require "spec_helper"
 
-describe Detour::GroupFlag do
+describe Detour::DefinedGroupFlag do
   it { should be_a Detour::Flag }
   it { should validate_presence_of :group_name }
   it { should allow_mass_assignment_of :group_name }

data/spec/models/detour/membership_spec.rb

@@ -0,0 +1,58 @@
+require "spec_helper"
+
+describe Detour::Membership do
+  subject { create :membership }
+
+  it { should validate_presence_of :group_id }
+  it { should validate_presence_of :member_id }
+  it { should validate_presence_of :member_type }
+  it { should validate_uniqueness_of(:member_id).scoped_to(:group_id) }
+
+  it { should allow_mass_assignment_of :group_id }
+  it { should allow_mass_assignment_of :member_key }
+  it { should allow_mass_assignment_of :member_type }
+
+  it { should belong_to :group }
+  it { should belong_to(:member) }
+
+  describe "before validating" do
+    it "sets its member" do
+      group = create(:group, flaggable_type: "User")
+      user  = create(:user)
+      membership = create(:membership, member: nil, group: group, member_key: user.id)
+      membership.member_id.should eq user.id
+    end
+
+    context "when the member is not found" do
+      let(:membership) { build :membership, member: nil, member_key: 1 }
+
+      it "is invalidated" do
+        membership.valid?
+        membership.errors["User"].should eq ['"1" could not be found']
+      end
+    end
+  end
+
+  describe "validate #member_type" do
+    let(:group) { create :group, flaggable_type: "User" }
+
+    context "when its member_type matches its group's flaggable_type" do
+      let(:user) { create :user }
+      let(:membership) { build :membership, group: group, member: user }
+
+      it "is valid" do
+        membership.should be_valid
+      end
+    end
+
+    context "when its member_type does not match its group's flaggable_type" do
+      let(:widget) { create :widget }
+      let(:membership) { build :membership, group: group, member: widget }
+
+      it "is invalid" do
+        membership.valid?
+        membership.errors[:member_type].should eq ["must match the group's flaggable_type"]
+      end
+    end
+  end
+end

data/spec/models/detour/opt_out_flag_spec.rb

@@ -1,10 +1,7 @@
 require "spec_helper"
 
 describe Detour::OptOutFlag do
-  it { should be_a Detour::Flag }
-  it { should belong_to :flaggable }
-  it { should validate_presence_of :flaggable }
-  it { should allow_mass_assignment_of :flaggable }
+  it { should be_a Detour::FlaggableFlag }
 
   it "validates uniquness of feature_id on flaggable" do
     user  = create :user

data/spec/spec_helper.rb

@@ -21,9 +21,12 @@ RSpec.configure do |config|
   config.mock_with :rspec
   config.use_transactional_fixtures = false
   config.infer_base_class_for_anonymous_controllers = false
+  config.color = true
   config.order = "random"
   config.include FactoryGirl::Syntax::Methods
 
+  I18n.enforce_available_locales = false
+
   config.after :each do
     Rake::Task.tasks.each { |t| t.reenable }
   end
@@ -50,6 +53,7 @@ RSpec.configure do |config|
 
   config.before :each do
     User.instance_variable_set "@detour_flaggable_find_by", :id
+    Detour.config.instance_variable_set "@defined_groups", {}
   end
 
   config.after :each do