decidim 0.4.4 → 0.5.0

data/decidim-core/spec/factories.rb

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+require "decidim/core/test/factories"
+
+require "decidim/proposals/test/factories"
+require "decidim/meetings/test/factories"
+require "decidim/results/test/factories"

data/decidim-core/spec/factory_lint_spec.rb

@@ -0,0 +1,9 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+describe "Lint factories", processing_uploads_for: Decidim::AttachmentUploader do
+  it "has 100% valid factories" do
+    expect { FactoryGirl.lint(traits: true) }.not_to raise_error
+  end
+end

data/decidim-core/spec/features/account_spec.rb

@@ -0,0 +1,159 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+describe "Account", type: :feature, perform_enqueued: true do
+  let(:user) { create(:user, :confirmed, password: "password1234", password_confirmation: "password1234") }
+  let(:organization) { user.organization }
+
+  before do
+    switch_to_host(organization.host)
+    login_as user, scope: :user
+  end
+
+  describe "navigation" do
+    it "shows the account form when clicking on the menu" do
+      visit decidim.root_path
+
+      within_user_menu do
+        find("a", text: "account").click
+      end
+
+      expect(page).to have_css("form.edit_user")
+    end
+  end
+
+  context "when on the account page" do
+    before do
+      visit decidim.account_path
+    end
+
+    describe "updating personal data" do
+      it "updates the user's data" do
+        within "form.edit_user" do
+          fill_in :user_name, with: "Nikola Tesla"
+          find("*[type=submit]").click
+        end
+
+        within_flash_messages do
+          expect(page).to have_content("successfully")
+        end
+
+        within ".title-bar" do
+          expect(page).to have_content("Nikola Tesla")
+        end
+      end
+    end
+
+    describe "updating the password" do
+      context "when password and confirmation match" do
+        it "updates the password successfully" do
+          within "form.edit_user" do
+            page.find(".change-password").click
+
+            fill_in :user_password, with: "sekritpass123"
+            fill_in :user_password_confirmation, with: "sekritpass123"
+
+            find("*[type=submit]").click
+          end
+
+          within_flash_messages do
+            expect(page).to have_content("successfully")
+          end
+
+          expect(user.reload.valid_password?("sekritpass123")).to eq(true)
+        end
+      end
+
+      context "when passwords don't match" do
+        it "doesn't update the password" do
+          within "form.edit_user" do
+            page.find(".change-password").click
+
+            fill_in :user_password, with: "sekritpass123"
+            fill_in :user_password_confirmation, with: "oopseytypo"
+
+            find("*[type=submit]").click
+          end
+
+          within_flash_messages do
+            expect(page).to have_content("error")
+          end
+
+          expect(user.reload.valid_password?("sekritpass123")).to eq(false)
+        end
+      end
+
+      context "when updating the email" do
+        it "needs to confirm it" do
+          within "form.edit_user" do
+            fill_in :user_email, with: "foo@bar.com"
+
+            find("*[type=submit]").click
+          end
+
+          within_flash_messages do
+            expect(page).to have_content("email to confirm")
+          end
+        end
+      end
+    end
+
+    context "when on the notifications settings page" do
+      before do
+        visit decidim.notifications_settings_path
+      end
+
+      it "updates the user's notifications" do
+        within ".switch.comments_notifications" do
+          page.find(".switch-paddle").click
+        end
+
+        within ".switch.replies_notifications" do
+          page.find(".switch-paddle").click
+        end
+
+        within ".switch.newsletter_notifications" do
+          page.find(".switch-paddle").click
+        end
+
+        within "form.edit_user" do
+          find("*[type=submit]").click
+        end
+
+        within_flash_messages do
+          expect(page).to have_content("successfully")
+        end
+      end
+    end
+
+    context "when on the delete my account page" do
+      before do
+        visit decidim.delete_account_path
+      end
+
+      it "the user can delete his account" do
+        fill_in :delete_account_delete_reason, with: "I just want to delete my account"
+
+        click_button "Delete my account"
+
+        click_button "Yes, I want to delete my account"
+
+        within_flash_messages do
+          expect(page).to have_content("successfully")
+        end
+
+        find(".sign-in-link").click
+
+        within ".new_user" do
+          fill_in :user_email, with: user.email
+          fill_in :user_password, with: "password1234"
+          find("*[type=submit]").click
+        end
+
+        expect(page).to have_no_content("Signed in successfully")
+        expect(page).to have_no_content(user.name)
+      end
+    end
+  end
+end

data/decidim-core/spec/features/authentication_spec.rb

@@ -0,0 +1,433 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+describe "Authentication", type: :feature, perform_enqueued: true do
+  let(:organization) { create(:organization) }
+  let(:last_user) { Decidim::User.last }
+
+  before do
+    switch_to_host(organization.host)
+    create(:static_page, slug: "terms-and-conditions", organization: organization)
+    visit decidim.root_path
+  end
+
+  describe "Sign Up" do
+    context "using email and password" do
+      it "creates a new User" do
+        find(".sign-up-link").click
+
+        within ".new_user" do
+          fill_in :user_email, with: "user@example.org"
+          fill_in :user_name, with: "Responsible Citizen"
+          fill_in :user_password, with: "123456"
+          fill_in :user_password_confirmation, with: "123456"
+          check :user_tos_agreement
+          find("*[type=submit]").click
+        end
+
+        expect(page).to have_content("confirmation link")
+      end
+    end
+
+    context "being a robot" do
+      it "denies the sign up" do
+        find(".sign-up-link").click
+
+        within "form#new_user" do
+          page.execute_script("$($('form#new_user > div > input')[0]).val('Ima robot :D')")
+          fill_in :user_email, with: "user@example.org"
+          fill_in :user_name, with: "Responsible Citizen"
+          fill_in :user_password, with: "123456"
+          fill_in :user_password_confirmation, with: "123456"
+          check :user_tos_agreement
+          find("*[type=submit]").click
+        end
+
+        expect(page).to have_no_content("confirmation link")
+      end
+    end
+
+    context "using facebook" do
+      let(:verified) { true }
+      let(:omniauth_hash) do
+        OmniAuth::AuthHash.new(
+          provider: "facebook",
+          uid: "123545",
+          info: {
+            email: "user@from-facebook.com",
+            name: "Facebook User"
+          }
+        )
+      end
+
+      before :each do
+        OmniAuth.config.test_mode = true
+        OmniAuth.config.mock_auth[:facebook] = omniauth_hash
+      end
+
+      after :each do
+        OmniAuth.config.test_mode = false
+        OmniAuth.config.mock_auth[:facebook] = nil
+      end
+
+      context "when the user has confirmed the email in facebook" do
+        it "creates a new User without sending confirmation instructions" do
+          find(".sign-up-link").click
+
+          click_link "Sign in with Facebook"
+
+          expect(page).to have_content("Successfully")
+          expect_user_logged
+        end
+      end
+    end
+
+    context "using twitter" do
+      let(:email) { nil }
+      let(:omniauth_hash) do
+        OmniAuth::AuthHash.new(
+          provider: "twitter",
+          uid: "123545",
+          info: {
+            name: "Twitter User",
+            email: email
+          }
+        )
+      end
+
+      before :each do
+        OmniAuth.config.test_mode = true
+        OmniAuth.config.mock_auth[:twitter] = omniauth_hash
+      end
+
+      after :each do
+        OmniAuth.config.test_mode = false
+        OmniAuth.config.mock_auth[:twitter] = nil
+      end
+
+      context "when the response doesn't include the email" do
+        it "redirects the user to a finish signup page" do
+          find(".sign-up-link").click
+
+          click_link "Sign in with Twitter"
+
+          expect(page).to have_content("Successfully")
+          expect(page).to have_content("Please complete your profile")
+
+          within ".new_user" do
+            fill_in :user_email, with: "user@from-twitter.com"
+            find("*[type=submit]").click
+          end
+
+          expect(page).to have_content("confirmation link")
+        end
+
+        context "and a user already exists with the given email" do
+          it "doesn't allow it" do
+            create(:user, :confirmed, email: "user@from-twitter.com", organization: organization)
+            find(".sign-up-link").click
+
+            click_link "Sign in with Twitter"
+
+            expect(page).to have_content("Successfully")
+            expect(page).to have_content("Please complete your profile")
+
+            within ".new_user" do
+              fill_in :user_email, with: "user@from-twitter.com"
+              find("*[type=submit]").click
+            end
+
+            expect(page).to have_content("Please complete your profile")
+            expect(page).to have_content("Another account is using the same email address")
+          end
+        end
+      end
+
+      context "when the response includes the email" do
+        let(:email) { "user@from-twitter.com" }
+
+        it "creates a new User" do
+          find(".sign-up-link").click
+
+          click_link "Sign in with Twitter"
+
+          expect_user_logged
+        end
+      end
+    end
+
+    context "using google" do
+      let(:omniauth_hash) do
+        OmniAuth::AuthHash.new(
+          provider: "google_oauth2",
+          uid: "123545",
+          info: {
+            name: "Google User",
+            email: "user@from-google.com"
+          }
+        )
+      end
+
+      before :each do
+        OmniAuth.config.test_mode = true
+        OmniAuth.config.mock_auth[:google_oauth2] = omniauth_hash
+      end
+
+      after :each do
+        OmniAuth.config.test_mode = false
+        OmniAuth.config.mock_auth[:google_oauth2] = nil
+      end
+
+      it "creates a new User" do
+        find(".sign-up-link").click
+
+        click_link "Sign in with Google"
+
+        expect_user_logged
+      end
+    end
+  end
+
+  describe "Sign Up as a organization" do
+    it "creates a new User" do
+      find(".sign-up-link").click
+
+      within ".new_user" do
+        choose "Organization/Collective"
+
+        fill_in :user_email, with: "user@example.org"
+        fill_in :user_name, with: "Responsible Citizen"
+        fill_in :user_password, with: "123456"
+        fill_in :user_password_confirmation, with: "123456"
+
+        fill_in :user_user_group_name, with: "My organization"
+        fill_in :user_user_group_document_number, with: "12345678Z"
+        fill_in :user_user_group_phone, with: "333-333-3333"
+
+        check :user_tos_agreement
+        find("*[type=submit]").click
+      end
+
+      expect(page).to have_content("confirmation link")
+    end
+  end
+
+  describe "Confirm email" do
+    it "confirms the user" do
+      create(:user, organization: organization)
+
+      visit last_email_link
+
+      expect(page).to have_content("successfully confirmed")
+      expect(last_user).to be_confirmed
+    end
+  end
+
+  describe "Resend confirmation instructions" do
+    let(:user) { create(:user, organization: organization) }
+
+    it "sends an email with the instructions" do
+      visit decidim.new_user_confirmation_path
+
+      within ".new_user" do
+        fill_in :user_email, with: user.email
+        find("*[type=submit]").click
+      end
+
+      expect(emails.count).to eq(2)
+      expect(page).to have_content("receive an email with instructions")
+    end
+  end
+
+  context "When a user is already registered" do
+    let(:user) { create(:user, :confirmed, organization: organization) }
+
+    describe "Sign in" do
+      it "authenticates an existing User" do
+        find(".sign-in-link").click
+
+        within ".new_user" do
+          fill_in :user_email, with: user.email
+          fill_in :user_password, with: "password1234"
+          find("*[type=submit]").click
+        end
+
+        expect(page).to have_content("Signed in successfully")
+        expect(page).to have_content(user.name)
+      end
+    end
+
+    describe "Forgot password" do
+      it "sends a password recovery email" do
+        visit decidim.new_user_password_path
+
+        within ".new_user" do
+          fill_in :user_email, with: user.email
+          find("*[type=submit]").click
+        end
+
+        expect(page).to have_content("reset your password")
+        expect(emails.count).to eq(1)
+      end
+    end
+
+    describe "Reset password" do
+      before do
+        user.send_reset_password_instructions
+      end
+
+      it "sets a new password for the user" do
+        visit last_email_link
+
+        within ".new_user" do
+          fill_in :user_password, with: "123456"
+          fill_in :user_password_confirmation, with: "123456"
+          find("*[type=submit]").click
+        end
+
+        expect(page).to have_content("password has been changed successfully")
+      end
+    end
+
+    describe "Sign Out" do
+      before do
+        login_as user, scope: :user
+        visit decidim.root_path
+      end
+
+      it "signs out the user" do
+        within ".topbar__user__logged" do
+          find("ul").hover
+          find(".sign-out-link").click
+        end
+
+        expect(page).to have_content("Signed out successfully.")
+        expect(page).to have_no_content(user.name)
+      end
+    end
+  end
+
+  context "When a user is already registered with a social provider" do
+    let(:user) { create(:user, :confirmed, organization: organization) }
+    let(:identity) { create(:identity, user: user, provider: "facebook", uid: "12345") }
+
+    let(:omniauth_hash) do
+      OmniAuth::AuthHash.new(
+        provider: identity.provider,
+        uid: identity.uid,
+        info: {
+          email: user.email,
+          name: "Facebook User",
+          verified: true
+        }
+      )
+    end
+
+    before :each do
+      OmniAuth.config.test_mode = true
+      OmniAuth.config.mock_auth[:facebook] = omniauth_hash
+    end
+
+    after :each do
+      OmniAuth.config.test_mode = false
+      OmniAuth.config.mock_auth[:facebook] = nil
+    end
+
+    describe "Sign in" do
+      it "authenticates an existing User" do
+        find(".sign-in-link").click
+
+        click_link "Sign in with Facebook"
+
+        expect(page).to have_content("Successfully")
+        expect(page).to have_content(user.name)
+      end
+    end
+  end
+
+  context "When a user is already registered in another organization with the same email" do
+    let(:user) { create(:user, :confirmed) }
+
+    describe "Sign Up" do
+      context "using the same email" do
+        it "creates a new User" do
+          find(".sign-up-link").click
+
+          within ".new_user" do
+            fill_in :user_email, with: user.email
+            fill_in :user_name, with: "Responsible Citizen"
+            fill_in :user_password, with: "123456"
+            fill_in :user_password_confirmation, with: "123456"
+            check :user_tos_agreement
+            find("*[type=submit]").click
+          end
+
+          expect(page).to have_content("confirmation link")
+        end
+      end
+    end
+  end
+
+  context "When a user is already registered in another organization with the same fb account" do
+    let(:user) { create(:user, :confirmed) }
+    let(:identity) { create(:identity, user: user, provider: "facebook", uid: "12345") }
+
+    let(:omniauth_hash) do
+      OmniAuth::AuthHash.new(
+        provider: identity.provider,
+        uid: identity.uid,
+        info: {
+          email: user.email,
+          name: "Facebook User",
+          verified: true
+        }
+      )
+    end
+
+    before :each do
+      OmniAuth.config.test_mode = true
+      OmniAuth.config.mock_auth[:facebook] = omniauth_hash
+    end
+
+    after :each do
+      OmniAuth.config.test_mode = false
+      OmniAuth.config.mock_auth[:facebook] = nil
+    end
+
+    describe "Sign Up" do
+      context "when the user has confirmed the email in facebook" do
+        it "creates a new User without sending confirmation instructions" do
+          find(".sign-up-link").click
+
+          click_link "Sign in with Facebook"
+
+          expect(page).to have_content("Successfully")
+          expect_user_logged
+        end
+      end
+    end
+  end
+
+  context "when a user with the same email is already registered in another organization" do
+    let(:organization2) { create(:organization) }
+
+    let!(:user2) { create(:user, :confirmed, email: "fake@user.com", name: "Wrong user", organization: organization2) }
+    let!(:user) { create(:user, :confirmed, email: "fake@user.com", name: "Right user", organization: organization) }
+
+    describe "Sign in" do
+      it "authenticates the right user" do
+        find(".sign-in-link").click
+
+        within ".new_user" do
+          fill_in :user_email, with: user.email
+          fill_in :user_password, with: "password1234"
+          find("*[type=submit]").click
+        end
+
+        expect(page).to have_content("successfully")
+        expect(page).to have_content("Right user")
+      end
+    end
+  end
+end