decidim 0.4.4 → 0.5.0

data/decidim-admin/spec/features/admin_manages_managed_users_spec.rb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+describe "Admin manages managed users", type: :feature do
+  let(:user) { create(:user, :admin, :confirmed, organization: organization) }
+
+  def navigate_to_managed_users_page
+    visit decidim_admin.root_path
+    click_link "Users"
+    click_link "Managed users"
+  end
+
+  it_behaves_like "manage managed users examples"
+end

data/decidim-admin/spec/features/admin_manages_organization_admins_spec.rb

@@ -41,6 +41,29 @@ describe "Organization admins", type: :feature do
       end
     end
 
+    it "can invite a user with a specific role" do
+      within ".card-title" do
+        find(".button--title").click
+      end
+
+      within ".new_user" do
+        fill_in :user_name, with: "New user manager"
+        fill_in :user_email, with: "newusermanager@example.org"
+        select "User manager", from: :user_role
+
+        find("*[type=submit]").click
+      end
+
+      within ".callout-wrapper" do
+        expect(page).to have_content("successfully")
+      end
+
+      within "table" do
+        expect(page).to have_content("New user manager")
+        expect(page).to have_content("User manager")
+      end
+    end
+
     context "with existing users" do
       let!(:user) do
         user = build(:user, :confirmed, :admin, organization: organization)
@@ -68,7 +91,7 @@ describe "Organization admins", type: :feature do
           page.find(".action-icon.action-icon--remove").click
         end
 
-        expect(page).not_to have_content(other_admin.name)
+        expect(page).to have_no_content(other_admin.name)
       end
     end
   end

data/decidim-admin/spec/features/admin_manages_organization_scopes_spec.rb

@@ -13,6 +13,8 @@ describe "Organization scopes", type: :feature do
   end
 
   describe "Managing scopes" do
+    let!(:scope_type) { create(:scope_type, organization: admin.organization) }
+
     before do
       login_as admin, scope: :user
       visit decidim_admin.root_path
@@ -24,7 +26,11 @@ describe "Organization scopes", type: :feature do
       click_link "Add"
 
       within ".new_scope" do
-        fill_in :scope_name, with: "My nice district"
+        fill_in_i18n :scope_name, "#scope-name-tabs", en: "My nice district",
+                                                      es: "Mi lindo distrito",
+                                                      ca: "El meu bonic barri"
+        fill_in "Code", with: "MY-DISTRICT"
+        select scope_type.name["en"], from: :scope_scope_type_id
 
         find("*[type=submit]").click
       end
@@ -46,12 +52,14 @@ describe "Organization scopes", type: :feature do
       end
 
       it "can edit them" do
-        within find("tr", text: scope.name) do
+        within find("tr", text: translated(scope.name)) do
           page.find("a.action-icon.action-icon--edit").click
         end
 
         within ".edit_scope" do
-          fill_in :scope_name, with: "Another district"
+          fill_in_i18n :scope_name, "#scope-name-tabs", en: "Another district",
+                                                        es: "Otro distrito",
+                                                        ca: "Un altre districte"
           find("*[type=submit]").click
         end
 
@@ -65,7 +73,7 @@ describe "Organization scopes", type: :feature do
       end
 
       it "can destroy them" do
-        within find("tr", text: scope.name) do
+        within find("tr", text: translated(scope.name)) do
           page.find("a.action-icon.action-icon--remove").click
         end
 
@@ -73,8 +81,34 @@ describe "Organization scopes", type: :feature do
           expect(page).to have_content("successfully")
         end
 
+        within ".card-section" do
+          expect(page).to have_no_content(translated(scope.name))
+        end
+      end
+
+      it "can create a new subcope" do
+        within find("tr", text: translated(scope.name)) do
+          page.find("td:first-child a").click
+        end
+
+        click_link "Add"
+
+        within ".new_scope" do
+          fill_in_i18n :scope_name, "#scope-name-tabs", en: "My nice subdistrict",
+                                                        es: "Mi lindo subdistrito",
+                                                        ca: "El meu bonic subbarri"
+          fill_in "Code", with: "MY-SUBDISTRICT"
+          select scope_type.name["en"], from: :scope_scope_type_id
+
+          find("*[type=submit]").click
+        end
+
+        within ".callout-wrapper" do
+          expect(page).to have_content("successfully")
+        end
+
         within "table" do
-          expect(page).not_to have_content(scope.name)
+          expect(page).to have_content("My nice subdistrict")
         end
       end
     end

data/decidim-admin/spec/features/admin_manages_participatory_process_groups_spec.rb

@@ -1,4 +1,3 @@
-# -*- coding: utf-8 -*-
 # frozen_string_literal: true
 
 require "spec_helper"
@@ -100,7 +99,7 @@ describe "Admin manages participatory process groups", type: :feature do
       end
 
       within "table" do
-        expect(page).not_to have_content(participatory_process_group.name["en"])
+        expect(page).to have_no_content(participatory_process_group.name["en"])
       end
     end
   end

data/decidim-admin/spec/features/admin_manages_participatory_processes_spec.rb

@@ -1,4 +1,3 @@
-# -*- coding: utf-8 -*-
 # frozen_string_literal: true
 
 require "spec_helper"
@@ -6,6 +5,7 @@ require "spec_helper"
 describe "Admin manages participatory processes", type: :feature do
   include_context "participatory process administration by admin"
   it_behaves_like "manage processes examples"
+  it_behaves_like "manage processes announcements"
 
   before do
     switch_to_host(organization.host)
@@ -108,7 +108,7 @@ describe "Admin manages participatory processes", type: :feature do
       end
 
       within "table" do
-        expect(page).not_to have_content(translated(participatory_process2.title))
+        expect(page).to have_no_content(translated(participatory_process2.title))
       end
     end
   end

data/decidim-admin/spec/features/admin_manages_user_groups_spec.rb

@@ -1,10 +1,11 @@
-# -*- coding: utf-8 -*-
 # frozen_string_literal: true
 
 require "spec_helper"
 
 describe "Admin manages user groups", type: :feature do
-  include_context "participatory process administration by admin"
+  let(:organization) { create(:organization) }
+
+  let!(:user) { create(:user, :admin, :confirmed, organization: organization) }
 
   let!(:user_groups) { create_list(:user_group, 10, users: [create(:user, organization: organization)]) }
 

data/decidim-admin/spec/features/participatory_process_admin_manages_participatory_process_admins_spec.rb

@@ -17,7 +17,7 @@ describe "Participatory process admin manages participatory process admins", typ
 
     it "cannot remove himself" do
       within find("#process_admins tr", text: user.email) do
-        expect(page).not_to have_content("Destroy")
+        expect(page).to have_no_content("Destroy")
       end
     end
   end

data/decidim-admin/spec/features/participatory_process_admin_manages_participatory_processes_spec.rb

@@ -6,6 +6,7 @@ describe "Participatory process admin manages participatory processes", type: :f
   include_context "participatory process administration by process admin"
 
   it_behaves_like "manage processes examples"
+  it_behaves_like "manage processes announcements"
 
   before do
     switch_to_host(organization.host)
@@ -14,7 +15,7 @@ describe "Participatory process admin manages participatory processes", type: :f
   end
 
   it "cannot create a new participatory_process" do
-    expect(page).not_to have_selector(".actions .new")
+    expect(page).to have_no_selector(".actions .new")
   end
 
   context "deleting a participatory process" do
@@ -27,7 +28,7 @@ describe "Participatory process admin manages participatory processes", type: :f
 
     it "cannot delete a participatory_process" do
       within find("tr", text: translated(participatory_process2.title)) do
-        expect(page).not_to have_content("Destroy")
+        expect(page).to have_no_content("Destroy")
       end
     end
   end

data/decidim-admin/spec/features/static_pages_spec.rb

@@ -117,7 +117,7 @@ describe "Content pages", type: :feature do
         end
 
         within "table" do
-          expect(page).not_to have_content(translated(decidim_page.title))
+          expect(page).to have_no_content(translated(decidim_page.title))
         end
       end
 

data/decidim-admin/spec/features/user_manager_managed_users_spec.rb

@@ -0,0 +1,14 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+describe "User manager manages managed users", type: :feature do
+  let(:user) { create(:user, :user_manager, :confirmed, organization: organization) }
+
+  def navigate_to_managed_users_page
+    visit decidim_admin.root_path
+    click_link "Users"
+  end
+
+  it_behaves_like "manage managed users examples"
+end

data/decidim-admin/spec/forms/impersonate_managed_user_form_spec.rb

@@ -0,0 +1,33 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+module Decidim
+  module Admin
+    describe ImpersonateManagedUserForm do
+      let(:organization) { create :organization }
+      let(:authorization) do
+        {
+          handler_name: "decidim/dummy_authorization_handler",
+          document_number: "12345678X"
+        }
+      end
+      let(:attributes) do
+        {
+          authorization: authorization
+        }
+      end
+      subject do
+        described_class.from_params(
+          attributes
+        ).with_context(
+          current_organization: organization
+        )
+      end
+
+      context "when everything is OK" do
+        it { is_expected.to be_valid }
+      end
+    end
+  end
+end

data/decidim-admin/spec/forms/managed_user_form_spec.rb

@@ -0,0 +1,53 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+module Decidim
+  module Admin
+    describe ManagedUserForm do
+      let(:organization) { create :organization }
+      let(:name) { "Foo" }
+      let(:authorization) do
+        {
+          handler_name: "decidim/dummy_authorization_handler",
+          document_number: "12345678X"
+        }
+      end
+      let(:attributes) do
+        {
+          name: name,
+          authorization: authorization
+        }
+      end
+      subject do
+        described_class.from_params(
+          attributes
+        ).with_context(
+          current_organization: organization
+        )
+      end
+
+      context "when everything is OK" do
+        it { is_expected.to be_valid }
+      end
+
+      context "when the name is not present" do
+        let(:name) { nil }
+
+        it { is_expected.not_to be_valid }
+      end
+
+      context "when the authorization already exists for another user" do
+        before do
+          Authorization.create!(
+            user: create(:user, organization: organization),
+            name: authorization[:handler_name],
+            unique_id: authorization[:document_number]
+          )
+        end
+
+        it { is_expected.not_to be_valid }
+      end
+    end
+  end
+end

data/decidim-admin/spec/forms/managed_user_promotion_form_spec.rb

@@ -0,0 +1,30 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+module Decidim
+  module Admin
+    describe ManagedUserPromotionForm do
+      let(:email) { "foo@example.org" }
+      let(:attributes) do
+        {
+          "managed_user_promotion" => {
+            "email" => email
+          }
+        }
+      end
+
+      subject { described_class.from_params(attributes) }
+
+      context "when everything is OK" do
+        it { is_expected.to be_valid }
+      end
+
+      context "when email is missing" do
+        let(:email) {}
+
+        it { is_expected.to be_invalid }
+      end
+    end
+  end
+end

data/decidim-admin/spec/forms/organization_form_spec.rb

@@ -1,4 +1,3 @@
-# -*- coding: utf-8 -*-
 # frozen_string_literal: true
 
 require "spec_helper"
@@ -28,11 +27,7 @@ module Decidim
         }
       end
       let(:organization) { create(:organization) }
-      let(:homepage_image_path) do
-        File.expand_path(
-          File.join(__dir__, "..", "..", "..", "decidim-dev", "spec", "support", "city.jpeg")
-        )
-      end
+      let(:homepage_image_path) { Decidim::Dev.asset("city.jpeg") }
       let(:attributes) do
         {
           "organization" => {

data/decidim-admin/spec/forms/participatory_process_form_spec.rb

@@ -59,9 +59,6 @@ module Decidim
           }
         }
       end
-      before do
-        Decidim::AttachmentUploader.enable_processing = true
-      end
 
       subject { described_class.from_params(attributes).with_context(current_organization: organization) }
 

data/decidim-admin/spec/forms/participatory_process_group_form_spec.rb

@@ -36,10 +36,6 @@ module Decidim
         }
       end
 
-      before do
-        Decidim::AttachmentUploader.enable_processing = true
-      end
-
       subject { described_class.from_params(attributes).with_context(current_organization: organization) }
 
       context "when everything is OK" do

data/decidim-admin/spec/forms/scope_form_spec.rb

@@ -5,12 +5,16 @@ require "spec_helper"
 module Decidim
   module Admin
     describe ScopeForm do
-      let(:name) { "my_name" }
-      let(:organization) { create(:organization) }
+      let(:organization) { create :organization }
+      let(:name) { Decidim::Faker::Localized.literal(::Faker::Address.unique.state) }
+      let(:code) { ::Faker::Address.unique.state_abbr }
+      let(:scope_type) { create :scope_type }
       let(:attributes) do
         {
           "scope" => {
-            "name" => name
+            "name" => name,
+            "code" => code,
+            "scope_type" => scope_type
           }
         }
       end
@@ -27,31 +31,31 @@ module Decidim
       end
 
       context "when name is missing" do
-        let(:name) { nil }
+        let(:name) { {} }
 
         it { is_expected.to be_invalid }
       end
 
-      context "when organization is missing" do
-        let(:organization) { nil }
+      context "when code is missing" do
+        let(:code) { "" }
 
         it { is_expected.to be_invalid }
       end
 
-      context "when slug is not unique" do
+      context "when code is not unique" do
         before do
-          create(:scope, organization: organization, name: name)
+          create(:scope, organization: organization, code: code)
         end
 
         it "is not valid" do
           expect(subject).not_to be_valid
-          expect(subject.errors[:name]).not_to be_empty
+          expect(subject.errors[:code]).not_to be_empty
         end
       end
 
-      context "when the slug exists in another organization" do
+      context "when the code exists in another organization" do
         before do
-          create(:scope, name: name)
+          create(:scope, code: code)
         end
 
         it { is_expected.to be_valid }