decidim 0.2.0 → 0.3.0

data/decidim-surveys/spec/forms/decidim/surveys/admin/survey_form_spec.rb

@@ -0,0 +1,64 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+module Decidim
+  module Surveys
+    module Admin
+      describe SurveyForm do
+        let(:current_organization) { create(:organization) }
+
+        let(:description) do
+          {
+            "en" => "<p>Content</p>",
+            "ca" => "<p>Contingut</p>",
+            "es" => "<p>Contenido</p>"
+          }
+        end
+
+        let(:questions) do
+          [
+            {
+              body: {
+                "en" => "First question",
+                "ca" => "Primera pregunta",
+                "es" => "Primera pregunta"
+              },
+              position: 0,
+              question_type: "short_answer"
+            },
+            {
+              body: {
+                "en" => "Second question",
+                "ca" => "Segona pregunta",
+                "es" => "Segunda pregunta"
+              },
+              position: 1,
+              mandatory: true,
+              question_type: "short_answer"
+            }
+          ]
+        end
+
+        let(:attributes) do
+          {
+            "survey" => {
+              "description" => description,
+              "questions" => questions
+            }
+          }
+        end
+
+        subject do
+          described_class.from_params(attributes).with_context(
+            current_organization: current_organization
+          )
+        end
+
+        context "when everything is OK" do
+          it { is_expected.to be_valid }
+        end
+      end
+    end
+  end
+end

data/decidim-surveys/spec/forms/decidim/surveys/admin/survey_question_form_spec.rb

@@ -0,0 +1,36 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+module Decidim
+  module Surveys
+    module Admin
+      describe SurveyQuestionForm do
+        let!(:survey) { create(:survey) }
+        let!(:position) { 0 }
+        let!(:question_type) { SurveyQuestion::TYPES.first }
+        let!(:survey_question) { create(:survey_question, survey: survey, position: position, question_type: question_type) }
+
+        subject do
+          described_class.from_model(survey_question).with_context(current_feature: survey.feature)
+        end
+
+        context "when everything is OK" do
+          it { is_expected.to be_valid }
+        end
+
+        context "when the position is not present" do
+          let!(:position) { nil }
+
+          it { is_expected.not_to be_valid }
+        end
+
+        context "when the question_type is not known" do
+          let!(:question_type) { "foo" }
+
+          it { is_expected.not_to be_valid }
+        end
+      end
+    end
+  end
+end

data/decidim-surveys/spec/forms/decidim/surveys/survey_answer_form_spec.rb

@@ -0,0 +1,36 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+module Decidim
+  module Surveys
+    describe SurveyAnswerForm do
+      let!(:survey) { create(:survey) }
+      let!(:user) { create(:user, organization: survey.feature.participatory_process.organization) }
+      let!(:survey_question) { create(:survey_question, survey: survey) }
+      let!(:survey_answer) { create(:survey_answer, user: user, survey: survey, question: survey_question) }
+
+      subject do
+        described_class.from_model(survey_answer).with_context(current_feature: survey.feature)
+      end
+
+      context "when everything is OK" do
+        it { is_expected.to be_valid }
+      end
+
+      context "when the question is mandatory" do
+        let!(:survey_question) { create(:survey_question, survey: survey, mandatory: true) }
+
+        it "is not valid if body is not present" do
+          subject.body = nil
+          expect(subject).not_to be_valid
+        end
+
+        it "is not valid if body entries are all blank" do
+          subject.body = [""]
+          expect(subject).not_to be_valid
+        end
+      end
+    end
+  end
+end

data/decidim-surveys/spec/forms/decidim/surveys/survey_form_spec.rb

@@ -0,0 +1,32 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+module Decidim
+  module Surveys
+    describe SurveyForm do
+      let!(:survey) { create(:survey) }
+      let!(:survey_question) { create(:survey_question, survey: survey) }
+
+      subject do
+        described_class.from_model(survey).with_context(current_feature: survey.feature)
+      end
+
+      it "builds empty answers for each question" do
+        expect(subject.answers.length).to eq(1)
+      end
+
+      context "when tos_agreement is not accepted" do
+        it { is_expected.not_to be_valid }
+      end
+
+      context "when tos_agreement is not accepted" do
+        before do
+          subject.tos_agreement = true
+        end
+
+        it { is_expected.to be_valid }
+      end
+    end
+  end
+end

data/decidim-surveys/spec/models/decidim/surveys/abilities/admin_user_spec.rb

@@ -0,0 +1,22 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+describe Decidim::Surveys::Abilities::AdminUser do
+  let(:user) { build(:user, :admin) }
+  let(:context) { {} }
+
+  subject { described_class.new(user, context) }
+
+  context "when the user is not an admin" do
+    let(:user) { build(:user) }
+
+    it "doesn't have any permission" do
+      expect(subject.permissions[:can]).to be_empty
+      expect(subject.permissions[:cannot]).to be_empty
+    end
+  end
+
+  it { is_expected.to be_able_to(:manage, Decidim::Surveys::Survey) }
+  it { is_expected.to be_able_to(:answer, Decidim::Surveys::Survey) }
+end

data/decidim-surveys/spec/models/decidim/surveys/abilities/current_user_spec.rb

@@ -0,0 +1,19 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+describe Decidim::Surveys::Abilities::CurrentUser do
+  let(:organization) { build(:organization) }
+  let(:user) { build(:user, organization: organization) }
+  let(:participatory_process) { build(:participatory_process, organization: organization) }
+  let(:surveys_feature) { build(:surveys_feature, participatory_process: participatory_process) }
+  let(:context) do
+    {
+      current_feature: surveys_feature
+    }
+  end
+
+  subject { described_class.new(user, context) }
+
+  it { is_expected.to be_able_to(:answer, Decidim::Surveys::Survey) }
+end

data/decidim-surveys/spec/models/decidim/surveys/abilities/process_admin_user_spec.rb

@@ -0,0 +1,23 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+describe Decidim::Surveys::Abilities::ProcessAdminUser do
+  let(:user) { build(:user) }
+  let(:user_process) { create :participatory_process, organization: user.organization }
+  let(:context) { {} }
+
+  subject { described_class.new(user, context) }
+
+  context "when the user is an admin" do
+    let(:user) { build(:user, :admin) }
+
+    it "doesn't have any permission" do
+      expect(subject.permissions[:can]).to be_empty
+      expect(subject.permissions[:cannot]).to be_empty
+    end
+  end
+
+  it { is_expected.to be_able_to(:manage, Decidim::Surveys::Survey) }
+  it { is_expected.to be_able_to(:answer, Decidim::Surveys::Survey) }
+end

data/decidim-surveys/spec/models/decidim/surveys/survey_answer_spec.rb

@@ -0,0 +1,55 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+module Decidim
+  module Surveys
+    describe SurveyAnswer do
+      let(:organization) { create(:organization) }
+      let(:user) { create(:user, organization: organization) }
+      let(:participatory_process) { create(:participatory_process, organization: organization) }
+      let(:feature) { create(:surveys_feature, participatory_process: participatory_process) }
+      let(:survey) { create(:survey, feature: feature) }
+      let(:survey_question) { create(:survey_question, survey: survey) }
+      let(:survey_answer) { create(:survey_answer, survey: survey, question: survey_question, user: user) }
+      subject { survey_answer }
+
+      it { is_expected.to be_valid }
+
+      it "has an association of survey" do
+        expect(subject.survey).to eq(survey)
+      end
+
+      it "has an association of question" do
+        expect(subject.question).to eq(survey_question)
+      end
+
+      it "has an association of user" do
+        expect(subject.user).to eq(user)
+      end
+
+      context "when the user doesn't belong to the same organization" do
+        it "is not valid" do
+          subject.user = create(:user)
+          expect(subject).not_to be_valid
+        end
+      end
+
+      context "when question doesn't belong to the survey" do
+        it "is not valid" do
+          subject.question = create(:survey_question)
+          expect(subject).not_to be_valid
+        end
+      end
+
+      context "when question is mandatory" do
+        let(:survey_question) { create(:survey_question, survey: survey, mandatory: true) }
+
+        it "is not valid with an empty body" do
+          subject.body = ""
+          expect(subject).not_to be_valid
+        end
+      end
+    end
+  end
+end

data/decidim-surveys/spec/models/decidim/surveys/survey_question_spec.rb

@@ -0,0 +1,19 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+module Decidim
+  module Surveys
+    describe SurveyQuestion do
+      let(:survey) { create(:survey) }
+      let(:survey_question) { create(:survey_question, survey: survey) }
+      subject { survey_question }
+
+      it { is_expected.to be_valid }
+
+      it "has an association of survey" do
+        expect(subject.survey).to eq(survey)
+      end
+    end
+  end
+end

data/decidim-surveys/spec/models/decidim/surveys/survey_spec.rb

@@ -0,0 +1,65 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+module Decidim
+  module Surveys
+    describe Survey do
+      let(:survey) { create(:survey) }
+      subject { survey }
+
+      include_examples "has feature"
+
+      it { is_expected.to be_valid }
+
+      it "has an association of questions" do
+        subject.questions << create(:survey_question)
+        subject.questions << create(:survey_question)
+        expect(subject.questions.count).to eq(2)
+      end
+
+      it "has an association of answers" do
+        create(:survey_answer, survey: subject, user: create(:user, organization: survey.feature.organization))
+        create(:survey_answer, survey: subject, user: create(:user, organization: survey.feature.organization))
+        expect(subject.reload.answers.count).to eq(2)
+      end
+
+      context "without a feature" do
+        let(:survey) { build :survey, feature: nil }
+
+        it { is_expected.not_to be_valid }
+      end
+
+      context "without a valid feature" do
+        let(:survey) { build :survey, feature: build(:feature, manifest_name: "proposals") }
+
+        it { is_expected.not_to be_valid }
+      end
+
+      it "has an associated feature" do
+        expect(survey.feature).to be_a(Decidim::Feature)
+      end
+
+      context "#questions_editable?" do
+        it "returns false when survey has already answers" do
+          create(:survey_answer, survey: survey)
+          expect(subject.reload).not_to be_questions_editable
+        end
+      end
+
+      context "#answered_by?" do
+        let!(:user) { create(:user, organization: survey.feature.participatory_process.organization) }
+        let!(:question) { create(:survey_question, survey: survey) }
+
+        it "returns false if the given user has not answered the survey" do
+          expect(survey.answered_by?(user)).to be_falsy
+        end
+
+        it "returns true if the given user has answered the survey" do
+          create(:survey_answer, survey: survey, question: question, user: user)
+          expect(survey.answered_by?(user)).to be_truthy
+        end
+      end
+    end
+  end
+end

data/decidim-surveys/spec/queries/decidim/surveys/survey_user_answers_spec.rb

@@ -0,0 +1,21 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+describe Decidim::Surveys::SurveyUserAnswers do
+  let!(:survey) { create(:survey) }
+  let!(:user_1) { create(:user, organization: survey.feature.organization) }
+  let!(:user_2) { create(:user, organization: survey.feature.organization) }
+  let!(:survey_questions) { 3.downto(1).map { |n| create :survey_question, survey: survey, position: n } }
+  let!(:survey_answers_user_1) { survey_questions.map { |question| create :survey_answer, user: user_1, survey: survey, question: question } }
+  let!(:survey_answers_user_2) { survey_questions.map { |question| create :survey_answer, user: user_2, survey: survey, question: question } }
+
+  subject { described_class.new(survey) }
+
+  it "returns the user answers for each user" do
+    result = subject.query
+
+    expect(result[0]).to eq(survey_answers_user_1.sort { |answer| answer.question.position })
+    expect(result[1]).to eq(survey_answers_user_2.sort { |answer| answer.question.position })
+  end
+end

data/decidim-surveys/spec/services/decidim/surveys/surveys/survey_user_answer_serializer_spec.rb

@@ -0,0 +1,34 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+module Decidim
+  module Surveys
+    describe SurveyUserAnswersSerializer do
+      let!(:survey) { create(:survey) }
+      let!(:user) { create(:user, organization: survey.feature.organization) }
+      let!(:survey_questions) { create_list :survey_question, 3, survey: survey }
+      let!(:survey_answers) do
+        survey_questions.map do |question|
+          create :survey_answer, survey: survey, question: question, user: user
+        end
+      end
+
+      subject do
+        described_class.new(survey_answers)
+      end
+
+      describe "#serialize" do
+        let(:serialized) { subject.serialize }
+
+        it "includes the answer for each question" do
+          survey_questions.each_with_index do |question, idx|
+            expect(serialized).to include(
+              "#{idx + 1}. #{translated(question.body, locale: I18n.locale)}" => survey_answers[idx].body
+            )
+          end
+        end
+      end
+    end
+  end
+end

data/decidim-surveys/spec/shared/edit_survey_examples.rb

@@ -0,0 +1,213 @@
+# -*- coding: utf-8 -*-
+# frozen_string_literal: true
+
+RSpec.shared_examples "edit surveys" do
+  let(:body) do
+    {
+      en: "This is the first question",
+      ca: "Aquesta es la primera pregunta",
+      es: "Esta es la primera pregunta"
+    }
+  end
+
+  it "updates the survey" do
+    visit_feature_admin
+
+    new_description = {
+      en: "<p>New description</p>",
+      ca: "<p>Nova descripció</p>",
+      es: "<p>Nueva descripción</p>"
+    }
+
+    within "form.edit_survey" do
+      fill_in_i18n_editor(:survey_description, "#survey-description-tabs", new_description)
+      click_button "Save"
+    end
+
+    within ".callout-wrapper" do
+      expect(page).to have_content("successfully")
+    end
+
+    visit_feature
+
+    expect(page).to have_content("New description")
+  end
+
+  context "when the survey is not already answered" do
+    it "adds a few questions to the survey" do
+      visit_feature_admin
+
+      questions_body = [
+        {
+          en: "This is the first question",
+          ca: "Aquesta es la primera pregunta",
+          es: "Esta es la primera pregunta"
+        },
+        {
+          en: "This is the second question",
+          ca: "Aquesta es la segona pregunta",
+          es: "Esta es la segunda pregunta"
+        }
+      ]
+
+      within "form.edit_survey" do
+        2.times { click_button "Add question" }
+
+        expect(page).to have_selector(".survey-question", count: 2)
+
+        page.all(".survey-question").each_with_index do |survey_question, idx|
+          questions_body[idx].each do |locale, value|
+            within survey_question do
+              click_link I18n.with_locale(locale) { I18n.t("name", scope: "locale") }
+              find("input[name='survey[questions][][body_#{locale}]']").send_keys value
+            end
+          end
+        end
+
+        click_button "Save"
+      end
+
+      within ".callout-wrapper" do
+        expect(page).to have_content("successfully")
+      end
+
+      visit_feature_admin
+
+      expect(page).to have_selector("input[value='This is the first question']")
+      expect(page).to have_selector("input[value='This is the second question']")
+    end
+
+    it "adds a question with answer options" do
+      visit_feature_admin
+
+      question_body = {
+        en: "This is the first question",
+        ca: "Aquesta es la primera pregunta",
+        es: "Esta es la primera pregunta"
+      }
+
+      answer_options_body = [
+        {
+          en: "This is the first option",
+          ca: "Aquesta es la primera opció",
+          es: "Esta es la primera opción"
+        },
+        {
+          en: "This is the second option",
+          ca: "Aquesta es la segona opció",
+          es: "Esta es la segunda opción"
+        }
+      ]
+
+      within "form.edit_survey" do
+        click_button "Add question"
+
+        expect(page).to have_selector(".survey-question", count: 1)
+
+        question_body.each do |locale, value|
+          within ".survey-question" do
+            click_link I18n.with_locale(locale) { I18n.t("name", scope: "locale") }
+            find("input[name='survey[questions][][body_#{locale}]']").send_keys value
+          end
+        end
+
+        expect(page).not_to have_content "Add answer option"
+
+        select "Single option", from: "Type"
+
+        expect(page).to have_content "Add answer option"
+
+        2.times { click_button "Add answer option" }
+
+        page.all(".survey-question-answer-option").each_with_index do |survey_question_answer_option, idx|
+          answer_options_body[idx].each do |locale, value|
+            within survey_question_answer_option do
+              click_link I18n.with_locale(locale) { I18n.t("name", scope: "locale") }
+              find("input[name='survey[questions][][answer_options][][body_#{locale}]']").send_keys value
+            end
+          end
+        end
+
+        click_button "Save"
+      end
+
+      within ".callout-wrapper" do
+        expect(page).to have_content("successfully")
+      end
+
+      visit_feature_admin
+
+      expect(page).to have_selector("input[value='This is the first question']")
+      expect(page).to have_selector("input[value='This is the first option']")
+      expect(page).to have_selector("input[value='This is the second option']")
+    end
+
+    describe "when a survey has an existing question" do
+      let!(:survey_question) { create(:survey_question, survey: survey, body: body) }
+
+      it "modifies the question" do
+        visit_feature_admin
+
+        within "form.edit_survey" do
+          expect(page).to have_selector(".survey-question", count: 1)
+
+          within ".survey-question" do
+            fill_in "survey-question-#{survey_question.id}_body_en", with: "Modified question"
+            check "Mandatory"
+            select "Long answer", from: "Type"
+          end
+
+          click_button "Save"
+        end
+
+        within ".callout-wrapper" do
+          expect(page).to have_content("successfully")
+        end
+
+        visit_feature_admin
+
+        expect(page).to have_selector("input[value='Modified question']")
+        expect(page).not_to have_selector("input[value='This is the first question']")
+        expect(page).to have_selector("input#survey_questions_#{survey_question.id}_mandatory[checked]")
+        expect(page).to have_selector("select#survey_questions_#{survey_question.id}_question_type option[value='long_answer'][selected]")
+      end
+
+      it "removes the question" do
+        visit_feature_admin
+
+        within "form.edit_survey" do
+          expect(page).to have_selector(".survey-question", count: 1)
+
+          within ".survey-question" do
+            click_button "Remove question"
+          end
+
+          click_button "Save"
+        end
+
+        within ".callout-wrapper" do
+          expect(page).to have_content("successfully")
+        end
+
+        visit_feature_admin
+
+        within "form.edit_survey" do
+          expect(page).to have_selector(".survey-question", count: 0)
+        end
+      end
+    end
+  end
+
+  context "when the survey is already answered" do
+    let!(:survey_question) { create(:survey_question, survey: survey, body: body) }
+    let!(:survey_answer) { create(:survey_answer, survey: survey, question: survey_question) }
+
+    it "cannot modify survey questions" do
+      visit_feature_admin
+
+      expect(page).not_to have_content("Add question")
+      expect(page).not_to have_content("Remove question")
+      expect(page).to have_selector("input[value='This is the first question'][disabled]")
+    end
+  end
+end